Commit graph

27891 commits

Author SHA1 Message Date
Jordan Borean
9ff26a4a22
psrp - Added proper reconnection variable name (#59369) 2019-07-23 05:55:52 +10:00
PRASOON KARUNAN V
a20afb5822 Add support for test script parameters in win_pester (#58790)
* add parameter list argument

* add tests

* fix test and add doc

* correct test file

* fix typo

* fix tests

* fix typo in file name

* correct file name reverting the previous commit

* correct property name

* add checkmode message

* changes as per review comments

* variable casing and other review comment changes

* define $test_parameters_check_mode_msg variable
2019-07-23 05:46:26 +10:00
Matt Martz
284dafe476
Perfy McPerferton (#58400)
* InventoryManager start of perf improvements

* 0 not 1

* More startswith to [0] improvements

* Remove unused var

* The hash doesn't need to be a string, start as a list, make it into a tuple

* set actually appears faster than frozenset, and these don't need to be frozen

* Cache hosts lists, to avoid extra get_hosts calls, pass to get_vars too

* negligible perf improvement, it could help with memory later

* Try the fast way, fallback to the safe way

* Revert to previous logic, linting fix

* Extend pre-caching to free

* Address test failures

* Hosts are strings

* Fix unit test

* host is a string

* update test assumption

* drop SharedPluginLoaderObj, pre-create a set, instead of 2 comparisons in the list comprehension

* Dedupe code

* Change to _hosts and _hosts_all in get_vars

* Add backwards compat for strategies that don't do set host caches

* Add deprecation message to SharedPluginLoaderObj

* Remove unused SharedPluginLoaderObj import

* Update docs/comments

* Remove debugging

* Indicate what patterh_hash is

* That won't work

* Re-fix tests

* Update _set_hosts_cache to accept the play directly, use without refresh in get_hosts_remaining and get_failed_hosts for backwards compat

* Rename variable to avoid confusion

* On add_host only manipulate _hosts_cache_all

* Add warning docs around _hosts and _hosts_all args
2019-07-22 14:25:20 -05:00
Chris Archibald
6adf0c581e New feature to na_ontap_snapmirror (#59047)
* updates

* updating version added for connection type
2019-07-22 13:46:00 -04:00
Brian Coca
74ac229fa8 fix all cases of none remote/become users (#59397)
some cases failed, when defaults were None on the plugins
2019-07-22 12:24:31 -05:00
Joseph Andreatta
7ee5835821 VMware: vmware_dvs_host: Add vendor_specific_config (#57637)
* Add vendor_specific_config
* Fix documentation typo
* Add example using vendor_specific_config
2019-07-22 22:06:30 +05:30
Chris Archibald
b1360c0d94 bug fixes (#59049) 2019-07-22 11:05:56 -04:00
Trois-Six
6f9f67be18 virt_net: add way to get facts for only one specified network 2019-07-22 16:34:07 +02:00
Eric Anderson
46b821d51f state wasn't a valid value (#59274)
State isn't a valid value for the gcp_compute_address module, remove it from docs example
2019-07-22 09:25:26 -05:00
n3pjk
6531819172 snow: Fix token reference in basic authentication (#59315)
* Fix OAUTHClient logic
* Add Env variable support for snow modules

Fixes: #59299

Signed-off-by: Paul Knight <paul.knight@state.de.us>
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-07-22 19:31:04 +05:30
Evert Mulder
66d12f6f1e Only convert VirtualDiskFix for #57653 clone_with_convert is failing 2019-07-22 12:52:48 +02:00
Martin Krizek
b7868529ee
Revert "Speed up VariableManager by preserving Templar state. (#45572)" (#59280)
This reverts commit 6069d09b9d.

Fixes #57351
2019-07-22 10:27:11 +02:00
Abhijeet Kasurde
791e565802
VMware: Additional testcase for mem_reservation (#59365)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-07-22 10:44:19 +05:30
Tyler Ramer
8d0f2e5725 Address regression causing bootproto=dhcp for manual IP addresses (#56376)
Commit b7724fdf85
appears to have caused a regression, where `ip4`, `gw4`, `ip6`, `gw6`
were converted to `ipv4.address`, `ipv4.gateway` etc.

This causes bootproto (or `ipv4.method`) to remain `dhcp`, as noted in https://github.com/ansible/ansible/issues/36615

This commit only reverts the key-value pairs to the original names,
which is in line with both expectation (manual ip addr == no dhcp) and
the language used in the playbook, which is, for example, "ip4" not
"ipv4.address"

Co-authored-by: Stuart Pollock <spollock@pivotal.io>
Co-authored-by: Tyler Ramer <tramer@pivotal.io>
2019-07-22 09:30:24 +05:30
Klaus Frank
252d1b7e95 VMware Tools Connector does not support pipelining (#57237) 2019-07-22 09:27:00 +05:30
Abhijeet Kasurde
1f49abb51c
VMware: Accept 0 as valid value for memory reservation (#59230)
vmware_guest accepts 0MB as valid value for memory reservation in
virtual machine hardware configuration. This fixes the regression
introduced via 193f69064f.

Fixes: #59190

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-07-22 09:03:25 +05:30
Xu Yuandong
c8697a4864 ce_switchport: add link-type hybrid and dot1qtunnel to mode. and fix bugs. (#59332)
* add link-type hybrid and dot1qtunnel to mode.and fix bugs.

* add verstion_add option for doc.

* update for shippable:E319.

* Update ce_switchport.py
2019-07-21 23:07:09 -04:00
Mark McKinstry
db95ff4823 update documentation for dictionaries (#59354)
it has been fixed if using 0.9.0 or newer

ref https://github.com/ansible/ansible/pull/49053#issuecomment-511073083
2019-07-22 09:43:43 +10:00
Jordan Borean
2f2b106423
Fix win_reg_stat for HKU hives (#59359) 2019-07-22 09:12:14 +10:00
Micah Hunsberger
74598b212e win_hosts to use Ansible.Basic CSharp Util and better diff support (#58600)
* switch win_hosts to use csharp util

* update win_hosts doc to match doc guide

* changed linking format for option values
2019-07-22 09:08:36 +10:00
Jordan Borean
015119df8c
Windows - Add common util for web requests (#54759)
* Windows - Add common util for web requests

* Use different method of retrieving options from module arg spec

* Added proper version_added for module options

* Fix linting errors

* Fix proxy issues and updated cred docs

* Fix FTP usage with proxy settings

* Removed uneeded function added in bad rebase

* Fix up client certificate auth

* fix new sanity checks

* Edit http agent code and update porting guide
2019-07-22 08:42:24 +10:00
Jordan Borean
1f3a3fdd3e
win_firewall_rule - removed deprecated force option (#59358) 2019-07-22 08:24:57 +10:00
maletin
883cc665e3 parameter ensure replaced by state (#59342)
corrected a typo at the absent-example.
2019-07-21 04:26:07 -04:00
Chris Archibald
f8c278e210 add dns info to gather facts (#59145)
* add dns info

* fix doc fragment

* Revert "fix doc fragment"

This reverts commit 8f08ac192e.
2019-07-19 18:30:30 -04:00
The Magician
e7fba5cea0 New Module: gcp_mlengine_version (#59224) 2019-07-19 16:52:40 -04:00
The Magician
5b0214bcce New Module: gcp_appengine_firewall_rule (#58852) 2019-07-19 16:42:37 -04:00
The Magician
40ff1949fb New Module: gcp_mlengine_model (#59222) 2019-07-19 16:41:07 -04:00
Sam Doran
8edad83ae0
User - make groups and append mutually exclusive with local (#59309)
* Update intigration tests
2019-07-19 16:05:15 -04:00
The Magician
5c6aa9b9e8 Bug fixes for GCP (as of 2019-07-09T06:06:53Z) (#59171)
* Bug fixes for GCP modules

* ignore syntax
2019-07-19 11:33:47 -07:00
The Magician
c5e26ab4da Bug fixes for GCP (as of 2019-07-09T06:06:53Z) (#59172)
* Bug fixes for GCP modules

* ignore syntax
2019-07-19 11:33:04 -07:00
The Magician
b75e8d19be Bug fixes for GCP (as of 2019-07-09T06:06:53Z) (#59132)
* Bug fixes for GCP modules

* ignore syntax
2019-07-19 11:32:05 -07:00
Felix Fontein
4a574c4d0c Option parsing: warn if both an option and its alias are specified for a module (#53698)
* Print warning when both an option and its alias is specified.

* Improve output.

* Put warnings into self._warnings directly, resp. use self.warn() when handling subspecs.

* Add changelog.

* Add unit test.
2019-07-19 13:11:41 -04:00
Sam Doran
f231f21669
Handle situation where ansible_architecure may not be defined when gathering facts (#55466) 2019-07-19 11:33:05 -04:00
Nilashish Chakraborty
bb006db7c8
Add exclusive configuration mode support (#59289)
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
2019-07-19 19:03:35 +05:30
Abhijeet Kasurde
4b152235ff
Typo fixes (#59227)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-07-19 18:18:14 +05:30
Raul Mahiques
fd2116e26a Added state "remount" which will remount the device (#52649) 2019-07-19 08:59:27 +02:00
Martin Krizek
a752e2a467
Clear 'connection related' plugin vars for next loop iteration (#59024)
Fixes #58876
2019-07-19 08:39:05 +02:00
Denis Afonso
da047eec59 cloudformation_facts: Fixes PhysicalResourceId KeyError(#55990)
Fixes: #38033
2019-07-19 10:51:54 +05:30
yanzhangi
e7c9c9585e update ce_vrrp to fix a bug (#59185)
* update ce_vrrp to fix a bug

* update module ce_vrrp 20190718

* update ce_vrrp to fix bugs
2019-07-18 21:33:19 -04:00
Pedro Magalhães
c010a6d288 Fix maven_artifact.py when your maven is behind a cloudflare (#53495)
Cloudflare has a feature that checks Browser Integrity Check, when the user agent is not present, it can fail on BIC.

Since we are defining the default value of variable "self.module.params['http_agent']" to None, this will cause that
User-Agent header will not be added, because of the conditional if present on module_utils/urls.py [1]

[1] https://github.com/ansible/ansible/blob/devel/lib/ansible/module_utils/urls.py#L1135-L1136

This fix will ensure that the "self.module.params['http_agent']" will be defined

URLs:
https://support.cloudflare.com/hc/en-us/articles/200171806-Error-1010-The-owner-of-this-website-has-banned-your-access-based-on-your-browser-s-signature
https://support.cloudflare.com/hc/en-us/articles/200170086-What-does-the-Browser-Integrity-Check-do-
2019-07-18 18:55:36 -04:00
Simon Dodsley
4acbb83c84 Add checks for VG and Pod existence when creating volume (#58857) 2019-07-18 18:11:06 -04:00
Simon Dodsley
a1220268b2 Add new facts for Pure Storage FlashArray (#58894)
* Update purefa_facts module to support NVMe and preferred arrays

* Update purefa_facts with new information available from array
2019-07-18 17:46:19 -04:00
Simon Dodsley
aeb0245ebd Add check for correct API version before trying to execute (#59205) 2019-07-18 17:17:31 -04:00
The Magician
5f222c478d Bug fixes for GCP modules (#59130) 2019-07-18 16:41:45 -04:00
The Magician
6128d0cd8b New Module: gcp_mlengine_model_facts (#59223) 2019-07-18 16:39:57 -04:00
The Magician
de92ea6b3d New Module: gcp_mlengine_version_facts (#59225) 2019-07-18 16:39:48 -04:00
Aljaž Košir
42073b6331 Add lambda_bucket_event module (#58059) 2019-07-18 10:54:01 -07:00
pratikgadiya12
393e4a41d0 Added support to create and delete multiple databases in MySQL (#58602)
* Added support to create/delete mulitiple databases in MySQL

Fixes: #58370

* Added additional tests cases and fixed documentation changes

* Code refactoring and added tests for better test coverage

- Removed db_exists usage from most of the code. Used existence_list
 and non_existence_list instead

- Added additional tests to cover all scenarios w.r.t creation and deletion
 on multiple databases

- Added tests for dump operations

* Minor fix

* Minor fix - create check mode test

* Added dump tests for better dump tests coverage

* Removed minor database connection details

* fixed error

* Added test case for import operations

* Code refactoring and review fixes

- Added dump all test case

* Fixed review comments

* Minor review comment fixes

* Altered db_create return value

* Removed db_list and altered "does exist" to just "exist"

* Kept db and db_list in module.exit_json

* Refactored tests

- Added removal of dump2 file

* Moved import tests to state_dump_import file

* Removed import tests from multi_db_create_delete

* Updated porting guide, added RETURN block

* Minor identation fix

* Added validation to check if databases are dumped
2019-07-18 16:56:32 +02:00
Felix Fontein
cdf0947df0
Fix typo in import package name. (#59229) 2019-07-18 16:54:33 +02:00
Hannes Ljungberg
0e8eb1d17f pip: Remove unused option use_mirrors and remove all ignore.txt entries
PR #58977

* Remove unused option use_mirrors

* Add changelog fragment
2019-07-18 16:38:37 +02:00