Commit graph

4179 commits

Author SHA1 Message Date
Bruce Pennypacker
b57887bafd Fix for https://github.com/ansible/ansible/issues/7054 - when renaming an instance and waiting for the change to occur, force result.id to the name of the new instance so the subsequent call to get_current_resource succeeds. 2014-04-18 17:56:11 +00:00
Michael Heca
4271613aa5 module docker_image - default tag latest
Fix constant rebuild of image if no tag specified.
2014-04-18 16:14:12 +02:00
Mike Buzzetti
5dada9403e Adds support for VPC subnets to ELB 2014-04-18 09:59:35 -04:00
Joshua Conner
4defd9a15a docker: exclude 'entrypoint' from comparing 'command' param with containers
The JSON the Docker API returns includes the container's ENTRYPOINT value (if it has one) with the 'Command' value. So instead of checking if `container['Command'] == module.params['command']`, we just check that `container['Command'].endswith(module.params['command'])` so the entrypoint won't affect a container being properly classified as matching the module params or not.

Also I refactored a super-long `if` statement into some temporary variables - I did it to help me figure out what was going wrong, and then it makes the code more readable so I kept it.
2014-04-17 16:10:53 -07:00
Joshua Conner
10171dc42b docker: send 1.10 params if docker-py is new enough version 2014-04-17 16:05:50 -07:00
James Cammarata
1ef0402f03 Make sure a default allow out rule exists if no other egress rules do
Fixes #7027
2014-04-17 15:24:18 -05:00
Chad Nelson
ef1a8e4cdd Only update submodules when recursive is true 2014-04-17 09:34:36 -04:00
Andreas Fleig
337a0059d9 apt_key: fix key lookup for 64 bit key ids
Fixes #7018 by extending `all_keys` to work with either short or long keys.

Also removes the ununsed method `key_present`.
2014-04-17 03:51:19 +02:00
Matt Bray
3948dc2d1d docker.client.APIError has moved to docker.errors.APIError
see 18d4db09ec
2014-04-16 23:42:56 +01:00
James Cammarata
a37a84243b Check resource_tags value before using it in ec2_vpc
Fixes #7024
2014-04-16 12:21:32 -05:00
Brian Brazil
8ec400669f Fix race conditions where a process gets in state "Running"
between the restart/start command and the summary command.

Refactor to avoid repeating the status, and fail if a given call to monit fails.
2014-04-16 18:04:19 +01:00
James Cammarata
f9eb0ba4ad Merge branch 'devel' of https://github.com/evanccopengeo/ansible into evanccopengeo-devel 2014-04-16 10:24:39 -05:00
jjshoe
5258f75789 apt_key lists all keys in uppercase
allow for a little user error
2014-04-16 10:06:59 -05:00
Michael Heca
a1706e6411 module replace - report changed only if contents is changed 2014-04-16 09:25:56 +02:00
Hernandes B. de Sousa
202fc57253 Add missing info for the append option
Both 'default' and 'choices' options were missing at the documentation.
2014-04-16 01:22:12 -03:00
James Cammarata
e8b33636ae Get the bin path for commands in the unarchive module
Fixes #6927
2014-04-15 20:39:22 -05:00
evanccopengeo
ac64f3c8cf cleaning up the code a bit more 2014-04-15 18:16:34 -04:00
evanccopengeo
88b30a74d2 fixing bug where if both private_ip and assign_public_p are set ansible fails out 2014-04-15 17:55:26 -04:00
James Cammarata
f547733b1f Check to make sure the firewalld client is connected before proceeding
Fixes #6911
2014-04-15 15:03:52 -05:00
Cédric RICARD
3384021fe6 Fixed test on 'cached' parameter.
'cached' parameter is boolean, not string
2014-04-15 16:41:27 +02:00
Joshua Conner
0ef288dcc8 Docker: don't send wrong parameters to client.start()
As part of being updated for the 1.10 API, a couple of parameters were passed to the docker.client.start() command that it doesn't accept. This caused the module to error out if it tried to start any Docker containers. This removes those parameters so the module works again.
2014-04-14 15:05:42 -07:00
James Tanner
6ec0e25d1a Addresses #6908 Add a mode parameter to apt_repository 2014-04-14 16:42:23 -04:00
James Tanner
28cb4756c4 Remove debug line 2014-04-14 16:02:08 -04:00
James Tanner
db36c41c3b Addresses #6908 Strip usernames and passwords from apt_repository filenames 2014-04-14 13:18:21 -04:00
James Cammarata
46ea3155c6 Ensure params were set in ec2_vpc before accessing them
Fixes #6763
2014-04-14 10:58:07 -05:00
Michael DeHaan
537320774a Merge pull request #6952 from nousdefions/devel
Added example demonstrating other functionality
2014-04-14 11:32:44 -04:00
Michael DeHaan
bc2b4174a5 Merge pull request #6956 from mattjbray/docker-1-10-volumes-from-dns
docker: from API 1.10 dns and volumes_from should be passed to start()
2014-04-14 11:29:10 -04:00
Ben Whaley
6c10297b2d Stackdriver code deploy and annotation module 2014-04-12 00:56:32 +00:00
Michael J. Schultz
db92301b00 cloud/elasticache: Ensure self.data is iterable
- self.data['SecurityGroups'] can return None causing traceback, if that
  is the case fallback to an empty list
2014-04-11 18:23:53 -05:00
Matt Bray
71b5a11735 docker: from API 1.10 dns and volumes_from should be passed to start() 2014-04-11 17:08:55 +01:00
James Tanner
b0556ab1fb Addresses #6702 Remove version_added from description string 2014-04-11 11:18:05 -04:00
Jonathan Davila
6a6ade830e Added example demonstrating other functionality 2014-04-11 11:14:40 -04:00
James Tanner
42fbbd0502 Addresses #6702 set version_added for rsync_opts 2014-04-11 11:04:05 -04:00
jctanner
bb3ce0c744 Merge pull request #6702 from jjshoe/devel
Allow you to pass in arbitrary rsync options
2014-04-11 10:43:14 -04:00
James Tanner
dfdc3b82a0 Fixes #6929 remote file module doc fragments from copy and template 2014-04-10 16:06:35 -04:00
Eugene Brevdo
8e32f54223 VPC security group membership fix for boto.
* facts now provides a list of existing vpc security group memberships
* adding a comma separated list of sg-* tags properly modifies membership
2014-04-09 13:32:47 -07:00
Will Thames
e7b275483c Use common code for ec2_elb and ec2_elb_lb
Uses the new get_aws_connection_info
and connect_to_aws common methods to reuse code

Now complains if region is not set in one of the
three possible methods

Also moved over to common documentation code so
this is actually based on #6913
2014-04-09 22:47:51 +10:00
willthames
509561f658 Moved AWS modules over to common module fragments
Created common module doc fragment, and applied to all
modules that use ec2_connect or connect_to_aws as
they definitely share the common doc fragments
2014-04-09 21:19:12 +10:00
James Tanner
68cd7258b6 Fixes #6894 create docs fragment for files 2014-04-08 13:20:15 -04:00
James Tanner
899ba4c9bb Fixes syntax error in cron module caused by #6870 2014-04-08 12:53:56 -04:00
James Cammarata
26ce8dac27 Fix incorrect version_added value in docstring for subversion export param 2014-04-08 10:26:12 -05:00
James Tanner
6d54eae96a Fix version_added for node in rabbitmq modules 2014-04-08 10:40:41 -04:00
James Tanner
7c9243eacf Fix version added for new parameters in quantum modules 2014-04-08 10:32:53 -04:00
James Tanner
c29cca6f86 Fix version added for annotation in pkgng 2014-04-08 10:28:01 -04:00
James Tanner
db90f308ca Fix version_added for login_tenant_name in keystone_user 2014-04-08 10:25:44 -04:00
James Tanner
5308c5dbdf Fix version_added for install_options in homebrew 2014-04-08 10:13:33 -04:00
James Tanner
03f99a57b7 Fix version_added for new params in gce_pd 2014-04-08 10:05:57 -04:00
James Tanner
d37f609e00 Fix version_added for new params in gce_net 2014-04-08 10:03:56 -04:00
James Tanner
387414fe29 Fix version_added for new params in gce_lb 2014-04-08 10:00:30 -04:00
James Tanner
34648426ba Set version_added for snapshot in ec2_vol 2014-04-07 23:10:24 -04:00
James Tanner
66747529a6 Fix version_added for a few parameters in django_manage 2014-04-07 22:57:49 -04:00
James Tanner
325bbf7dee Fix version_added for url in airbrake_deployment module 2014-04-07 22:30:53 -04:00
Michael DeHaan
dfa8aef408 Merge pull request #6850 from atlashealth/ec2_set_ebs_optimized
ec2: added ability to set EBS optimized instances
2014-04-07 15:57:34 -04:00
Michael DeHaan
cd1cd2060b Merge pull request #6869 from cove/mongodb_user
add replica_set attr to mongodb_user module
2014-04-07 13:57:28 -04:00
Michael DeHaan
3f89c3a3cc Merge pull request #6883 from ericlake/devel
Adding bold to service doc to call up state and enabled.
2014-04-07 13:39:28 -04:00
James Tanner
b2701d0d76 Fixes #6780 Update version_added for source_dest_check in ec2 module 2014-04-07 12:44:34 -04:00
James Cammarata
b73cddc485 Revert "Fix #5679 again after recent changes in core"
This reverts commit 2bfaacd170.

Fixes #6821
2014-04-07 09:55:59 -05:00
Eric Lake
e84291d717 Adding bold to service doc to call up state and enabled. 2014-04-07 09:37:15 -05:00
James Cammarata
085d9aee72 Merge branch 'rax-clb-nodes-nodeid' of https://github.com/sivel/ansible into sivel-rax-clb-nodes-nodeid 2014-04-07 07:40:05 -05:00
Matt Martz
8a98773089 Simplify node matching 2014-04-06 19:17:13 -05:00
Atlas Health
97a7df7644 moved ebs_optimized param out of main request hash 2014-04-06 15:35:22 -07:00
MorrisA
4dc46e9061 Modified Cron to add AIX Crontab support, changed according to suggestions
from mpdehaan and redone entirely.
2014-04-05 18:10:45 -07:00
Cove Schneider
6a321fe346 re-add idempotency check 2014-04-05 16:31:33 -07:00
Cove Schneider
6e81f41cd4 add replicaset support to mongodb_user module 2014-04-05 15:33:22 -07:00
Michael DeHaan
4d2b7d6341 Merge pull request #6864 from sivel/rax-add-shared-mod-docs
Shared module docs for remaining rax modules
2014-04-05 15:16:11 -04:00
James Tanner
036c8193b7 Fixes #6857 Make the url parameter required for get_url 2014-04-04 16:36:38 -04:00
Matt Martz
55a26fa9ed Shared module docs for remaining rax modules 2014-04-04 13:02:49 -05:00
Matt Martz
e821770505 Allow respecification of a node without requiring node_id 2014-04-04 12:41:57 -05:00
Michael DeHaan
466ab0a9d6 Merge pull request #6852 from tedder/patch-1
cloudformation's disable_rollback must be a bool
2014-04-04 12:14:03 -04:00
Ted Timmons
d544eb3e3b cloudformation's disable_rollback must be a bool
passing "yes" to boto causes severe problems.
2014-04-04 08:00:56 -07:00
Drew Blas
2e26549426 Update apt:deb with correct version
The docs site says this option is available in 1.5, but it is not.  

#5910 https://github.com/ansible/ansible/pull/5910 added the deb option.  The PR was generated two months ago (before 1.5) but was not included until after 1.5 was released.  This fixes the docs.
2014-04-04 05:59:57 -05:00
Michael DeHaan
621fcbb9de Name is not required, update docs. 2014-04-03 18:03:13 -04:00
Michael DeHaan
2518ec2b86 Merge pull request #6849 from atlashealth/ec2_snapshot_fixed_type_issue
ec2_snapshot: fix for "unknown type number requested for wait_timeout"
2014-04-03 18:01:22 -04:00
Michael DeHaan
b4c500634d Merge pull request #6793 from muffl0n/patch-4
apt_key: Output URL for debugging
2014-04-03 17:35:49 -04:00
Michael DeHaan
051d57caeb Clarify free_form isn't a real option :) 2014-04-03 17:34:33 -04:00
Richard C Isaacson
dc93b31d22 assemble module: fix insertion of newlines when not needed.
This builds on GH-6359 and changes the logic so that a newline is only inserted between fragments if the previous fragment does not end with a newline.
2014-04-03 16:32:35 -05:00
Peter Gehres
3ac731087c Fix for #6353 adding a newline between assembled files 2014-04-03 16:32:35 -05:00
Matt Martz
37f096a6bb rax modules improvements
* Catch issues with invalid regions
* Ensure we send string only data as meta values in the rax module
* Add public_key/lookup example for rax_keypair
* Clean up import statements
2014-04-03 17:16:24 -04:00
Michael DeHaan
1fa19e29e8 Use common file argument system previously implemented by @sivel for rax modules on the file modules as well (copy/file/template).
Application to other cloud providers would make very good sense.
2014-04-03 16:52:39 -04:00
Matt Martz
7b5f89ec7c Use PluginLoader for module docs fragments 2014-04-03 16:52:39 -04:00
Matt Martz
bb6f7a267a Add support for shared module documentation fragments 2014-04-03 16:52:39 -04:00
Atlas Health
2657bbcefa ec2: added ability to set EBS optimized instances
added version
2014-04-03 12:38:43 -07:00
James Tanner
1c9950678a Addresses #6750 Use --help instead of - 2014-04-03 15:26:48 -04:00
Atlas Health
7321e23b31 fixed error related to type being defined as a number 2014-04-03 12:24:05 -07:00
James Tanner
cca028187e Fixes #6750 Check git subcommand for --remote and expose errors 2014-04-03 15:21:54 -04:00
James Tanner
b660062801 Fixes #6454 verify ec2 key fingerprints 2014-04-03 13:53:43 -04:00
Gael Pasgrimaud
1fc4b89e64 Fix a typo in the subversion module documentation 2014-04-03 14:34:43 +02:00
Michael DeHaan
2fd6d16f99 Merge pull request #6831 from aresch/patch-1
Fix _parse_value always returning 0 when not true, false or None.
2014-04-02 20:09:41 -04:00
Michael DeHaan
7db7e86db9 Merge pull request #6830 from angstwad/cf-fix
rax_files fix -- small idempotency fix
2014-04-02 19:18:42 -04:00
Paul Durivage
3763b32f86 Fix issue where a container is created but is not indicating that the state was changed 2014-04-02 18:05:36 -05:00
Andrew Resch
cd12d8a917 Fix _parse_value always returning 0 when not true, false or None. 2014-04-02 15:59:05 -07:00
Joshua Lund
79c245f31f Update cron module documentation. The 'name' parameter is required. 2014-04-02 16:41:09 -06:00
Michael DeHaan
90c137dea3 Slightly revise wording. 2014-04-02 17:43:40 -04:00
Michael DeHaan
dff5368e43 Merge branch 'authorized_key-manage_dir' of git://github.com/tyll/ansible into devel 2014-04-02 17:42:24 -04:00
Michael DeHaan
a4bce09ad1 Clarify docs message. 2014-04-02 17:37:10 -04:00
Michael DeHaan
19437aad0b Merge pull request #6798 from follower/patch-5
Clarify the port value always defaults to 3306
2014-04-02 17:34:33 -04:00
Michael DeHaan
18b713fd74 Example cleanup. 2014-04-02 17:32:44 -04:00
Michael DeHaan
5269216c41 Merge branch 'patch-3' of git://github.com/muffl0n/ansible into devel 2014-04-02 17:30:29 -04:00
Michael DeHaan
0981e405d6 Merge pull request #6810 from bob-smith/debconf-text
debconf detail requirements and fix typos
2014-04-02 17:25:22 -04:00
Michael DeHaan
0125f36c49 Merge pull request #6796 from mistaka0s/mysqldump_fix
Remove extra quote from the mysqldump password argument
2014-04-02 17:24:35 -04:00
Michael DeHaan
12022233f4 Merge pull request #6770 from lemonlatte/fix_default_uri_of_get_xml
Fix the default url of get_xml function.
2014-04-02 17:23:22 -04:00
Michael DeHaan
3ba01cac3c Note that keyserver was added in 1.6 2014-04-02 17:18:14 -04:00
James Cammarata
eb15d2f6fe Fix issue with sysctl parameter parsing introduced by 0e8c7b1
Fixes #6806
2014-04-02 15:26:02 -05:00
Michael DeHaan
71061479a0 Merge pull request #6826 from bob-smith/debconf-parsing
debconf correctly quote strings
2014-04-02 16:14:17 -04:00
James Cammarata
684d46b170 Fixing some parsing issues in authorized_key module
Also adds an integration test for authorized_key for future validation.

Fixes #6700
2014-04-02 15:02:54 -05:00
John Barker
b8efbb1cb3 debconf correctly quote strings 2014-04-02 20:43:12 +01:00
Michael DeHaan
f50a943064 Merge pull request #6803 from aresch/patch-1
redhat_subscription calls AnsibleModule() without argument_spec
2014-04-02 11:40:57 -04:00
Oleg A. Mamontov
933fb349f1 Fixed cwd for submodules update 2014-04-02 13:21:26 +04:00
James Cammarata
ba4838cde5 Adding wait/wait_timeout parameters to the ec2_key module
Fixes #6455
2014-04-01 22:14:35 -05:00
John Barker
f89262c74f debconf detail requirements and fix typos 2014-04-01 21:51:12 +01:00
jctanner
6a1dcca4be Merge pull request #6805 from sivel/env-interpreter-fix
Fix interpreter lines in a couple of modules
2014-04-01 15:03:20 -04:00
Matt Martz
b4de76373a Use /usr/bin/python instead of /usr/bin/env python 2014-04-01 13:54:37 -05:00
Andrew Resch
c92ec68fa3 redhat_subscription calls AnsibleModule() without argument_spec
The Rhsm object requires an AnsibleModule but it isn't created with an argument_spec and fails.  Since the rhn.module is set directly after, setting None for the required argument of Rhsm fixes the module.
2014-04-01 11:22:29 -07:00
follower
4be010b09b Clarify the port value always defaults to 3306
While the [boto docs](https://github.com/boto/boto/blob/develop/boto/rds/__init__.py#L253) make it seem like the default value of `port` is changed depending on the engine chosen, AFAICT from looking at the code the default value is never changed from 3306.

I think the docs are intended to be read as "the default value used by <engine> is <port> so you should change `port` to that value".

If you don't specify the port value and chose the database engine as PostgreSQL you'll end up with a PostgreSQL instance running on port 3306.
2014-04-02 02:25:14 +13:00
Chao Luan
134c449cf6 Remove extra quote from the mysqldump password argument
The mysqldb Ansible module will fail if the state specified is import or dump with a '1045: Access Denied' mysql error for complex passwords.

This is caused by the extra quote around the '--password' argument to mysqldump, as pipes.quotes already quotes the password string.

>>> "--password='%s'" % pipes.quote('simple')
"--password='simple'"

>>> "--password='%s'" % pipes.quote('c0mplexp@ssword!')
"--password=''c0mplexp@ssword!''"

>>> "--password='%s'" % pipes.quote('password with space')
"--password=''password with space''"
2014-04-01 23:52:08 +11:00
jjshoe
2387f044e4 module_retention isn't defined anywhere, including the help. 2014-04-01 07:49:51 -05:00
follower
618554ad63 Make vpc_security_group docs more accurate
Without the `subnet` parameter supplied there's an error `msg: Parameter vpc_security_groups invalid for create command`. (This might be a bug?)

If the VPC security group name rather than ID is supplied there's an error: `msg: Invalid security group , groupId= <some group name>, groupName=.` (Accepting a group name might be a feature enhancement.)

In my case I set the subnet as `default` and used `register` to get the result of the security group creation section and just referred to its `group_id` property.
2014-04-02 01:06:45 +13:00
Sven Schliesing
c8e80b2aa4 Output URL for debugging 2014-04-01 13:55:58 +02:00
James Tanner
c751168895 Fix merge conflicts 2014-03-31 13:15:21 -04:00
James Tanner
9fe2bcd076 Merge #5903 from rhaido/ansible
Update files documentation for usage of force=True and hardlinks
2014-03-31 12:53:03 -04:00
Michael DeHaan
9ca9b9fe07 Merge pull request #6768 from mscherer/fix_typo_caps
fix typo in the capabilities module description
2014-03-31 09:34:25 -04:00
Sven Schliesing
fb10ca73dc Update uri 2014-03-31 14:32:56 +02:00
Sven Schliesing
d6943e46ef Example for queueing build in Jenkins 2014-03-31 14:32:07 +02:00
James Cammarata
225eca6311 Adding an options sections to the docstring in the lldp module 2014-03-30 23:08:53 -05:00
Jim Yeh
48dc27ea74 Fix the default url of get_xml function.
* This enable a user to configure uri in get_xml function
2014-03-31 11:05:31 +08:00
James Tanner
6792c76c50 Fix librato_annotation docstring 2014-03-30 22:28:31 -04:00
Michael Scherer
2dc3153330 fix typo in the capabilities module description 2014-03-30 22:33:24 +02:00
Matt Way
034ac93ca2 don't parse empty stream chunks 2014-03-30 15:27:29 -04:00
James Laska
f96618c967 Use proper YAML quotes to fix webdocs 2014-03-30 14:26:18 -04:00
Michael DeHaan
2f75662a47 Merge pull request #6758 from cgtx/devel
backreferences should be double escaped
2014-03-30 11:59:06 -04:00
James Cammarata
1b3f77fafd Merge pull request #6759 from Malvineous/devel
More descriptive error message if init system is unknown
2014-03-30 01:37:17 -05:00
James Cammarata
6e809c2be3 Removing wait loop around initial state check during registration
Also fixed a bug in which the state parameter was marked as a 'bool'
type, which was breaking execution of the module.

Fixes #6543
2014-03-29 23:47:11 -05:00
Adam Nielsen
1a9c5947ed More descriptive error message if init system is unknown 2014-03-30 11:46:13 +10:00
James Laska
6c8d8a746f Fix YAML docstring that broke webdocs 2014-03-29 19:15:42 -04:00
cgtx
f6abc17e8a backreferences should be double escaped 2014-03-29 18:14:56 -05:00
Ahti Kitsik
e0f3105ef9 Bugfix for ufw to support "logging" properly:
It's a separate parameter so updated docs and set it as mutually exclusive param.
Also due to an array construction typo it was not working in any situation (ufw LOGLEVEL was passed to cmd instead of ufw logging LOGLEVEL).

Also fixed doc and parameters parsing typo ("choises" should be "choices")
2014-03-29 11:06:51 +02:00
Daniel Jaouen
7f6d2a94af Miscellaneous fixes to homebrew module. 2014-03-28 19:37:05 -04:00
Daniel Jaouen
6412bdf003 Update homebrew module. 2014-03-28 19:20:51 -04:00
Michael DeHaan
4dc598049e Merge pull request #6746 from Jmainguy/svr4pkg
svr4pkg changes - Did my best to rebase. Now includes the latest changes made to devel, al...
2014-03-28 18:50:29 -04:00
Michael DeHaan
6c6523aa1b Merge pull request #6747 from ciupicri/cloud-bugfix
Bugfix for gc_storage and s3
2014-03-28 18:48:14 -04:00
Michael DeHaan
c308b98742 Merge branch 'intellectronica/non-recursive-git' of git://github.com/intellectronica/ansible into devel
Conflicts:
	library/source_control/git
2014-03-28 17:49:02 -04:00
Michael DeHaan
ae1b183855 Add LLDP module 2014-03-28 17:41:58 -04:00
Andy Hill
5b5f2e6d45 lldp: Added EXAMPLES 2014-03-28 17:41:58 -04:00
Andy Hill
8ca70ec487 lldp support in Ansible
This PR introduces support for a lldp module.

lldpd is similar to CDP and can return useful details about a server's network like ports, switches, and VLANs.
2014-03-28 17:41:58 -04:00
Michael DeHaan
c24d4acb2a Documentation fixes + add missing license header 2014-03-28 17:20:20 -04:00
Seth Edwards
cb97599a97 add librato annotation module 2014-03-28 17:20:20 -04:00
Michael DeHaan
2d116aca5e Add version_added info + changelog 2014-03-28 17:11:21 -04:00
Christian Berendt
9a1c1d3242 use module.get_bin_path() for a2enmod 2014-03-28 17:10:15 -04:00
Christian Berendt
b8a8e9fbec removed duplicated <<INCLUDE_ANSIBLE_MODULE_COMMON>> line 2014-03-28 17:10:15 -04:00
Christian Berendt
c958c301ae added module to enable/disable Apache2 modules
This module uses a2enmod or a2dismod to enable or disable
Apache2 modules.
2014-03-28 17:10:15 -04:00