Commit graph

34750 commits

Author SHA1 Message Date
Sloane Hertel
d877c146ab [cloud] ec2_group fix CIDR with host bits set - fixes #25403 (#29605)
* WIP adds network subnetting functions

* adds functions to convert between netmask and masklen
* adds functions to verify netmask and masklen
* adds function to dtermine network and subnet from address / mask pair

* network_common: add a function to get the first 48 bits in a IPv6 address.

ec2_group: only use network bits of a CIDR.

* Add tests for CIDRs with host bits set.

* ec2_group: add warning if CIDR isn't the networking address.

* Fix pep8.

* Improve wording.

* fix import for network utils

* Update tests to use pytest instead of unittest

* add test for to_ipv6_network()

* Fix PEP8
2017-12-20 14:57:47 -05:00
Nathaniel Case
5f215337c9
Swap how become is specified for ios integration tests (#34107) 2017-12-20 14:05:16 -05:00
Andy Hill
427479ae48 remove andyhky from maintainers (#34096)
* remove andyhky from maintainers

I'm no longer able to contribute to ansible.

* Explicitly ignore andyhky for modules with that user as an author
2017-12-20 12:48:41 -06:00
kalimsshar
4086cb4b25 Added support for Cisco stacks in ios_facts.py (#33714) 2017-12-20 12:33:47 -05:00
Nathaniel Case
2e76c89910
IOS XR cli tests move to network_cli (#34007)
* Update task definitions for network_cli

* Add connection to debug messages

* Specify connection for prepare task

* pc won't be around for connection=network_cli

* Assorted Python 3 fixes

* Give default port if ansible_ssh_port missing

* delegate -> connection

* Extend error regex
2017-12-20 11:26:09 -05:00
Abhijeet Kasurde
5db9ac23ee
freeipa: Refactor ipa_dnszone (#34078)
Code refactoring of ipa_dnszone module
- use ipa_argument_spec
- use common documentation fragment

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2017-12-20 21:29:52 +05:30
John R Barker
c50da48049
Fix various RST warnings (#34084)
* Fix various RST warnings

* shorter lines
2017-12-20 15:20:05 +00:00
John R Barker
20174f1c47 Suggest using replace module rather than command sed (#34085)
* Suggest using replace module rather than command sed

* Better order
2017-12-20 10:00:32 -05:00
Ryan S. Brown
339278fa15 Add new module aws_direct_connect_gateway to CHANGELOG 2017-12-20 09:57:55 -05:00
Kim Egede Jakobsen
fd2150f9fa Typo fix (#34088) 2017-12-20 14:53:17 +00:00
Pilou
4713d9ea44 ce_file_copy: fix broken import (#34023)
* fix broken import

* doc: use formatting functions
2017-12-20 14:44:01 +00:00
Trishna Guha
663f8464ee
eos_linkagg DI module (#33007)
* eos_linkagg DI module

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* integration test

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* pep8 fixes

* Push fix for Qalthos's comment

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2017-12-20 19:43:30 +05:30
Nathaniel Case
cb1b705218
ios integration tests to network_cli (#33920)
* Preliminary steps

* Fix Python3 network_cli ios

* Add connection to debug strings

* Fix ios confirm prompt by way of optional newline

Also update ios_user delete tests
2017-12-20 09:03:29 -05:00
Abhijeet Kasurde
8d5c8b252d
VMware: Add support for cpuHotRemoveEnabled (#33962)
This fix adds support for cpuHotRemoveEnabled in vmware_guest module.

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2017-12-20 19:15:55 +05:30
Marc Tschapek
c3952e928f changelog: add new module win_disk_facts (#34087) 2017-12-20 14:19:40 +01:00
René Moser
09edb032d3
vultr: new module vr_firewall_rule (#32637)
* vultr: new module vr_firewall_rule

* vr_firewall_rule: fix typo

* fix styles
2017-12-20 13:42:21 +01:00
René Moser
acfa8d8b75
vultr: new module vr_ssh_key (#30961) 2017-12-20 13:41:33 +01:00
René Moser
73ddecd819
vultr: new module vr_firewall_group (#30960) 2017-12-20 13:41:07 +01:00
René Moser
cfd7325ac4
vultr: new module vr_server (#30869)
* vultr: new module vr_server

* minor restyling

* fix method name
2017-12-20 13:40:33 +01:00
Marc Tschapek
b3ff93e129 Added new module win_disk_facts (#32935)
* Added module new win_disk_facts

* Corrected examples section

* Added integration tests

* Added some disk properties

* Removed whitspaces

* Extended docu

* Changed header

* Added partition, volume and physical disk output

* Removed MediaType property of phys. disk

* Added return values

Added virtual disk, volume and physical disk output

* Added docu for return values

* Removed whitespaces

* Improved and added values

- Added virtual disk return values
- Improved code

* Updated docu

* Removed whitespaces

* Removed check

* Improved code and docu

* Changed integration test

* Changed integration test

* Changed integration test

* Changed integration test

* corrected typo

* Added admin test because CIM is not available with user rights

* Changed unit prefix from decimal to binary
2017-12-20 21:53:19 +10:00
Trishna Guha
4a4da2b774
nxos_static_route DI module (#33797)
* nxos_static_route DI module

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* add version_added
2017-12-20 17:08:29 +05:30
John R Barker
7381554e42 Compact documentation (#34081)
Before this fix lists of `documentation:` were in individual <p> tags
causing a lot of whitespace on the rendered _module.html pages.
2017-12-20 20:49:09 +10:00
Jordan Borean
0880297909 fix options output for bool type (#34074) 2017-12-20 09:48:17 +00:00
Kedar Kekan
78a14d7966
Cliconf and Netconf refactoring iosxr_interface (#33909)
* Cliconf and Netconf refactoring iosxr_interface

* adds `xml` key and related changes for netconf output

* * review comments changes
2017-12-20 13:06:07 +05:30
Fedor Sumkin
8a9865cb10 Fix for dns4 empty setting (#30757)
This fix check if DNS4 is None or not before proceeding with
other operations. Also, added unit test for this change.

Signed-off-by: Fedor Sumkin <qosys.net@gmail.com>
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2017-12-20 12:48:22 +05:30
Abhijeet Kasurde
f7fe6a065e
VMware: Allow users to specify port for ESXi (#34073)
This fix adds 'port' as module parameter in VMware modules,
which allows user to specify vCenter or ESXi server port number for
admin connection.

Fixes: #34070

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2017-12-20 11:53:22 +05:30
Trishna Guha
be89822bb5
Deprecate nxos_portchannel and add nxos_linkagg DI module (#33376)
* deprecate nxos_portchannel

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* Add nxos_linkagg DI module

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* remove nxos_portchannel unit test

* fix syntax issues

* fix ansible-doc failure

* update nxos_portchannel unittest

* minor fixes and integration test

* update nxos_linkagg
2017-12-20 11:26:07 +05:30
Trishna Guha
3cce8dfafd
Deprecate nxos_ip_interface and Add nxos_l3_interface DI module (#33866)
* Deprecate nxos_ip_interface module

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* Add nxos_l3_interface DI module

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* Add integration test

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* pep8 fixes

* Add nxapi cli test

* Improve complexity

* manage layer3 interface

* fix unit test
2017-12-20 11:07:23 +05:30
Trishna Guha
27be2a0f5a
Handle nxos platform diffs with cli conf implementation (#34020)
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2017-12-20 10:41:10 +05:30
Brian Coca
2db3d861e0 lookup templated value of a var (#32772)
* lookup templated value of a var
* better dupe loop detection
* corrected invalid test loops
2017-12-19 22:41:50 -06:00
Abhijeet Kasurde
bc91258124 apt_get: add warning for force_apt_get (#33994)
This fix adds strict check for package manager binary checking in given
path.

Fixes: #32940

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2017-12-19 22:39:15 -06:00
Adrian Likins
51315c498d Add intg tests for some of the issues in 32302 (#32360)
Verify that set_fact's var_prec is correct and that
regular facts var_prec is correct (ie, that play_vars
can override them)
2017-12-19 22:34:05 -06:00
Fabio Alessandro Locati
dc86f6f6d5 Easier to debug (#30675) 2017-12-19 22:33:11 -06:00
Toshio Kuratomi
2e1c889275
Have command nanny tell you how to disable the warning (#34061)
* Have command nanny tell you how to disable the warning
2017-12-19 17:30:10 -08:00
René Moser
790c06c079 changelog: add new modules (#34059)
* changelog: add new modules

* remove false postive new modules
2017-12-19 20:05:50 -05:00
Toshio Kuratomi
cc7a5228b0
Deprecate check_invalid_arguments (#34004)
* Deprecate check_invalid_arguments

Check_invalid_arguments is a piece of functionality from the early days
of Ansible that should not be used.  We'll remove it in Ansible 2.9.
Deprecating it for now.
2017-12-19 14:36:02 -08:00
Sloane Hertel
7bc754674c
[template/vars] Use to_native(exception) as a fallback for Python 3 which doesn't have a .message attribute (#34044) 2017-12-19 17:34:46 -05:00
Toshio Kuratomi
b06f7688cd Fix a unicodeerror so that we get the correct error message (#34058)
Fixes #33044
2017-12-19 16:26:30 -06:00
Gobin Sougrakpam
e2de3c9776 [cloud] New module - AWS Direct Connect Gateway (#33890)
* Adding module for AWS Direct Connect Gateway

* Fixes for failing checks

* Fix errors for shippable checks

* Fix pep8 errors

* Fixes from review comments

* Simplify logic and add exception handling for every boto3 call

* Fix undefined variable
2017-12-19 17:22:18 -05:00
Robert "Bo" Davis
b5c0141fb0 Use hostname in group_by_aws_account to prevent duplicates. (#34053)
Fix typo. The use of `dest` for group_by_aws_account causes the group to be produced using IP and to duplicate the hosts in the inventory.

Fixes #23772

Signed-off-by: bo <robert@jbanetwork.com>
2017-12-19 17:04:46 -05:00
Sloane Hertel
bf8d695ec3
[ec2_vpc_peer] Remove use of DryRun since the module doesn't support check mode (#34062) 2017-12-19 16:42:26 -05:00
Chris Houseknecht
1a59247f27 K8s raw modules (#34050)
* New dirs, raw modules, and deprecations, 'openshift' not 'oc'
2017-12-19 15:25:33 -06:00
Brian Lamar
fcc79de246 Add support for intra-region VPC peering (#34036)
* [ec2_vpc_peer] Add support for intra-region VPC peering
2017-12-19 16:05:14 -05:00
Nathaniel Case
513c75079e
Port eos tests to network_cli (#33586)
* Add eos and fix tests to run multiple connections

* Update tests to report connection

* Add missing START messages

* Fix unspecified connection

* Python 3 updates

Exceptions don't have `.message` in Python 3

* Override `become` when using `connection=local`

* Slight restructuring to make eapi easier later on

* Move eapi toggle to prepare_eos
* Pull out connection on eapi tasks
2017-12-19 15:49:49 -05:00
Matt Bachmann
f64b276f6a Add option allowing the user to specify a custom cowpath
This allows the user to use custom cowsay implementations without shadowing common cowsay paths
2017-12-19 15:39:38 -05:00
Tim Rupp
96335b12bb
Fixes some verbiage in the f5 docs (#34057) 2017-12-19 12:33:55 -08:00
Toshio Kuratomi
120af786af Remove params option from examples 2017-12-19 12:04:14 -08:00
René Moser
168fb07cba
influxdb: make param database_name uncommon (#34021) 2017-12-19 20:51:07 +01:00
Øyvind Saltvik
b385e3d725 Add support for adding CORS to S3 bucket on AWS - fixes #29238 (#22284)
* Add aws_s3_cors module for adding/removing CORS to S3 bucket on AWS

Based on code found here but fixes some of the mentioned issues.

https://github.com/ansible/ansible-modules-extras/pull/1177/files
2017-12-19 14:23:51 -05:00
James Mighion
ded4e6ac0f Ios config save (#33885)
* Fixing save so it still works. Adding changed as an option for save_when.

* Updating description to state that changed was added in 2.5.

* Fixing removal version for deprecated options.
2017-12-19 18:04:21 +00:00