Denis Krienbühl
b40bdb7a22
cloudscale: Fixes wrong return value docs in cloudscale_server ( #67198 )
2020-02-10 11:47:51 +01:00
Dusan Matejka
c80d0c40ce
fixed zabbix no longer returning macros as part of the template ( #66996 )
2020-02-10 02:09:00 -05:00
Matt Clay
1110e9d80d
Test AIX with smaller volumes.
2020-02-09 13:23:28 -08:00
Matt Clay
959ddf2589
Revert "Temporarily remove AIX from test matrix."
...
This reverts commit 57d43d1932
.
2020-02-09 13:23:28 -08:00
Sloane Hertel
4719072c49
Fix describing transit gateways with backoff in ec2_transit_gateway ( #67247 )
...
* Fix ec2_transit_gateway retries. AWSRetry must be used within ClientError handling to have any effect
* changelog
2020-02-08 21:48:11 +01:00
Sloane Hertel
3f5aed056b
Integration tests for notify with variable list ( #66423 )
...
Co-authored-by: Luca Berruti <nadirio@gmail.com>
Co-authored-by: lberruti <nadirio@gmail.com>
2020-02-08 12:41:06 -05:00
Matt Clay
88efb24ff8
Rename aci_switch_leaf_policy_profile test.
2020-02-07 21:33:23 -08:00
Matt Clay
d86dcedef1
Rename scaleway_ssh test.
2020-02-07 21:33:06 -08:00
Matt Clay
c2f7c4ae47
Rename rabbitmq lookup test.
2020-02-07 21:32:54 -08:00
Matt Clay
a42a76190e
Renamed meraki_webhooks test.
2020-02-07 21:32:40 -08:00
Matt Clay
a68a8ef2f1
Rename netapp_eseries_* tests to match modules.
...
This will allow the ansible-base migration script to recognize the tests as being associated with their respective modules.
2020-02-07 21:32:24 -08:00
Matt Clay
0d430c2ccc
Rename digital_ocean_ssh_key test.
2020-02-07 21:32:07 -08:00
Matt Clay
f02ceaf66a
Fix AWS test names and aliases. ( #67232 )
...
* Fix AWS test names and aliases.
* Add missing alias.
* Rename ec2_vpc_vpn_facts test.
2020-02-07 21:31:48 -08:00
Matt Clay
6a79bb2b91
Simplify package install in unarchive test.
...
This will enable the test to work on supported platforms when modules for other platforms are not present.
2020-02-07 21:31:24 -08:00
Matt Clay
c92697acec
Move tower_common tests with tower_organization.
2020-02-07 21:31:05 -08:00
Matt Clay
c10f4a8156
Rename azure_rm_workspace test.
2020-02-07 21:30:43 -08:00
Matt Clay
415409c6e3
Rename azure_rm_virtualmachineimage_facts test.
2020-02-07 21:30:20 -08:00
Matt Clay
64567cf4f6
Split tasks for prepare_http_tests.
...
This allows setup of a platform to run even when modules for another platform are not present.
2020-02-07 21:30:01 -08:00
Matt Clay
80561ccef0
Improve sanity test handling in CI after migration.
2020-02-07 21:29:39 -08:00
Matt Clay
7724fb8f33
Split handler tasks for setup_remote_tmp_dir.
...
This allows a platform handler to run even when the module required for the other platform is not present.
2020-02-07 21:29:20 -08:00
Matt Clay
a0242b2173
Improve unit test handling in CI after migration. ( #67217 )
...
* Improve unit test handling in CI after migration.
* Fix undefined var in bash 4.3 and earlier.
See https://git.savannah.gnu.org/cgit/bash.git/tree/CHANGES?id=3ba697465bc74fab513a26dea700cc82e9f4724e#n878
2020-02-07 21:28:46 -08:00
Felix Fontein
f725dce936
Clean up FILE_COMMON_ARGUMENTS ( #66389 )
...
* Clean up FILE_COMMON_ARGUMENTS.
* postgresql_pg_hba doesn't declare the backup option.
* uri doesn't declare the remote_src option.
* Add documentation.
* maven_artifact seems to use directory_mode, which it doesn't declare.
* Update changelogs/fragments/66389-file-common-arguments.yml
Update docs/docsite/rst/porting_guides/porting_guide_2.10.rst
ci_complete
Co-Authored-By: Jill R <4121322+jillr@users.noreply.github.com>
2020-02-07 18:56:01 -05:00
Gonéri Le Bouder
802cc60242
vmware_guest_tools_wait: add timeout parameter
...
Add a new `timeout` parameter to `vmware_guest_tools_wait`.
Also, a functional test to cover the module.
2020-02-07 17:48:29 -05:00
Matt Clay
57d43d1932
Temporarily remove AIX from test matrix.
...
AIX provisioning is failing.
2020-02-07 11:07:30 -08:00
Paul Belanger
4863efd0df
Remove yaml stdout_callback plugin from network-integration tests ( #67203 )
...
With the move to collections, yaml is no longer in ansible base. Switch
back to default stdout.
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2020-02-07 13:24:42 -05:00
Allen Smith
fd8eb77cc3
pmrun - quote success command ( #66929 )
...
* Recreate the older behavior where the entire success command was quoted
* Use shlex_quote for a correct fix of this
* Add changelog fragment
2020-02-07 12:15:55 -05:00
Mark Chappell
8fa233ba1e
aws_az_info: Fix rename deprecaction warning ( #67188 )
2020-02-07 11:13:02 -05:00
Gonéri Le Bouder
4a1115785f
vmware_guest_network/test: disable the test
...
The test fails in the CI with a timeout of vmware_guest_tools_wait. It's
still unclear if this comes from:
- the ESXi environment
- the VM configuration, e.g: the amount of the RAM
- the ISO image itself
Ideally, we should have a light VM with the vmware-tools.
2020-02-06 19:59:23 -05:00
Paul Belanger
bf4dac10fa
Revert "WIP: testing ansible-base ( #67149 )" ( #67175 )
...
I didn't properly update the commit message via github UI. Revert, to
open a new PR.
This reverts commit 2794142eb3
.
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2020-02-06 14:26:10 -05:00
Paul Belanger
2794142eb3
WIP: testing ansible-base ( #67149 )
...
Currently, yaml stdout_callback is not in base.
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2020-02-06 13:40:02 -05:00
Todd Lewis
640bf31f87
user - allow 'groups', 'append' with 'local' ( #62134 )
2020-02-06 12:32:44 -05:00
Paul Belanger
c3635532d3
Revert "Allow httpapi for EOS resource modules ( #66871 )" ( #67131 )
...
This looks to be causing issues for our new ansible.netcommon
collection. Revert for now, until we can properly address.
This reverts commit 53c7f8cbde
.
2020-02-06 10:20:08 -05:00
Andrew Klychkov
637eed5a5c
postgresql modules: fix sanity issues ( #67046 )
...
* postgresql modules: fix sanity issues
* add changelog
* fix changelog
2020-02-06 16:05:42 +01:00
Lukas Kämmerling
a5b5101e09
Fix a typo in hcloud_image_info and hcloud_location_info ( #67123 )
2020-02-06 03:09:47 -05:00
Matt Clay
b48a89682b
Revert "Temporarily remove AIX from test matrix."
...
This reverts commit be9471b251
.
2020-02-05 22:16:36 -08:00
Matt Clay
5e68bb3d93
Add code coverage target analysis to ansible-test. ( #67141 )
...
* Refactor coverage file enumeration.
* Relocate sanitize_filename function.
* Support sets when writing JSON files.
* Generalize setting of info_stderr mode.
* Split out coverage path checking.
* Split out collection regex logic.
* Improve sanitize_filename type hints and docs.
* Clean up coverage erase command.
* Fix docs and type hints for initialize_coverage.
* Update type hints on CoverageConfig.
* Split out logic for finding modules.
* Split out arc enumeration.
* Split out powershell coverage enumeration.
* Raise verbosity level of empty coverage warnings.
* Add code coverage target analysis to ansible-test.
2020-02-05 22:16:15 -08:00
Dennis Israelsson
68b981ae21
update nmap inventory plugin to not depend on rdns ( #56457 )
2020-02-05 17:29:59 -05:00
Matt Martz
0e46af17a5
Nuke all removed_module stubs ( #67139 )
...
* Nuke all removed_module stubs
* Remove ignores and botmeta entry
2020-02-05 16:29:27 -06:00
James Cassell
b868f1c933
fix systemd use in container builds ( #66062 )
...
* systemd: unify "systemctl show" failure cases
* systemd: is-enabled to detect configured state
* systemd: is-enabled to detect masked status
2020-02-05 15:14:57 -05:00
Lihu Ben-Ezri-Ravin
48505af9d2
Remove filtering from edgeos_config module ( #63362 )
...
The edgeos_config module had a list of commands to filter out to avoid
load failures. This list had a single regular expression which caught
commands that attempted to set pre-encrypted passwords. This behavior is
undesirable for a few reasons.
* It's poorly documented. The documentation makes cryptic mention of a
return value that some commands might be filtered out, but offers no
explanation as to what they are or why.
* It's hard-coded. There's no way for the user to change or disable this
functionality, rendering the commands caught by that expression
completely unusable with the edgeos_config module.
* The obvious workaround is unsafe. The filter catches passwords that
are already encrypted, but is perfectly fine letting the user set
plain-text passwords. EdgeOS will encrypt them upon commit, but this
module encourages unsafe handling of secrets up to that point.
* It's a security vulnerability if the user doesn't know about this
behavior. While the module will warn if commands are filtered, the
user won't know what got filtered out until after the fact, and may
easily miss that warning if they are not vigilant. For something as
sensitive as setting a password, it's not hard to imagine naive use of
this module resulting in incorrect credentials being deployed.
* It provides no discernible benefit. Using the module without filtering
does not result in load failures. If those commands are indeed harmful
for some reason on (old?) versions of EdgeOS, it should be incumbent
upon the user to be scrupulous in what commands they issue, rather
than the module maintaining a blacklist of possible ways the user
might misuse their own system.
2020-02-05 14:57:55 -05:00
Jørgen Lien Sellæg
43f93d275c
openssl_certificate: Selecting which acme directory to use to get certificate ( #67109 )
...
* "openssl_certificate - Add option for changing which ACME directory to use with acme-tiny. Set the default ACME directory to Let's Encrypt instead of using acme-tiny's default. (acme-tiny also uses Let's Encrypt at the time being, so no action should neccessary.)"
* "openssl_certificate - Change the required version of acme-tiny to >= 4.0.0"
2020-02-05 14:10:27 -05:00
Ruediger Pluem
80c4b86abe
group - correctly determine if a local group exists. ( #59772 )
...
Fixes #58619
Add integration test
2020-02-05 12:34:41 -05:00
Mark Chappell
50eb2f6957
sns_topic: Retry on Topic 'NotFound' Exceptions when attempting to list subscriptions ( #67089 )
...
* sns_topic: Retry on Topic 'NotFound' Exceptions when attempting to list subscriptions
* add changelog
2020-02-05 12:16:07 -05:00
Adam Miller
2f77a6f1f0
migrate qradar and splunk httpapi plugins to collections ( #67132 )
...
Signed-off-by: Adam Miller <admiller@redhat.com>
2020-02-05 11:07:03 -06:00
anshulbehl
f3f9671e01
Adding migration for netapp content ( #67081 )
...
* Adding migration for netapp elementsw content
* Adding migration data for netapp ontap content
2020-02-05 18:05:53 +01:00
Mitsuru Nakakawaji
c55ba658c6
add note for Azure Availbility Zone ( #66200 )
...
* add note for Azure Availbility Zone
* Change title
* Update docs/docsite/rst/scenario_guides/guide_azure.rst
Co-Authored-By: Sandra McCann <samccann@redhat.com>
* Update docs/docsite/rst/scenario_guides/guide_azure.rst
Co-Authored-By: Sandra McCann <samccann@redhat.com>
* Update docs/docsite/rst/scenario_guides/guide_azure.rst
Co-Authored-By: Sandra McCann <samccann@redhat.com>
* Update docs/docsite/rst/scenario_guides/guide_azure.rst
Co-Authored-By: Sandra McCann <samccann@redhat.com>
* Update docs/docsite/rst/scenario_guides/guide_azure.rst
Co-Authored-By: Sandra McCann <samccann@redhat.com>
* Update docs/docsite/rst/scenario_guides/guide_azure.rst
Co-Authored-By: Sandra McCann <samccann@redhat.com>
* Update docs/docsite/rst/scenario_guides/guide_azure.rst
Co-Authored-By: Sandra McCann <samccann@redhat.com>
* Update docs/docsite/rst/scenario_guides/guide_azure.rst
Co-Authored-By: Sandra McCann <samccann@redhat.com>
* Update docs/docsite/rst/scenario_guides/guide_azure.rst
Co-Authored-By: Sandra McCann <samccann@redhat.com>
* Update docs/docsite/rst/scenario_guides/guide_azure.rst
Co-Authored-By: Sandra McCann <samccann@redhat.com>
* Update docs/docsite/rst/scenario_guides/guide_azure.rst
Co-Authored-By: Sandra McCann <samccann@redhat.com>
* Update docs/docsite/rst/scenario_guides/guide_azure.rst
Co-Authored-By: Sandra McCann <samccann@redhat.com>
* Update docs/docsite/rst/scenario_guides/guide_azure.rst
Co-Authored-By: Sandra McCann <samccann@redhat.com>
* Update docs/docsite/rst/scenario_guides/guide_azure.rst
Co-Authored-By: Sandra McCann <samccann@redhat.com>
* Update docs/docsite/rst/scenario_guides/guide_azure.rst
Co-Authored-By: Sandra McCann <samccann@redhat.com>
* Update docs/docsite/rst/scenario_guides/guide_azure.rst
Co-Authored-By: Sandra McCann <samccann@redhat.com>
* Update docs/docsite/rst/scenario_guides/guide_azure.rst
Co-Authored-By: Sandra McCann <samccann@redhat.com>
* Update docs/docsite/rst/scenario_guides/guide_azure.rst
Co-Authored-By: Sandra McCann <samccann@redhat.com>
* Update docs/docsite/rst/scenario_guides/guide_azure.rst
Co-Authored-By: Sandra McCann <samccann@redhat.com>
Co-authored-by: Sandra McCann <samccann@redhat.com>
2020-02-05 12:04:47 -05:00
Newptone
0a8f5aba74
Bugfix for os_coe_cluster_template module ( #54819 ) ( #54820 )
...
* Support 'overlay2' in docker_storage_driver
* Fixed the data type in labels
* Improve string process with parsing labels
2020-02-05 10:41:15 -05:00
Mads Jensen
3dd4b3c8a3
Replaces a open/close to validate access with os.access in azure storageblob. ( #65608 )
2020-02-05 08:20:39 -05:00
Martin Nečas
52f2081e62
Ovirt_host_network: add custom_properties ( #67117 )
...
* init of cp
* set update_custom_properties
* update check_mode
* correct examples
* add version_added
* update sanity
2020-02-05 07:03:32 -05:00
Markus Bergholz
822077fefd
Asg mixed instance types ( #67045 )
...
* merge from origin pr 55067
* handle update existing asg with mixed-instance-policy
* fix documentation and append output
* update output documentation
* update documentation version added
* add integration test for mixed instance policy using launch template
* add changelog fragment
* Update lib/ansible/modules/cloud/amazon/ec2_asg.py
Co-Authored-By: Mark Chappell <mchappel@redhat.com>
* Update lib/ansible/modules/cloud/amazon/ec2_asg.py
Co-Authored-By: Mark Chappell <mchappel@redhat.com>
* Update lib/ansible/modules/cloud/amazon/ec2_asg.py
Co-Authored-By: Jill R <4121322+jillr@users.noreply.github.com>
* add warning about botocore version and add expand example documentation
* Update changelogs/fragments/67045-ec2_asg_mixed_instance_policy.yml
Co-Authored-By: Mark Chappell <mchappel@redhat.com>
* Update lib/ansible/modules/cloud/amazon/ec2_asg.py
Co-Authored-By: Mark Chappell <mchappel@redhat.com>
* Update lib/ansible/modules/cloud/amazon/ec2_asg.py
Co-Authored-By: Mark Chappell <mchappel@redhat.com>
* remove useless line
Co-authored-by: Yi-Tse Hong <yitse.hong@soocii.me>
Co-authored-by: Mark Chappell <mchappel@redhat.com>
Co-authored-by: Jill R <4121322+jillr@users.noreply.github.com>
2020-02-05 09:04:15 +01:00