cmueller/ansible
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity
49527 commits 47 branches 390 tags 440 MiB
Commit graph

49527 commits

This branch
This branch
All branches
Author SHA1 Message Date
Sam Doran
d30c57ab22
win_unzip - normalize and compare paths to prevent path traversal (#67799) 
* Actually inspect the paths and prevent escape
* Add integration tests
* Generate zip files for use in integration test
* Adjust error message
 2020-02-28 17:56:21 -05:00
Markus Bergholz
8ab304af44
implement support for hidden/protected variables gitlab_project_variable (#67461) 
* #66135 implement support for hidden/protected variables

* Update lib/ansible/modules/source_control/gitlab/gitlab_project_variable.py

Co-Authored-By: Abhijeet Kasurde <akasurde@redhat.com>

* Update lib/ansible/modules/source_control/gitlab/gitlab_project_variable.py

Co-Authored-By: Abhijeet Kasurde <akasurde@redhat.com>

* Update lib/ansible/modules/source_control/gitlab/gitlab_project_variable.py

Co-Authored-By: Abhijeet Kasurde <akasurde@redhat.com>

* Update lib/ansible/modules/source_control/gitlab/gitlab_project_variable.py

Co-Authored-By: Abhijeet Kasurde <akasurde@redhat.com>

* Update lib/ansible/modules/source_control/gitlab/gitlab_project_variable.py

Co-Authored-By: Abhijeet Kasurde <akasurde@redhat.com>

* update example value

* fix pep

* fix pep8

* fix tailing whitespace

* Update lib/ansible/modules/source_control/gitlab/gitlab_project_variable.py

Co-Authored-By: Felix Fontein <felix@fontein.de>

* Update lib/ansible/modules/source_control/gitlab/gitlab_project_variable.py

Co-Authored-By: Felix Fontein <felix@fontein.de>

* Update lib/ansible/modules/source_control/gitlab/gitlab_project_variable.py

Co-Authored-By: Felix Fontein <felix@fontein.de>

* Update lib/ansible/modules/source_control/gitlab/gitlab_project_variable.py

Co-Authored-By: Felix Fontein <felix@fontein.de>

* Update test/integration/targets/gitlab_project_variable/tasks/main.yml

Co-Authored-By: Felix Fontein <felix@fontein.de>

* Update lib/ansible/modules/source_control/gitlab/gitlab_project_variable.py

Co-Authored-By: Felix Fontein <felix@fontein.de>

* fix recommendations and request changes

* Update lib/ansible/modules/source_control/gitlab/gitlab_project_variable.py

Co-Authored-By: Felix Fontein <felix@fontein.de>

* Update lib/ansible/modules/source_control/gitlab/gitlab_project_variable.py

Co-Authored-By: Felix Fontein <felix@fontein.de>

* Update test/integration/targets/gitlab_project_variable/tasks/main.yml

Co-Authored-By: Felix Fontein <felix@fontein.de>

* fix undefine module

* add missing import

* expand documentation

* add idempotent check

* add changelog

* Update changelogs/fragments/67461-gitlab-project-variable-masked-protected.yml

Co-Authored-By: Felix Fontein <felix@fontein.de>

* Update lib/ansible/modules/source_control/gitlab/gitlab_project_variable.py

Co-Authored-By: Felix Fontein <felix@fontein.de>

* Update lib/ansible/modules/source_control/gitlab/gitlab_project_variable.py

Co-Authored-By: Felix Fontein <felix@fontein.de>

* Update lib/ansible/modules/source_control/gitlab/gitlab_project_variable.py

Co-Authored-By: Felix Fontein <felix@fontein.de>

* check also for integer_types

* expand integration test and check also for float type

* append documentation

* Update lib/ansible/modules/source_control/gitlab/gitlab_project_variable.py

Co-Authored-By: Felix Fontein <felix@fontein.de>

Co-authored-by: Abhijeet Kasurde <akasurde@redhat.com>
Co-authored-by: Felix Fontein <felix@fontein.de>
 2020-02-28 23:17:03 +01:00
Sam Doran
7a42354021
Switch to using FreeBSD 12.1 (#67659) 2020-02-28 17:12:55 -05:00
Ruheena Ansari
e0eee3c37e
Run Powershell modules on windows container via docker connection (#67832) 
* Run modules on windows container

This provides an ability to run Powershell modules on windows container via docker connection. Otherwise, Ansible tries to run python modules on windows containers and fails.

* Removing whitespace in the blank lines

* Adding a changelog fragment
 2020-02-28 23:05:53 +01:00
Guillaume Bour
09fb563317
fix docker_login doc example (#67852) 2020-02-28 15:37:50 -05:00
nemethloci
a76d78f691
Fixed incorrect request body when creating VM snapshot with disks (#67815) 
* Fixed incorrect request body when creating VM snapshot with disks

* fixed changlog file extension
 2020-02-28 12:32:14 -05:00
Matt Clay
b84dc2f2a6 Add integration test for regex_search filter. 2020-02-28 08:38:50 -08:00
Sumit Jaiswal
9392912608
Resource module for IOS ACL (#66629) 
* fix ios_acl
 2020-02-28 22:06:38 +05:30
Mark Chappell
32a76f0aa1
Add 'OperationAborted' to the list of S3 error codes where we'll retry (#67811) 2020-02-28 11:26:26 -05:00
misacek007
dbd86be2d6
Update vmware_guest_info.py (#67853) 
forgotten doc replacement of vmware_guest_facts to vmware_guest_info
 2020-02-28 21:23:35 +05:30
Sayed Anisul Hoque
b437167671
line indentation issue in postgresql_set (#67859) 
Fixed indentation issue with the `register` for the example task in postgresql_set module.
 2020-02-28 21:22:30 +05:30
Rick Elrod
ed37efb217
"Fix" test_get_bin_path by changing mock order (#67730) 
pytest-mock 2.0.0, when run locally, gets grumpy when os.path.exists is
messed with and then another method is patched afterwards. Likely
something in the pytest-mock chain uses os.path.exists internally, and
since pytest-mock prohibits context-specific patching, there's not a
good solution. For now, just patch os.path.exists last.

Signed-off-by: Rick Elrod <rick@elrod.me>
 2020-02-28 10:39:27 -05:00
Dainius Sakalinskas
735ea43aeb
hostname Add cloudlinuxserver value to hostname.py (#66911) 2020-02-28 10:26:07 -05:00
narimantos
554676da5e
git - use remote_tmp directory (#66762) 
* fix:git module ignores remote_tmp

* WIP: added the changelog fragment and edit comment

* Revert "WIP: added the changelog fragment and edit comment"

This reverts commit 2f739df619.

* WIP: added changelog fragments

* WIP: added changelog fragment

* WIP: fixed spelling in changelog fragment
 2020-02-28 10:19:47 -05:00
Sumit Jaiswal
4c0eb4396b
Resource module for IOS static routes (#64632) 
* ios_static_routes
 2020-02-28 18:29:17 +05:30
Sumit Jaiswal
6629b9feef
Resource module for IOS ACL_Interfaces (#66746) 
* acl_interfaces
 2020-02-28 16:29:18 +05:30
Felix Fontein
08fc9f63b6
Add x509_crl_info module (#67539) 
* Add x509_crl_info module.

* Apply suggestions from code review

Co-Authored-By: Andrew Klychkov <aaklychkov@mail.ru>

Co-authored-by: Andrew Klychkov <aaklychkov@mail.ru>
 2020-02-28 08:00:47 +01:00
Matt Clay
21475aa83b Test system users and groups. 2020-02-27 21:45:18 -08:00
Abhijeet Kasurde
b6c2056ea2
mongodb_user: fix doc formatting (#67763) 
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
 2020-02-28 09:04:27 +05:30
Abhijeet Kasurde
0cd22abe8c
mongodb: Fix documentation (#67806) 
* Added correct datatypes of parameter
* Fixed doc formatting

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
 2020-02-28 08:51:06 +05:30
Matt Clay
8e31a2fe40
Add lookup_dict integration test. (#67836) 
* Add lookup_dict integration test.

* Skip test on python 2.6.
 2020-02-27 18:45:37 -08:00
Paul Belanger
2a920cf228
Fix flake8 errors for checkpoint modules (#67827) 
We caught these in our checkpoint.checkpoint collection testing.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
 2020-02-27 21:15:32 -05:00
Matt Clay
f735fd672a
Third batch of incidental integration tests. (#67830) 
* Copy in incidental windows tests.

* Update incidental test aliases.

* Add support plugins.

* Update target references.

* Update sanity ignores.

* Update integration-aliases test.

* Add to CI.
 2020-02-27 16:05:47 -08:00
Mark Chappell
da30e6d2e1
sqs_queue - Move to boto3 and add support for various extra features (#66795) 
* reworked sqs_queue

* Switch default purge_tags behaviour to false.

This matches the behaviour of ec2_tag and ecs_tag.

* Minor lint / review fixups

* Add missing AWS IAM policy for SQS tests

* Move integration tests to using module_defaults: group/aws:...

* add changelog

* Break out the 'compatability' map from our spec definition (gets flagged by the schema validation)

* Tweaks based on review

* add basic examples

* Lint fixups

* Switch out NonExistentQueue logic so it's easier to follow

* Reorder name argument options for consistency

Co-authored-by: Dennis Podkovyrin <dennis.podkovyrin@gmail.com>
 2020-02-27 15:26:20 -07:00
Sandra McCann
75b088d6a9
Remove extra Ansible in network automation section header (#67828) 2020-02-27 15:28:34 -06:00
adambriand
92571e5448
Update blockinfile.py to change dest: to path: (#67824) 2020-02-27 16:13:25 -05:00
Sam Doran
d7546ba336
Fix PostgreSQL tests for newer FreeBSD versions (#67658) 
Use PostgreSQL 9.5 on FreeBSD 12.0, and PostgreSQL 11 on FreeBSD 12.1 and 11.3 due to the Python packages having a dependency on that version of PostgreSQL and automatically uninstalling PostgreSQL 9.5.

* Use separate PostgreSQL versions for 12.0 and 12.1
 2020-02-27 15:01:15 -05:00
mmoyle
cfe96b2092
add module cloudformation_exports (#67349) 
* add module cloudformation_exports

* add RETURN, add aliases group, clean up yaml

* update return value. uncomment security_token. remove cloudformation shortcut

* fix typo

* try to delete test stack

* rename stack

* add cleanup and assert. try to set stack name with variable

* create s3 bucket instead

* set bucket name

* add tests, remove unsed key and import, add iam role, add to module_defaults

* import exceptions, fix assert syntax

* fix assert

* Update test/integration/targets/cloudformation_exports/tasks/main.yml

Co-Authored-By: Jill R <4121322+jillr@users.noreply.github.com>

* fix export name

* renamed module

Co-authored-by: Jill R <4121322+jillr@users.noreply.github.com>
 2020-02-27 11:39:59 -07:00
Stefan Horning
652346ad5d
Allow passing through of (almost) all params available … (#58118) 
* Allow passing through of (almost) all params available on boto methods in aws_api_gateway

* Linting and docs fixes

* Refactored method signature of create_deployment() to use keyword args instead of named args

* Updated version_added flags to 2.10

* Cleanup and improve aws_api__gateway integration test play. Also included new params into test.

* Fixed RETURN docs and some ttests

* Completed RETURN docs and made integration tests match

* Fixed variable names in test and YAML syntax in docs

* Comment out critical sections of integration test

* Fixed update test after figuring out what the error message means. Also updated error message to be more descriptive.

* Fixed test assertion

* Update docs and make tests reflect that endpoint type wont be changed on updates

* Syntax fix

* Add changelog fragment

* Improve aws_api_gateway docs, fix typos.

* Quote doc lines with colon
 2020-02-27 10:44:20 -07:00
Andrew Klychkov
a81ab5fe40
mysql_db: add possibility to make dump with --no-create-db option (#67767) 
* mysql_db: add possibility to make dump with --no-create-db option

* add changelog fragment

* fix
 2020-02-27 13:51:23 +00:00
Abhijeet Kasurde
ed306c7991
influxdb: Fix documentation (#67807) 
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
 2020-02-27 13:43:16 +01:00
John R Barker
08821709ef
Fix invalid botmeta entries (#67785) 
Correct paths
Remove trailing whitespace
 2020-02-27 11:49:45 +00:00
Nilashish Chakraborty
3405ee1c01
Add iosxr_static_routes RM (#65181) 
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
 2020-02-27 14:31:00 +05:30
Brian Scholer
9afe87139a
Add win_psrepository_info module (#67594) 
* Add win_psrepository_info module

* Change return type

* Add tests for win_psrepository_info
 2020-02-27 16:05:37 +10:00
Andrew Klychkov
10feb24870
mongodb_shard: fix doc formatting (#67750) 2020-02-27 08:04:12 +05:30
Mark Chappell
d5c17118ed
s3_bucket - cleanup and test stabilisation. (#66778) 
* AnsibleAWSModule related cleanup - s3_bucket

* Add extra information to s3_bucket timeout failures, it's possible the comparisons are doing something weird...

* Move Bucket Encryption boto support logic into the pre-flight checks

* Use the built in required_by logic

* Rework s3_bucket integration tests

* Add a retry around put_bucket_encryption

s3_client.put_bucket_encryption is occasionally dropped on the floor
by Amazon add some logic to retry s3_client.put_bucket_encryption call

* Catch OperationAborted and retry, it is caused by a conflicting change
still being in progress.   (For example an Encryption setting applying)

* Make sure we don't explode if the botocore version's too old

* Review tweaks
 2020-02-26 16:54:39 -07:00
Markus Bergholz
9463d28967
read enabled_key_rotation status also in aws_kms_info (#67770) 
* read enabled_key_rotation status

* add changelog

* use AWSRetry decorator to prevent api rate limits

* fix pip8
 2020-02-26 16:51:04 -07:00
sky-joker
454b043c13 Reflect changed JSON structure than zabbix version 4.4 or more to zabbix_user 
add fragments file

Fix several pointed out

https://github.com/ansible/ansible/pull/67475#discussion_r380528775
https://github.com/ansible/ansible/pull/67475#discussion_r380532685

Enable integration test
 2020-02-26 15:40:17 -08:00
Jill R
5550fc442b
Mark aws_acm unstable and connection_aws_ssm disabled (#67787) 
* Mark aws_acm and connection_aws_ssm unstable

CI failures in https://app.shippable.com/github/ansible/ansible/runs/160867/133/tests
and https://app.shippable.com/github/ansible/ansible/runs/160867/129/tests

* Disabling concection_aws_ssm, it's repeatedly failing on this PR
https://app.shippable.com/github/ansible/ansible/runs/160888/133/tests
 2020-02-26 14:56:05 -08:00
Paul Belanger
357ae7ec0e
Remove unused import from frr cli plugin (#67790) 
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
 2020-02-26 16:48:07 -05:00
Andrew Klychkov
dd53c104d7
postgresql_info: move subscription info to corresponding database dict (#67772) 2020-02-26 22:25:16 +01:00
Matt Clay
b68e55da26
Remove test/legacy/ directory. (#67786) 
* Remove `test/legacy/` directory.

* Remove references to `test/legacy/` directory.

* Update the remaining valid legacy reference.

* Remove outdated legacy references.
 2020-02-26 11:48:30 -08:00
Martin Nečas
a6f24f8aa9
Migrate ovirt to collection - add botmeta (#67729) 
* Add ovirt migrated_to to botmeta

* list all ovirt modules

* remove .idea

* remove links
 2020-02-26 18:35:22 +00:00
Sumit Jaiswal
d8c5c6eb9d
Add Switchport mode support in newly introduced *_l2_interfaces resource module (#67456) 
* fixes 65032
 2020-02-26 23:49:00 +05:30
Matt Clay
a18d3257e9 Add more bot notifications for test related paths. 2020-02-26 08:50:03 -08:00
Prasad Katti
a1f26af712
ec2_instance - update tests related to termination protection (#65035) 
* ec2_instance - update tests related to termination protection

* add more test cases for termination protection
 2020-02-26 11:08:49 -05:00
Abhijeet Kasurde
a4da73e961
misc typo fixes (#67775) 
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
 2020-02-26 10:58:39 -05:00
Paul Belanger
9c221e2bfa
Remove unused import from test_eos_static_routes.py (#67776) 
Signed-off-by: Paul Belanger <pabelanger@redhat.com>
 2020-02-26 09:27:40 -05:00
sky-joker
829a29ef18
Fix to be support for zabbix 4.4 or more and python3 (#67693) 
add fragments file
 2020-02-26 07:48:29 -05:00
sky-joker
305789144a
Fix to remove unnecessary duplicate line (#67761) 2020-02-26 07:48:15 -05:00