Commit graph

41285 commits

Author SHA1 Message Date
Michael Rose
1eed8900ed influxdb_user: Fixed default password behavior (#47040) 2018-11-23 19:25:07 +00:00
Josue David Hernandez
8880c72682 Adding support for clearlinux showing release nuber (#47101)
Signed-off-by: Josue David Hernandez <josue.d.hernandez.gutierrez@intel.com>
2018-11-23 19:22:45 +00:00
Arnaud Venturi
ad1180b22f Replace some likely forgotten yum by dnf (#48988)
I'm not 100% certain this change is relevant for the filename, but it would make sense, so I'll let you confirm.

+label: docsite_pr
2018-11-23 16:10:28 +00:00
Christopher Brown
7f7062580e Update docs with rhsm note (#48928)
* Update docs with rhsm note

redhat_subscription is the module for handling registration of modern Red Hat systems. This commit adds a note indicating that unless people are using RHEL 5 etc, they probably want that module instead.

+label: docsite_pr

* Make redhat_subscription a link to the module docs
2018-11-23 15:48:08 +00:00
René Moser
3554c59c9f cs_instance: fix typos in defaults for ip/ip6_ipaddress (#49064) 2018-11-23 15:39:15 +00:00
Zeng Jie
a9c2bc955c Fix dictionary iteration exception reported in #48096 (#48836) 2018-11-23 15:24:03 +00:00
Felix Fontein
de1c9c53c3 update value in acme_certificate route53 example
fixes #49032

Co-Authored-By: endorama <endorama@users.noreply.github.com>
2018-11-23 07:50:28 -05:00
Edoardo T
b30d2ce9e5 add state parameter to route53 module
<!--- Your description here -->

route53 module state parameter is required (https://docs.ansible.com/ansible/latest/modules/route53_module.html#parameters), so the example is not working out of the box in ansible.

Required state parameters has been introduced in commit 698fa37a44 (698fa37a44)

+label: docsite_pr
2018-11-23 07:50:28 -05:00
Stefan Horning
c3b059d61c Ecs service module health check settings (#47217)
* Added feature health_check_grace_period_seconds to ecs_service, this time with a botocore version check and some initial testing

* Only set health_check_grace_period_seconds when loadbalancers are defined

* Removed leftover commas and fix in test

* Removed blank line

* Minor improvements for ecs_service module

* Removed default (30) for health_check_grace_period_seconds param

* Changed botocore version allowed to 1.8.20 for health check param.

* Fix empty healthcheck failure
2018-11-23 22:35:25 +10:00
Paul Neumann
2019f0e430 nxos_facts: Do not gather redundant neighbor data (#49024)
* nxos_facts: Remove dead code

The commit e51964e made this redundant as the structured case is handled
elsewhere.

* nxos_facts: Do not gather neighbors redundantly

LLDP reports the neighbor using the abbreviated interface name, whereas
CDP reports the neighbor using the full interface name. Normalize the
local interface name in the LLDP case, so there is no redundant
information. Due to the order of the gathering, CDP neighbors are saved
in case both LLDP and CDP data is available on a certain interface.
2018-11-23 14:43:40 +05:30
Yunge Zhu
729d094a72 use explict conversion instead of as_dict (#49046)
* use explict conversion instead of as_dict

* fix typo
2018-11-23 13:23:58 +08:00
Yunge Zhu
438bd35729 fix keyvault doc (#49045) 2018-11-23 11:24:49 +08:00
Will Thames
31ccb3c29d Diff mode returns yaml diffs in yaml callback plugin (#48794)
* Diff mode returns yaml diffs in yaml callback plugin

* Add changelog for yaml diff mode
2018-11-22 18:03:25 +00:00
Benoît Knecht
e39fbb9db4 modules: github_release: support anonymous access (#47817)
Releases can be listed without logging in for public projects, so allow
`github_release` to be called without `token` or `password`.

Signed-off-by: Benoît Knecht <benoit.knecht@fsfe.org>
2018-11-22 17:02:39 +00:00
johnstudarus
679b7dce63 Update guide_packet.rst (#49007)
Properly parses the returned data to get the device data and IP address. 


+label: docsite_pr
2018-11-22 16:53:24 +00:00
Abhijeet Kasurde
69191b10c1 Remove unused import (#48639)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-11-22 07:58:17 -08:00
Adam Chalkley
685ea357f9 counter_enabled.py - Fix minor typos (#49014) 2018-11-22 05:41:38 -05:00
Devyani Kota
363ec65062 Fixes #38174: Add remove-brick operation for gluster_volume (#38269)
* Fixes #38174: Add remove-brick operation for gluster_volume

Existing gluster_volume module does not support removal of bricks
from a gluster volume. Also, operation remove-brick needs to be
followed by a commit operation.

Signed-off-by: Devyani Kota <dkota@redhat.com>

* Updates #38174: Add documentation for remove-brick operation

Signed-off-by: Devyani Kota <dkota@redhat.com>

* Updates #38174: Add support to reduce cluster configuration.

An exceptional scenario exists where the user might want to
reduce the gluster cluster configuration for replicated
volumes from replica 3 to replica 2 that need to be handled
in a different manner than the generic gluster commands,
where the user is expected to mention the replica count
of the new configuration in order to remove the bricks.

Signed-off-by: Devyani Kota <dkota@redhat.com>

* Updates #38174: Add checks for self-heal status prior remove operation.

While reducing the cluster configuration from replica 3
to 2, it needs to be checked for status of self-heal
prior remove-brick operation is executed.

Signed-off-by: Devyani Kota <dkota@redhat.com>
2018-11-22 04:42:02 -05:00
Will Thames
960ebd981f k8s append_hash (#48830)
* Add append_hash functionality to k8s module

append_hash adds a hash based on the contents of a ConfigMap
or Secret to the name - this enables immutable ConfigMaps and
Secrets.

* Provide k8s_config_resource_name plugin

The k8s_config_resource_name filter plugin provides a means of determining
the name of ConfigMaps and Secrets created with append_hash

* Add changelog fragment

* fix failing tests

* Update openshift version needed for append_hash
2018-11-22 08:14:43 +00:00
Jordan Borean
c3770bf6f2
win_mapped_drive: removed docs around a system wide mount (#49017) 2018-11-22 17:05:35 +10:00
nesanton
14612db43f Ovirt: fixes #41592, #34559 (#41622)
* autostart cannot be used with command=define

autostart cannot be used with command=define. If it's used with state, it'll be silently ignored.
https://github.com/ansible/ansible/issues/41592

* guest name should not be used with xml

When both ```name``` and ```xml``` are specified, there might be a mismatch of domain names in
```name``` and inside ```xml```.

* Improved error handling and param deps for autostart-only tasks.
Standalone autostart tasks depend on ```name``` and need the domain to be present.

* Added handling of errors thrown by libvirt

* Updates to documentstion and examples

* Removed required flag from name. Added description on some option combinations.
Added a few examples.

* lint issues

* docs: note that name is optional

* Removing required from documentation of name parameter

* extra text to make clearer when name is required

* When defining a domain with xml, its name is taken directly from the xml definition.

This reverts commit 4ac14a622b.
2018-11-22 08:13:55 +05:30
jctanner
f6c83538d3
ignore yum module creator (#49009) 2018-11-21 19:47:45 -05:00
Jordan Borean
a568bbed3c
win_mapped_drive - refactor module and docs (#48642)
* win_mapped_drive - refactor module and docs

* Updated code to work with become and split tokens

* use win_credential_manager instead of cmdkey

* updated credential manager module name

* harden the system token impersonation process
2018-11-22 08:12:41 +10:00
Jordan Borean
8e92cca139
win_credential: new module to manage credentials (#48840)
* win_credential_manager: new module to manage credentials

* fix sanity issues and removed CredSSP references

* renamed module to win_credential

* fix typo on test variable

* fix sanity ignore line
2018-11-22 06:55:48 +10:00
Michael Cassaniti
10af3874b5 win_snmp: Initial commit (#45710)
* win_snmp: Initial commit

* win_snmp: Better handling of lists

* win_snmp: Documentation fixes

* win_snmp: Updated documentation to match parameters

* win_snmp: Added integration tests

* win_snmp: Fixed typo in test

* win_snmp: Adjusted parameter checks to match documentation

* win_snmp: Updated option descriptions to be full sentences

* win_snmp: Better type checking and output suppression

* win_snmp: Fixed unset managers and communities

* win_snmp: Fixed skipping default registry keys

* win_snmp: Migrated to using add/set/remove action from replace

* win_snmp: Fixed check mode

* win_snmp: Fixed setting action and documentation. Expanded tests.

* win_snmp: Efficiency changes and documentation cleanup
  * Added example of explicitly setting an empty set of managers to
documentation
  * Made sure set will only remove items if there is a list of items
provided. This list can be of length 0
  * Improved efficiency in selecting next index for SNMP manager
  * Updated tests

* win_snmp: Added output of permitted managers and community strings

* win_snmp: Documentation fix
2018-11-22 06:55:10 +10:00
John R Barker
75407d3e43
Validate DOCUMENTATION.author (#48993)
* Validate DOCUMENTATION.author

Ensure that author line includes a GitHub account
2018-11-21 17:29:29 +00:00
Diane Wang
9b44109ba3 Fix pr44962 add check before hot add cpu or memory (#48289) 2018-11-21 12:27:35 -05:00
Brian Coca
91150423f4
ignore netapp tests when no libs (#48941)
* ignore tests when no libs
2018-11-21 11:51:40 -05:00
John R Barker
8f41270a01
Bulk fix DOCUMENTATION.author (Part 3) (#48990) 2018-11-21 15:10:41 +00:00
Rémy Léone
959395f4b4 Fix getheaders regression with open_url in Scaleway dynamic inventory (#48671)
* Fix regression

* Improve changelog fragment
2018-11-21 09:06:21 -06:00
abarbare
70fff13a6e feat: meaningful error message scaleway image not found (#48829) 2018-11-21 11:40:15 +00:00
Brian Coca
9f785cf8a9 updated missing botmeta support core (#48958)
* botmeta add more support:core
2018-11-21 11:27:54 +00:00
John R Barker
e7da4975cc
Botmeta validate path macros (#48980)
BOTMETA validation - use path macros

Rather than hard coding the list of path macros, read them directly from
BOTMETA
2018-11-21 11:15:56 +00:00
John R Barker
97e2fa4953
Bulk module author 2 (#48955)
* Bulk fix DOCUMENTATION.author (Part 2)
2018-11-21 10:32:42 +00:00
John R Barker
a6cf45da16
botmeta - ignore cigamit from VMware (#48978) 2018-11-21 10:28:56 +00:00
Christian Kotte
3f6878ac84 VMware: New module vmware_dvswitch_lacp (#48555) 2018-11-21 12:31:19 +05:30
ftntcorecse
fb7b6f9521 Fortinet FortiManager Device Add Module (#45954)
* fmgr_device PR candidate

* fmgr_device PR candidate

* fmgr_device PR candidate

* fmgr_device PR candidate

* fmgr_device PR candidate

* fmgr_device PR candidate

* fmgr_fwobj_address PR candidate

* Grammar

* grammar changes

* pylint changes

* Fixing Authors
2018-11-21 12:05:33 +05:30
ftntcorecse
050a2c51dd Fortinet FortiManager Device Config Module (#46080)
* fmgr_device_config PR candidate

* fmgr_fwobj_address PR candidate

* PR candidate

* Resolving Edits

* Resolving Edits

* Fixing Authors
2018-11-21 12:03:38 +05:30
ftntcorecse
1da3c5c302 Fortinet FortiManager Firewall Objects - Addresses (#46084)
* fmgr_fwobj_address PR candidate

* fmgr_fwobj_address PR candidate

* PR candidate

* PR candidate

* Adding requested changes by @samccann

* minor issue...

* minor pylint issue

* More changes from @samccann

* more grammar

* Author Mention Change

* Fixing Authors
2018-11-21 12:00:39 +05:30
ftntcorecse
86222fd4c4 Fortinet FortiManager HA Configuration Module (#46085)
* fmgr_ha PR candidate

* PR candidate

* PR candidate

* PR candidate

* PR candidate

* Fixing Edits.

* Fixing Edits.

* Fixing Edits.

* Fixing Edits.

* Fixing Authors
2018-11-21 11:57:04 +05:30
Tim Rupp
212b48b6fd
Adds module to configure ldap device auth on a bigip (#48974) 2018-11-20 22:15:50 -08:00
ftntcorecse
44b20fbf96 Fortinet Firewall Object - Virtual IPs (#47637)
* PR Candidate

* PR Candidate - pylint fix

* PR Candidate minor pylint fix v2

* Fixed Odd type annotation -- needed double comments

* Missed one of the # type: comments in fixture...

* Fixing Edits. Nixing Stale CI Flag

* Fixing Edits.

* Fixed Authors -- Fixed Changes.

* Fixing pep8...

* Fixing a description
2018-11-21 11:19:58 +05:30
ftntcorecse
4862a4aeb4 FortiManager security profile group module (#46220)
* Initial Commit

* Initial Commit

* Initial Commit

* Fixing syntax errors

* After running sanity tests, fixed pylint and pep8 errors

* After running sanity tests, fixed pylint and pep8 errors

* Fixing more syntax issues

* Fixing more syntax issues

* Adding username to doc block

* PR candidate

* PR candidate

* fixed pep8 and docs issues

* fixed 2.6 function issues

* fixed 2.6 function issues part duex

* Initial commit for security profile group module

* Adding better playbook example to module

* Adding another commit to test shippable tests

* Fixing shippable errors, pep8 in unit test file and doc block problem in main module

* Fixing documentation module error

* Fixing pep8 line too long in unit test

* Fixing utility function with nested dictionaries

* Fixing utility function with pep8 issue

* Adding change to allow for multiple list of dictionaries to be submitted via a single playbook

* Fixing review changes

* Adding @ in author names per @Gundalow's request per Ansible's guidelines
2018-11-21 11:18:19 +05:30
ftntcorecse
64c4881d58 FortiManager DNS security profile (#46239)
* Initial Commit

* Initial Commit

* Initial Commit

* Fixing syntax errors

* After running sanity tests, fixed pylint and pep8 errors

* After running sanity tests, fixed pylint and pep8 errors

* Fixing more syntax issues

* Fixing more syntax issues

* Adding username to doc block

* PR candidate

* PR candidate

* fixed pep8 and docs issues

* fixed 2.6 function issues

* fixed 2.6 function issues part duex

* Initial commit for security profile group module

* Adding better playbook example to module

* Initial commit for FMG DNS security profile

* Fixing pep8 line too long in unit test

* Removing excess modules and unit tests

* Fixing trailing white space for dns module

* Fixing utility function with nested dictionaries

* Fixing utility function with pep8 issue

* Adding change to allow for multiple list of dictionaries to be submitted via a single playbook

* Fixing review changes

* Adding @ in author names per @Gundalow's request per Ansible's guidelines
2018-11-21 11:17:37 +05:30
ftntcorecse
37e932c4ee Fortinet FortiManager IPv4 Policy Module (#47638)
* Needs unit test fix -- the "delete" calls a GET command and another function to get policy ID of a firewall policy before deleting it. Nested functions like this, where a GET occurs to determine a new call, breaks the unitTestGen output. Need to figure out what's going on, and adjust the generator.

* PR Candidate

* PR Candidate (fixes)

* Reverting

* Fixing Edits.

* Fixing Authors - Fixing Requested Changes
2018-11-21 11:14:47 +05:30
ftntcorecse
1f1c1a0a16 Fortinet FortiManager Query Module (#46716)
* PR Candidate

* Fixing Edits. nixing Stale CI flag.

* Update lib/ansible/modules/network/fortimanager/fmgr_query.py

Co-Authored-By: ftntcorecse <43451990+ftntcorecse@users.noreply.github.com>

* Fixing Edits. Nixing Stale CI Tags

* Fixing Edits.

* Fixing Authors
2018-11-21 10:46:34 +05:30
ftntcorecse
d7e1e6429c FortiManager Web Application Firewall Security Profile (#46967)
* Initial Commit

* Initial Commit

* Initial Commit

* Fixing syntax errors

* After running sanity tests, fixed pylint and pep8 errors

* After running sanity tests, fixed pylint and pep8 errors

* Fixing more syntax issues

* Fixing more syntax issues

* Adding username to doc block

* PR candidate

* PR candidate

* fixed pep8 and docs issues

* fixed 2.6 function issues

* fixed 2.6 function issues part duex

* Initial commit for security profile group module

* Adding better playbook example to module

* Adding another commit to test shippable tests

* Fixing shippable errors, pep8 in unit test file and doc block problem in main module

* Fixing documentation module error

* Fixing pep8 line too long in unit test

* Fixing utility function with nested dictionaries

* Fixing utility function with pep8 issue

* Adding change to allow for multiple list of dictionaries to be submitted via a single playbook

* Initial commit for FMG Security Profile Web Application Firewall

* adding extra line at bottom for pep8 conditions

* Adding descriptions to documentation

* Fixing more pep8 issues

* New commit for new PR

* Removing todo in documentation

* Changing module name in documentation to match actual module name

* Fixing yaml syntax for long choices list

* Fixing yaml syntax for long choices list

* Fixing review changes

* Adding @ in author names per @Gundalow's request per Ansible's guidelines
2018-11-21 10:46:13 +05:30
ftntcorecse
a171b80a0c FortiManager Web Filter Security Profile (#47150)
* Initial Commit

* Initial Commit

* Initial Commit

* Fixing syntax errors

* After running sanity tests, fixed pylint and pep8 errors

* After running sanity tests, fixed pylint and pep8 errors

* Fixing more syntax issues

* Fixing more syntax issues

* Adding username to doc block

* PR candidate

* PR candidate

* fixed pep8 and docs issues

* fixed 2.6 function issues

* fixed 2.6 function issues part duex

* Initial commit for security profile group module

* Adding better playbook example to module

* Adding another commit to test shippable tests

* Fixing shippable errors, pep8 in unit test file and doc block problem in main module

* Fixing documentation module error

* Fixing pep8 line too long in unit test

* Fixing utility function with nested dictionaries

* Fixing utility function with pep8 issue

* Adding change to allow for multiple list of dictionaries to be submitted via a single playbook

* Initial commit for FMG Security Profile Web Application Firewall

* adding extra line at bottom for pep8 conditions

* Adding descriptions to documentation

* Fixing more pep8 issues

* New commit for new PR

* Removing todo in documentation

* Changing module name in documentation to match actual module name

* Fixing yaml syntax for long choices list

* Fixing yaml syntax for long choices list

* Initial commit for fmgr web filter security profile

* Fixing pep8 syntax issues

* Fixing documentation yaml syntax errors with choices on new lines

* Fixing documentation yaml syntax errors, removing Todo comments

* Fixing choices additional tab

* Fixing choices on multiple lines

* Fixing choices on multiple lines

* Adding yaml block scalar for multiline choices

* Changing YAML syntax for multiline to YAML sequence for choices

* Fixing all sanity test errors

* Fixing review changes

* Adding @ in author names per @Gundalow's request per Ansible's guidelines
2018-11-21 10:45:00 +05:30
ftntcorecse
199cd1bc77 FortiManager SSL SSH Security Profiles (#47152)
* Initial Commit

* Initial Commit

* Initial Commit

* Fixing syntax errors

* After running sanity tests, fixed pylint and pep8 errors

* After running sanity tests, fixed pylint and pep8 errors

* Fixing more syntax issues

* Fixing more syntax issues

* Adding username to doc block

* PR candidate

* PR candidate

* fixed pep8 and docs issues

* fixed 2.6 function issues

* fixed 2.6 function issues part duex

* Initial commit for security profile group module

* Adding better playbook example to module

* Adding another commit to test shippable tests

* Fixing shippable errors, pep8 in unit test file and doc block problem in main module

* Fixing documentation module error

* Fixing pep8 line too long in unit test

* Fixing utility function with nested dictionaries

* Fixing utility function with pep8 issue

* Adding change to allow for multiple list of dictionaries to be submitted via a single playbook

* Initial commit for FMG Security Profile Web Application Firewall

* adding extra line at bottom for pep8 conditions

* Adding descriptions to documentation

* Fixing more pep8 issues

* New commit for new PR

* Removing todo in documentation

* Changing module name in documentation to match actual module name

* Fixing yaml syntax for long choices list

* Fixing yaml syntax for long choices list

* Initial commit for fmgr web filter security profile

* Initial commit for SSL and SSH security profiles in FMG

* Fixing pep8 syntax issues

* Adding better playbook example

* Fixing review changes

* Adding @ in author names per @Gundalow's request per Ansible's guidelines
2018-11-21 10:44:35 +05:30
Abhijeet Kasurde
6965cea86a
Avoid implicit string concatenation in a list (#48718)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-11-21 10:22:58 +05:30