Commit graph

9155 commits

Author SHA1 Message Date
David Shrewsbury
789c1fcbe7 Correct port matching logic
Port matching logic did not take into account recent shade change
to equate (None, None) to (1, 65535) when Nova is the backend.

Also, this encapsulates the port matching logic into a single function
and heavily documents the logic.
2016-12-08 11:23:18 -05:00
Flyte
2f46364921 Provide correct kwargs to rds2 connection when making a final snapshot 2016-12-08 11:23:18 -05:00
David Shrewsbury
387fe5b0e7 Change required parameters for rules module
The ports and protocol are no longer required (and now depends on
a new version of shade).
2016-12-08 11:23:18 -05:00
Davide Guerri
531b93490b Fix reuse argument documentation 2016-12-08 11:23:18 -05:00
Davide Guerri
95cfe3da96 Update os_floating_ip with new shade methods 2016-12-08 11:23:18 -05:00
Monty Taylor
4f2028439f Use int in the parameter list instead of casting 2016-12-08 11:23:18 -05:00
dagnello
2c3fc61357 Resolving issues in rule comparison algorithm
Port range min/max values are at times represented as string and
compared to int equivalents.  This fix explicitly ensures all
port range values are ints for proper comparisons.
2016-12-08 11:23:18 -05:00
David Shrewsbury
e7dd93c5c1 Compare ports as strings
Ports as returned from shade are ints. They are strings as they come
in to the module.
2016-12-08 11:23:18 -05:00
David Shrewsbury
14212c37e2 Fix syntax error 2016-12-08 11:23:18 -05:00
Monty Taylor
60102e36e2 Return rule object 2016-12-08 11:23:18 -05:00
David Shrewsbury
174254a423 Update secgroup rules module for latest shade
This allows the rules module to work against either nova or neutron
for handling security groups. New parameters for 'direction' and
'ethertype' are added.

Check mode is supported with this version.
2016-12-08 11:23:18 -05:00
David Shrewsbury
fcc1d643f6 Recongnize None and -1 port equivalency
shade 0.7.0 represents disabled min/max ports as None (in the
neutron style) rather than -1. Recognize this as the same as -1.
2016-12-08 11:23:17 -05:00
David Shrewsbury
b42a9d56e6 Fix id value reference 2016-12-08 11:23:17 -05:00
David Shrewsbury
f02ec15c17 Update rules mode for latest shade
Shade 0.7.0 normalized the security group data that is returned,
when using nova, to look more like neutron security group data.
This adjusts for that change.
2016-12-08 11:23:17 -05:00
dagnello
ecef2aadba Minor fixes for os_security_group_rule module
Was not able to use this module as it was.  The changes submitted
resolved the issues I ran into in order to get it working.
2016-12-08 11:23:17 -05:00
Davide Guerri
2d7dbc5d0c Fix invalid syntax in openstack_module_kwargs call 2016-12-08 11:23:17 -05:00
Monty Taylor
9acc891477 Fix example code syntax 2016-12-08 11:23:17 -05:00
0tmc
6e4c5e0a12 Use of proper fstab file on FreeBSD 2016-12-08 11:23:17 -05:00
Monty Taylor
a657e80bc8 Add OpenStack Floating IP Module
Also deprecate the two old quantum floating ip modules.
2016-12-08 11:23:17 -05:00
Monty Taylor
8d5e43c14f Add OpenStack Security Group Rule module 2016-12-08 11:23:17 -05:00
Juho-Mikko Pellinen
321244d881 Remove empty aliases 2016-12-08 11:23:17 -05:00
Juho-Mikko Pellinen
54af79692a Add version number 2016-12-08 11:23:17 -05:00
Juho-Mikko Pellinen
f016cb556b Fix hosted_zone_id after rebase. 2016-12-08 11:23:17 -05:00
Juho-Mikko Pellinen
3f2d1e6bfa Add support for specifying unique hosted zone identifier 2016-12-08 11:23:17 -05:00
Scott Miller
62b6cf85d3 Update cloudformation.py
Fix for inaccurate phrasing
2016-12-08 11:23:17 -05:00
Brian Coca
e7dc05df11 updated upgrade to a more sensible default as the previous was prone to confusion fixes #1667 2016-12-08 11:23:17 -05:00
Robb Wagoner
848e9de950 remove double dict & fix increment bug 2016-12-08 11:23:16 -05:00
Mike Putnam
0e6e3e097e Upstream docs show launch_config_name as required.
http://docs.aws.amazon.com/AutoScaling/latest/APIReference/API_AutoScalingGroup.html

Fixes #11209

Ansible behavior is correct, this commit just updates the docs to
reflect that correctness.
2016-12-08 11:23:16 -05:00
verm666
ac40d9f41a fix authorized_keys in check_mode
This change is in response to issue #1515.
Original pull request #1580.

The original problem is: in authorized_key module you have no idea about users
which will be created by Ansible at first run. I can propose next two ways to
solve this problem:

  1. Combine modules system/user.py and system/authorized_key.py in one module
     (so you will know everything about users in that module)
  2. Use small workaround: add my commit and always provide 'path' parameter
     for authorized_key module during runs with --check option.
2016-12-08 11:23:16 -05:00
Matthew Gilliard
17a40aa259 Handle race condition in directory creation.
If we try to make a directory, but someone else creates the directory
at the same time as us, we don't need to raise that error to the user.
They asked for the directory to exist, and now it does. This fixes
the race condition which was causing that error to be raised, and
closes #1648.
2016-12-08 11:23:16 -05:00
Matt Martz
f33a8b09a9 Remove unnecessary imports in a docs only file for win_copy 2016-12-08 11:23:16 -05:00
Matt Martz
d47de74ade Replaced tabbed indentation with spaces for group module 2016-12-08 11:23:16 -05:00
Matt Martz
30d5c1166c Replaced tabbed indentation with spaces for subversion module 2016-12-08 11:23:16 -05:00
Matt Martz
a0f5ae8726 Replaced tabbed indentation with spaces for apt module 2016-12-08 11:23:16 -05:00
Matt Martz
3d28efaf7e Replace tabbed indentation with spaces for mysql_db module 2016-12-08 11:23:16 -05:00
Toshio Kuratomi
cf595b3c52 Fix indentation levels in os_keypair 2016-12-08 11:23:16 -05:00
Toshio Kuratomi
4c863187ad Few minor things from review of the pull request 2016-12-08 11:23:16 -05:00
verm666
6acfa5fcee unarchive: fix @bcoca's remarks, issue #1575 2016-12-08 11:23:16 -05:00
Toshio Kuratomi
432764b703 Add version that the profilename param was added 2016-12-08 11:23:16 -05:00
Jesse Keating
2b5af82706 Document auto_floating_ip argument 2016-12-08 11:23:16 -05:00
David Shrewsbury
3cd81d2dd3 Use newest documentation style for return value. 2016-12-08 11:23:16 -05:00
Jonathan Davila
f1027ae6bc no_log to iam password 2016-12-08 11:23:16 -05:00
David Shrewsbury
c4bc6dea13 Add a note about the return value. 2016-12-08 11:23:15 -05:00
Scott Miller
b43db1d2ff update docs for cloudformation 2016-12-08 11:23:15 -05:00
James Meickle
8197d7e640 Change uri debug example 2016-12-08 11:23:15 -05:00
Monty Taylor
c0190b0443 Fix dict syntax typo 2016-12-08 11:23:15 -05:00
Andreas Reischuck
3cc14a0a65 fixed win_file state=touch 2016-12-08 11:23:15 -05:00
ToBeReplaced
5e259a8dd9 Make ALL_IN_SCHEMA for tables affect views
ALL TABLES is considered to include views, so we must check for reltypes
'r' and 'v', not just 'r'. This bug was introduced due to using a
custom, backwards-compatible version of "ALL TABLES IN SCHEMA".
2016-12-08 11:23:15 -05:00
Robb Wagoner
372a2286db return health of instances and counts 2016-12-08 11:23:15 -05:00
verm666
b898cb656b unarchive: fix work with 0 bytes archives
This change is in response to issue #1575
2016-12-08 11:23:15 -05:00
Vladimir Martsul
db646757c1 Add "force" description
Add "force" option description
2016-12-08 11:23:15 -05:00
Patrick Roby
e638913c97 iterate through all keys in a more pythonic manner 2016-12-08 11:23:15 -05:00
Patrick Roby
bc5d79fc30 update documentation, adding new params 2016-12-08 11:23:15 -05:00
David Shrewsbury
341efbf7ae Update os_keypair for latest shade
Uses the latest version of shade for cleaner code. Also, always
return the key dict whether we create the key, or it already exists.
The example using public_key_file is corrected to use a full path
since ~ is not converted for us.
2016-12-08 11:23:15 -05:00
Evan Carter
98756144cf Add ClassicLink settings to EC2_launchconfig 2016-12-08 11:23:15 -05:00
Andrea Mandolo
ae1080d922 Added some block_device_mapping (disks) informations to EC2 instance module ouput 2016-12-08 11:23:15 -05:00
Andrea Mandolo
a8da674cf4 Added "EC2 instance" termination_protection and source_dest_check changeability at run-time 2016-12-08 11:23:15 -05:00
Tom Paine
df8013182e Parse out space characters in route53 value list
Fixes: https://github.com/ansible/ansible-modules-core/issues/992
2016-12-08 11:23:15 -05:00
Michael Weinrich
543cb13f42 Fix connection creation to allow usage of profiles with boto 2016-12-08 11:23:15 -05:00
Toshio Kuratomi
f422782180 Use module.fail_json() instead of sys.exit() 2016-12-08 11:23:14 -05:00
Toshio Kuratomi
53c840e275 Add testing of docs to the core repo 2016-12-08 11:23:14 -05:00
Brian Coca
b261fd8d3e added doc to note that git the command line tool is required for this moduel to function fixes http://github.com/ansible/ansible/issues/11358 2016-12-08 11:23:14 -05:00
Brian Coca
e91818ef77 updated docs to clarify use of exclusive 2016-12-08 11:23:14 -05:00
Roetman, Victor
fa612a14b1 apache2_module documetation update
requires a2enmod and a2dismod
2016-12-08 11:23:14 -05:00
Ash Wilson
9f12fd0a26 Default net to 'bridge' in container diff
This prevents an unnecessary reload when the `net` parameter is unspecified
(i.e. almost always).
2016-12-08 11:23:14 -05:00
verm666
9b3aa0a9d4 This change is in response to issue #133.
The original problem is: apt_repository.py connect to launchpad on
every playbook run. In this patch apt_repository.py checks if required
repository already exists or not. If no - paa will be added, if yes -
just skip actions.
2016-12-08 11:23:14 -05:00
Michael Weinrich
a0466f1f8d Add the option to pass a string as policy 2016-12-08 11:23:14 -05:00
Monty Taylor
869da89b35 Move the order of argument processing 2016-12-08 11:23:14 -05:00
Monty Taylor
377311db56 Add filter ability 2016-12-08 11:23:14 -05:00
Ed Hein
f11c451bfa Fix computation of port bindings. Port bindings configuration can be a list if several host ports are bound to the same guest port. 2016-12-08 11:23:14 -05:00
Davide Guerri
c1d7678cc2 Avoind using lookup() in documentation
lookup() is currently broken (current Ansible devel branch), so better to avoid
it in our examples.
2016-12-08 11:23:14 -05:00
Konstantin Gribov
8d91c3a61a Escape spaces, backslashes and ampersands in fstab
Fixes #530.

It's more generic than #578 which only fixes spaces escaping in name (target dir to mount).
Escaping is used in both `set_mount` (important for `src`, `name` and `opts`) and
`unset_mount` (for `name`).

It's shouldn't be used in `mount` and `umount` since `name` parameter is passed as array element
to `module.run_command`.

Signed-off-by: Konstantin Gribov <grossws@gmail.com>
2016-12-08 11:23:14 -05:00
Arata Notsu
cc76a479e1 Not use "is" to compare strings
As "is" tests whether if operands are the same object rather than
they have the same value, potentially causes a wrong result.
2016-12-08 11:23:14 -05:00
Bryan Fleming
6f8d60a5ed fixes #1120 - privileges using columns 2016-12-08 11:23:13 -05:00
Lucas David Traverso
20aa4c0cea django_manage: Use shebang in manage.py instead of hardcode python 2016-12-08 11:23:13 -05:00
Andrew Davis
4d4d911d6e ansible_facts reflects 1.8 output 2016-12-08 11:23:13 -05:00
Monty Taylor
0c0359798b Add OpenStack Keypair module
Also deprecate old nova_keypair module.
2016-12-08 11:23:13 -05:00
Ash Wilson
ea83727fcf Wait for process exit on detached=no. 2016-12-08 11:23:13 -05:00
Ian Clegg
f9c294f1ad Added support for comma seperated feature names in the name parameter of the win_feature module 2016-12-08 11:23:13 -05:00
Tagir Bakirov
8bd367eac7 added 'absent' option to supervisorctl 2016-12-08 11:23:13 -05:00
Stefan Junker
4ee972190b docker: Use a list instead of a dict for volumes according to the docker-py docs. Do not add host-binds to volumes list. 2016-12-08 11:23:13 -05:00
gimoh
fd69c5687b Do not insert extra newline if line already contains it
When using YAML multi-line strings, e.g.:

- lineinfile:
    dest: /tmp/foo
    line: >
      foo
      bar

the line already ends with a newline.  If an extra newline is appended unconditionally it will lead to inserting an extra newline on each run.
2016-12-08 11:23:13 -05:00
Jens Carl
9ad15cdae9 - List the name servers of a zone. 2016-12-08 11:23:13 -05:00
Alexis Seigneurin
53e9caa1d0 - 'name' should not be required so as to allow uninstalling a cron_file 2016-12-08 11:23:13 -05:00
Annika Backstrom
6b2c89a422 Force redownload if sha256sum does not match 2016-12-08 11:23:13 -05:00
Igor Khomyakov
03483d2ea5 Check if a service exists 2016-12-08 11:23:13 -05:00
Federico G. Schwindt
b6258a1e4c Document globbing support 2016-12-08 11:23:13 -05:00
sysadmin75
f096359608 ansible-modules-core #530 fix - Mount module does not accept spaces in mount point path 2016-12-08 11:23:13 -05:00
Chris Church
3048626d6e Update docs, add example of using django_manage to run other commands. 2016-12-08 11:23:13 -05:00
Stefan Junker
50fe57fff3 Fix bind-volumes on docker >= 1.4.0
If bind-volumes are submitted to docker >= 1.4.0 with the volumes set in addition to the binds, docker will create a regular volume and not bind-mount the specified path.
2016-12-08 11:23:13 -05:00
Federico G. Schwindt
fa463fb1b7 Allow globbing in creates= and removes= directives
Fixes 1904
2016-12-08 11:23:12 -05:00
Robb Wagoner
e025effc99 include all launch config properties in the return
make all properties available when registering the result
which is useful when wanting to launch a stand-alone instance based upon
an existing Launch Config.
2016-12-08 11:23:12 -05:00
Toshio Kuratomi
870446dd6b Update version_added to 2.0 for the partial option 2016-12-08 11:23:12 -05:00
Jonathan Davila
82b809f0e2 new vpc module. does not contain subnet or route table functionality.
changed name to ec2_vpc_net

refactored out IGW functionality
2016-12-08 11:23:12 -05:00
Juan Picca
81ea358b09 synchronize module: add partial option 2016-12-08 11:23:12 -05:00
Toshio Kuratomi
5118d0e3b1 Add note about redirects proxies
Fixes #1574
2016-12-08 11:23:12 -05:00
Toshio Kuratomi
0a3150f7d7 Add version_added documentation to log_driver parameter 2016-12-08 11:23:12 -05:00
Toshio Kuratomi
9ecd06fb47 Fix apt_repository so that it does not modify the mode of existing repositories 2016-12-08 11:23:12 -05:00
Michael Weinrich
1f6c177da0 Use aws connect calls that allow boto profile use 2016-12-08 11:23:12 -05:00
Ryan Walls
01a28e7d80 Fix typo in Docker module. 2016-12-08 11:23:12 -05:00
Ryan Walls
9630972c2c Update docker module to avoid false positives when containers are first created. Also have the module check for api compatibility before trying to set a "--log-driver" option. 2016-12-08 11:23:12 -05:00
Ryan Walls
f5c1d8141b Set default "log_driver" option to None in docker module. 2016-12-08 11:23:12 -05:00
Ryan Walls
0df1b01cb2 Update docker module to look at log_driver variable when deciding if container configuration has changed. 2016-12-08 11:23:12 -05:00
Ryan Walls
3419a1e253 Add support for --log-driver option that docker released with Docker 1.6 2016-12-08 11:23:12 -05:00
Alex King
c8ae53b308 Extend hashes that can be specified by crypt_scheme beyond those understood by Apache/Nginx. 2016-12-08 11:23:12 -05:00
Sebastian Gerhards
a979417a4a rhn_register: add support for profilename 2016-12-08 11:23:12 -05:00
Jim Patterson
4185ffc43e Correct check mode for pip in virtualenv.
Fix #412.  Check mode was always returning changed=True for pip
when the target was in a virtualenv.  The code now uses the normal
tests for determining if change status.
2016-12-08 11:23:11 -05:00
Lorin Hochstein
abf314c258 django_manage: expand ~ in app_path parameter
Allow users to specify app_path parameters that contain ~, for example:

app_path=~/myproject
2016-12-08 11:23:11 -05:00
Pierre-Louis Bonicoli
c366e7acb2 apt_repository: fix file mode
'set_mode_if_different' method should be called on dest filename and after
'atomic_move' method
2016-12-08 11:23:11 -05:00
Patrick Roby
b318bc8b43 Add support for listing keys in a specific S3 bucket
Includes support for specifying a prefix, marker, and/or max_keys. Returns a list of key names (as strings).
2016-12-08 11:23:11 -05:00
James Cammarata
4239922d07 Updating version_added for new spot_type param in ec2 module
Also made sure 'choices' were set on the module param, to catch errors
in user's playbooks, etc.
2016-12-08 11:23:11 -05:00
Toshio Kuratomi
cb776e6190 Fix for when the password file did not exist previously 2016-12-08 11:23:11 -05:00
Jay Taylor
ed279d8175 Added support for spot request type specification (to support persistent spot requests). 2016-12-08 11:23:11 -05:00
Toshio Kuratomi
bd87c11c2a Read the url in in chunks so that we don't use as much memory for large packages 2016-12-08 11:23:11 -05:00
Toshio Kuratomi
2e7dcf3317 Small cleanups. * Import url(lib|parse|lib2) if needed by the module rather than relying on module_utils.urls to do so. * Remove stdlib modules from requirements * Use the if __name__ conditional for invoking main() 2016-12-08 11:23:11 -05:00
Toshio Kuratomi
5f27a073ba Bump amount of file to download in a chunk to 64k. 2016-12-08 11:23:11 -05:00
Jonathan Mainguy
dd0659c83d add download ability to unarchive module 2016-12-08 11:23:11 -05:00
zimbatm
99e2557b42 route53: add support for routing policies
It is now possible to pass various routing policies if an identity is
provided.

This commit also introduces multiple optimisations:
* Only fetch records for the given domain
* Use UPSERT instead of DELETE+CREATE to update existing records
2016-12-08 11:23:11 -05:00
billwanjohi
86e679fe3c iam: use modern helper to allow sts
previous implementation ignored the session token when present
2016-12-08 11:23:11 -05:00
James Cammarata
5cd3c6ebe6 Update choices and version_added for new gce.py param service_account_permissions 2016-12-08 11:23:11 -05:00
Michal Smereczynski
9d4b252f56 Added new Premium Storage instance sizes and case-related documentation clarification. 2016-12-08 11:23:11 -05:00
murdochr
aae140e6cd Change docs to reflect correct when syntax for matching variable strings as per MD's forum post as this fails with unhelpful error otherwise.
https://groups.google.com/forum/#!topic/ansible-project/D2hQzZ_jNuM
2016-12-08 11:23:11 -05:00
Monty Taylor
186fbd7645 Remove duplicate shade requirement 2016-12-08 11:23:10 -05:00
Monty Taylor
73cb529d2c Make sure we're always returning objects too 2016-12-08 11:23:10 -05:00
dagnello
072110c757 Resolving secgroup.id issue in this module
secgroup['id'] was not being returned in all cases where the
specified security group exists.
2016-12-08 11:23:10 -05:00
toninog
bea77c938e fixes to code to enable updates of user to groups and delete groups. Fixed example yaml to use groups 2016-12-08 11:23:10 -05:00
toninog
ab7678f199 Fixed more issues with the delete_group and paramater mismatch 2016-12-08 11:23:10 -05:00
Jonathan Mainguy
c9d1cc0ce3 remove blank lines from htpasswd file
used standard mktemp()
2016-12-08 11:23:10 -05:00
Vasyl Kaigorodov
758688a667 GCE module: added Service Account permissions sanity checks 2016-12-08 11:23:10 -05:00
Vasyl Kaigorodov
4400c5e163 GCE module: document Service Account permissions parameter usage 2016-12-08 11:23:10 -05:00
Vasyl Kaigorodov
97e880a27f GCE module: add posibility to specify Service Account permissions during instance creation 2016-12-08 11:23:10 -05:00
Jonathan Davila
6482ad964f iam certificate module
boto import tweak

style patch
2016-12-08 11:23:10 -05:00
Dan Abel
a51a8e1fd6 use aws connect calls that allow boto profile use 2016-12-08 11:23:10 -05:00
Hagai Kariti
b46a1ff3e1 Hostname module should update ansible_hostname 2016-12-08 11:23:10 -05:00
Vyronas Tsingaras
654d2d3f60 This enable one to find a datastore with no config_target supplied
Signed-off-by: Vyronas Tsingaras <vtsingaras@it.auth.gr>
2016-12-08 11:23:10 -05:00
Jon Hawkesworth
a00d86946d document file size limit for win_copy module 2016-12-08 11:23:10 -05:00
Vyronas Tsingaras
56957ca45e Remember power state when starting vm reconfigure
This commit fixes #1391

Signed-off-by: Vyronas Tsingaras <vtsingaras@it.auth.gr>
2016-12-08 11:23:10 -05:00
Matt Martz
158772ffc2 Fix some remaining rax asg idempotency checks 2016-12-08 11:23:10 -05:00
Benno Joy
17c185c8d1 enable azure to provision windows instances 2016-12-08 11:23:09 -05:00
Benno Joy
2314670952 enable the module to provision windows instances 2016-12-08 11:23:09 -05:00
Colin Hutchinson
97a2cd0bd9 Indentation fix for with and register in the ec2_vol example 2016-12-08 11:23:09 -05:00
Ritesh Khadgaray
9c3f9d23c8 Add the ability to grep for content 2016-12-08 11:23:09 -05:00
Vyronas Tsingaras
bdb33b5756 Properly check if vm_hardware contains keys
This commit fixes #1475

Signed-off-by: Vyronas Tsingaras <vtsingaras@it.auth.gr>
2016-12-08 11:23:09 -05:00
Vyronas Tsingaras
262e86b36b Use either esxi:dc,host OR cluster,resource_pool
vsphere_guest now can deploy a template using a datacenter and hostname
as the target, instead of requiring a cluster and resource_pool.

This commit fixes #951.

Signed-off-by: Vyronas Tsingaras <vtsingaras@it.auth.gr>
2016-12-08 11:23:09 -05:00
Robin Roth
abc89f0df5 add comment: ports need to be exposed.
port mapping with this module only works for ports that are exposed either in the Dockerfile or via an additional arguments. This is different from the command line docker client, that is willing to also map ports that are not exposed.

This comments makes the behaviour more obvious.
2016-12-08 11:23:09 -05:00
Monty Taylor
8ff71a3fa8 Actually use changed variable 2016-12-08 11:23:09 -05:00
Monty Taylor
4125b576e9 Return the secgroup for all present states 2016-12-08 11:23:09 -05:00
Monty Taylor
b955b2f5c8 Return resource objects from OpenStack modules
It's not uncommon for people to want to do additional things after
creating a module. Also, add a note about it to the dev notes.
2016-12-08 11:23:09 -05:00
Monty Taylor
89f95471f8 Return secgroup, not just id 2016-12-08 11:23:09 -05:00
Philip Kirkland
cc214afed6 adding 'encrypted' option into volume dict so ec2 module can easily include encrypted volumes 2016-12-08 11:23:09 -05:00