Commit graph

7272 commits

Author SHA1 Message Date
Maykel Moya 1a79d9ae58 apt_key: Validate key_id and accept a leading '0x' 2013-10-16 20:52:18 +02:00
Lorin Hochstein 1c5bdba977 s3: better check for walrus
Check for Walrus endpoint by looking to see if the endpoint is not AWS.

This fixes a bug where the user specifies an AWS endpoint via S3_URL,
but the code interprets it as Walrus and then fails.
2013-10-16 13:22:41 -04:00
Tomaz Muraus 922f61899e Throw a more user-friendly exception during template rendering process. 2013-10-16 16:48:17 +02:00
James Tanner 807e602228 mysql_db: if connection is a socket, do not specify hostname 2013-10-16 09:59:31 -04:00
James Tanner 84a692bcf7 Fixes #4301 Use module_common functions for mysqldump and return better errors 2013-10-16 09:51:08 -04:00
Michael DeHaan efe2a9fb1d Merge pull request #4538 from mulby/gabe/arguments-sudo
Ensure non-root users can read arguments file when using sudo_user and non-standard modules
2013-10-16 06:07:55 -07:00
Yap Sok Ann 8519d586ba git: Don't add --branch while cloning if the version is a SHA-1 hash. 2013-10-16 20:37:07 +08:00
Yap Sok Ann 9f8cdac0aa git: Handle network problem when running git ls-remote. 2013-10-16 20:37:07 +08:00
Yap Sok Ann a53e7045a6 git: Always return the before/after revisions, even in check mode.
The return values from check mode and non-check mode should match in all cases,
except when a SHA-1 hash is used as version, as there is no way to check if it
is a valid hash using `git ls-remote`.

Also, to accomodate this change, the force flag for the reset function has been
removed so that we can do the checking in main.
2013-10-16 20:37:07 +08:00
Yap Sok Ann b9558828e8 git: Make function get_remote_head usable when cloning.
This allows the module to return the before/after revisions in all cases.
2013-10-16 20:37:07 +08:00
Yap Sok Ann 2ad4d77c9a git: Remove unnecessary return code checking.
The functions either return rc=0 or call fail_json themselves.
2013-10-16 20:37:06 +08:00
Yap Sok Ann 9af05f4d2f git: Full length SHA-1 in, full length SHA-1 out.
This removes ambiguity at the expense of slight backward incompatibility.
2013-10-16 20:37:06 +08:00
Gabe Mulley 84a57b7545 ensure non-root users can read arguments file when using sudo_user
Non-standard modules must read in the arguments file in order to access their arguments, however, when this file is transfered to the remote host it may only have the permissions 600.  This means that using sudo and sudo_user will result in permission denied errors when attempting to read the arguments file.

This patch fixes #4438 by explicitly forcing the arguments file to be world readable before executing the module.
2013-10-16 08:18:11 -04:00
Michael DeHaan afa781d628 Merge pull request #4530 from geerds/feature/use-bash-executable-in-subprocess-call
Fix TestInventory class by explicitly using /bin/bash
2013-10-15 17:38:19 -07:00
James Tanner 00f3ec645d Fixes #4532 Send easy_install to get_bin_path instead of None 2013-10-15 18:15:08 -04:00
Jascha Geerds 76ed19d279 Fix TestInventory class by explicitly using /bin/bash 2013-10-15 21:34:36 +02:00
jctanner 33faaaa9a0 Merge pull request #4529 from bcoca/warns_no_conflict
fixed name colision between warnings dict and module
2013-10-15 12:12:33 -07:00
Brian Coca bd9acedb57 fixed name colision between warnings dict and module
Signed-off-by: Brian Coca <briancoca+ansible@gmail.com>
2013-10-15 14:58:15 -04:00
James Tanner 7061c99049 fix indentation in easy_install module docstring 2013-10-15 12:49:43 -04:00
Michael DeHaan ebbf845e09 Merge pull request #4520 from jaugustin/patch-1
[doc] duplicate group in usa:children group
2013-10-15 08:23:52 -07:00
Michael DeHaan cb87a94515 Merge pull request #4519 from mmoya/fixes
Fix building of docsite
2013-10-15 08:23:32 -07:00
Jérémie Augustin ddf1d71b7d [doc] duplicate group in usa:children group 2013-10-15 17:18:07 +02:00
Maykel Moya cd051c4a0d Fix building of docsite
* Fix paths in docsite/Makefile having an additional '..'.
* Ignore generated docsite/rst/modules/*.rst
2013-10-15 16:21:19 +02:00
James Cammarata 35284818a9 Handle ssh key files that may only have a type/key specified
If a specified key did not have a comment, it would be ignored as
an invalid key.

Fixes #4513
2013-10-15 09:05:50 -05:00
James Tanner 6b60267898 Document per task remote_user, based on #3932 2013-10-15 09:40:37 -04:00
jctanner 69fa5954fd Merge pull request #3932 from jocelynj/devel
Add option remote_user to task level, to specify the ssh login user
2013-10-15 06:34:57 -07:00
Stefan Heinemann af704562a9 Set the options of an authorized key comma separated
According to the sshd man page, no spaces are permitted between the
options of an authorized ssh key
2013-10-15 15:29:52 +02:00
Stefan Heinemann 346d46a94c Don't mind the options of a key when removing it
This allows to remove a key without knowing the options in the
authorized_key file
2013-10-15 15:29:47 +02:00
Michael DeHaan e131de4de0 Added "debug: var=variableName" capability. 2013-10-14 21:01:38 -04:00
Michael DeHaan 84ff24d92c Merge pull request #4346 from dmkoch/digitalocean-droplet-options
Add "virtio" and "private_networking" options for DigitalOcean droplets
2013-10-14 17:05:06 -07:00
Michael DeHaan 8349c04d06 Merge pull request #4488 from renanivo/devel
create install_options parameter for homebrew module
2013-10-14 16:47:59 -07:00
Michael DeHaan aa57e75f1a Merge pull request #4504 from eggsby/realpath
Adding os realpath filter.
2013-10-14 16:46:53 -07:00
egghead ca7e2d283c Adding os realpath filter.
This is particularly useful when wanting to get the absolute path of filepaths found by the 'fileglob' filter.
This also lets you provide absolute paths to roles, which search for files in different areas unless absolutely pathed.
2013-10-14 23:41:16 +00:00
jctanner 79071aee79 Merge pull request #4470 from jyap808/patch-1
Assume state='directory' if recurse is set and previous state was 'direc...
2013-10-14 13:49:35 -07:00
Michael DeHaan b8ec300d4c Add note about feature being new in 1.4 2013-10-14 11:57:19 -04:00
Constantine Peresypkin 4bd485d87f fixed identity type not set in inventory/rax.py plugin 2013-10-14 11:57:19 -04:00
Constantine Peresypkin 499a2fe456 add support for disk_config option to cloud/rax module 2013-10-14 11:57:19 -04:00
Michael DeHaan 6ff4806b90 Merge branch 'devel' of git://github.com/shirou/ansible into devel 2013-10-14 11:50:25 -04:00
Pedro Romano e6062db92f Implement a '_get_easy_install' helper function to find the desired
'easy_install' executable, modeled on '_get_pip'
from the 'pip' module to correctly handle all combinations of explicit
executable and virtualenv.
2013-10-14 11:48:45 -04:00
Pedro Romano 307dd77589 Refactor helper function '_get_pip' to handle the cases where an absolute
path explicit executable is passed to the task and to look for an explicit executable
by basename in a virtualenv if that is specified.
2013-10-14 11:48:28 -04:00
Pedro Romano 57a71043a3 New module argument to specify the executable used for running 'pip'. This allows support for system installation of packages on systems with multiple installations of Python. 2013-10-14 11:48:28 -04:00
Pedro Romano 3c33273071 New module argument to specify the executable used for running 'easy_install'. This allows support for system installation of packages on systems with multiple installations of Python. 2013-10-14 11:48:27 -04:00
Pedro Romano 48e50a9c11 Rename copy/pasted variables more appropriately. 2013-10-14 11:47:59 -04:00
Pedro Romano 5a5d431fa1 Changes examples from using Flask to some other package (Bottle was chosen) as per @mpdehaan's suggestion. 2013-10-14 11:47:59 -04:00
Michael DeHaan 4369fdccb3 Merge pull request #3851 from jlafon/devel
env-setup for fish users
2013-10-14 08:43:53 -07:00
Michael DeHaan 54b5548068 Slight tweak to ovirt module docs. 2013-10-14 11:43:01 -04:00
Michael DeHaan f6eae5571a Update version_added in ovirt module. 2013-10-14 11:41:24 -04:00
Michael DeHaan 33f6f3ddb9 Add changelog note about new ovirt module 2013-10-14 11:41:03 -04:00
Michael DeHaan 5dd25692d4 Merge pull request #3838 from vincentvdk/ovirt-mod
added new module "ovirt"
2013-10-14 08:40:07 -07:00
Michael DeHaan bc0cfe8436 Add changelog note that the ACL module was added. 2013-10-14 11:37:14 -04:00