Brian Coca
06ecdaa7b1
comment heavy playbook ( #68981 )
...
* create examples/play.yml
Co-authored-by: flowerysong <junk+github@flowerysong.com>
2020-05-19 17:27:08 -04:00
Toshio Kuratomi
25c5388fde
Update compile skip; all release and docs build scripts require 3.6+
2020-05-14 09:14:37 -07:00
Bob Weinand
f200487414
Fix filedescriptor out of range in select() when running commands ( #65058 )
...
* Fix filedescriptor out of range in select() when running commands
* Simplify the run_command() code
Now that we're using selectors in run_command(), we can simplify some of
the code.
* Use fileobj.read() instead of os.read()
* No longer use get_buffer_size() as we can just slurp all of the data
instead.
Also use a simpler conditional check of whether the selector map is
empty
Co-authored-by: Toshio Kuratomi <a.badger@gmail.com>
2020-05-14 11:46:34 -04:00
Matt Martz
4c4406b2df
Flatten the directory hierarchy of modules ( #68966 )
...
* Flatten the directory hierarchy of modules
* Update ignore.txt, flatten units
* Update imports
* Completely flatten the modules directory
* Update sanity ignore
* Fix some sanity test ignores
* Fix relative import
* Fix docs builds without category
* ci_complete
* Clean up docs. ci_complete
* Adjust needs/file alias
* ci_complete
* fix hardcoded ping module paths
Co-authored-by: Matt Davis <mrd@redhat.com>
2020-05-13 19:14:53 -07:00
Felix Fontein
0e15375ffe
Add deprecated removed_in_version and deprecated_aliases version tests ( #66920 )
2020-05-13 13:58:09 -07:00
Rick Elrod
98fbd1b72f
lint
...
Signed-off-by: Rick Elrod <rick@elrod.me>
2020-05-07 21:44:13 -05:00
Toshio Kuratomi
39b3942048
Remove left hand side slicing
...
Left hand side slicing is confusing and slower but maybe more memory
efficient in some circumstances. There is one case where it adds to
code safety: when it's used to substitute a different list in place of a
slice of the original list and the original list could have been bound
to a different variable in some other code. (The most likely case of
this is when it's a global variable and some other code might import
that variable name).
Because of the confusion factor we think it should only be used for the
safety case or where it's been benchmarked and shown to have some sort
of documentatble improvement. At the moment, only one piece of code
falls into those categories so this PR removes all the other instances
of left hand side slicing.
2020-05-06 09:56:40 -07:00
Rick Elrod
cace616aab
Filter BLACKLIST_EXTS in PluginLoader ( #69029 )
...
Change:
Rather than hardcoding .pyo and .pyc, filter on all BLACKLIST_EXTS in
the non-legacy logic of PluginLoader (_find_fq_plugin). The two harcoded
extensions are part of BLACKLIST_EXTS already and this simply adds the
rest of the blacklisted extensions to the check.
In addition, check .endswith() instead of an exact match of the suffix,
like everywhere else that uses BLACKLIST_EXTS. This allows for
blacklisting, for example, emacs's backup files which can appear after
any extension, leading to things like `foo.py~`.
Test Plan:
Ran `ansible-playbook` against a collection where a `foo.py~` module was
getting executed instead of `foo.py` which also appeared in the same
directory. `foo.py~` is no longer executed.
Tickets:
Fixes #22268
Refs #27235
Signed-off-by: Rick Elrod <rick@elrod.me>
2020-04-22 17:20:12 -05:00
Matt Clay
122743ae30
Update ansible-test handling of delegation paths. ( #69056 )
2020-04-20 22:04:25 -07:00
Martin Krizek
acdc9eb76d
native types: literal_eval all the things ( #68938 )
...
With https://github.com/pallets/jinja/pull/1190 merged our short-circuit
is no longer valid (has it ever been?) as now data like ' True ' may go
through our ansible_native_concat function as opposed to going through
intermediate call to Jinja2's native_concat before. Now we need to always
send data through literal_eval to ensure native types are returned.
2020-04-17 14:59:52 +02:00
Jordan Borean
79fff7da69
Expose to_<str> as a public function ( #68965 )
...
* Expose to_<str> as a public function
* Fix sanity checks
* Move docstring to start of util
2020-04-17 07:54:00 +10:00
Jordan Borean
702949e64c
windows - fix up env var quoting for unicode single quotes ( #68968 )
...
* windows - fix up env var quoting for unicode single quotes
* Add sanity ignore check for smart quotes
2020-04-16 20:24:23 +10:00
jctanner
f11b1454bb
prepare for future ansibot collection changes ( #68944 )
2020-04-14 13:11:05 -04:00
Matt Martz
40d9650f20
Migrate apt_repo to community.general. Fixes #68637 ( #68641 )
2020-04-02 11:06:12 -05:00
Matt Clay
0fb5593abf
Add initial ansible-test tests for collections. ( #68533 )
2020-03-29 09:04:27 -07:00
Matt Clay
4fc10186b9
Move coding guidelines links to readme. ( #68479 )
2020-03-26 15:19:01 -04:00
Matt Clay
206896e9b2
Cleanup refs to deleted files/dirs. ( #68480 )
...
* Remove deleted contrib dir from MANIFEST.in
* Update package-data sanity test.
Remove deleted files and directories.
* Remove aws_config dirs.
2020-03-25 19:10:27 -07:00
Sandra McCann
8042d226e4
fix make webdocs warnings ( #68411 )
2020-03-25 13:13:56 -05:00
jctanner
c067beecda
disable bot notification spam ( #68460 )
...
* disable bot notification spam
* add new key to botmeta sanity
2020-03-25 11:45:53 -04:00
Jordan Borean
48bef155fd
Ignore test files in new package-data sanity test ( #68452 )
2020-03-25 10:57:14 +10:00
Brian Coca
a9d2ceafe4
prevent ansible_facts injection ( #68431 )
...
- also only replace when needed
- switched from replace to index
- added test to verify bogus_facts are not accepted
CVE-2020-10684
2020-03-24 15:46:56 -04:00
Matt Davis
ed9de94ad9
remove azure extras and extras_require support ( #67822 )
...
* remove azure extras and extras_require support
* Since Azure will be collectionized, the requirements will float more frequently than Ansible releases; the Azure collection needs to host the requirements now.
* Removed the dynamic extras support as well, since Azure was the only thing using it. If we need it again, it's easy to pull back from history.
* Mark azure-requirements as orhpaned.
This keeps the docs around so that existing links from old test runs remain valid.
Co-authored-by: Matt Clay <matt@mystile.com>
2020-03-23 13:07:33 -07:00
Matt Clay
5a1b59adf9
Rename tests ( #68356 )
...
* Rename `tests` test to match plugin type.
* Rename `test_infra` test to avoid confusion.
This test target is not a test for test plugins.
* Rename `vars_prompt` test to avoid confusion.
* Update sanity ignores.
2020-03-23 11:14:21 -05:00
Matt Clay
815a36d7a9
Fix sanity test ignores.
2020-03-23 11:14:21 -05:00
Alicia Cozine
69543b47c9
fix last 7 docs errors on post-migration test runs ( #68115 )
...
* address toc-tree-glob-pattern-no-match errors
* address Include-file-not-found error
* address 2.10 porting guide errors, add warning to page
* updates individual plugin type pages
* Add ignores.
Co-authored-by: Alicia Cozine <acozine@users.noreply.github.com>
Co-authored-by: Matt Clay <matt@mystile.com>
2020-03-23 11:14:21 -05:00
Ansible Core Team
c788ee69d9
Migrated to wti.remote
2020-03-23 11:14:21 -05:00
Ansible Core Team
cc2feea51b
Migrated to vyos.vyos
2020-03-23 11:14:21 -05:00
Ansible Core Team
40714dfca9
Migrated to openvswitch.openvswitch
2020-03-23 11:14:21 -05:00
Ansible Core Team
ab914b9ab6
Migrated to azure.azcollection
2020-03-23 11:14:21 -05:00
Ansible Core Team
fe0f4750e1
Migrated to purestorage.flashblade
2020-03-23 11:14:21 -05:00
Ansible Core Team
d9920706d7
Migrated to purestorage.flasharray
2020-03-23 11:14:21 -05:00
Ansible Core Team
7449ec1546
Migrated to google.cloud
2020-03-23 11:14:21 -05:00
Ansible Core Team
fb696bf66b
Migrated to cyberark.bizdev
2020-03-23 11:14:21 -05:00
Ansible Core Team
b82d084e90
Migrated to skydive.skydive
2020-03-23 11:14:21 -05:00
Ansible Core Team
dd5a8dec21
Migrated to hetzner.hcloud
2020-03-23 11:14:21 -05:00
Ansible Core Team
36a545553e
Migrated to dellemc_networking.os6
2020-03-23 11:14:21 -05:00
Ansible Core Team
bc40fe0b6f
Migrated to dellemc_networking.os9
2020-03-23 11:14:21 -05:00
Ansible Core Team
0b633b3703
Migrated to dellemc_networking.os10
2020-03-23 11:14:21 -05:00
Ansible Core Team
d1f86d7151
Migrated to ovirt.ovirt
2020-03-23 11:14:21 -05:00
Ansible Core Team
02541a15b2
Migrated to awx.awx
2020-03-23 11:14:21 -05:00
Ansible Core Team
35063de590
Migrated to junipernetworks.junos
2020-03-23 11:14:21 -05:00
Ansible Core Team
8ee0187388
Migrated to openstack.cloud
2020-03-23 11:14:21 -05:00
Ansible Core Team
6ce86295c0
Migrated to f5networks.f5_modules
2020-03-23 11:14:21 -05:00
Ansible Core Team
675129ae19
Migrated to cisco.ucs
2020-03-23 11:14:21 -05:00
Ansible Core Team
3149db0869
Migrated to cisco.nxos
2020-03-23 11:14:21 -05:00
Ansible Core Team
ae8fb5e371
Migrated to cisco.mso
2020-03-23 11:14:21 -05:00
Ansible Core Team
8a3f3e41f8
Migrated to cisco.meraki
2020-03-23 11:14:21 -05:00
Ansible Core Team
5aa37733c3
Migrated to cisco.iosxr
2020-03-23 11:14:21 -05:00
Ansible Core Team
7e04b5ba8b
Migrated to cisco.ios
2020-03-23 11:14:21 -05:00
Ansible Core Team
8a2e2e8af2
Migrated to cisco.intersight
2020-03-23 11:14:21 -05:00
Ansible Core Team
ab5a3b4305
Migrated to cisco.asa
2020-03-23 11:14:21 -05:00
Ansible Core Team
3f1cea89fb
Migrated to cisco.aci
2020-03-23 11:14:21 -05:00
Ansible Core Team
14b0ab63ac
Migrated to arista.eos
2020-03-23 11:14:21 -05:00
Ansible Core Team
6da1ec1d8c
Migrated to check_point.mgmt
2020-03-23 11:14:21 -05:00
Ansible Core Team
f0cf2c159b
Migrated to netapp.ontap
2020-03-23 11:14:21 -05:00
Ansible Core Team
cae9d633b0
Migrated to netapp.elementsw
2020-03-23 11:14:21 -05:00
Ansible Core Team
0a9205b7c0
Migrated to netapp.aws
2020-03-23 11:14:21 -05:00
Ansible Core Team
bdd82adf61
Migrated to netbox.netbox
2020-03-23 11:14:21 -05:00
Ansible Core Team
09d8d46983
Migrated to fortinet.fortios
2020-03-23 11:14:21 -05:00
Ansible Core Team
48d4e9370e
Migrated to ansible.windows
2020-03-23 11:14:21 -05:00
Ansible Core Team
829eb0f1d1
Migrated to ansible.posix
2020-03-23 11:14:21 -05:00
Ansible Core Team
9a7a574ffc
Migrated to ansible.netcommon
2020-03-23 11:14:21 -05:00
Ansible Core Team
6d910034a0
Migrated to ansible.amazon
2020-03-23 11:14:21 -05:00
Ansible Core Team
8f7e9f73ce
Migrated to servicenow.servicenow
2020-03-23 11:14:21 -05:00
Ansible Core Team
bb3494356a
Migrated to community.windows
2020-03-23 11:14:21 -05:00
Ansible Core Team
40218535ee
Migrated to community.vmware
2020-03-23 11:14:21 -05:00
Ansible Core Team
f8c4936c10
Migrated to community.vmware_rest
2020-03-23 11:14:21 -05:00
Ansible Core Team
46b865c7d6
Migrated to community.mongo
2020-03-23 11:14:21 -05:00
Ansible Core Team
0ed8af9021
Migrated to community.crypto
2020-03-23 11:14:21 -05:00
Ansible Core Team
fb6bc5058a
Migrated to community.kubernetes
2020-03-23 11:14:21 -05:00
Ansible Core Team
43f47d553e
Migrated to community.grafana
2020-03-23 11:14:21 -05:00
Ansible Core Team
4e488d8435
Migrated to community.general
2020-03-23 11:14:21 -05:00
Ansible Core Team
58e8a91f4d
Migrated to community.amazon
2020-03-23 11:14:21 -05:00
Ansible Core Team
32bf1b8115
Migrated to frr.frr
2020-03-23 11:14:21 -05:00
Ansible Core Team
38c652712c
Migrated to containers.podman
2020-03-23 11:14:21 -05:00
Matt Clay
2c0be65f44
Relocate netbox module_utils unit tests. ( #68056 )
...
* Relocate netbox module_utils unit tests.
This puts them where migration expects them.
* Update sanity ignores.
2020-03-05 16:01:55 -08:00
Matt Clay
f963c8ca3d
Update no-unwanted-files sanity test.
...
This prepares for an additional path to be present after migration.
2020-03-04 14:03:35 -08:00
Matt Clay
b26ceb57ce
Remove file exists check from botmeta sanity test.
...
Many of the paths in botmeta will no longer exist after migration, making this check pointless.
2020-03-04 14:03:09 -08:00
Matt Clay
4fb7e62003
Include more test support plugins. ( #68015 )
...
* Include more test support plugins.
Also add missing module_utils `__init__.py` files.
* Update sanity ignores.
2020-03-04 12:20:02 -08:00
Matt Clay
8339704831
Create a dedicated windows-minimal test target. ( #67987 )
...
* Create a dedicated windows-minimal test target.
The windows-minimal target is a copy of the win_ping test, taking the place of that test as the windows minimal test run on multiple python versions.
It includes a private copy of the win_ping module so it will work after migration.
This will keep tests passing during the migration prep process.
* Update sanity ignores.
2020-03-03 18:36:37 -08:00
Matt Clay
7c493577ba
Unit test cleanup to assist with migration. ( #67920 )
...
* Move linode unit tests to match module layout.
* Fix location of netapp module_utils unit tests.
* Update sanity ignores.
2020-03-02 10:40:34 -08:00
Martin Nečas
4ef7bd4c79
ovirt: update botmeta deprecated ( #67826 )
...
* ovirt: update botmeta deprecated
* correct deprecate option
* remove duplication
* add removed_module
* add removed_module to external_provider
* add imports and metaclass
* update misc ovirt
* update sanity tests to have correct misc ovirt name
Signed-off-by: mnecas <necas.marty@gmail.com>
* remove unnecessary sanity ignore
2020-03-02 10:18:35 +00:00
Jordan Borean
97d2d4512f
Separated ps module_util test targets, added WebRequest tests ( #67914 )
...
* Separated ps module_util test targets, added WebRequest tests
* Simplify header test
2020-03-02 16:12:08 +10:00
Jordan Borean
c66ee7e994
Split C# module utils to their own test target ( #67910 )
...
* Split C# module utils to their own test target
* Fix up outstanding sanity ignores
2020-03-02 15:16:31 +10:00
Matt Clay
7c8b046b5f
Fourth batch of incidental integration tests. ( #67873 )
...
* Copy in incidental posix tests.
* Update incidental test aliases.
* Update target names.
* Add support plugins.
* Fix paths.
* Update ignores.
* Update integration-aliases sanity test.
* Add incidental tests to CI.
2020-02-28 20:37:50 -08:00
Matt Clay
04666c9fa1
Clean up unit tests to assist with migration. ( #67875 )
...
* Split out cache plugin unit tests.
* Rename unit tests to match code under test.
* Relocate unit test code to match code under test.
* Another rename.
* Update sanity ignores.
2020-02-28 20:29:41 -08:00
Abhijeet Kasurde
b6c2056ea2
mongodb_user: fix doc formatting ( #67763 )
...
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2020-02-28 09:04:27 +05:30
Abhijeet Kasurde
0cd22abe8c
mongodb: Fix documentation ( #67806 )
...
* Added correct datatypes of parameter
* Fixed doc formatting
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2020-02-28 08:51:06 +05:30
Matt Clay
f735fd672a
Third batch of incidental integration tests. ( #67830 )
...
* Copy in incidental windows tests.
* Update incidental test aliases.
* Add support plugins.
* Update target references.
* Update sanity ignores.
* Update integration-aliases test.
* Add to CI.
2020-02-27 16:05:47 -08:00
Abhijeet Kasurde
ed306c7991
influxdb: Fix documentation ( #67807 )
...
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2020-02-27 13:43:16 +01:00
Andrew Klychkov
10feb24870
mongodb_shard: fix doc formatting ( #67750 )
2020-02-27 08:04:12 +05:30
Matt Clay
b68e55da26
Remove test/legacy/
directory. ( #67786 )
...
* Remove `test/legacy/` directory.
* Remove references to `test/legacy/` directory.
* Update the remaining valid legacy reference.
* Remove outdated legacy references.
2020-02-26 11:48:30 -08:00
Matt Clay
e3591223a0
Second batch of incidental integration tests. ( #67765 )
...
* Update incidental test aliases.
* Rewrite target references for renamed targets.
* Add incidental tests to CI.
* Update sanity tests for incidental cloud tests.
* Initial copy of incidental tests.
* Copy contrib files into test.
* Update paths in test.
* Add support plugins.
* Update plugin to work around missing deps.
* Update sanity ignores.
* Fix matrix entries.
* Remove debug echo.
2020-02-25 23:18:50 -08:00
GomathiselviS
726d6455d8
eos static_routes module added ( #65480 )
...
* Adding files for RM static_routes
* Added Integration tests
* Added Unit testcases
* Addressed review comments
* corrected lint errors
* corrected documentation errors
* Lint errors
* corrected test/sanity
* corrected documentation for deprecation
* corrected case sensitivity
* Again Documentation eroor
* Lint errors again
* corrected deprecated module in ignoretxt
* added new gethered,rendered,parsed state checks to unit test
* New code broke the old flow-fixed
* Lint errs
* Added check for running_config
* Add rtt testcase
* Fixed unit tcs
* lint errors
* lint errors
* Modified replaced operation behavior
* updated documentation and tests for delete opration
* fixed shippable errors
* review comments and flake8 error fix
* syntax errors fixed
2020-02-25 07:50:27 -05:00
Matt Clay
4e571248a9
First batch of incidental integration tests. ( #67717 )
...
* Initial copy of incidental network tests.
* Update incidental test aliases.
* Add incidental tests to CI.
* Rewrite module references in tests.
This should not be necessary once module redirection is supported.
* Rewrite target references for renamed targets.
* Add support collections for incidental tests.
* Add ignores for test support code.
* Remove echo used for debugging.
2020-02-24 17:31:14 -08:00
Xu Yuandong
dbaa421f9d
Some cloudengine modules miss "import __future__" and "mateclass", update to add them. ( #67634 )
...
* update doc missing future & mateclass.
* update ignore.txt.
* add a changelog.
* update changelog.
2020-02-22 17:35:18 +01:00
Xu Yuandong
347e19178d
Some cloudengine modules miss "import __future__" and "mateclass", update to add them. ( #67635 )
...
* update doc, missing future & metaclass type.
* update ignore.txt
* add a changelog.
* update changelog.
* rename changelog.
* update changelog.
2020-02-21 11:54:45 +01:00
Matt Clay
19f6fc68d4
Relocate Shippable tools. ( #67556 )
...
* Move Shippable tools to hacking directory.
These limits the `test/utils/shippable/` directory to scripts required for CI.
* Fix `test/utils/shippable/` file classification.
* Update package-data sanity test.
2020-02-19 09:55:34 -08:00
Felix Fontein
4373863f25
Module validation: sanity check mutually_exclusive, required_if, required_xxx ... ( #66961 )
...
* required_if checks should have three or four parts.
* Validate mutually_exclusive, required_together, required_one_of, required_if and required_by.
* Simplify code.
* Improve messages.
* Add changelog.
* Sanity check.
* Update docs.
* Update ignore.txt.
* Don't continue with tests when terms are not strings.
* Remove ignore.txt entry.
* Make sure validate-modules doesn't choke on things already flagged by schema test.
* Check required_if requirements list for strings.
2020-02-19 12:26:42 -05:00
Rohit
9eb7709c61
Vyos static route module added ( #62193 )
...
* Vyos static route module added
Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>
* sanity fixes
Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>
* empty config traceback fix
Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>
* sanity check fix
* model specific changes and SI test cases updated
Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>
* new state changes and SI test cases updated
Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>
* sanity fixes
Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>
* UT cases added
Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>
* replaced operation fix
Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>
* review comments incorporated
Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>
* shippable fix
Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>
* sanity fix
Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>
* delete opr updated
Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>
* comments incorporated
Signed-off-by: rohitthakur2590 <rohitthakur2590@outlook.com>
2020-02-18 07:32:26 -05:00