Commit graph

4521 commits

Author SHA1 Message Date
Jean-Francois Chevrette
8756612599 this should return 0 to indicate a non-failure when check_mode is True 2014-05-07 10:20:51 -04:00
James Cammarata
f60d1702c1 Merge branch 'cchurch-devel' into devel 2014-05-07 09:12:10 -05:00
James Cammarata
d9a09916d4 Close fds when running commands from the accelerate daemon
Fixes #7307
2014-05-07 08:47:38 -05:00
James Cammarata
43aefc7421 Close fds when running commands from the accelerate daemon
Fixes #7307
2014-05-07 08:10:57 -05:00
Maykel Moya
da5204e58b Fix typo 2014-05-07 10:35:16 +02:00
Christian Berendt
bbcfda8c18 [get_url] check against lowered stripped sha256sum
The content of the sha256sum attribute should be lowered before comparing it with the calculated sha256sum.

In the following example the used sha256sum uses ABC.. and not abc.. and the check failed. This should not happen.

```
TASK: [get_url url=http://ftp.fau.de/apache/hadoop/common/hadoop-2.4.0/hadoop-2.4.0.tar.gz dest=/home/vagrant/hadoop-2.4.0.tar.gz mode=0644 sha256sum=024326AC68A1A68B5566B10F95609EAAFD9F70CFEB37FCA0E97CBB1674E57C3A] ***
failed: [instance000] => {"failed": true}
msg: The SHA-256 checksum for /home/vagrant/hadoop-2.4.0.tar.gz did not match 024326AC68A1A68B5566B10F95609EAAFD9F70CFEB37FCA0E97CBB1674E57C3A; it was 024326ac68a1a68b5566b10f95609eaafd9f70cfeb37fca0e97cbb1674e57c3a.

FATAL: all hosts have already failed -- aborting
```
2014-05-06 18:27:43 +02:00
James Cammarata
bf3079c77a Make sure distro variable is set if python-apt is installed
Fixes #7295
2014-05-06 09:42:50 -05:00
James Cammarata
ff1c948c2c Merge pull request #7294 from adamchainz/patch-1
Fix sync_binlog name in mysql_variables example
2014-05-06 08:18:05 -05:00
James Cammarata
121648f978 Merge branch 'fixing_apache2_module' of https://github.com/berendt/ansible into berendt-fixing_apache2_module 2014-05-06 08:02:21 -05:00
Adam Chainz
29b10ac698 Fix sync_binlog name in mysql_variables example
The previous sync_binary_log is not a real MySQL variable.
2014-05-06 12:25:11 +01:00
James Cammarata
4b2a56fb03 Fixing two bugs in the ec2_elb_lb module
* the current state of the ELB was not reflected properly when checking
  the status after a change was made.
* invalid zones caused a traceback when enabling/disabling zones
2014-05-05 12:48:45 -05:00
James Cammarata
19a77228d3 Removing zone choices that overly-limit available zones for gce
Fixes #7270
2014-05-05 11:58:39 -05:00
Antti Salminen
a6b482c500 Switch to mapper device name if pvs returns the wrong one. 2014-05-03 10:36:22 +03:00
James Cammarata
5ce5ba5e58 Refuse to convert a non-empty directory into a link with the file module
Also adds an integration test for the above.

Fixes #7254
2014-05-02 14:46:38 -05:00
Kesten Broughton
068cb9af59 if key name already exists on tenant, check if public_key is offered that it matches the existing key 2014-05-02 11:09:54 -05:00
James Cammarata
84173035ea Merge branch 'fix-copy-recursive-issue' of https://github.com/tksmd/ansible into tksmd-fix-copy-recursive-issue 2014-05-01 13:39:11 -05:00
James Cammarata
f75af83c63 Fixing a documentation error in the new stackdriver module 2014-05-01 11:44:31 -05:00
James Cammarata
e9e2b110a8 Minor fix to imports in new stackdriver module 2014-05-01 11:39:46 -05:00
someda
5bb888af4b fix #7244 recursive copy fails when setting directory attributes
- reverse the order of new_directory_list returned from split_pre_existing_dir in copy module
2014-05-02 01:38:16 +09:00
James Cammarata
d64c0ae4f1 Merge branch 'stackdriver' of https://github.com/bwhaley/ansible into bwhaley-stackdriver 2014-05-01 11:21:36 -05:00
willthames
44eb585e74 Improve the ec2_snapshot argument spec and docs
ec2_snapshot got missed when moving to a common argument spec.
It could already make use of the capabilities (as it uses
ec2_connect) and the documentation suggested it supported the
common argument spec (thanks to the documentation fragment work)
so it was just a matter of fixing the argument spec.

Removed unnecessary documentation for profile and security_token
that is covered by documentation fragment

Also removed spurious documentation flags (default: null, aliases: [])
which aren't needed.
2014-05-01 13:11:41 +10:00
James Cammarata
b08ce87429 Merge pull request #7230 from binarytemple/fix_for_issue_7228
fix issue #7228 ec2_vol crash
2014-04-30 08:30:27 -05:00
bryan hunt
9fe00396ab fix issue #7228 ec2_vol crash 2014-04-30 10:43:05 +01:00
Atlas Health
4e4d4370c1 added example 2014-04-29 17:13:25 -04:00
Atlas Health
eba4d83827 updated docs to include snapshot_tags option
added version
2014-04-29 17:13:25 -04:00
James Cammarata
ba06269655 Merge branch 'patch-2' of https://github.com/budlight/ansible into budlight-patch-2 2014-04-29 15:58:05 -05:00
Michael DeHaan
f57f9c950f Merge pull request #7119 from jjshoe/patch-4
Finish reverting a broken commit in #5679
2014-04-29 16:47:46 -04:00
James Cammarata
b53bf7c8b1 Minor tweak to rsync_path construction in synchronize module
Fixes #7182
2014-04-29 15:47:16 -05:00
Michael DeHaan
de3f7e4225 Merge pull request #6794 from follower/patch-4
Make `vpc_security_group` docs more accurate
2014-04-29 15:49:57 -04:00
Michael DeHaan
594e5dcdd7 In apt module show 'name' vs pkg to standardize with the rest of the modules. 'pkg' is an alias for name. 2014-04-29 15:48:51 -04:00
James Cammarata
3d9c5ceafd Merge pull request #7212 from jimi-c/issue_7027_ec2_group_egress_rules
Make sure a default allow out rule exists if no other egress rules do
2014-04-29 10:39:36 -05:00
James Cammarata
09e675290a Merge pull request #7190 from jimi-c/issue_7180_vsphere_guest_hardware_variable_casts
Make sure values are integers for certain hardware items for vpshere_guest
2014-04-28 21:00:46 -05:00
James Cammarata
2b3d39ddd3 Merge branch 'elb' of https://github.com/bpennypacker/ansible into bpennypacker-elb 2014-04-28 20:39:10 -05:00
Christian Berendt
0a35850927 made enabled/disabled checks of apache2_module workable 2014-04-28 19:46:34 +02:00
James Cammarata
075c3bcfa3 Make sure values are integers for certain hardware items for vpshere_guest
Fixes #7180
2014-04-28 11:40:00 -05:00
James Cammarata
eb0978e4db Merge branch 'fix_user_non_root_on_rhel' of https://github.com/mscherer/ansible into mscherer-fix_user_non_root_on_rhel 2014-04-28 10:47:36 -05:00
Michael Scherer
4ed4bfff90 Do not fail if we try to generate a ssh key for a user without being root
If we try to use the user module without being root, it fail on RHEL/Fedora
because usermod --help cannot be run. The root cause is lack of permission
due to EAL4+ certification, as seen in shadow-utils changelo.

So if we cannot run it, assume there is no append. It doesn't matter
much since we will not be able to run usermod at all with or without the
option.
2014-04-28 12:29:57 +02:00
Skyler Leigh Amador
6eb8759ec5 Remove --timeout option to rsync from synchronize defaults
The current 10-second default timeout for rsync seems to be behind issue #6809.

As a workaround for the underlying issue in rsync when different versions are
used on the source and destination sides, don't include the timeout option
unless the user specifies a timeout > 0.
2014-04-27 20:21:54 -07:00
Michael DeHaan
0db3ad3f73 Merge pull request #7168 from jjshoe/fix_apache2_module_docs
Fix example
2014-04-27 16:28:31 -04:00
Joel Schuweiler
c1470db8fd Fix example 2014-04-27 12:16:51 -05:00
Joel Schuweiler
aed596088b Finish reverting #b73cddc 2014-04-27 09:36:13 -05:00
jjshoe
6f0808b23b Ensure the validation string has %s in it 2014-04-27 09:30:36 -05:00
Brian Brazil
296bf6bd04 Use empty string rather than None to avoid TypeError
Improve error messages.
2014-04-25 13:30:19 +01:00
mkosmach
cfc8b1c561 add simplejson as alternative to json 2014-04-25 02:44:51 -07:00
Ben Holloway
0830d9eed5 documentation fix 2014-04-24 17:58:39 -06:00
Ben Holloway
c20f6b58c7 attempt to set availability_zones to all if neither availability_zones or vpc_identifier are set 2014-04-24 17:56:26 -06:00
Bruce Pennypacker
8baeccacab removed unwanted 'if wait else None' 2014-04-24 20:41:51 +00:00
Ben
008905f58d documentation fix availability_zones should be required for ec2_asg 2014-04-24 11:56:25 -06:00
Ben
834115290d updated example to include instance_type 2014-04-24 11:50:49 -06:00
Ben
06ff535098 Added instance_type to ec2_lc variable list 2014-04-24 11:47:41 -06:00