Commit graph

783 commits

Author SHA1 Message Date
Matt Clay
151f981ce5 Make modify_user honor check mode on OS X. 2016-02-04 01:29:56 -08:00
Matt Clay
8bb538aeb1 Make modify_user honor check mode on FreeBSD. 2016-02-03 02:24:12 -08:00
Toshio Kuratomi
93d02189f6 Remove duplicate documentation fields 2016-01-28 09:24:20 -08:00
Toshio Kuratomi
09e2457eb0 Fix documentation build in hostname 2016-01-21 08:37:56 -08:00
Brian Coca
1ab46f1e79 Merge pull request #2795 from hnakamur/add_warning_to_hostname_doc
Doc: Add NOTE about hostname modules does not modify /etc/hosts
2016-01-18 20:45:20 -05:00
Brian Coca
493f06435c Merge pull request #2768 from quinot/topic/abs_cron_file
Allow cron_file to be an absolute path
2016-01-18 20:35:12 -05:00
Brian Coca
7a0b488244 reverse order of cron commands
does not affect linux but fixes issue with busybox caring about order
fixes #2807
2016-01-15 15:01:36 -05:00
Jeroen Seegers
1a362cdff0 Update cron.py
Minor update to documentation for the cron module to reflect the required "name" parameter when the value of "state" is "absent".
2016-01-15 17:05:34 +01:00
Hiroaki Nakamura
9f2bd22a3d Doc: Add NOTE about hostname modules does not modify /etc/hosts 2016-01-12 20:29:22 +09:00
Thomas Quinot
0b38e4b407 Allow cron_file to be an absolute path
Support specifying an absolute path (typically /etc/crontab) rather than
a path relative to /etc/cron.d, to allow modifying the main system crontab.
Particularly useful for target systems that have /etc/crontab but no
/etc/cron.d.
2016-01-06 15:18:15 +01:00
Brian Coca
827b9596da service goes back to failing when absent
if no tools and no init script, this should always fail
2015-12-17 12:55:43 -05:00
Brian Coca
f3ed819241 added missing version_added 2015-12-12 17:29:27 -05:00
Brian Coca
76b926a9e8 Merge pull request #1941 from badpass/devel
Add support for selinux user when adding a new user
2015-12-12 17:25:15 -05:00
Michael Scherer
8ccfdb874e Remove a unneeded use of use_unsafe_shell
Since use_unsafe_shell is suspicious from a security point
of view (or it wouldn't be unsafe), the less we have, the less
code we have to toroughly inspect for a security audit.
2015-12-10 00:00:19 +01:00
nitzmahone
f2b72e62c0 fixed disappearing groups on OSX user module
Ensure that we don't try to modify the groups collection if groups are not specified
2015-12-08 16:17:21 -05:00
Dominique Barton
6128845b69 bugfix for issue #2537 2015-12-08 16:17:21 -05:00
Sina Sadeghi
ae582adce6 Update hostname.py
Added support for FreeBSD. (http://www.freebsd.org)
2015-11-29 18:00:44 +11:00
Brian Coca
660b47f62d minor doc fixes and reformating
updated validate_certs feature to be 2.1
2015-11-27 09:28:50 -08:00
Brian Coca
aad6e044e6 Merge pull request #2519 from vmindru/validate_key_auth_module
add  validate_certs  option #2518
2015-11-27 09:22:31 -08:00
Veaceslav (Slava) Mindru
19abe233fe Squashed commit of the following:
commit 406214fad214359fcf13fe8c7cd3f8f8faac5386
commit 85d1c9b0a41dd075eb2683b1a7de595ca3119614
commit 4aa5049b5ae25dee71a248238201611a466a13c4
commit 65a96974c80aea1fef88d78e218ecb665d8113e1
commit 22ea5863d1dfd628735b46cc7de51c0fd33251de

Refactoring
2015-11-26 08:48:42 -05:00
Martin André
129bac3649 Fix typo in ping module short description 2015-11-25 16:54:11 +09:00
Jordi De Groof
6584b59d91 Update facts when hostname is changed
ansible_hostname contains the unqualified hostname
2015-11-11 20:23:24 +01:00
Greg DeKoenigsberg
a76184ad1f @bradobro stepping down as maintainer 2015-10-28 14:39:20 -04:00
Brian Coca
4072bc1da0 rearranged systemd check, removed redundant systemctl check
fixed unused cmd and state var assignements
2015-10-23 18:59:05 -04:00
Brian Coca
dae3718e79 Merge pull request #2341 from reactormonk/devel
simpler way to check if systemd is the init system
2015-10-23 18:44:01 -04:00
Simon Hafner
6233e72001 added earlier paths to systemd
2b583ce657
b925e72633
2015-10-24 00:20:59 +02:00
chriskarel
32a21a9b61 Update hostname.py
Added support for Oracle Linux.  (http://www.oracle.com/linux)
2015-10-22 16:49:34 -05:00
Simon Hafner
e65c0f896a simpler way to check if systemd is the init system
According to
http://www.freedesktop.org/software/systemd/man/sd_booted.html
check if the directory /run/systemd/system/ exists.
2015-10-22 22:26:51 +02:00
Brian Coca
83b5220068 clarified ping module purpose 2015-10-21 13:58:05 -04:00
Toshio Kuratomi
dc51e1ae41 Mark a few parameters as no_log 2015-10-20 15:35:17 -07:00
Brian Coca
ccbcff8c8e better handling of checkmode for solaris
fixes #2296
2015-10-19 20:09:21 -04:00
Brian Coca
0307e3e649 Merge pull request #2209 from gekmihesg/devel
Support sysctl on OpenBSD
2015-10-09 13:26:24 -04:00
Achilleas Pipinellis
1499288c64 Add missing documentation: cron_file requires user to be set 2015-10-08 19:20:08 +03:00
gekmihesg
cdf0c8a560 Support sysctl on OpenBSD
Fixes #1233
2015-10-06 17:38:47 +02:00
Simon Li
d616fd12da Fix incorrect variable in group.py: user -> group 2015-10-03 01:09:03 +01:00
Brian Coca
a15aa09251 removed typo 2015-10-01 10:16:34 -04:00
Brian Coca
f6bbd2ac5b removed syslog in favor of common module logging functions 2015-10-01 00:13:58 -04:00
Brian Coca
3e42527fde revert must_exist 2015-10-01 00:13:58 -04:00
Mike Boone
539c996ede Updated link to the FAQ. 2015-09-20 22:45:51 -04:00
Brian Coca
81a7243bbb changed chmod to 2.4 compat 2015-09-14 09:54:38 -04:00
Brian Coca
813053c51c Merge pull request #986 from ssssam/cron-permissions-fix
Fix permissions issue with 'cron' module
2015-09-11 16:37:16 -04:00
tobbe
75fed6e6d8 Merge remote-tracking branch 'upstream/devel' into devel 2015-09-05 22:50:55 +02:00
tobbe
30576ad0c7 add text to the description, more user friendly 2015-09-05 14:39:52 +02:00
Brian Coca
e278f285aa partially reverted previous change to deal with systemctl show status not returning errors on missing service
Now it looks for not-found key instead of running status which does return error codes when service is present but in diff states.
fixes #12216
2015-09-02 17:11:30 -04:00
Brian Coca
bbcfb1092a check systemctl status before show as show will not return antyhing other than rc=0 even when it fails. 2015-09-01 10:58:15 -04:00
Marius Gedminas
5595a9f81d authorized_key: fix example in documentation
'key=' cannot be pointing to a file name; it needs to be the key itself as a string (or a URL).
2015-08-31 09:08:35 +03:00
Tim Rupp
48f522455d Add hostname support for Kali linux 2.0
This patch allows the hostname module to detect and set the hostname for a
Kali Linux 2.0 installation. Without this patch, the hostname module raises
the following error

   hostname module cannot be used on platform Linux (Kali)

Kali is based off of Debian.
2015-08-28 20:35:24 -07:00
Benno Joy
8bf800d5c5 Merge pull request #1973 from mgedmin/user-no-ssh-keygen-in-check-mode
user: don't generate SSH keys in check mode
2015-08-27 12:13:06 +05:30
Marius Gedminas
4ae4331a6b user: don't generate SSH keys in check mode
Fixes https://github.com/ansible/ansible/issues/11768

Test plan:

- (in a Vagrant VM) created a user 'bob' with no ssh key
- ran the following playbook in check mode:

    ---
    - hosts: trusty
      tasks:
        - user: name=bob state=present generate_ssh_key=yes

- saw that ansible-playbook reported "changes=1"
- saw that /home/bob/.ssh was still absent
- ran the playbook for real
- saw that /home/bob/.ssh was created
- ran the playbook in check mode again
- saw that ansible-playbook reported no changes
- tried a variation with a different username for a user that didn't
  exist: ansible-playbook --check worked correctly (no errors, reported
  "changed")
2015-08-26 08:51:52 +03:00
Simon Li
428550e179 Don't fail in check_mode if user exists
PR #1651 fixed issue #1515 but the requirement for path to be defined is unecessarily strict. If the user has previously been created a path isn't necessary.
2015-08-21 17:55:28 +01:00