Commit graph

147 commits

Author SHA1 Message Date
James Cammarata
b2741f451e Fixes to the service module for Ubuntu 12.04 (LTS)
Fixes #3615
Fixes #3572
2013-09-10 22:19:15 -05:00
James Cammarata
9a3a3e648b Check for systemd ownership of a service even if an init.d script exists
Also slight modification to the error message in the earlier commit that
modified the update-rc.d detection portion of the code

Fixes #3474
2013-09-10 19:37:51 -05:00
James Cammarata
7c8aa669cf Minor fix to account for template service names in systemctl 2013-09-10 11:31:13 -05:00
James Cammarata
6c3af4df81 Fix for update-rc.d based systems that also have systemd installed
By default, the service module had assumed that if the system had the
update-rc.d binary, the service was either managed via upstart or standard
sysV init-style scripts. This patch adds a check for systemctl ahead
of the other methods when update-rc.d is detected, and also simplifies
the logic around the detection of systemctl-managed services
2013-09-10 11:15:30 -05:00
James Laska
546788a1b6 The required package for selinux is libselinux-python 2013-09-06 16:26:48 -04:00
James Cammarata
82e1722fff Merge branch 'aix_wpar_facts' of https://github.com/mplonka/ansible into mplonka-aix_wpar_facts 2013-09-05 23:49:29 -05:00
James Cammarata
26a8d4ce9f Added 'reloaded' state to list of states checked for bounced services
Fixes #3556
2013-09-03 09:49:19 -05:00
Raul Melo
461858e476 Fix issue 3908. There was some ilegal operations over the sets 2013-08-27 17:07:42 +02:00
James Cammarata
ceddc37f07 Fix for the cron module on FreeBSD
Apparently crontab on freebsd does not like the file path coming before
the "-u username" portion of the command to install the crontab
2013-08-24 21:37:10 -05:00
Marcin Płonka
61298e4703 Skipping facts not available on AIX WPARs 2013-08-24 07:24:05 +02:00
Michael DeHaan
5e049a5df7 Merge branch 'fix_service_with_initscript' of git://github.com/psvo/ansible into devel 2013-08-10 18:05:35 -04:00
Andy Wilson
bc30203abe docfix: grammar in docstring for sysctl module 2013-08-08 12:23:30 -05:00
Petr Svoboda
e2f20db534 Fix traceback in service module when svc_cmd is None
When service module is used on unsupported Linux system where init
script is used directly, LinuxService.svc_cmd is None so .endswith()
fails.

Fixes issue #3533
2013-08-08 14:24:20 +02:00
Michael Scherer
cfa5a0f94d Add urpmi as a package manager for mandriva-based distribution 2013-08-04 00:03:50 +02:00
James Cammarata
e32a6110af Removing skipped=True so the task is just marked as not-changed 2013-08-03 12:15:09 -05:00
James Cammarata
d98ad7b374 Set result to skipped when vol group is missing and lv state=absent
Fixes issue #3714 - lvol module state=absent fails (with error) if
the volume group doesn't exist
2013-08-02 20:32:56 -05:00
rishid
07ef8c4d84 Verify groups string is not empty before trying add user to groups 2013-08-01 21:19:11 -04:00
Brian Coca
0ae7bcf3e2 fixed bug from prev update
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
2013-08-01 00:24:34 -04:00
Brian Coca
1e1f117886 whitespace updates on new lines
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
2013-07-31 23:26:28 -04:00
Brian Coca
d8e8aa714e now uses get_bin_path for lvg executables
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
2013-07-31 22:32:41 -04:00
Michael DeHaan
8cc13590b4 Make exceptions handling python 2.4 compatible. 2013-07-29 13:27:16 -04:00
Michael DeHaan
fc9aa5f014 Continue on mount errors, don't fail the setup module. 2013-07-22 13:57:35 -04:00
Brian Coca
3f85a82ae9 use global to fail as its not in self
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
2013-07-22 10:54:20 -04:00
Michael DeHaan
1acd9b6325 Update CHANGELOG 2013-07-21 10:12:28 -04:00
Michael DeHaan
e589365279 Merge branch 'iss_cron' of git://github.com/dirtyharrycallahan/ansible into dh_cron 2013-07-21 10:00:11 -04:00
Michael DeHaan
588b20c012 Merge pull request #3602 from bcoca/fine_tune_stat_exception
narrowed down exception
2013-07-20 09:45:31 -07:00
Michael DeHaan
3b3b600a98 Merge pull request #3470 from langemeijer/devel
Only append non_unique parameter if a uid is provided as well to user module
2013-07-20 09:11:52 -07:00
Brian Coca
b7b1c714f9 narrowed down exception we ignore and fail if any other unexpected one
crops up.
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
2013-07-20 11:51:52 -04:00
Florian Tham
ceff31241b fix fatal error when removing logical volumes 2013-07-19 10:59:11 +02:00
Antti Rasinen
7b8f24adda Make zfs set_property accept values with embedded spaces
Converting the argument list to a string with ' '.join causes
the shell interpreter to misparse spaces in property values.
Since the zfs command does not need shell anywhere, using
a list instead of a string works just as well with run_command. 

Fixes #3545.
2013-07-16 14:01:14 +03:00
Antti Rasinen
7670572578 Fix zfs property parsing
Current property parser breaks when values contain spaces. Since
zfs get -H returns tab separated lines,  it is better to explicitly
split on tabs than on whitespace.
2013-07-16 13:49:19 +03:00
trbs
38b6087495 fix missing json module for issue #3363 print JSON error as string instead 2013-07-15 16:50:31 +02:00
Brian Coca
80b9b01e97 now won't throw exception if we don't have permission to stat a mtab
entry on linux (weird chromebook issue)
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
2013-07-14 22:59:24 -04:00
Michael DeHaan
8fe15f0a30 Merge pull request #3426 from trbs/services_sleep_option
sleep option for service module which adds a pauze between stopping and ...
2013-07-12 08:18:22 -07:00
Michael DeHaan
3a84254f6d Merge pull request #3496 from johanwiren/bsd-ipv6-facts
Fix for populating default_ipv6 on BSD systems
2013-07-11 05:55:53 -07:00
Michael DeHaan
d1398594ce Merge pull request #3497 from johanwiren/bsd-gateway
Updated setup module to collect gateway fact for BSD systems
2013-07-11 05:55:26 -07:00
Michael DeHaan
952760c605 Merge pull request #3388 from bcoca/fixed_user_create_doc
updated module docs to reflect 'correct' on_create vs on_creation
2013-07-11 05:34:37 -07:00
Johan Wirén
1c247c9eb4 Updated GenericBsdIfconfigNetwork to collect gateway 2013-07-11 00:05:53 +02:00
Johan Wirén
10e9194744 Fix for populating default_ipv6 on BSD systems 2013-07-10 22:54:33 +02:00
Joshua Lund
cc275ca2be Added a new with_file example to the authorized_key documentation 2013-07-10 14:09:03 -06:00
Patrick Callahan
8f14ffe56b Bug fixes and enhancements.
Bugs:
(1) no longer allow empty jobs
(2) strip the header added by crontab package used in openSuSE and SuSE
(3) try not to leak temp files when things go wrong
(4) issue returning job names under certain conditions

Enhancements:
(1) Allow all special times not just reboot.
(2) Fail earlier by performing more input validation
(3) Add feature to allow removing cron file under /etc/cron.d

ToDo:
(1) Validate times (minute, hour, ...)
(2) Strip white space from fields such as name and job such that name=foo equals name=' foo'.
(3) More testing
2013-07-09 03:21:40 +00:00
Brian Coca
0664e36aa2 fixed check mode
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
2013-07-08 15:41:39 -04:00
Casper Langemeijer
922a71fced Only append non_unique parameter if a uid is provided as well 2013-07-08 11:46:38 +02:00
Aaron Brady
efc4bc10d4 Make the CPU facts Hyperthreading aware 2013-07-03 16:25:35 +01:00
trbs
3b2173b6df sleep option for service module which adds a pauze between stopping and starting a service using state=restarted. This helps for bad scripts that exist immediatly after signaling a process to stop. 2013-07-03 17:08:07 +02:00
Antti Rasinen
93fc3391fe Fix service enable on FreeBSD
Some services have a knob (i.e. rc.conf setting) whose name
differs from that of the script. For example, lockd process
is controlled with a script called lockd, but the rc.conf
value is rpc_lockd_enable.

Fixes issue #3382.
2013-07-03 14:52:23 +03:00
Brian Coca
9f75397310 updated module docs to reflect 'correct' on_create vs on_creation
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
2013-06-30 20:32:05 -04:00
Michael DeHaan
15bf8a8398 Merge pull request #3315 from madduck/fix-service-updatercd-changed
Let update-rc.d set changed flag properly
2013-06-30 16:09:39 -07:00
Michael DeHaan
681696846a Styling: semicolon 2013-06-30 18:56:03 -04:00
Michael DeHaan
fc8ffc1864 Styling: blank lines 2013-06-30 18:52:33 -04:00