Commit graph

4485 commits

Author SHA1 Message Date
Cristian Ciupitu
a416dba3d1 hostname module: don't filter hostnamectl with awk
There's no need to filter hostnamectl's output with awk because its man
page says:

    hostnamectl [OPTIONS...] {COMMAND}

       --static, --transient, --pretty
	   If status is used (or no explicit command is given) and one
	   of those fields is given, hostnamectl will print out just
           this selected hostname.

E.g. hostnamectl --static status => ansible.example.org
2014-03-16 13:10:28 -04:00
Cristian Ciupitu
7f681c33a2 Micro-optimization: replace s.find(x)!=-1 with x in s
timeit shows a speedup of ~3x on Python 2.7.5 x86_64.
It also makes the code a bit shorter.
2014-03-16 13:10:28 -04:00
Ali Asad Lotia
77e6dded62 Fix acl module doc and error messages
- Fix typos in module doc
- Provide clearer error message when entry and etype are both missing
2014-03-16 16:41:37 +00:00
Michael DeHaan
c3e8a51374 Remove nova_fip (redundant merge relative to quantum module) 2014-03-16 12:29:19 -04:00
Steve Smith
ba1bffde5d Add a JIRA control module for Ansible. This version uses fetch_url rather than urllib2. 2014-03-16 17:14:04 +01:00
follower
75ce001230 Fix typo
"a the" -> "the"
2014-03-17 00:23:16 +13:00
Brian Coca
7ca6343ca3 Fixes and cleanup to file functions and module
- unified set attribute functions ... not sure why 2 identical functions
exist with diff names, now there are 3 while i repoint all modules to 1
- fixed issue with symlinks being created w/o existing src when force=no
- refactored conditionals, simplified where possible
- added tests for symlink to nonexistant source, with both force options
- made symlink on existing attomic (force)
2014-03-15 13:54:24 -04:00
Michael DeHaan
4f1ccfd66f Merge pull request #6504 from follower/patch-2
Fix typo
2014-03-15 09:15:53 -05:00
Michael DeHaan
6f3a093258 Merge pull request #6502 from follower/patch-1
Fix typo in example name
2014-03-15 09:15:17 -05:00
follower
5beee66d1d Fix typo
"resort" -> "result"
2014-03-15 20:04:38 +13:00
follower
7b14469f9e Fix typo in example name 2014-03-15 19:16:14 +13:00
Brian Coca
5dd041ae7e fixed bad detection of change on default and premature break 2014-03-15 01:10:15 -04:00
tmperret
dbec576633 Made load_balencers in ec2_lc non-required as not all ASGs require an ELB 2014-03-14 22:39:57 +00:00
Michael DeHaan
6b43e6cd50 Add GCE guide and retool a bit to show the add_host interactions, improvements/upgrades are welcome.
Had to shoot the recently merged nova_group module in the head temporarily as it contained a dict comprehension, which means it can't work on all the platforms
and was also breaking docs builds on CentOS.  Will engage with list about that shortly.
2014-03-14 15:02:22 -04:00
Matt Martz
4f3f2e0f95 New module: nexmo 2014-03-14 11:06:25 -05:00
Michael DeHaan
e9f6496582 Fix docs for ec2_lc module. 2014-03-14 12:01:23 -04:00
Michael DeHaan
7eb48d9d85 Merge pull request #6491 from jlaska/apt_repository_signing_fix
[apt_repository] Correct check_mode conditional logic
2014-03-14 10:21:31 -05:00
James Tanner
59fb47ae9a Fixes #6482 Check sysctl file path and catch read exceptions 2014-03-14 11:16:45 -04:00
James Laska
2638cc9a49 Correct check_mode conditional logic
The desired behavior is to _not_ add the ppa signing key when check_mode is
enabled.  This fix corrects the conditional logic to comply with the stated
behavior.
2014-03-14 10:24:52 -04:00
Johannes 'fish' Ziemke
459a76c0dd Rename present to running, add new present state
The new present state just makes sure that a container exists, not that
it's running, although it get started one creation.
This is very useful for data volumes. This also changes the old
present, now running (default) state to only create the container if
it's not found, otherwise it just get started.

See also discussion on mailinglist:
https://groups.google.com/forum/#!topic/ansible-devel/jB84gdhPzLQ

This closes #6395
2014-03-14 14:28:46 +01:00
Sam Hanes
3776348acb Add support for YAML lists to apt module. 2014-03-14 00:22:32 -07:00
Patrick Gerken
0c70cc123e Properly catch import errors in apt
When one accidentally tries to run this module as a user, he gets the error message that python-apt must be installed, no matter what. Because importing apt will trigger an exception as a regular user. Explicitly catching the ImportError will let the exception bubble. The exception clearly says Permission denied somewhere, and the user has a better idea, what he must fix.
2014-03-14 02:13:20 +01:00
Michael DeHaan
ec8b67bea8 Merge pull request #6468 from philpep/fix_apt_key
apt_key: Fix traceback when key_id format is invalid
2014-03-13 17:58:40 -05:00
Michael DeHaan
931c527397 Merge pull request #6470 from patrickheeney/doc-git-fix
Fix documentation for accept_hostkey in GIT module
2014-03-13 17:57:56 -05:00
Paul Durivage
66fe9c0ac4 Documentation updates 2014-03-13 16:18:50 -05:00
James Cammarata
564fbb55de Fix small typo resulting in a traceback for the apt_key module 2014-03-13 13:51:59 -05:00
patrickheeney
4bc663092f Fix documentation for accept_hostkey 2014-03-13 07:58:12 -07:00
Philippe Pepiot
f9d1809a70 apt_key: Fix traceback when key_id format is invalid
Signed-off-by: Philippe Pepiot <phil@philpep.org>
2014-03-13 15:28:37 +01:00
Richard Isaacson
35b4cf001c Merge pull request #6461 from risaacson/modules_make_run_command_safer
Modules make run command safer
2014-03-12 23:28:06 -05:00
Richard C Isaacson
122917019c mysql_db module: typo fix
Tests clean.
2014-03-12 23:25:22 -05:00
Richard C Isaacson
d9da5cf084 Shell updates. 2014-03-12 22:15:56 -05:00
James Cammarata
7f7802c26d Merge pull request #6460 from jsmartin/riak-bugfix
Fixes various typos, fetch_url now working, changed command composure for wait_for_service
2014-03-12 21:56:39 -05:00
James Cammarata
6b492de1ee Fix regression in dnsmadeeasy module caused by fetch_url change
Also:
* changed this module to use https for requests to the API
* fixed a bug in which a traceback was caused when the domain wasn't found

Fixes #6457
2014-03-12 20:48:22 -05:00
James Martin
0a74cb484c Fixes various typos introduced in a9017af2bb.
Fixes odd encoding problem with wait_for_service.
2014-03-12 21:26:16 -04:00
Daniel Jaouen
002099cdbc Fix Homebrew._current_package_is_installed 2014-03-12 19:52:16 -04:00
Michael DeHaan
e811a9b603 Still more shell fixes. 2014-03-12 17:44:53 -04:00
Michael DeHaan
376237d9d9 Fixup shell handling in monit module. 2014-03-12 17:43:31 -04:00
Michael DeHaan
980653f20b More shell fixes 2014-03-12 17:43:31 -04:00
James Tanner
ae3bbec489 Close parens in portinstall 2014-03-12 17:36:48 -04:00
Michael DeHaan
29138b1872 More shell updates 2014-03-12 17:31:00 -04:00
James Tanner
ffe325cdae Fix missing colons in cpanm 2014-03-12 17:25:32 -04:00
James Tanner
7c3831ab16 Fix typo in portinstall 2014-03-12 17:12:38 -04:00
Michael DeHaan
349063743f Some more run_command updates. 2014-03-12 17:04:34 -04:00
Michael DeHaan
d4d87c420f Fixes for run_command shell usage in remainder of packaging modules, save portinstall. 2014-03-12 16:57:18 -04:00
Michael DeHaan
cb9059b250 Various commits to enable no-shell or safe-shell usage, more to come. 2014-03-12 16:44:35 -04:00
Patrick Smith
0f9cb7a24f git: Execute git commands in dest directory 2014-03-12 13:28:39 -04:00
Jakub Jirutka
f39b8cae95 Fix #5679 again after recent changes in core 2014-03-12 18:21:53 +01:00
Richard C Isaacson
9e9f43272a setup module: Mark unsafe commands as use_unsafe_shell=True. 2014-03-12 11:13:20 -05:00
James Cammarata
c68be8b418 Remove validate_certs parameter from fetch_url calls 2014-03-12 10:31:01 -05:00
James Cammarata
72217c297d Adding validate_certs to all modules that use fetch_url 2014-03-12 10:19:54 -05:00