cmueller/ansible
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity
32826 commits 47 branches 390 tags 440 MiB
Commit graph

3419 commits

Author SHA1 Message Date
Abhijeet Kasurde
b5eca624d0 Refactor easy_install module 
* PEP8 fix
* Rectified string check in package install command stdout
* Add abadger's code review changes

Fixes #22245

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
 2017-09-11 15:45:41 -07:00
Jordan Borean
5623e679b8 win_unzip: added support for Server core by using .net zip functions (#29272) 
* win_unzip: added support for Server core by using .net zip functions

* fixed unzip behaviour with folders
 2017-09-11 18:30:24 -04:00
Adam Miller
75127092f2 refactor firewalld module with object abstraction (#26487) 
* refactor firewalld module with object abstraction

This change creates a FirewallTransaction object that each
individual transaction type is a sub-class of as they all follow the
same pattern to enable or disable something in the firewall.

Also, there's a few bugfixes here:
    - Fix the "source" type to handle permanent operations
    - Remove ambiguity of required parameters for only specific use
      cases that can lead to transactions effectively being a no-op.
      Instead, pick sane defaults and document them.
    - Change how imports are done so globals are no longer needed

This is based on the original feedback by Toshio from the last
refactor attempt:

    https://github.com/ansible/ansible-modules-extras/pull/3383

Signed-off-by: Adam Miller <maxamillion@fedoraproject.org>

* fix line too long for pep8 for shippable tests

Signed-off-by: Adam Miller <maxamillion@fedoraproject.org>

* remove firewalld from pep8/legacy-files

Signed-off-by: Adam Miller <maxamillion@fedoraproject.org>
 2017-09-11 14:10:07 -07:00
Toshio Kuratomi
ff13d58c14 Remove use of unicode_literals as it is an anti-pattern 
from __future__ unicode_literals leads to developer confusion as
developers no longer can tell whether a bare literal string is a byte
string or a unicode string.  Explicit marking as u"" or b"" is the way
to solve the same problem in the Ansbile codebase.
 2017-09-11 13:33:51 -07:00
Martin Krizek
0daacdccf8 dnf: add environment upgrade test 2017-09-11 11:45:10 -07:00
Matt Clay
5953a428a8 Undo accidental addition to skip.txt. 2017-09-11 09:45:44 -07:00
Martin Krizek
de299ef77c dnf: fix TypeError when env/group failed 2017-09-11 09:16:39 -07:00
Matt Clay
cafd064547 Improve import error handling in azure_rm_common. (#29153) 
* Improve import error handling in azure_rm_common.

* Update skip.txt
 2017-09-11 09:11:28 -07:00
Brian Coca
444a5b5389 fix cs_zone_facts tests, namespace feature removed (#29184) 
* fix cszonefacts .. namespace feature removed

* also removed the 2nd instance of ansible_facts
 2017-09-11 17:30:43 +02:00
Trishna Guha
2bef344512 nxos_config CI fix (#29437) 
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
 2017-09-11 14:17:17 +05:30
Trishna Guha
bbb1ceba75 fix nxos_command nxapi test output (#29436) 
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
 2017-09-11 14:15:56 +05:30
Matt Clay
50ae33d3c1 Fix wheel dependency on python 2.6. (#29388) 
* Fix wheel dependency on python 2.6.
* Limit wheel version for tox on python 2.6.
 2017-09-10 23:52:13 -07:00
Andrew Saraceni
8f050d3719 Fix SID Lookup Issues on Assorted Windows Modules (#28979) 
* fix sid lookup issues and update copyright/license to latest format

* simplify win_owner and win_share by removing unnecessary function
 2017-09-11 07:34:51 +10:00
Miguel Ángel Ajo
8e4f112b39 Fixes #23680 bug with py3.x due to binary string handling (#23688) 
* This commit includes a unit test to exercise the _is_role
function and make sure it doesn't break in any Python version.
* Import os.path and other minor fixups
 2017-09-09 18:40:07 -07:00
Toshio Kuratomi
75249e311e Fix set theory filters for python3 
The set theory filters need to use lists rather than generators on python3.

Also add unit tests for most of the mathstuff filters

Fixes #26494
 2017-09-09 17:38:39 -07:00
Abhijeet Kasurde
8f6626bd8f Misc typo corrections 
Fix adds correction for typos

* Anisble to Ansible
* Fasle to False

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
 2017-09-09 10:25:50 -07:00
Matt Clay
f88750d665 Expand disabled pylint rules. (#29162) 
* Expand disabled pylint rules.
* Fix pylint and unicode issues in ansible-test.
 2017-09-09 08:59:09 -07:00
Pierre-Louis Bonicoli
557356c571 module_utils/ovirt.py: fix broken import 2017-09-08 22:12:00 -07:00
Matt Clay
e71cddc026 Remove unnecessary import skip entries. 2017-09-08 11:27:58 -07:00
Trishna Guha
2ff9888923 rename nxos test basic-no-exec to basic-no-motd (#29144) 
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
 2017-09-08 22:50:25 +05:30
Trishna Guha
588bddbc35 nxos_banner CI fix (#29134) 
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
 2017-09-08 19:33:41 +05:30
Ricardo Carrillo Cruz
497e6cf405 Use 'hostname switch' on setup/teardown tasks for nxos_config non_idempotent (#29132) 
inventory_hostname breaks CI due to too long string.
 2017-09-08 13:56:09 +02:00
Ricardo Carrillo Cruz
8b6e3272f2 Set hostname to 'switch' on nxos_config toplevel setup/teardown tasks (#29127) 
Using inventory_hostname breaks in our CI, as the inventory_hostname
translates to a long UUID, exceeding the maximum length for a NXOS
hostname.
 2017-09-08 12:13:35 +02:00
Ricardo Carrillo Cruz
2304706bd3 Set hostname to 'switch' on nxos_system teardown (#29126) 
On setup we set it to 'switch', so teardown should be 'switch'.
Also, using inventory_hostname breaks the test, since in our CI
it's a long UUID string, which exceeds the 32 chars maximum for setting
a hostname on NXOS.
 2017-09-08 12:09:44 +02:00
Ganesh Nalawade
4d5b9a4a57 Increase persistent timer setting for network integration test (#29121) 2017-09-08 10:05:54 +05:30
Ganesh Nalawade
0b2619ff2b Add lldp neighbor intent argument for vyos_interface (#29092) 
* Add lldp neighbor intent argument for vyos_interface

* Add version_added info for neighbor argument

* Fix CI issue
 2017-09-08 08:28:43 +05:30
Sam Doran
a5ee865634 Update elasticsearch_plugin.py (#28936) 
* Update elasticsearch_plugin.py

Change module to work with Elasticsearch 2.x and 5.x automatically.
Update examples and docs.
Supersedes #21989

* Check system paths for elasticsearch-plugin binary

Use get_bin_path from basic.py for searching paths.

* Create a copy of PLUGIN_BIN_PATHS rather than modifying the global

* Use provided plugin_bin path first before trying other places

Change global PLUGIN_BIN_PATHS to a tuple
 2017-09-07 11:33:53 -04:00
Trishna Guha
757983d808 Disable nxapi test for nxos_banner (#29088) 
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
 2017-09-07 17:51:54 +05:30
Trishna Guha
064bb66e6d run banner exec test only for NXOS7K (#29041) 
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
 2017-09-07 17:30:24 +05:30
Jordan Borean
91e7c3ec81 win_regedit: fixed up diff output to be more representative of type (#28974) 
* win_regedit: fixed up diff output to be more representative of type

* added diff fix for creation of key and prop in one go
 2017-09-07 16:14:49 +10:00
Matt Clay
a1453a7917 Improve handling of first CI run for new branch. (#29070) 2017-09-06 16:40:04 -07:00
Brian Coca
fe3b4325c2 less confusing 'args' message (#29053) 
* less confusing 'args' message

* fix test

* gone native
 2017-09-06 18:20:06 -04:00
Nathaniel Case
f84ff216b6 Generalize nxos_bgp event-history detection (#28890) 
* More general handling of event-history

* Update unit tests
 2017-09-06 17:37:44 -04:00
Matt Clay
286348bd0d Temporarily disable leaky test in CI. 2017-09-05 21:56:40 -07:00
Ganesh Nalawade
3b6b004570 Add support for neighbor argument in ios_interface (#29035) 
Add missing support for lldp neighbor argument in ios_interface
 2017-09-06 10:15:02 +05:30
Matt Clay
08bdb6198e Migrate more Azure integration tests. (#29034) 2017-09-05 19:38:56 -07:00
Matt Clay
8f4c8844c4 Divide Windows integration tests into 2 groups. (#29029) 
* Divide Windows integration tests into 2 groups.
* Support `none` for `--changed-all-target`.
* Run 2 separate Windows groups on Shippable.
* Only run smoketest and minimal for the group1 job.
 2017-09-05 15:32:26 -07:00
Dag Wieers
d8649adf10 aci_rest: More tests related to input types 
Now test inline YAML, inline JSON, YAML string, JSON string and XML
string input.
 2017-09-05 00:59:33 -07:00
Dag Wieers
6108b46022 aci_rest: Add integration tests 
Integration tests for aci_rest to upstream.

It follows the same flow as aci_tenant to create, change and remove a
tenant idempotently.
 2017-09-05 00:09:17 -07:00
Ganesh Nalawade
60d0139844 Remove provider from prepare junos test intergration setup (#28961) 2017-09-03 03:16:06 +05:30
Ganesh Nalawade
7372e0c658 Fix junos_netconf integration test provider param (#28954) 2017-09-02 23:34:51 +05:30
Matt Clay
55fb18b85c Split cloud tests into two CI groups. 2017-09-01 17:33:54 -07:00
Matt Clay
a7d5492ea3 Fix github_issue test and enable in CI. 2017-09-01 14:13:34 -07:00
René Moser
9c6d925f5a tests: cs_instance: expand tests cases with project (#28938) 2017-09-01 21:49:53 +02:00
Nathaniel Case
8bfdbd0f73 nxos_bgp_neighbor: Fix regex &report warnings (#28888) 
* Fix over-detection of log-neighbor-as

* Report nxos warnings

* Update nxos_bgp_neighbor unit tests to test remove-private-as
 2017-09-01 15:17:42 -04:00
Abhijeet Kasurde
8027aad4b8 Add support for Python3 in vmware_guest_find 
* Remove redundant get_obj method
* Fix testcase
* Correct logic for compile_folder_path_for_object

Fixes: #25984

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
 2017-09-01 11:11:09 -07:00
Nathaniel Case
de2096e3d0 Move networking provider options to subspec (#28894) 
* Add EOS provider options as subspec

* Add IOS provider options as subspec

* Add IOS XR provider options as subspec

* Add Junos provider options as subspec

* Add NX-OS provider options as subspec

* Add Vyos provider options as subspec

* Remove password checks from check_args

* Do the same to aireos, aruba, ce, dellos*, & sros, as they work the same way

* VyOS does not support `transport`
 2017-09-01 11:53:51 -04:00
Mike Wiebe
fb1aa54341 Rel240/fix nxos interface ospf (#28898) 
* Fixes 28897 nxos_interface_ospf idempotence

* Handle all characters upper or lower with tests
 2017-09-01 11:07:18 -04:00
saichint
737c27121b Add Idempotent IT cases for vrrp, vrf, vtp (#28895) 2017-09-01 05:59:21 -04:00
rahushen
50d148a7d6 Add nxos_config IT (#28853) 
* recalibrate tests and add new ones

* add new cli tests

* add new nxapi tests

* Add new tests for cli and nxapi
 2017-09-01 05:44:24 -04:00