Commit graph

2525 commits

Author SHA1 Message Date
Fabian von Feilitzsch
edc8698c14 make binds a list instead of a dict (to prevent overwriting when copying the same file to two places) (#2294) 2016-04-12 22:01:45 +02:00
Matt Davis
6d0e9327e3 Merge pull request #3342 from gundalow/docsfix
ansible-validate-modules part 1: Correct documentation
2016-04-12 12:26:27 -07:00
Ricardo Carrillo Cruz
8a03ae5287 Create subnet by domain
A cloud/domain admin should be able to create a subnet on any
project it is granted on.
This change adds the 'project' parameter that accepts either
a name (admin-only) or id.
2016-04-12 17:58:01 +00:00
Rene Moser
85c45d9fd1 openstack: doc fix, add version_added
see #3388
2016-04-10 11:37:53 +02:00
David Shrewsbury
99659036ca Merge pull request #3363 from rcarrillocruz/check_default_project_if_present
Only check default_project on resource creation
2016-04-08 14:21:26 -04:00
Matt Martz
e9227c4d8f overwrite option was added for 2.1 2016-04-08 11:36:14 -05:00
Monty Taylor
265c3fdfb5 Merge pull request #3388 from Shrews/os_network_provider
Add support for provider network options
2016-04-08 08:18:17 -07:00
David Shrewsbury
29bd86394e Add support for provider network options.
Adds new parameters for specifying options for provider network plugins.
2016-04-08 09:31:26 -04:00
David Shrewsbury
6970cc233f Wrap calls to main() with if check
A change was merged to the main Ansible core code that can cause

a potential hang if any libraries are called that use threading.

This change was:



  4b0aa1214c



This affected the os_object module by causing a hang on the shade

create_object() API call (which in turn calls swiftclient which

uses threading). The fix is to make sure all modules have a main()

that is wrapped with an "if __name__ == '__main__'" check.
2016-04-06 12:18:35 -07:00
John Barker
531eed80b3 Replace BOOLEANS with true/false 2016-04-05 16:31:15 +01:00
Kalle Lehtonen
5aa652c6fd Fix and add more error handling for role policies
In case role policy was deleted, we did not handle at all if there

was authorization issue to do the deletion. Also add message when

role is not found and the policy is skipped.
2016-04-05 09:55:49 -04:00
Ricardo Carrillo Cruz
ee2d436aa5 Only check default_project on resource creation
The default_project is checked at the beginning of the module.
This raises an exception if the project passed does not exist.
This logic only makes sense on resource creation, if a user
puts state=absent the module fails, even though the default
project is not relevant
2016-04-04 13:20:00 +00:00
Brian Coca
2ddeb5cdec fixed doc quoting 2016-04-01 17:48:39 -04:00
Brian Coca
20e4ad0eef corrected required docs as only boolean is allowed
these complex values were not displayed and would always show the fields as requried
2016-04-01 16:59:12 -04:00
René Moser
bd2924b8ff Merge pull request #3133 from alachaum/fix-elasticache-idempotency
Fix aws elasticache idempotency
2016-03-31 19:27:15 +02:00
René Moser
18367243e4 Merge pull request #3341 from Shrews/os_server_wait
Pass wait/timeout parameters to floating IP APIs in os_server
2016-03-31 15:32:58 +02:00
Jonathan Davila
8b13f2a693 Merge pull request #2278 from wimnat/feature/iam_doc_fix
IAM doc fix
2016-03-30 08:27:32 -04:00
René Moser
fa8cb762ed Merge pull request #3161 from somechris/fix-boto-version-requirement
Guard against too old boto library
2016-03-30 07:23:52 +02:00
David Shrewsbury
aecec868d5 Pass wait/timeout parameters to floating IP APIs in os_server
If a server already exists when os_server is run, but a floating
IP was not assigned to the server when one was requested, the
module will attempt to add an IP to the existing server. But it
would not pass the wait/timeout params to the floating IP APIs.
If wait was True, you could get back a server dict that did not
show the floating IP because it did not wait.
2016-03-29 13:42:41 -04:00
David Shrewsbury
772d9eb88e Set type on floating_ip_pools in os_server
This has been expected as a list, so let's be explicit about it
so it will work correctly in 2.1 release.
2016-03-29 10:13:49 -04:00
Ricardo Carrillo Cruz
6e6817ce18 Fix is_public type on os_image
Without this fix, the is_public value is a string and the shade
call handling the module does not evaluate correctly when
passing is_public: no
2016-03-29 11:37:49 +00:00
René Moser
5e90c86519 Merge pull request #2702 from curious-eyes/add-gce-preemptible
Add preemptible option on gce.py
2016-03-28 00:06:43 +02:00
René Moser
7e879eca32 Merge pull request #2968 from ashwanthkumar/exponential-backoff-in-route53
add retry with exponential backoff on route53
2016-03-27 23:54:37 +02:00
Michael Scherer
74fd65b2d8 s/plubic/public/in the doc 2016-03-26 14:17:26 +01:00
René Moser
13f4b40c15 Merge pull request #3284 from mscherer/fix_docker_args
Improve/fix type checking for docker module
2016-03-25 23:43:52 +01:00
Ash Wilson
f4557c1631 Remove myself from the docker module maintainers
Apologies, but I no longer use this module day-to-day myself, and I don't have the bandwidth right now to effectively triage changes in any kind of timely fashion.
2016-03-24 10:03:47 -04:00
Brian Coca
dabf28edbe Merge pull request #2853 from Igelko/patch-1
docker: If cmd and entrypoint not set, don't match them
2016-03-24 06:29:49 -07:00
curious-eyes
24f1afc606 Add preemptible option on gce.py 2016-03-24 18:17:21 +09:00
Victor Beresnev
6a279fd421 If cmd and entrypoint not set, don't match them
Hello!
I wanted stop the containers matched only by image name, but can't do this, if I not set cmd in playbook.
This behavior confused me.

If cmd or entrypoint is defined for running container, but not defined in playbook, makes matching behavior as this sample:
https://github.com/ansible/ansible-modules-core/blob/devel/cloud/docker/docker.py#L463
2016-03-24 11:53:49 +04:00
Brian Coca
c10daa5d80 Merge pull request #3302 from rcarrillocruz/allow_domain_name_os_user
Allow passing domain name on os_user
2016-03-23 14:31:40 -07:00
Ricardo Carrillo Cruz
d26f788519 Allow passing domain name on os_server
A cloud admin can search domains, thus it should be possible
to pass a domain name, just like ids.
2016-03-22 17:56:46 +00:00
David Shrewsbury
827fd9acc2 Fix allowed_address_pairs and extra_dhcp_opts in os_port
Commit f71542c set the incorrect type for these two parameters to
dict when they are actually list of dicts.

Also, the extra_dhcp_opts was incorrectly named (without the terminal
's') and NEVER worked, so this was corrected.

Fixes #3301
2016-03-22 08:26:07 -04:00
David Shrewsbury
318cc16c27 Fix size parameter documentation
The generated documentation shows the size parameter as required.
Set 'required' to 'false' and move the explanation to the description.

Fixes #3278
2016-03-21 16:13:29 -04:00
Brian Coca
cf03730fa2 added version added 2016-03-21 11:34:56 -07:00
Brian Coca
73586f7ddb Merge pull request #3124 from nbrownus/elb_proxy_protocol
ELB Proxy Protocol support for backends
2016-03-21 11:25:56 -07:00
Brian Coca
62310c8954 Merge pull request #3077 from jjshoe/devel
Allow us to sort by all available datatypes
2016-03-21 11:23:23 -07:00
Brian Coca
0abade73c4 Merge pull request #2929 from gesellix/add_env_file_support_v2
add `env_file` support
2016-03-21 11:19:57 -07:00
Michael Scherer
e78e13b222 Improve/fix type checking for docker module
tls_* point to files, so should be type=path
count is a int, so tag it as such and avoid converting later
password should be tagged as no_log
2016-03-21 00:44:52 +01:00
Yannig Perré
b958985816 Add an example of extra_hosts option. 2016-03-20 14:33:32 +01:00
René Moser
faf2bea527 Merge pull request #3261 from fabfuel/bugfix-ec2-elb-stickiness-without-expiration
Fixes #2039 Convert None to 0 when checking ELB cookie expiration
2016-03-19 19:09:51 +01:00
Rene Moser
de7ceacfcd openstack: os_server: add version_added for scheduler_hints
See #3172
2016-03-18 23:45:48 +01:00
Ted Timmons
a87171e280 fix typo in documentation
let's -> lets
2016-03-18 12:03:14 -07:00
Michael Scherer
70a3891b1e Merge pull request #3172 from Comcast/feature/server_scheduler_hints
port 'scheduler_hints' feature from nova_compute to os_server module
2016-03-18 00:06:22 +01:00
René Moser
37d978fa1c Merge pull request #3117 from beamly/fix-ec2-group
Fixes #3109: Executing ec2_group with rules fails with "Inval…
2016-03-17 08:41:54 +01:00
Taras Lipatov
5299279b0b Fixed typo json_fail to fail_json 2016-03-16 11:06:22 -04:00
Fabian Fülling
a34dae58cf Fixes #2039 Convert None to 0 when checking if ELB cookie expiration has changed 2016-03-16 14:14:37 +01:00
Jonathan Davila
9c286f35be Clarified IAM module doc 2016-03-15 10:15:41 -04:00
Matt Davis
effb355952 Merge pull request #2842 from kanwei/patch-1
Add new Dv2 Azure instances
2016-03-09 17:09:40 +00:00
Matt Martz
1a2a8e152f Merge pull request #3208 from schlueter/fix/add-missing-quote-in-docker-documentation
Add missing quote in docker documentation
2016-03-08 21:09:48 -06:00
Schlueter
0028f58ab6 Add missing quote in docker documentation 2016-03-08 21:32:38 -05:00
Brian Coca
ad47bb91f1 Merge pull request #3132 from curious-eyes/fix-2761-gce-UnboundLocalError
Fix #2761: gce.py - UnboundLocalError: local variable 'md'
2016-03-08 12:45:09 -05:00
Brian Coca
22caa104e4 Merge pull request #3187 from TerryHowe/openstack
Fix openstack module documentation
2016-03-07 10:48:09 -05:00
Brian Coca
6a48f2207a corrected typo on aws connection arguments var 2016-03-07 10:39:24 -05:00
Toshio Kuratomi
1c4da434c7 Merge pull request #2421 from willthames/ec2_fix_vpc_security_token
Use connect_to_aws where possible
2016-03-04 11:06:22 -08:00
Terry Howe
447d1e4b7c Fix openstack module documentation 2016-03-04 09:32:40 -07:00
Brian Coca
79564c5aa7 Merge pull request #3054 from atplanet/route53-soa-record-type
Bugfix: Permit SOA record type
2016-03-03 18:34:30 -05:00
Brian Coca
55932201a9 Merge pull request #2931 from ryannealmes/ec2-vpc-subnet-fix
ec2_vpc creating/updating incorrect subnets
2016-03-03 18:33:29 -05:00
David Hocky
5fb334e84b add explicit type for scheduler hints 2016-03-03 14:15:04 -05:00
Brian Coca
0c7af0d807 Merge pull request #3179 from Constantin07/update_ec2_ami_find
ec2_ami_find.py - Treat 'is_public' option as a bool
2016-03-03 09:56:18 -05:00
Constantin07
86a4026f48 Treat 'is_public' option as a bool 2016-03-03 10:31:30 +00:00
Brian Coca
212b1d2044 Merge pull request #3176 from mylokin/3175-docker_image_path
docker_image path param doesn't support home directory #3175
2016-03-02 18:38:44 -05:00
Andrey Gubarev
45b3066c81 update docker_image's path param type to 'path'. Fixes #3175 2016-03-03 02:27:39 +03:00
Matt Martz
305caac35d Merge pull request #1237 from vmihailenco/fix/cdn-cors-headers
rackspace: set headers when uploading files to CF.
2016-03-02 16:45:10 -06:00
Matt Martz
9ccb9af72e Merge pull request #1126 from bobgroves/devel
Adds overwrite option to rax_dns_record
2016-03-02 16:44:36 -06:00
David Hocky
cda0ec85b4 port 'scheduler_hints' feature from nova_compute to os_server module 2016-03-02 12:55:20 -05:00
Christian Aistleitner
ffeff8053b Guard against too old boto library
route53 creates Record objects using `health check` and `failover`
parameters. Those parameters only became available in boto 2.28.0.
As some prominent LTS Linux releases (e.g.: Ubuntu 14.04) only ship
older boto versions (e.g.: 2.20.1 for Ubuntu 14.04), users are getting
unhelpful error messages like

  TypeError: __init__() got an unexpected keyword argument 'health_check'

when running Ansible 2 against their LTS install's default boto.
We improve upon this error message by checking the boto version
beforehand.

Fixes ansible/ansible#13646
2016-03-01 18:55:58 +01:00
Tim Alkemade
c0734fde79 GCE module does not fetch disk images if not necessary 2016-03-01 08:17:52 +01:00
Brian Coca
5129ef5590 Merge pull request #2993 from berlic/devel
Fix docker container restart
2016-03-01 00:01:12 -05:00
Brian Coca
76669fa16c Merge pull request #2992 from dusdanig/devel
Adds ulimit to the docker module
2016-03-01 00:00:57 -05:00
Brian Coca
e50a674190 Merge pull request #2977 from scottbrown/bugfix-missing-interpolation-var
BUGFIX: Fixing missing interpolation variable
2016-03-01 00:00:33 -05:00
Brian Coca
b9020155ee Merge pull request #2939 from Shrews/os_server
Fix for os_server module when specifying region
2016-02-29 23:58:24 -05:00
Toshio Kuratomi
876b91eb3d Merge pull request #3113 from Constantin07/update_cloudformation
cloudformation.py - Added explicit type for 'tags' option
2016-02-28 22:35:34 -08:00
Arnaud Lachaume
b2c4731bd3 fix aws elasticache idempotency 2016-02-29 01:08:18 +11:00
curious-eyes
858a8b8e67 Fix #2761: gce.py - UnboundLocalError: local variable 'md' 2016-02-27 22:28:18 +09:00
Brian Coca
edf3aa336f Merge pull request #3129 from defionscode/lc_doc
Updated ec2_lc docs
2016-02-26 17:34:18 -05:00
Jonathan Davila
51d2f49ae0 Updated ec2_lc docs 2016-02-26 16:21:33 -06:00
Nate Brown
72da61ba83 ELB Proxy Protocol support for backends 2016-02-25 11:12:58 -08:00
Neil Saunders
6aa0cd4457 Fix for issue #3109: Executing ec2_group with rules fails with "Invalid rule parameter '['" 2016-02-25 14:18:02 +00:00
Constantin07
bc94e691e8 Added explicit type for 'tags' option 2016-02-24 23:33:42 +00:00
Toshio Kuratomi
e9454fa44f Merge pull request #2352 from bermudezjd/feature/iam_policy_present_state_includes_policy_changes
Feature/iam policy present state includes policy changes
2016-02-24 08:50:50 -08:00
James Cammarata
4bc2a189ba Merge pull request #3058 from Constantin07/update_ec2_tag1
ec2_tag.py - Fixing issue #3057 - AttributeError: 'str' object has no attribute 'i…
2016-02-24 11:16:55 -05:00
Brian Coca
814527fca9 tolerate environment not being set
default will be the same as before, None/null
2016-02-23 12:36:50 -05:00
Matt Martz
a7e399955f Merge pull request #3037 from immanetize/rax-expanduser
use expanduser() before testing user_data as file
2016-02-23 10:51:38 -06:00
Brian Coca
d540342984 Merge pull request #3007 from jasonk/vsphere_guest-env-vars
Enable env vars for vsphere_guest
2016-02-23 10:52:10 -05:00
Brian Coca
78f4f8c9bc Merge pull request #2728 from sysreq0/devel
vsphere_guest: Added support for resizing disks when state is 'reconfigured'
2016-02-23 10:47:02 -05:00
Joel
147b724f5d Allow us to sort by all available datatypes 2016-02-22 10:48:14 -06:00
Brian Coca
c9cfde4d0c Merge pull request #3069 from mixmatch/devel
replaced sudo with become
2016-02-20 18:37:22 -05:00
Brian Coca
369806de25 fixed rax_cdb argument spec
now we pull the actual arguments and added aliases to be nice
fixes #3075
2016-02-19 06:55:38 -08:00
Daniel Petty
e256ae0683 replaced sudo with become 2016-02-18 16:18:59 -07:00
Daniel Petty
4bdd755412 replaced sudo with become 2016-02-18 16:18:22 -07:00
Daniel Petty
bf04a0fe0e replaced sudo with become 2016-02-18 08:00:27 -07:00
Constantin07
9e42b2a684 Fixing issue #3057 - AttributeError: 'str' object has no attribute 'items' 2016-02-17 22:09:02 +00:00
Tom Bamford
5749454723 Bugfix: Permit SOA record type 2016-02-17 06:29:53 +02:00
Matt Martz
4e594a9196 Merge pull request #3050 from sivel/module-cleanup
Various simple linting type cleanups on modules
2016-02-16 16:03:34 -06:00
Matt Martz
c7845456a6 Various simple linting type cleanups on modules 2016-02-16 15:58:44 -06:00
Brian Coca
7fb2818048 Merge pull request #3002 from MikeCaspar/devel
Documentation Adjustments for Digital Ocean module
2016-02-15 15:46:44 -05:00
Pete Travis
363e459cb9 quote fail 2016-02-13 20:34:18 -06:00
Pete Travis
d5242e4016 expand when opening too 2016-02-13 20:33:19 -06:00
Pete Travis
7cfa625a31 use expanduser() before testing user_data as file
I like to use ~/somepath instead of absolute paths because
that's more shareable.  Without expansion, the path wasn't
considered a file, and the resulting cloud-config user_data
contained a string for the file path instead of the file context.
So, expand it.
2016-02-13 20:22:13 -06:00
David Shrewsbury
f71542ccf2 Fix parameters where type is assumed.
A change is coming to Ansible where module params will default to str.
Many of our modules were taking advantage of this by not being explicit
about the type, so they will break when that change merges. This hopefully
catches those cases.
2016-02-12 12:30:52 -05:00