Commit graph

4663 commits

Author SHA1 Message Date
Jonathan Mainguy
f4690464b4 Makes ansible fail if login_port is defined and login_host is either not defined, or defined as localhost. This is because if login_host is localhost then MySQLdb will use the socket instead of TCP. This leads to confusion for ansible users as, when a port is defined it gets ignored if login_host is localhost. This is to fix the bug reported by wrosario #8070. Info on MysqlDb can be read here http://mysql-python.sourceforge.net/MySQLdb.html 2014-07-09 14:38:27 -04:00
James Cammarata
778503c859 Merge branch 'issue_7848' of https://github.com/mpeters/ansible into mpeters-issue_7848 2014-07-09 12:24:06 -05:00
James Cammarata
812098b07e Merge branch 'issue_7906' of https://github.com/mpeters/ansible into mpeters-issue_7906 2014-07-09 12:09:40 -05:00
James Cammarata
56b87e8bba Merge branch 'resource-tag-required' of https://github.com/psa/ansible into psa-resource-tag-required 2014-07-09 11:49:41 -05:00
James Cammarata
2e614c8a63 Merge branch 'bug/8057' of https://github.com/ericwb/ansible into ericwb-bug/8057 2014-07-08 14:38:35 -05:00
Trond Hindenes
8e16962596 improvements to win_feature 2014-07-08 18:04:12 +02:00
Andreas Fleig
3c4dbd61fc ini_file: replace lambda with named function
Fixes #6876
2014-07-08 10:17:03 -05:00
James Cammarata
7793bd9638 Merge pull request #8049 from ranjan/dev
Provision VM using virtual network.
2014-07-08 10:11:18 -05:00
Eric Brown
7bbe3dc30c Adds an option to specify the glance endpoint type
Some environments that utilize an SSL terminator with a self-signed
certificate can use the publicURL without getting certificate
verify errors.  This allows using the internalURL with in my case
is HTTP and not HTTPS.

Closes issue: #8057
2014-07-08 00:30:40 -07:00
James Cammarata
0a33ac418a Merge pull request #8038 from caphrim007/correct-missing-msg-argument
Fix missing msg argument
2014-07-05 00:30:20 -05:00
James Cammarata
4ad4c8802a Merge pull request #8036 from sqs/remove-fragile-RDS-instance-type-validation
Remove validation of RDS DB instance type names because Amazon frequently adds new ones
2014-07-05 00:29:12 -05:00
James Cammarata
62456f5e27 Merge pull request #8022 from psa/vpc-gateway-peering
Fix for #7368 breaks peering connections. Unreak them.
2014-07-05 00:08:04 -05:00
Tim Rupp
821c133ff8 Fix missing msg argument
The following patch adds a missing 'msg=' syntax. An exception is raised
in ansible if this block is reached during the execution of the module

    TypeError: fail_json() takes exactly 1 argument (2 given)

With the 'msg=' added, you get a more informative error. For example

    msg: No settings provided to update_domain().
2014-07-04 14:00:15 -05:00
Michael DeHaan
504fc616d0 Merge pull request #8015 from cchurch/test_win_service
win_service module updates and tests
2014-07-03 19:29:24 -05:00
Quinn Slack
73c65e3db8 Remove validation of RDS DB instance type names because Amazon frequently adds new ones 2014-07-03 15:57:28 -07:00
Ranjan Kumar
8ef95374e7 Provision VM using virtual network. 2014-07-03 15:36:51 +05:30
Paul Armstrong
7b40939231 Fix for #7368 breaks peering connections. Unreak them. 2014-07-02 23:13:29 +00:00
James Cammarata
0a3e8c8e36 Merge pull request #7896 from botify-labs/feature/add-instance-monitoring-to-ec2-lc
Adds support for Cloudwatch detailled monitoring in ec2_lc module.
2014-07-02 09:50:27 -05:00
James Cammarata
2b1af586a2 Make sure subnets and route_tables are initialized before using
Fixes #7712
2014-07-02 09:26:51 -05:00
Chris Church
042d5b761d Return service name, display name, start mode and state from win_service module. 2014-07-02 08:12:40 -04:00
Paul Armstrong
714a9fda64 Make resource_tags required and do whitespace cleanup 2014-07-01 12:33:06 -07:00
Michael Leer
39b34b008c add interfact documentation #7704 2014-07-01 18:49:07 +01:00
Jacopo
91e246a776 Fixed bug with environment path for homebrew_cask 2014-06-28 14:27:33 +10:00
Brian Coca
030ac743a4 now compares permissions correctly 2014-06-28 00:24:16 -04:00
Markus Amalthea Magnuson
a58709ac1d Use correct parameter name in error message.
The parameter is called `cron_file` but the error message uses `file` which is confusing.
2014-06-27 14:53:54 +02:00
Hector Acosta
35ca6d535b Check at most 16 characters of the key. Fixes #7936
Signed-off-by: Hector Acosta <hector.acosta@gmail.com>
2014-06-27 03:18:54 -05:00
Hector Acosta
b5fe46d48c Correctly handle .repo files in zypper_repository module
Before the changes, removing a repository required a repo url. This shouldn't be required since zypper allows removing a repo based on its alias (mapped to name in this module).

The name variable was always required, which is misleading since repofiles provide their own alias. So a runtime check was added to avoid this confusion.

Additionaly, running this module on .repo files weren't idempotent. e.g

Before:
$ ./hacking/test-module -m library/packaging/zypper_repository -a "repo=http://download.opensuse.org/repositories/devel:/languages:/python/SLE_11_SP3/devel:languages:python.repo name=foo"
{"repo": "http://download.opensuse.org/repositories/devel:/languages:/python/SLE_11_SP3/devel:languages:python.repo", "state": "present", "changed": true}
$ ./hacking/test-module -m library/packaging/zypper_repository -a "repo=http://download.opensuse.org/repositories/devel:/languages:/python/SLE_11_SP3/devel:languages:python.repo name=foo"
{"msg": "Repository named 'devel_languages_python' already exists. Please use another alias.\n", "failed": true}

After:
$ ./hacking/test-module -m library/packaging/zypper_repository -a "repo=http://download.opensuse.org/repositories/devel:/languages:/python/SLE_11_SP3/devel:languages:python.repo"
{"repo": "http://download.opensuse.org/repositories/devel:/languages:/python/SLE_11_SP3/devel:languages:python.repo", "state": "present", "changed": true}
$ ./hacking/test-module -m library/packaging/zypper_repository -a "repo=http://download.opensuse.org/repositories/devel:/languages:/python/SLE_11_SP3/devel:languages:python.repo"
{"repo": "http://download.opensuse.org/repositories/devel:/languages:/python/SLE_11_SP3/devel:languages:python.repo", "state": "present", "changed": false}

Signed-off-by: Hector Acosta <hector.acosta@gmail.com>
2014-06-26 13:17:27 -07:00
James Cammarata
8e6a60dfd6 Merge pull request #7942 from sidred10/devel
Fixed FreeBSD ports install issue
2014-06-26 11:50:33 -05:00
sid
2f02d27744 Fixed FreeBSD ports install issue 2014-06-26 20:52:57 +05:30
Maxim Odinintsev
f4c183f5b8 Successfull exit if sync=yes and no package provided 2014-06-26 15:02:15 +03:00
Maxim Odinintsev
f4774a71b7 Success exit if sync=yes and no package provided 2014-06-26 14:55:16 +03:00
James Cammarata
935acf9efb Merge pull request #7925 from devpopol/fixes/api_error
fixes the now-incorrect module for ApiError -- noticed since 0.3.2
2014-06-25 22:33:22 -05:00
James Cammarata
1320f862de Merge pull request #7930 from trbs/apt_key_fetch_url_failure_codes
apt_key clear message when downloading key returns an (http) error code
2014-06-25 22:27:08 -05:00
Michael DeHaan
66ac6ebe87 Merge pull request #7931 from quiver/fix-yum-module-doc
In yum module example, use present/absent instead of installed/removed
2014-06-25 17:03:10 -05:00
George Yoshida
284476d4ec In the yum module example, use present/absent instead of installed/removed 2014-06-25 23:21:43 +09:00
trbs
e12d09861f apt_key clear message when downloading key returns an (http) error code 2014-06-25 15:30:34 +02:00
Tim Ruffles
5aba816396 grammar fix 2014-06-25 14:00:01 +01:00
Stephen Paul Suarez
1fa9c2adcc support old and new versions of APIError 2014-06-25 14:52:00 +08:00
Stephen Paul Suarez
8efce857b8 fixes the now-incorrect module for ApiError
https://github.com/dotcloud/docker-py/blob/0.3.2/docker/errors.py
- ApiError is now(0.3.2) under the docker.errors
2014-06-25 14:20:07 +08:00
James Cammarata
c61d04dd1f Check to make sure key exists in tag list before using it
Fixes #7910
2014-06-24 13:54:33 -05:00
James Cammarata
936daf6f63 Updating the other classes in the group module to match #7249 2014-06-24 12:28:43 -05:00
James Cammarata
4ca9ebf084 Merge pull request #7249 from jfchevrette/implement-group-checking-if-state-present
Allow group module to handle check_mode properly when group.state=present and group already exists
2014-06-24 12:27:31 -05:00
James Cammarata
aa028f3fb3 Merge pull request #7915 from gitaarik/devel
Add examples for `shell` and `command` modules.
2014-06-24 12:24:21 -05:00
Rik
8f25698925 Added examples to the command module 2014-06-24 13:47:23 +02:00
Rik
0b8aec9547 Added examples to the shell module 2014-06-24 13:45:33 +02:00
Sam Hanes
ed1aef3fa5 Restore #6484 reverted by c751168. 2014-06-23 17:12:19 -07:00
Michael Peters
0d7a99d114 Fixing issue #7906
Catch any InvalidInstanceID.NotFound errors coming from the boto library
when trying to find the newly created instance. When this happens We should
just wait and try again.
2014-06-23 16:58:07 -04:00
Frédéric de Villamil
b535c2b2ca Adds support for Cloudwatch detailled monitoring in ec2_lc module.
Enabling detailled monitoring in the launch config is mandatory to be able to activate cloudwatch in the to be created autoscaling group.
2014-06-23 21:00:58 +02:00
James Cammarata
6d78d6c6b1 Merge branch 'devel' of https://github.com/ansible/ansible into devel 2014-06-23 12:59:12 -05:00
James Cammarata
ae37758257 Merge pull request #6766 from Jmainguy/mysql_db_bug
mysql_db module now correctly fails on import if bz2 or gz fails.
2014-06-23 12:42:42 -05:00