Commit graph

44947 commits

Author SHA1 Message Date
James Cassell
d0f74f495b dzdo: fix password prompt (#59208)
(cherry picked from commit 28259ee247)
2019-07-22 13:59:53 -07:00
Sam Doran
a5178d8a34 Add pslint ignore rules 2019-07-22 13:59:02 -07:00
Sam Doran
9c391ea78e [stable-2.8] Update default test container to use Python 3.8.0b2 (#58877).
(cherry picked from commit 5ccd674dba)

Co-authored-by: Sam Doran <sdoran@redhat.com>
2019-07-22 13:59:02 -07:00
Martin Nečas
5447dc855b Ovirt correct sysprep backport (#59286)
* use sysprep only when needed (#59196)

* add changelog
2019-07-22 13:53:52 -07:00
Matt Davis
8074fa9a3e patch ansible-connection collection plugin loading (#59119)
(cherry picked from commit d28f25d118)
2019-07-17 15:34:16 -07:00
Sam Doran
f837444a77 [stable-2.8] Add test for meta: end_play (#59118)
- Set ansible_python_interpreter for hosts using local connection
(cherry picked from commit d17e7a91b1)

Co-authored-by: Sam Doran <sdoran@redhat.com>
2019-07-17 15:32:26 -07:00
Martin Krizek
0d86a4dbaa group: detect duplicate GIDs when local=yes (#58469)
(cherry picked from commit 4898b0a4a2)
2019-07-17 14:30:55 -07:00
Pierre Riteau
299fff1d5e Fix os_quota when volume service not available
os_quota checks the current quotas for compute, network and volume
services and fails when no volume service is found in the catalog.

Since openstack test deployments without volume services are common,
os_quota shouldn't fail if such service is missing.

This was originally fixed in d31a09ceb7
and later adapted to catch exceptions raised by shade. Since then, this
module moved to using openstacksdk, which doesn't catch the exception
raised by keystoneauth1.

Fixes #41240

(cherry picked from commit 1aca1f21f9)
2019-07-17 14:28:26 -07:00
Pilou
afb91e5140 [2.8] tower_role: ensure alias of "validate_certs" parameter is handled
* tower_role: ensure alias of validate_certs is handled

* tower modules: remove tower_verify_ssl alias too

Error was:

    Failed to update role: The Tower server claims it was sent a bad request.
    GET https://tower/api/v2/projects/22/object_roles/
    Params: [('tower_verify_ssl', False), ('role_field', 'admin_role')]
    Data: None
    Response: {"detail": "Role has no field named 'tower_verify_ssl'"}

Full traceback:

    File "/tmp/ansible_tower_role_payload_7_2p0X/__main__.py", line 145, in main
      result = role.grant(**params)
    File "/usr/local/lib/python2.7/dist-packages/tower_cli/resources/role.py", line 365, in grant
      return self.role_write(fail_on_found=fail_on_found, **kwargs)
    File "/usr/local/lib/python2.7/dist-packages/tower_cli/resources/role.py", line 242, in role_write
      fail_on_multiple_results=True, **data)
    File "/usr/local/lib/python2.7/dist-packages/tower_cli/models/base.py", line 301, in read
      r = client.get(url, params=params)
    File "/usr/local/lib/python2.7/dist-packages/requests/sessions.py", line 546, in get
      return self.request('GET', url, **kwargs)
    File "/usr/local/lib/python2.7/dist-packages/tower_cli/api.py", line 299, in request
      kwargs.get('data', None), r.content.decode('utf8'))

(cherry picked from commit 77e01e6abc)
2019-07-17 12:44:31 -07:00
YuandongXu
863520b077 Update 58227-update-cce_evpn_bd_vni-to-fix-a-bug.yml 2019-07-17 12:16:46 -07:00
xuxiaowei0512
550cac42bc add a changelog fragment to PR 58558. 2019-07-17 12:16:46 -07:00
YuandongXu
98725b25f7 update to fix a bug (#58227)
(cherry picked from commit e0f3e404c9)
2019-07-17 12:16:46 -07:00
Xu Yuandong
6491c5cdd7 Backport/2.8/58226 ce_vxlan_gateway: update the regular expression to match the more acc… (#58557)
* ce_vxlan_gateway: update the regular expression to match the more accurate. (#58226)

* Update the regular expression to match the more accurate

* Update the regular expression to match the more accurate

* Update the regular expression to match the more accurate

(cherry picked from commit 2f91266aa9)

* add a changlog fragment to PR 58557.

* Update 58226-update-ce_vxlan_gateway-to-fix-a-bug.yml
2019-07-17 12:14:47 -07:00
Sloane Hertel
d170588ab6 [2.8] Define region for aws_secret (#58722)
* AWS: Fix KeyError in aws_secret lookup (#54792)

(cherry picked from commit 33d0d36eaa)

* changelog
2019-07-17 12:11:24 -07:00
Xu Yuandong
494ec6d752 Backport/2.8/59070 ce_interface : update ce_interface to fix a bug (#59072)
* update ce_interface to fix a bug. (#59070)


(cherry picked from commit 07a598089a)

* add a changelog fragment to PR 59072.
2019-07-17 11:49:09 -07:00
Felix Fontein
3d999dbe39 docker_* modules: improve tag validation and requests error handling (#58791)
* Add method to validate docker tags.

* Validate tag option of docker_image.

* Fix regex. Always return boolean, not None vs. Matcher object.

* Also catch requests errors.

* Linting.

* Add changelog.

(cherry picked from commit 8d6f1846a6)
2019-07-17 11:48:27 -07:00
Felix Fontein
1e20cc8bd1 docker_container: add support for nocopy mode (#59043)
* Add support for nocopy mode.

* Add changelog.

(cherry picked from commit fa7c387f9b)
2019-07-17 09:24:21 -07:00
Adam Miller
eb8c4eaa01 assign a sane default to yum/dnf lock_timeout, in line with cli (#57383)
* assign a sane default to yum/dnf lock_timeout, in line with cli

Fixes #57189

Signed-off-by: Adam Miller <admiller@redhat.com>

* fix typo in changelog snippet

Signed-off-by: Adam Miller <admiller@redhat.com>
(cherry picked from commit d2dc4c9bc4)
2019-07-16 20:03:51 -07:00
Brian Coca
e6c93bea0d Fix gather_facts error/skipped reporting (#58927)
now give back full output from each module executed
 fixes #57204

(cherry picked from commit adea964c3e)
2019-07-16 19:50:37 -07:00
pratikgadiya12
0f292cd886 nmcli: Argument vlanid (int) is changed internally to string (#58963)
* Argument vlanid (int) is changed internally to string
* Modified test case to check vlan id

Fixes: #58949
(cherry picked from commit e8f4ebb22c)
2019-07-16 17:57:45 -07:00
Ondra Machacek
4477af7f90 ovirt: Resolve also list of hrefs 2019-07-16 17:56:37 -07:00
Martin Nečas
909f68d035 Ovirt vm migrate with state present backport (#58720)
* ovirt vm migrate with state present  (#58136)

* ovirt vm migrate with state present init

* add migrate comment

* add changelog
2019-07-16 17:50:18 -07:00
Martin Krizek
d3afa17930 Use templated loop_var/index_var when looping include_* (#58866)
Fixes #58820

(cherry picked from commit 7346b699ee)
2019-07-16 15:11:57 -07:00
Lindsay Hill
044923e4ae Fix broken slxos_config due to changed backup options (#58804)
(cherry picked from commit 5b2d1cc24d)
2019-07-16 14:48:28 -07:00
Klaas Demter
6d146c89f2 Fix nagios module to recognize if file exists and is fifo pipe (#58569)
add felixfontein suggestion to changelogs/fragments/58569-nagios-fifo-fix.yaml

Co-Authored-By: Felix Fontein <felix@fontein.de>
(cherry picked from commit faf50dbace)
2019-07-16 14:46:21 -07:00
Joseph
6d467a8bd9 Backport machinectl become plugin fixes (#58734) (#58774)
* Correct machinectl become plugin function arguments (#58734)

* Correct get_option function name and change flags to become_flags

* Remove the '--' from the returned command

* add changelog fragment

* change changelog fragment description

* move the -q argument to machinectl before the shell argument to resolve issues with machinectl v230 (see #56571)

(cherry picked from commit 4f642daae5)

* Update PR number in changelog fragment

* Revert "Update PR number in changelog fragment"

This reverts commit 38e6b4785a.
2019-07-16 14:40:36 -07:00
ShachafGoldstein
3516406d59 win_get_url - Fix proxy_url not used correctly
(cherry picked from commit a21d40474c)
2019-07-16 14:23:01 -07:00
Sumit Jaiswal
5fb2a0ae2d Backport PR to resolve NoneType error in issue 57711 (#58706)
* fix 57711 (#58618)

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
(cherry picked from commit 8b844b67b5)

* changelog file
2019-07-16 14:22:18 -07:00
Martin Nečas
396e48b36e Ovirt update vm migrate docs backport (#58717)
* ovirt update vm migration domunetation (#58577)

* init update docs

* Update lib/ansible/modules/cloud/ovirt/ovirt_vm.py

Co-Authored-By: Alicia Cozine <879121+acozine@users.noreply.github.com>

* add changelog
2019-07-16 14:21:16 -07:00
Martin Nečas
4519688a95 Ovirt add host retry doc backport (#58718)
* add changelog

* add docs about retry (#58625)
2019-07-16 14:19:40 -07:00
Sam Doran
04762f1c26 [stable-2.8] Improve setup_docker tests to work with RHEL 8 GA (#58649)
- use include_vars to set appropriate packages and pip packages per distribution and version
- install an older version of Docker CE on RHEL 8 since a dependency is unavailable
- disable warnings on tasks that are ok
- skip tests for CentOS/RHEL 6
(cherry picked from commit d50c8c2b83)

Co-authored-by: Sam Doran <sdoran@redhat.com>
2019-07-16 14:18:54 -07:00
Sam Doran
6e0f2a37aa [stable-2.8] Improve dnf test formatting and fix RHEL 8 module name (#58648)
- use single include_vars task rather than multiple set_fact tasks
- use multi-line YAML to break up long conditionals
- use version() test rather than direct comparisions
- use different appstream package on RHEL since '@swig:3.0/default' is not working in the GA
(cherry picked from commit 16d6fcf514)

Co-authored-by: Sam Doran <sdoran@redhat.com>
2019-07-16 14:06:10 -07:00
Albert Siersema
db7c82ea21 Backport/2.8/55218 (#58639)
* "no macro" command should not be handled by edit_macro(), fixes #55212
(cherry picked from commit 2cdab1379f)

* fixed ios_config issue where the "no macro" command was erroneously handled by edit_macro()
2019-07-16 14:03:45 -07:00
lijok
7e8b81ae18 [2.8] VMware: looking up maxMksConnections in incorrect location
maxMksConnections is contained in vim.vm.ConfigInfo not vim.vm.VirtualHardware

Fixes: #58060

Signed-off-by: lijok <28689084+lijok@users.noreply.github.com>
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
(cherry picked from commit 63bdd0d6cd)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-07-16 14:01:56 -07:00
Alicia Cozine
752c40464f
Docs on general precedence (#50201) (#59120)
* Add docs/docsite/rst/reference_appendices/general_precedence.rst

Co-Authored-By: Sandra McCann <samccann@redhat.com>
(cherry picked from commit c2469648e4)
2019-07-16 14:10:32 -05:00
Jordan Borean
e8450891ba Load Ansible module_utils for ps_argspec validator (#58571)
* Load Ansible module_utils for ps_argspec validator

* fix validation for modules without Requires statement

* Moved future comment to proper location

(cherry picked from commit c3978fed4b)
2019-07-16 12:10:09 -07:00
Jordan Borean
014b7ecc07 win_domain_user: do not hide error on failures (#58357)
* win_domain_user: do not hide error on failures

* Was a bit too overzealous in the removal

* Remove uneeded sanity ignore rule

(cherry picked from commit c260721ce5)
2019-07-16 12:05:20 -07:00
Felix Fontein
dd758f582a openssl_privatekey: forgot to add secp256r1 (#58605)
* Forgot to add secp256r1. This one is the interoperable one.

* Add changelog.

(cherry picked from commit 5d5a7d6ebe)
2019-07-16 12:04:37 -07:00
Abhijeet Kasurde
0306b9a907 [2.8] VMware: Set vapp settings while creating VM
vApp Settings can be set while creating VM.

Fixes: #50617

(cherry picked from commit 760dc19284)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-07-16 11:56:14 -07:00
Martin Krizek
28077887c2 2.8: yum: take care of stale/invalid yum.pid (#58457) (#58489)
* yum: take care of stale/invalid yum.pid (#58457)

* yum: take care of stale/invalid yum.pid

* Add changelog

(cherry picked from commit 5064e67d37)

* yum: check whether the lock file disappeared (#58581)


(cherry picked from commit b0f38931b0)
2019-07-15 13:58:53 -07:00
Alicia Cozine
b41199f1f2
Remove reference to Windows for assemble docs (#59082) (#59098)
(cherry picked from commit 66a5ed64ca)
2019-07-15 15:58:14 -05:00
Xu Yuandong
4d9542a789 Backport/2.8/58251 ce_static_route: fix some bugs. (#58251) (#58565)
* ce_static_route:  fix some bugs. (#58251)

* add a util function to ce.

* add a util function to ce.

* update to fix bugs for ce_static_route

* update to fix bugs for ce_static_route

* update to fix bugs for ce_static_route

* update

* update for shippable.

(cherry picked from commit bb33c922f7)

* add a changelog fragment to PR 58565.

* Update 58565-update-ce_static_route-to-fix-a-bug.yml
2019-07-15 13:57:35 -07:00
Hannes Ljungberg
fb5a6e1250 Cleanup EXAMPLES (#58972) (#59012)
(cherry picked from commit 4ab364eaaf)
2019-07-12 15:36:50 -05:00
anshulbehl
840d869c22 Backport/2.8/58936 (#58939)
* Changing LBName used by same task inside azure_rm_loadbalancer (#58936)

fixes #58933

(cherry picked from commit 00d7aed56b)

* Backporting #58933 to stable-2.8
2019-07-10 19:34:21 -07:00
Max Calzavara
87f0e0405e Add examples (#58819) (#58917)
* Add examples to the ios_vlan docs: vlan using aggregate and move vlan interface example

(cherry picked from commit 5689cc08ce)
2019-07-10 14:43:38 -05:00
YuandongXu
9724b230e3 backport/2.8/58231 ce_netstream_aging: update to fix a bug. (#58231) (#58563)
* ce_netstream_aging: update to fix a bug. (#58231)

* update to fix a bug

* update to for shippable.

(cherry picked from commit 715de33467)

* add a changelog fragment.

* Update 58563-update-ce_netstream_aging-to-fix-a-bug.yml
2019-07-08 21:44:11 -07:00
YuandongXu
ae17f3842e Backport/2.8/58230 ce_link_status: update to fix a bug (#58230) (#58561)
* update to fix a bug (#58230)


(cherry picked from commit b7630ccb36)

* add a changelog fragment.
2019-07-08 21:43:08 -07:00
YuandongXu
eb9f6ce790 Update 58229-update-ce_interface_ospf-to-fix-a-bug.yml 2019-07-08 21:42:01 -07:00
xuxiaowei0512
b7c348afda add a changelog fragment. 2019-07-08 21:42:01 -07:00
YuandongXu
e072a5b111 update to fix a bug (#58229)
Signed-off-by: xuxiaowei0512 <786018072@qq.com>
(cherry picked from commit b93411a5b2)
2019-07-08 21:42:01 -07:00