cmueller/ansible
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity
22388 commits 47 branches 390 tags 440 MiB
Commit graph

9003 commits

Author SHA1 Message Date
James Cammarata
68a07a2bb5 Merge branch 'osx_user_fix' of https://github.com/bambou42/ansible-modules-core into bambou42-osx_user_fix 
Includes commits for:
* Don't return change if the password is not set
* Set the group to nogroup if none is specified
* Set an uid if none is specified
* Test if SHADOWFILE is set (for Darwin)
* remove unused uid
 2016-12-08 11:22:53 -05:00
Kyle Johnson
cf61778689 Fix typo in rds_subnet_group.py 
aws_connection_kwargs should be aws_connect_kwargs
 2016-12-08 11:22:53 -05:00
Matt Martz
0b4fec0a06 Don't use a dict comprehension, be more verbose 2016-12-08 11:22:53 -05:00
Brian Coca
a014bde3f0 switched to use python's built in os.separator vs using / 2016-12-08 11:22:53 -05:00
Brian Coca
7f618bd787 minor docfixes 2016-12-08 11:22:53 -05:00
Ken Dreyer
46372842e8 redhat_subscription: fix activationkeys argument 
Prior to this commit, Ansible would pass '--activationkeys <value>' as a
literal string, which the remote server would interpret as a single
argument to subscription-manager.

This led to the following failure message when using an activation key:

  subscription-manager: error: no such option: --activationkey "mykey"

Update the arguments so that the remote server will properly interpret
them as two separate values.
 2016-12-08 11:22:53 -05:00
Monty Taylor
0283791d5f Add OpenStack Auth module 
Use this to pre-auth or to get a copy of the service catalog.
 2016-12-08 11:22:53 -05:00
Jesse Rusak
9d93f052c2 Update rds module for RDS2 parameter name change. 
boto's rds2 renamed `vpc_security_groups` to `vpc_security_group_ids`
and changed from a list of `VPCSecurityGroupMembership` to just a
list of ids. This accommodates that change when rds2 is being used.
 2016-12-08 11:22:53 -05:00
steenzout
67f769d9a6 issue #994: use HAS_BOTO to determine if import was successful: - removed import of sys module. - HAS_BOTO constant to check if import was successful. - trigger a failure when import fails. - removed unnecessary imports. 2016-12-08 11:22:53 -05:00
Richard Tier
0a48d54c1c added version to docstring 2016-12-08 11:22:53 -05:00
Monty Taylor
ea809efe7b Revert "Add OpenStack Router Gateway module" 2016-12-08 11:22:52 -05:00
Monty Taylor
c4db70a133 Add OpenStack Router Gateway module 
Also deprecate old quantum_router_gateway module
 2016-12-08 11:22:52 -05:00
Ash Wilson
c6b0656c1c Record facts for each changed container. 2016-12-08 11:22:52 -05:00
Brian Coca
7985682c94 added support for postgres9.4 which is now available from amazon 2016-12-08 11:22:52 -05:00
Brian Coca
706db441b4 really fixed docs this time 2016-12-08 11:22:52 -05:00
Brian Coca
2dafff3f97 fixed doc issues on cloudformation 2016-12-08 11:22:52 -05:00
tedder
9fd568f655 code review fixes per #957 2016-12-08 11:22:52 -05:00
Richard Tier
0c1624f9b7 allow setting header 2016-12-08 11:22:52 -05:00
Tor Åke Fransson
459fd81435 Remove all reference to obsolete client_id and rename api_key to the for v2 more correct api_token 2016-12-08 11:22:52 -05:00
Tor Åke Fransson
02883a460b Make digital_ocean ssh command use API v2 2016-12-08 11:22:52 -05:00
David Wittman
15235a718d Fix bug with upstart detection 
Upstart scripts are being incorrectly identified as SysV init scripts
due to a logic error in the `service` module.

Because upstart uses multiple commands (`/sbin/start`, `/sbin/stop`,
etc.) for managing service state, the codepath for upstart sets
`self.svc_cmd` to an empty string on line 451.

Empty strings are considered a non-truthy value in Python, so
conditionals which are checking the state of `self.svc_cmd` should
explicitly compare it to `None` to avoid overlooking the fact that
the service may be controlled by an upstart script.
 2016-12-08 11:22:52 -05:00
Tor Åke Fransson
5faa882138 WIP: DigitalOcean API version 2 with user_data option 2016-12-08 11:22:52 -05:00
tedder
35ce9fb095 skip password changes so pg_authid isn't needed 
Some places ([AWS RDS](https://forums.aws.amazon.com/thread.jspa?threadID=151248)) don't have, or don't allow, access to the `pg_authid` table. The only reason that is necessary is to check for a password change.

This flag is a workaround so passwords can only be set at creation time. It isn't as elegant as changing the password down the line, but it fixes the longstanding issue #297 that prevented this from being useful on AWS RDS.
 2016-12-08 11:22:52 -05:00
Solomon Gifford
d14bbf514e mysql_user #829: add update_password to mysql_user 2016-12-08 11:22:52 -05:00
Richard Lander
2091278ff0 azure check for hosted service and vm before creating 2016-12-08 11:22:52 -05:00
Rob Johnson
d8af3f3b67 allow both template and template_url parameters 2016-12-08 11:22:52 -05:00
Sébastien Bocahu
f88f895795 Removes YAML body_format option 
It would require adding a dependency to the YAML module while it might
not provide much benefit (has anybody seen a HTTP API taking YAML as
input ?)
 2016-12-08 11:22:51 -05:00
Mick Bass
5de4c053b6 clean rebase of https://github.com/ansible/ansible-modules-core/pull/1024 on a new branch 2016-12-08 11:22:51 -05:00
Brian Coca
4f7bc895d2 removed requirements/boto as it broke documentation as it is duplicated in shared aws fragements 2016-12-08 11:22:51 -05:00
Florian Apolloner
a925a075a6 Added os.path.expanduser to app_path in django_manage 2016-12-08 11:22:51 -05:00
Florian Apolloner
f07096bfe5 Added os.path.expanduser when searching for pip executable. 2016-12-08 11:22:51 -05:00
Adam Chainz
21339664ce Make cloudformation module's template argument not required in case of stack deletion 2016-12-08 11:22:51 -05:00
Jonathan Davila
de85294d2d allow boto profile use with s3 2016-12-08 11:22:51 -05:00
Sébastien Bocahu
4af3b60167 Add body_format for handling of JSON and YAML body 
body_format is a new optional argument that enables handling of JSON or
YAML serialization format for the body argument.
When set to either 'json' or 'yaml', the body argument can be a dict or list.
The body will be encoded, and the Content-Type HTTP header will be set,
accordingly to the body_format argument.

Example:

- name: Facette - Create memory graph
  uri:
    method: POST
    url: http://facette/api/v1/library/graphs
    status_code: 201
    body_format: json
    body:
      name: "{{ ansible_fqdn }} - Memory usage"
      attributes:
        Source": "{{ ansible_fqdn }}"
        link: "1947a490-8ac6-4bf2-47c1-ff74272f8b32"
 2016-12-08 11:22:51 -05:00
Lorin Hochstein
5224375a5a Use the correct alias syntax 2016-12-08 11:22:51 -05:00
Lorin Hochstein
17e6be671b ec2 module: add instance_id alias 
Create an alias named instance_id for the instance_ids parameter.
 2016-12-08 11:22:51 -05:00
Robert Estelle
268763995c ec2_group allow empty rules. 2016-12-08 11:22:51 -05:00
Kohei YOSHIDA
f0db5c0cd0 support secure connection on fakes3 2016-12-08 11:22:51 -05:00
Ryan Trauntvein
eaa0ce0ceb Specify that "state: reloaded" was added in Ansible 1.9 2016-12-08 11:22:51 -05:00
Scott Miller
751434de9d describe choices in alias documentation 2016-12-08 11:22:51 -05:00
Mick Bass
9980205edc Add support for AWS Security Token Service (temporary credentials) to all AWS cloud modules. 2016-12-08 11:22:51 -05:00
Toshio Kuratomi
e710e46ff2 Make lack of boto call fail_json instead of sys.exit 
Fixes #994
 2016-12-08 11:22:51 -05:00
Brandon W Maister
c1571928e5 Make cache_subnet_group default to empty security groups 
Since they can't be specified together, it seems like setting the
default to no security groups is the right option.
 2016-12-08 11:22:51 -05:00
Tom Wadley
ad248376b1 use aws connect call in rds_subnet_group that allows boto profile use 2016-12-08 11:22:50 -05:00
Dan Abel
2250a95638 use simpler ec2_connect ec2 util call 
This allows boto profile use
 2016-12-08 11:22:50 -05:00
David Fritzsche
14720b54ac Add working status detection for pf on FreeBSD 
The return code of "service pf onestatus" is usually zero on FreeBSD (tested with FreeBSD 10.0), even if pf is not running. So the service module always thinks that pf is running, even when it needs to be started.
 2016-12-08 11:22:50 -05:00
Mick Bass
e9a0fad36b add retry with exponential backoff when we receive throttling error code from cloudformation 2016-12-08 11:22:50 -05:00
Brandon W Maister
cffb2bdee9 Add cache_subnet_group to elasticache module 
According to the [docs] cache subnet groups are required inside a VPC.

[docs]: http://docs.aws.amazon.com/AmazonElastiCache/latest/UserGuide/CacheSubnetGroups.html
 2016-12-08 11:22:50 -05:00
Brian Coca
7cd7bad2e8 added patch to workaround some s3 connection faliures 2016-12-08 11:22:50 -05:00
Brian Coca
252df8685a refactrored connection exception handling, added check to see if we actually get a connection before proceeding 
Fixes #964
 2016-12-08 11:22:50 -05:00
Toshio Kuratomi
a6643160c5 Fix stat code to return name of group owning the file rather than name of group that the file's owner belongs to. 
Followup to #17
 2016-12-08 11:22:50 -05:00
Ash Wilson
2dde45cea9 Only fetch details when necessary. 2016-12-08 11:22:50 -05:00
Ash Wilson
93b620ea8a Compare container images to Config.Image. 2016-12-08 11:22:50 -05:00
Sarah Zelechoski
17334b21ea fix syntax in last example 2016-12-08 11:22:50 -05:00
Sam Thursfield
5d2652f31b Fix authorized_key module crashing when given an invalid key 
I tried a playbook with the following (accidentally wrong) task:

  tasks:
      - name: authorized key test
        authorized_key: key=/home/sam/.ssh/id_rsa.pub key_options='command="/foo/bar"' user=sam

I got the following traceback:

    TASK: [authorized key test] ***************************************************
    failed: [localhost] => {"failed": true, "parsed": false}
    Traceback (most recent call last):
    File "/home/sam/.ansible/tmp/ansible-tmp-1427110003.65-277897441194582/authorized_key", line 2515, in <module>
        main()
    File "/home/sam/.ansible/tmp/ansible-tmp-1427110003.65-277897441194582/authorized_key", line 460, in main
        results = enforce_state(module, module.params)
    File "/home/sam/.ansible/tmp/ansible-tmp-1427110003.65-277897441194582/authorized_key", line 385, in enforce_state
        parsed_new_key = (parsed_new_key[0], parsed_new_key[1], parsed_options, parsed_new_key[3])
    TypeError: 'NoneType' object has no attribute '__getitem__'

With this fix, I see the expected error instead:

    TASK: [authorized key test] ***************************************************
    failed: [localhost] => {"failed": true}
    msg: invalid key specified: /home/sam/.ssh/id_rsa.pub
 2016-12-08 11:22:50 -05:00
Brian Coca
c04c84887e fix to return vals docs 2016-12-08 11:22:50 -05:00
James Martin
57cf6e8bb4 Re-wording of feature. 2016-12-08 11:22:50 -05:00
Toshio Kuratomi
e5149f3b30 Fix review comments from @bcoca in #745 2016-12-08 11:22:50 -05:00
Toshio Kuratomi
5378b5db98 Minor code formatting 2016-12-08 11:22:50 -05:00
Tim Rupp
db6c2bac75 Add missing import of apt.debfile 
In cases when the python-apt package is not installed, ansible will
attempt to install it. After this attempt, it tries to import the
needed apt modules, but forgets to import the apt.debfile module.

The result is that playbooks that use the dpkg argument on a machine
that does not initially have the python-apt package available will
fail with the following error

AttributeError: 'module' object has no attribute 'debfile'

This patch adds the appropriate import to the apt module to ensure
that necessary libraries are available in cases when the dpkg argument
is being used on a system that does not initially have the python-apt
package installed
 2016-12-08 11:22:50 -05:00
Rowan Wookey
04fcfdad2c Fixed group name not being passed to wait_for_new_instances when replacing instances 
Fixed group_name not being passed to wait_for_elb
Minor code clean up
 2016-12-08 11:22:49 -05:00
moe
bd09ebe5b4 Woops, make collect/delete loop more efficient. 2016-12-08 11:22:49 -05:00
moe
5e1e1a4dff Fixes #744. 
The following cases work for me now:
- Create new ASG with tags
- Update tags on ASG (create/change/delete)

In short, the module should now work as expected
wrt tagging. The previous code did not work at all
with latest boto for me (serialization errors) and
the logic was buggy anyway; e.g. removed tags
would never get deleted from ec2.
 2016-12-08 11:22:49 -05:00
James Martin
cadfd56304 check lb for instance healthy and some refactoring of rolling replace functions. 
Optionally waiting for new instances to be in viable state on ASG creation/update.

Properly updating properties and terminating group.
 2016-12-08 11:22:49 -05:00
Brian Coca
7f8094e977 undeprecated openstack modules as new ones are not making into release 2016-12-08 11:22:49 -05:00
moncho
0156188a54 Update docker.py 
Fix typo that prevents use_tls 'encrypt' option from working properly.
 2016-12-08 11:22:49 -05:00
Toshio Kuratomi
5262d768e0 Add another valid status from downloading images 2016-12-08 11:22:49 -05:00
nemunaire
7eebab43ae Convert tuple items to string before format 2016-12-08 11:22:49 -05:00
Robert Marsa
b7649cc5ca Added multiple allowed ranges. 2016-12-08 11:22:49 -05:00
Julien Syx
c676adde0b Fix the issue #931 
Checking that the parameter doesn't exist. The old code had a bug when the parameter was 0.
 2016-12-08 11:22:49 -05:00
Toshio Kuratomi
d5e3abc5d5 Some code cleanup (removed unused variables and imports) 2016-12-08 11:22:49 -05:00
Toshio Kuratomi
f892ca5b8f Also use DOCKER_TLS_VERIFY env var to turn on tls verification 2016-12-08 11:22:49 -05:00
Toshio Kuratomi
1bb98542d3 Fix a potential bug in docker pull 2016-12-08 11:22:49 -05:00
Toshio Kuratomi
0ad023a0ac When no use_tls is not specified and no tls parameters are given we need to not attempt tls. 2016-12-08 11:22:49 -05:00
Alex Rowley
eeb867daf0 cloud/amazon/s3: update documentation 
update description to show that module can do more than just put files into s3
 2016-12-08 11:22:48 -05:00
Toshio Kuratomi
2e93f8e9f7 Make state=running work for backwards compatibility with 1.8 2016-12-08 11:22:48 -05:00
Toshio Kuratomi
1946f05baf Fix lookup of parameter name to be pid instead of pid_mode 2016-12-08 11:22:48 -05:00
Toshio Kuratomi
09a0db1e1f Make pid_mode parameter do minimum docker-py/docker server version checks 2016-12-08 11:22:48 -05:00
Toshio Kuratomi
95df4bcbee Fix for problems found by @dguerri 
* TLSConfig['verify'] has to be set to False if we're only encrypting the
  connection, not verifying the host.
* tls_hostname was not set if tls_ca_cert was not present

https://github.com/ansible/ansible-modules-core/pull/926#issuecomment-78573877
 2016-12-08 11:22:48 -05:00
Toshio Kuratomi
7c261b3954 Implement comments from @smashwilson: 
* if tls_ca_cert is set then use tls to verify the server
* take tls_hostname from the environment variable DOCKER_TLS_HOSTNAME
  if it's not specified in the playbook

https://github.com/ansible/ansible-modules-core/pull/926#issuecomment-78542210
 2016-12-08 11:22:48 -05:00
Ian Babrou
3bfe9a7b50 fixed: global name 'e' is not defined 2016-12-08 11:22:48 -05:00
Toshio Kuratomi
3284359894 Alternative implementation of tls for docker 
Alternative to #854
 2016-12-08 11:22:48 -05:00
Toshio Kuratomi
c9b33d5de2 Fix for py2.6 (no dict comprehensions on py2.6) 2016-12-08 11:22:48 -05:00
Toshio Kuratomi
c9cc8d0b70 Initialize the value of vpc_id variable 2016-12-08 11:22:48 -05:00
Mario Loria
00613cd4f3 Setting the actual passno and dump defaults, and warning user of consequences in nulling 
Using ansible 1.8.4, I found that these two options actually work slightly different than advertised.
 2016-12-08 11:22:48 -05:00
Toshio Kuratomi
ba90eea165 Also don't fail if files are different and overwrite is false for uploads (this mimics copy and template). 
Related to #489
 2016-12-08 11:22:48 -05:00
Hagai Kariti
7d16ec283e Fix KeyError in public zones in route53 2016-12-08 11:22:48 -05:00
Toshio Kuratomi
a02641b4f3 Documentation style changes 2016-12-08 11:22:48 -05:00
James Bowes
0d3aed3e1f Fix C() formatting typo in file module 2016-12-08 11:22:48 -05:00
Matt Martz
bcd9f83521 Prevent an empty error message 2016-12-08 11:22:48 -05:00
Brian Coca
34dbd69e12 updated to keep same info as in extras repo 2016-12-08 11:22:47 -05:00
Ian Babrou
005d02b185 not triggering reload for links and not string env variables 2016-12-08 11:22:47 -05:00
Ash Wilson
7c4e8774d8 Use {0}, {1} style format indices for 2.6 compat 2016-12-08 11:22:47 -05:00
Ash Wilson
ff0d0ceb70 Expect module env vars to override Dockerfile ones. 2016-12-08 11:22:47 -05:00
Ash Wilson
4e7d766e8f Include bind mounts in VOLUMES check. 2016-12-08 11:22:47 -05:00
Ash Wilson
959d135b60 Exposed ports, env vars, volumes from the image. 
This will account for settings that are provided by the hierarchy of
Dockerfiles used to construct your image, rather than only accounting
for settings provided to the module directly.
 2016-12-08 11:22:47 -05:00
Ash Wilson
0d822c0c02 Full image inspection and just repo tags 
Hat tip to @bobrik.
 2016-12-08 11:22:47 -05:00
Toshio Kuratomi
bba322a10e Sort subnets by the order they are specified in the play 
Fixes #172
 2016-12-08 11:22:47 -05:00
Bret Martin
650a7365f9 Allow vpc_subnet_id to remain unspecified (see bc0c169) 2016-12-08 11:22:47 -05:00
Sam Yaple
42fd85f041 Updated version and fixed default 2016-12-08 11:22:47 -05:00
Sam Yaple
24f1cf80bd Add pid mode support to docker module 
This allows setting the pid namespace for a container. Currently only
the 'host' pid namespace is supported.

This requires Docker 1.4.1 and docker-py 1.0.0
 2016-12-08 11:22:47 -05:00
Ash Wilson
1c5601a0b5 Connect to Docker with optional TLS. 2016-12-08 11:22:47 -05:00
Ash Wilson
4224dd1acb Rework docker module states. 
Organize each state into a distinct function for readability and composability.
Rework `present` to create but not start containers. Add a `restarted` state
to unconditionally restart a container and a `reloaded` state to restart a
container if and only if its configuration is incorrect. Store our most recent
knowledge about container states in a ContainerSet object. Improve the value
registered by this task to include not only the inspect data from any changed
containers, but also action counters in their native form, a summary message
for all actions taken, and a `reload_reasons` key to store a human-readable
diagnostic to determine why each container was reloaded.
 2016-12-08 11:22:47 -05:00
Matt Ferrante
aaca9b5127 check keys is in dim2 before evaluating 2016-12-08 11:22:47 -05:00
Lorin Hochstein
09e10ea031 Don't pass volumes_from to create_container 
Don't pass the volumes_from argument to the Docker create_container method.

If the volumes_from argument is passed to the create_container method, Docker
raises the following exception:

    docker.errors.DockerException: 'volumes_from' parameter has no effect on
    create_container(). It has been moved to start()
 2016-12-08 11:22:47 -05:00
zitterbacke
264a16d822 fix uri modul for JSON-escape quotation marks 
consider the following response body (content) of a REST/JSON webservice containing escaped quotation marks:

```json
{ "key": "\"works\"" }
```

decoding this string not as raw will lose the backslash as JSON escape. later json.loads will fail to parse.

Inspired by [this thread](https://groups.google.com/forum/#!topic/ansible-project/kymtiloDme4) on the mailing list and the following python shell code:

```python
import json
string=r'{ "key": "\"works\"" }'
json.loads(string)
json.loads(string.decode('raw_unicode_escape'))
json.loads(string.decode('unicode_escape'))
```
 2016-12-08 11:22:47 -05:00
Ash Wilson
338bbf6efc Pull newer image versions when requested. 2016-12-08 11:22:46 -05:00
Ash Wilson
6505ce3940 Another documentation commit. 2016-12-08 11:22:46 -05:00
Dag Wieers
43ef3a2bd9 Update authorized_key.py 
Fix a (common) error in the examples. This is something that may go unnoticed during troubleshooting when copy&pasting the example.
 2016-12-08 11:22:46 -05:00
Lev Popov
5f31654704 Allow to keep instance boot disk after instance deletion in google cloud module 2016-12-08 11:22:46 -05:00
Toshio Kuratomi
e5ba4e87d8 Fix for int port assignment in a playbook failing 
Ports are integer values but the old code was assuming they were
strings.  When login_port is put into playbook complex_args as an
integer the code would fail.  This update should make the argument
validating make sure we have an integer and then we can send that value
directly to the relevant APIs.

Fixes #818
 2016-12-08 11:22:46 -05:00
Toshio Kuratomi
49511ea078 Small code cleanup 2016-12-08 11:22:46 -05:00
Toshio Kuratomi
86f8a3d381 Clarify the documented behaviour of insertbefore slightly. 2016-12-08 11:22:46 -05:00
Toshio Kuratomi
9fa04de137 In service_enable, the default of changed is True so we have to set it to False explicitly if it is False. 
Fixes #875
 2016-12-08 11:22:46 -05:00
Brandon W Maister
2121bbc208 ec2: Apply all security groups at instance-creation 
The code was picking out the first instance from the security groups
specified, even when multiple groups were specified. Now we use all of
them.
 2016-12-08 11:22:46 -05:00
Lev Popov
6d1fd1afcc Allow to spawn instances without external ip in google cloud module 2016-12-08 11:22:46 -05:00
Michael Laccetti
8efb138fdc Moving the import to the top of the file and getting rid of the redundancy 
I sure do wish I knew where the whitespace change was coming from, though. Frustrating.
 2016-12-08 11:22:46 -05:00
Michael Laccetti
0bd25a9a38 Change s3 to use connect_to_region 
* Allows us to use Ansible/s3 for GovCloud when accessing a pre-existing bucket
 2016-12-08 11:22:46 -05:00
Jonathan Mainguy
1608163b26 Now correctly gzip/bzips file back up in case of import failure 
Removed gunzip and bunzip2 dependency
 2016-12-08 11:22:46 -05:00
Peter Gehres
878ff1e929 Issue #489: s3 should not fail on checksum mismtach when overwrite=no 2016-12-08 11:22:46 -05:00
Piotr Gosławski
9dd4f22430 update docs for insertbefore/insertafter 2016-12-08 11:22:46 -05:00
Piotr Gosławski
d388516046 Fix behavior when insert* doesn't match anything 
If insertbefore/insertafter didn't match anything, lineinfile module was doing nothing, instead of adding the line at end of fille as it's supposed to.
 2016-12-08 11:22:46 -05:00
Achilleas Pipinellis
302c6f9b82 Add note about using version 1 of DigitalOcean API. 2016-12-08 11:22:45 -05:00
Feanil Patel
a0caaf7f42 Compare DNS names case insensitively. 2016-12-08 11:22:45 -05:00
Carlo Mandelli
1f93a052d6 Added HP-UX subclass 2016-12-08 11:22:47 -05:00
James Cammarata
7fd7cffb61 Updating version added fields for new alias parameters in route53 2016-12-08 11:22:45 -05:00
Monty Taylor
3e3486b813 One more OpenStack deprecation notice 
Fixes #858
 2016-12-08 11:22:45 -05:00
Oleg A. Mamontov
845b6d78be On FreeBSD apply 'login_class' only if there is real change. 2016-12-08 11:22:45 -05:00
James Cammarata
657d9d1f25 Add private_zone parameter for route53 
Fixes #473
 2016-12-08 11:22:45 -05:00
Monty Taylor
411c7e22b6 Add deprecation notices for old OpenStack modules 2016-12-08 11:22:45 -05:00
Brian Coca
fb61d5e795 fixed add_host docs indentation 2016-12-08 11:22:45 -05:00
Monty Taylor
7c9a36a999 Deprecate old OpenStack modules 
There are a completely new set of modules that do all of the things like
keystone v3 and auth_plugins and the like correctly. Structurally
upgrading these would have been massively disruptive and there is no
real good way to do so without breaking people.

These modules should be kept around for several releases - they still
work for people - and they should get bug fixes. But they should not
take new features. New features should go to the os_ modules.
 2016-12-08 11:22:45 -05:00
Brian Coca
d6305bc938 fixed file module to use realpath when following links, readlink could be relative and fail in corner cases as per #852 2016-12-08 11:22:45 -05:00
Edward Larkey
d17726bae9 Fix typo in authorized key module documentation. 
Added opening double quote
 2016-12-08 11:22:45 -05:00
Toshio Kuratomi
b9984b1dfe Fix documentation to have correct param name 2016-12-08 11:22:45 -05:00
Dann Bohn
2cbaf16bcd rhn_channel using depriciated methods. swapped out with their replacements 2016-12-08 11:22:45 -05:00
Brian Coca
5c90040626 undeprecated docker_image until replacement actually arives 2016-12-08 11:22:45 -05:00
blxd
35c414c271 Added check mode support to the ini_file module 2016-12-08 11:22:45 -05:00
Gerard Lynch
1fcc1a7374 wait_for: updated docs, must be resolvable hostname, updated example 2016-12-08 11:22:45 -05:00
Brian Coca
1ca1a2ed98 fixed typo on isgid 2016-12-08 11:22:44 -05:00
Brian Coca
49c10e4359 now captures connection exceptions and returns in 'nicer' module failure 2016-12-08 11:22:44 -05:00
Brian Coca
6e08dea567 fixed issues with stats return docs as per feedback 2016-12-08 11:22:44 -05:00
Brian Coca
47f84190a0 removed always for success, as data wont show on fail 2016-12-08 11:22:44 -05:00
Brian Coca
4124f8c381 now module fails gracefully instead of stacktrace when trying to install missing deb file 2016-12-08 11:22:44 -05:00
Brian Coca
8f197aed48 added missing docs on connection_timeout for wait_for 2016-12-08 11:22:44 -05:00
Brian Coca
d07d41b914 added note to add_hosts about loop bypass 2016-12-08 11:22:44 -05:00
Brian Coca
bcd6a6a3d5 draft for documenting module returns 2016-12-08 11:22:44 -05:00
Coderah
0fbe26273d add alias support to route53 module 2016-12-08 11:22:44 -05:00
Coderah
40c41ed4ec add hosted_zone information to ec2_elb_lb return 2016-12-08 11:22:44 -05:00
Capi Etheriel
103caa2853 add ec2 instance tags and groups info 2016-12-08 11:22:44 -05:00
Joel Thompson
646657e325 Fixes issue 697 -- only purge the grants that need to be purged 2016-12-08 11:22:44 -05:00
Stefan J. Betz
aca24caa19 Create SSH Keys always after creating $HOME 2016-12-08 11:22:44 -05:00
Jorge-Rodriguez
ad9379ad7d Added optional parameter scheduler_hints. 2016-12-08 11:22:44 -05:00
Bret Martin
ed3f1a133b ec2: make group only match group names in this VPC 2016-12-08 11:22:43 -05:00
Edward
bad5aafd30 Fixes #816 Backups not enabled on new droplets. 
Convert backups_enabled string to lowercase. Similar to fix for private
networking.
 2016-12-08 11:22:43 -05:00
Brian Coca
2278a69f7b fix for mount w/o opts (bug introduced when fixing bind mounts) 2016-12-08 11:22:43 -05:00
Brian Coca
70856d5228 fix instance=None documentation 2016-12-08 11:22:43 -05:00
Brian Coca
cd7f498755 Revert "Revert "Don't use 'tenancy' in ec2 spot requests"" 2016-12-08 11:22:43 -05:00
Brian Coca
6e55a0324b Revert "Don't use 'tenancy' in ec2 spot requests" 2016-12-08 11:22:43 -05:00
Dan Rue
d3c686d632 Do not mark "skipped" when changed is false 
When using the "creates" option with the uri module, set changed
to False if the file already exists. This behavior is consistent with
other modules which use "creates", such as command and shell.
 2016-12-08 11:22:43 -05:00
Matt Martz
8e4755728e DRY up duplicate code 2016-12-08 11:22:43 -05:00
mrsheepuk
31421374c0 Doc change - make clearer usage for existing remote file 
Having read the doc for this module several times and completely missing that it can be used for existing remote archives, I propose this update to the wording to make clear from the top the two ways in which this module can be used.
 2016-12-08 11:22:43 -05:00
Gauvain Pocentek
6c7b202a63 fetch: fix the flat parameter description 
ansible-doc expects the value of the description field to be a list,
otherwise the output is not correct. This patch updates the flat
description to be a list.
 2016-12-08 11:22:43 -05:00
Matt Martz
cf50526cb5 Don't hardcode minimum for boot_volume_size 2016-12-08 11:22:43 -05:00
Sergey Zhukov
d013652dc7 Fixed broken volumes_from for client API >= 1.10 2016-12-08 11:22:43 -05:00
Marek Chodor
35ab6d15df Fixes docker.errors.DockerException: 'dns' parameter has no effect on create_container(). It has been moved to start() 2016-12-08 11:22:43 -05:00
Matt Martz
724ae97898 Fix order of logic to determine required args 2016-12-08 11:22:43 -05:00
Richard Lander
a0dad8e683 password required 2016-12-08 11:22:43 -05:00
Richard Lander
f5532b7904 set network_config.public_ips attribute 2016-12-08 11:22:43 -05:00
Matt Martz
1f51a5effd Add boot from volume functionality to rax and rax_cbs modules 2016-12-08 11:22:42 -05:00
Toshio Kuratomi
3aba0d5272 Fix for recursion traceback in copy with relative paths 
This is a further fix for: https://github.com/ansible/ansible/issues/9092

when the relative path contains a subdirectory.  Like:

ansible localhost -m copy -a 'src=/etc/group dest=foo/bar/'
 2016-12-08 11:22:42 -05:00
Matt Martz
cce6cb8d7f Don't hardcode a minimum size of a volume 2016-12-08 11:22:42 -05:00
mcameron
f799180a58 More general output. 2016-12-08 11:22:42 -05:00
Toshio Kuratomi
af6c625cc2 When recursing subdirectories, honor the follow parameter for setting file attributes. 
One half of the fix for
https://github.com/ansible/ansible-modules-core/issues/778
The other half is in basic.py
 2016-12-08 11:22:42 -05:00
mcameron
751e268f0d Useful log output. 2016-12-08 11:22:42 -05:00
Rahul Mehrotra
fe08f52d92 Fixed Documentation issue concerning file mode when specified using numberical value 2016-12-08 11:22:42 -05:00
David Hummel
63e9de3170 Fix issue #793: mysql_db: for state={absent,present} connections to database mysql fail for users other than root 2016-12-08 11:22:42 -05:00
Robert Marsa
4737b41f26 Added the ability to set an instance to forward ip. 2016-12-08 11:22:42 -05:00
Jon Hadfield
90f5a23f34 use is-enabled to check systemd service status. 2016-12-08 11:22:42 -05:00
Matt Martz
a078a99fae Support accounts with more than 100 load balancers 2016-12-08 11:22:42 -05:00
Brendan Jurd
fdc52b8277 Add word boundary in apache2_module regexp 
Add a word boundary \b to the regexp for checking the output of a2{en,dis}mod,
to avoid a false positive for a module that ends with the same text as the
module we're working on.

For example, the previous regexp r'.*spam already enabled' would also match
against 'eggs_spam already enabled'.

Also, get rid of the redundant '.*' from the end of the regexp.
 2016-12-08 11:22:42 -05:00
Graham Hay
15fcbcb0ee Use insserv where available 2016-12-08 11:22:42 -05:00
Henry Finucane
464c502f95 dpkg does not take a --force-yes option 2016-12-08 11:22:42 -05:00
Doug Ellwanger
cc6cc6e302 Pull SSL certificate IDs from existing ELBs 2016-12-08 11:22:42 -05:00
Petros Moisiadis
f5961f9ecf synchronize: use a single -F instead of -FF 
This small change corrects behavior when one uses an .rsync-filter file to exclude some paths from both being transferred and being deleted, so that these excluded paths can be handled separately with different tasks (e.g. in order to deploy the excluded paths independently from the rest paths and notify handlers appropriately). The problem with the double -FF option is that it excludes the .rsync-filter file from being transferred to the receiver. However, deletions are done on the side of the receiver, so it is absolutely necessary the .rsync-filter file to be transferred to the receiver, so that the receiver knows what files to delete and what not to delete.
 2016-12-08 11:22:42 -05:00
Sébastien Gross
164d518370 Add basic support for OSX groups. 2016-12-08 11:22:42 -05:00
Sébastien Gross
624be0e239 Add basic support for OS X (Darwin) user management. 2016-12-08 11:22:41 -05:00
Robert Marsa
bf3cb32c1b Added target_tags to gce_module. 2016-12-08 11:22:41 -05:00
Dagobert Michelsen
9991e8d8f1 Solaris SMF is already supported and should be mentioned in the docs, 2016-12-08 11:22:41 -05:00
Brian Coca
132c43a84f added note that url src is only avaialable from 1.9 on 2016-12-08 11:22:41 -05:00
Toshio Kuratomi
691f4cc049 Tabs to spaces 2016-12-08 11:22:41 -05:00
Tomer Paz
76ee9a6a04 resolve issue 764 
https://github.com/ansible/ansible-modules-core/issues/764
added 'domainname' attribute in addition to existing 'hostname'.
That's the most elegant way to delegate domain name to docker-py...
 2016-12-08 11:22:41 -05:00
Paul Geraghty
5f24584010 Correct grammar of comment relating to example 2016-12-08 11:22:41 -05:00
giovtorres
1f034a6573 Added pip example installing from local tarball 2016-12-08 11:22:41 -05:00
moussa taifi
742c10a1a0 Adds the currently available instance types for azure to the available dict(choices..... 2016-12-08 11:22:41 -05:00
Luc Bourlier
ae97d76a12 Don't use 'tenancy' in ec2 spot requests 
The problem was introduced in commit f5789e8e. 'tenancy' is a parameter of
ec2.run_instances, but not in ec2.request_spot_instances. So it was breaking
the support for spot requests.
 2016-12-08 11:22:41 -05:00
Jesse Keating
6f4273a3ff Add exclusive option to authorized_keys 
This option allows the module to ensure that ONLY the specified keys
exist in the authorized_keys file. All others will be removed. This is
quite useful when rotating keys and ensuring no other key will be
accepted.
 2016-12-08 11:22:41 -05:00
Philippe ALEXANDRE
5b48ecc80a Add Linuxmint support in hostname module 2016-12-08 11:22:41 -05:00
Jeff Gonzalez
7ea6650d6c Refactored code to use module utility fetch_url function. 2016-12-08 11:22:41 -05:00
Jeff Gonzalez
04fb952d49 Added documentation for using url as key source 2016-12-08 11:22:41 -05:00
Brian Coca
b6a1927f13 now allows for case in which someone removed the K* links and is trying to reenable a service 2016-12-08 11:22:41 -05:00
Brian Coca
03273e06c7 simplified update-rc.d enable/disable handling, removed forced defaults creation as that breaks local customizations 2016-12-08 11:22:41 -05:00
Jean-Baptiste Barth
c0b2960892 Improve formatting after previous commit 2016-12-08 11:22:41 -05:00
Jean-Baptiste Barth
58ff9bece2 EC2: move logic about terminated instances up (#423) 
As stated in #423, the commit 7f11c3d broke ec2 spot instance launching
after 1.7.2. This is because it acts on the 'res' variable which have 2
different types in the method, and in case we request spot instances,
the resulting object is not a result of ec2.run_instances() but
ec2.request_spot_instances(). Actually this fix doesn't seem to be
relevant in the spot instances case, because by construction we won't
retrieve 'terminated' instances in the end.
 2016-12-08 11:22:40 -05:00
Toshio Kuratomi
52d769d36c Reverse the force parameter for the hg module 2016-12-08 11:22:40 -05:00
Peter Mooshammer
d741b57b91 adding disk_type option to choose from pd-ssd or pd-standard 2016-12-08 11:22:40 -05:00
Toshio Kuratomi
49f5b28fbd Change the git force parameter to default to no as a safety change. 
Fixes #306
 2016-12-08 11:22:40 -05:00
Toshio Kuratomi
245dce0e30 Make documentation list when force changed defaults 2016-12-08 11:22:40 -05:00
Toshio Kuratomi
36a483dacd Update force documentation to reflect default=no 2016-12-08 11:22:40 -05:00
Brian Coca
b853ad6c90 corrected version added for latest features 2016-12-08 11:22:40 -05:00
Brian Coca
83e0516478 minor fixes on new rds refactor 2016-12-08 11:22:40 -05:00
AlejandroF
2e40773034 Example added 
How to define specific version of the package we need...
 2016-12-08 11:22:40 -05:00
Brian Coca
884471a6b5 implemented account expiration as flag and not state, removed from unsupported platforms 2016-12-08 11:22:40 -05:00
Toshio Kuratomi
84f27cfa68 Remove str.format() usage for python2.4 compat. 
Fixes #10036
 2016-12-08 11:22:40 -05:00
Conrado Buhrer
09082e6e7f fixed: namespace clash #710 2016-12-08 11:22:40 -05:00
Conrado Buhrer
abde33c615 fixed: erroneous logic 2016-12-08 11:22:40 -05:00
Conrado Buhrer
a6315043ef fixed: missing check for upgrade flag 2016-12-08 11:22:40 -05:00
Conrado Buhrer
807b168590 fixed: removed build-deb from required_one_of 2016-12-08 11:22:40 -05:00
Toshio Kuratomi
e4a3e5fdd7 Prefer gtar to tar 
Fixes #702
 2016-12-08 11:22:40 -05:00
Conrado Buhrer
3165b39d21 changed: state=build-dep; refactored into install() 2016-12-08 11:22:39 -05:00
Conrado Buhrer
442663a13a added: build-dep to apt module #349 
Original code provided by @nathanhruby
 2016-12-08 11:22:39 -05:00
Johannes Steger
1a440d6a06 Fix function identifier quoting 2016-12-08 11:22:39 -05:00
sysadmin75
2990358cd5 Fix #10059 - replace module does not obey follow=yes 2016-12-08 11:22:39 -05:00
Toshio Kuratomi
dd79a27e73 Spelling and grammar fix 2016-12-08 11:22:39 -05:00
Matt Martz
ff90273021 Remove unnecessary logic, return the database on delete 2016-12-08 11:22:39 -05:00
Toshio Kuratomi
a73bd8dcbc More information about distutils on Solaris in case we run into this again 2016-12-08 11:22:39 -05:00
Toshio Kuratomi
52bcf4a195 Don't fial if virtualenv is not installed and we do not need to initialize the virtualenv 
Fixes #688
 2016-12-08 11:22:39 -05:00
Brian Coca
f90da6b2ba ec2 fix docs format 2016-12-08 11:22:39 -05:00
Brian Coca
ed0f5045eb moved defaulting to module constant to after when it is defined 2016-12-08 11:22:39 -05:00
Toshio Kuratomi
547c90554a Standardize class names on Archive suffix. 
This also removes the collision between the stdlib ZipFile class and the
module's ZipFile class

Fixes #681
 2016-12-08 11:22:39 -05:00
Brian Coca
1f1ebf248f updated tenancy version added 2016-12-08 11:22:39 -05:00
Ryan Rawson
e318ef2d70 Fixes #581 - digitalocean module cannot create private_networking=true droplets 2016-12-08 11:22:39 -05:00
Ben Konrath
96a20de9ff Add support for SL7 to hostname module. 2016-12-08 11:22:39 -05:00
Brian Coca
8405edd5a2 now handles non string values for sysctl 2016-12-08 11:22:38 -05:00
Alex Clifford
4097cbf317 ttl should always be used during a delete 2016-12-08 11:22:38 -05:00
Matt Martz
8b60fb7181 Remove unnecessary required arg logic, and remove 'absent' as a valid choice since it isn't implemented 2016-12-08 11:22:38 -05:00
Matt Martz
5ae50eb8cf Small fix-ups to convert objects to dicts, update volume details at the appropriate time, and remove unnecessary required argument logic 2016-12-08 11:22:38 -05:00
Matt Martz
19d99e0da6 Remove some broken and unnecessary required args logic 2016-12-08 11:22:38 -05:00
Matt Martz
63e5d5dcc4 Use rax_to_dict and make sure to return the volume details after deletion 2016-12-08 11:22:38 -05:00
Brian Coca
02a1cb62df corrected release when this feature was added 2016-12-08 11:22:38 -05:00
Patrik Lundin
88fe45d7e7 Update OpenBSD rcctl handling to use new syntax. 
See http://marc.info/?l=openbsd-cvs&m=142054488027109&w=2
 2016-12-08 11:22:38 -05:00
Matt Martz
3a46c79451 Clean up some required argument logic 2016-12-08 11:22:38 -05:00
Matt Martz
db5f2bf3df Just use built in required functionality for arguments 2016-12-08 11:22:38 -05:00
Matt Martz
617048b717 It is not correct that you need at least 1 primary node 2016-12-08 11:22:38 -05:00
Tim G
b2e39265e1 Load distutils on all platforms EXCEPT Solaris. 
Solaris doesn't ship distutils with with the default Python package.  This patch fixes "service" on Solaris since 30d6713.
 2016-12-08 11:22:38 -05:00
Toshio Kuratomi
1728f9bba7 Add detection of uid,gid,mode changes when deciding whether an archive needs to be unarchived again. 2016-12-08 11:22:38 -05:00
Brian Coca
65d3b167e6 now captures cache fetch failures 2016-12-08 11:22:38 -05:00
Toshio Kuratomi
f9a6ec95b0 Implement user,group,mode,selinux settings for unarchive. 
This is a partial fix for #234.  Still have to figure out how to
make change reporting work as we can no longer rely on tar's --compare
option
 2016-12-08 11:22:38 -05:00
Toshio Kuratomi
44354e31e4 Better error messages if a2enmod/a2dismod are not found 2016-12-08 11:22:38 -05:00
Toshio Kuratomi
f3d41cdb06 Potential fix for 640 2016-12-08 11:22:38 -05:00
Tim G
ea77ac076b distutils is not available on some non-Linux OS's 2016-12-08 11:22:37 -05:00
Alex Clifford
d4c4dd31d8 Fix slight typo in doco 2016-12-08 11:22:37 -05:00
Toshio Kuratomi
e11ea4b402 Also catch mysql errors so we can give the error message back through json rather than tracebacking 2016-12-08 11:22:37 -05:00
Michael Scherer
0a745de765 Do not use echo shell builtin for password 
Using \t in a password may result in a different password
being set :

    $ echo 'a\ta'
    a   a

Problem report originally found by Pilou-
( https://github.com/ansible/ansible-modules-extras/pull/198 )
 2016-12-08 11:22:37 -05:00
Michael Scherer
b154bf967e Remove unused code 
There is no call to yum_base using 'cachedir' argument, so
while it work fine from a cursory look, that's useless code,
and so should be removed to clarify the code.
 2016-12-08 11:22:37 -05:00
Michael Scherer
2dfc7122af Use the rpm python module rather than execing rpm 
Using the rpm module prevent a uneeded fork, and permit
to skip the signature checking which slow down a bit the
operation, and which would be done by yum on installation
anyway.
 2016-12-08 11:22:37 -05:00
Bruce Pennypacker
605a5a5b53 requested changes 2016-12-08 11:22:37 -05:00
Bruce Pennypacker
9cbe3eb8ae Added support for 'REQUIRE SSL' grant option 2016-12-08 11:22:37 -05:00
Brian Coca
a3de4db57d fix for allowing permissions on hard links and soft links + follow=yes 2016-12-08 11:22:37 -05:00
Toshio Kuratomi
e75dc7e5a6 Clarify documented behaviour of user module's ssh_key_file parameter 
Fixes #9873
 2016-12-08 11:22:37 -05:00
Brian Coca
c5dfc66cb1 added version added for new template options 2016-12-08 11:22:37 -05:00
Vasyl Kaigorodov
d41ec7027f gce_net - creating firewall rule, src_range value seems to get lost or set to empty string -- fixes #252 2016-12-08 11:22:37 -05:00
James Martin
07dbc333b2 vpc_zone_identifier must be a csv string when an asg is updated. 2016-12-08 11:22:37 -05:00
Brian Coca
9eb77bdb4f fix for when state=directory, follow=yes and target is symlink to directory 2016-12-08 11:22:37 -05:00
Philip Misiowiec
f3abfa0f19 Adds tenancy state to returning json 2016-12-08 11:22:37 -05:00
Johnny Robeson
6fc04862a4 rename FedoraStratgy to SystemdStrategy 2016-12-08 11:22:37 -05:00
Michael J. Schultz
588d03db8d Build the db connection on "postgres" instead of "template1" 
According to the postgresql docs[1], you should not have a connection with
`"template1"` when copying multiple databases.

[1]: http://www.postgresql.org/docs/9.1/static/manage-ag-templatedbs.html
 2016-12-08 11:22:36 -05:00
Jeff Gonzalez
30822706dd Added ability to use url as key source 2016-12-08 11:22:36 -05:00
Michael Scherer
d357f309b5 Fix #370, by allowing to export over a existing repository 
This requires to use force=True
 2016-12-08 11:22:36 -05:00
Michael Scherer
e1194116b2 Make force parameter work for export operation 
The default is changed from 'yes' to 'no' to follow
subversion behavior (ie, requiring explicit confirmation
to erase a existing repository). Since that was not working before
cf #370 and since the option was ignored before and unused, this
should be safe to change.
 2016-12-08 11:22:36 -05:00
Patrik Lundin
9803938663 Handle string returned by 'default' correctly. 
We need to handle the string returned by 'default' in the same way we handle
the string returned by 'status' since the resulting flags are compared later.
 2016-12-08 11:22:36 -05:00
Jesse Buchanan
06a58dcad7 Files module: Allow touch on hardlinks 2016-12-08 11:22:36 -05:00
Patrik Lundin
d88080007a Fix typo: Replace "N0" with "NO". 2016-12-08 11:22:36 -05:00
anatoly techtonik
59a700ad17 acl: Fix X support in ACL permissions 
If you try to set rwX permissions, ACL fails to set them at all.

Expected:

    $ sudo setfacl -m 'group::rwX' www
    ...
    drwxrwxr-x  2 root root  4096 Nov 10 17:09 www

With Ansible:

    acl: name=/var/www permissions=rwX etype=group state=present
    ...
    drwxrw-r-x  2 root root  4096 Nov 10 17:30 www

x for group is erased. =/
 2016-12-08 11:22:36 -05:00
Patrik Lundin
6594a1458d Multiple fixes for OpenBSD rcctl handling. 
* Use the newly added 'default' argument to know if the default flags are set
  or not.
* Handle that 'status' may either return flags or YES/NO.
* Centralize flag handling logic.
* Set action variable after check if we need to keep going.

Big thanks to @ajacoutot for implementing the rcctl 'default' argument.
 2016-12-08 11:22:36 -05:00
Ricky Cook
522c644bf1 Fix regex string format 2016-12-08 11:22:36 -05:00
Ricky Cook
a6a9e2c247 Get warn option same as other args 2016-12-08 11:22:36 -05:00
Ricky Cook
095400c45e Add comment to command options dict 2016-12-08 11:22:36 -05:00
Ricky Cook
5e21c81ca4 Simplify command module option parsing 2016-12-08 11:22:36 -05:00
Luís Guilherme F. Pereira
b347875de0 Allow ec2_lc to create EC2-Classic Launch Configs 
Removes default value from ec2_lc so it can create launch configurations valid on a EC2-Classic environment. AWS API will not accept a assign_public_ip when creating an ASG outside of VPC.
 2016-12-08 11:22:36 -05:00
Nate Coraor
771fdfb1f8 Fix a few bugs and misbehavior in the hg module: 1. Don't pull when dest is already at the desired changeset. 2. Don't change the working copy when cleaning or pulling and a revision was specified. 3. Change the default for the revision param to match the behavior of hg. 2016-12-08 11:22:36 -05:00
Jonathan Mainguy
aef138107c Fixes bind mounts 
Fixed tab's and spaces, or so I think I did

Fixed tabs and spaces for real this time
 2016-12-08 11:22:36 -05:00
Jonathan Mainguy
6be46cb2e3 Fixes --enable-repo for Oracle Linux 2016-12-08 11:22:35 -05:00
Jonathan Mainguy
13990e9479 adds error message if socket does not exist 2016-12-08 11:22:35 -05:00
Philip Misiowiec
c57c1ea419 added version 2016-12-08 11:22:35 -05:00
billwanjohi
b019076dd3 user: add expired state 
ported from
https://github.com/ansible/ansible/pull/6303

It's very useful and routine to disable a *nix user.
I implemented expired instead of locked because this prevents any use of
the account, safer than just preventing password-based authentication.

I have tests [1], but since none of the suite came along with the core
modules, I'm unsure how to submit them.

[1] https://github.com/billwanjohi/ansible/blob/add_locked_state/test/integration/roles/test_user/tasks/main.yml
 2016-12-08 11:22:35 -05:00
kustodian
447c625cb3 Set selinux state to 'permissive' for state=disabled 2016-12-08 11:22:35 -05:00
Michael Scherer
36c653f54a Add hostname to generated user SSH key comment 
The default is not very useful to sort between different
keys and user. Adding the hostname in the comment permit to later
sort them if you start to reuse the key and set them in different
servers. See https://github.com/ansible/ansible/pull/7420
for the rational.
 2016-12-08 11:22:35 -05:00
Phillip Holmes
0d3b144eb2 Route53 fix - forcing zone_in, record_in to lower case 
Fixed the .tolower to .lower() for correct syntax (copied change from older notes).
 2016-12-08 11:22:35 -05:00
Philip Misiowiec
23668e41b0 Support for EC2 dedicated tenancy option 2016-12-08 11:22:35 -05:00
Philip Misiowiec
d30881a461 Ability to detach an EBS volume from an EC2 instance 2016-12-08 11:22:35 -05:00
fabios
3c53b3b268 mark as upgradable and let apt-get install deal with it 2016-12-08 11:22:35 -05:00
fabios
043242df2c improve fail message and use itertools chain 2016-12-08 11:22:35 -05:00
fabios
21bfa80203 older python-apt compatibility 2016-12-08 11:22:35 -05:00
fabios
301c8b8e09 handle list of list for python-apt < 0.7.9 compatibility 2016-12-08 11:22:35 -05:00
Lorin Hochstein
88d5f15025 docker: fix volume[s]_from typo 
Code makes reference to volume_from instead of volumes_from. If volumes_from is
passed as an argument, generates a KeyError.
 2016-12-08 11:22:35 -05:00
Toshio Kuratomi
1dc2ae0aef Cleanup the old apt compatibility changes 2016-12-08 11:22:35 -05:00
fabios
0ad355585a use low-level apt_pkg.Package 2016-12-08 11:22:35 -05:00
Jan Weitz
8146b45203 Fixes invalid dictionary access. 2016-12-08 11:22:35 -05:00
FabioBatSilva
a748229f3a fix compatibility issues with python-apt < 0.7.9 2016-12-08 11:22:34 -05:00
Mark Phillips
786aceb43b vsphere_guest fix for KeyError: folder message 2016-12-08 11:22:34 -05:00
Jan Weitz
1b9d0c5987 Fixes version check for docker-py 2016-12-08 11:22:34 -05:00
Toshio Kuratomi
1be539d870 git fetch --tags overwrites normal fetching with git < 1.8.x so do a normal fetch followed by using the refspec format for fetching tags 2016-12-08 11:22:34 -05:00
Toshio Kuratomi
73b7d6ea7b Fix typo in git refspec code. Change lists to tuples 2016-12-08 11:22:34 -05:00
Brian Coca
945909bf67 update to use connect_to_region to avoid errors with china 2016-12-08 11:22:34 -05:00
Brian Coca
abdb1afa0a Revert "Merge pull request #384 from jhawkesworth/win_copy_file_template_ansible_modules_core_1" I missed some discussion in devel, these need more work before inclusion 
This reverts commit 58bfebb047, reversing
changes made to 27dee77ca0.
 2016-12-08 11:22:34 -05:00
Peter Oliver
432a6286db Fix appending to a user's group on Solaris 
Without this change, you get:
    AttributeError: 'set' object has no attribute 'extend'

Tested on a Solaris 11.2 client with the included Python 2.6.8.
 2016-12-08 11:22:34 -05:00
Toshio Kuratomi
5c090207ff Make documentation clear about update=no vs clone=no 2016-12-08 11:22:34 -05:00
Chris Church
9d0830a181 Change version added in win_user docs to 1.9 for updates that didn't make it into 1.8. 2016-12-08 11:22:34 -05:00
Rohan McGovern
b607ffb7c6 git: add 'refspec' argument 
This argument may be used to fetch additional refs beyond the default
refs/heads/* and refs/tags/*.  Checking out GitHub pull requests or Gerrit
patch sets are two examples where this is useful.

Without this, specifying version=<sha1> with a SHA1 unreachable from any
tag or branch can't work.
 2016-12-08 11:22:34 -05:00
Rohan McGovern
06ff34f364 git: clean up "fetch" method 
De-duplicate repetitive code checking the exit code.

Include the stdout/stderr of the failed process in all cases.

Remove the returned values because no caller uses them.

Combine git commands where possible.  There is no need to fetch branches
and tags as two separate operations.
 2016-12-08 11:22:34 -05:00
Toshio Kuratomi
d28cd02ab7 Newstyle class 2016-12-08 11:22:34 -05:00
Toshio Kuratomi
4aaba45e29 Make insecure_registry feature version check against the client API 2016-12-08 11:22:34 -05:00
Maksim Losev
807d964a48 Add insecure_registry to docker-py pull method 
Starting from docker-py>=0.5.0 it is impossible to work with private registries based on HTTP.
So we need additional parameter to allow pull from insecure registry
Related to ansible/ansible#9111
 2016-12-08 11:22:34 -05:00
Toshio Kuratomi
7b74e451d9 Make docker ver checks issue failures rather than silently ignoring 
Also:
* make client version checks robust for two digit version pieces and
  alpha versions
* consolidate version checking code
 2016-12-08 11:22:33 -05:00
Will Thames
834c8d2f59 Added better region handling and enabled eu-central-1 
Make use of improved connect_to_aws that throws an exception
if a region can't be connected to (e.g. eu-central-1 requires
boto 2.34 onwards)

Add eu-central-1 to the two modules that hardcode their regions
Add us-gov-west-1 to ec2_ami_search to match documentation!
This pull request makes use of the changes in ansible/ansible#9419
 2016-12-08 11:22:33 -05:00
Ingo Gottwald
f88107bc9b Add support for new docker restart policies 2016-12-08 11:22:33 -05:00
Toshio Kuratomi
8af70de1fc Probably would make clone a 1.9 feature rather than 1.8.3 2016-12-08 11:22:33 -05:00
Toshio Kuratomi
a7ff6c4cba Make git's update parameter revert to its old behaviour and add new clone parameter to take its place. 
Fixes #426
Fixes https://github.com/ansible/ansible/issues/8630
 2016-12-08 11:22:33 -05:00
Kale Franz
7c8f0b99af #531 correction 
correct list comprehension for older versions of python (back to python 2.4)
 2016-12-08 11:22:33 -05:00
Kale Franz
eac743dc39 fixes #529 ec2_group module bug 2016-12-08 11:22:33 -05:00
Toshio Kuratomi
104b2d684c Add text/json as a mimetype to try deserializing 
Fixes #503
 2016-12-08 11:22:33 -05:00
Jonathan Mainguy
8c05023be3 Fixed hostname for rhel5 python 2.4.3 2016-12-08 11:22:33 -05:00
zitterbacke
1d4808780f re-enable AIX password setting 
the AIX class uses a unsafe shell for setting the user password (containing a pipe in the command). This patch adopts to the new behavior of module_utils/basic.py (since somewhere around 1.7).

besides it changes the qoutes for the echo command from double to single, because password-hashes contain $-signs and one would not have this variables expanded.
 2016-12-08 11:22:33 -05:00
Toshio Kuratomi
123c99f879 Add error message from git to message returned from ansible 
Fixes #81
 2016-12-08 11:22:33 -05:00
Jeff Gonzalez
8eedd915cd Fixed formatting in documentation 
The example was using mixed shorthand and long form yaml (region: "us-east-1 disable_rollback=true"

I modified the entire example to be long form.
 2016-12-08 11:22:33 -05:00
Jeff Bradberry
60ed80f99a Fix breakage in lineinfile check mode when target file does not exist. 
Similarly to https://github.com/ansible/ansible/issues/6182, checking of the file attributes should be avoided in check mode when the file didn't originally exist.

Also, avoid creating parent directories in check mode.

Fixes https://github.com/ansible/ansible/issues/9546
 2016-12-08 11:22:33 -05:00
Michael Scherer
104f91ed3b Revert commit cbc417c, as the code is broken, see #438 
LooseVersion expect a string, so filtering to return a int
is incorrect. Thanks to Jeremy Brown for the analysis.
 2016-12-08 11:22:33 -05:00
sysadmin75
7fbb422ae7 Fixes #9518 - "file state=directory" silently skips if it's currently a file 2016-12-08 11:22:33 -05:00
kustodian
8621f9a7cd Fixed postgresql_db failing on Python 2.4 with --check 
This reverts commit 81cbdb6c8c and adds ignoring of the SystemExit exception because of Python 2.4.
 2016-12-08 11:22:33 -05:00
Toshio Kuratomi
e359f7cfcf Don't traceback if a gid is specified instead of a group name 
Fixes https://github.com/ansible/ansible/issues/9796
 2016-12-08 11:22:33 -05:00
Mike Putnam
d2d0ffd83a Type fix on delete_snapshot docs. 2016-12-08 11:22:32 -05:00
Toshio Kuratomi
37f237ecfc Fixup the directory name at a higher level so it can be used by both conditional branches 
Fixes #500
 2016-12-08 11:22:32 -05:00
Jon Hawkesworth
44cc1a75ba Switched to SHA1 checksum instead of MD5 2016-12-08 11:22:32 -05:00
Harald Skoglund
1a8b9b8935 add support for stack policies in cloudformation 2016-12-08 11:22:32 -05:00
Jon Hawkesworth
67def35795 Adding first pass at win_copy, win_file and win_template modules (include new files). 2016-12-08 11:22:32 -05:00
Harri Hämäläinen
299d28f7e5 Fixed typo in comment 2016-12-08 11:22:32 -05:00
Brian Coca
6d56767454 fixed hostname for gentoo 2016-12-08 11:22:32 -05:00
Matt Martz
411e4cfae8 Make a few enhancements to the rax_scaling_group module 
* Cast loadbalancer id and port to integers
* Do not attempt to base64 encode NoneType values
 2016-12-08 11:22:32 -05:00
Petros Moisiadis
63b18ae618 mysql_user: Added missing privileges 
Added missing privileges 'CREATE TABLESPACE' and 'PROXY' (see: http://dev.mysql.com/doc/refman/5.5/en/privileges-provided.html).
 2016-12-08 11:22:32 -05:00
PikachuEXE
fbba80d72e ~ Add missing documentation for option email 2016-12-08 11:22:32 -05:00
Andrew Shults
2390184084 Strip white space to support multiline permissions in YAML 2016-12-08 11:22:32 -05:00
Toshio Kuratomi
88ccfc219a Change git update param documentation to match reality 2016-12-08 11:22:32 -05:00
Toshio Kuratomi
8b586ad055 Before pulling submodules from repos add ssh hostkeys for those submodules 
Fixes #9655
 2016-12-08 11:22:32 -05:00
Mike Putnam
1de5248a0a Clarify possible variable value in the docs. 2016-12-08 11:22:32 -05:00
Toshio Kuratomi
6f3f0904eb Fix git mod so that we switch to the desired version even if it was previously downloaded 2016-12-08 11:22:32 -05:00
Toshio Kuratomi
59066f6138 Some cleanups to the git module 2016-12-08 11:22:32 -05:00
Toshio Kuratomi
fc15177e6e Revert git module doc update because it appears ssh:// works and bare ssh repo does not 
This reverts commit e715909831.
 2016-12-08 11:22:31 -05:00
Marcus Ahle
a71b1b7385 Preventing Nonetype is not iterable error when no tags are passed in for a newly created ASG 2016-12-08 11:22:31 -05:00
Ben Whaley
6609ebde27 vpc_zone_identifier should be a list as per the docs 2016-12-08 11:22:31 -05:00
Brian Coca
77ec45e3d1 vastly simplified systemd detection, made enable/disable errors clearer both of which allows us to remove 'service name detection' as if systemd is init we still use it to handle initscripts. 2016-12-08 11:22:31 -05:00
Brian Coca
8b9772565e now actually adds usable name for systemd when service only has init script 2016-12-08 11:22:31 -05:00
Peter Bwire
20eb900065 Update django_manage to add database option for migrate 
Allow passing the database option to the django_manage module for migrations. This is usefull in situations where multiple databases are used by a django application.
 2016-12-08 11:22:31 -05:00
Dale Bewley
65d8fbd9ab use state parameter in examples 2016-12-08 11:22:31 -05:00
follower
b15a633103 Note that rsync must be installed on both local & remote machine 
In particular, if `rsync` is not installed on the remote machine the following error message will be encountered:

    "rsync error: remote command not found"
 2016-12-08 11:22:31 -05:00
Toshio Kuratomi
9fde3c2dc5 Add USAGE as a valid privilege 2016-12-08 11:22:31 -05:00
Scott Miller
c49a20b0e5 fix documentation 
AWS does not recognize the subnet if it is presented in a comma delimited format with spaces. you must remove the space for Amazon to recognize the second subnet.
 2016-12-08 11:22:31 -05:00
Toshio Kuratomi
cd7cc07e85 Gixes to doc formatting 2016-12-08 11:22:31 -05:00
Francois Deppierraz
181c3aa25f Fix auto_floating_ip documentation 
The default value is 'no' instead of the currently documented 'yes'.

See cloud/openstack/nova_compute.py line 543:

        auto_floating_ip                = dict(default=False, type='bool'),
 2016-12-08 11:22:31 -05:00
Toshio Kuratomi
307116b838 Fix typo so docs will build 2016-12-08 11:22:31 -05:00
Toshio Kuratomi
7ff9b3990a Update cron example for setting to run twice a day 
Fixes #415
 2016-12-08 11:22:31 -05:00
Tomasz Kontusz
103b5954c7 supervisorctl: Don't try to start a starting program 
Starting a "STARTING" program throws ERROR (already started),
so don't do that.
 2016-12-08 11:22:31 -05:00
Steve Fox
7af1c96623 retry_interval needs to be a float before passing to time.sleep 2016-12-08 11:22:31 -05:00
Lorin Hochstein
0cf3cfbf5a git doc: don't prepend ssh:// for ssh repo 
The github ssh example has ssh:// at the beginning of the url. However, this doesn't
work. It does work if the ssh:// is removed.
 2016-12-08 11:22:31 -05:00
Chris Church
ff193241b1 Minor win_user fixes based on feedback. 2016-12-08 11:22:30 -05:00
Brian Coca
ab96ff8b6d service cleanup 2016-12-08 11:22:30 -05:00
Stewart Rutledge
0f1bf6c8c1 Fixed a typo on power options 2016-12-08 11:22:30 -05:00
Jérémie Astori
c52bfe3e35 Fix #91: Expand user home folder for the key_file path of the git module 2016-12-08 11:22:30 -05:00
Chris Church
262624ca12 Update win_feature module to work on server 2008 and fail with error message on non-server windows, fix output messages and error handling. 2016-12-08 11:22:30 -05:00
Chris Church
c81c192dcb Update win_user module to support more user options and group membership changes. 2016-12-08 11:22:30 -05:00
sterutkb
944ce9c7c3 Added support for deploying virtual machine from a virtual template 2016-12-08 11:22:30 -05:00
Michael Scherer
4e4e0cca17 Fix old ticket #9092 where a playbook can enter in recursion 
This can be tested with this command :

    ansible -c local -m copy -a 'src=/etc/group dest=foo/' all

This is a corner case of the algorithm used to find how we should
copy recursively a folder, and this commit detect it and avoid it.

Check https://github.com/ansible/ansible/issues/9092 for the story
 2016-12-08 11:22:30 -05:00
Philip Misiowiec
3f4d412bff Ability to specify new SSD EBS option 2016-12-08 11:22:30 -05:00
Patrik Lundin
8a6a4a7757 Simplify self.arguments logic. 
Strange logic pointed out by @jarmani, thanks!
 2016-12-08 11:22:30 -05:00
Patrik Lundin
2b18e544f5 Depend more on rcctl if it is present. 
* Make the module support enable/disable of special services like pf via rcctl.
  Idea and method from @jarmani.
* Make the module handle when the user supplied 'arguments' variable does not
  match the current flags in rc.conf.local.
* Update description now that the code tries to use rcctl for everything if it
  is available.
 2016-12-08 11:22:30 -05:00
Will Thames
63656e5ef7 Fixed tagging 2016-12-08 11:22:30 -05:00
Denver Janke
61cfccff1c Fix few bugs around renaming db instances. 2016-12-08 11:22:30 -05:00
Will Thames
daac0e3a3e Improved error handling 
More tests, particular for failure testing
 2016-12-08 11:22:30 -05:00
Patrik Lundin
25c3c03a11 Tweak error checking for "enabled" code. 
Based on input from @jarmani:
* A return value of 2 now means a service does not exist. Instead of
  trying to handle the different meanings of rc after running "status",
  just look at stderr to know if something failed.
* Skip looking at stdout to make the code cleaner. Any errors should
  turn up on stderr.
 2016-12-08 11:22:30 -05:00
Patrik Lundin
32cb025b85 Fail if "rcctl status" writes to stderr. 2016-12-08 11:22:30 -05:00
Patrik Lundin
03d4b76b14 Check rc and print error message if any. 
It is probably good to use stdout before printing a generic error
message as well.
 2016-12-08 11:22:29 -05:00
Patrik Lundin
38d8db473f Make "enabled" code aware of --check mode. 2016-12-08 11:22:29 -05:00
Jonathan Armani
d1433eca14 Add enable / disable of services for OpenBSD if rcctl is present 2016-12-08 11:22:29 -05:00
Will Thames
22a3b3f811 RDS rewrite to use boto.rds and boto.rds2 
Using rds2 allows tags and the control over whether or not DBs are
publicly accessible.
Move RDS towards a pair of interfaces implementing the details of rds
and rds2
Added tests to ensure that all operations work correctly as well as
requirements files that allow virtualenvs to test either boto.rds or
boto.rds2
 2016-12-08 11:22:29 -05:00
Antti Salminen
75e15e2ae9 Find the actual commit annotated tags refer to instead of the tag object. 2016-12-08 11:22:29 -05:00
willthames
ef88ff6dd8 Added the ability to remove snapshots 
Added state option, and accompanying snapshot_id option for
when state=absent.
 2016-12-08 11:22:29 -05:00
Michael DeHaan
f875cc5197 Remove potentially out of date or specific product references. 2016-12-08 11:22:29 -05:00
Michael DeHaan
76efaa6cfb More EC2 doc tweaks 2016-12-08 11:22:29 -05:00
Michael DeHaan
590d20db24 Misc EC2 doc tweaks. 2016-12-08 11:22:29 -05:00
Toshio Kuratomi
ddc81c7b93 Escape % in db+table names before adding to a format string being passed into db.execute() 
Fixes #416
 2016-12-08 11:22:29 -05:00
Dan
fe787f1bc9 Adds a login_unix_socket option to the postgresql_privs module. 2016-12-08 11:22:29 -05:00
Dan
ee65c55fb0 Adds a unix_socket/login_unix_socket option to the postgresql_user module. 2016-12-08 11:22:29 -05:00
Dan
789ee410f1 Adds a login_unix_socket option to the postgresql_db module. 2016-12-08 11:22:29 -05:00
René Moser
ceeeea84cd yum: add update_cache option 
Yum does not always update to latest package version unless metadata cache has expired. By runing yum makecache, we ensure the metadata cache has been updated.

Signed-off-by: René Moser <mail@renemoser.net>
 2016-12-08 11:22:29 -05:00
Toshio Kuratomi
5734838cd1 Fix module traceback instead of returning an error 2016-12-08 11:22:29 -05:00
Eric
11bd0fed9d Fix lineinfile documentation typo 2016-12-08 11:22:28 -05:00
Achilleas Pipinellis
872f6aa559 Clarify supported init systems. 2016-12-08 11:22:28 -05:00
follower
4889701874 Fix typo of "rules_egress" 
Or is "rules_egree" supposed to be a plural? The sentence is difficult to parse.

Maybe the correct fix is to "Purge existing rules on security group that are not found in rules_egress"?
 2016-12-08 11:22:28 -05:00
Pascal Borreli
187b07e6c0 Fixed typo 2016-12-08 11:22:28 -05:00
Fabrice Bernhard
3d437b068e Typo in comments 
Credit goes to @kbsali
@pborreli : you did not see that one? :-)
 2016-12-08 11:22:28 -05:00