Commit graph

26648 commits

Author SHA1 Message Date
Gonéri Le Bouder
bda0687d28 vmware_host: ensure idempotency with state=absent (#54608)
If a host is already missing, `self.host_update` is `None`. With
this change,`state_exit_unchanged()` won't try anymore to access
`self.host_update.runtime`.
2019-04-09 01:04:47 -04:00
Zim Kalinowski
656ca13f65
adding application gateway support to vmss (#54973) 2019-04-09 10:31:34 +08:00
Jason Witkowski
87f8e37c2c Fix for neither LaunchConfigName nor LaunchTemplate existing on object (#54692) 2019-04-09 09:00:51 +10:00
Varun Chopra
4651bcf561 Add win_format (#53925)
* Add win_format

* Some doc changes were missed

* Fixes for ansible-test, additional assertion for check mode

* Fix -WhatIf issues

* Support for idempotency and changes to integration tests

* Fix trailing whitespace

* Fixes from review, and added check for non-empty volumes

* Remove an extra line

* Structural changes

* Minor fixes for CI
2019-04-09 06:45:04 +10:00
Bojan Vitnik
b27c4caa49 XenServer: Minor bug fixes 2 (#54697)
- xenserver module_util: fixed comment in set_vm_power_state().
 - xenserver module_util: renamed cdrom.iso VM fact to cdrom.iso_name
   in gather_vm_facts() to be in line with module parameter of same name.
 - xenserver module_util: sorted IPv6 addresses by their OS index
   in gather_vm_facts().
 - xenserver_guest module: fixed a bug in deploy() where an error message
   would not be shown when VM name is empty and check mode is used.
 - xenserver_guest module: fixed a bug in destroy() where VM would be
   shut down by error when check mode is used.
 - xenserver_guest module: fixed a bug in get_changes() where wrong
   out-of-bound disk position would be shown in error message when
   CD-ROM device occupies last position.
 - xenserver_guest module: assume value "none" for "networks.type" and
   "networks.type6" module parameters in get_changes() when no value is
   found in xenstore_data (custom customization agent).
 - xenserver_guest module: added separate error message in get_changes()
   for a case when maximum number of network interfaces is reached.
 - xenserver_guest module: negative value for disk size in
   get_normalized_disk_size() now properly shows an error.
2019-04-08 12:27:02 -04:00
Sumit Jaiswal
0ff689a315
Resolves handling of error and failure scenarios from Checkpoint module end (#54890)
* handle failure case

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* handle failure case

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* handle failure case

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
2019-04-08 21:37:52 +05:30
Matt Martz
56ae8ebd60 Don't swallow exceptions when processing included files (#54791)
* Don't swallow exceptions when processing included files. Fixes #54786
2019-04-08 12:03:22 -04:00
Hannes Ljungberg
17776142d1 Extend state option documentation (#54989) 2019-04-08 11:36:56 -04:00
Jim Ladd
17d78553ee Add options for configuring memory / pid polling interval (#54936) 2019-04-08 09:18:37 -05:00
Felix Fontein
7d27348356 ufw: fix default, direction is not necessary for it (#54799)
* Correct behavior so that direction isn't required for default.
* Add more tests.
* 'disabled' values cannot be changed.
* Include 'not specified' in messages.
2019-04-08 08:49:35 -04:00
Chris Archibald
c6f12eea32 push fix (#54916) 2019-04-08 13:11:42 +01:00
Felix Fontein
e079758b31 Move refactoring steps from #54635 to own PR. (#54690) 2019-04-08 12:59:55 +01:00
Ruben Tsirunyan
97ac03f613 zabbix_action: Checking event source for 'pause_suppressed' parameter (#54951) 2019-04-08 04:43:27 -04:00
Ruben Tsirunyan
0fe63ec2d6 zabbix_action: Fixing the default message checking (#54953) 2019-04-08 04:43:15 -04:00
Robert Osowiecki
1532e31ec0 Allow all of yum version compare operators (#54603)
* Allow all of yum version compare operators

* * yum: name="foo >= VERSION" integration test
* changelog fragment
2019-04-08 10:34:21 +02:00
Felix Fontein
221da3e8b1 Implement Ed25519, Ed448, X25519 and X448 support (cryptography backend). (#54947) 2019-04-08 10:30:05 +02:00
Felix Fontein
7a16703dff Add openssl_privatekey_info module (#54845)
* Add openssl_privatekey_info module.

* Addressing review feedback.

* Update docs.

* Update tests.

* Work around too broad sanity checks.

* ...

* Don't die when None is returned.

* Use OpenSSL to extract RSA and DSA key data.

* Extend tests.

* Make OpenSSL code compatible to OpenSSL < 1.1.

* Rewrite tests to use result dicts instead of result lists.

* Skip ECC for too old PyOpenSSL.

* Reformulate.

* Improve return_private_key_data docs.

* Rename path_content -> content.

* Add sample.

* Cleanup.

* Add key consistency check.

* Improve description.

* Adjust minimal version.

* Fallback code for some pyOpenSSL < 16.0 versions.

* Also support Ed25519 and Ed448 keys (or not).

* Add more consistency checks.

* Verify DSA keys manually.

* Improve DSA key validation.

* Forgot one condition.

* Make validation more robust.

* Move generic arithmetic code to module_utils/crypto.py.
2019-04-08 10:07:56 +02:00
Felix Fontein
4503426f32 Fix some formatting. (#54952) 2019-04-08 02:17:36 -04:00
Anil Kumar Muraleedharan
f5d97205a0 The module fails on switchport. Check added to fix. (#54970) 2019-04-08 10:41:36 +05:30
MyronFanQiu
e3c79979c2 support caching options (#51387) (#54710) 2019-04-08 11:41:53 +08:00
Zim Kalinowski
ea609c3492
adding plan and container settings to function app (#54830) 2019-04-08 11:05:21 +08:00
Zim Kalinowski
3be01cce33
fix poller for some resources (#54853) 2019-04-08 09:41:10 +08:00
Tyler Schwend
684b749e47 fix: Don't fail if updating Kinesis stream Shard count; We support this! (#54530)
This added support for increasing shard count:
https://github.com/ansible/ansible/pull/24805

But the conditional to fail if you have specified a shard count other 
than the current shard count was still left in.

This removes that conditional since it's no longer needed and prevents 
you from actually updating things!
2019-04-08 10:59:31 +10:00
William Leemans
993727ff5e New module: xfs_quota (#51654)
* New module: xfs_quota

* wildcard import resolution

* pep8 fixes

* validate-modules fixes

* pep8 and validate-module fixes

* removal of extra copyright info

* description capitalization and trailing dot

* Some more description

* type specification

* removal of notes

* reorder imports

* sorting

* starting with variable type

* removal of defaults

* results to dict

* results to dict

* complete condition

* removal of spaces for pep8 compliancy, removal of root check, addition of tests for failed xfs_quota commands indicating the need for elevation/capabilities

* lost result

* typo

* historical override removal

* report back values

* unexpected spaces removal

* Update lib/ansible/modules/system/xfs_quota.py

Co-Authored-By: bushvin <bushvin@users.noreply.github.com>

* Update lib/ansible/modules/system/xfs_quota.py

Co-Authored-By: bushvin <bushvin@users.noreply.github.com>

* Update lib/ansible/modules/system/xfs_quota.py

Co-Authored-By: bushvin <bushvin@users.noreply.github.com>

* Update lib/ansible/modules/system/xfs_quota.py

Co-Authored-By: bushvin <bushvin@users.noreply.github.com>

* Update lib/ansible/modules/system/xfs_quota.py

Co-Authored-By: bushvin <bushvin@users.noreply.github.com>

* Update lib/ansible/modules/system/xfs_quota.py

Co-Authored-By: bushvin <bushvin@users.noreply.github.com>

* Update lib/ansible/modules/system/xfs_quota.py

Co-Authored-By: bushvin <bushvin@users.noreply.github.com>

* Update lib/ansible/modules/system/xfs_quota.py

Co-Authored-By: bushvin <bushvin@users.noreply.github.com>

* Update lib/ansible/modules/system/xfs_quota.py

Co-Authored-By: bushvin <bushvin@users.noreply.github.com>

* Update lib/ansible/modules/system/xfs_quota.py

Co-Authored-By: bushvin <bushvin@users.noreply.github.com>

* Update lib/ansible/modules/system/xfs_quota.py

Co-Authored-By: bushvin <bushvin@users.noreply.github.com>

* Update lib/ansible/modules/system/xfs_quota.py

Co-Authored-By: bushvin <bushvin@users.noreply.github.com>

* Update lib/ansible/modules/system/xfs_quota.py

Co-Authored-By: bushvin <bushvin@users.noreply.github.com>

* Update lib/ansible/modules/system/xfs_quota.py

Co-Authored-By: bushvin <bushvin@users.noreply.github.com>

* Update lib/ansible/modules/system/xfs_quota.py

Co-Authored-By: bushvin <bushvin@users.noreply.github.com>

* Update lib/ansible/modules/system/xfs_quota.py

Co-Authored-By: bushvin <bushvin@users.noreply.github.com>

* Update lib/ansible/modules/system/xfs_quota.py

Co-Authored-By: bushvin <bushvin@users.noreply.github.com>

* typo

* raw data, full data

* removal of several else: statements and indentation

* pep8

* typo

* Update lib/ansible/modules/system/xfs_quota.py

Co-Authored-By: bushvin <bushvin@users.noreply.github.com>

* Update lib/ansible/modules/system/xfs_quota.py

Co-Authored-By: bushvin <bushvin@users.noreply.github.com>

* Update lib/ansible/modules/system/xfs_quota.py

Co-Authored-By: bushvin <bushvin@users.noreply.github.com>

* Update lib/ansible/modules/system/xfs_quota.py

Co-Authored-By: bushvin <bushvin@users.noreply.github.com>

* Update lib/ansible/modules/system/xfs_quota.py

Co-Authored-By: bushvin <bushvin@users.noreply.github.com>

* Update lib/ansible/modules/system/xfs_quota.py

Co-Authored-By: bushvin <bushvin@users.noreply.github.com>

* Update lib/ansible/modules/system/xfs_quota.py

Co-Authored-By: bushvin <bushvin@users.noreply.github.com>

* typo

* use bytes as base, not kilobytes

* be consistent

* integration tests

* lint

* empty lines

* Update lib/ansible/modules/system/xfs_quota.py

Co-Authored-By: bushvin <bushvin@users.noreply.github.com>

* updates

* ci group

* XFS not supported on osx

* XFS not supported by freebsd

* long lines and removal of xfs_quota dict in return

* RETURN values

* no more xfs_quota dict
2019-04-07 20:11:32 +01:00
Keith Maxwell
889024e101 Clarify example for fileglob lookup plugin (#54941)
fileglob returns a list of paths it does not return file contents, as explained in latest notes. The file lookup retrieves file contents. This change clarifies the first example to make it clear a paths, not contents, are returned. 

It also adds spaces around the lookup to avoid E206 from ansible-lint: "Variables should have spaces before and after: {{ var_name }}"

+label: docsite_pr
2019-04-07 16:24:48 +01:00
Bruno Inec
c637104078 Allow Netbox device modification (#53631)
* netbox_device: Allow device modification

* Add ability to update and existing device
* Allow check_mode
* Fail when device name is missing
* Fail when cannot resolve ID instead of taking ID 1 by default

* netbox_device: Add diff output

* netbox: Some refactoring

* Add diff output and check_mode to netbox_ip_address
* Deduplicate redundant code into netbox_utils

* netbox_utils: A few unit tests
2019-04-07 15:47:11 +05:30
Anil Kumar Muraleedharan
c2958df3a4 Removing provider from facts, command and config (#54623) 2019-04-05 21:50:29 -04:00
Adam Miller
21d692cace fix dnf module removal in dnf upstream 4.2.2+ (#54923)
* fix dnf module removal in dnf upstream 4.2.2+

Signed-off-by: Adam Miller <admiller@redhat.com>

* Remove extra blank line in changelog fragment.
2019-04-05 14:28:24 -07:00
Alicia Cozine
32218332ee
Add a recurse example to file module docs (#54926)
Add recurse example to file module
must set state: directory to use recurse: yes
2019-04-05 16:24:29 -05:00
Felix Fontein
c5991b970f openssl_certificate_info, openssl_csr: fix wrong exception, and little refactoring (#54922)
* Fix wrong exception name.

* Use crypto_utils.load_certificate_request() to load CSRs with both backends.
2019-04-05 16:18:30 -04:00
Julian
dafdcf286a passwordstore: add hint for subkey=password (#54221)
Clarify that subkey=password will always return the first line. Adding a YAML style subkey called "password" is not possible.
2019-04-05 15:11:14 -05:00
Lukas Kämmerling
22e1f33f5e Add rebuild server functionality (#54899) 2019-04-05 21:31:31 +02:00
Chris Archibald
730176db81 update networking example (#54802)
change syntax from param=value to param: value
2019-04-05 14:27:55 -05:00
Stefano Zilli
fa21e0c3db Fix example in iptables module (#54906)
In the documentation the rule_num parameter works only in conjunction with `action` set to `insert` - fix the example with the rule_num parameter.

+label: docsite_pr
2019-04-05 14:23:59 -05:00
Travis Estep
e9d1dd51d2 Removed spaces in blank line
Removed the spaces that were auto-placed in a blank line by editor
2019-04-05 14:15:20 -04:00
Travis Estep
5154f248c0 Add deployment slot example
The existing documentation does not include an example that shows how to create a deployment slot for a web app. After much frustration, I finally had to break out fiddler and look at the actual request that was being made in order to figure out how to create one. Hopefully the addition of this example will help someone like me who is struggling to easily solve this problem.

+label: docsite_pr
2019-04-05 14:15:20 -04:00
The Magician
78fe931327 Bug fixes for GCP modules (#54888) 2019-04-05 13:00:35 -04:00
Felix Fontein
65d7f0d17b Add openssl_certificate_info module (#54709)
* Add certificate_info module.

* Improve normalization.

* Add extension dump.

* Add support for basic_constraints and ocsp_must_staple.

* Update docs.

* Add serial number.

* Remove superfluous code.

* Fix formulation.

* Improve examples.

* Improve result docs.

* Forgot to add tests.

* Adjust when no fingerprints can be computed.
2019-04-05 15:47:05 +01:00
Simone Tiraboschi
087587ec48 ovirt_disk: really add new content types (#54720) 2019-04-05 05:40:51 -04:00
Sachidananda Urs
aaf6262ff9 Use --mode=script always while running gluster commands (#54843) (#54895) 2019-04-05 05:37:36 -04:00
Martin Nečas
6f5aacc168 Add ovirt role (#54600)
* innit of ovirt_role.py

* put permits to build_entity

* add manual update to role permit

* ovirt role add docs

* ovirt_role update syntax

* ovirt role dont use permit name

* use correct syntax fo get_all_permits

* add role description

* ovirt role update whitespace

* update pep8 syntax

* update permits description

* ovirt role add check_mode

* add remove all permits example

* update examples spacing
2019-04-05 10:21:59 +01:00
Chris Van Heuveln
0fe6bf911a nxos_interface:DI: delay only when operation state check is requested (#54862)
* nxos_interface:DI: should only use delay when operation state check is requested

There is a 10 second delay that is added for every interface that is changed.
This delay should only occur when a task sets one of the `want` vars.

* /return/continue/
2019-04-05 13:58:26 +05:30
Tyler Schwend
daca7fa584 fix: return a list, specifically (#54537)
tags.keys() returns a list of the keys, sure. But in Python 3 it's a 
"dict_keys" class, and BOTO is expecting a list. So let's make this work 
in Python 3.

list(tags) returns a list of the keys in Python 2 and Python3. That 
seems to be what we want.
2019-04-05 12:09:48 +10:00
Jordan Borean
10a9cf59dd
Added win_http_proxy and win_inet_proxy (#54631)
* Added win_http_proxy and win_inet_proxy

* Fix up docs sanity issues

* removed duplicate doc entry

* Fix docs issues and fix for empty proxy

* Removed <-loopback> for win_http_proxy

* doc changes from review
2019-04-05 11:19:30 +10:00
psharkey
a39051067b Adding support for memcached1.5 and redis5.0 parameter group families. (#54571) 2019-04-05 11:01:02 +10:00
Toshio Kuratomi
6a5d6a56f5 Update Ansible release version to v2.8.0a1.post0. 2019-04-04 17:59:06 -07:00
Toshio Kuratomi
ae667d3d86 New release v2.8.0a1 2019-04-04 16:37:20 -07:00
Felix Fontein
8cba1f9397 docker_network: add IPAM driver options support (#54632)
* Tidying up.

* Adding ipam_driver_options parameter.

* Add tests.

* Add changelog.
2019-04-04 15:44:31 -04:00
Artem Goncharov
d0745ed6a2 add support for specifying volume metadata (#48081)
add possibility to specify metadata (properties) to be set on the volume
2019-04-04 13:16:48 -04:00
Alan Rominger
aa3f010e62 optionally get service account file path from env var (#54407) 2019-04-04 13:02:11 -04:00