Commit graph

48328 commits

Author SHA1 Message Date
Edoardo T
0d905a0496 ACMEAccount.get_request check status code value lower boundary (#63140)
* check status code value lower boundary

Any HTTP code below 200 cannot be considered a success, should be
handled like a failure instead.

This is particularly true for below zero status codes.

Fixes #63139

* provide changelog fragment

* ensure connection errors are handled in Acme module

* add fetch_url check to ACME.send_signed_request

* remove module.fail_json

* move _assert_fetch_url_success out of ACMEAccount

* fix ansible-lint errors

* use simplified syntax status checking
2019-10-29 19:44:25 +01:00
Matt Clay
c782831dd7 Disable failing zabbix_host integration test. 2019-10-29 10:26:53 -07:00
Brian Coca
885ee62b53 clarified some points on environment keyword usage (#64065) 2019-10-29 13:17:41 -04:00
Austin Macdonald
1aee11c860 add newline to render table correctly (#63769) 2019-10-29 13:09:18 -04:00
Sloane Hertel
1e52782d6b Fix indentation of example (#63789)
Remove no_log since module_defaults aren't displayed like set_fact was
2019-10-29 13:08:41 -04:00
Robert Osowiecki
3c978a3225 lineinfile - don't run os.makedirs on empty dir path (#63921)
* Fix #63919: don't run os.makedirs on empty dir path

* integration test for lineinfile create: yes without path
2019-10-29 13:06:17 -04:00
bontreger
92daec5d0b Update password.py (#63965)
Update the examples of the password lookup plugin to show how multiple options are joined together.
2019-10-29 11:16:00 -04:00
John R Barker
ae2a27ad6a Disable automerge (#63958)
Help reduce the incoming flow of features into devel as we confirm what we are doing regarding collections.
2019-10-29 11:13:12 -04:00
Major Hayden
4048fb4da7 Fix doc errors on aws_batch_job_queue (#63804)
Fixes: ansible/ansible#63803

Signed-off-by: Major Hayden <major@redhat.com>
2019-10-29 10:24:21 -04:00
Bill Dodd
14eedb2956 Do not PATCH Account Enabled prop if not supported (#62617)
* do not PATCH Account Enabled prop if not supported

* add changelog fragment
2019-10-29 13:16:49 +00:00
Bill Dodd
c9a669e42c add GetSoftwareInventory command (#62811) 2019-10-29 13:15:42 +00:00
panyy3
31f3a29613 add UpdateUserName and UpdatePasswordPolicy (#62941)
* add new command UpdateUserName and UpdatePasswordPolicy in redfish_command module

* fix errors detected by ansible-test

* fix error detected by ansible-test

* change command name UpdatePasswordPolicy to UpdateAccountServiceProperties, and update parameter to account_properties to support mlti-properties setting
2019-10-29 13:13:40 +00:00
Bill Dodd
92a39a0910 add controller name to Drive and Volume inventories (#63106) 2019-10-29 13:13:12 +00:00
Nikita Beletskii
2108a2e1c9 add type of elements of list in package modules (#63427) 2019-10-29 13:12:50 +00:00
Bill Dodd
2b8553b242 Add SetBootOrder and SetDefaultBootOrder commands (#63915)
* add SetBootOrder and SetDefaultBootOrder commands

* change boot_order version added from 2.9 to 2.10
2019-10-29 13:10:58 +00:00
Felix Fontein
16d4d2dba9
acme_certificate: add select_chain option (#60710)
* Add select_alternate_chain option.

* Fix docs.

* Allow to match via subject key identifier and authority key identifier.

* Simplify test.

* Add comments.

* Add tests.

* Fix bugs.

* Also consider main chain when searching for alternatives.

* Bump version_added.

* Rename select_alternate_chain -> select_chain.
2019-10-29 08:09:15 +01:00
Felix Fontein
35a412fab7
openssl_csr: fix tests (#63994)
* Make sure tests are validated with correct backend in mind.

* Fix tests.
2019-10-29 07:07:17 +01:00
Felix Fontein
5c973dd147 docker_container: get rid of defaults (#63419)
* Add container_default_behavior option to get rid of some defaults.

* Add changelog.

* Fix option.
2019-10-28 16:40:48 -04:00
Marek Czernek
18f4f0549f Correct a typo (#64020) 2019-10-28 15:01:10 -05:00
Sandra McCann
ee8a088205 combine galaxy.com install roles details (#63486)
* combine galaxy.com install roles details
* flatten dev guide and user guide for galaxy
2019-10-28 14:59:14 -05:00
The Magician
d455183cac Bug fixes for GCP modules (#63966) 2019-10-28 13:50:24 -04:00
Sviatoslav Sydorenko
ee290bf5b1 Declare support for Python 3.8 @ Trove classifiers 2019-10-28 10:06:03 -07:00
Chris Budzilowicz
5c962ef859 revisions to docsite README (#63957) 2019-10-28 12:04:59 -05:00
Gonéri Le Bouder
039c770a95 vmware_host_firewall_manager: fix #61332
Since https://github.com/ansible/ansible/pull/56733, we were not able to apply
firewall rules with no `allowed_hosts` key.

closes: #61332

In addition, this patch ensures the `allowed_hosts` key accepts a dict,
instead of a dict in a single entry list.

```yaml
vmware_host_firewall_manager:
  esxi_hostname: "{{ esxi1 }}"
  rules:
    - name: NFC
      enabled: True
      allowed_hosts:
        - all_ip: False
          ip_address:
            - "1.2.3.4"
```

Should be written:

```yaml
vmware_host_firewall_manager:
  esxi_hostname: "{{ esxi1 }}"
  rules:
    - name: NFC
      enabled: True
      allowed_hosts:
        all_ip: False
        ip_address:
          - "1.2.3.4"
```
2019-10-28 13:01:02 -04:00
yanzhangi
358574d57f update ce_sflow to fix bugs (#64021)
* update ce_sflow to fix bugs

* update ce_sflow to fix bugs

* update ce_sflow to fix bugs

* update ce_sflow to fix bugs

* update ce_sflow to fix bugs
2019-10-28 10:33:41 -04:00
Andrey Klychkov
defccd1d44 postgresql_db: allow to pass users names with dots (#64007)
* postgresql_db: allow to pass users names with dots

* postgresql_db: allow to pass users names with dots, add changelog fragment

* postgresql_db: allow to pass users names with dots, fix ci
2019-10-28 13:23:09 +00:00
yanzhangi
823f2e3fca update ce_acl_interface to fix bugs (#64018) 2019-10-28 09:21:11 -04:00
John R Barker
1e8765f0d9
BOTMETA support migrated_to (#63952)
* BOTMETA support migrated_to

Allow BOTMETA to define if this part of the codebase has moved
into a Collection on Galaxy.
See also https://github.com/ansible/ansible/pull/63935

* Enforce migrated_to URL format

* pep8
2019-10-28 11:02:31 +00:00
Mark Chappell
ef7d060a3f AWS module_utils: Clear out Sanity Test issues (#63991) 2019-10-28 09:21:40 +00:00
Mark Chappell
cd7bfc09a1 AWS ELB: Sanity Test fixups (#64008) 2019-10-28 09:19:26 +00:00
Mark Chappell
8d7580a59f AWS S3 : Fixup sanity test issues and deprecate 2 unused options (#63989)
* S3 module Sanity check fixes.

* s3_lifecycle: deprecate unused 'requester_pays' option

* s3_sync: deprecate unused retries option

* Add changelog fragment
2019-10-28 09:18:08 +00:00
Mark Chappell
fd54c54b51 AWS IAM Sanity test cleanup and deprecate unused 'fail_on_delete' option (#63961)
* AWS IAM Sanity test cleanup

* Changelog and porting guide updates

* Review recommendations
2019-10-28 09:18:58 +01:00
Xu Yuandong
30be3a4a9f Revert "ce_sflow: update to fix bugs." (#64001)
* Revert "ce_sflow: update to fix bugs. (#59349)"

This reverts commit 7711524718.

* Update ce_sflow.py
2019-10-27 21:51:20 -04:00
Fabian von Feilitzsch
e60cdc310d Remove k8s_scale dependency on k8s_raw (#59887)
* Remove k8s_scale dependency on k8s_raw

* fix sanity checks
2019-10-25 15:44:39 -04:00
kalimsshar
01a92f0191 Make banner detection non-greedy in ios_banner (#63092)
* Make banner detection non-greedy in ios_banner

* Added ios_banner unit test to detect bug #63091

* Corrected PEP8 errors

* Added integration test

* Corrected typo in integration test
2019-10-25 14:20:00 -04:00
emschu
9d91e6275e enable grafana_annotations callback sending annotations to multiple panels (#57575)
* enable grafana_annotations callback plugin message sending to multiple panels

* remove new line at end of file

* restructuring code of grafana_annotations cb plugin

* add missing self keyword

* grafana callback: use list for panel_ids

* grafana callback: convert panel_id to integer

annotations HTTP API states that panelId are integer (same as
dashboardId which is also converted).
2019-10-25 18:49:20 +01:00
The Magician
0f6ca6c4c5 New Module: gcp_runtimeconfig_config_info (#63884) 2019-10-25 13:41:01 -04:00
The Magician
1d5413a6ce Bug fixes for GCP modules (#63941) 2019-10-25 13:40:41 -04:00
Andrey Klychkov
88af9f6470 mysql_replication - accept empty string to the module's parameters (#63546) 2019-10-25 11:56:40 -04:00
Matt Martz
cdb7ab61a0
Introduce context manager for temporary templar context changes (#60513)
* Introduce context manager for temporary templar context changes. Fixes #60106

* Rename and docstring

* Make set_temporary_context more generic, don't hardcode each thing you can set, apply to template action too

* not None

* linting fix

* Ignore invalid attrs

* Catch the right things, loop the right things

* Use set_temporary_context in a few extra action plugins
2019-10-25 09:51:57 -05:00
Martin Nečas
92d6212026 ovirt correct resolving nested atributes which are false (#63908) 2019-10-25 14:51:45 +01:00
Evert Mulder
5e9638c869 ManageIQ Ivanchuk fixes (#63948)
- manageiq-group: better handling if key not present
- manageiq-tenant: ivanchuk api now returns ids as strings
2019-10-25 14:46:13 +01:00
Andrey Klychkov
3aaebba235 postgresql_privs: allow to pass roles with names containing dots (#63942) 2019-10-25 14:39:49 +01:00
Jonathan Lestrelin
54f0b183dc Add BOTMETA entry for pear module (#62349)
* Add BOTMETA entry for pear module

Add an entry for pear module so that team_ansible can be set as maintainer

* Wrong indentation.

* Update .github/BOTMETA.yml

Co-Authored-By: Sloane Hertel <shertel@redhat.com>
2019-10-25 14:23:10 +01:00
Xu Yuandong
3e6ecdedb4 Botmate: update to label cloudengine files. (#63566)
* Update BOTMETA.yml

* update for cloudengine.
2019-10-25 14:11:40 +01:00
Xu Yuandong
5c5a315a44 a new module to manage static route and bfd. (#58004)
* add a new module

* update for shippable

* update

* update for shippable

* update for shippable

* update for shippable

* update

* add unittest.

* update

* update integration

* update unittest

* update

* update unittest.

* update for syntax error

* update for reviewing.
2019-10-25 06:40:30 -04:00
Nurfet Becirevic
9d68115f7f Add packet project module (#63569) 2019-10-25 06:28:49 -04:00
Dusan Matejka
57c36e0378 Zabbix integration tests (#63744)
* adjusted setup_zabbix integration tests role to work on distributions from Debian family

* bumped zabbix_host integration tests role to be run against bionic
2019-10-25 06:28:20 -04:00
Will Thames
07ed860c2b Add more kubernetes Service tests (#62581)
* Add more kubernetes Service tests

Services can often go wrong, and one of the main motivations for
apply was being able to correctly modify them, so more tests are good

* Remove a port from a service for k8s testing

* Add a Service check mode to k8s tests
2019-10-25 11:21:13 +01:00
abarbare
8d1aa42e7b fix: Scaleway loadbalancer API url (#63437) 2019-10-25 11:19:25 +01:00