cmueller/ansible
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity
17357 commits 47 branches 390 tags 440 MiB
Commit graph

280 commits

Author SHA1 Message Date
Toshio Kuratomi
f9f8af06fc Change asserts to assertIsInstance for better error messages 2015-05-08 13:49:10 -07:00
Matt Martz
a0fc8bb0bd Testing additions and fixes 
* Fix import pathing for units.mock
* Add some additional requirements
* Use compileall to test compatiblity with different python versions
 2015-05-08 13:40:02 -05:00
James Cammarata
ce3ef7f4c1 Making the switch to v2 2015-05-03 21:47:26 -05:00
Jesse Rusak
652cd6cd5e Fix --force-handlers, and allow it in plays and ansible.cfg 
The --force-handlers command line argument was not correctly running
handlers on hosts which had tasks that later failed. This corrects that,
and also allows you to specify force_handlers in ansible.cfg or in a
play.
 2015-04-10 19:38:59 -04:00
James Laska
60acdee0dc Enable assert_raises_regexp on py26 2015-03-13 08:21:14 -04:00
Toshio Kuratomi
f05cda6ffc Comma is also dependent on position within the hash 2015-03-12 13:20:51 -07:00
Brian Coca
74bf59082d fixed and reintroduced syncronize test, fakerunner object needed become_method to be it's default 'sudo' 2015-03-12 14:48:06 -04:00
Toshio Kuratomi
644e50fe34 Hash randomization makes one of the heuristic_log_sanitize checks not work. 
Nothing we can do, when it sanitizes ssh_urls it's simply overzealous.
 2015-03-12 11:39:47 -07:00
Brian Coca
587ab17f10 fixes password error detection for ssh connection plugin 
removes sycnronize test that does not work with current sudo setup
Fixes #10434
 2015-03-11 16:11:27 -04:00
Brian Coca
5f6db0e164 preliminary privlege escalation unification + pbrun 
- become constants inherit existing sudo/su ones
- become command line options, marked sudo/su as deprecated and moved sudo/su passwords to runas group
- changed method signatures as privlege escalation is collapsed to become
- added tests for su and become, diabled su for lack of support in local.py
- updated playbook,play and task objects to become
- added become to runner
- added whoami test for become/sudo/su
- added home override dir for plugins
- removed useless method from ask pass
- forced become pass to always be string also uses to_bytes
- fixed fakerunner for tests
- corrected reference in synchronize action plugin
- added pfexec (needs testing)
- removed unused sudo/su in runner init
- removed deprecated info
- updated pe tests to allow to run under sudo and not need root
- normalized become options into a funciton to avoid duplication and inconsistencies
- pushed suppored list to connection classs property
- updated all connection plugins to latest 'become' pe

- includes fixes from feedback (including typos)
- added draft docs
- stub of become_exe, leaving for future v2 fixes
 2015-03-10 18:42:36 -04:00
Toshio Kuratomi
ffb281d96c Merge pull request #9600 from msabramo/make_AnsibleError_a_plain_ol_exception 
Make AnsibleError a plain ol' exception
 2015-03-03 09:56:09 -08:00
Alejandro Guirao
b8cf131375 Bug fix: Search only for files as candidates 2015-02-26 19:13:07 +01:00
Brian Coca
8872bba21f rearranged math filters 2015-02-18 20:03:05 -05:00
Brian Coca
2642738646 changed jsonify test to ignore whitespace 2015-02-18 12:09:22 -05:00
Brian Coca
bc5d0a8cd4 fixed jsonify test 2015-02-17 08:58:52 -05:00
Brian Coca
5f2d5abeea ensure proper strings/unicodestrings for passwords 
updated to correct to_bytes function
removed old to_bytes/to_unicode and repointed clients to new location
fixed unicode test
 2015-02-12 17:44:08 -05:00
Toshio Kuratomi
4902c06304 Obfuscate passwords in more places where it is displayed 2015-02-09 10:13:13 -08:00
Marc Abramowitz
372a29744b Make AnsibleError a plain ol' exception 
Python's Exception constructor already takes a `message` as a parameter,
which you can then get at by doing str(e) (e.message was deprecated).

The reason I bothered to make this change was because I was debugging
with pdb and I noticed that AnsibleErrors don't give useful information
in pdb (probably because they don't have a __repr__ method that prints
the `msg` attribute).

    (Pdb) c
    > /Users/marca/dev/git-repos/ansible/lib/ansible/runner/__init__.py(599)_executor()
    -> msg = str(ae)
    (Pdb) ae
    AnsibleError()
 2015-01-29 10:36:06 -08:00
Björn Andersson
65e4f2b2bc Add filter to turn a string into a UUID 
This filter was made because I needed to create idempotent UUIDs when
installing the agent for Go (http://go.cd), which uses UUIds to
distinguish the agents from each other.

It uses a newly created Ansible namespace to distinguish UUIDs created
by Ansible from any other source. The new namespace is a random one
created by uuidgen on OSX.
 2015-01-21 08:07:17 +08:00
Michael DeHaan
d4da58e102 Merge pull request #9720 from vlajos/typofixes-vlajos-20141204 
typofixes - https://github.com/vlajos/misspell_fixer
 2014-12-08 14:00:52 -08:00
Veres Lajos
bf5d8ee678 typofixes - https://github.com/vlajos/misspell_fixer 2014-12-04 22:23:35 +00:00
Brian Coca
97408fe5b2 Revert "Make listify respect the global setting for undefined variables." 
This 'mostly' reverts commit 2769098fe7.

Conflicts:
	lib/ansible/utils/__init__.py
	test/units/TestUtils.py
 2014-12-04 09:14:53 -05:00
Brian Coca
7d2937b1cc minor fixes to template function 
- make sure it calls itself correctly, now passes same params as it recieves
- vars is reserved, changed for templatevars to avoid confustion
- forcing mustaches again since the removal broke 'listification' as per #9622
- fixes incorrectly successful tests using undefined var, now it is defined
- now returns empty list if items is None to avoid errors
 2014-11-25 12:59:13 -05:00
Toshio Kuratomi
d36c38c35e Exception message changes 2014-11-25 02:36:38 -08:00
Toshio Kuratomi
067112b5ee Code for modules to perform more robust quoting of database identifiers 2014-11-24 20:55:44 -08:00
Toshio Kuratomi
4ae2d58d72 Fix detection of fips mode in test_do_encrypt_md5 2014-11-17 13:33:30 -08:00
James Cammarata
9a0f8f0158 Split out various vars-related things to avoid merging too early 
Fixes #9498
 2014-11-17 15:31:55 -06:00
Toshio Kuratomi
d14dcdc222 Docker test does not require the mock module 2014-11-14 08:59:36 -08:00
Toshio Kuratomi
b95475c1f9 Unittest the get_split_image_tag function in the docker module 2014-11-14 08:48:21 -08:00
Toshio Kuratomi
6030be3835 Add unittest for discrete functions in the apt module 2014-11-14 07:55:10 -08:00
Toshio Kuratomi
44eb19d553 Make VaultEditor Tests compatible with FIPS mode 
Migrate one test to vault-1.1.  Skip the two other vault 1.0 tests if
running on a FIPS enabled system
 2014-11-12 12:05:25 -08:00
Toshio Kuratomi
e05b22e0d1 Skip some md5 related unit tests when running in fips mode 2014-11-12 11:47:11 -08:00
Toshio Kuratomi
f1267c0b05 Move from md5 to sha1 to work on fips-140 enabled systems 2014-11-06 21:28:04 -08:00
Toshio Kuratomi
48a308a87c Allow both old-style and new-style role dependencies to be valid. 
Fixes #9173
 2014-10-09 02:48:47 -04:00
Rob Howard
2769098fe7 Make listify respect the global setting for undefined variables. 
(Fixes #9008.)

With credit to jimi-c for the initial pass in this commit:
b18bd6b98e
 2014-10-08 13:47:11 +11:00
Michael DeHaan
4cb7f654b6 Add stub tests for module args parsing. 2014-10-07 17:00:01 -04:00
Michael DeHaan
6db1b4dfd2 WIP on refactoring changes 2014-10-03 15:25:21 -04:00
Toshio Kuratomi
e6fcd90342 Merge pull request #9224 from drawks/iss9223 
Resolve #9223 Fix test for python 2.6
 2014-10-01 11:54:44 -04:00
Toshio Kuratomi
e00d657362 Make unittest compatible with python <= 2.6 2014-10-01 11:50:45 -04:00
Dave Rawks
5f54b57b6d Corrected indentation 2014-09-30 13:37:47 -07:00
Toshio Kuratomi
0af750e3e5 Merge pull request #9182 from bbasleeper/feature_sudo_exe_from_inventory 
Add a new inventory parameter (ansible_sudo_exe) to specify sudo command...
 2014-09-30 14:55:46 -04:00
Dave Rawks
c070ab69f7 Resolve #9223 Fix test for python 2.6 
* trivial test refactor to allow for python 2.6 compat
 2014-09-30 11:24:47 -07:00
Bruno BAILLUET
a25da4af05 Add a new inventory parameter (ansible_sudo_exe) to specify sudo command path. 2014-09-27 17:39:49 +02:00
Michael DeHaan
f35ed8a6c0 Update module test code to avoid pycs (that are not used) 2014-09-26 10:57:12 -04:00
Michael DeHaan
d6e6d2a6ca Remove regex related to baby-JSON parsing only. 2014-09-11 13:30:10 -04:00
Michael DeHaan
26cdddaebf Tracebacks are now catchable with ignore_errors and have streamlined output. Also removes 'baby-JSON' for bash modules. 2014-09-11 12:27:21 -04:00
James Cammarata
317ab06bc6 Fixing multiline parsing to preserve newlines 
Fixes #8813
 2014-09-10 15:14:46 -05:00
James Cammarata
8cc3543918 Re-allow templating of complex_args, but count params to prevent injection 
Fixes #8810
 2014-09-05 14:24:05 -05:00
Toshio Kuratomi
8233522a7a Reduce commenting as basic.py is copied to the remote host with every module transfer. 
Move some comments to the unittest as we might look at that if we decide
to refactor the code.
 2014-09-05 07:39:17 -07:00
Toshio Kuratomi
d293a46994 Unittests to detect speed regressions in password obfuscation and that 
the passwords are correctly hidden in the output.
 2014-09-04 18:03:49 -07:00
Michael DeHaan
8a0045baad Update tests for ansible-galaxy CLI additions. 2014-08-22 14:01:15 -04:00
Michael DeHaan
d87830e1cc Merge branch 'galaxy_github_archive' of git://github.com/willthames/ansible into devel 
Conflicts:
	lib/ansible/utils/__init__.py
 2014-08-22 13:58:50 -04:00
James Cammarata
d01188033f Checking for localized versions of the su password prompt 
Fixes #8681
 2014-08-22 09:59:40 -05:00
Will Thames
850963790d Allow roles to be installed from archives on github 
Ensure that the automated scm determination for github.com
repos still copes with .tar.gz archive files.

Handling .zip archives is left as an exercise for the interested reader
 2014-08-22 10:06:21 +10:00
Michael DeHaan
bcb44276fe Assume github.com URLs are git protocol if not specified. 2014-08-21 17:15:23 -04:00
Will Thames
6e9abefc11 Corrected bug where role_path was wrong for roles in subdirectories 
Fixed role name for
    - { role: 'lives/in/a/subdirectory' }
Should be 'lives/in/a/subdirectory', not just 'subdirectory'
 2014-08-21 17:15:23 -04:00
Will Thames
46b59b02ed Friendly Role Names and roles from URLs 
* Roles can now be given a friendly name as third field in role spec csv
* Roles can be installed from URL (not just from archived SCMs)
* Integration tests to demonstrate this
* Unit tests to ensure that role spec parsing works as expected
 2014-08-21 17:15:23 -04:00
Will Thames
4803e923ff Improved handling of role_version in repo_url_to_role_name 2014-08-21 17:15:23 -04:00
Will Thames
c2fe33f9f4 Tidied up a little, added tests 
Moved repo_url_to_role_name to common method in ansible.utils
Added unit test for repo_url_to_role_name
Added integration tests for galaxy
 2014-08-21 17:15:23 -04:00
James Cammarata
8a1fbed5d6 Correct variable blending from vars_files with hostvars in them 
Fixes #8638
 2014-08-20 15:49:01 -05:00
Michael DeHaan
99c39b1ff3 By popular request, make the no_log attribute also censor tasks from callbacks. 2014-08-12 13:36:05 -04:00
James Cammarata
5a128ca286 Adding extra member to mock inventory for unittests 2014-08-11 19:29:55 -05:00
Michael DeHaan
2629cd3fce Fix some copyrights, fix a misc test. 2014-08-11 12:23:05 -04:00
James Cammarata
25e9d1197e Merge branch 'optimise_utils_clean_data' of https://github.com/leth/ansible into leth-optimise_utils_clean_data 2014-08-11 10:21:02 -05:00
Marcus Cobden
e3dbca9378 Test escaping strings with two variables 2014-08-11 08:46:47 +01:00
Michael DeHaan
3bead39c75 Merge branch 'spelling' of git://github.com/cgar/ansible into devel 
Conflicts:
	docsite/rst/guide_rax.rst
	plugins/callbacks/mail.py
 2014-08-08 13:28:45 -04:00
James Cammarata
63bf2f6d9a Preserve all line breaks in literal blocks 
Fixes #8512
 2014-08-08 12:11:15 -05:00
Michael DeHaan
8c4161d4a1 Merge branch 'retf_py' of git://github.com/berendt/ansible into devel 
Conflicts:
	lib/ansible/inventory/vars_plugins/group_vars.py
	plugins/callbacks/mail.py
 2014-08-08 12:17:37 -04:00
Michael Peters
3ba516ac25 adding min() and max() filters for use in Jinja templates 2014-08-08 11:28:48 -04:00
James Cammarata
af0d8cda7b Fix literal block multiline parsing 
Fixes #8394
 2014-08-04 11:10:07 -05:00
James Cammarata
6d94ae64ec Remove unnecessary unicode conversions from parse_kv 
Fixes #8425
 2014-08-04 09:59:08 -05:00
James Cammarata
e6fa50a306 Move splitter to module_utils so modules can use it and fix command arg splitting 
Fixes #8338
 2014-07-29 14:55:16 -05:00
James Cammarata
aee940aaca Reworking _clean_data() to be smarter about replaces 
Fixes #8228
 2014-07-28 16:50:18 -05:00
James Cammarata
a8c2d6acd5 Adding unittest for space preservation within quotes when splitting args 2014-07-25 15:23:32 -05:00
James Cammarata
8f694c7588 Fixing unittests based on previous patch for splitting 2014-07-25 13:42:10 -05:00
Michael DeHaan
8d42f5cbfa Smush ds removal 2014-07-24 20:38:02 -05:00
Michael DeHaan
eeb51b6bf3 Moar split_args tests 2014-07-24 20:42:41 -04:00
Michael DeHaan
630f080cf0 Start of unit tests for split_args function, moved split_args to utils since not needed by modules (so far). 2014-07-24 20:15:04 -04:00
James Cammarata
4e5eb7559e Merge branch 'svg_and_inventory_refactor' into devel 2014-07-10 14:43:07 -05:00
Dan Slimmon
6ad09f1825 Added test for regex grouping bug fixed in 307a3e 2014-07-10 00:21:38 +00:00
James Cammarata
d8a7b49b59 Merge branch 'inventorytree' of https://github.com/sergevanginderachter/ansible into sergevanginderachter-inventorytree 2014-06-24 15:21:08 -05:00
James Cammarata
32aa948dd0 Exclude ps1 modules from the TestModules unittest 
Fixes #7864
 2014-06-20 10:15:35 -05:00
James Cammarata
8ff0c0f253 Tweaking make_su_cmd test 
Fixes #7652
 2014-06-04 13:03:50 -05:00
Timothy Appnel
754d635aca Recent BSD su work introduced a failing test. Removed leading space from the assertion that seems to be the culprit. 2014-05-27 10:50:19 -04:00
James Cammarata
1e672a0fec Fixes for su on freebsd 
Addresses multiple issues when using su on freebsd including
* su prompt differs between platforms, so turned that check into a
  regex comparison instead of a simple string comparison
* not using '-c' after su causes problems, so added that for all
  platforms
* fixed quoting issues due to multiple uses of '-c' introduced by
  the above fix

Fixes #7503
Fixes #7507
 2014-05-23 10:06:09 -05:00
Kevin Bell
bcfef8d0d4 Add a broken test that shows extensions not skipped 2014-05-14 23:43:14 -07:00
Christian Berendt
6676720ce5 fixed typos found by RETF rules in PY files 
rules are avaialble at https://en.wikipedia.org/wiki/Wikipedia:AutoWikiBrowser/Typos
 2014-05-03 18:40:05 +02:00
Carlos E. Garcia
7f5dd5e85d multiple spelling error changes 2014-04-29 10:41:05 -04:00
Taylor Barstow
154055e9ff Fixing expectations in test_dir_inventory_groups_for_host 2014-04-17 16:41:49 -04:00
Michael DeHaan
a5e7492c4f This test appears OS specific, so disabling for now. 2014-04-15 20:21:50 -04:00
Timothy Appnel
fd35c59fc1 Fixed escaping of " in test_make_sudo_cmd in TestUtils so that it passes 
as it should.

Signed-off-by: Timothy Appnel <tim@appnel.com>
 2014-04-15 19:35:53 -04:00
James Cammarata
bdbb3bb4a1 Fixing unit tests for synchronize due to earlier changes 2014-04-14 21:13:14 -05:00
Taylor Barstow
9ed7717634 Adding unit tests for host groups with inventory dir 2014-04-13 13:01:13 -04:00
James Tanner
d9d36ce207 Add unit tests for vars_files 2014-04-10 13:55:03 -04:00
Matt Martz
5770428e91 Add version_compare filter 2014-04-02 20:21:30 -05:00
James Tanner
efba8b4771 Merge branch 'regexreplace' of git://github.com/jacobweber/ansible into jacobweber-regexreplace 2014-03-31 13:48:13 -04:00
Serge van Ginderachter
d3eaa1b79e InventoryDir: refactor logic 
Make sure all hosts and groups are unique objects
and that those are referenced uniquely everywhere.
Also fixes test_dir_inventory unit tests which were broken after previous
patches.

	modified:   lib/ansible/inventory/dir.py
 2014-03-25 12:45:00 +01:00
Michael DeHaan
c42dbf80a2 Merge pull request #6586 from sivel/probline-logic-fix 
Fix logic in process_common_errors for unbalanced quotes
 2014-03-19 17:45:49 -04:00
Matt Martz
2aaecc5afa Fix logic in process_common_errors for unbalanced quotes 2014-03-19 13:49:31 -05:00
James Tanner
409044155d Fixes #6579 allow for vault passwords ending with newline chars 
Also add a unit test for vaulteditor to verify 1.0 passwords with newline chars.
 2014-03-19 14:38:11 -04:00
James Tanner
db3d2e1042 Fixes #6542 rewrite test string for osx compatibility 2014-03-18 09:03:55 -04:00
James Tanner
7c5ad1fa23 Fixes #6539 Workaround py26 vs py27 difflib results 2014-03-17 22:21:30 -04:00
Oleg Bulatov
f6a4c20cc0 Make parsing variables for hosts and groups more consistent 
This commit allows to specify arrays in [group:vars] block.

Signed-off-by: Oleg Bulatov <oleg@bulatov.me>
 2014-03-16 21:47:26 +04:00
Matt Martz
5062f4962f Unit tests for ansible.utils 2014-03-14 10:38:33 -05:00
James Cammarata
8df29e7c8b Cleaning up some exception blocks in TestModuleUtilsBasic 2014-03-13 16:24:29 -05:00
James Cammarata
69ff355726 Adding new unit tests for module_utils/basic (run_command only now) 2014-03-13 14:56:44 -05:00
James Tanner
b0d22b76bd Add an ast.parse unit test for modules to simulate ansible-doc 2014-03-13 12:01:55 -04:00
James Tanner
0d6f6ad282 Implement new default cipher class AES256 2014-03-10 16:15:44 -05:00
Richard Isaacson
119434d079 Merge pull request #6319 from risaacson/fix_test_dir_inventory 
Fix TestInventory Unit Tests

Tested clean.
 2014-03-06 15:43:45 -06:00
James Tanner
85bc14a8eb Remve debug file from vault unit test 2014-03-06 14:49:55 -05:00
Richard C Isaacson
913c855df4 Formatting cleanup. 
Post merging of GH-5837 via GH-5749.
 2014-03-06 13:08:35 -06:00
g-k-r
dbad5d71c6 modifed test to use get_hosts instead of get_groups 
closes #5749

Conflicts:
	test/units/TestInventory.py
 2014-03-06 13:06:08 -06:00
g-k-r
6626cb0b3d add test same host in different files in dir 
tests issue #5749
 same host defined in different groups which in turn are defined
 in different ini files in an inventory directory

Conflicts:
	test/units/TestInventory.py
 2014-03-06 13:03:25 -06:00
Richard C Isaacson
16fe09eef8 Fixes related to uncommenting test_dir_inventory in TestInventory. 
0. Uncomment the test.
1. Test fails.
2. Make vars unique per file in test inventory files.
3. Modify token addition to not ast.literal_eval(v) a variable containing a hash.
4. Modify vars to have an escape in test inventory file.
5. Catch exceptions explicitly. Any unknown exceptions should be a bug.
6. Test passes.
 2014-03-06 12:09:53 -06:00
Michael DeHaan
94a7fb60fe Allow escaped comments in inventory files. 2014-03-05 20:10:25 -05:00
Richard C Isaacson
b41d8106ff Revert "Merge pull request #6287 from risaacson/fix_hash_in_var" 
This reverts commit a808287451, reversing
changes made to 6129ea7566.
 2014-03-05 14:49:30 -06:00
Richard Isaacson
a808287451 Merge pull request #6287 from risaacson/fix_hash_in_var 
Fix inventory for test_dir_inventory, merge PRs from GH-5749, cleanup some formatting.
 2014-03-05 14:20:27 -06:00
James Tanner
6129ea7566 Fixes #6298 and adds a sudo unit test for synchronize 2014-03-05 14:51:40 -05:00
Richard C Isaacson
22a1fb28d6 Minor cleanup. 2014-03-05 13:44:15 -06:00
g-k-r
a3c36a6853 modifed test to use get_hosts instead of get_groups 
closes #5749

Conflicts:
	test/units/TestInventory.py
 2014-03-05 13:29:47 -06:00
g-k-r
23fee4b836 add test same host in different files in dir 
tests issue #5749
 same host defined in different groups which in turn are defined
 in different ini files in an inventory directory

Conflicts:
	test/units/TestInventory.py
 2014-03-05 13:27:39 -06:00
Richard C Isaacson
49bd8b0b35 Fix inventory for test_dir_inventory 
It came up that fixing this unit test may relate to another ticket that is open. This work allows us to uncomment this unit test by fixing how we pars variables allowing a quoted variable to contain a '#'.

Work also went into cleaning up some of the test data to clarify what was working.

Lastly work went into cleaning up formatting so that the code is easily read.
 2014-03-04 18:31:49 -06:00
Jesse Keating
0c2c37a47a Avoid range selection on empty groups 
This prevents a traceback when the group is empty.
Fixes #6258
 2014-03-03 13:23:27 -08:00
James Tanner
a37a6983be Switch from skipIf to SkipTest for TestVaulLib 2014-02-26 14:01:31 -05:00
James Tanner
f5359c310f Add negative tests for VaultLib 2014-02-26 13:38:58 -05:00
James Tanner
baed7a0ed9 Fixes #6187 Add unit tests for VaultLib 2014-02-26 12:10:09 -05:00
James Tanner
e121ff111d Fix synchronize unit test to handle checkmode 2014-02-25 09:24:14 -05:00
James Cammarata
f23ccebbdc Merge branch 'issue_4620' of https://github.com/jimi-c/ansible into jimi-c-issue_4620 2014-02-24 20:30:25 -06:00
Michael DeHaan
f0dd040377 reconnect unit tests to 'make tests' 2014-02-20 19:13:27 -05:00
Michael DeHaan
2177b773c8 Rename tests to test, use old directory name. 2014-02-20 19:11:15 -05:00