Commit graph

14 commits

Author SHA1 Message Date
Justin Ludwig
26374d89a0 Fix AWS credential params for s3 and other modules
The `ec2_ami`, `ec2_elb`, `ec2_tag`, `ec2_vpc`, `route53`, and `s3` modules
all canonicalize the AWS access and secret key params as
`aws_access_key` and `aws_secret_key`. However, following the fixes for #4540,
those modules now use `get_ec2_creds` from `lib/ansible/module_utils/ec2.py`,
which requires access/secret key params to be canonicalized as
`ec2_access_key` and `ec2_secret_key`. As a result, AWS credentials passed
to those six modules as parameters are ignored (they instead always use
the AWS credentials specified via environment variables, or nothing).

So this change fixes those six modules to canonicalize the
AWS access and secret key params as `ec2_access_key` and `ec2_secret_key`,
allowing them to again accept AWS credentials passed via module params.
2013-11-26 19:29:06 -08:00
Michael DeHaan
f7c3975f21 Add version_added to all modules missing version_added information, the docs formatter will now
raise errors when omitted, updated changelog with new modules.
2013-11-18 18:55:49 -05:00
James Tanner
afa5988391 Fixes #4540 Use shared module snippet to evaluate ec2 credentials 2013-11-01 11:59:24 -04:00
Yap Sok Ann
a8f95435c3 ec2_ami: Account for AWS's "eventual consistency" with AMI creation.
Calling `ec2.get_image` right after `ec2.create_image` may raise error
"InvalidAMIID.NotFound". This has happend roughly 1 time out of 10 for me.

Other people has bitten by this too:
- 5707f100a0
- http://stackoverflow.com/a/14794952
- https://bitbucket.org/utoolity/bamboo-aws-plugin/pull-request/22/baws-116-fix-ec2-image-task-failing-with/diff
2013-10-04 23:17:04 +08:00
James Cammarata
bb75050912 Merge branch 'rb2' of https://github.com/bpennypacker/ansible into bpennypacker-rb2
Conflicts:
	library/cloud/route53
2013-08-23 11:36:45 -05:00
Joshua Lund
654b37f212 Fixing typo in EC2 modules 2013-08-21 18:13:05 -06:00
Bruce Pennypacker
0f458210bc Rebase attempt
No idea if I'm rebasing properly or not.  This is my first attempt.
2013-08-20 15:14:16 -04:00
Michael DeHaan
10f99938b9 Fix YAML doc errors. 2013-07-21 11:15:06 -04:00
Evan Duffield
7932ccef46 added note about AMI security 2013-07-08 10:24:22 -07:00
Evan Duffield
e33f5ae56e Merge branch 'devel' of https://github.com/evan82/ansible into devel 2013-07-08 09:26:04 -07:00
Evan Duffield
45bdda24db added region to spec 2013-07-08 09:24:18 -07:00
Evan
de211aa8ec Getting timeout errors this morning as AMIs are taking a bit longer to create, so I changed to timeout to 15 minutes 2013-07-03 11:10:39 -07:00
Evan
637a6c562e fixed spelling errors, unused variables and unused import 2013-07-03 10:35:32 -07:00
Evan Duffield
c8f8f14e59 Added module for baking EC2 AMIs 2013-07-02 11:24:40 -07:00