cmueller/ansible
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity
5293 commits 47 branches 390 tags 440 MiB
Commit graph

596 commits

Author SHA1 Message Date
trbs
1f673450cd Fix for #3062 additional groups should only be added once. 
Also consolidated duplicate groups code into one get_groups_set() method.
Removed unused call to user_group_membership.
Removed sorting operations on set functions cause sets are inherently unordered.
Minor style improvements to match the rest of the code.

The new function will make the order of group names passed to the system command less determistic.
Which was already the case for modify_user_usermod() but not for other methods.
It will also strip out duplicate group names automatically which was not always the case previously.
 2013-05-30 19:18:18 -04:00
Lorin Hochstein
ec2fc7c983 authorized_key: Set manage_dir default value 
This commit fixes a bug where the authorized_key module causes
the ~user/.ssh directory to be owned by root instead of the user,
when the manage_dir argument is not specified.

If the manage_dir argument was not specified, the module behaved as if
manage_dir was set to false, even though it's supposed to default to
true.

This module assumed that an optional argument, with no default
specified, will not be present in the module.params dictionary.

What actually seems to happen is that the argument does appear in
the module.params dictionary with a value of None.

The upside is that this line was evaluating to None instead of
true:

    manage_dir = params.get("manage_dir", True)

I fixed the problem in this particular module by explicitly specifying
the default value for the manage_dir arugment. But if this bug
occurred because of a change in behavior in AnsibleModule, then other
modules may be broken as well.
 2013-05-30 16:16:14 -04:00
Michael DeHaan
94c35df69c Merge pull request #3064 from sfromm/issue2990 
Verify /proc/modules is readable (issue #2990)
 2013-05-30 11:12:30 -07:00
Stephen Fromm
c23ce83375 Verify /proc/modules is readable (issue #2990) 2013-05-30 10:25:48 -07:00
Stephen Fromm
44025024e9 Use get_bin_path to find mkfs command (issue #2983) 2013-05-30 10:25:35 -07:00
Chris Gardner
972545407c Fix typo. Solaris 9 should now correctly ignore 'brand' and use 'implementation'. 2013-05-30 08:51:03 +01:00
Chris Gardner
3cf243ec3e TODO: Separate IPv4 and IPv6 2013-05-30 08:39:11 +01:00
Jiří Kubíček
626cbc4e8b Add some FreeBSD facts 
added:
 * ansible_distribution
 * ansible_distribution_release 
 * ansible_distribution_version
 * ansible_os_family
 * ansible_pkg_mgr
 * ansible_ssh_host_key_ecdsa_public

Also adds ECDSA public key for all plaforms.
 2013-05-30 01:34:33 +02:00
Chris Gardner
d5bb7188f0 Add Solaris network facts. IPv6 details overwrite IPv4 per interface, needs further work. 2013-05-30 00:06:57 +01:00
Chris Gardner
f05540cb48 Add clock speed to processor description for SPARC CPU. 2013-05-29 21:00:21 +01:00
Chris Gardner
35ee8a16de Use 'implementation' if 'brand' not available (Solaris 9). Add CPU socket/core counting. 2013-05-29 18:54:43 +01:00
Michael DeHaan
da348cf079 Merge branch 'facter-fix' of git://github.com/flyapen/ansible into devel 2013-05-29 10:00:20 -04:00
Guillaume Lasmayous
fe484e5fd7 Implement NetBSD-specific subclass of Hardware in the setup module. 
Defines memory and CPU facts:
- memfree_mb
- memtotal_mb
- swapfree_mb
- swaptotal_mb
- processor (a list)
- processor_cores
- processor_count
- devices

As a matter of fact, on NetBSD, it is possible to get memory, swap and
processor facts exactly as on Linux. Tested on NetBSD-5, NetBSD-6 and
NetBSD-6.1 (without Linux emulation).
 2013-05-29 09:37:46 -04:00
Chris Gardner
7d61180034 Use kstat for Solaris CPU info 2013-05-28 22:44:06 +01:00
Chris Gardner
50c3cf302c Use kstat for Solaris CPU info 2013-05-28 22:36:49 +01:00
Kristof Keppens
f607ba09a4 change fix to lookup path with get_bin_path 2013-05-27 07:38:17 +02:00
Michael DeHaan
b0f62209c6 Merge pull request #2992 from SirScott/service_pattern 
Fixes #2991: Service module pattern argument ignored.
 2013-05-24 19:58:42 -07:00
Scott Sturdivant
ffb50dfb34 Fixes #2924: User creation always reports 'changed' 2013-05-23 13:43:23 -06:00
Scott Sturdivant
0110b616cb Fixes #2991: Service module pattern argument ignored. 2013-05-23 09:39:26 -06:00
Kristof Keppens
dc20d63919 fix for facter being installed in a different location 2013-05-23 11:21:01 +02:00
Elan Ruusamäe
52643e2a4d no need to init None to None 2013-05-19 00:20:10 +03:00
Michael DeHaan
3ad9866124 Merge pull request #2941 from bcoca/setup_bin 
no uses get_bin_path for 2nd use of ip tool
 2013-05-18 13:22:24 -07:00
Michael DeHaan
fc36695e7a Merge pull request #2940 from madema/patch-3 
-o and -r option don't exist on AIX
 2013-05-18 13:21:48 -07:00
Ton Kersten
438ab750c3 Fix issue 2906 2013-05-18 15:57:10 -04:00
Brian Coca
af745d0f9a no uses get_bin_path for 2nd use of ip tool (fixes reported issue with openwrt) 
module needs this added to many tool invokations, but his is a start
Signed-off-by: Brian Coca <briancoca+dev@gmail.com>
 2013-05-16 08:32:49 -04:00
madema
973eb69911 -o and -r option don't exist on AIX 2013-05-16 14:30:42 +02:00
Michael DeHaan
911213f8d7 Style fix. 2013-05-11 17:21:49 -04:00
Michael DeHaan
4ef987736a Merge pull request #2866 from madema/patch-2 
Fixed an error in the get_cpu_facts of the AIX class
 2013-05-11 11:10:17 -07:00
Michael DeHaan
05fb9876d3 Merge pull request #2865 from madema/patch-1 
Added AIX class in the service module to control AIX SRC processes.
 2013-05-11 11:09:41 -07:00
Michael DeHaan
a7521a9826 Merge pull request #2863 from lonerr/freebsd-group 
FreeBSD group operations is now supported properly.
 2013-05-11 11:08:13 -07:00
Michael DeHaan
da6cb522ed Merge pull request #2862 from lonerr/freebsd-user 
Fixed errors in FreeBSD user manipulations.
 2013-05-11 11:07:32 -07:00
Michael DeHaan
a9f5f86edb Change filesystem module message. 2013-05-11 14:03:40 -04:00
Michael DeHaan
9ca9b4cb29 Merge pull request #2853 from abulimov/module_mkfs 
Module filesystem
 2013-05-11 11:02:43 -07:00
Elan Ruusamäe
258cf60924 LinuxService: avoid enforcing systemd even if init.d script was found 2013-05-11 13:24:00 +03:00
madema
57fb97470c Update service 2013-05-10 18:16:23 +03:00
madema
54abf22c35 Fixed an error in the get_cpu_facts of the AIX class 
assumed proc0 as the first processor but can be different in a LPAR environment
 2013-05-08 16:13:13 +03:00
madema
88a4a56889 Added AIX class in the service module to control AIX SRC processes. 2013-05-08 16:10:22 +03:00
lonerr
384798145a FreeBSD group operations is now supported properly. 2013-05-08 13:36:55 +04:00
lonerr
2a8ef8a87c Fixed errors in FreeBSD user manipulations. 2013-05-08 13:03:18 +04:00
Oleg
6735ec6e9d fix for authorized_key: skip chown and chmod if authorized_key_file is link 2013-05-08 01:47:41 +02:00
Alexander Bulimov
6a644714a7 renamed mkfs and moved to system/filesystem 2013-05-06 18:08:38 +04:00
Luciano Cavalheiro da Silva
96d4225245 Fix #2836. Ensure proper handling of option "system=yes" in module "group". 2013-05-04 21:24:02 -03:00
rektide
351bcf24cf Duplicate pull #2803 in ipv6, fixing setup module's handling of venet & unknown interface types. 2013-05-02 17:19:22 -04:00
Michael DeHaan
b0794ff5f6 Test for the existance of a file that might not be present on older RHEL. 2013-04-30 09:26:25 -04:00
James Mills
ced36f3e81 Fixed setup module to accomodate venet interfaces (OpenVZ) 2013-04-29 10:08:24 +10:00
Michael DeHaan
cd97a4cb14 Allow modules to be categorized, and also sort them when generating the documentation. 2013-04-28 15:03:45 -04:00