Commit graph

45749 commits

Author SHA1 Message Date
Richlv
1d50d308fc Minor typo/language fixes in the documentation (#58856)
Minor typo/language fixes in the zabbix_map documentation
2019-07-09 18:15:28 +05:30
Miguel Angel Muñoz González
d50531c6bd New Fortinet's module for fortios_user_device (using new httpapi plugin) (#58291)
* New Fortinet's module for fortios_user_device (using new httpapi plugin

* Fix documentation errors

* Update lib/ansible/modules/network/fortios/fortios_user_device.py

Co-Authored-By: Sandra McCann <samccann@redhat.com>

* Update lib/ansible/modules/network/fortios/fortios_user_device.py

Co-Authored-By: Sandra McCann <samccann@redhat.com>

* Update lib/ansible/modules/network/fortios/fortios_user_device.py

Co-Authored-By: Sandra McCann <samccann@redhat.com>

* Update lib/ansible/modules/network/fortios/fortios_user_device.py

Co-Authored-By: Sandra McCann <samccann@redhat.com>

* Update lib/ansible/modules/network/fortios/fortios_user_device.py

Co-Authored-By: Sandra McCann <samccann@redhat.com>

* Update lib/ansible/modules/network/fortios/fortios_user_device.py

Co-Authored-By: Sandra McCann <samccann@redhat.com>
2019-07-09 15:53:36 +05:30
Gonéri Le Bouder
140a8e53f3 vmware_guest: do not use infra.vm_list
Update the functional tests of `vmware_guest` to use the
`virtual_machines` data structure.
2019-07-09 11:55:12 +02:00
Sam Doran
1c2c1c15d0 dnf - fix error formatting of module name in error message (#58647) 2019-07-09 10:16:42 +02:00
pratikgadiya12
1f427249d5 Fixed examples module name in udm_dns_record (#58814)
Fixes: 58813
2019-07-09 12:52:02 +05:30
Andrey Klychkov
88ec5e14cb Add unit tests for lenient_lowercase function (#58586) 2019-07-08 18:33:15 -04:00
Will Thames
446919de6f Add apply to k8s module (#49053)
* Add apply to k8s module

Use apply method for updating k8s resources.

* Improve apply documentation

* k8s: Make apply and merge_type mutually exclusive
2019-07-08 13:47:41 -07:00
Dusan Matejka
105f60cf48 unified required zabbix-api dependency version and removed no longer needed extend of ZabbixAPI class (#53334) 2019-07-08 15:46:25 -04:00
Shachaf92
7ddcaafee5 many pslint fixes (#55862)
* Handles:

PSAvoidTrailingWhitespace
PSAvoidGlobalVars
PSAvoidAssignmentToAutomaticVariable
PSAvoidUsingCmdletAliases
PSAvoidUsingWriteHost
PSUseDeclaredVarsMoreThanAssignments
PSUsePSCredentialType
PSAvoidUsingPositionalParameters
PSAvoidUsingEmptyCatchBlock
PSAvoidUsingWMICmdlet

Replaced Write-Host with Write-Output
Added smart reboot check for win_domain feature installation
Modify the Creation of the pagefileto fit to CIM
Changelog fragment addition
Ignore.txt without fixes

* Changes after community reviews

* Change Out-Null to '> $null'

* Fixes after jborean93 comments

* Test

* Revert "Test"

This reverts commit 35c5c0648fa9d2868a18094d84954e53ffa28880.

* Removed all  > $null since they broke the module since the output got dumped

* run test again

* Revert "run test again"

This reverts commit 80eaf07143f9d8cb0116cbbc68a6a69c0ace840c.

* Changes after community review

* ignore PSUseDeclaredVarsMoreThanAssignments that are on a diffrent PR

* CI failed on extra line in ignore.txt

* Review changes

* PSlint errors

* Trail space

* send to null breaks the tests for  Set-Workgroup

* Lint stuff

* win_domain_user issue of indent.

* Update win_domain_user.ps1

* Update win_domain_membership.ps1

* Fix redirect to null

* lint space issue

* removed return from set-workgroup

* removed send to null
2019-07-09 05:41:58 +10:00
Max Calzavara
5689cc08ce Add examples (#58819)
* Add examples to the ios_vlan docs: vlan using aggregate and move vlan interface example
2019-07-08 14:10:10 -05:00
Nicolas Boutet
6a5bc5f206 Fix wrong unit in documentation example of ec2_metric_alarm (#58622) 2019-07-08 14:07:28 -05:00
Will Thames
88364d4cfd Add purge_tags to s3_bucket to allow preservation of existing tags (#58754)
* Add purge_tags to s3_bucket to allow preservation of existing tags

Adding `purge_tags` with default `True` to maintain existing behaviour
allows users to set it to `False` to preserve existing tags

Fixes #29366

* s3_bucket: Add further tests and improve tag handling further

Additional tests for purge_tags: False suggested some incorrect
logic and thus further improvements

Increase wait timeout on bucket deletion as it wasn't always completing
in the default 100 seconds
2019-07-08 10:19:01 -07:00
François Deppierraz
737da1853e os_user_role: add support for named domain (#49891)
Fixes #49859.
2019-07-08 09:26:15 -04:00
Abhijeet Kasurde
79fdc2190a role: Fix role's hash_params (#55263)
* role: Fix role's hash_params

Fix based upon work done by alikins.

Fixes: #20596

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>

* review comments

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-07-08 09:25:59 -04:00
AndyG
894d19b108 Update ec2_snapshot.py (#58753)
ansible ec2_snapshot ValueError: time data '2019-05-27T12:08:49.929Z' does not match format '%Y-%m-%dT%H:%M:%S.000Z'
2019-07-08 19:20:47 +10:00
Lindsay Hill
5b2d1cc24d Fix broken slxos_config due to changed backup options (#58804) 2019-07-08 09:28:53 +05:30
Lindsay Hill
2eb499cbb3 Minor typo in sros_config docstrings (#58803)
Changed `f` to `If`
2019-07-08 07:58:12 +05:30
Diane Wang
9c140d26d5 VMware: add new module vmware_guest_network (#52075) 2019-07-08 07:54:54 +05:30
Shachaf92
5b953581b4 win_domain_user - MAke the query user try catch block more accurate (#58782)
* win_domain_user - MAke the query user try catch block more accurate for missing identity

* change to minor_changes

* Update win_domain_user-make-query-try-catch-accurate.yml

* Update win_domain_user-make-query-try-catch-accurate.yml
2019-07-08 07:13:48 +10:00
Dominik Holler
6e4c2c61bd Remove redundant line in os_port (#57838)
* Remove redundant line in os_port

The renaming of the key 'vnic_type' to 'binding:vnic_type'
is reduced to a single line.
The old key is removed to avoid to possibility of
inconsistency.

* Add missing parameter in example of os_port

In the example "Create port of type 'direct'" the parameter
"network" is added, because this parameter is required on
creating new ports.
2019-07-07 05:00:09 -04:00
Josh VanDeraa
73db7e2901 Changed command for next-hop-self to next-hop-self instead of activate (#58789) 2019-07-07 02:09:10 +05:30
Klaas Demter
faf50dbace Fix nagios module to recognize if file exists and is fifo pipe (#58569)
add felixfontein suggestion to changelogs/fragments/58569-nagios-fifo-fix.yaml

Co-Authored-By: Felix Fontein <felix@fontein.de>
2019-07-06 22:37:23 +02:00
smile37773
8ff97edd1a Add the singlePlacementGroup in the virtual machine scale set module (#58320) 2019-07-06 06:14:14 +08:00
Toshio Kuratomi
0c992d5ae4 Fix for skipping of gitlab_runner test.
Correct variable name for skipping of the gitlab test when gitlab python
client is not installed.
2019-07-05 11:47:19 -07:00
Toshio Kuratomi
fed90efc4d Fix unicode error in changelog generation 2019-07-05 11:15:17 -07:00
Joseph
4f642daae5 Correct machinectl become plugin function arguments (#58734)
* Correct get_option function name and change flags to become_flags

* Remove the '--' from the returned command

* add changelog fragment

* change changelog fragment description

* move the -q argument to machinectl before the shell argument to resolve issues with machinectl v230 (see #56571)
2019-07-05 11:03:24 -04:00
Dag Wieers
61647731e2
Fix regression in cron module (#58751)
This reverts the changes to cron from #28662

This fixes #58493
2019-07-05 15:02:29 +02:00
Nilashish Chakraborty
709fbcf804
Fix fetching existing AS (#58756)
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
2019-07-05 18:03:08 +05:30
Nilashish Chakraborty
83f92987b8
Change default behaviour for network resource facts (#58750)
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
2019-07-05 17:30:35 +05:30
Abhijeet Kasurde
5e2471485a
VMware: Warn user about dvswitch permissions (#58579)
Warn user about dvswitch permissions since permissions for
a distributed switch must be defined and managed on either
the datacenter or a folder containing the switch.

Fixes: #55248

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-07-05 17:11:25 +05:30
Sunil Raj
641f7c4ae3 VMware: Updates the DRS rule without deletion (#57119)
* The DRS rule will be updated if any changes in the configuration without deleting the existing rule.
The rule itself is updated by the given configuration.
* Lint errors fixed
* VMware: update vmware_vm_vm_drs_rule testcases
2019-07-05 17:00:05 +05:30
Mariusz Mazur
2fb06650a7 kubevirt: even more unit tests (#58593) 2019-07-05 20:35:32 +10:00
Ganesh Nalawade
ff4001f470
Update junos module utils (#58730)
*  Add utils fucntion to build xml
   subtree
2019-07-05 12:21:38 +05:30
Abhijeet Kasurde
1bd91279d0
Fixed fail_json call in command module (#58615)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-07-05 11:00:10 +05:30
Trishna Guha
5c5d9ad669
Refactor nxos_facts to support resource module (#58705)
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2019-07-05 09:26:33 +05:30
Shachaf92
a6b7d0d00b win_domain_user and win_domain_group: add created result boolean (#57901)
* win_domain_user and win_domain_group: add created result boolean

* Fix YML

* add docs

* brackets

* Update win_domain_group.py

* Update win_domain_user.py

* Update win_domain_user.ps1

* fix indent
2019-07-05 08:44:07 +10:00
Shachaf92
07edcab051 win_acl: Fix problems with special IDRef in different languages than english (#57281)
* Change special id ref recognitionto avoid language diff

* Changelog added

* specialIdRefPrefixes to array

* Changed to the more generic option
2019-07-05 08:08:23 +10:00
Shachaf92
e0b8bc1ef9 win_firewall_rule: Only report changed when change is made (#57267)
* Fix bug https://github.com/ansible/ansible/issues/44450

* Added tests

* I will make this CI work

* Update win_firewall_rule.ps1
2019-07-05 08:06:34 +10:00
Shachaf92
6e319ff088 win_psmodule - Missing SkipPublisherCheck in Prerq installations (#58090)
* win_psmodule - Missing SkipPublisherCheck in Prerq installations

* Handle different minors of PS5

* community revisions

* Update win_psmodule.ps1
2019-07-05 08:00:58 +10:00
PRASOON KARUNAN V
db5656cf6e Add support for pester tags (#57918)
* correct argument name

* added documentation

* adding missing version_added to doc

* correcting description in docs

* change type to list

* add tests

* correct test file
2019-07-05 07:45:52 +10:00
Shachaf92
48a518d9a3 win_get_url - Fix proxy_url not used correctly (#58738) 2019-07-05 07:42:05 +10:00
Will Thames
60fb9fc208 Fix EC2 test suite to work with testing policies (#44387)
* Update testing policies to ensure all required permissions are present
* Tidy up security policies to reduce duplicate permissions
* Make roles static so that they can be present before CI is run,
  meaning that role creation permission is not required by the CI
  itself, only by someone setting up the roles prior to testing
* Move contents to cloudfront policy to network policy to ensure policy
  count (maximum of 10) stays low
* Maintain compute policy below 6144 bytes
2019-07-04 15:25:19 -04:00
Andrey Klychkov
6cf722fed6 postgresql_query module: add autocommit parameter (#58704)
* postgresql_query: add autocommit parameter

* postgresql_query: add autocommit parameter, add CI tests

* postgresql_query: add autocommit parameter, add a changelog fragment

* postgresql_query: add autocommit parameter, fix sanity

* postgresql_query: add autocommit parameter, cosmetic fix
2019-07-04 12:25:51 +02:00
Trishna Guha
7b20535063
Fix repetitive ansible_net key in gather_subset (#58702)
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2019-07-04 13:05:13 +05:30
Sumit Jaiswal
8b844b67b5
fix 57711 (#58618)
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
2019-07-04 10:45:10 +05:30
Pierre Riteau
1eb3fba51f Fix os_quota when volume service not available (#57364)
os_quota checks the current quotas for compute, network and volume
services and fails when no volume service is found in the catalog.

Since openstack test deployments without volume services are common,
os_quota shouldn't fail if such service is missing.

This was originally fixed in d31a09ceb7
and later adapted to catch exceptions raised by shade. Since then, this
module moved to using openstacksdk, which doesn't catch the exception
raised by keystoneauth1.

Fixes #41240
2019-07-04 00:48:28 -04:00
Avishay Bar
89be328a29 - Fixed error handling on aws_kms (#58690)
While alias creation failes, this PR fixes the requirement of passing 2 arguments for the `fail_json_aws` method.
2019-07-04 09:35:56 +10:00
Brian Coca
9808ffecc7
Add JSON output option to ansible-doc (#58209)
* allow json from ansible-doc

* save the var

* try to yaml load

* let examples stay as text blob
2019-07-03 17:52:20 -04:00
Manuel Mendez
b4f4cb9b87 Fix 32910 part2 (#38709)
* cloud/packet: remove bogus mutual exclusions

operating_system is a required parameter, for custom ipxe it should be
set to custom_ipxe. The always_pxe and ipxe_script_url parameters are
only valid when operating_system==custom_ipxe, but they are not mutually
exclusive.

* cloud/packet: disallow custom_ipxe settings for supported oses.
2019-07-03 17:35:32 -04:00
Sandra McCann
3bfe32b9d9 fixed formatting and spelling issues (#58686) 2019-07-03 13:53:58 -05:00