Commit graph

24280 commits

Author SHA1 Message Date
Olivier BLIN
c51407c806 Fix nxos modules idempotence issue (#46437)
* nxos_interface vlan and port-channel idempotence fix for mtu

* Fix MTU reconfiguration at each execution

* nxos_interface port-channel idempotence fix for mode (#44248)

* Fix trunk mode idempotence for port-channel
* Gather ethernet and port-channel code for mode management

* nxos_linkagg port-channel idempotence fix for channel-group's mode

The regex to retrieve channel-group's mode is not enough accurate.
Therefore, the swhitchport mode  was matched instead of the
channel-group's mode.

* This fix add accuracy to match the right configuration command

* Add support for switchport mode dot1q-tunnel in nxos_interface

* Fix layer reconfiguration at each execution
2018-11-29 10:23:51 +05:30
Mike Wiebe
af1e6878e9 Fix n3k power supply facts (#49150) 2018-11-29 09:29:21 +05:30
Yunge Zhu
ecd995496c new module: azure_rm_rediscache (#47914)
* add new redis cache module

* fix version

* fix lint
2018-11-28 15:59:55 -08:00
Sandra McCann
13a6b4a856 Gather subset fix (#49264)
*  reword subset description for ios_facts
2018-11-28 15:33:16 -06:00
vmpr
46a3c0cf2e changed documented default value for url (#49097)
the Default Value for url is 3000, so there was a mistake in the documentation
2018-11-28 15:16:36 -06:00
Chris Archibald
6dc6538eef Bug fixes for na_ontap_fcp (#48583) 2018-11-28 20:03:44 +00:00
Selivanov Pavel
0b380b09bf ec2_instance_facts.py: documentation: add example (#49010)
Add an example of using multiple states for instance-state-name in filters. Not obvious how it works until you try.
2018-11-28 19:42:38 +00:00
Pierre Allix
965dec6a9a Clarify volume unit in the ec2_vol module (#49242)
"GiB" is more appropriate than "GB" since the volume size in AWS is
expressed in gibibytes.
2018-11-28 13:32:39 -06:00
Adam Miller
81540bd754 require git when trying to use it in ansible-galaxy cli (#49212)
* require git when trying to use it in ansible-galaxy cli

Previously we weren't setting `required=True` when calling
`get_bin_path` and the path would return `None`, this would cause
a traceback when attempting to ' '.join() to create a string
representation of the failed command for error output

Fixes #49200

Signed-off-by: Adam Miller <admiller@redhat.com>

* add changelog

Signed-off-by: Adam Miller <admiller@redhat.com>
2018-11-28 13:28:21 -05:00
Anil Kumar Muraleedharan
7a81d859c5 Refactoring cnos_vlan in line with ios, eos etc. (#48924)
* Refactoring cnos_vlan in line with ios, eos etc.
2018-11-28 12:51:39 -05:00
Michael Brennan
ca918def18 fixed parsing issue with openstacksdk and idempotent checking issues (#44928)
* fixed parsing issue with openstacksdk and idempotent checking issues

* fixed whitespace found in pylint
2018-11-28 12:13:50 -05:00
Abhijeet Kasurde
bc3e7bbeba
E325 Removal - Part II (#49196)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-11-28 13:55:52 +05:30
Sumit Jaiswal
991a9dfa12
PR to support commit check to confirm commits with JunOS (#49054)
* commit check support

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* fixed review comments

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* fixed review comments

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* fixed shippable

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
2018-11-28 11:27:46 +05:30
Matt Clay
8987a647e3 Remove commented out author to attempt bot fix. 2018-11-27 21:52:05 -08:00
Matt Clay
aaf1e459e7 Fix author in azure_rm_virtualnetworkpeering. 2018-11-27 21:43:05 -08:00
Abhijeet Kasurde
7ac47bd600
Fix author GitHub id (#49228)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-11-28 11:03:28 +05:30
Mike Wiebe
374ca783bb nxos_logging message fix (#49205)
* nxos_logging message fix

* Remove rescue in block
2018-11-28 10:37:04 +05:30
Yunge Zhu
dc871bd493
add module azure_rm_virtualnetworkpeering (#47045) 2018-11-28 11:37:00 +08:00
Jordan Borean
098b18e846
win basic - fix issue when serializing PSObjects in result (#48860) 2018-11-28 12:17:49 +10:00
Yunge Zhu
e0af9b2ce0 new module cdnendpoint (#46796)
* new module cdnendpoint
2018-11-28 09:57:04 +08:00
jokurz
6404c6484c Fix fact ansible_distribution_version for AIX (#48570)
* Fix fact ansible_distribution_version for AIX

* aix_facts: Check oslevel output
2018-11-27 19:43:07 -05:00
Brian Coca
ae2467ddbc Merge pull request #49080 from bcoca/better_invp_skip
more precise pluing skip msg and now in higher verbosity level
2018-11-27 15:30:14 -08:00
tomasg2012
07895538b5 Changes to redfish-based parameters (#48717)
* Changes to redfish-based parameters

Corrected (potentially) small scope variable to 'id'

Review to see if this is problematic

* Updated doc information with "version_added"

* Corrected 'username' in redfish_config file
2018-11-27 18:16:24 -05:00
Vinay Dandekar
ff9b86f560 Revert back to getting the AWS role name from the URI with a small change (#49113)
- The role name and instance profile name _can_ be different
- Change the delimiter to `:` for keys that are discovered through the JSON parsing (which is not a valid delimiter for AWS IAM role names), this delimiter is still converted to underscore
- Now checks for the existence of that delimiter to remove the cases where the JSON keys are appended to the role name to find the role name
2018-11-27 17:52:24 -05:00
Adilio
3cbb66dd53 Updated example in include_role.py
<!--- Updated example text from with_items to loop -->

+label: docsite_pr
2018-11-27 14:12:45 -08:00
Sam Doran
5eb7f5781e
Reboot - Fix errors when using Paramiko connection (#49002)
Different connection plugins return different data when throwing exceptions. The Paramiko connection plugin does not return a text sting, which caused an exception.

The ssh connection plugin returns multi-line errors, which makes the debug logs harder to read. Only return the last line in that case in order to make the logs more readable.

When experiencing a connection failure, reset the connection.

Add reset() to paramiko_ssh

Indicate thet conection state is False when running close(). This is needed by the ensure_connected() decorator to work properly.


Co-authored-by: Matt Martz <matt@sivel.net>
2018-11-27 16:48:57 -05:00
Martin Krizek
d4568d97d4 Fix using vault encrypted data with jinja2_native (#49025)
Fixes #48950
2018-11-27 16:44:22 -05:00
Lars Kellogg-Stedman
bafc1f8a41 fix constructed functionality in openstack inventory plugin (#48833)
* test for openstack inventory constructed functionality

this adds unit tests for the compose, groups, and keyed_var features
of the openstack inventory plugin

* fix constructed functionality in openstack inventory plugin

The compose, groups, and keyed_groups functionality of the openstack
inventory plugin was broken:

- the plugin was not passing the correct variables to the
  Constructable methods for compose and groups
- the plugin was simply never calling the appropriate method for
  implementing keyed_groups

This commit fixes both issues.
2018-11-27 13:01:56 -05:00
Martin Krizek
abdf46803b
Warn about falling back to jinja2_native=false (#49063) 2018-11-27 18:11:42 +01:00
Bob Vincent
67a70a1205 Improve docs for umask option of pip module. (#49146)
* Improve docs for umask option of pip module; umask should be specified as an octal *string*, not an octal (or decimal) *integer*.
2018-11-27 10:38:53 -06:00
Abhijeet Kasurde
9b732df436
E325 removal - Part I (#49136)
Remove E325 from Amazon modules

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-11-27 20:41:01 +05:30
tchernomax
d14dee9ceb pacman: if 'upgrade' is used, 'name' isn't apply (#48854)
fix #31713
2018-11-27 14:36:25 +00:00
AlexZolotarenko
91b7bee3da -'templateLinkage' set to match Zabbix web interface defaults (#45229) 2018-11-27 09:17:05 -05:00
seag-rvc
3acc71225a Update tower_host.py (#49186)
<!--- Your description here -->
Current example does not show how to declare variables
+label: docsite_pr
2018-11-27 13:10:18 +00:00
Tim Rupp
0b5b5e69d8
Adds hasattr checks for rpc calls used in network_cli plugins (#49173)
Network platforms that don't have cliconf plugin will fail when
sending rpc calls for the reset_history and disable_response_logging
functions because those are defined in cliconf exclusively at this
time.

This patch adds checks for those attributes before making the call
2018-11-26 20:59:03 -08:00
Trishna Guha
8796085569
nxos_facts fix NameError (#48981)
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-11-27 10:14:13 +05:30
Jonathan Hanson
12a573a7db Fix type in ansible-galaxy info output (#49096)
Changed from 'intalled_version' to 'installed_version'
2018-11-27 09:45:20 +05:30
Matt Davis
8c1f701e6e
split PS wrapper and payload (CVE-2018-16859) (#49142)
* prevent scriptblock logging from logging payload contents
* added tests to verify no payload contents in PS Operational event log
* fix script action to send split-aware wrapper
* fix CLIXML error parser (return to -EncodedCommand exposed problems with it)
2018-11-26 15:28:21 -08:00
ivovangeel
e7104a445b Fix incorrect 'installed' status setting in dnf.py (#48931) 2018-11-26 18:08:36 -05:00
Brian Coca
89b7e10436 updated var docs (#48957)
* updates var docs, fixes #48949

Co-Authored-By: bcoca <bcoca@users.noreply.github.com>
2018-11-26 16:08:39 -06:00
Bernardo Vieira da Silva
26a677c2a9 Update git example (#49098)
* Update git example

* set correct url format for ssh
2018-11-26 15:35:08 -05:00
Alicia Cozine
e42fb44995 adds hint about simplestreams protocol (#48959) 2018-11-26 14:45:48 -05:00
ikanobori
7740778d85 correct message to have consistent pluralisation (#36897) 2018-11-26 13:45:38 -05:00
Gregor Riepl
02893520a9 Cloudstack: Add password reset module (#47931) 2018-11-26 18:20:52 +01:00
Martin Krizek
48ffd8789f
Properly handle FieldAttribute.default if callable (#48992)
* Properly handle FieldAttribute.default if callable

Fixes #48673

* Add changelog...

* Add integration test

* Add aliases file
2018-11-26 18:14:46 +01:00
Zhikang Zhang
93c5781f61 pip: Fix the mistake replacement from 'distribute' to 'setuptools' (#47403)
* Fix the mistake replace from distribute to setuptools

* Add a testcase for this bug
2018-11-26 17:12:36 +01:00
Felix Fontein
3a9eadb22f Updating argument_spec for type='list' options by elements value. (#48485) 2018-11-26 10:17:25 -05:00
Christian Kotte
1ed9e72dc3 Improve vmware_portgroup_facts module (#47357) 2018-11-26 09:27:49 -05:00
Felix Fontein
be55abafe1 Mention docker[tls]. (#49095) 2018-11-26 14:11:24 +00:00
Felix Fontein
9caaf7b109 docker_container: fix init option idempotency with old docker-py versions (#49078)
* Don't check options for idempotency which are not supported.

This check should be superfluous if every option would adhere to
the convention that options not specified should have value None.
Unfortunately, some options (such as init) which correspond to
container properties have an explicit default set.
2018-11-26 13:53:01 +00:00