cmueller/ansible
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity
3073 commits 47 branches 390 tags 440 MiB
Commit graph

766 commits

Author SHA1 Message Date
Michael DeHaan
69612ba16d The very first start of 'fireball mode', which uses ansible in SSH mode to deploy a ephemeral zeromq daemon (entirely optional) that is will die after 
it is no longer used.  No key signing will be required.  At this point, development use only -- NOT complete.
 2012-09-26 23:51:59 -04:00
Jan-Piet Mens
c2daa77089 New module: manipulate INI-style settings 
split off examples from DOCUMENTATION into own array as per #1098
 2012-09-26 13:44:19 +02:00
Michael DeHaan
af8f11e3f7 Merge pull request #1096 from sfromm/issue1067 
Ignore failure of stop command if start succeeds with state=restarted
 2012-09-26 04:02:02 -07:00
Stephen Fromm
19c0202aaf Ignore failure of stop command if start succeeds with state=restarted 
In some cases (see issue #1067) with state=restarted, a failure to stop
the service (which wasn't running) would appear to the module to be a
failure to restart the service even though it successfully started the
service.  This changes the behavior of the service module to focus
on the return code of the start command.  If the rc of stop is not
0 and the rc of start does equal 0, it considers the service
successfully restarted.  It then ignores the rc, stdout, and stderr
from the unsuccessful stop command.
 2012-09-25 22:51:13 -07:00
Stephen Fromm
f52624f6d2 Give nice error message if destination directory doesn't exist (issue #1048) 2012-09-25 14:57:32 -07:00
Michael DeHaan
2f97afb634 Merge pull request #1071 from dhozac/git-expanduser 
User-expand the destination path of the git module
 2012-09-23 10:21:04 -07:00
Michael DeHaan
0b3e05d9a4 Merge pull request #1066 from jpmens/doc3_lineinfile 
Added DOCUMENTATION to lineinfile module
 2012-09-23 10:20:08 -07:00
Michael DeHaan
4e6d89b5b5 Merge pull request #1073 from dcoutu/devel 
Added cases for 'dead but subsys locked' status
 2012-09-23 10:19:19 -07:00
Dave Coutu
9bb83067bc Added cases for 'dead but subsys locked' status 2012-09-21 14:55:59 -04:00
Daniel Hokka Zakrisson
f6af88fe9f User-expand the destination path of the git module 2012-09-21 19:20:05 +02:00
Jan-Piet Mens
5a75433ce9 Added DOCUMENTATION to lineinfile module 2012-09-19 22:29:11 +02:00
Jan-Piet Mens
60e0410298 Tweak DOCUMENTATION YAML as per latest 991 2012-09-19 16:09:26 +02:00
Michael DeHaan
1bd9ea6440 Merge pull request #1062 from dagwieers/wait_for-fix 
Fix on older python versions, plus various improvements
 2012-09-19 06:36:56 -07:00
Dag Wieers
8912258016 Fix on older python versions, plus various improvements 
This change includes:

 - (on possibly older python versions ?) a string variable test using the 'is' operator fails (so it always return ok immediately after initial delay)
 - add a missing socket.settimeout() for the state=started case (if the machine does not exist, timeout defaults to 60 seconds)
 - add a connect_timeout option to customize the default connection timeout
 - use socket.shutdown(2) to close immediately
 - return the elapsed time
 2012-09-19 15:19:59 +02:00
Michael DeHaan
4cd3262f50 Merge pull request #1054 from jpmens/geturl_doc1 
First attempt at standardizing DOCUMENTATION string
 2012-09-19 06:09:39 -07:00
Aleksej Romanov
eefe66f1cc Squashed commit of the following: 
commit 80a26a8175b779b707bc08e9d28c451c30ee4ada
Merge: b25b9fd 61e9b27
Author: Michael DeHaan <michael.dehaan@gmail.com>
Date:   Tue Sep 18 21:01:47 2012 -0400

    Merge branch 'devel' of git://github.com/alopropoz/ansible into file-force

commit 61e9b27df2
Merge: 3f6f329 16bf3e1
Author: Aleksej Romanov <alopropoz2@yandex.ru>
Date:   Thu Sep 13 20:48:02 2012 +0700

    Merge remote branch 'upstream/devel' into devel

commit 3f6f3291df
Author: Aleksej Romanov <alopropoz2@yandex.ru>
Date:   Thu Sep 13 20:41:31 2012 +0700

    'force' option for 'file' module.

commit 6223bba941
Author: Aleksej Romanov <alopropoz2@yandex.ru>
Date:   Thu Sep 13 20:40:19 2012 +0700

    changed = True when changing symlink referent, #1008. Needed for tests.
 2012-09-18 21:04:42 -04:00
Jan-Piet Mens
e041c2e2cd First attempt at standardizing DOCUMENTATION string (new DICT) 2012-09-18 14:04:43 +02:00
Michael DeHaan
d77be4eecf Merge pull request #1052 from romeotheriault/add-SunOSVirtual-facts 
Adding SunOSVirtual facts
 2012-09-17 17:27:43 -07:00
Romeo Theriault
d72eaa3fc5 Adding SunOSVirtual facts 2012-09-16 23:14:06 -10:00
Stephen Fromm
65fe7b7003 Update package manager fact innards to a list of dicts 2012-09-16 21:42:55 -07:00
Stephen Fromm
94eb11a6d7 Add pkg_mgr fact to setup 
This should help facilitate playbook decision making that are not
strictly distribution specific, but more package manager.
 2012-09-16 21:42:54 -07:00
Michael DeHaan
7df0e5259f Merge pull request #1038 from bcoca/atomic_copy2 
Atomic copy2
 2012-09-14 15:53:49 -07:00
Ali Asad Lotia
c0aac03b0c url_get module returns dest 
The url_get module now includes the destination in the returned JSON.
 2012-09-14 08:34:41 +01:00
Ali Asad Lotia
99746d4a83 Indicate thirsty argument required if dest is dir. 
The check for the destination being a directory is now done before
checking if the file exists, that way the user is informed that the
thirsty argument is required.
 2012-09-14 08:02:30 +01:00
Daniel Hokka Zakrisson
56b1a8ceed Invoke is_installed correctly from rpm path 2012-09-13 12:34:52 +02:00
Brian Coca
88d1285f33 time is what i wanted, not gmtime 
Signed-off-by: Brian Coca <briancoca+ansible@gmail.com>
 2012-09-12 14:52:54 -04:00
Brian Coca
06b914c5b3 small fix to prevent temp file from living past its succesful usage 
Signed-off-by: Brian Coca <briancoca+ansible@gmail.com>
 2012-09-12 14:47:06 -04:00
Brian Coca
f5481621f8 made copy atomic by creating tmp file in dest location (ensures same partition) 
uses pid and epoch to prevent collisions, good enough for most cases
Signed-off-by: Brian Coca <briancoca+ansible@gmail.com>
 2012-09-12 14:42:51 -04:00
Michael DeHaan
565f336182 lineinfile should use 'search' everywhere 2012-09-08 14:53:34 -04:00
Michael DeHaan
14a9c3ab9e Line in file regexep should match a portion of the line, not the whole line! 2012-09-07 21:03:59 -04:00
Michael DeHaan
5b57011152 Merge pull request #1027 from mcodd/setup_bug_python24 
setup not python24 compatible in 0.7
 2012-09-08 05:24:09 -07:00
Michael DeHaan
335f136e71 Merge pull request #1023 from lorin/postgres-user-fix 
Fix postgresql_user bug
 2012-09-08 05:23:29 -07:00
Matt Coddington
c0638842d8 make this python24 compatible 2012-09-07 22:47:03 -04:00
Lorin Hochstein
b3b01bb7a3 Fix postgresql_user bug 
If I create a database from scratch and assign permissions by doing:

      - name: ensure database is created
        action: postgresql_db db=$dbname

      - name: ensure django user has access
        action: postgresql_user db=$dbname user=$dbuser priv=ALL password=$dbpassword

Then it fails with the error:

  File "/tmp/ansible-1347048449.32-29998829936529/postgresql_user", line 565, in <module>
    main()
  File "/tmp/ansible-1347048449.32-29998829936529/postgresql_user", line 273, in main
    changed = grant_privileges(cursor, user, privs) or changed
  File "/tmp/ansible-1347048449.32-29998829936529/postgresql_user", line 174, in grant_privileges
    changed = grant_func(cursor, user, name, privilege)\
  File "/tmp/ansible-1347048449.32-29998829936529/postgresql_user", line 132, in grant_database_privilege
    prev_priv = get_database_privileges(cursor, user, db)
  File "/tmp/ansible-1347048449.32-29998829936529/postgresql_user", line 118, in get_database_privileges
    r = re.search('%s=(C?T?c?)/[a-z]+\,?' % user, datacl)
  File "/usr/lib/python2.7/re.py", line 142, in search
    return _compile(pattern, flags).search(string)
TypeError: expected string or buffer

This fix fixes the problem by not executing the regex if the
db query on pg_database returns None.
 2012-09-07 16:24:00 -04:00
Seth Vidal
9d88b3eedd add import sys to virt module b/c it needs it if the libvirt python 
module is missing
 2012-09-07 16:05:42 -04:00
Michael DeHaan
4280e00d56 Merge pull request #1000 from mavimo/patch-1 
Add support to removes control param
 2012-09-06 17:52:02 -07:00
Michael DeHaan
7ef3e7dccb Merge pull request #1003 from bladypirat/devel 
added support for custom port definition for postgresql_* modules
 2012-09-06 17:51:35 -07:00
Michael DeHaan
49bef3f6c2 Merge pull request #1005 from dagwieers/cmdline 
Add /proc/cmdline information to the default facts
 2012-09-06 17:51:19 -07:00
Jan-Piet Mens
b36aa61237 Add support for RSA/DSA SSH host key detection in setup module for OS/X 
s/<8spaces>/<4spaces>/g
 2012-09-06 20:40:21 +02:00
Dag Wieers
d158218c3f Add /proc/cmdline information to the default facts 
The use-case here is that based on information in the /proc/cmdline certain actions can be taken.

A practical example in our case is that we have a play at the end of the provisioning phase that reboots the system. Since we don't want to accidentally reboot a system (or restart the network) on a production machine, having a way to separate an Anaconda post-install (sshd in chroot) with a normal system is a good way to make that distinction.

    ---
    - name: reboot
      hosts: all
      tasks:
      - action: command init 6
        only_if: "not '${ansible_cmdline.BOOT_IMAGE}'.startswith('$')"

A practical problem here is the fact that we cannot simply check whether it is set or empty:

    ---
    - name: reboot
      hosts: all
      tasks:
      - action: command init 6
        only_if: "'${ansible_cmdline.BOOT_IMAGE}'"

If ansible_cmdline was a string, a simple only_if: "'${ansible_cmdline}'.find(' BOOT_IMAGE=')" was an option, but still not very "beautiful" :-/

This implementation uses shlex.split() and uses split(sep, maxsplit=1).
 2012-09-06 09:35:33 +02:00
Piotr Kweclich
8360f9f46c added support for custom port definition 2012-09-05 18:18:30 +02:00
Marco Vito Moscaritolo
2dd430d9c0 Add support to removes control param 
Execute action only if specified file using param removes exist (execute reverse control of creates).

Some usage eg.:

```yaml
- name: enable apache2 default websites
  action: command /usr/sbin/a2ensite $item
creates=/etc/apache2/sites-enabled/$item
  with_items:
    - default
    - default-ssl

- name: disable apache2 default websites
  action: command /usr/sbin/a2dissite $item
removes=/etc/apache2/sites-enabled/$item
  with_items:
    - default
    - default-ssl
```
 2012-09-05 14:06:47 +03:00
Michael DeHaan
eed031cd82 Check for ipv6 2012-09-04 21:22:47 -04:00
Michael DeHaan
aa704a6111 backuplocal => backup_local for API standardization reasons 2012-09-04 19:49:49 -04:00
Michael DeHaan
b97e2a6f5a Merge branch 'backup-common' of https://github.com/dhozac/ansible into devel 2012-09-04 19:45:39 -04:00
Michael DeHaan
c69c3d6e18 Merge pull request #995 from mattupstate/devel 
Use `get_bin_path` properly for supervisorctl module
 2012-09-04 16:44:22 -07:00
Daniel Hokka Zakrisson
a5d63532d3 Add backup to assemble 2012-09-04 16:04:53 +02:00
Daniel Hokka Zakrisson
2a8b92954f Add backups to lineinfile 2012-09-04 16:04:53 +02:00
Daniel Hokka Zakrisson
dfcb9d3c2d Move backup to module_common 2012-09-04 16:04:53 +02:00
willthames
8b8eae7d82 Allow ~ expansion in chdir argument of command module 
This allows the use of ~ in the chdir argument of the command module
I know the later change is absolutely necessary as the first change
was not sufficient. It may be that the first change fixes shell and
the second fixes command.
 2012-09-04 14:22:53 +10:00
willthames
d4c4a51866 Subversion dest should allow ~ expansion 
Used os.path.expanduser on dest to allow e.g. ~/svn/repo as
a destination
 2012-09-04 10:15:13 +10:00
Michael DeHaan
8f220a4f77 Always pipe stderr in the setup module to avoid JSON interference. 2012-09-02 12:34:28 -04:00
Matt Wright
d52f1d969b Use get_bin_path properly 2012-08-31 15:03:26 -04:00
Matt Wright
a092eadbbb Fix supervisorctl module after merge issue 2012-08-31 11:03:14 -04:00
Michael DeHaan
8e02b165f1 chmod +x 2012-08-30 19:43:14 -04:00
Michael DeHaan
b0ac7e07b0 Merge branch 'binpath' of https://github.com/sfromm/ansible into devel 
Conflicts:
	library/supervisorctl
 2012-08-30 19:24:09 -04:00
Michael DeHaan
a454db5345 Merge pull request #970 from mattupstate/devel 
Improve apt_repository and supervisorctl
 2012-08-30 16:21:47 -07:00
Michael DeHaan
90f051f818 Merge pull request #971 from sfromm/seboolean 
Add seboolean module
 2012-08-30 16:10:30 -07:00
Michael DeHaan
092bd8e3da make parameter required 2012-08-30 19:09:02 -04:00
Michael DeHaan
4da4c31dfb Merge pull request #974 from goozbach/add_selinux_module 
add selinux module
 2012-08-30 16:02:16 -07:00
Derek Carter
2aa760a3fc add selinux module 2012-08-30 15:29:59 -04:00
Stephen Fromm
6742e9c3f4 Add option required=(True|False) to get_bin_path and update modules 
Added required as optional argument to get_bin_path(). It defaults to
false.  Updated following modules to use required=True when calling
get_bin_path():  apt_repository, easy_install, group, pip,
supervisorctl, and user.
Also removed _find_supervisorctl() from supervisorctl module and updated
_is_running() to not need it.
 2012-08-30 11:01:37 -07:00
Matt Wright
b93df1fc60 Update handling of state changes 2012-08-30 12:37:02 -04:00
Matt Wright
bdfccbfb34 Move conditional that accounts for variances in distros/versions to work when removing and adding. 2012-08-30 12:35:37 -04:00
Stephen Fromm
97c2e58081 Add seboolean module 
Will manage values of seboolean on a host.  Options are name (name of
boolean), state (on or off), and persistent (on or off).  Persistent
defaults to no.
 2012-08-30 09:33:09 -07:00
Stephen Fromm
e5a635672c Migrate remaining modules to use get_bin_path in module_common.py 
* Migraed easy_install, pip, service, setup, and user.
* Updated fail_json message in apt_repository
* Fixed easy_install to not hardcode location of virtualenv in
  /usr/local/bin/.
* Made handling of virtualenv more consistent between easy_install and
  pip.
 2012-08-29 20:26:22 -07:00
Stephen Fromm
bdb39058ae Migrate apt_repository, group, and supervisorctl to use module.get_bin_path 2012-08-29 16:24:49 -07:00
Daniel Hokka Zakrisson
ed8e31d618 Add a lineinfile module 2012-08-30 00:07:58 +02:00
Michael DeHaan
d0994cd169 Merge branch 'setup-no-dash-facts' of https://github.com/tima/ansible into devel 
Conflicts:
	library/setup
 2012-08-28 20:29:40 -04:00
Matt Wright
a82928e7dc fix bug in supervisorctl module 2012-08-28 19:21:05 -04:00
Timothy Appnel
8c32aefc80 Replace - with _ in setup module key names to avoid variable access problems reported in #954 2012-08-28 19:02:19 -04:00
Michael DeHaan
f9e9753141 Remove obsolete comment 2012-08-28 07:29:32 -04:00
Michael DeHaan
d7eed66a06 Merge pull request #951 from gottwald/devel-git-sudo-fix 
Added cwd to tempdir in git clone method. Fixes usage with sudo.
 2012-08-28 04:28:46 -07:00
Ingo Gottwald
30fdd56560 Added cwd to tempdir in git clone method. Fixes usage with sudo. 2012-08-28 11:28:50 +02:00
Tim Bielawa
6b73907811 Change from a module config file to brute force locating the nagios configs so we can find the command file. 2012-08-28 02:16:07 -04:00
Tim Bielawa
98d3e2bfc8 Nagios is executable now 2012-08-27 20:01:06 -04:00
Tim Bielawa
8b8aaa7f76 Fix copying that special character 2012-08-27 11:55:38 -04:00
Tim Bielawa
da2665bcd2 In-line docs. 2012-08-27 11:39:52 -04:00
Tim Bielawa
9829033a8a Now reading from a config file actually works. 2012-08-27 11:30:13 -04:00
Tim Bielawa
62ffeb93a5 Services iterate correctly now 
Cleaned up return methods
 2012-08-27 11:08:16 -04:00
Tim Bielawa
5d41fffa00 Groundwork for nagios module. 2012-08-27 04:11:59 -04:00
Florian Diebold
886fed5ae7 Remove ternary operator to fix python 2.4 compatibility. 2012-08-26 00:16:58 +02:00
Florian Diebold
af17bab373 Support systemd in the service module. 
Most of it worked already, except for the enable parameter, because it
tried to use chkconfig which only sees SysV services. First look for
systemctl and use that if it exists.
 2012-08-25 22:26:34 +02:00
Michael DeHaan
4816644b22 Merge pull request #937 from jhoekx/wait-state 
Add a state parameter to the wait_for module.
 2012-08-24 16:46:41 -07:00
Michael DeHaan
165f4b514d Merge pull request #938 from skvidal/devel 
fix up local_nvra and fix for a missing localinstall rpm file.
 2012-08-24 16:46:06 -07:00
Maxim Burgerhout
3d44de284a Add working CPU model fact for some ARM devices 
Works on Sheevaplug, probably works on Rasberry Pi as well
 2012-08-24 23:11:06 +02:00
Jeroen Hoekx
81c9a0cb78 wait_for: remove restarted, add delay, rename name to host, make port required. 2012-08-24 20:58:05 +02:00
Jeroen Hoekx
18d5c875d0 Change wait_for return message to be machine readable. 2012-08-24 20:47:55 +02:00
Seth Vidal
5dbc85e8ad fix up local_nvra 2012-08-24 13:51:07 -04:00
Jeroen Hoekx
5ba34572d9 Add a state parameter to the wait_for module. 
This takes started, stopped and restarted.

Started returns when connecting is possible.
Stopped when connecting is not possible.
Restarted first waits for connecting to be impossible and returns when it is
possible again.
 2012-08-24 19:08:45 +02:00
Michael DeHaan
150a47c66c Merge pull request #922 from dsummersl/subversion 
Subversion
 2012-08-23 18:43:29 -07:00
Michael DeHaan
b3b607ff5e Merge pull request #931 from elventear/postgresql_db 
Allow change of ownership and checks for existing database
 2012-08-23 18:41:15 -07:00
Michael DeHaan
7341ed241e Merge pull request #924 from elventear/postgresql_user 
Change semantics of postgresql_user module
 2012-08-23 18:40:45 -07:00
Jeroen Hoekx
8660fb074a Add the wait_for module. 
This module waits until a specific port on a given host can be connected to.
 2012-08-23 19:41:26 +02:00
Dane Summers
71cff25254 added force option to git - made both subversion and git default to force=true for backward compatibility with git's previous behavior 2012-08-23 00:07:14 -04:00
Dane Summers
6dd6a4c534 tested library - fixed several test cases, added 'force' option, and removed grep requirement 2012-08-22 23:06:03 -04:00
Pepe Barbe
fdaf65282b bugfix in sql query 2012-08-22 13:34:24 -05:00
Pepe Barbe
fdbc99dc28 Check for database ownership 2012-08-22 12:20:51 -05:00
Pepe Barbe
6d473df324 Typo 2012-08-22 12:19:55 -05:00
Pepe Barbe
af5d67c496 Query for all active privileges instead 
Use a different method to query for current 
privileges at the table and database level. 
This method is more robust if newer privileges 
are added in future versions and also supports the 
ALL wildcard.
 2012-08-22 10:04:58 -05:00
Pepe Barbe
95169b75c4 Add fail_on_user option 
fail_on_user option can be used to ignore silently
if the user cannot be removed because of remaining
privilege dependencies to other objects in the 
database. By default it will fail, so that this new 
behavior won't surprise unsuspecting users.
 2012-08-22 10:04:58 -05:00
Pepe Barbe
4e833cf506 Initial commit of change of semantics for module 
The postgresql_user module has several drawbacks:
* No granularity for privileges
* PostgreSQL semantics force working on one
  database at time, at least for Tables. Which
  means that a single call can't remove all the 
  privileges for a user, and a user can't be
  removed until all the privileges are removed, 
  forcing a module failure with no way to 
  work around the issue.

Changes:
* Added the ability to specify granular privileges
  for database and tables within the database
* Report if user was removed, and add an option to 
  disable failing if user is not removed.
 2012-08-22 10:04:57 -05:00
Dane Summers
24c8c22e75 removed logger, removed superfluous mkdir 2012-08-21 16:10:17 -04:00
Dane Summers
157fa3868a added TODO for test scenarios to add 2012-08-21 13:59:39 -04:00
Dag Wieërs
9d4f70f0ad Handle special files just like normal files 
As discussed in #923
 2012-08-21 23:48:18 +02:00
Michael DeHaan
1ae018ce94 Adds a thirsty=yes|no to the get_url module, such that if downloading a large file from the internet you can decide 
whether to download it every time or not -- will replace only on change, or decide to not download.  The default
is thirsty=no which will not download every time by default.
 2012-08-20 18:39:37 -04:00
Tim Bielawa
3d3c8a004e Fix setup module explosion when a route is empty. Closes #909 2012-08-19 21:19:07 -04:00
Michael DeHaan
14c2e8de0c Fix invalid usage or fail_json in apt module 2012-08-18 19:43:45 -04:00
Michael DeHaan
798c35d83e Apt module should accept 'absent', and 'present' like the yum module does. 2012-08-18 18:38:10 -04:00
Michael DeHaan
8eda23f856 tweak service module pattern= logic so ./hacking/test-module does not give false positives 2012-08-17 20:26:22 -04:00
Michael DeHaan
bc571ccb55 Merge pull request #902 from sfromm/issue719 
Add pattern option to service module
 2012-08-17 17:17:32 -07:00
Michael DeHaan
2b51cf04c7 Merge pull request #901 from dhozac/setup-ip 
Work with tun and p2p interfaces
 2012-08-17 17:10:59 -07:00
Michael DeHaan
705057b9a6 Merge pull request #900 from lorin/pip-venv-bug 
Retrieve pip path after creating virtualenv
 2012-08-17 17:10:35 -07:00
Michael DeHaan
229ab1582a Merge pull request #898 from elventear/postgresql_user_py24 
Fixes for postgresql_user to make it work with postgresql defaults and under Python 2.4
 2012-08-17 17:09:35 -07:00
Stephen Fromm
18f0302de8 Add pattern option to service module 
Adds ability to check service status based on pattern.  The pattern
is a simple string.  If a pattern is provided, the output of ps is
checked first.
 2012-08-17 14:00:01 -07:00
Daniel Hokka Zakrisson
121341833a Work with tun and p2p interfaces 2012-08-17 22:08:04 +02:00
Lorin Hochstein
8223d3ee3f Retrieve pip path after creating virtualenv 
Retrieve the pip path after creating a non-existent virtualenv.
Prevents the problem of using the wrong pip if virtualenv doesn't
exist yet.
 2012-08-17 14:38:49 -04:00
Pepe Barbe
3dd2c0700f Syntax change to make module compatible with Python 2.4 2012-08-17 10:37:02 -05:00
Lorin Hochstein
8af3403f65 Return both stdout and stderr on pip failures. 
pip failure message sometimes (always?) go to standard out. Return
both standard out and standard error when there's a failure.
 2012-08-17 11:32:47 -04:00
Michael DeHaan
c93df29249 Make a more logical error when the command/shell module is used with no arguments. 2012-08-16 21:40:52 -04:00
Sundar Raman
3aff9396e8 (Re #882) Handle errors in get_interfaces 
If there is an error in how interfaces are configured (or only one set, like IPv6),
the setup command should not error out.
 2012-08-15 19:22:05 -04:00
Dane Summers
19686d549c support for subversion repositories 2012-08-15 09:04:17 -04:00
Jeremy Penner
09d5812cbb Make easy_install module actually work. 
mpdehaan requested in ansible/ansible#795 that globals be removed.
The response was to remove the lines with the word 'global', but not
the actual use of global variables.  Which makes the module break silently.
Updated to use local variables.
 2012-08-14 23:31:13 -04:00
Michael DeHaan
ded0c61750 meaningless whitespace changes 2012-08-14 19:33:11 -04:00
Michael DeHaan
de4b8dc53a Can use fail JSON here, remove debug statement 2012-08-14 19:29:09 -04:00
Michael DeHaan
58c975d621 Fix aliases, package not found is not an error 2012-08-14 19:27:02 -04:00
Michael DeHaan
07fd96acc9 Merge branch 'devel' of https://github.com/skvidal/ansible into devel 2012-08-14 19:20:09 -04:00
Michael DeHaan
731adc0eaf Merge pull request #866 from akhayyat/devel 
setup: add type and default_ipv{4,6} to linux network facts
 2012-08-14 16:19:14 -07:00
Michael DeHaan
a2a8cfe099 Merge pull request #876 from elventear/postgresql_fix 
Changes to postgresql to support defaults settings and older psycopg2
 2012-08-14 16:17:37 -07:00
Pepe Barbe
7dcd1bd223 Autocommit support for psycopg2 < 2.4.2 2012-08-14 17:12:09 -05:00
Pepe Barbe
95fc5dd4a8 Fix using postgres default values 
When initalizing a connection to psycopg2, in order to use the default
values, the keywords must be missing. So we use a dictionary as a kwarg
and include only the keywords that do not have an empty value on the
module parameters.
 2012-08-14 17:11:53 -05:00
Seth Vidal
3175eacfc4 fixes to yum module 
include local_nvra
change the remove behavior to pretty much NEVEr error out if the pkg is not there (or anywhere)
 2012-08-14 16:23:40 -04:00
Seth Vidal
14479e6adc cover all of the edge cases with and without yum-utils installed. 
it is possible those folks w/o yum-utils installed but with rhn-plugin
installed but w/o any rhn-certificates will still see an error msg.
they have 3 options:
1. remove rhn-plugin
2. enable some channels w/rhn certs
3. install yum-utils
 2012-08-14 13:23:49 -04:00
Seth Vidal
2e3926d13f subprocess is already imported in module_common - no need for it here 2012-08-14 13:23:49 -04:00
Daniel Hokka Zakrisson
ae964b97c4 Fix spelling of architecture for non-x86 2012-08-14 15:57:54 +02:00
Ahmad Khayyat
c96c51a534 setup: add type and default_ipv{4,6} to linux network facts 2012-08-14 01:37:14 -04:00
Michael DeHaan
7ab0d60b1a update config code 2012-08-13 20:17:07 -04:00
Michael DeHaan
3b259ef5f6 Merge pull request #859 from zecrazytux/bugfix/apt_repository 
Bugfix/apt repository
 2012-08-13 15:30:21 -07:00
Michael DeHaan
e29ee9db2b Merge pull request #860 from goozbach/broken_mount 
fixed missing module argument for mount module
 2012-08-13 15:29:43 -07:00
Pepe Barbe
bce1d4da53 Use Python 2.4 compatible syntax 2012-08-13 16:02:16 -05:00
Derek Carter
556593bb18 fixed missing module argument for mount module 2012-08-13 15:20:36 -04:00
Sebastien Bocahu
d95eddceb1 Quote the repository string when appending it to the command line in the apt_repository module. 2012-08-13 19:36:08 +02:00
Sebastien Bocahu
3e9bcd351d Add support for Debian in apt_repository 2012-08-13 19:23:53 +02:00
Sebastien Bocahu
df269c72c1 Fixed scoping issue in apt_repository module. 2012-08-13 19:06:53 +02:00
Stephen Fromm
c4ce5f9497 Try to find ip command in either /sbin or /usr/sbin 
If ip is not found in either /sbin or /usr/sbin, this will return
an empty result.  It seems extremely unlikely that a linux system will
not have iproute2 installed
 2012-08-11 23:54:22 -07:00
Stephen Fromm
84028c2339 Tweak invocation of ip in LinuxNetwork 
Specify full path to ip and add third argument 'show' to be explicit
about requested action.  This goes from 'ip addr' to
'/sbin/ip addr show'.
 2012-08-11 23:54:22 -07:00
Michael DeHaan
75bbd73173 Fix indentation 2012-08-11 18:39:09 -04:00
Michael DeHaan
67301c1015 rename variable 'pkg' in yum module such that the auto-handled error messages use the same key. 2012-08-11 18:16:10 -04:00
Michael DeHaan
1e4d45af1e Add module common code to allow it to be easier to indicate whether arguments are mutually exclusive, required in conjunction, or whether one of a list of arguments is required. This simplifies writing Python modules. 2012-08-11 18:13:29 -04:00
Michael DeHaan
e9c9d8f523 tweak config mode check to just have a default 2012-08-11 12:38:05 -04:00
Michael DeHaan
477ca2ed1a Make pep8 tests run against the library directory as well, and associated tweaks (mostly to indentation) in the library 
directory.
 2012-08-11 12:35:58 -04:00
Michael DeHaan
e0765be1ea Merge pull request #850 from akhayyat/virt-facts 
Add openvz detection to virtualization facts, and some cleanup
 2012-08-11 09:11:01 -07:00
Michael DeHaan
32922e404b Don't include local addresses in the all_ipv4/6 list 2012-08-11 12:08:55 -04:00
Ahmad Khayyat
916fcdb93b Add openvz detection to virtualization facts, and some cleanup 2012-08-11 08:33:43 -04:00
Ahmad Khayyat
f0a8e13628 Update doc string and minor cleanup 2012-08-11 06:39:22 -04:00
Ahmad Khayyat
7950dd01e5 Recognize interface aliases in network facts, and add IP facts 2012-08-11 06:20:32 -04:00
Michael DeHaan
36527ca9d5 Merge pull request #838 from sfromm/issue825 
Update file module to not recurse when setting ownership
 2012-08-10 17:02:23 -07:00
Sébastien Bocahu
487d07a845 Fix variable scope 2012-08-10 21:58:58 +02:00
Stephen Fromm
94696fb88e Update file module to not recurse when setting ownership 
This updates set_owner_if_different() and set_group_if_different()
to not implicitly recurse when setting ownership (whether user or
group).  It drops the os.system() call and replaces it with os.chown().
Resolves issue #825.

The recursion should be explicit.  A recurse=yes|no option should be
added to the file module.
 2012-08-09 22:59:39 -07:00
Michael DeHaan
9e934acfca Relative symlinks don't really work (module bug) and would be confusing anyway, better to be explicit. 2012-08-09 21:46:03 -04:00
Michael DeHaan
ef18f9d953 Fix a scoping issue that was fixing some non-repoquery-installed cases 2012-08-09 21:35:21 -04:00
Michael DeHaan
63641da225 Merge branch 'yum-wo-repoquery' of https://github.com/dhozac/ansible into devel 
Conflicts:
	library/yum
 2012-08-09 21:29:59 -04:00
Michael DeHaan
8e12440db4 Merge pull request #830 from cybertoast/feature/pip_module_py2.4 
Feature/pip module py2.4
 2012-08-09 17:24:27 -07:00
Michael DeHaan
f311d685cb Merge pull request #828 from skvidal/devel 
add backup= option to copy. makes a backup of the file on the target
 2012-08-09 17:23:52 -07:00
Sundar Raman
66a6231922 Further syntax fix work on Python2.4 
The `val if something else something-else` syntax does not work prior to 2.5.
 2012-08-09 18:09:18 -04:00
Sundar Raman
9ad91d7369 Fix syntax to work on Python2.4 
The `val if something else something-else` syntax does not work prior to 2.5
 2012-08-09 17:54:29 -04:00
Seth Vidal
588b129018 fix case where destination does not yet exist - no backup can be made 2012-08-09 15:33:05 -04:00
Seth Vidal
28e9b1128f add backup= option to copy. makes a backup of the file on the target 
in a file named: $filename.YYYY-MM-DD@HH:MM~

backup=False is default
 2012-08-09 14:24:21 -04:00
Seth Vidal
5c458b9761 make yum module work with list=pkgspec 2012-08-09 13:22:51 -04:00
Daniel Hokka Zakrisson
5a7d271759 Allow using the yum module without repoquery 
It is still required to use list=..., but the typical install and remove
won't need it.
 2012-08-09 17:22:09 +02:00
Michael DeHaan
c82f06258c Only run yum,apt through the with_items loop if there is a list of items. Just a cosmetic fix on return values 
for the most part.
 2012-08-08 20:43:01 -04:00
Michael DeHaan
d451cc6463 Merge pull request #794 from mattupstate/apt_repository 
add apt_repository module
 2012-08-08 16:14:38 -07:00
Michael DeHaan
b378a94b7b Merge pull request #796 from mattupstate/pip 
add pip module
 2012-08-08 16:13:32 -07:00
Michael DeHaan
82dfb11fb9 Merge pull request #807 from mattupstate/supervisorctl 
Add supervisorctl module
 2012-08-08 16:13:16 -07:00
Michael DeHaan
67205eb816 Merge pull request #795 from mattupstate/easy_install 
Add easy_install module
 2012-08-08 16:12:30 -07:00
Michael DeHaan
311d7c46ca Merge pull request #806 from skvidal/devel 
fix up yum state=latest with pkg groups
 2012-08-08 16:11:41 -07:00
Michael DeHaan
fe65648ea5 Merge pull request #808 from sfromm/issue800 
Make exception more specific (OSError) in setup module for selinux call
 2012-08-08 16:11:04 -07:00
Seth Vidal
61e02d508c add show-duplicates to reqpoquery to keep people who 
want to install an old package happy.
 2012-08-08 14:02:38 -04:00
Stephen Fromm
0cc73c930b Make exception more specific (OSError) in setup module for selinux call 2012-08-08 08:56:12 -07:00
Matt Wright
34e0faaf4b Add supervisorctl module 2012-08-08 10:59:46 -04:00
Matt Wright
15e9f1e15a Update per ansible/ansible#794 2012-08-08 10:46:23 -04:00
Seth Vidal
ca63173bf0 missed the quotes 2012-08-08 10:43:45 -04:00
Matt Wright
2a68f5d0af Updates per ansible/ansible#795 2012-08-08 10:38:27 -04:00
Seth Vidal
70eea69e79 fix up yum state=latest with pkg groups 2012-08-08 10:35:43 -04:00
Matt Wright
0116e53e48 Updates per ansible/ansible#796 2012-08-08 10:35:07 -04:00
Michael DeHaan
f757d659cc Merge pull request #804 from sfromm/issue789 
Abstract how to look up user password to be more flexible
 2012-08-08 04:46:28 -07:00
Michael DeHaan
ae7e1928df Merge pull request #790 from sfromm/fixgit 
Fix error handling when switching versions
 2012-08-08 04:44:43 -07:00
Stephen Fromm
49f3ab6757 Abstract how to look up user password to be more flexible 
This adds user_password() to abstract how the user's password is looked
up.  If spwd is not available, this will read the shadow file for the
user's shadow entry.  This will then facilitate idempotent password
changes on hosts without spwd.
 2012-08-07 23:57:17 -07:00
Stephen Fromm
3fb3eae7b6 Protect all selinux calls with try/except 2012-08-07 22:57:44 -07:00
Matt Wright
62297b608f Add easy_install module 2012-08-07 16:41:34 -04:00
Matt Wright
bef4c1b955 add apt_repository module 2012-08-07 16:39:31 -04:00
Matt Wright
4de0e5de54 add pip module 2012-08-07 16:38:04 -04:00
Stephen Fromm
6265be3aee Fix error handling when switching versions 
git module used to check stderr for the string 'error' after calling
switch_version().  This changes that to just look at the return code to
determine whether the command failed.  If the rc is not zero, the git
module will call fail_json().

The problem is that git checkout will summarize the commit message,
such as:

    HEAD is now at ea38409... removing artificial error

When the string 'error' is the commit message, this check will
erroneously think the command failed.

This also removes the method switchLocalBranch() since it is no longer
used.
 2012-08-07 11:20:14 -07:00
Michael DeHaan
092f83e6f8 Merge pull request #781 from gottwald/devel-mysql-socketOption 
login_unix_socket option for mysql modules
 2012-08-06 18:45:36 -07:00
Michael DeHaan
faed4b5a33 whitespace + remove deprecated YAML parser (migration script lives in examples/scripts and warning was added 
in 0.6 release)
 2012-08-06 20:07:02 -04:00
Michael DeHaan
08c1f96e4b Fix some subtle behavior of how the get_url module chains into the file module, plus blend the results of daisy chain 
operations in the correct order, so the file module results overlay the original module results, not the other way
around (which keeps any failure msg's intact)
 2012-08-03 07:02:31 -04:00
Ingo Gottwald
891415e616 Added login_unix_socket option to mysql_user module 2012-08-03 12:35:18 +02:00
Ingo Gottwald
a2aa30f4e5 Added login_unix_socket option to mysql_db module 2012-08-03 12:34:55 +02:00
Michael DeHaan
7e9e29011e Add encoding lines to python modules such that they can take unicode options if they are fed them, since the 
AnsibleModule stuff no longer base64 encodes for simplicity and speed reasons.
 2012-08-02 21:29:10 -04:00
Michael DeHaan
ce01c3f7e7 Allow unicode transfer by not base64 encoding. Also: faster 2012-08-02 21:20:43 -04:00
Seth Vidal
4d29cd6ee3 make virt module command= work again - better error handling should be in its 
future
 2012-08-02 17:46:21 -04:00
Seth Vidal
fd492bebc6 - add a check for repoquery so we can abort politely 
- make the results output a bit more readable
- fix up where repoquery is looked for so it is easier to change
 2012-08-02 17:02:37 -04:00
Michael DeHaan
98e4034de2 Merge pull request #772 from gottwald/devel-serviceFix 
Fixed a Bug in the service module "state changed" recognition
 2012-08-02 08:49:30 -07:00
Ingo Gottwald
25b52109b4 Fixed a Bug in the service module state changed recognition 2012-08-02 17:18:25 +02:00
Stephen Fromm
85c838c835 Add Blade to FORM_FACTOR list and document SMBIOS spec URL 2012-08-02 07:24:05 -07:00
Stephen Fromm
9a3ad060dc Catch exception if form factor id is unknown 2012-08-02 07:06:55 -07:00
Michael DeHaan
fa79d57d13 changelog / remove a failed=False 2012-08-01 22:35:07 -04:00
Michael DeHaan
b7c3fd1246 failed should not be in the result returns for a module upon success 2012-08-01 22:30:22 -04:00
Michael DeHaan
91d31d8164 Merge pull request #761 from skvidal/devel 
redo of yum module - uses more system calls but should handle
 2012-08-02 05:13:23 -07:00
Seth Vidal
c91befda5c redo of yum module - uses more system calls but should handle 
random plugin vomit better.
also should handle multiple withitems in a single execution, now.
 2012-08-02 01:47:48 -04:00
Michael DeHaan
e820c282be Merge pull request #760 from sfromm/fixes 
A couple fixes for the file module
 2012-08-02 04:54:16 -07:00
Will Thames
0e26ef9bdd Revert acceptance of directory as dest for copy 
Although library/copy can be corrected to understand that dest is
a directory, I can't see how to let _execute_copy know this and let the
file module know.

As a better solution than before #733, the copy module now explicitly (rather
than silently) fails when dest is a directory.
 2012-08-02 16:54:03 +10:00
Stephen Fromm
d0892c19ad Add setype to file's argument_spec and remove secontext 
secontext is used internally and should not be in argument_spec
 2012-08-01 22:24:09 -07:00
Stephen Fromm
52afacf475 Fix module_fail_json call when symlink src does not exist 2012-08-01 22:23:02 -07:00
Michael DeHaan
25acfa8170 Join with_items for the apt module, yum pending, and various fixes to the yum module to support aliases 2012-08-01 20:33:13 -04:00
Michael DeHaan
ed14312ad6 reinstate invalid argument checks where possible, daisy chainee/chained modules turn it off 2012-08-01 19:42:31 -04:00
Michael DeHaan
77029a4227 Merge pull request #752 from go2sh/apt-patch 
Enable apt module to handle multiply packages (comma separated)
 2012-08-01 16:27:29 -07:00
Stephen Fromm
abe8d8d4d6 Return extra information from service module 
If _do_enable() is run and returns rc == 0, set changed=True
Add enabled and state to result if they are supplied when the module is
run.
 2012-08-01 14:58:32 -07:00
Stephen Fromm
42ad1c879f Fix service module for issue 755 and another bug 
Allow use of service module with just enable parameter, per issue #755.
Also fixed two other issues:
- fixed parameter to be 'enabled' per docs, not 'enable'.
- fixed if block that checks whether to run _do_enable() to check
  whether the parameter is set, not the value of the enable value which
  may be None or False.  If enabled=no, the service would never be
  disabled.
 2012-08-01 14:44:26 -07:00
Christoph Seitz
6baaea90ae Tweaked error massages. 2012-08-01 18:45:32 +02:00
Christoph Seitz
b973910283 Some optimizations to previous code. 2012-08-01 18:43:39 +02:00
Christoph Seitz
418445d3c5 Enable apt module to handle multiply packages (comma separated) 2012-08-01 18:09:30 +02:00
Jan-Piet Mens
31c0e523c2 Fix exeptions, replace 'as' by ',' as reported on IRC for Python 2.4.3 on Centos5 2012-08-01 15:30:16 +02:00
Michael DeHaan
0a3ebdb6d5 Module consistency and make daisy chaining work with invalid arguments detection. 2012-08-01 00:22:02 -04:00
Michael DeHaan
8700de964c Teach the common module code to warn users about typo'd arguments and also set everything to None automatically such 
that code doesn't have to do a lot of params.get('foo', None) everywhere.
 2012-07-31 21:23:34 -04:00
Lorin Hochstein
9bcc18d17b Apt module: add update-cache as alias of update_cache 
This will ensure users of previous versions of this module don't
have their playbooks break.
 2012-07-31 09:56:36 -04:00
Michael DeHaan
d79900b434 Merge pull request #732 from willthames/fix_git_fail_json 
Fixes for git module when it fails.
 2012-07-31 05:04:47 -07:00
Michael DeHaan
89ef236e9c Merge pull request #733 from willthames/copy_to_directory 
Allow copy dest argument to be a directory
 2012-07-31 05:03:50 -07:00
Michael DeHaan
a8d13fe40d Merge pull request #735 from nix85/fix_ohai_mod 
Changed funtion name to get_ohai_data
 2012-07-31 05:02:44 -07:00
Petros Moisiadis
24c1d32120 added extra arguments for database creation 
mysql_db: added 'encoding' and 'collation' args
postgresql_db: added 'owner', 'template' and 'encoding' args
 2012-07-31 12:56:29 +03:00
Nikhil Singh
526a0b1f60 Changed funtion name to get_ohai_data 2012-07-31 13:07:53 +05:30
u348095
3cb51acd78 Allow copy dest argument to be a directory 
Could have used shutil.copy rather than shutil.copyfile, but this
implementation preserves the md5 comparison to avoid unnecessary copies
 2012-07-31 14:47:01 +10:00
u348095
e863ba0cec Fixes for git module when it fails. 
* module.fail_json *must* have msg argument
Using http://github.com/ rather than git://github.com/ as it gets through more
firewalls
 2012-07-31 12:59:22 +10:00
Michael DeHaan
ce5f3dd148 Port the file module over to the new common code infrastructure + cleanup some redundant imports since the module code already imports those things. 2012-07-30 21:50:32 -04:00
Michael DeHaan
d0f6410326 Porting the virt module to new module core. 2012-07-30 21:16:29 -04:00
Michael DeHaan
6b72804cb4 remove unneeded imports 2012-07-28 17:15:07 -04:00
Michael DeHaan
d0a5dec686 Port setup module to use the common module base 2012-07-28 17:14:23 -04:00
Michael DeHaan
d79ba6f2aa Port the ohai module over, while this is actually *longer* now, not transferring the args file makes this much 
faster.
 2012-07-28 17:07:55 -04:00
Michael DeHaan
5fd2018117 Convert authorized_key modules to use new common code + misc style things 2012-07-28 17:03:10 -04:00
Michael DeHaan
63459110c4 Merge pull request #730 from marktheunissen/mysql_change_params 
Changing the parameter names to be consistent, and adding root user
 2012-07-30 15:50:40 -07:00
Mark Theunissen
9a1265b856 Changing the parameter names to be consistent, and adding root user default with empty password, as per mysql standard 2012-07-30 17:15:24 -05:00
Michael DeHaan
47cead3603 Merge pull request #727 from sfromm/git 
Git module ported to use module magic
 2012-07-30 13:40:36 -07:00
Michael DeHaan
d0f0315c9d Merge pull request #723 from skvidal/devel 
fix trace-creating error in apt module - also make the default setting a...
 2012-07-30 10:45:42 -07:00
Seth Vidal
21a35bde00 new patch - adds a 'boolean' function to the module_common class and cleans up 
the apt module to use it
 2012-07-30 13:41:42 -04:00
Seth Vidal
c4c53d545a fix trace-creating error in apt module - also make the default setting actualy work 2012-07-30 13:07:19 -04:00
Petros Moisiadis
4ad0ff61e5 added a 'chdir' argument to the command module 
the 'chdir' argument changes the current working directory to the
fullpath supplied as its value, before the execution of the command.
 2012-07-30 18:39:45 +03:00
Stephen Fromm
87b3e1ecdc Update git module to use module magic and other changes 
Convert git module to module magic.
Drop cruft no longer needed.
Standardize indent to 4 spaces in methods switchLocalBranch, reset,
clone, and get_version.
Update is_local_branch to also handle '* branch' format.
Add is_current branch method()
Update pull() method to use is_current_branch()
 2012-07-29 22:39:19 -07:00
Lorin Hochstein
dcd214a631 Use standard argument names in PostgreSQL modules 
passwd -> password
loginpass -> login_password
loginuser -> login_user
loginhost -> login_host

Add an example playbook that shows how to use the modules.
 2012-07-29 12:52:14 -04:00
Lorin Hochstein
a9c2e597ac Fix typo in apt error message: update-cache -> update_cache 
The apt parameter changed from update-cache to update_cache, but
the error message still mentioned update-cache
 2012-07-29 12:29:00 -04:00
Michael DeHaan
ff82f0a168 Further service module tweaks 2012-07-28 16:48:04 -04:00