Commit graph

28 commits

Author SHA1 Message Date
Michael DeHaan
c8e1a2077e file extensions! 2014-09-26 10:37:56 -04:00
Michael DeHaan
417309a626 Restructuring. 2014-09-26 10:13:26 -04:00
Michael DeHaan
73123b69fa Move modules into subdirectory. 2014-09-26 09:23:50 -04:00
Wayne Rosario
7cfef577a1 Adding the following Test Coverage:
Use mysql_user module to create, delete users.
Update user password and ensure new password was updated for the correct user.
Assert user has access to multiple databases
Assert user creation, deleting using different user privilege and ensure privilege work correctly.
2014-07-29 11:49:53 -04:00
Wayne Rosario
45d7e53da9 updating doc to include revoke example for mysql_user docs 2014-07-24 10:32:28 -04:00
Mathieu Martin
9589ee2a41 Add example 'Specify grants composed of more than one word' to the mysql_user module. 2014-05-20 14:41:18 -04:00
Cristian Ciupitu
7f681c33a2 Micro-optimization: replace s.find(x)!=-1 with x in s
timeit shows a speedup of ~3x on Python 2.7.5 x86_64.
It also makes the code a bit shorter.
2014-03-16 13:10:28 -04:00
David Busby
ab8d5c5924 Documentation update to yield example of "WITH GRANT OPTION" which is undocumented previous 2014-01-14 12:04:32 +00:00
James Tanner
4f9aadcc07 Addresses #5023 Fix import comments 2013-12-02 15:13:49 -05:00
James Tanner
38edad70ac Fixes #5023 Convert all modules to use new snippet import pattern 2013-12-02 15:11:23 -05:00
Michael DeHaan
4c35b7f380 There's a cleaner way to do this, commit to module formatter pending.
Revert "No longer need to reference 'version_added' in docs for these, as this was quite a while ago."

This reverts commit ff0a41d446.
2013-11-27 21:23:03 -05:00
Michael DeHaan
9e4d71203d No longer need to reference 'version_added' in docs for these, as this was quite a while ago. 2013-11-27 21:19:32 -05:00
James Tanner
251b52bef8 Fixes #4454 Make a temporary clean cnf file if unable to parse existing 2013-10-18 17:42:40 -04:00
Michael DeHaan
daa005085d Add missing version_added doc to mysql login port parameter. 2013-10-11 09:14:14 -04:00
Jeroen Hoekx
19b52e9fb7 Add append_privs parameter to MySQL user module.
This adds the privileges given to the existing list of privileges
instead of overwriting any existing ones.
2013-10-03 14:57:01 +02:00
James Cammarata
619a80c505 Merge branch 'devel' of https://github.com/tomdymond/ansible into tomdymond-devel 2013-09-23 14:53:46 -05:00
James Cammarata
0eaae4ac9c Cleaning up whitspace issues in the mysql_user module 2013-09-06 10:51:53 -05:00
John Hamelink
266255640e Fixed #3767 - mysql_user command fails with dots (and underscores) in
database names.
2013-09-06 10:51:53 -05:00
Tom Dymond
b3646176a9 Add option to specify the MySQL server port 2013-09-05 16:25:34 +01:00
Michael DeHaan
fab11537b1 Merge pull request #3691 from stoned/mysql_user-doc-fix
module mysql_user: fix 'state' parameter description
2013-08-01 17:25:21 -07:00
Stoned Elipot
a0ce78e6e5 module mysql_user: fix 'state' parameter description 2013-07-29 23:50:17 +02:00
Stijn Tintel
7102503bb2 Only revoke GRANT OPTION when user actually has it
When revoking privileges from a user, the GRANT OPTION is always
revoked, even if the user doesn't have it. If the user exists, this
doesn't give an error, but if the user doesn't exist, it does:

mysql> GRANT ALL ON test.* TO 'test'@'localhost';
Query OK, 0 rows affected (0.00 sec)

mysql> REVOKE GRANT OPTION ON test.* FROM 'test'@'localhost';
Query OK, 0 rows affected (0.00 sec)

mysql> REVOKE GRANT OPTION ON test.* FROM 'test'@'localhost';
Query OK, 0 rows affected (0.00 sec)

mysql> REVOKE ALL ON test.* FROM 'test'@'localhost';
Query OK, 0 rows affected (0.00 sec)

mysql> REVOKE GRANT OPTION ON test.* FROM 'test'@'localhost';
ERROR 1141 (42000): There is no such grant defined for user 'test' on
host 'localhost'

Additionally, in MySQL 5.6 this breaks replication because of
http://bugs.mysql.com/bug.php?id=68892.

Rather than revoking the GRANT OPTION and catching the error, check if
the user actually has it and only revoke it when he does.
2013-07-23 13:00:29 +02:00
Michael DeHaan
23e9e5c028 Add version_added information to module parameter. 2013-07-20 12:33:42 -04:00
Andrew de Quincey
28ec499f2a Check if mysql allows login as root/nopassword before trying supplied credentials. 2013-07-01 11:56:04 +01:00
Michael DeHaan
653d78c23d Merge pull request #3177 from stintel/mysql56-compat
Fix MySQL 5.6 compatibility
2013-06-16 19:27:17 -07:00
Jan-Piet Mens
3404a0fc16 DOCS: standardize on EXAMPLES (a.k.a. Docs-JumboPatch JetLag Edition)
Migrated all examples: in DOCUMENTATION=''' string to standalone EXAMPLES=''' string
  Added deprecation warning to moduledev.rst and remove deprecated example from it
  Fixed up a few typos and uppercased some acronyms.
  add consistency to how EXAMPLES are formatted
2013-06-15 20:54:25 +02:00
Stijn Tintel
66ffef5967 Fix MySQL 5.6 compatibility
In MySQL 5.6, the root account created by default during MySQL
installation has the PROXY ... WITH GRANT OPTION privilege for ''@'',
that is, for all users.

The mysql_user module tries to revoke this privilege, but this fails:
_mysql_exceptions.ProgrammingError: (1064, "You have an error in your
SQL syntax; check the manual that corresponds to your MySQL server
version for the right syntax to use near '''@'' FROM 'root'@'localhost''
at line 1")

Quick fix: don't revoke privilege if user is root and the privilege to
revoke contains PROXY.
2013-06-11 15:00:14 +02:00
Michael DeHaan
cd97a4cb14 Allow modules to be categorized, and also sort them when generating the documentation. 2013-04-28 15:03:45 -04:00
Renamed from mysql_user (Browse further)