Matt Parker
dc634bc644
Name appears to be a required parameter
...
As far as I can tell, `name` is a required parameter. The guard test at (now) line 458 says you need name if `state == present` and at 464 if `state != present`, although that's not quite as clear. Each of the code paths at 485 - 495 pass the name param through to `add_job`, `update_job` and `remove_job`, and the actual _update_job method earlier seems to require it too. However I don't really know python so I may be wrong, but I can't see the circumstances when `name` is not required.
2014-08-25 10:23:54 +01:00
Chris Church
57dee4545b
Make sure cmd is UTF8 encoded before splitting. Fixes regression introduced by 80df2135e9
.
2014-08-24 21:06:21 -04:00
Brian Coca
f6e10b580e
now acl expands tildes
2014-08-24 19:16:15 -04:00
Eric D. White
f44125ccb7
Issue 8735 - module docker - expose values should be striped to ensure port forwarding works.
2014-08-24 21:07:26 +01:00
Johann Schmitz
9945a732f7
Hostname strategy implementation for OpenRC based systems (e.g. Gentoo)
2014-08-23 09:00:28 +02:00
George Yoshida
b2385870af
For content-disposition response header field, try to parse filename parameter even if it's not quoted.
2014-08-23 12:10:45 +09:00
Michael DeHaan
a419ffdf41
Make command warnings off by default to minimize surprises.
2014-08-22 16:12:48 -04:00
Michael DeHaan
b44e22aa68
Merge pull request #8722 from cmbaughman/devel
...
Bugfix: #8720 winrm.py: protocol.send_message() crashes with https
2014-08-22 15:53:09 -04:00
Michael DeHaan
7ffa9cecae
Docs for command warnings feature.
2014-08-22 15:37:07 -04:00
Michael DeHaan
fcb610dec4
Slightly trim down the warnings list based on some things being pretty common
...
for local usage.
2014-08-22 15:37:07 -04:00
Will Thames
ab8490d003
Added warnings to command module
...
Generate warnings when users are shelling out to commands
rather than using modules
Can be turned off on a per-action line with the documented
warn=False flag. Can be turned off globally using
command_warnings = False in ansible config file.
Print out warnings using the standard playbook callbacks.
Created some additional tests in TestRunner.test_command
and also a demonstration playbook.
2014-08-22 15:37:07 -04:00
Chris Baughman
07f12539ee
Bugfix: #8720 winrm.py: protocol.send_message() crashes with https
2014-08-22 15:09:48 -04:00
Michael DeHaan
f54665aa51
Merge pull request #7491 from hkariti/doc_group_vars_dir
...
Update docs to include directories inside group_vars
2014-08-22 15:09:37 -04:00
James Cammarata
6b3f7a82fb
Fixing bug with image/tag pulling in docker module
...
Fixes #8670
2014-08-22 14:08:40 -05:00
Michael DeHaan
3871eebfbb
Merge pull request #8441 from willthames/unarchive_dest_fix
...
Unarchive should work when parent directory is not writable
2014-08-22 15:05:42 -04:00
Will Thames
1787c29354
Improved inventory handling when inventory does not yet exist
...
Fixes #8324
Improves #7667
2014-08-22 14:49:09 -04:00
Michael DeHaan
b0e863b3f8
Merge pull request #8659 from willthames/rds_module_connection_fix
...
rds_module: Fix AWS connection
2014-08-22 14:45:27 -04:00
Michael DeHaan
3695c2bcab
Remove galaxy CLI tests that hit bitbucket as bitbucket is hanging tests - maybe replace with nice github examples later :)
2014-08-22 14:06:08 -04:00
Michael DeHaan
8a0045baad
Update tests for ansible-galaxy CLI additions.
2014-08-22 14:01:15 -04:00
Michael DeHaan
d87830e1cc
Merge branch 'galaxy_github_archive' of git://github.com/willthames/ansible into devel
...
Conflicts:
lib/ansible/utils/__init__.py
2014-08-22 13:58:50 -04:00
James Cammarata
311ec543af
If not specified, do not modify subnet/route_tables for ec2 VPCs
...
Also fixes a bug whereby any changes to the route_tables were not
properly reflected by setting changed=True.
Fixes #8666
2014-08-22 11:03:41 -05:00
James Cammarata
32a5c2bf48
Merge pull request #8721 from sergevanginderachter/syntax_check_avoid_blank_output
...
Avoid multiple blank lines with --syntax-check
2014-08-22 10:46:45 -05:00
James Cammarata
2e6f9804a5
Merge pull request #8716 from pborreli/typos
...
Fixed typos
2014-08-22 10:33:25 -05:00
James Cammarata
ae4af85eb7
Merge pull request #8715 from retr0h/bug/galaxy-syntax-error
...
Corrected a simple syntax error in galaxy
2014-08-22 10:31:28 -05:00
James Cammarata
d01188033f
Checking for localized versions of the su password prompt
...
Fixes #8681
2014-08-22 09:59:40 -05:00
Michael DeHaan
0286c31e85
Assume master branch for downloads if not specified.
2014-08-22 10:01:13 -04:00
Michael DeHaan
0cd40fc372
Remove debug
2014-08-22 09:58:27 -04:00
Michael DeHaan
d66bb47db7
Fixing a typo, still some more work to do on CLI.
2014-08-22 09:57:10 -04:00
Serge van Ginderachter
ad3d3c7379
Avoid multiple blank lines with --syntax-check
...
Only print a blank line between plays when also doing --list-hosts and/or
--list-tasks, otherwise this output just a long list of blank lines, one for
each play.
2014-08-22 15:32:08 +02:00
Pascal Borreli
fe40a7d88a
Fixed typos
2014-08-22 11:39:38 +01:00
John Dewey
39eb11a598
Corrected a simple syntax error in galaxy
2014-08-21 22:01:04 -07:00
Will Thames
850963790d
Allow roles to be installed from archives on github
...
Ensure that the automated scm determination for github.com
repos still copes with .tar.gz archive files.
Handling .zip archives is left as an exercise for the interested reader
2014-08-22 10:06:21 +10:00
Michael DeHaan
8e0af04c3b
Add TOC to galaxy docs.
2014-08-21 18:53:36 -04:00
Michael DeHaan
399fe32287
Clarify examples further.
2014-08-21 18:48:02 -04:00
Michael DeHaan
caf4e44be7
Replace examples for requirements file.
2014-08-21 18:26:40 -04:00
Michael DeHaan
2e95e21cad
Remove some debug in ansible-galaxy upgrades, one of which raises errors down some code paths.
2014-08-21 18:24:40 -04:00
Michael DeHaan
56ce56fdbe
Fix docs typo.
2014-08-21 17:22:39 -04:00
Michael DeHaan
90f09a5e56
update changelog
2014-08-21 17:17:35 -04:00
Greg Swift
5ecfe884b8
Extend wait_for module to support draining of active tcp connections
2014-08-21 16:15:59 -05:00
James Cammarata
3b19b83806
Add GovCloud region to list of regions for AWS
...
Fixes #8604
2014-08-21 16:12:51 -05:00
Michael DeHaan
bcb44276fe
Assume github.com URLs are git protocol if not specified.
2014-08-21 17:15:23 -04:00
Michael DeHaan
e7c0b95074
Work in progress on bin/ansible-galaxy changes testing.
2014-08-21 17:15:23 -04:00
Michael DeHaan
12ad110205
Add documentation for new ansible-galaxy role options in 1.8. Much rejoicing.
2014-08-21 17:15:23 -04:00
Michael DeHaan
68e21aa4b0
Add comments about what these new functions do.
2014-08-21 17:15:23 -04:00
Will Thames
6e9abefc11
Corrected bug where role_path was wrong for roles in subdirectories
...
Fixed role name for
- { role: 'lives/in/a/subdirectory' }
Should be 'lives/in/a/subdirectory', not just 'subdirectory'
2014-08-21 17:15:23 -04:00
Will Thames
bf9ea81c4b
Make galaxy work when API server not available
...
`ansible-galaxy init --offline ...` can create a role without
talking to the galaxy api server
`ansible-galaxy install ...` only needs to talk to the galaxy api
server for galaxy roles, not tar files or scm archives
Fixed a bug in command line role installation
2014-08-21 17:15:23 -04:00
Will Thames
31540246dd
Handle older git archive commands
...
Older git archive commands create tar archives even with a tar.gz
extension. So change it to always create tar archives and have
the install_role method cope.
Removed ssh roles from the test case as they don't work unless
you can connect to bitbucket via ssh and have your key there.
Corrected a minor typo in error messages
2014-08-21 17:15:23 -04:00
Will Thames
ada9074276
Allow installation of roles from yaml roles file
...
Added docs
Added more tests
Improved how roles are returned from the parsers
2014-08-21 17:15:23 -04:00
Will Thames
46b59b02ed
Friendly Role Names and roles from URLs
...
* Roles can now be given a friendly name as third field in role spec csv
* Roles can be installed from URL (not just from archived SCMs)
* Integration tests to demonstrate this
* Unit tests to ensure that role spec parsing works as expected
2014-08-21 17:15:23 -04:00
Will Thames
4803e923ff
Improved handling of role_version in repo_url_to_role_name
2014-08-21 17:15:23 -04:00