Commit graph

3233 commits

Author SHA1 Message Date
Pepe Barbe
4a9a6c81ac Check for database ownership 2012-08-22 12:20:51 -05:00
Pepe Barbe
9e275529d6 Typo 2012-08-22 12:19:55 -05:00
Pepe Barbe
511ab8697c Query for all active privileges instead
Use a different method to query for current 
privileges at the table and database level. 
This method is more robust if newer privileges 
are added in future versions and also supports the 
ALL wildcard.
2012-08-22 10:04:58 -05:00
Pepe Barbe
a7e1ca6a6f Add fail_on_user option
fail_on_user option can be used to ignore silently
if the user cannot be removed because of remaining
privilege dependencies to other objects in the 
database. By default it will fail, so that this new 
behavior won't surprise unsuspecting users.
2012-08-22 10:04:58 -05:00
Pepe Barbe
384839bfe1 Initial commit of change of semantics for module
The postgresql_user module has several drawbacks:
* No granularity for privileges
* PostgreSQL semantics force working on one
  database at time, at least for Tables. Which
  means that a single call can't remove all the 
  privileges for a user, and a user can't be
  removed until all the privileges are removed, 
  forcing a module failure with no way to 
  work around the issue.

Changes:
* Added the ability to specify granular privileges
  for database and tables within the database
* Report if user was removed, and add an option to 
  disable failing if user is not removed.
2012-08-22 10:04:57 -05:00
Dag Wieërs
a32ae49bb6 Handle special files just like normal files
As discussed in #923
2012-08-21 23:48:18 +02:00
Dane Summers
648f740b95 removed logger, removed superfluous mkdir 2012-08-21 16:10:17 -04:00
Dane Summers
fc9fd48843 added TODO for test scenarios to add 2012-08-21 13:59:39 -04:00
Michael DeHaan
1af0a4c303 Adds a thirsty=yes|no to the get_url module, such that if downloading a large file from the internet you can decide
whether to download it every time or not -- will replace only on change, or decide to not download.  The default
is thirsty=no which will not download every time by default.
2012-08-20 18:39:37 -04:00
Tim Bielawa
23ec079661 Fix setup module explosion when a route is empty. Closes #909 2012-08-19 21:19:07 -04:00
Michael DeHaan
e87697d602 Fix invalid usage or fail_json in apt module 2012-08-18 19:43:45 -04:00
Michael DeHaan
20d90d4c00 Apt module should accept 'absent', and 'present' like the yum module does. 2012-08-18 18:38:10 -04:00
Michael DeHaan
1330e66709 tweak service module pattern= logic so ./hacking/test-module does not give false positives 2012-08-17 20:26:22 -04:00
Michael DeHaan
260c2819be Merge pull request #902 from sfromm/issue719
Add pattern option to service module
2012-08-17 17:17:32 -07:00
Michael DeHaan
6f1f044566 Merge pull request #901 from dhozac/setup-ip
Work with tun and p2p interfaces
2012-08-17 17:10:59 -07:00
Michael DeHaan
b9880e38b8 Merge pull request #900 from lorin/pip-venv-bug
Retrieve pip path after creating virtualenv
2012-08-17 17:10:35 -07:00
Michael DeHaan
7ec431fa57 Merge pull request #898 from elventear/postgresql_user_py24
Fixes for postgresql_user to make it work with postgresql defaults and under Python 2.4
2012-08-17 17:09:35 -07:00
Stephen Fromm
32cb95e424 Add pattern option to service module
Adds ability to check service status based on pattern.  The pattern
is a simple string.  If a pattern is provided, the output of ps is
checked first.
2012-08-17 14:00:01 -07:00
Daniel Hokka Zakrisson
d1568b1ebb Work with tun and p2p interfaces 2012-08-17 22:08:04 +02:00
Lorin Hochstein
449ab0635b Retrieve pip path after creating virtualenv
Retrieve the pip path after creating a non-existent virtualenv.
Prevents the problem of using the wrong pip if virtualenv doesn't
exist yet.
2012-08-17 14:38:49 -04:00
Pepe Barbe
35e27fe1b2 Syntax change to make module compatible with Python 2.4 2012-08-17 10:37:02 -05:00
Lorin Hochstein
ac672f8331 Return both stdout and stderr on pip failures.
pip failure message sometimes (always?) go to standard out. Return
both standard out and standard error when there's a failure.
2012-08-17 11:32:47 -04:00
Michael DeHaan
51e85b4bde Make a more logical error when the command/shell module is used with no arguments. 2012-08-16 21:40:52 -04:00
Sundar Raman
62e082a1c7 (Re #882) Handle errors in get_interfaces
If there is an error in how interfaces are configured (or only one set, like IPv6),
the setup command should not error out.
2012-08-15 19:22:05 -04:00
Dane Summers
d5482f1320 support for subversion repositories 2012-08-15 09:04:17 -04:00
Jeremy Penner
fdf7f3ae6d Make easy_install module actually work.
mpdehaan requested in ansible/ansible#795 that globals be removed.
The response was to remove the lines with the word 'global', but not
the actual use of global variables.  Which makes the module break silently.
Updated to use local variables.
2012-08-14 23:31:13 -04:00
Michael DeHaan
e3ffe74c33 meaningless whitespace changes 2012-08-14 19:33:11 -04:00
Michael DeHaan
ffcd959e15 Can use fail JSON here, remove debug statement 2012-08-14 19:29:09 -04:00
Michael DeHaan
c62f404bde Fix aliases, package not found is not an error 2012-08-14 19:27:02 -04:00
Michael DeHaan
43aa54386e Merge branch 'devel' of https://github.com/skvidal/ansible into devel 2012-08-14 19:20:09 -04:00
Michael DeHaan
a102507a5c Merge pull request #866 from akhayyat/devel
setup: add type and default_ipv{4,6} to linux network facts
2012-08-14 16:19:14 -07:00
Michael DeHaan
91a4e33bd8 Merge pull request #876 from elventear/postgresql_fix
Changes to postgresql to support defaults settings and older psycopg2
2012-08-14 16:17:37 -07:00
Pepe Barbe
db957df5af Autocommit support for psycopg2 < 2.4.2 2012-08-14 17:12:09 -05:00
Pepe Barbe
dfce4a20a1 Fix using postgres default values
When initalizing a connection to psycopg2, in order to use the default
values, the keywords must be missing. So we use a dictionary as a kwarg
and include only the keywords that do not have an empty value on the
module parameters.
2012-08-14 17:11:53 -05:00
Seth Vidal
da26266ef3 fixes to yum module
include local_nvra
change the remove behavior to pretty much NEVEr error out if the pkg is not there (or anywhere)
2012-08-14 16:23:40 -04:00
Seth Vidal
5267b75c31 cover all of the edge cases with and without yum-utils installed.
it is possible those folks w/o yum-utils installed but with rhn-plugin
installed but w/o any rhn-certificates will still see an error msg.
they have 3 options:
1. remove rhn-plugin
2. enable some channels w/rhn certs
3. install yum-utils
2012-08-14 13:23:49 -04:00
Seth Vidal
ddb18cfd76 subprocess is already imported in module_common - no need for it here 2012-08-14 13:23:49 -04:00
Daniel Hokka Zakrisson
e79667bcad Fix spelling of architecture for non-x86 2012-08-14 15:57:54 +02:00
Ahmad Khayyat
a9ebe9cb2b setup: add type and default_ipv{4,6} to linux network facts 2012-08-14 01:37:14 -04:00
Michael DeHaan
498bebd03e update config code 2012-08-13 20:17:07 -04:00
Michael DeHaan
a8d51a1508 Merge pull request #859 from zecrazytux/bugfix/apt_repository
Bugfix/apt repository
2012-08-13 15:30:21 -07:00
Michael DeHaan
bca8ca955b Merge pull request #860 from goozbach/broken_mount
fixed missing module argument for mount module
2012-08-13 15:29:43 -07:00
Pepe Barbe
e33973e8ca Use Python 2.4 compatible syntax 2012-08-13 16:02:16 -05:00
Derek Carter
44138e8c07 fixed missing module argument for mount module 2012-08-13 15:20:36 -04:00
Sebastien Bocahu
c7ada98af0 Quote the repository string when appending it to the command line in the apt_repository module. 2012-08-13 19:36:08 +02:00
Sebastien Bocahu
41422e852c Add support for Debian in apt_repository 2012-08-13 19:23:53 +02:00
Sebastien Bocahu
b030d787fd Fixed scoping issue in apt_repository module. 2012-08-13 19:06:53 +02:00
Stephen Fromm
a991c43702 Try to find ip command in either /sbin or /usr/sbin
If ip is not found in either /sbin or /usr/sbin, this will return
an empty result.  It seems extremely unlikely that a linux system will
not have iproute2 installed
2012-08-11 23:54:22 -07:00
Stephen Fromm
da58114c87 Tweak invocation of ip in LinuxNetwork
Specify full path to ip and add third argument 'show' to be explicit
about requested action.  This goes from 'ip addr' to
'/sbin/ip addr show'.
2012-08-11 23:54:22 -07:00
Michael DeHaan
ed449ed3e2 Fix indentation 2012-08-11 18:39:09 -04:00