Commit graph

50 commits

Author SHA1 Message Date
James Cammarata
e47f6137e5 Push the expanduser call on the source down to slurp rather than fetch
Also moves the calculation of the destination file name until after
the slurp of the file contents, since the source as returned by slurp
may now be different, so we want to use that expanded path locally.

Fixes #8942
2014-09-23 15:32:07 -05:00
Will Thames
1a1272dfe7 get_url module: Add timeout parameter 2014-09-08 13:58:25 +10:00
George Yoshida
b2385870af For content-disposition response header field, try to parse filename parameter even if it's not quoted. 2014-08-23 12:10:45 +09:00
Brian Coca
c24956032d unified calls to fs function vs duplicate functions for file and
directory
2014-05-24 09:28:45 -04:00
James Cammarata
e3ee7787ed Remove erroneous set of status_code causing a traceback in module uri
Fixes #7416
2014-05-16 08:49:08 -05:00
Christian Berendt
2c39eff60e [get_url] check against lowered stripped sha256sum
The content of the sha256sum attribute should be lowered before comparing it with the calculated sha256sum.

In the following example the used sha256sum uses ABC.. and not abc.. and the check failed. This should not happen.

```
TASK: [get_url url=http://ftp.fau.de/apache/hadoop/common/hadoop-2.4.0/hadoop-2.4.0.tar.gz dest=/home/vagrant/hadoop-2.4.0.tar.gz mode=0644 sha256sum=024326AC68A1A68B5566B10F95609EAAFD9F70CFEB37FCA0E97CBB1674E57C3A] ***
failed: [instance000] => {"failed": true}
msg: The SHA-256 checksum for /home/vagrant/hadoop-2.4.0.tar.gz did not match 024326AC68A1A68B5566B10F95609EAAFD9F70CFEB37FCA0E97CBB1674E57C3A; it was 024326ac68a1a68b5566b10f95609eaafd9f70cfeb37fca0e97cbb1674e57c3a.

FATAL: all hosts have already failed -- aborting
```
2014-05-06 18:27:43 +02:00
James Cammarata
89fa9b7305 Add parameters to get_url for the url username/password
Fixes #6928
2014-04-24 00:26:50 -05:00
James Tanner
036c8193b7 Fixes #6857 Make the url parameter required for get_url 2014-04-04 16:36:38 -04:00
Michael DeHaan
18b713fd74 Example cleanup. 2014-04-02 17:32:44 -04:00
Sven Schliesing
fb10ca73dc Update uri 2014-03-31 14:32:56 +02:00
Sven Schliesing
d6943e46ef Example for queueing build in Jenkins 2014-03-31 14:32:07 +02:00
Michael DeHaan
8e27992335 Merge pull request #6649 from picsolvebryan/devel
Accept status code from a list of valid codes.
2014-03-28 11:49:04 -04:00
bryan hunt
aa2d6e47f0 Accept status code from a list of valid codes.
(cast the list of acceptable codes to a list of int )
2014-03-24 14:23:18 +00:00
bryan hunt
9ff6c40ed0 Accept status code from a list of valid codes. 2014-03-24 14:17:36 +00:00
bryan hunt
5d51837921 Accept status code from a list of valid codes. 2014-03-24 13:51:44 +00:00
James Cammarata
d8a81c488e Remove validate_certs parameter from fetch_url calls 2014-03-12 10:31:01 -05:00
James Cammarata
9730157525 Validate SSL certs accessed through urllib*
* Adds another module utility file which generalizes the
  access of urls via the urllib* libraries.
* Adds a new spec generator for common arguments.
* Makes the user-agent string configurable.

Fixes #6211
2014-03-10 16:06:52 -05:00
James Cammarata
cb79947054 Fixing the unicode issue in uri for EL6 platforms
Fixes #5869
2014-02-25 13:04:05 -06:00
James Cammarata
97eededc99 Handle unicode content in the uri module properly
Fixes #5869
2014-02-24 23:34:17 -06:00
Richard Isaacson
5a15762739 Merge pull request #5826 from romeotheriault/fix_follow_redirects
A fix for uri module regarding following redirects. The old behavior would follow redirects either way. This change clarifies the functionality and makes it a bit more explicit. Comparing the old behavior to the new 'yes' == 'all', 'no' == 'safe' and now 'no' will not follow any redirects. Historic behavior is still supported and documented with a push to the new values.
2014-02-07 11:36:51 -06:00
Eric Hanchrow
7e557663c2 Clarify doc for get_url
Move a sentence from doc for the "force" option to that for the "dest" option.
2014-02-05 10:58:48 -08:00
James Cammarata
77d5a18392 When force=yes, get_url should always download the specified file
This is accomplished by not setting the If-Modified-Since header,
and setting "cache-control: no-cache" instead. Note that if the
file content has not changed, the module will still report that
changed=false, as the md5's of the tmp file and existing file are
compared before swapping

Fixes #5104
2014-02-05 11:56:05 -06:00
Pedro Romano
30c8f514a2 Allow the 'PATCH' method in the 'uri' module since 'httplib2' allows it
and some APIs require it.
2014-02-02 20:53:52 +00:00
Romeo Theriault
8ea59e8ce5 fix following redirects 2014-01-29 14:04:53 -10:00
Michael DeHaan
83f43b82ad ansible -> ansibleworks 2014-01-28 20:29:41 -05:00
James Tanner
ad837709bd Addresses #5023 Fix import comments 2013-12-02 15:13:49 -05:00
James Tanner
6000d636b3 Fixes #5023 Convert all modules to use new snippet import pattern 2013-12-02 15:11:23 -05:00
Michael DeHaan
36effd237c There's a cleaner way to do this, commit to module formatter pending.
Revert "No longer need to reference 'version_added' in docs for these, as this was quite a while ago."

This reverts commit ff0a41d446.
2013-11-27 21:23:03 -05:00
Michael DeHaan
ff0a41d446 No longer need to reference 'version_added' in docs for these, as this was quite a while ago. 2013-11-27 21:19:32 -05:00
Michael DeHaan
f7c3975f21 Add version_added to all modules missing version_added information, the docs formatter will now
raise errors when omitted, updated changelog with new modules.
2013-11-18 18:55:49 -05:00
jctanner
3a5e689b80 Merge pull request #4785 from Tinche/get_url/uri-content-disposition
Modified the get_url module to respect the content-disposition header if...
2013-11-14 10:02:15 -08:00
Tin Tvrtkovic
ea60360449 Use the final URL from the finished request instead of the provided URL for filename generation, to properly deal with redirects. 2013-11-09 00:35:14 +01:00
James Laska
4013e94cf6 Correct documentation URLs 2013-11-08 15:02:45 -05:00
Tin Tvrtkovic
c85655f720 Modified the get_url module to respect the content-disposition header if the destination is a directory and the server provides it.
See http://www.w3.org/Protocols/rfc2616/rfc2616-sec19.html, section 19.5.1.
2013-11-02 17:23:59 +01:00
Michael Scherer
914226afc3 Fix issue 4433, make sure status is a int rather than a string 2013-10-12 22:10:40 +02:00
Joshua Lund
20489f1346 * Updated SHA-256 functionality in the get_url module
(fixes issue #4277)

* The sha256sum error message now displays the invalid
  destination checksum if it doesn't match the one that
  is specified in the arguments. This is useful for
  debugging purposes.

* Non-alphanumeric characters, including the infamous
  Unicode zero-width space, are removed from the sha256sum
  argument prior to the check.
2013-09-27 14:37:21 -06:00
Serge van Ginderachter
a311ee35b3 Fix bug in uri where redirect check fails.
When the redirect check fails, the 'status' key is not set in
resp_redir, so we need to check this.
2013-08-29 15:58:01 +02:00
Michael DeHaan
86ddbb224b Trim old style var references 2013-07-19 09:37:19 -04:00
Joshua Lund
0f81d1630f * Updated all ansible.cc references in the documentation to point
to ansibleworks.com
* Fixed a few misspelled words
2013-06-19 19:34:02 -06:00
Joshua Lund
bb4de94937 Removed merge conflict header 2013-06-18 15:01:01 -06:00
Michael DeHaan
2123507315 Merge branch 'sha256' of git://github.com/jlund/ansible into devel
Conflicts:
	library/network/get_url
2013-06-18 14:46:57 -04:00
Jan-Piet Mens
30d641094b Docs: consistently format playbook EXAMPLES 2013-06-17 08:53:46 +02:00
Jan-Piet Mens
5c69918d53 DOCS: standardize on EXAMPLES (a.k.a. Docs-JumboPatch JetLag Edition)
Migrated all examples: in DOCUMENTATION=''' string to standalone EXAMPLES=''' string
  Added deprecation warning to moduledev.rst and remove deprecated example from it
  Fixed up a few typos and uppercased some acronyms.
  add consistency to how EXAMPLES are formatted
2013-06-15 20:54:25 +02:00
Joshua Lund
37f15d0216 Setting version_added for this feature to 1.3 2013-06-07 11:37:41 -06:00
Joshua Lund
2ce7f136b2 * Added a sha256 method to module_common
* Added a sha256sum parameter to the get_url module to enable
cryptographic verification of downloaded files
* Fixed a few typos in the documentation
2013-06-04 23:28:28 -06:00
Michael DeHaan
6b0a547652 Docs standardization 2013-06-01 12:13:21 -04:00
Michael DeHaan
f9a14f0d70 Fixup fetch doc formatting. 2013-05-29 10:45:31 -04:00
James Martin
3c131dbd2b Initial Commit. 2013-05-23 13:33:36 -04:00
Piffey Parlance
99196024dd Fixed bug where if destination was unspecified, changed would not be set, resulting in an UnboundLocalError. 2013-04-29 13:59:06 -05:00
Michael DeHaan
391fb98ee2 Allow modules to be categorized, and also sort them when generating the documentation. 2013-04-28 15:03:45 -04:00