Commit graph

25760 commits

Author SHA1 Message Date
Brian Coca
cf6a92d268
use get_optoins instead of play_context for user (#52604)
fill in missing data
  fixes #52103
2019-02-26 12:08:17 -05:00
Brian Coca
514b974182
Loader invalid plugin nicer error (#52754)
* stop processing invalid plugins
2019-02-26 11:51:16 -05:00
Pilou
d8a2d64ec1 osx_say callback plugin: add espeak support, rename to say (#33740)
* rename into say

* add support for espeak command

* adds symlink from osx_say to say

* Update version number
2019-02-26 09:46:35 -06:00
Dag Wieers
2561fd7000
ACI: Add seealso sections to various modules (#52988) 2019-02-26 15:44:18 +01:00
Farhan Nomani
27804b3b8b Ansible module to enable the user to provision CPGs on HPE StoreServ 3PAR device (#39656)
* Added storage modules and unit tests

Removed unnecessary file

Fixing pep8 issues

Adding reusable documentation to the data fragment file

Fixing issues reported by module validation in documentation

Fixed issues: 10549, 10553

Fixed unit tests

Added future imports and removed license from init py file

Resolved import issue reported by ansible sanity test

Fixed unit tests

Adding CPG management module

Fixing sanity test issues

Resolving line ending issues

Resolved import issue reported by ansible sanity test

Correcting the error message when resource is more than 31 char

Update hpe3par_cpg.py

Fix for defect 10556: Unable to modify volume. Persona not set

Fix for defect 10556: Unable to modify volume. Persona not set

Fixing pep8 changes

Fixed pep8 issues

Added more pep8 related fixes

Added more pep8 related fixes

Fixed rebase issue in cps test

Adding GPL3.0+ License (#7)

* Update hpe3par.py

* Update hpe3par_cpg.py

* Update hpe3par_cpg.py

Adding GPLV3+ only license

Fix anity test

Addressing review comments

Fixing undefined variable error

Addressed review comments and added more unit tests (#8)

Added maintainers

Fixed sanity test

Update test_hpe3par_cpg.py

Renamed the module as per the review comments (#9)

* Added maintainers

* Renaming the module to remove the vendor name from the module

* remove pep8 related issues

Modify the requirements to add version of 3par sdk

Review address (#10)

* Unit is no longer a different paramter in the task

* Fixing unit tests

* Taking into account the default values

Fixing issue with default values

fixing unit test

Adding more flexibility and checks to the size and it's units

Fixed pylint extra line issue

Fixing conflicts in BOTMETA.yml

Made changes according to the review comments

Updating ansible version

Refactored the code to move reusable method to module utils

Modified the GPLv3+ license text according to the review comments. Modified the module utils license to BSD

Corrected the BOTMETA entry. Fixed the pep8 issues

Fixing entries in BOTMETA.yml

Removed ansible version, renamed the version to address the name review comments

Reverting name change for module to revert test failures

Set size and raid type and now reuqired together based on the review comment

Fixed unit tests

Removing default value as raid and set size are now required together

Renaming the modules to ss_3par_*

Resolving the pep8 issues

Added storage modules and unit tests

Removed unnecessary file

Fixing pep8 issues

Adding reusable documentation to the data fragment file

Fixing issues reported by module validation in documentation

Fixed issues: 10549, 10553

Fixed unit tests

Added future imports and removed license from init py file

Resolved import issue reported by ansible sanity test

Fixed unit tests

Adding CPG management module

Fixing sanity test issues

Resolving line ending issues

Resolved import issue reported by ansible sanity test

Correcting the error message when resource is more than 31 char

Update hpe3par_cpg.py

Fix for defect 10556: Unable to modify volume. Persona not set

Fix for defect 10556: Unable to modify volume. Persona not set

Fixing pep8 changes

Fixed pep8 issues

Added more pep8 related fixes

Added more pep8 related fixes

Fixed rebase issue in cps test

Adding GPL3.0+ License (#7)

* Update hpe3par.py

* Update hpe3par_cpg.py

* Update hpe3par_cpg.py

Adding GPLV3+ only license

Fix anity test

Addressing review comments

Fixing undefined variable error

Addressed review comments and added more unit tests (#8)

Added maintainers

Fixed sanity test

Update test_hpe3par_cpg.py

Renamed the module as per the review comments (#9)

* Added maintainers

* Renaming the module to remove the vendor name from the module

* remove pep8 related issues

Modify the requirements to add version of 3par sdk

Review address (#10)

* Unit is no longer a different paramter in the task

* Fixing unit tests

* Taking into account the default values

Fixing issue with default values

fixing unit test

Adding more flexibility and checks to the size and it's units

Fixed pylint extra line issue

Fixing conflicts in BOTMETA.yml

Made changes according to the review comments

Updating ansible version

Refactored the code to move reusable method to module utils

Modified the GPLv3+ license text according to the review comments. Modified the module utils license to BSD

Corrected the BOTMETA entry. Fixed the pep8 issues

Removed ansible version, renamed the version to address the name review comments

Reverting name change for module to revert test failures

Set size and raid type and now reuqired together based on the review comment

Fixed unit tests

Removing default value as raid and set size are now required together

Renaming the modules to ss_3par_*

Resolving the pep8 issues

Update lib/ansible/modules/storage/hpe3par/ss_3par_cpg.py

Co-Authored-By: farhan7500 <farhan7500@gmail.com>

Update lib/ansible/modules/storage/hpe3par/ss_3par_cpg.py

Co-Authored-By: farhan7500 <farhan7500@gmail.com>

Fixed rebase issue

Fixed rebase issuein BOTMETA.yml

* Modified the documentation based on the review comments

* Fixed the pep8 sanity issue

* Moved the doc fragment file based on latest changes

* Reverting inadvertent rebase changes

* Fixed inadvertent change during rebase
2019-02-26 14:09:03 +00:00
Dag Wieers
076562e5c2
ACI: Various changes and doc updates (#52957)
* ACI: Various changes and doc updates

* Fix typos
2019-02-26 14:55:40 +01:00
Felix Fontein
bf3c291606 docker_swarm: add diff support (#52947)
* Add diff support to docker_swarm.

* Add changelog.

* Using diff mode for docker_swarm tests. This improves debugging, since the the module now outputs more information on *why* it did certain actions.
2019-02-26 11:57:02 +00:00
Ondra Machacek
84cc5202db Add kubevirt_template module (#52528)
* Apply suggestions from code review

Co-Authored-By: machacekondra <machacek.ondra@gmail.com>
2019-02-26 17:24:49 +05:30
Felix Fontein
42ae6cdb95 docker_swarm: fix idempotency (#52976)
* Improve idempotency checking: only consider parameters which are part of the generated spec.

* Properly handle rotate_worker_token and rotate_manager_token.
2019-02-26 11:46:43 +00:00
Dawson Mortenson
6f585b6ee9 terraform: patch state 'planned' outputs and perform minor refactor (#52004)
* patch state 'planned' outputs and perform minor refactor

* reconcile with pep8 and pylint

* remove a space...

* update changed to only flip when >0 added, changed, or destroyed is detected

* add state dependecy to conditional change check

* fix typo

* reconcile with pep8[E317]

* add a changelog fragment
2019-02-26 11:39:13 +00:00
Ondra Machacek
48187d5659 Add firewall and gluster tuned options to oVirt cluster (#52655) 2019-02-26 06:00:11 -05:00
Martin Nečas
73e7a12c4f Ovirt skip fencing gluster (#52580)
* add fencing options for ovirt cluster

* add version_added to ovirt_cluster module

* add description of fencing options
2019-02-26 05:47:23 -05:00
Chris Van Heuveln
0df5b92af3 nxos_command:run_commands results failure when commands array size >1 (#52670) 2019-02-26 12:01:13 +05:30
Jordan Borean
d55ddec923
Revert Clear failed state in always only if we did rescue (#52968)
* Revert "Clear failed state in always only if we did rescue (#52829)"

This reverts commit f135960fc2.

* Add tests for failed scenario

* Set failed task with EXPECTED FAILURE
2019-02-26 16:22:32 +10:00
Zim Kalinowski
344a81daec
Adding DTL VM facts (#52692) 2019-02-26 10:45:39 +08:00
Dag Wieers
b808b06607
ACI: Fix examples in documentation (#52958)
* ACI: Fix examples in documentation

* Fix typo
2019-02-26 03:00:00 +01:00
Jordan Borean
13f8f1481f
Ansible.Basic - Support a delegate type for option elements key (#52951) 2019-02-26 08:14:10 +10:00
AndyG
fe7cbc2554 Update ec2_elb_lb.py (#52729)
*Calls out that the module can update as well as create and delete ELBs

Co-Authored-By: biohazd <biohazd@users.noreply.github.com>
2019-02-25 15:56:24 -06:00
Andrea Scarpino
f5c0ae82fc redshift_subnet_group: improve error message (#52900)
Adds more detail to region-not-specified error.
2019-02-25 15:43:09 -06:00
Brian Coca
40a053ce78
better error for bad module options (#52726)
also document clearly inline vaults don't work on 'options'
  fixes #52707
2019-02-25 15:58:51 -05:00
Rémi REY
30b3ce0f81 Add aws_secret module for managing secretsmanager on AWS (#48486)
* Adding module for managing AWS Secrets Manager resources

* adding aws_secret lookup plugin

Also use the data returned by describe_secret everywhere.

* replace the explicit /root use by a temporary dir

* aws_secret: rework module

Reworked module to use a class avoiding using client and module in every
functions.

* Added support of "recovery_window" parameter to allow user to provide
recovery period.

* updated return value to be the api output providing more details about
  the secret.

* Fix Python 3 bug in tests if the role is not removed

* Add unsupported alias due to issue restricting resource for creating secrets
2019-02-25 14:27:33 -06:00
Felix Fontein
4eb9c591d7 Accidentally included q.q. (#52946) 2019-02-25 14:07:27 -06:00
Abhijeet Kasurde
c3777a6e54
VMware: add missing fact about IP network in firewall facts (#52554)
Fixes: #52526

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-02-25 22:43:25 +05:30
Jonathan Brown
681082e47c Unixy stdout callback: Display name of play and list of play hosts, don't display play name if no hosts in play (#32810) 2019-02-25 11:57:29 -05:00
Andrew Gaffney
e287b35f69 Turn 'actionable' into a thin wrapper for 'default' (#52908)
The 'default' action plugin now implements this functionality, so the
'actionable' plugin doesn't need any of its own logic (which was
interacting poorly with the new 'default' plugin logic to do the same
things). This fixes #51533 and #47353
2019-02-25 11:55:46 -05:00
Miguel Angel Muñoz González
840698ce05 Fortinet's FortiOS ssh filter profile (#52720) 2019-02-25 14:24:12 +00:00
Theron Savery
1f7ffe2619 NSO - added validate_certs parameter to allow for ignoring of SSL certificates (#51981)
* added validate_certs paramter to allow for ignoring of SSL certificates

* formatting

* updated NSO unit tests with validate_certs variable

* fixed NSO tests
2019-02-25 14:17:56 +00:00
Miguel Angel Muñoz González
1563dc32e8 Fortinet's FortiOS spamfilter profile (#52718) 2019-02-25 14:16:28 +00:00
Miguel Angel Muñoz González
3d2d324476 Fortinet's FortiOS switch controller global (#52803) 2019-02-25 14:15:49 +00:00
Miguel Angel Muñoz González
1d5972a9fe Fortinet's FortiOS switch controller lldp profile (#52805) 2019-02-25 14:15:28 +00:00
Miguel Angel Muñoz González
07c69c2663 Fortinet's FortiOS switch controller lldp settings (#52807) 2019-02-25 14:14:24 +00:00
Miguel Angel Muñoz González
0665832316 Fortinet's FortiOS switch controller mac sync settings (#52808)
* Fortinet's FortiOS switch controller mac sync settings

* Updated doc
2019-02-25 14:14:05 +00:00
Miguel Angel Muñoz González
f9afecb065 Fortinet's FortiOS switch controller managed switch (#52809) 2019-02-25 14:13:51 +00:00
Miguel Angel Muñoz González
ca5299890e Fortinet's FortiOS switch controller network monitor settings (#52810) 2019-02-25 14:13:39 +00:00
Miguel Angel Muñoz González
eb851b14b3 Fortinet's FortiOS system dhcp server (#52812) 2019-02-25 14:13:23 +00:00
Andrey Klychkov
be75c79941 New module postgresql_query (#52555)
* New module postgresql_query

* New module postgresql_query: added tests

* New module postgresql_query: added path_to_script

* New module postgresql_query: fix doc

* New module postgresql_query: fix autocommit

* New module postgresql_query: added exception for centos6 tests

* New module postgresql_query: fixes

* New module postgresql_query: add psycopg2 check

* New module postgresql_query: add psycopg2 check, fix

* New module postgresql_query: add psycopg2 check, fix

* New module postgresql_query: add psycopg2 check, fix

* New module postgresql_query: fix a type
2019-02-25 14:08:04 +00:00
Dag Wieers
3ced545d06
validate-modules: Fix some files modules (#52440)
This PR includes:
- fixes to validate-modules issues

All modules already include parameter types.

The remaining files-modules have action plugins, so comparing to the arg_spec only is incorrect.
2019-02-25 13:29:31 +01:00
Dag Wieers
4670e41a30
validate-modules: Fix net_tools modules (#52489)
This PR includes:

* Fixes to open validate-modules issues
* Adding parameter types
2019-02-25 13:27:35 +01:00
Ganesh Nalawade
cb67235eab
Fix network config module invalid src option error (#52912)
Fixes #52911

Raise AnsibleError execption if the file
path mentioned in src option in not found or
failed to load
2019-02-25 16:46:33 +05:30
James E. King III
f2495ef0d3 Add ability to get vmware_guest_facts using vsphere schema output (#47446) 2019-02-25 06:03:40 -05:00
Rhys Campbell
7f50f467fe mongodb_replicaset module and test exception (#49690)
* Clean up from previous fork

* Minor doc update

* Fix doc string return type

* Minor doc updates

* Keeping fresh

* Various changes to documentation, cosmetics and code logic

Please test :-)

* Fix typo

* Various small changes as requested

* Remove traceback ref

* try catch changes

* Tidy description

* Correct data type in documentation

* Fix for 4.0
2019-02-25 11:52:07 +01:00
Abhijeet Kasurde
46d869e7bd VMware: new module: vmware_dvs_portgroup_facts (#45116)
* VMware: new module: vmware_dvs_portgroup_facts

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>

* Review comments

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-02-25 05:47:09 -05:00
Abhijeet Kasurde
1a8332d2cd VMware: new module: vmware_guest_customization_facts (#38588)
This module gathers facts about customization specification created
for virtual machine.

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-02-25 04:32:56 -05:00
Jose Angel Munoz
e729ad56a0 Fixing VMWare Guest Disk Creation when Using Template (#52676) 2019-02-25 14:43:53 +05:30
Christian Kotte
2f44ac4edc VMware: Fix module vmware_host (#46225)
* Add folder_name alias

The parameter should be named folder_name instead of folder to be
consistent with the other parameters cluster_name and datacenter_name.

* Fix 'A specified parameter was not correct: cnxSpec' error

The play fails when re-connecting a host with the cnxSpec argument
defined.

Just remove the cnxSpec argument definition. It isn't necessary when
re-connecting an existing host in vCenter (6.5).

* Fix ESXi host add/remove/re-connect errors

An ESXi host cannot be added, removed, or re-connected under a folder.

ESXi hosts connected under a folder, instead of a cluster, have an
object type of ComputeResource instead of HostSystem and the HostSystem
object is the first entry in the host parameter list of the
ComputeResource object.

Separate between cluster and folder actions.
2019-02-25 14:08:33 +05:30
Jake Hill
e18d5ea8b3 VMware: Add support in VMWare modules for BIOS and instance UUID's (#44399)
* Add support for changing UUID type referenced
* Update all appropriate VMware modules to include UUID type
* Add integration test for filtering on instance UUID
2019-02-25 14:07:07 +05:30
Martin Krizek
f135960fc2
Clear failed state in always only if we did rescue (#52829)
Fixes #52561
2019-02-25 09:30:17 +01:00
Felix Fontein
a1ec307d43 docker_swarm: make labels work with older docker daemon versions (#52895)
* Make labels work with older docker daemon versions.

* Fix idempotence detection.

* Add changelog.
2019-02-25 08:16:09 +00:00
Nicolas Singh Oteiza
e599f5aabe Add docker_prune sample to remove everything, including non-dangling images (#52744)
* Update docker_prune.py

##### SUMMARY
Add example to remove everything, including non-dangling images


##### ISSUE TYPE
- Docs Pull Request

+label: docsite_pr

* fix indentation

* Update lib/ansible/modules/cloud/docker/docker_prune.py

Co-Authored-By: nicosingh <nicolas.singh@gmail.com>
2019-02-25 08:15:15 +00:00
Mario Lenz
bcd6702b8a VMware: Fix KeyError in vmware_host_config_manager (#52736)
* Bug fix for vmware_host_config_manager

* Update changelogs/fragments/44561-vmware_host_config_manager-fix_key_error.yml

Co-Authored-By: mariolenz <m@riolenz.de>
2019-02-25 13:27:49 +05:30