Commit graph

9945 commits

Author SHA1 Message Date
Tobias Wolf
3a00d2bb38 Add diff support to apt_repository module
The returned list of diffs aims to simulate how a file system diff would
look before and after writing the sources list files.

![screenshot](http://i.imgur.com/dH6QXtY.png)

n.b. Ternary conditional  is due to failing integration test for
python 2.4
2016-12-08 11:24:10 -05:00
Constantin07
33079b2b7f Treat 'is_public' option as a bool 2016-12-08 11:24:10 -05:00
Andrey Gubarev
edde3b49cf update docker_image's path param type to 'path'. Fixes #3175 2016-12-08 11:24:10 -05:00
moyashiki
96ce498b77 Fix ios_command fix
This is not valid YAML commands. So fix it.
2016-12-08 11:24:10 -05:00
Sam Wilson
0bd95d0f2d Fixed BOOLEANS rendering in docsite 2016-12-08 11:24:10 -05:00
Peter Sprygada
1f4625938e refactor arguments in ops_template
This commit refactors the arugments used in ops_template to be strictly
typed and handle by declarative / rest and cli based configurations.  It
also removes old arguments not supported and cleans up the documentation
strings
2016-12-08 11:24:10 -05:00
curious-eyes
e16367739e Fix #2761: gce.py - UnboundLocalError: local variable 'md' 2016-12-08 11:24:10 -05:00
davidobrien1
072c68ea79 Restore filter on Windows and version reference for Windows facts. 2016-12-08 11:24:10 -05:00
davidobrien1
a874e1e25e Change fact invocation from dotsourcing to ampersand so that scripts do not execute in global scope. 2016-12-08 11:24:10 -05:00
Stefano Mazzucco
04e9677ae0 'executable' and 'virtualenv' mutually exclusive
fixes https://github.com/ansible/ansible/issues/14415
2016-12-08 11:24:09 -05:00
Tom Bamford
1cace51ed6 Bugfix: Permit SOA record type 2016-12-08 11:24:09 -05:00
Gary Rybak
5ff79d0596 Add filter to eos_template to remove configuration mode command followed immediately by an exit command indented one level. 2016-12-08 11:24:09 -05:00
callipeo
4331fcae34 Add support for both keyserver and keyring in apt_key
Fixes Issue #2996
2016-12-08 11:24:09 -05:00
David O'Brien
ce7a86b4ce Add documentation to setup.py and remove use of $params.fact_path in setup.ps1 2016-12-08 11:24:09 -05:00
Ryan-Neal Mes
2fa3f16012 Indented code so it only executes tag comparison for matching cird values 2016-12-08 11:24:09 -05:00
Tobias Gesellchen
db14b544a5 add env_file support (original code from @vpetersson) 2016-12-08 11:24:09 -05:00
Matt Clay
53b0fd65ee Split shell command to avoid use_unsafe_shell.
This mirrors a nearly identical change made to apt_repository.py.

Also removes the use of apt-get --force-yes as it can be dangerous
and should not be necessary (apt_repository.py does not use it).

Repeating the explanation from the apt_respository change below:

Since use_unsafe_shell is suspicious from a security point
of view (or it wouldn't be unsafe), the less we have, the less
code we have to thoroughly inspect for a security audit.

In this case, the '&&' can be replaced by doing 2 calls to run_command.
2016-12-08 11:24:09 -05:00
Tobias Wolf
75e8b365b4 Add supports_check_mode=True to mysql_db module
The most important cases are state=present and state=absent.

Future work: import and dump could be simulated and hence checked.
2016-12-08 11:24:09 -05:00
Kanwei Li
a2a3d2fc06 Add new Dv2 Azure instances 2016-12-08 11:24:09 -05:00
Bert Van Vreckem
4a10eeb196 Also show stdout when validation fails. This fixes #2498 2016-12-08 11:24:09 -05:00
Jonathan Mainguy
44bde46097 Add ability to download deb from url
if :// in deb, will try to download from url.
2016-12-08 11:24:09 -05:00
nitzmahone
3abdfb1712 mark failed async_status as finished
Running async_status in an "until: result.finished" loop will mask a module failure (eg, traceback) with a
template failure, because the fail dict doesn't include "finished" (eg, you'll see "ERROR! The conditional check 'bogus_out.finished' failed. The error was: ERROR! error while evaluating conditional: bogus_out.finished ({% if bogus_out.finished %} True {% else %} False {% endif %}"). Because the failure dict still includes "failed: true",
this change has no effect on stoppage/failure reporting, it just prevents the common usage pattern from masking the underlying error message.
2016-12-08 11:24:09 -05:00
Will Thames
52accd7d1f Use connect_to_aws where possible
`connect_to_aws` fixes a bug with security tokens in AWS.
Modules should use that rather than calling
`boto.x.connect_to_region`
2016-12-08 11:24:09 -05:00
Tim Alkemade
be19982313 GCE module does not fetch disk images if not necessary 2016-12-08 11:24:09 -05:00
Matt Martz
b85d3f32da Add get_checksum option to win_stat to work with new use of the stat module for checksumming 2016-12-08 11:24:08 -05:00
Toshio Kuratomi
9551e51607 At least for now, set body to raw as it can be either a dict or jsonified-str
Since our validation does conversion as well as validation, I'm not sure
this is entirely correct.  May need to take a look at our conversion
code and re-examine to be sure we're doing it right.
2016-12-08 11:24:08 -05:00
Toshio Kuratomi
0400efa3f8 Change parameter to type=path
Read as binary for python3 preparedness
2016-12-08 11:24:08 -05:00
Toshio Kuratomi
390dbe5090 Change one param to be of type path 2016-12-08 11:24:08 -05:00
Toshio Kuratomi
8b711c1c77 change a parameter to type=path 2016-12-08 11:24:08 -05:00
Toshio Kuratomi
ecafdeeaa5 Set some module parameters to type=path 2016-12-08 11:24:08 -05:00
Toshio Kuratomi
cea1125d02 Correct dest_port to be of type int 2016-12-08 11:24:08 -05:00
Toshio Kuratomi
646d0e406d Set one parameter to be type path 2016-12-08 11:24:08 -05:00
Toshio Kuratomi
249b9511a5 Set name to type path so that tilde and env vars are expanded 2016-12-08 11:24:08 -05:00
Toshio Kuratomi
47e9a06784 Specify types in argument_spec instead of code so that checking type vs default value does not trigger 2016-12-08 11:24:08 -05:00
Michael Scherer
776d079e6b Fix non RFC 2606 domain name in doc 2016-12-08 11:24:08 -05:00
Jonathan Davila
7f338e13ff Updated ec2_lc docs 2016-12-08 11:24:08 -05:00
Peter Sprygada
24fc4dbeab fixes issue with return docstring
This commit fixes an issue with the return doc string.  The old line
was removed that would prevent the docs form being built correctly
2016-12-08 11:24:08 -05:00
Leonardo Giordani
344c976141 Added some documentation for the shell return values 2016-12-08 11:24:08 -05:00
Brian Coca
a148dbe5b4 updated with html comments to avoid posting hints
also simplified form, had too much from issue template
2016-12-08 11:24:08 -05:00
Brian Coca
f7597f916c added html comments so hints are not posted
also added verbostiy instruction
2016-12-08 11:24:08 -05:00
Constantin07
3dde5196aa Added explicit type for 'tags' option 2016-12-08 11:24:08 -05:00
Matt Martz
fada638d88 Indicate in notes that the dependency on httplib2 was removed for v2.1 2016-12-08 11:24:07 -05:00
Brian Coca
7a804fd17c tolerate environment not being set
default will be the same as before, None/null
2016-12-08 11:24:07 -05:00
Constantin07
94345349a6 Fixing issue #3057 - AttributeError: 'str' object has no attribute 'items' 2016-12-08 11:24:07 -05:00
Pete Travis
b504625f72 quote fail 2016-12-08 11:24:07 -05:00
Pete Travis
f6efa9aaa5 expand when opening too 2016-12-08 11:24:07 -05:00
Pete Travis
57703450f5 use expanduser() before testing user_data as file
I like to use ~/somepath instead of absolute paths because
that's more shareable.  Without expansion, the path wasn't
considered a file, and the resulting cloud-config user_data
contained a string for the file path instead of the file context.
So, expand it.
2016-12-08 11:24:07 -05:00
Konstantin Suvorov
762bd3a801 Fix docker container restart
restart_containers(containers.running) may try to restart containers
that are deleted when looping through get_differing_containers()
fix this by refreshing list after first loop
2016-12-08 11:24:07 -05:00
Daan Oosterveld
6b4fbe62de Adds ulimit to the docker module
The ulimit will be specified as a list and separated by colons. The
hard limit is optional, in which case it is equal to the soft limit.

The ulimits are compared to the ulimits of the container and added
or adjusted accordingly on by a reload.

The module ensures that ulimits are available in the capabilities
iff ulimits is passes as a parameter.
2016-12-08 11:24:07 -05:00
Scott Brown
ba2bc1dbfe Fixing missing interpolation variable 2016-12-08 11:24:07 -05:00
Matt Martz
a18206355a Drop dependency on httplib2 in the uri module, instead using ansible.module_utils.urls 2016-12-08 11:24:07 -05:00
Brian Coca
a546775172 fixed typo, now correctly check isdir
fixes #3089
2016-12-08 11:24:07 -05:00
Brian Coca
69b0e39220 added missing checksum alias 2016-12-08 11:24:07 -05:00
Peter Sprygada
0b49f956ce minor bugfixes for junos_config return values
The junos_config now properly returns updates and reponses
2016-12-08 11:24:07 -05:00
Brian Coca
ab6242bace fixed rax_cdb argument spec
now we pull the actual arguments and added aliases to be nice
fixes #3075
2016-12-08 11:24:07 -05:00
Ton Kersten
b58e16ed3d Fix facter path
In Puppet 4 and in the PE edition, the Puppet tree is installed in
`/opt/puppetlabs/...` and all commands can be reached from
`/opt/puppetlabs/bin`.
2016-12-08 11:24:07 -05:00
Daniel Petty
f26199d962 replaced sudo with become 2016-12-08 11:24:06 -05:00
Brian Coca
bd54067287 point to local issue temmplate 2016-12-08 11:24:06 -05:00
Brian Coca
c2a3b16155 initial add of issue/pr templates 2016-12-08 11:24:06 -05:00
Brian Coca
453d267489 documented new verbosity option 2016-12-08 11:24:06 -05:00
Peter Sprygada
025bc70acd initial add of ops_template module
This adds a new module ops_template used for configuring OpenSwitch
using local declarative config modules
2016-12-08 11:24:06 -05:00
Peter Sprygada
0f7279b967 bugfix for missing function name in ios_command
This provides a minor bugfix for a missing function name in the ios_command
network module
2016-12-08 11:24:06 -05:00
Matt Martz
aaf762573e Various simple linting type cleanups on modules 2016-12-08 11:24:06 -05:00
Brian Coca
4ec0ccd5ac fixed option name mismatch, added aliases
also removed empty aliases
2016-12-08 11:24:06 -05:00
Brian Coca
b357f4dd72 added follow to specific modules that support it
was removed from common file docs
2016-12-08 11:24:06 -05:00
Jose Moreira
cc173b445e Fixed module doc typos 2016-12-08 11:24:06 -05:00
Brian Coca
bbfb957bc1 recursive copy is not available(yet) on remote_src 2016-12-08 11:24:06 -05:00
Guruprasad
1b642fcf75 Fix typo in the copy module error message
Fix the typos in the error message shown on trying to use remote_src=yes for copying directories
2016-12-08 11:24:06 -05:00
Brian Coca
23c07ccf2c cleaner error on recursive remote copy
TODO: add recursive copy support when remote_src=yes
probably need to make shared the logic in the action plugin.
2016-12-08 11:24:06 -05:00
Peter Sprygada
06e3899860 initial add of iosxr_config module
This adds a new module, iosxr_config, that can be used for configuring
Cisco IOS XR devices.  It is provides a set of arguments for sending
configuration commands to the device over cli
2016-12-08 11:24:06 -05:00
Peter Sprygada
5725472cc6 initial add of iosxr_template module
This adds a new module, iosxr_template, that can be used to template
configurations for IOS XR devices.  Templates are then loaded into the
target device over cli
2016-12-08 11:24:06 -05:00
Peter Sprygada
671184adc4 initial add of iosxr_command module
This adds a new module, iosxr_command, that can be used to issue
commands to devices running IOS XR.  Commands are run on the
target device over cli
2016-12-08 11:24:06 -05:00
Peter Sprygada
4f4bc9ed5c update junos_command module return values
This minor update fixes the return values from the junos_command module
to be consistent with other network modules
2016-12-08 11:24:06 -05:00
Peter Sprygada
13793d7b95 update ios_command module return values
This minor change updates the return values and doc string for the
ios_command module to be consistent with other network modules
2016-12-08 11:24:05 -05:00
jjshoe
a160d5426d List which version it was added
fixes https://github.com/ansible/ansible-modules-core/issues/2605
2016-12-08 11:24:05 -05:00
Brian Coca
8d0d251003 removed 'overquoting' of example
fixes #3029
2016-12-08 11:24:05 -05:00
David Shrewsbury
d7568a50e2 Fix parameters where type is assumed.
A change is coming to Ansible where module params will default to str.
Many of our modules were taking advantage of this by not being explicit
about the type, so they will break when that change merges. This hopefully
catches those cases.
2016-12-08 11:24:05 -05:00
Peter Sprygada
ca9be1d62c add init to network/cumulus and reset module attrs
The modules were merged in without an __init__.py.  This adds the module
iniit and resets all of the module attrs to 0644
2016-12-08 11:24:05 -05:00
Toshio Kuratomi
50eda6c62e password needs to be type str.
In 1.9 this was the default.  In 2.0.0 and 2.0.1 this doesn't get set.
2.1.0 will fix the default but we should fix this now.
2016-12-08 11:24:05 -05:00
Peter Sprygada
c98ba21f45 add package init to junos/ 2016-12-08 11:24:05 -05:00
Brian Coca
5b07831a11 fixes for uri module
- clarify docs on body_json behaviour
- only tranform into json if body input is not a string
  users keep passing json string and expecint it to not be jsonified again
- fixed issue with removes not handling path expansion correctly
- switched all path variables to 'type path' to handle expansions
2016-12-08 11:24:05 -05:00
Jason Kohles
bc834ff564 Enable env vars for vsphere_guest
This commit allows the connection information for
the vsphere_guest module to be provided as environment
variables, which makes it possible to use Cloud
Credentials from Ansible Tower in playbooks that utilize
vsphere_guest.

| ENV VAR         | vsphere_guest param    |
| --------------- | ---------------------- |
| VMWARE_HOST     | vcenter_hostname       |
| VMWARE_USER     | username               |
| VMWARE_PASSWORD | password               |
2016-12-08 11:24:05 -05:00
Mike Caspar
ea8097a821 Documentation updates to use complete YAML : syntax instead of key=val syntax. Adjusted example to use "" where appropriate to pass YAML Syntax checker per Contribution guidelines.
See Issue [# 2879](https://github.com/ansible/ansible-modules-core/issues/2879)
2016-12-08 11:24:05 -05:00
Peter Sprygada
0310363a22 initial add of junos_config module
This adds a new module, junos_config, useed to configure Juniper JUNOS based
devices.  The config module can be used to set an ordered set of set and
delete statements over a cli transport
2016-12-08 11:24:05 -05:00
chouseknecht
a5fe046f90 Add ios_commnand module. 2016-12-08 11:24:05 -05:00
chouseknecht
be2a50547e Moved Conditional class to netcfg. 2016-12-08 11:24:05 -05:00
Peter Sprygada
ab210862f0 initial add of junos_template
This adds a new module, junos_template, that can read in a template
config and push the changes to the device.  It can also backup the
current config.  This module is implemented over cli
2016-12-08 11:24:05 -05:00
Peter Sprygada
fb7d5e798c initial add of junos_command module
This adds a new module, junos_command that can be used for sending commands
to Juniper JUNOS based devices.   The junos_command module is implemented
over a cli transport
2016-12-08 11:24:05 -05:00
Brian Coca
2ed38b79cb expanded info on fail on check + missing apt-python
it now explains that apt module will auto install
2016-12-08 11:24:05 -05:00
Luca Berruti
feb309e3cf Typo. 2016-12-08 11:24:04 -05:00
David Shrewsbury
66c83fc788 Fix for os_server module when specifying region
Fix the OpenStack os_server module for when region_name is specified.
This should not be passed through to the shade create_server() call
as it's only used with the auth parameters.

Fixes bug: https://github.com/ansible/ansible-modules-core/issues/2797
2016-12-08 11:24:04 -05:00
Matt Clay
4288150270 Do not install python-apt in check mode. 2016-12-08 11:24:04 -05:00
Brian Coca
b5c9945485 avoid chmod in check mode 2016-12-08 11:24:04 -05:00
Peter Sprygada
8303eadff1 update eos_config doc string and return values
This change update the return values from eos_config to be consistent with
all network config modules.  This will now return updates and responses
from the module
2016-12-08 11:24:04 -05:00
Peter Sprygada
eb5f9c216b update eos_template doc string and return values
This updates the return values form eos_template to be consistent
across all template modules.  This change now returns updates and
respones
2016-12-08 11:24:04 -05:00
Peter Sprygada
279ca048ae update eos_command doc strings and return values
This change updates the returns values from eos_command to be consistent
with network modules. It now returns stdout, stdout_lines and failed_conditionals
2016-12-08 11:24:04 -05:00
Peter Sprygada
79b50f5cf8 update nxos_config doc strings and return values
This commit unifys the return values for the nxos_config module to always
return updates and responses
2016-12-08 11:24:04 -05:00
Peter Sprygada
4873e8ab12 update nxos_template doc strings and return values
This updates the nxos_template doc string to unify the return values
across all network modules.  This change now returns stdout, stdout_lines
and failed_conditionals
2016-12-08 11:24:04 -05:00
Peter Sprygada
00d3e33dbf update nxos_command doc strings and return values
This modifies the return values to make them consistent across all
network command modules.  The module now returns stdout, stdout_lines
and failed_conditionals
2016-12-08 11:24:04 -05:00
Peter Sprygada
25d724a88d update ios_template doc strings and return values
Sets the return values from ios_template to be consistent with the rest
of the network modules.  Return values are now updates and responses
2016-12-08 11:24:04 -05:00