Commit graph

48617 commits

Author SHA1 Message Date
Gonéri Le Bouder
a8efe7442c
vmware/test: set vmware/scenario/vcenter_only alias (#65515)
Add the `vmware/scenario/vcenter_only` alias to be able to identify the
vmware test roles that can be tested with just on vcenter instance.

Also, add a check to be sure we don't try to attach ESXi hosts if none
has been defined.
2019-12-04 17:12:29 -05:00
Raj Wurttemberg
212fb40147 Added an example with output. (#65336)
* Added an example with output.

##### SUMMARY
<!--- Added an example with output. -->


##### ISSUE TYPE
- Docs Pull Request

+label: docsite_pr

* Just use simpler debug tasks
2019-12-05 06:56:51 +10:00
Aaryn
be8fa961cf Fix RuntimeError in ec2_group_info (#65434)
Modifying dictionary while iterating over it
2019-12-04 13:50:06 -07:00
Ian Wienand
fc54ae9227 dnf: don't return fail_json['msg'] as list (#65302)
Although it's not enforced that fail_json['msg'] should be a string
[1], I think it is pretty strongly implied.

In this case the failure_response['msg'] is sent through as the
fail_json['msg'], and the trailing commas here turn it into a tuple.
It's not clear if this is a typo or intended, but it does cause
problems for callbacks that expect this as a string (e.g. [2]).

Since there seems no point to having these values as a tuple, remove
the trailing commas so they return a string as per everywhere else.

[1] 4c589661c2/lib/ansible/module_utils/basic.py (L2078)
[2] https://review.opendev.org/#/c/696081
2019-12-04 15:28:10 -05:00
Satyajit Bulage
770430fd07 Added required parameter to document DOC-string to produce Documentation. (#65230)
* Added required parameter to document DOC-string to produce Documentation.

Signed-off-by: Satyajit Bulage <sbulage@redhat.com>

* Just copy short_description as it was
2019-12-05 06:23:45 +10:00
Jordan Borean
c04fc52aad
win_dns_client - only configure ip enabled adapters (#65488) 2019-12-05 06:04:13 +10:00
Toshio Kuratomi
9973121f44 Fix ansible-galaxy man page generation (#65478)
The Action list was misformatted, leading to an error message in the man
page.

https://bugzilla.redhat.com/show_bug.cgi?id=1717110
2019-12-04 13:49:21 -06:00
Sam Doran
2a7623dd5c
Add CentOS 8 to the test matrix (#63649) 2019-12-04 13:39:00 -05:00
Mark Chappell
b51a1bc429 Fixup parameter documentation ("doc-required-mismatch") AWS simple cases (#65462)
* Clean up "required" lines in AWS module docs, remove corresponding ignore.txt entries, general docs cleanup
2019-12-04 10:00:50 -06:00
Kevin Breit
4184b05cc1 meraki_organization - Ignore URL parameter when comparing for… (#65337) 2019-12-04 10:40:56 -05:00
Kevin Breit
79b088aeba Meraki - Remove type comparison for idempotency check (#65338)
* Remove type comparison in is_update_required()

* Add changelog
2019-12-04 10:39:26 -05:00
Mads Jensen
f4a9f23a1b Removes duplicate HAS_IPADDRESS variable assignment in postgresql_pg_hba. (#65408) 2019-12-04 08:29:48 -05:00
Guillaume Martinez
2eb615f1ef gitlab_runner: fix idempotency for shared runners (#65176) 2019-12-04 08:18:46 -05:00
Andrey Klychkov
651dff6a2e mysql_db: add the executed_commands returned value (#65498)
* mysql_db: add the executed_commands returned value

* add changelog
2019-12-04 18:31:33 +05:30
Sylvain Monné
03c16096d7 Fix extract filter when key does not exist in container (#64959)
Fixes #64957
2019-12-04 13:24:52 +01:00
Daniel Mellado
9404384985
Add junos_static_routes module (#65239)
This commit adds a new network resource module for static routes on
junos devices.

Signed-off-by: Daniel Mellado <dmellado@redhat.com>
2019-12-04 12:59:56 +01:00
Abhijeet Kasurde
520a505caf
VMware: Fix state parameter in vmware_host_lockdown module (#65495)
Changed 'str' to 'type' in Argument_spec which is valid parameter.

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-12-04 14:16:13 +05:30
RusoSova
2d074f2a31 win_description Module (#61629)
* win_description Module

Module to change Windows description and Windows license owner information.

* LiteralPath updated

changed -path to -LiteralPath in the script

* Version and metadata_version

version_added updated to 2.10
Metadata_version set to 1.1

* version updated

version_added changed to '2.10'

* Changes based on feedback

* removed some redundant checks

* Rename win_description.ps1 to win_computer_description.ps1

* Rename win_description.py to win_computer_description.py

* Module name change

* Integration tests added

* added aliases file

* Change compatibility from 2008 to 2008R2

* Update aliases
2019-12-04 14:25:16 +10:00
rnsc
cfb6cb4cef Win data deduplication module (#59723)
* win_data_deduplication initial commit

* Ansible version added bump

* integration tests

* missing aliases

* Fixing documentation

* license and metadata

* documentation formating

* removing win_format ref

* documentation fixes

* trailing whitespace

* Fixing more documentation :(

* missing return

* documentation cleanup

* align copyright with doc

* indentation fixes...

* updated examples

* ignore meta and future for python doc

* removing when

* use Get-PSVolume

* Get-Volume not PSVolume

* missing updated var

* updated old drive refs

* make sure that the T drive is formated as NTFS

* path and drive_letter are exclusive

* idempotence test fix

* changing task order + reboot timeout

* implementing the requested changes to the code

* updating documentation to reflect code changes

* simplifying tests

* missing feature install before running the tasks

* pslint trailing whitespace

* putting old tests back

* missing win_format

* skip windows 2012

* Fixing message for OS check

* pass settings and dedup_job variables

* Removing unnecessary module

* logic issue

* replacing tabs with double space

* documentation fix + removing tabs

* Update documentation with recent changes

* Apply changes requested

* switch feature install with partition format

* replace tabs with spaces

* trailing whitespace

* we don't need those ignores anymore

* minor fixes

* updated test to match latest code changes

* removing dedup job task

* adding check mode yes test

* fixes for check_mode support

* updating examples in documentation

* wrong indentation for check_mode in tests

* convert indentation to spaces

* -not $check_mode

* removing unneeded spec in documentation

* Switch to Ansible.Basic

* 2.9 is already gone, so let's add this module to 2.10...

* removing useless else condition

* updated documentation

* fixing specs and removing useless try/catch + fix exit/fail

* spaces indentation

* $null check is actually needed if volume never had dedup

* Missing check_mode update

* removing required for default state in documentation

* converted tabs to spaces
2019-12-04 14:21:21 +10:00
Shachaf92
584824f560 win_share - Implement append paramtere for access rules (#59469)
* win_share - Implement append paramtere for access rules

* changed fragment

* add test

* missing bracket

* removed whitespace

* Wrong number of lines

* Forgot the actual new parameter in the test

* community review

* Change option names

* version update

* Update tests.yml

* Add idempotence to rule_action: add
2019-12-04 14:16:10 +10:00
Brant Evans
ed54b9b441 add win_initialize_disk module (#58617)
* add win_initialize_disk module

* Add ability to specify disk by path or uniqueid

* Fix documentation

* fix shippable failures

* Update anisble version

* Slight tweaks to the documentation

* Small documentation fixes
2019-12-04 12:37:15 +10:00
Matt Clay
85722c360f Disable failing hcloud tests. 2019-12-03 17:52:08 -08:00
GomathiselviS
d710a5cd7f
eos_interfaces: Added unit testcases for eos_interfaces (#63813)
* Added unit testcases for eos_interfaces

* Corrected lint errors

* Corrected lint errors

* Addressed Review comments
2019-12-03 18:42:26 -05:00
Samir Jha
db709488bd Update foreman inventory to use foreman's inventory report (#62438) 2019-12-03 15:11:40 -07:00
John R Barker
322a4dc691
BOTMETA migrated_to should be namespace.collection (#64029) 2019-12-03 19:20:58 +00:00
Felix Fontein
88d8cf8197
Remove no longer valid ignore.txt entry. (#65469) 2019-12-03 18:13:23 +01:00
Gonéri Le Bouder
974e8cec3d
prepare_vmware_tests: run test w/ just 1 vcsa (#65433)
Add the ability to run test with just a VCSA instance. This allow us to
test a subset of tests that don't need any ESXi nodes.
2019-12-03 11:17:06 -05:00
Kiyo Nagamine
daecbb9bf0 Ensure allow_duplicates: true enables to run single role multiple times (#64902) (#65063)
* Ensure `allow_duplicates: true` enables to run single role multiple times(#64902)

* Changed return value in `_load_roles` . Fixes #64902

* Add changelog fragment

* Add an integration test for the issue

* Fix changelog generation error and integration test.

* Fix yaml syntax error in changelog fragment
2019-12-03 10:21:54 -05:00
Felix Fontein
4be8b2134f Sanity checks: make sure that required in argument spec coincides with documentation (#65437)
* Add sanity test for required parameters, update ignore.txt, and add changelog.
2019-12-03 09:15:07 -06:00
Yanis Guenane
c19949706f vyos: Make vyos related yaml file passing yamllint (#65449) 2019-12-03 09:34:35 -05:00
Felix Fontein
ae4363f6d1
openssl_csr: make sure privatekey_path is specified when state is present (#65435)
* Make sure privatekey_path is specified when state is present.

* Add changelog.
2019-12-03 14:08:26 +01:00
Nilashish Chakraborty
d82361a709
Fix exos_lldp_interfaces support status (#65428)
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
2019-12-03 13:47:32 +05:30
Fabrice
49b457016e k8s: persist refreshed tokens (#63219)
When the ansible k8s module is refreshing the tokens from the local kube
config, it should save those token to the kube config file.

If this is not done, this might break the next kube client call as the
token in the local kube config file is not valid anymore and refreshing
can fail.

This commit is adding an env var K8S_AUTH_PERSIST_CONFIG that can be
used to set this flag to true (default is false, same as current
behavior).
2019-12-03 12:22:26 +10:00
Jordan Borean
8648003c1f
ansible-galaxy - Add User-Agent to requests (#65438) 2019-12-03 10:04:41 +10:00
Bruno Meneguello
6075536907 route53_info: add pagination support to list (#60433) 2019-12-02 15:33:59 -07:00
Jordan Borean
6586b7132c
galaxy - print HTTP reason on unknown error (#65273) 2019-12-03 07:36:05 +10:00
Sam Doran
0e5a83a1cc
Add Fedora 31 to the test matrix (#64848)
* Add Fedora 31 to the test matrix

* Remove Fedora 29 from the test matrix
2019-12-02 15:54:32 -05:00
Prasad Katti
37ce55fd79 lightsail - Use AnsibleAWSModule (#65275)
* lightsail - Use AnsibleAWSModule

- Use AnsibleAWSModule
- Refactor the logic for wait into a separate function (Fixes #63869)
- Handle exceptions in find_instance_info and add a fail_if_not_found parameter
- Add a new state `rebooted` as an alias for `restarted`. AWS calls the action Reboot.
- Add required_if clause for when state is present

* lightsail - Use the default keypair if one is not provided

* lightsail - add a required_if for when state=present

* Update short description for lightsail module
2019-12-02 13:12:44 -07:00
Mario Lenz
02e7c5a19f vmware_datastore_cluster: Added SDRS configuration (#65193) 2019-12-02 15:02:50 -05:00
Jordan Borean
694ef5660d
Fix using a URL for galaxy collection install (#65272)
* Fix using a URL for galaxy collection install

* Update lib/ansible/galaxy/collection.py

Co-Authored-By: Sloane Hertel <shertel@redhat.com>
2019-12-03 04:55:31 +10:00
Sandra McCann
41472ee387 Describe different ways to set connection timeout options (#65126)
* add timeout option examples, link to new section, implement feedback
2019-12-02 10:42:45 -06:00
Jiri Tyr
a8ef5d5034 VMware: Autoselect datastore only from the given cluster/ESXi (#43435)
* Autoselect DS only from the given cluster/esxi
* Run tests only on real vCenter
2019-12-02 21:53:08 +05:30
Will Brock
5942e7f2a2 Fix type in svn documentation path (#65353) 2019-12-02 09:55:02 -06:00
Sam Doran
21bbf49396 Mention Python builtin methods in filter docs (#65425) 2019-12-02 09:44:59 -06:00
林博仁(Buo-ren Lin)
8ebc57c186 Mention that Python keywords are invalid Ansible variable names (#65094)
* Mention that Python keywords are invalid Ansible variable names
Using a Python keyword as a variable name triggers the error `Invalid variable name in 'register' specified: 'return'`.
2019-12-02 09:42:40 -06:00
Andrey Klychkov
0cadb952f9 postgresql_ext: use query_params (#64994)
* postgresql_ext: use query_params

* added changelog
2019-12-02 13:32:25 +00:00
Kaarle Ritvanen
c53b8030ab lbu module: Alpine Linux Local Backup Utility (#62584) 2019-12-02 19:00:09 +05:30
Pavan Bidkar
a8f1c85a20 VMware: Updated module compatibility with vsphere version. (#65419)
Update vmware_content_deploy_template module compatibility with vSphere version.
2019-12-02 18:57:56 +05:30
Felix Fontein
08b53b94a9 acme_certificate: Fix ACME v1 support when modify_account is set to false (#64648)
* Fix ACME v1 when modify_account is set to false.

* Add changelog.
2019-12-02 03:35:49 -05:00
Felix Fontein
5f6057598e Hetzner: dedicated server firewall module (#65399) 2019-12-02 09:19:49 +01:00