Commit graph

26568 commits

Author SHA1 Message Date
Martin Krizek
d15812fabf
Fix copy module to reset filesystem acls (#51868)
The controller's fixup_perms2 uses filesystem acls to make the temporary
file for copy readable by an unprivileged become user. On Python3, the
acls are then copied to the destination filename so we have to remove
them from there.

We can't remove them prior to the copy because we may not have
permission to read the file if the acls are not present. We can't
remove them in atomic_move() because the move function shouldn't know
anything about controller features. We may want to generalize this into
a helper function, though.

Fixes #44412

Co-authored-by: Toshio Kuratomi <a.badger@gmail.com>
2019-04-03 18:37:59 +02:00
Nilashish Chakraborty
40507220b4
asa: Not all modules will have 'passwords' and 'context' keys (#54783)
* Add a check of passwords

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Add caution for context key as well

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Update lib/ansible/module_utils/network/asa/asa.py

Co-Authored-By: NilashishC <nilashishchakraborty8@gmail.com>

* Update lib/ansible/module_utils/network/asa/asa.py

Co-Authored-By: NilashishC <nilashishchakraborty8@gmail.com>
2019-04-03 21:42:34 +05:30
Zim Kalinowski
4f0ad57934 renaming info -> facts (#54573) 2019-04-03 23:03:47 +08:00
Ondra Machacek
8940da9b46 ovirt_host: add activate parameter (#54594) 2019-04-03 10:30:27 -04:00
Yunge Zhu
a387b8e239
add vnet peering facts module (#53942) 2019-04-03 22:22:16 +08:00
Mikhail Yohman
0b1470a3c9 Netbox site module (#53219)
* Created netbox_interface module and updated netbox_utils

* Fixed PEP issues and documentation issue for ASN type

* tenant API endpoint doesn't support slug currently, changed to name, fixed user issue

* Updated documentation to include types

* Updated argument_spec to include required sub options of data

* Fixed formatting of argument spec - missing parenthesis in data options

* Fixed syntax error

* refactored to use shared functions create()/delete()/update()

* Fixed PEP issues
2019-04-03 18:17:55 +05:30
zhongjun2
eb7735000e Fix typo (#54770) 2019-04-03 11:37:30 +01:00
Trishna Guha
6155701e36
Add type of group in nxos_linkagg module doc (#54769)
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2019-04-03 14:21:12 +05:30
Mariusz Mazur
0acef98dc4 kubevirt_cdi_upload: add more error handling (#54041) 2019-04-03 04:46:24 -04:00
Nilashish Chakraborty
ee08b009dd
Make prompt inspection explicit for IOS (#54324)
* Be explicit with prompt inspection

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Use regex to evaluate prompt for sub-level config sessions

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>

* Add new line at the end of file

Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
2019-04-03 10:55:20 +05:30
b-abadie
70f315b7a4 network, eos_config: when the config session show no diff, set 'changed' to False (#54678) 2019-04-03 10:31:11 +05:30
Fred-sun
3694711a7e Update azure_rm_managed_disk.py --add zones (#53788) 2019-04-03 11:08:27 +08:00
Felix Fontein
c82c33f6ce docker_image: fix KeyError and docs copy'n'paste error (#54732)
* Avoid KeyErrors.

* Fix docs.

* Fix key checks.
2019-04-02 17:58:44 -04:00
Jordan Borean
e56fb48873
psrp - auth options (#54705) 2019-04-03 07:53:50 +10:00
Jordan Borean
b13fa0d408
Ansible.Basic - event log perm fix and no_log improv (#54699)
* Ansible.Basic - event log perm fix and no_log improv

* Still log other failures
2019-04-03 06:49:43 +10:00
Yuwei Zhou
064d89a850 Update create_with_nsg documentation (#54441) 2019-04-02 15:33:52 -05:00
Sebastian Meyer
a8474ba91f Add package requirements for openSUSE for nmcli (#54489) 2019-04-02 15:29:48 -05:00
Jordan Borean
8b1b22ddc7
Bump dependency versions to avoid conflicts (#54443)
* Bump dependency versions to avoid conflicts

* Fix module code to support newer SDK packages

* Fix keyvault module are upgrading deps
2019-04-03 05:40:52 +10:00
The Magician
696e9c1462 Bug fixes for GCP modules (#54706) 2019-04-02 14:09:05 -04:00
The Magician
08d2545883 Bug fixes for GCP modules (#54707) 2019-04-02 14:08:53 -04:00
Toshio Kuratomi
b03c16fa8b
Paramiko might not come standard everywhere (#54486)
* Paramiko might not come standard everywhere

There is a platform where paramiko isn't shipped but a special version
of paramiko just for our use is shipped.  This code imports paramiko
from that location.
2019-04-02 10:06:51 -07:00
Andrey Klychkov
40f65a54ec Postgresql privs reformat (#54717)
* postgresql_privs: fix doc format, pgutils

* postgresql_privs: added pgutils, ret value

* postgresql_privs: fix test

* postgresql_privs: fixes

* postgresql_privs: fixes

* postgresql_privs: fixed CI
2019-04-02 16:48:35 +01:00
Mariusz Mazur
7ea01da38f kubevirt_rs: new wait logic (#54726) 2019-04-02 10:42:33 -04:00
Alan Rominger
2c169e0baf correct example since per_host default is false (#54725) 2019-04-02 10:08:55 -04:00
Sam Doran
579e72573a Add BusyBox support to group module (#54689)
* Add BusyBox support to group module

* Use bytes when reading/writing to file
2019-04-02 09:58:04 -04:00
tnisan
fbaa6c33ca ovirt_disk: Support Hosted Engine content types (#54328)
Signed-off-by: Tal Nisan <tnisan@redhat.com>
2019-04-02 04:52:36 -04:00
René Moser
8f65c4f8d5
vultr: fix missing encoding header (#54696) 2019-04-02 06:37:13 +02:00
Zim Kalinowski
d760b400af more doc improvements (#54649) 2019-04-02 09:33:00 +08:00
Jordan Borean
c40f41d519
win_credential - fix encoding for text based secrets (#54695)
* win_credential - fix encoding for text based secrets

* Fix py2 encoding issues
2019-04-02 09:29:05 +10:00
Steve Bonds
95e5f89089 Clarify source of the host name (#54693)
The host could have been either the inventory name (`inventory_hostname`)
or the discovered hostname (`ansible_hostname`)

Inspecting the source code of `fetch.py` shows that the
inventory name is preferred.

```
if 'inventory_hostname' in task_vars:
                    target_name = task_vars['inventory_hostname']
```
2019-04-01 17:44:12 -04:00
Jose Delarosa
c9d183f1f7 Add new Redfish config module to handle Dell-specific OEM extensions (#54359)
* Add new Redfish config modules to handle Dell-specific OEM extensions

- Extends the existing RedfishUtils class and leverages its methods

* Removed extra password key

* Add timeout parameter

* Updates to DOCUMENTATION section

- Removed version_added from several parameters
- Added type to category parameter
2019-04-01 20:59:16 +01:00
Jose Delarosa
4890c69a3d Add new Redfish facts module to handle Dell-specific OEM extensions (#54360)
* Add new Redfish facts module to handle Dell-specific OEM extensions

- Extends the existing RedfishUtils class and leverages its methods

* Add timeout parameter

* Removed version_added for timeout paramater
2019-04-01 20:58:06 +01:00
Christopher Schmitt
cafd124288 Add ssh key facts for hcloud (#54518)
* Add ssh_key facts

* Fix documentation
2019-04-01 19:07:59 +01:00
Jose Delarosa
7ddddeb801 Fix error with get_manager_nic_inventory method (#54553)
* Fix error with get_manager_nic_inventory function

- Function was not updated when code to handle multiple systems was added

* More elegant way to put self.manager_uri in a list
2019-04-01 18:11:04 +01:00
David Passante
aa2427573b cs_vlan_ip_range: Update return values documentation (#54677)
* cs_vlan_ip_range: Update return values documentation

* add missing start/end_ipv6 return values to the doc
2019-04-01 13:06:26 -04:00
Lukas Kämmerling
72f1e4b83a Add hcloud_volume_facts (#54666)
* Add hcloud_volume_facts

* Fix server name
2019-04-01 17:25:46 +01:00
Martin Nečas
90c4b22205 ovirt add template version (#54675) 2019-04-01 17:23:57 +01:00
Chris Archibald
ec03ddd336 Multiple fixs for na_ontap_user (#54610)
* Fix ontap user for 9.1

* fix bugs:

* update unit tests
2019-04-01 17:22:48 +01:00
Chris Archibald
03e18e4e1f na_elementsw_cluster was using wrong username/password (#54622)
* Bug fix

* Bug fix
2019-04-01 17:18:43 +01:00
Łukasz Szczęsny
bcdd1dc951 pamd: fix idempotence issue when removing rules (#54105) 2019-04-01 10:18:33 -04:00
Ondra Machacek
f405d97e1e kubevirt_vm: rename parameters to template_parameters (#54676) 2019-04-01 09:59:43 -04:00
Andrey Klychkov
48ec8d13a0 postgresql_lang module: fixed doc formatting, added aliases, pg_utils, added missing CI tests (#54672)
* postgresql_lang: fixed doc

* postgresql_lang: add pg_utils

* postgresql_lang: added return value - queries

* postgresql_lang: added CI tests

* postgresql_lang: restricted CI using CentOS

* postgresql_lang: fixed typos in CI comments
2019-04-01 14:39:00 +01:00
Vitalii Kostenko
2176b53a55 Add latest updates from FTD Ansible downstream repository. (#53638)
* Add latest updates from FTD Ansible downstream repository.
 - add a better implementation of the upsert operation;
 - add API version lookup functionality;
 - add filter which remove duplicated references from the list of references;
 - fix minor bugs.

* fix issues outlined by ansibot

* fix argument name for _check_enum_method
2019-04-01 18:08:01 +05:30
Martin Nečas
71216cace5 add ovirt template clone name (#54596)
* add ovirt template clone name

* ovirt template clone name update docs
2019-04-01 07:25:36 -04:00
Hannes Ljungberg
e58f23b73e docker_swarm: Return UnlockKey (#54490)
* Return UnlockKey

* Add changelog fragment

* Add method to check if a parameter exists in diffs

* Add method to get swarm unlock key

* Add option unlock_key

* Only return unlock key when created or changed

* Rename difference check

* Extend unlock key example

* Assert that unlock_key is a string

* Fix docker_swarm_info authors

* Don’t silence APIErrors

* Test unlock_key on unlocked swarm

* Catch APIError when retrieving unlock key

* Better return value description

* Lint

* Fix UnlockKey return value documentation

Co-Authored-By: hannseman <hannes@5monkeys.se>

* Get unlock key safely

Co-Authored-By: hannseman <hannes@5monkeys.se>

* Return None on empty UnlockKey

* Assert swarm_unlock_key is undefined if unqueried

* Add documentation about swarm_info unlock_key

* Add change log fragment for unlock_key option

* Revert "Add change log fragment for unlock_key option"

This reverts commit e3cb2325b5.

* Use generator expression instead

* Restart docker more decisively

* Use systemctl kill

Co-Authored-By: hannseman <hannes@5monkeys.se>

* Try to restart docker daemon
2019-04-01 12:19:18 +01:00
Jakob Ackermann
21c8650180 openssh_cert: add serial_number param (#54653)
* [openssh_cert] cleanup the returned certificate info

- Drop the certificate path - it is already present in rc.filename.
- Drop the leading whitespace for all lines.

Signed-off-by: Jakob Ackermann <das7pad@outlook.com>

* [openssh_cert] add support for a certificate serial number

Signed-off-by: Jakob Ackermann <das7pad@outlook.com>

* [openssh_cert] fix lint error

Signed-off-by: Jakob Ackermann <das7pad@outlook.com>

* [openssh_cert] drop explicit default value

Signed-off-by: Jakob Ackermann <das7pad@outlook.com>

* [openssh_cert] enforce the specified or missing serial number

Signed-off-by: Jakob Ackermann <das7pad@outlook.com>

* [openssh_cert] passing no explicit serial number ignores any present one

Signed-off-by: Jakob Ackermann <das7pad@outlook.com>
2019-04-01 12:18:33 +01:00
Felix Fontein
fa47bed71c openssl_certificate: fix ACME provider (#54656)
* Change default of acme_chain to no.

* Stop using string command lines.

* Add changelog.

* Fix changelog.
2019-04-01 12:18:14 +01:00
Lukas Kämmerling
f99d1b3e47 Add hcloud_floating_ip_facts module (#54667) 2019-04-01 13:16:24 +02:00
Rémy Léone
d48fb6ee41 Remove check for commercial types in scaleway_compute (#54535) 2019-04-01 07:02:12 -04:00
Ondra Machacek
f6bdadaecd Support to create VM from template (#54222) 2019-04-01 06:32:47 -04:00