cmueller/ansible
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity
5345 commits 47 branches 390 tags 440 MiB
Commit graph

598 commits

Author SHA1 Message Date
Toshio Kuratomi
2973bac72f Clarify documented behaviour of user module's ssh_key_file parameter 
Fixes #9873
 2015-01-07 08:46:42 -08:00
Peter Oliver
18c429d016 Fix appending to a user's group on Solaris 
Without this change, you get:
    AttributeError: 'set' object has no attribute 'extend'

Tested on a Solaris 11.2 client with the included Python 2.6.8.
 2014-12-21 20:05:17 +00:00
Toshio Kuratomi
443951ce82 Merge pull request #524 from zitterbacke/patch-1 
re-enable AIX password setting
 2014-12-16 23:38:38 -08:00
Toshio Kuratomi
67aeab9576 Merge pull request #512 from mscherer/fix_438 
Revert commit cbc417c, as the code is broken, see #438
 2014-12-16 22:46:20 -08:00
Jonathan Mainguy
541070be4c Fixed hostname for rhel5 python 2.4.3 2014-12-16 09:49:13 -05:00
zitterbacke
2e88582165 re-enable AIX password setting 
the AIX class uses a unsafe shell for setting the user password (containing a pipe in the command). This patch adopts to the new behavior of module_utils/basic.py (since somewhere around 1.7).

besides it changes the qoutes for the echo command from double to single, because password-hashes contain $-signs and one would not have this variables expanded.
 2014-12-16 15:10:00 +01:00
Michael Scherer
39cd64ec17 Revert commit cbc417c, as the code is broken, see #438 
LooseVersion expect a string, so filtering to return a int
is incorrect. Thanks to Jeremy Brown for the analysis.
 2014-12-14 21:59:44 +01:00
Toshio Kuratomi
e1f90635af Don't traceback if a gid is specified instead of a group name 
Fixes https://github.com/ansible/ansible/issues/9796
 2014-12-12 12:08:03 -08:00
Brian Coca
ba139b145b fixed hostname for gentoo 2014-12-11 09:05:27 -05:00
Brian Coca
aba9e5e4f9 vastly simplified systemd detection, made enable/disable errors clearer 
both of which allows us to remove 'service name detection' as if systemd
is init we still use it to handle initscripts.
 2014-12-08 08:15:54 -05:00
Brian Coca
df6d58614e now actually adds usable name for systemd when service only has init 
script
 2014-12-05 12:45:01 -05:00
Toshio Kuratomi
5af4463823 Gixes to doc formatting 2014-12-03 08:17:15 -08:00
Toshio Kuratomi
799a75580a Update cron example for setting to run twice a day 
Fixes #415
 2014-12-02 14:38:32 -08:00
Brian Coca
943f8fe7c9 Merge pull request #346 from bcoca/service_cleanup 
service cleanup
 2014-12-02 11:03:03 -05:00
Achilleas Pipinellis
a375ce33d3 Clarify supported init systems. 2014-12-01 16:15:24 +02:00
Pascal Borreli
32a00ec3a3 Fixed typo 2014-11-28 16:36:21 +01:00
Fabrice Bernhard
1ef8c26c0e Typo in comments 
Credit goes to @kbsali 
@pborreli : you did not see that one? :-)
 2014-11-27 12:36:34 +01:00
Brian Coca
29d211e7ab service cleanup 2014-11-17 22:32:16 -05:00
Brian Coca
f49120598f service now detects systemd is actually running, not just installed 2014-11-17 15:03:49 -05:00
Jonathan Mainguy
8b8008569f fixes user module for rhel5 by using -n instead of -N, all other distros will still use -N 2014-11-17 13:26:08 -05:00
Robert Estelle
4dd099fe7a Remove incorrect executable permissions. 2014-11-13 18:08:48 -05:00
Brian Coca
04680ce228 Merge pull request #286 from bcoca/hostname_24_compatible 
made hostname work with python 2.4
 2014-11-13 12:39:01 -05:00
Brian Coca
83669d7eda switched to iterator as per comments 2014-11-11 09:39:03 -05:00
Martijn P. Rijkeboer
5257222f33 Fix whitespace around '=' in sysctl.conf. 2014-11-10 20:00:28 +01:00
Brian Coca
e4b6968901 made hostname work with python 2.4 2014-11-08 12:08:47 -05:00
Toshio Kuratomi
7f611468a8 Fix for systemd service scripts with newlines 
Fixes #127
 2014-10-22 16:43:35 -04:00
Michael DeHaan
385a037cd6 package files 2014-09-26 11:05:47 -04:00
Michael DeHaan
c8e1a2077e file extensions! 2014-09-26 10:37:56 -04:00
Michael DeHaan
417309a626 Restructuring. 2014-09-26 10:13:26 -04:00
Michael DeHaan
73123b69fa Move modules into subdirectory. 2014-09-26 09:23:50 -04:00
Toshio Kuratomi
8b81062be0 The fix for gh-7284 causes problems for initscripts which have the 
standards compliant return codes but return a verbose error message via
stdout.  Limit the times when we invoke the heuristic to attempt to work
around this.
 2014-09-22 14:53:07 -04:00
Michael Scherer
c9a0a7ae4b Fix #9704, correctly set changed as false when nothing is done 2014-09-21 14:55:31 +02:00
Toshio Kuratomi
7b100dd389 Be more specific in checking if a job restarted successfully. 
Fixes: #9056
 2014-09-19 12:03:27 -07:00
Toshio Kuratomi
36083c3b90 Failure to enable a service now fails the task 
Fixes: 8855
 2014-09-18 12:39:54 -07:00
Toshio Kuratomi
a50258d26a remove debugging that was causing failure 2014-09-17 10:25:54 -07:00
Toshio Kuratomi
2e16bd3a44 Refactor the Linux service_enable() method 
* Fix check_mode for initctl systems

Fixes #9009
 2014-09-17 09:34:33 -07:00
Toshio Kuratomi
104401805b Revert "Refactor the Linux service_enable() method" needs some debugging 
This reverts commit e294e31fd3.
 2014-09-17 09:17:33 -07:00
Toshio Kuratomi
c362902f50 Refactor the Linux service_enable() method 
* Fix check_mode for initctl systems

Fixes #9009
 2014-09-17 08:44:32 -07:00
Toshio Kuratomi
a9928492f7 Make systemd vs rht detection more robust for centos 
Centos 6.x and below use an old RHT style of configuring hostname.
CentOS 7.x and better use systemd.  Instead of depending on the
distribution string which seems to have changed over the course of 6.x
we need to explicitly check the version.

Fixes #8997
 2014-09-16 09:53:13 -07:00
James Cammarata
7edcf21bdc Move initscript rc check to later in service status check 
Fixes #7284
 2014-09-11 12:11:06 -05:00
Michael DeHaan
5aa6ddef7f Tracebacks are now catchable with ignore_errors and have streamlined output. Also removes 'baby-JSON' for bash modules. 2014-09-11 12:27:21 -04:00
Patrik Lundin
0abf14ff19 service: use self.changed in service_enable_rcconf(). 
This sets the "changed" result of the module when a rc file is modified.
Previously only --check mode would show that it was going to change.
 2014-08-28 00:52:23 +02:00
James Cammarata
30d6713bf0 Add additional checks to detect upstart services 
Also adds checks for the upstart version, in order to test check
support for manual vs. start on manual
 2014-08-25 13:41:39 -05:00
Eri Bastos
6f8a29dc3d Proposed fix for issue #7757 2014-08-25 12:10:14 -05:00
James Cammarata
c8376e296f Tweaking change to documentation language for cron name param 2014-08-25 09:54:21 -05:00
James Cammarata
509761249c Merge branch 'devel' of https://github.com/mattparker/ansible into mattparker-devel 2014-08-25 09:51:17 -05:00
James Cammarata
07e77c5bed Merge pull request #8740 from mattparker/patch-1 
Name appears to be a required parameter for cron module
 2014-08-25 09:49:58 -05:00
James Cammarata
1f2727c607 Merge pull request #8729 from ercpe/openrc-hostname 
Hostname strategy implementation for OpenRC based systems (e.g. Gentoo)
 2014-08-25 09:28:29 -05:00
Matt Parker
6086c505fe Update cron documenation 
The "name" parameter seems to be rather important as the identifying feature of a cron job.  This is an update to the documentation to further emphasize this.
 2014-08-25 10:29:45 +01:00
Matt Parker
5accd15ba6 Name appears to be a required parameter 
As far as I can tell, `name` is a required parameter.  The guard test at (now) line 458 says you need name if `state == present` and at 464 if `state != present`, although that's not quite as clear.  Each of the code paths at 485 - 495 pass the name param through to `add_job`, `update_job` and `remove_job`, and the actual _update_job method earlier seems to require it too.  However I don't really know python so I may be wrong, but I can't see the circumstances when `name` is not required.
 2014-08-25 10:23:54 +01:00