Michael DeHaan
a94ec130d2
Common module code upgrades
2012-07-17 23:09:57 -04:00
Michael DeHaan
9006d4557d
Added code to allow insertion of boilerplate into modules to make them able to share lots of code, the result
...
should be a huge reduction of total ansible source, at a slight cost of difficulty in original module development.
We need to apply this now to all modules, but may need to have some exemptions to things like command, which should
subclass this module.
2012-07-17 22:34:52 -04:00
Peter Sankauskas
5e35cd6466
Pass through error message when repo not found
2012-07-19 15:48:13 -07:00
John Kleint
ae665c15b3
Service module outputting extra data.
...
The service module was printing stuff to stderr, returning two
JSON dicts, not using consistent 'failed' values, had dead code
and unused variables. Added detection for the case when service
status returns 'xxx is dead and pid file exists' and made the
code a bit easier to read.
2012-07-19 13:15:09 -04:00
Michael DeHaan
1a88a3362f
add noninteractive to debian module per #602
2012-07-16 20:18:58 -04:00
Seth Vidal
f6a09bc4c1
Squashed commit of the following:
...
commit ea14bbfb52587bf5b97b5577c0439b01cb0b4836
Merge: 82819a9
285aaf8
Author: Michael DeHaan <michael.dehaan@gmail.com>
Date: Sun Jul 15 14:38:28 2012 -0400
Merge branch 'devel' of https://github.com/skvidal/ansible into skvidal_mount
commit 285aaf836c
Merge: 634c117
32b6879
Author: Seth Vidal <skvidal@fedoraproject.org>
Date: Mon Jul 16 12:42:21 2012 -0400
Merge remote-tracking branch 'upstream/devel' into devel
* upstream/devel: (52 commits)
format fixes to make fetch more usable
...
commit 634c11748e
Author: Seth Vidal <skvidal@fedoraproject.org>
Date: Thu Jul 12 01:16:00 2012 -0400
fix a bunch of small bugs in mount module - test with bind and local mounts
commit fcfd73de71
Author: Seth Vidal <skvidal@fedoraproject.org>
Date: Wed Jul 11 20:46:14 2012 -0400
fix some obvious bugs pointed out by #ansible
commit 13c3080383
Author: Seth Vidal <skvidal@fedoraproject.org>
Date: Wed Jul 11 19:35:34 2012 -0400
mount/fstab editor
2012-07-15 14:38:40 -04:00
Michael DeHaan
64c51ade1e
Change the way we do with_items to make them happen next to each other in runner, which eliminates the problem of with_items and vars_files sometimes not playing nice with each other.
...
(Also a fix for the user module error handling when the user
is not present at the time of the return. This can only really be caused by multiple ansible executions).
2012-07-14 19:18:33 -04:00
Michael DeHaan
931f9f1a61
Setup module no longer saves to disk, as templates are mostly useful in playbooks and this allows lots of simplifications
...
around file pathing and removes occasional permissions conflicts depending on how things are used.
2012-07-14 11:59:12 -04:00
Mark Theunissen
f47cc1693d
The MySQL modules
2012-07-13 17:07:23 -05:00
Jeremy Smitherman
e5a6627d10
Removed unused recurse option in file module.
2012-07-12 02:04:51 -04:00
Michael DeHaan
fd7e96d33e
Merge pull request #578 from jeremysmitherman/boolean_parameters
...
Removed boolean parameter setting from user module.
2012-07-11 10:58:09 -07:00
Michael DeHaan
626e4cb003
Merge pull request #572 from goozbach/devel
...
fixes #569 apt module problems on old versions of apt-python
2012-07-11 10:53:29 -07:00
Jeremy Smitherman
ecacb67d31
Added yes/no to user options instead of False comparison for force and remove options for user module
2012-07-11 12:16:40 -04:00
Michael DeHaan
3f5c4772be
Merge pull request #575 from jeremysmitherman/apt-force
...
Added cmd modifications to use a force-yes option for apt module
2012-07-11 07:16:40 -07:00
Michael DeHaan
949f8b8fc5
Merge pull request #571 from sfromm/group
...
Group module fixes
2012-07-11 05:27:56 -07:00
Jeremy Smitherman
a35a0f885e
Added cmd modifications to use a force-yes option for apt module
2012-07-10 22:22:52 -04:00
Derek Carter
f38b9d1ca7
added filter for future warning
2012-07-10 19:50:08 -04:00
Stephen Fromm
ac3341cc12
Minor fix to user module to further streamline setting 'changed' flag
2012-07-10 16:37:07 -07:00
Derek Carter
e261d49acc
fixes #569 apt module problems on old versions of apt-python (namely debian 5.0)
2012-07-10 19:28:14 -04:00
Stephen Fromm
3a5f2126a6
Fixes to group module for better error handling
...
Takes a lot of the fixes to the user module and applies them to the
group module: provide stdout/stderr in result if available and call
fail_json() if the attempted action fails.
2012-07-10 16:18:53 -07:00
Michael DeHaan
3235da074e
Merge pull request #568 from sfromm/user
...
User modules fixes
2012-07-10 16:04:17 -07:00
Michael DeHaan
8bb41bc627
Merge pull request #566 from jeremysmitherman/service-no-pid
...
Added additional output to service status checker
2012-07-10 16:03:51 -07:00
Stephen Fromm
09f025b7a0
Fixes to user module for better error handling
...
The user module now returns the output, both stdout and stderr, from
useradd, usermod, and userdel. This should help debug cases why one of
those commands fail. In addition, the user module will now call
fail_json() when the attempted command failed so as to properly
communicate a failure in a playbook.
2012-07-10 15:55:39 -07:00
Seth Vidal
2f11350665
modify user module so that password is NEVER logged before the command runs
2012-07-10 17:13:51 -04:00
Jeremy Smitherman
7af3bdc89e
Added additional output to service status checker
2012-07-10 16:13:39 -04:00
John Kleint
375a1eaf43
Use iterative MD5 hashing.
2012-07-09 13:27:47 -04:00
Dave Hatton
55694db7c3
switch to hashlib.md5 or md5 instead of OS md5 commands
2012-07-09 08:52:00 +01:00
Peter Sankauskas
fed1e9870c
Assigning to boolean first
2012-07-06 18:05:15 -07:00
Peter Sankauskas
fced8cf6b0
Getting the apt module to accept and understand a 'install-recommends' parameter which allows running apt with --no-install-recommends
2012-07-06 12:12:04 -07:00
Dave Hatton
ecaa794f7f
copy always returned change=true
2012-07-06 13:43:19 +01:00
Dave Hatton
9d85a55434
switch to shutil.copy rather than os.system(cp)
2012-07-04 12:26:25 +01:00
Dave Hatton
263fcab594
md5 allow copy if file is missing
2012-07-03 20:07:08 +01:00
Jeremy Smitherman
3003aa2d47
Added IndexError catch for copy module, IndexError is thrown if a destination file doesn't exist
2012-07-03 14:12:19 -04:00
Dave Hatton
d47de18b6c
improve error trapping for md5
2012-07-03 12:44:37 +01:00
Brad Olson
be9ff7ff46
Fixes ansible/ansible#522 , no longer creates comment in ~/.ssh/authorized_keys, does not create directory or file if state==absent.
2012-07-02 19:16:57 +00:00
Brad Olson
756df550f8
Fixes ansible/ansible#523 . Removed 'with:' blocks so module works with Python 2.4 for CentOS 5 support, courtesy of mcodd/ansible@29af24b732 .
2012-07-02 17:57:38 +00:00
Derek Carter
fc4ae3e270
remove UID/GID from output
2012-07-01 17:38:17 -04:00
Derek Carter
a548769792
removed print from debug code of file module
2012-06-29 21:38:31 -04:00
Derek Carter
82832021e8
file when UID or GID doesn't exist
2012-06-29 20:05:23 -04:00
Michael DeHaan
efac68b636
Remove the -D module debug flag, which no longer is functional due to sudo pty requirements, and replace with -v/--verbose.
...
This flag will show playbook output from non-failing commands. -v is also added to /usr/bin/ansible, but not yet used.
I also gutted some internals code dealing with 'invocations' which allowed the callback to know what module invoked
it. This is not something 0.5 does or needed, so callbacks have been simplified.
2012-06-19 21:57:43 -04:00
Ludovic Claude
daf858648b
Add basic support for Solaris
2012-06-26 19:49:26 +02:00
Ingo Gottwald
a42167ca73
Copy module: Extended error handling and fixed error messages
2012-06-25 20:45:05 +02:00
Ingo Gottwald
270266e920
Added to copy module: Error handling for missing permissions on the copy destination
2012-06-23 21:39:37 +02:00
Michael DeHaan
25083953fc
Merge pull request #495 from nafeger/devel
...
make copy module implemented closer to other newer modules when returning results
2012-06-20 13:12:24 -07:00
Nathan A. Feger
26816b72ec
attempt to make copy more idiomatic.
2012-06-20 14:17:15 -05:00
Ingo Gottwald
abe33a5881
Enhanced the service state recognition in the service module:
...
- Added Upstart support
- Added an initial unknown state
- Prevented state changes when the current state is not recognized
- Changed the keyword recognition to a safer method
2012-06-17 15:55:26 +02:00
Fred Alger
80f402aa9b
Remove unused md5sum function from file module
2012-06-15 00:13:35 -04:00
Fred Alger
834f6a216d
Make shell outs to md5sum work on FreeBSD and OS X
...
Tested with OS X local connection and Linux remote. The paths to the
md5sum and md5 commands are hardcoded to the most common location. This
will definitely fail if the commands are elsewhere, or if the md5
command doesn't support the -q 'quiet' option.
2012-06-15 00:04:01 -04:00
Stephen Fromm
4a6a3fd305
Conditionally import hashlib (issue #471 )
...
Import hashlib if it is there, otherwise import md5. Adds method
file_digest that wraps the logic on which module to invoke.
2012-06-14 07:18:46 -07:00
Michael DeHaan
7926ab5b95
Merge pull request #469 from nafeger/devel
...
Add support for older version of python-apt
2012-06-13 19:21:31 -07:00
Nathan A. Feger
1d553830f2
Add support for older version of python-apt
2012-06-13 13:57:47 -05:00
Stephen Fromm
9cf182c225
Add assemble module
...
This adds a module that concatenates (ie. assembles) a file from
fragments in a directory in alphabetical order. It chains the file
module afterward to fix up ownership and permission. This also adds
tests for the assemble module with fragments in assemble.d.
2012-06-11 23:09:54 -07:00
Michael DeHaan
9ff59090c2
capture possible chown stderr output
2012-05-31 22:19:05 -04:00
Michael DeHaan
5a8e61a610
Fix parsing error in file module when returning errors.
2012-05-31 22:14:33 -04:00
Michael DeHaan
4886b26ea9
Merge pull request #426 from dagwieers/facts
...
Add BIOS information and fix VMware detection (supports both IDE and SCSI)
2012-05-31 18:45:52 -07:00
Michael DeHaan
960e7c331c
Merge pull request #433 from bradobro/authorized_key
...
Renamed module, fixed idempotency, removed debug param.
2012-05-30 13:59:13 -07:00
Brad Olson
ab55b1a412
Renamed module, fixed idempotency, removed debug param.
2012-05-30 16:41:38 -04:00
Stephen Fromm
3eef7a629b
Update get_selinux_facts in setup module
...
This switches to using selinux library calls instead of parsing the
output of sestatus. This fixes issue #428 where the output was slightly
different than expected on F17. Tested against debian (non-selinux),
centos5, centos6, and fedora17.
2012-05-30 08:42:05 -07:00
Dag Wieers
50ef1bb93f
Add BIOS information and fix VMware detection (supports both IDE and SCSI disks)
2012-05-30 14:23:52 +02:00
Michael DeHaan
ecb944892d
Tweaks on previous refactoring of playbook, version bump a 0.4 reference, remove some debug, etc
2012-05-26 01:20:53 -04:00
Michael DeHaan
8a687b77f8
Merge pull request #391 from cocoy/reload-feature
...
Feature: Add state=reloaded
2012-05-19 14:26:20 -07:00
Michael DeHaan
0db6d73523
Merge pull request #393 from bradobro/fix_usergroup
...
0.4 fix, Remove call to undefined debug() in module 'user'
2012-05-15 10:04:28 -07:00
Brad Olson
2b8bc789c2
Remove call to undefined debug() in module 'user'.
...
I think when we stopped using stderr for debugging modules because
paramiko didn't like it, many modules used the idiom of defining
a debug function that used standard error. The def's and calls were
removed.
This looks like a stray debug() that didn't get removed and didn't
show up unless you alter a user's groups. If it's hit, 'user' fails
with a global undefined function error.
2012-05-15 09:19:43 -04:00
cocoy
25f808de8f
Add state=reloaded
2012-05-15 17:28:49 +08:00
Wes Johnson
5da7f2aff4
starting fresh, doing it 'right'
...
Lost commit history, but this way I'm not introducing crappy commit
history in RP
2012-05-14 14:31:53 -07:00
Michael DeHaan
54a56e478b
add fake module for 'raw'
2012-05-10 01:08:01 -04:00
Michael DeHaan
45100f03b1
Default git module to master branch so branch= is not required.
2012-05-10 00:41:44 -04:00
Michael DeHaan
e6416def6b
update comment about branch support, now that supported
2012-05-10 00:39:15 -04:00
Michael DeHaan
eb41bfd3c8
Allow service 'enable' parameter be 'enabled', which is what I'd personally try to use.
2012-05-09 23:13:13 -04:00
Cosmin Luță
c37014083a
Added a new fact: network address for an interface
2012-05-11 17:17:59 +03:00
Cosmin Luță
204bffa21e
Added parameter to the apt-get install command to prevent interactive conflict resolution
2012-05-11 10:54:55 +03:00
Michael DeHaan
d118cf3e31
Merge pull request #336 from sfromm/issue122
...
Issue122 - have all modules log to syslog
2012-05-09 17:19:24 -07:00
Michael DeHaan
0fe8e51cb5
Merge pull request #337 from ordrin/devel
...
Support for branches in git module
2012-05-09 17:18:32 -07:00
Stephen Fromm
aea022b002
Apply logging of arguments to modules (issue #122 )
...
The ohai and facter modules use /usr/bin/logger to log the fact that
they have been invoked. I added 'import os' to the ping module
so that it could have the same syslog statements as the other modules.
I separated the condensed:
shlex.split(open(argfile, 'r').read())
into two separate statements similar to the other modules.
2012-05-09 15:19:20 -07:00
felix
7ee6ae3663
removed unecessary branch addition from switchver
2012-05-08 16:24:29 -04:00
felix
c9fafcecbe
added in support for branches in git module (now takes optional "branch")
2012-05-08 16:20:08 -04:00
Stephen Fromm
73ffec9710
Move import of spwd under a try block
...
Resolves issue #333 . If spwd is not available, the password will
be set regardless.
2012-05-08 10:40:44 -07:00
Brendan Beveridge
be32d3b00f
Merge remote-tracking branch 'ansible-origin/devel' into devel
...
Conflicts:
library/user
2012-05-08 10:33:18 +10:00
Michael DeHaan
b460980d7d
Merge pull request #324 from lcosmin/devel
...
Prevent facter stderr messages from confusing ansible
2012-05-07 17:07:49 -07:00
Michael DeHaan
9b1add8c40
Reverting to apply correct attribution.
2012-05-07 20:07:12 -04:00
Michael DeHaan
3a027c2749
Don't let facter spew things to stderr and confuse Ansible, which now blends stdout/stderr due to paramiko
...
pty usage.
(This commit from lcosmin, manually applied due to github crossup on my part -- MPD)
2012-05-07 20:05:10 -04:00
Brendan Beveridge
5059588b17
remove now useless append check in user_mod
2012-05-08 09:49:37 +10:00
Brendan Beveridge
2635195185
Fixes issue #315
...
This adds some logic when usings groups possibly in combination with append
if just specifying groups and the current groups do not match the list
set groups
if specifying groups with append and any group thats not in the current groups
set groups with -a
2012-05-08 09:43:51 +10:00
Peter Sankauskas
d814136ec9
Code was adding '-a' even when the user was already in the desired groups causing usermod to fail since there was no '-G' option. This is duplicate code (3 lines) from the 'group' section, so could be improved, but it works.
2012-05-07 11:35:45 -07:00
Cosmin Luță
fba4d9232d
Prevent facter stderr messages from confusing ansible
2012-05-07 18:08:50 +03:00
Michael DeHaan
36559badd5
Merge pull request #316 from skvidal/devel
...
fix up service module to make it start processes that are listed to be
2012-05-06 16:43:20 -07:00
Michael DeHaan
0669ce858a
Refactored inventory to make it object oriented, need to make YAML format and executable script
...
format compatible with this still, and add some tests for INI-style groups of groups
and variables.
2012-05-05 16:31:03 -04:00
Seth Vidal
81418afbbb
fix up service module to make it start processes that are listed to be
...
running and to report errors from starting them
2012-05-04 01:20:51 -04:00
Rafal Lewczuk
3de61fb180
Fix: file module does not remove dangling symlinks
2012-05-01 22:56:37 -04:00
Michel Blanc
a7e4da92db
Fixes _find_binaries not using globals
...
_find_binaries now sets the right globals
Binaries are now properly populated (reverse path/binary for loops)
2012-05-03 12:36:06 +02:00
Michel Blanc
572868c9e1
Adds support for Ubuntu style update-rc.d
...
Checks if update-rc.d (Ubuntu) or chkconfig (RHEL) should be used.
Adds basic bin path search for those binaries
Adds 'enable' and 'disable' options for 'enable' command since it's the
arguments that update-rc.d uses (this might be somewhat confusing to
have a command line with 'enable=enable', but probably mkes sense for
Ubuntu users).
Allows use of mixed case for 'list' and 'state' commands.
2012-05-03 08:34:36 +02:00
Michael DeHaan
9ad4e7d149
Merge pull request #300 from sfromm/git
...
Updates for git module
2012-05-02 19:57:50 -07:00
Stephen Fromm
f1b7149fcf
Update how to set default selinux context for file
...
This removes the 'context' option and replaces it with checks for
'_default' value for seuser, serole, setype, or (maybe) selevel.
If '_default' is provided *and* there is a default context for the given
file, this will set the file context to the available default.
2012-05-02 11:38:44 -07:00
Stephen Fromm
887d293a3b
Add git reset --hard support to git module
...
Resets working tree to what is in HEAD and discards any
uncommitted changes.
2012-05-02 09:50:36 -07:00
Stephen Fromm
40dbd9b3d7
Add exit_json and fail_json to git module
...
This adds exit_json() and fail_json() to git module. It also sets
version to 'HEAD', if not provided.
2012-05-02 09:50:36 -07:00
Jeroen Hoekx
2c8fbdbd20
Group order in user module should not matter.
...
Groups are not necessarily returned in the defined order, especially when the user already existed before ansible started managing the system.
2012-05-02 11:54:27 +02:00
Michael DeHaan
594084bc9f
Merge pull request #287 from dne/user-group-add-system
...
Add 'system' option for user and group modules
2012-05-01 15:54:45 -07:00
Michael DeHaan
27582ad313
Merge pull request #281 from dne/file-link-relative
...
File module fix for symlink from relative source path
2012-05-01 15:41:46 -07:00
Michael DeHaan
dd380f67e6
Merge pull request #289 from skvidal/devel
...
service enable=on/off
2012-05-01 15:40:59 -07:00
Jeroen Hoekx
d96763346f
Make async wrapper kill the process it supervises.
...
It wasn't killing the job at all before.
Indentation was 3 spaces.
2012-05-01 18:38:26 -04:00