Commit graph

27 commits

Author SHA1 Message Date
Scott Anderson
baf508a379 Change standard AWS access and secret key parameter names to aws_access_key and aws_secret_key. Fixes an authentication problem with the rds module and standardizes the naming convention on something more encompassing than ec2_*_key. 2014-02-08 18:35:26 -05:00
Justin Ludwig
26374d89a0 Fix AWS credential params for s3 and other modules
The `ec2_ami`, `ec2_elb`, `ec2_tag`, `ec2_vpc`, `route53`, and `s3` modules
all canonicalize the AWS access and secret key params as
`aws_access_key` and `aws_secret_key`. However, following the fixes for #4540,
those modules now use `get_ec2_creds` from `lib/ansible/module_utils/ec2.py`,
which requires access/secret key params to be canonicalized as
`ec2_access_key` and `ec2_secret_key`. As a result, AWS credentials passed
to those six modules as parameters are ignored (they instead always use
the AWS credentials specified via environment variables, or nothing).

So this change fixes those six modules to canonicalize the
AWS access and secret key params as `ec2_access_key` and `ec2_secret_key`,
allowing them to again accept AWS credentials passed via module params.
2013-11-26 19:29:06 -08:00
James Tanner
fb903c5317 Change s3 module to use shared ec2 authorization module snippet 2013-11-12 14:13:05 -05:00
dragon3
e54832a730 Remove duplicate "download_s3file" execution when the destination path doesn't exist 2013-11-05 22:03:40 +09:00
Lorin Hochstein
1c5bdba977 s3: better check for walrus
Check for Walrus endpoint by looking to see if the endpoint is not AWS.

This fixes a bug where the user specifies an AWS endpoint via S3_URL,
but the code interprets it as Walrus and then fails.
2013-10-16 13:22:41 -04:00
James Tanner
d21a0287a2 Remove all sys.exit calls in the cloud/s3 module
Fixes #4458
2013-10-11 11:28:47 -04:00
Matthew Barrington
ce0bf71245 Fixed crash when s3 bucket did not exist for put operation 2013-10-11 16:01:54 +01:00
James Tanner
c679491ece #4408 s3: add force alias for overwrite and set True by default 2013-10-09 12:56:56 -04:00
James Tanner
c55107fa83 Remove debug comment from s3 module 2013-10-09 12:25:09 -04:00
James Tanner
9c3fb9c2b7 4006: return s3 url even if file exists 2013-10-09 12:12:24 -04:00
Michael DeHaan
d803ce7ab3 Fix documentation of default value in s3 module. Fixes #4289 2013-10-08 08:42:03 -04:00
Benno Joy
c1198dc12c change "Changed" to changed 2013-10-07 18:29:03 +05:30
bennojoy
00dcf0f1ac minor fixes 2013-10-02 13:27:54 +05:30
Jeremy Price
f56b3fba3e dest in s3 module does not work with ~username notation for home directories. Wrapped dest definition in os.path.expanduser() which will return the expanded path in case of successful tilde expansion and otherwise the original value 2013-09-19 00:32:13 -04:00
Bruce Pennypacker
0f458210bc Rebase attempt
No idea if I'm rebasing properly or not.  This is my first attempt.
2013-08-20 15:14:16 -04:00
Michael DeHaan
0b4e145709 Merge pull request #3772 from lorin/s3-docpatch
Minor doc update to s3 & ec2 modules
2013-08-06 13:30:20 -07:00
Michael DeHaan
0edcbdca05 Merge pull request #3709 from lwade/devel
S3folder
2013-08-06 13:01:43 -07:00
Lorin Hochstein
729c03ed88 Minor doc update to s3 & ec2 modules
Adds some additional docs about the module parameters for s3
and ec2 modules.
2013-08-06 12:23:25 -04:00
Michael DeHaan
dab48fa3ed Slight docs tweak and remove redundant sys.exit call 2013-08-03 14:25:27 -04:00
lwade
f6cb9bce15 Added ability to create virtual directories. 2013-07-31 11:51:57 +01:00
Peter Hall
d1369f3d95 Adding getstr mode to download an object into a variable 2013-07-23 11:03:00 +10:00
lwade
ae992c6b6e Rewritten s3 module to allow for additional modes of operation. 2013-07-04 15:55:06 +01:00
Jan-Piet Mens
5c69918d53 DOCS: standardize on EXAMPLES (a.k.a. Docs-JumboPatch JetLag Edition)
Migrated all examples: in DOCUMENTATION=''' string to standalone EXAMPLES=''' string
  Added deprecation warning to moduledev.rst and remove deprecated example from it
  Fixed up a few typos and uppercased some acronyms.
  add consistency to how EXAMPLES are formatted
2013-06-15 20:54:25 +02:00
Michael DeHaan
e06ced89fb Doc standardization/style 2013-06-01 12:09:04 -04:00
Shahar Kedar
fe6ca38bec Issue #3079: Initializing key_exists in case the S3 bucket does not exist 2013-05-31 16:37:37 +03:00
Ralph Tice
918de8d6dc amended s3 plugin to support 'dest' parameter to allow uploading to custom location 2013-05-02 14:27:12 -05:00
Michael DeHaan
391fb98ee2 Allow modules to be categorized, and also sort them when generating the documentation. 2013-04-28 15:03:45 -04:00
Renamed from library/s3 (Browse further)