cmueller/ansible
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity
7135 commits 47 branches 390 tags 440 MiB
Commit graph

7135 commits

This branch
This branch
All branches
Author SHA1 Message Date
Timothy Appnel
2ba32a8b10 Clarified and cleaned up grammar of error messages. 2015-08-26 11:59:31 -04:00
Timothy Appnel
0e42b1708b Fixed call to undefined attribute when RDS module timeouts waiting. 2015-08-26 11:58:16 -04:00
Brian Coca
8cc9fdde4a Merge pull request #1952 from manics/authorized_key-check_mode-user_path 
Don't fail in authorized_key check_mode if user exists
 2015-08-26 08:00:35 -04:00
Marius Gedminas
4ae4331a6b user: don't generate SSH keys in check mode 
Fixes https://github.com/ansible/ansible/issues/11768

Test plan:

- (in a Vagrant VM) created a user 'bob' with no ssh key
- ran the following playbook in check mode:

    ---
    - hosts: trusty
      tasks:
        - user: name=bob state=present generate_ssh_key=yes

- saw that ansible-playbook reported "changes=1"
- saw that /home/bob/.ssh was still absent
- ran the playbook for real
- saw that /home/bob/.ssh was created
- ran the playbook in check mode again
- saw that ansible-playbook reported no changes
- tried a variation with a different username for a user that didn't
  exist: ansible-playbook --check worked correctly (no errors, reported
  "changed")
 2015-08-26 08:51:52 +03:00
Marius Gedminas
eb17b6a36c apt: check for "0 upgraded" to be at the beginning of the line 
Fixes #1678.
 2015-08-25 19:15:33 +03:00
Brian Coca
116793889f Merge pull request #1915 from leedm777/patch-1 
ec2_vol: Added missing "needs 2.0" doc
 2015-08-24 18:44:15 -04:00
Toshio Kuratomi
b29276df34 Merge pull request #1204 from detiber/test_rhsm 
bugfixes for redhat_subscription
 2015-08-24 12:54:03 -07:00
Brian Coca
aae5177164 Merge pull request #1966 from tback/devel 
Delete dead and broken code
 2015-08-24 14:20:10 -04:00
Till Backhaus
39e7e05a8d Delete dead and broken code 2015-08-24 20:06:53 +02:00
Tony Kinsley
bd210e42bc Adding start and stop actions to os_server_actions 
Also making the os_server module allow a server in the possible new
states from the os_server_actions changes
 2015-08-23 11:51:28 -07:00
Brian Coca
bc6a8761a1 Merge pull request #1958 from omriiluz/Bugfix-for-1957 
No need for .keys on volumes list
 2015-08-23 14:01:47 -04:00
Omri Iluz
daf7a0551b No need for .keys on volumes list 
Since c3f92cca21 changed "volumes" to be a list instead of a dictionary, we don't need (and cannot) .keys when appending to set.
Reported as bug #1957
 2015-08-23 02:29:39 -07:00
Chris Church
1d074d43aa * Update core modules to fix strict mode errors. 
* Also fix creates parameter issue in win_msi as described in https://github.com/ansible/ansible-modules-core/issues/129, slightly different fix from https://github.com/ansible/ansible-modules-core/pull/1482
* Fix setup.ps1 module issue described in https://github.com/ansible/ansible-modules-core/issues/1927
 2015-08-22 19:01:11 -04:00
James Cammarata
85ddb1b902 Fixing region requirement regarding euca clusters 
Fixes ansible/ansible#11023
 2015-08-22 12:32:40 -04:00
Brian Coca
630e8ef9a6 Merge pull request #1954 from nitzmahone/setup_uptime 
added windows facts ansible_lastboot, ansible_uptime_seconds
 2015-08-21 17:40:58 -04:00
nitzmahone
2a5f3754e7 added windows facts ansible_lastboot, ansible_uptime_seconds 
switched OS object to Get-CimInstance since we need a DateTime object for lastbootuptime
 2015-08-21 13:37:29 -07:00
Bruno Galindro da Costa
f7f621839a Added termination_policies option 2015-08-21 14:13:09 -03:00
Simon Li
428550e179 Don't fail in check_mode if user exists 
PR #1651 fixed issue #1515 but the requirement for path to be defined is unecessarily strict. If the user has previously been created a path isn't necessary.
 2015-08-21 17:55:28 +01:00
Brian Coca
2af3f34d58 Merge pull request #1926 from cjchang/keystone_user 
support creating role only
 2015-08-21 00:07:14 -04:00
Jérémie Astori
72fb7a0a17 Fix physical walk on acl module for Linux 
`-h` is for BSD [1] while `-P`/`--physical` is for Linux [2].
This commit fixes that option now that acl module is (temporarily)
only supported for Linux.
I will re-add `-h` when fixing BSD support.

[1]: http://www.freebsd.org/cgi/man.cgi?format=html&query=setfacl(1)
[2]: http://linuxcommand.org/man_pages/setfacl1.html
 2015-08-20 23:35:53 +00:00
Jérémie Astori
8eefd44aef Make sure entry is not sent when acl state=query 2015-08-20 22:59:00 +00:00
Jérémie Astori
0e659ad872 Make sure permission-less entries are accepted when state=absent 
Also, remove that try condition as, at that stage, no permissions with
other than 2 or 3 fields are sent to the function.
 2015-08-20 22:58:49 +00:00
Toshio Kuratomi
4721d6d8b5 Fix for the case where plugins aren't loaded on old RHEL systems 2015-08-20 15:34:57 -07:00
Jérémie Astori
e95bcaeb8a Remove support for d[efault]: in entry permissions 
It is not documented in [the Ansible doc page][1] nor
[the BSD setfacl man entry][2] (which means it might not be compatible
with BSD) so removing it does not break the API.

On the other hand, it does not conform with POSIX 1003.1e DRAFT
STANDARD 17 according to the [Linux setfacl man entry][3] so safer to
remove.

Finally, the most important reason: in non POSIX 1003.e mode, only ACL
entries without the permissions field are accepted, so having an
optional field here is very much error-prone.

[1]: http://docs.ansible.com/ansible/acl_module.html
[2]: http://www.freebsd.org/cgi/man.cgi?format=html&query=setfacl(1)
[3]: http://linuxcommand.org/man_pages/setfacl1.html
 2015-08-20 22:22:28 +00:00
Toshio Kuratomi
c228739f2d Merge pull request #1946 from ansible/pr/1657 
Update check-mode results to be a dictionary (finishes pr 1657)
 2015-08-20 13:14:02 -07:00
Toshio Kuratomi
9d4694122d Return change results in a dictionary listing the package names. 
Fix a parsing problem when package names contain a dot.
 2015-08-20 13:02:29 -07:00
Matt Martz
51b800d1df Merge pull request #1943 from richbria/devel 
Preventing servers that are deleted and left in the deleted state from being included in the server list
 2015-08-20 12:34:31 -05:00
Brian Richards
e4a5f3b409 Preventing servers that are deleted and left in the deleted state from being included in the server list 2015-08-20 11:07:58 -05:00
Toshio Kuratomi
c6d09d8f8d Merge pull request #1920 from ilya-epifanov/devel 
fixed memory_limit for docker api version  >= 1.19
 2015-08-20 09:03:54 -07:00
Nithy Renganathan
4171d167f4 Handle the changed value 2015-08-20 14:24:05 +00:00
Jason Cowley
8215aad3b3 Add support for S3 canned permissions. resolves #1939 2015-08-19 11:40:07 -07:00
Brian Coca
f925f7e01f Merge pull request #1734 from freym/assemble-file-validation 
assemble: add file validation support.
 2015-08-19 11:15:21 -04:00
Toshio Kuratomi
8841c85505 Merge pull request #1934 from SamYaple/refix_bug_1226 
Refix bug 1226 after revert
 2015-08-19 04:17:59 -07:00
Sam Yaple
54804d25e3 Actually remove the section we are replacing 2015-08-19 08:52:05 +00:00
Sam Yaple
dddb5270c8 Refix bug 1226 after revert 
This patch properly fixes bug 1226 without introducing a breaking
change to idempotency which was introduced in PR #1358

We can properly assign permissions to databases with a '.' in the name
of the database as well as assign priviliges to all databases as
specified with '*'
 2015-08-19 04:23:03 +00:00
Jérémie Astori
3ac990556d Fix wrong expectation regarding entry format in acl module 2015-08-19 00:26:04 +00:00
Jérémie Astori
421d3f12cf Fix wrong processing of lines returned by setfacl in test mode 2015-08-19 00:25:18 +00:00
Jérémie Astori
50c6425673 Fix minor whitespace issues 2015-08-19 00:24:08 +00:00
Brian Coca
5913f5e5e1 deal with more failures when apt module fails to instantiate pkg 
fixes #1499
 2015-08-18 14:59:35 -04:00
Brian Coca
65270a172e Merge pull request #1857 from SamYaple/devel 
Revert "escapeds changes"
 2015-08-18 11:47:52 -04:00
HAMSIK Adam
dfac073343 Rebase start/stop instance pull code 2015-08-18 14:32:48 +02:00
Mahesh Sawaiker
f459b3773c support creating role only 2015-08-17 16:28:18 +00:00
Brian Coca
ff3b88c4d7 Merge pull request #1925 from kostyrevaa/devel 
Fix documentation of authorized_key.py
 2015-08-17 11:36:07 -04:00
Александр Костырев
31ec203583 Fix documentation of authorized_key.py 
man for sshd http://www.openbsd.org/cgi-bin/man.cgi/OpenBSD-current/man8/sshd.8?query=sshd
says there's no "host" option but "from".
 2015-08-17 18:00:04 +03:00
Ilya Epifanov
d951172920 fixed memory_limit for docker api version >= 1.19 2015-08-16 18:34:56 +03:00
Brian Coca
d61fde42ef updated encoding comment and expanded authors field 2015-08-14 22:01:05 -04:00
Brian Coca
d4a39d23df Merge pull request #150 from astorije/recursive_acl 
Add recursive support for ACL module
 2015-08-14 20:21:01 -04:00
Jérémie Astori
acfc2166b0 Set version number in recursive option description 2015-08-14 23:40:47 +00:00
Jérémie Astori
f8027a7f0a Ensure Python 2.4 compatibility and Linux-restricted support 
- Make build_entry compatible with Python 2.4
- Re-add missing warning/comment that was forgotten while refactoring
- Replace `all()` with a good ol' for-loop Python 2.4 compatibility
- Make a condition check more explicit (when `state` is `query`)
- Make sure this module can only be run with on a Linux distribution
- Add a note about Linux-only support in the documentation
- Set the version in which recursive support was added, 2.0
 2015-08-14 22:06:51 +00:00
David M. Lee
6a8108133d ec2_vol: Added missing "needs 2.0" doc 
The ability to find-or-create a volume was added in 2.0. Added note to
the example.
 2015-08-14 13:01:44 -05:00