Commit graph

27619 commits

Author SHA1 Message Date
jcastilloixl
5e2451c1a8 Update net_interface.py (#58350)
typo in example command -- net_interface module accidentally listed as junos_interface
2019-06-25 14:37:37 -05:00
René Moser
360a9f1a68
exoscale: exo_dns: fix sanity checks (#58312) 2019-06-25 21:20:41 +02:00
Strahinja Kustudic
7fd10d821c Add service_account_contents parameter to allign with the modules (#57848) 2019-06-25 14:40:10 -04:00
Fred-sun
42a831d42c Update azure_rm_sqlserver related document (#58267)
* Update azure_rm_sqlserver related documentation
2019-06-25 11:33:12 -05:00
Fred-sun
bb2c7cf57d Update azure_rm_sqlfirewallrule related document (#58265)
* Update azure_rm_sqlfirewallrule related documentation
2019-06-25 11:32:11 -05:00
Matt Martz
e32d60bbcd
Add back _contains_vars method as maybe_template (#58290)
* Add back _contains_vars method as maybe_template. Fixes #58282

* Remove template guard in a few places

* maybe_template sounds like it might template something, rename to is_possibly_template

* Add tests for is_possibly_template
2019-06-25 10:54:37 -05:00
Matt Martz
bc25ac20e1
Set _ansible_verbose_override in gather_facts action plugin. Fixes #58310 (#58339) 2019-06-25 10:28:09 -05:00
Martin Krizek
9069a681aa sysctl: fix 'err' referenced before assignment (#58161)
* sysctl: fix 'err' referenced before assignment

Fixes #58158

* Add changelog
2019-06-25 11:13:34 -04:00
Tim Rupp
48af9bdfec Adds tls_version argument to mqtt module (#58264)
Fixes: #22034

This patch adds support for a tls_version parameter that allows the
TLS version used to be configurable. By default the module will let
the underlying system libraries pick the maximum supported version.

This parameter is useful for servers that are unable to support
newer versions of TLS
2019-06-25 15:27:32 +02:00
Wojciech Wypior
ac101f7f33 adds initial_hotfix parameter to vcmp guest (#58180) 2019-06-25 15:26:09 +02:00
Wojciech Wypior
d591014163 fixes an issue where rule_lists were not correctly applied to the AFM policy (#58181) 2019-06-25 15:25:22 +02:00
Ondra Machacek
d50ee592d0 kubevirt: Add hostname and subdomain parameters (#57223) 2019-06-25 15:19:27 +02:00
Ganesh Nalawade
fcc32bcf0e
Fix junos netconf plugin get_configuration filter (#58271)
* junos `get_configuration` netconf api expects the
  filter as instance of ElementTree object
2019-06-25 16:00:56 +05:30
Andrey Klychkov
cf528c562a postgresql_membership: remove debug print (#58315) 2019-06-25 13:42:11 +05:30
Mike Frost
307a7c5853 This comment is no longer needed, as the calculation is done in the 'grow' method (#58109) 2019-06-25 03:55:01 -04:00
markafarrell
8555b728c3 also allow None Type for safe eval (#58269) 2019-06-24 17:05:18 -04:00
lolcube
547a29805e openssh_keypair: bugfix make regenerating keypairs via force possible… (#57801)
* openssh_keypair: bugfix make regenerating keypairs via force possible / add invalid file handling

* openssh_keypair: change permissions of read-only file instead of deleting it for regeneration; add changelog fragment

* address review feedbak, refactor

* add integration tests for bigfixes

* linter: fix indent

* fixup integration tests: use force when regenerating an invalid file

* linter: fix indent

* openssh_keypair: address review feedback

* openssh_keypair: fixup, remove backtick

* openssh_keypair: address review feedback

* Only pass 'y' into stdin of ssh-keygen when file exists.
2019-06-24 21:45:49 +02:00
Matt Martz
57d8b68c03
Use to_text on value to activate _fail_with_undefined_error (#58214)
* Use to_text on value to activate _fail_with_undefined_error. Fixes #12186

* Add comment explaining in depth what to_text gives us
2019-06-24 12:43:18 -05:00
David Stark
958f740cc3 fixed reference to a non-existing hcloud_server parameter (#57659) 2019-06-24 13:20:55 -04:00
Mariusz Mazur
4d357ffca5 kubevirt: replace nested function with one from utils
Use dict_transformations.dict_merge() in kubevirt's merge_dicts()
2019-06-24 09:26:00 -07:00
Brian Goad
23fcae7c9e Fix issue with displaying error about unreachable hosts when using Unixy Callback (#58076) 2019-06-24 11:58:04 -04:00
Ganesh Nalawade
67c251d13c
Fix junos modules persistent connection check (#57986)
Fixes #57985

*  The check `USE_PERSISTENT_CONNECTION` flag is no longer
   required in action plugin as the junos modules in galaxy are renamed
   to start with `juniper_`.
2019-06-24 19:24:20 +05:30
Andrey Klychkov
278c59b17e postgresql_privs: bugfix of 27327 - incorrect views handling (#58272) 2019-06-24 18:08:12 +05:30
Martin Nečas
f94da94e62 ovirt add nic linked (#58053)
* ovirt add nic linked

* add version added

* update check method
2019-06-24 07:51:27 -04:00
rajaspachipulusu17
fc1798cc14 Pluribus Networks ipv6security raguard module with UT (#57031)
* Pluribus Networks ipv6security raguard module with UT
* Doc fixes
2019-06-24 16:29:41 +05:30
Ganesh Nalawade
94fe139f04
Revert "Fix junos module transport check (#58050)" (#58270)
This reverts commit f864f621d8.
2019-06-24 15:18:17 +05:30
pratikgadiya12
44058e9425 Allow multiple databases(not all) to be dumped from mysql (#56721)
* Allow multiple databases(not all) to be dumped from mysql

Fixes: #56059

* Altered fail message to provide atleast one database name

* Minor grammatical fix
2019-06-24 09:29:18 +02:00
Michael Cassaniti
372b896ed1 win_snmp: Fixed example documentation (#58222) (#58261) 2019-06-24 08:00:18 +01:00
Felix Fontein
75ca8eb42f
openssl_certificate: fix failing SAN comparisons (#58256)
* Fix failing SAN comparison for older cryptography versions due to not implemented __hashh__ functions.

* Fix SAN comparison: IPv6 addresses need to be normalized before comparing strings.

* Add changelog.

* Fix comment.
2019-06-24 06:34:12 +02:00
Felix Fontein
808cf4aa26
Remove from sanity ignores. (#57911) 2019-06-23 14:20:26 +02:00
Felix Fontein
4a12be31fb docker_* modules: improve error message when docker-py is missing (#57914)
* Improve error for docker modules when docker-py can't be imported.

* Add changelog.

* Mention platform and Python interpreter in more cases.

* Clarify wording.

* Adjust tests.
2019-06-23 06:27:33 -04:00
Miguel Angel Muñoz González
64c3b4fbb5 New HTTPAPI plugin for FortiOS (#56870)
* New HTTPAPI plugin for FortiOS

* Remove special char

* Updates after review - Comments from Qalthos
2019-06-22 19:31:21 -04:00
Klaus Frank
fbdf6e59f2 Fix ansible-vault cipher_whitelist (#57272)
* Fix ansible-vault cipher_whitelist Fixes: #57271

* Add changelog for #57272
2019-06-22 11:14:37 -04:00
Wojciech Wypior
de03c007bc BIGIP: fixes issue with image installation on multiblade platforms (#58176)
* fixes issue with image installation on multiblade platforms

* test
2019-06-21 17:12:30 -07:00
Wojciech Wypior
30ada17d4f Adds message routing transport module (#58201) 2019-06-21 12:58:02 -07:00
Wojciech Wypior
b8fd2f4df3 adds generic routing peer module (#58189) 2019-06-21 12:56:25 -07:00
Wojciech Wypior
429bf5340e adds module for message routing protocol (#58188) 2019-06-21 12:56:03 -07:00
Wojciech Wypior
0a3a94a493 adds new module to manage firewall schedules (#58187) 2019-06-21 12:55:50 -07:00
Wojciech Wypior
92a1e6845c Adds two modules to manage AFM log profiles (#58186) 2019-06-21 12:55:37 -07:00
Sam Doran
bd55617a5b
hostname - Correct distribution for various Linux distros based on output from distro library (#56936)
* Adjust hostname classes based on output from distro

Corrects the following:
- OpenSUSE Leap
- ArchARM
- Oracle Linux

* Add CoreOS and Clear Linux distributions
2019-06-21 14:29:41 -04:00
MyronFanQiu
1539e0e855 a doc fix for azure_rm_virtualmachinescaleset (#56448) 2019-06-21 12:12:26 -04:00
Wojciech Wypior
fbca93b8ad removes args from the code and corrects few missed tests (#58175) 2019-06-21 09:09:39 -07:00
Wojciech Wypior
56b3b1ac56 adds message routing router module (#58191) 2019-06-21 09:09:14 -07:00
Wojciech Wypior
c1f2df4753 adds message routing route module (#58190) 2019-06-21 09:08:56 -07:00
Derrick Johnson
b86c7759c5 Update Documentation mso_schema_template_bd.py (#58020)
* Update mso_schema_template_bd.py
2019-06-21 12:04:38 -04:00
Fred-sun
1b7ef47776 Update azure_rm_securitygroup related document (#58035)
* Update azure_rm_securitygroup related document
2019-06-21 12:00:18 -04:00
Fred-sun
1c49a9110a Update azure_rm_servicebus related document (#58105)
* Update azure_rm_servicebus related document
2019-06-21 11:59:07 -04:00
Fred-sun
7e70184f10 Update azure_rm_servicebusqueue related document (#58160)
* Update azure_rm_servicebus related document
2019-06-21 11:55:09 -04:00
Fred-sun
af000444d2 Update azure_rm_sqldatabase related document (#58163) 2019-06-21 11:53:51 -04:00
akatch
200eed6177 Implement display_ok_hosts and display_skipped_hosts for unixy (#53179)
* Implement display_ok_hosts and display_skipped_hosts like default callback

* Implement show_custom_stats and display_failed_stderr like default callback

* Fix pep8

* Clarify conditional

* Changelog fragment

* Import from defaults.py per feedback
2019-06-21 11:22:16 -04:00
Wojciech Wypior
95e59e7ee7 adds description to bigip snatpool (#58179) 2019-06-21 07:52:46 -07:00
Wojciech Wypior
655ad7456d adds multiple new parameters to bigip_profile_http (#58183) 2019-06-21 07:16:47 -07:00
Wojciech Wypior
022b5d8b79 adds support for IPV4 addressing for interfaces (#58182) 2019-06-21 07:16:31 -07:00
Wojciech Wypior
66c828d45f adds new parameters to tcp profile module (#58185)
minor fix in policy module
2019-06-21 07:07:48 -07:00
Wojciech Wypior
07fc880b3c minor fixes in two modules (#58178) 2019-06-21 07:07:17 -07:00
Wojciech Wypior
3531bf3148 fixes issue with ssl protocols ordering (#58177) 2019-06-21 06:46:53 -07:00
Wojciech Wypior
cee3d539cb Fixes issue with failure messages (#58173) 2019-06-21 06:45:57 -07:00
Wojciech Wypior
becca36c5e Added new module for remote user management (#58171) 2019-06-21 06:45:29 -07:00
Tobias
e7c39460ed ipaddr: Handle ipaddress index in network correctly (#57896)
This commit prevents integer indices from being parsed as ip nets

Fixes #57895

Signed-off-by: Tobias Schramm <tobleminer@gmail.com>
2019-06-21 15:26:08 +02:00
Kevin Breit
0f12e1c7d8 Meraki - Improve type information in module documentation (#58114)
* Improve type information in module documentation
- Removed some duplicate documentation
- Ensure org_id is always string
- Add type information for items which don't have it

* Fix whitespace
2019-06-21 09:25:03 -04:00
Sumit Jaiswal
58d446e61a
PR to fix where ansible_net_model was not being populated (#58159)
* fix bug 57285

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* minor fix

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* adding TC fix related

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* fix shippable error

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
2019-06-21 16:18:59 +05:30
markafarrell
43872d6b88 Fix netconf guess_network_os to use ssh_config if supplied. (#55199)
* feature: use network_os=auto to trigger network os guessing

* doc: add debug messages

* fix linting

* fix test_netconf_init default network_os is auto

* add documentation

* fix rst errors

* use init lexer

* Update docs/docsite/rst/network/user_guide/platform_netconf_enabled.rst

Co-Authored-By: Sandra McCann <samccann@redhat.com>

* Update docs/docsite/rst/network/user_guide/platform_netconf_enabled.rst

Co-Authored-By: Sandra McCann <samccann@redhat.com>

* Update docs/docsite/rst/network/user_guide/platform_netconf_enabled.rst

Co-Authored-By: Sandra McCann <samccann@redhat.com>

* Update docs/docsite/rst/network/user_guide/platform_netconf_enabled.rst

Co-Authored-By: Sandra McCann <samccann@redhat.com>

* Update docs/docsite/rst/network/user_guide/platform_netconf_enabled.rst

Co-Authored-By: Sandra McCann <samccann@redhat.com>

* Update docs/docsite/rst/network/user_guide/platform_netconf_enabled.rst

Co-Authored-By: Sandra McCann <samccann@redhat.com>

* Update docs/docsite/rst/network/user_guide/platform_netconf_enabled.rst

Co-Authored-By: Sandra McCann <samccann@redhat.com>

* Update lib/ansible/plugins/connection/netconf.py

Co-Authored-By: Sandra McCann <samccann@redhat.com>

* Update lib/ansible/plugins/connection/netconf.py

Co-Authored-By: Sandra McCann <samccann@redhat.com>

* Update lib/ansible/plugins/connection/netconf.py

Co-Authored-By: Sandra McCann <samccann@redhat.com>

* Update docs/docsite/rst/network/user_guide/platform_netconf_enabled.rst

Co-Authored-By: Sandra McCann <samccann@redhat.com>

* Update docs/docsite/rst/network/user_guide/platform_netconf_enabled.rst

Co-Authored-By: Sandra McCann <samccann@redhat.com>

* Update docs/docsite/rst/network/user_guide/platform_netconf_enabled.rst

Co-Authored-By: Sandra McCann <samccann@redhat.com>
2019-06-21 09:04:13 +05:30
Ganesh Nalawade
f864f621d8
Fix junos module transport check (#58050)
*  Since new junos resource modules will
   support only network_cli connection type
   modify the transport check from network_cli
   connection netconf as netconf only supported modules
   is a fronzen set.
2019-06-21 08:56:52 +05:30
The Magician
28b67d809f Bug fixes for GCP modules (#58107) 2019-06-20 20:51:43 -04:00
Kohei Asano
ddf6d096c5 Support the new TLS termination on NLBs (#51327) (#58031) 2019-06-20 17:03:04 -07:00
Felix Fontein
f8f2738351 docker_*: make modules more robust on Docker errors (#57913)
* Improve general error behavior if a Docker error is not caught.

* Don't die when network doesn't exist.

* Add changelog.

* Make API version always available. Also catch errors when retrieving version.

* Fix error message.

* Adjust fallback error messages.
2019-06-20 16:59:15 -04:00
Dmitriy Yakovlev
122d4164c5 docker_swarm_service: Added default value for mounts.source (#58039)
* Added default value for mounts.source

* Added the changelog fragment

* Added tests

* Fixed separators

* Moved the teardown section at the end
2019-06-20 15:58:32 -04:00
Felix Fontein
4188cd299b crypto modules: Improve requirements / error messages (#57868)
* Reformat requirements.

* Include Python lib versions in lib required error messages, if available.

* Update lib/ansible/modules/crypto/openssl_publickey.py

Co-Authored-By: MarkusTeufelberger <mteufelberger@mgit.at>

* Add changelog.
2019-06-20 21:31:00 +02:00
Alberto Murillo
320d05dc30 tower_workflow_template: Add missing options (#56891)
The following options can be set on a workflow template but the
functionallity to do so from this module was missing.

inventory
ask_variables_on_launch
ask_inventory_on_launch

Fixes #49728

Signed-off-by: Alberto Murillo <albertomurillosilva@gmail.com>
2019-06-20 13:55:37 -04:00
Stefan Prietl
9dbc838d99 Add rudimentary wait for os_zone (#54391)
This adds a rudimentary wait functionality for the os_zone module.

It will wait for:
* Zone not in OpenStack API when choosing `absent`
* Zone `status` being `AVAILABLE` in OpenStack when choosing `present`
2019-06-20 13:00:57 -04:00
panticz
d0ee6e1e54 Implement protected parameter (#54114)
* Implement protected parameter

* version_added field

* Remove point at at the end of the sentence

* Update version_added to 2.9
2019-06-20 12:47:18 -04:00
A Codeweavers Infrastructure Bod
2f70c90efd Update apt.py (#56479)
* Update apt.py

Tested under Debian 9 with installation of Apache2 and PostgreSQL
In both cases the daemons are started immediately upon installation

https://www.alextomkins.com/2018/03/runlevel-apt-get-install-package-alternative/
https://major.io/2014/06/26/install-debian-packages-without-starting-daemons/
2019-06-20 12:10:28 -04:00
Josef 'veloc1ty' Stautner
bdb089b910 Update sysctl.py (#57984)
##### SUMMARY
Quote values to mitigate this ansible warning:

+label: docsite_pr
2019-06-20 11:46:25 -04:00
Tom Moore
67e02b5eee Corrected module example in documentation (#58124) 2019-06-20 11:37:05 -04:00
pratikgadiya12
2b5ad94a96 vmware_guest_disk_facts: return controller_bus_number and controller_type (#58117)
Fixes: #57608
Fixes: #57998
2019-06-20 20:07:17 +05:30
Matt Martz
ffd117132f
Create new instance of the action plugin per until iteration. Fixes #57886 (#58022) 2019-06-20 09:17:50 -05:00
Matt Martz
375ac76e58
ssh: Ensure debug messages are properly converted to text (#57850)
* ssh: Ensure debug messages are properly converted to text. Fixes #57843

* surrogate_then_replace is default, be less explicit

* We only needed to_text for display, not exceptions
2019-06-20 09:15:53 -05:00
smile37773
3a3465c47d Add the way to create a VM with the image id (#58106) 2019-06-20 16:42:09 +08:00
Cameron Nemo
cc7bea2100 plugins/connection/netconf: remove unimplemented option (#58104)
closes #51972
2019-06-20 12:07:10 +05:30
Yurii Vlasenko
8c1c2afd02 docker_container: Change expected config source (#57969)
* Change expected config source

* make it conditional

* rename property

* Add changelog fragment

* make it string

* Update changelogs/fragments/57969-docker_container-change-expected-config-source.yml

Co-Authored-By: Felix Fontein <felix@fontein.de>
2019-06-19 23:32:59 +02:00
The Magician
8b6c6cf302 Bug fixes for GCP modules (#58041) 2019-06-19 14:20:43 -04:00
Jeya
bdd0bbf50a [nxos] New parameter vrf in nxos_file_copy (#57851)
* [nxos] New parameter vrf in nxos_file_copy

* Fix version_added

* Fix documentation default value
2019-06-19 21:26:07 +05:30
Chris Van Heuveln
52c811c841 nxos_bgp_neighbor: Add bfd support (#56932)
* nxos_bgp_neighbor: Add bfd support

- Add support for bfd state in nxos_bgp_neighbor

- Feature Pull Request

- nxos_bgp_neighbor

- Tested on platforms: `N3K,N6K,N7K,N9K`

* bfd T/F now bfd enable/disable

* pep fix ws
2019-06-19 21:23:00 +05:30
Chris Van Heuveln
727a6b405a nxos_ospf_vrf: Add 'bfd' support (#57425)
* nxos_ospf_vrf: Add 'bfd' support

* Add default to bfd doc hdr

* bfd T/F now bfd enable/disable
2019-06-19 21:22:32 +05:30
Chris Van Heuveln
30830a4482 nxos_pim: Add bfd support (#56908)
* nxos_pim: Add bfd support

* Add integration sanity

* minor cleanup

* bfd T/F now bfd enable/disable
2019-06-19 21:22:03 +05:30
Mike Wiebe
12d656901f Add CmdRef logic to handle multiples (#57495)
* Add CmdRef logic to handle multiples

* Fix python 2.6 issues

* Fix bug when existing is not a dict object

* Fix python2 vs python3 incompatibilty

* Ignore unnecessary-lambda warning
2019-06-19 21:15:32 +05:30
Kevin Breit
8f68c8d438 meraki_snmp - Enable check mode (#54625)
* Add support for check mode

* Add diff support

* Remove check mode for idempotent action
2019-06-19 11:35:10 -04:00
Fred-sun
8cff96e388 Update azure_rm_roledefinition related document (#57927)
* Update azure_rm_roledefinition related documentation
2019-06-19 09:27:30 -05:00
Nathaniel Case
f656959861
Fix RESTCONF media types (#58015)
Fixes #56680
2019-06-19 10:22:24 -04:00
Andrey Klychkov
64d0559e9f Postgres module_utils: add get_connect_params + unit tests (#58067)
* add get_conn_params

* add get_conn_params: add to the modules
2019-06-19 06:49:19 -07:00
René Moser
6bace8aa54
vultr: vultr_account_facts -> info (#57563) 2019-06-19 14:10:55 +02:00
Zim Kalinowski
ee32222ae7 fixing vmss failure (#56625)
* triggering test

* deleting autocreated as last one

* fixed mistake
2019-06-19 05:00:43 -04:00
MyronFanQiu
ec95086b69 add support for https (#57785) 2019-06-19 15:14:53 +08:00
endurancetest20380119
3d452fb917 Update azure_rm_aks.py (#57898) 2019-06-19 15:13:16 +08:00
Martin Nečas
c609fad106 Ovirt vnic profile fix (#57936)
* ovirt vnic profile fix init

* ovirt vnic profile fix init

* update syntax whitespace

* document pass_through

* create get entity method

* update example syntax

* update docs

* change force_create style
2019-06-18 21:46:41 -04:00
Rob
feae35ab7e add IAM role assumption to aws_ec2 inventory (#41637)
* add IAM role assumption to aws_ec2 inventory
* Ensure inventory._options has necessary option keys populated since the plugin docs parser isn't accessible to unit tests yet
2019-06-18 15:34:41 -07:00
Dusan Matejka
8646b6953d updated zabbix modules to use missing_required_lib helper (#58002) 2019-06-18 16:57:09 -04:00
Andrey Klychkov
186210af8a postgresql modules: remove unused imports, remove blank lines after docstrings 2019-06-18 12:55:32 -07:00
The Magician
a1128b6b94 Bug fixes for GCP modules (#58016) 2019-06-18 15:45:47 -04:00
Martin Nečas
b4d4f77963 Ovirt add managed storage domain (#57995)
* init managed storage domain

* add version added

* add no log for sensitive options

* add driver default types

* update docs

* update pep8 syntax

* update example syntax

* update example syntax

* set default domain_fucntion for managed_block_storage

* correct pep8 syntax

* update managed example

* update managed docs
2019-06-18 14:05:48 -04:00