cmueller/ansible
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity
9644 commits 47 branches 390 tags 440 MiB
Commit graph

9644 commits

This branch
This branch
All branches
Author SHA1 Message Date
James Laska
5cfefb326a Correct check_mode conditional logic 
The desired behavior is to _not_ add the ppa signing key when check_mode is
enabled.  This fix corrects the conditional logic to comply with the stated
behavior.
 2014-03-14 10:24:52 -04:00
Michael DeHaan
b2350d8aaf Merge pull request #6480 from do3cc/patch-1 
Properly catch import errors in apt
 2014-03-14 08:02:10 -05:00
Patrick Gerken
38d6956c1f Properly catch import errors in apt 
When one accidentally tries to run this module as a user, he gets the error message that python-apt must be installed, no matter what. Because importing apt will trigger an exception as a regular user. Explicitly catching the ImportError will let the exception bubble. The exception clearly says Permission denied somewhere, and the user has a better idea, what he must fix.
 2014-03-14 02:13:20 +01:00
Michael DeHaan
47bfa8b9eb Update index.rst 2014-03-13 19:30:01 -05:00
Michael DeHaan
9eb3f8779c Merge pull request #6468 from philpep/fix_apt_key 
apt_key: Fix traceback when key_id format is invalid
 2014-03-13 17:58:40 -05:00
Michael DeHaan
9c189ed7a4 Merge pull request #6470 from patrickheeney/doc-git-fix 
Fix documentation for accept_hostkey in GIT module
 2014-03-13 17:57:56 -05:00
Michael DeHaan
a669d6a151 Merge pull request #6477 from angstwad/docs-fix 
Documentation updates
 2014-03-13 17:50:50 -05:00
James Cammarata
316d1ca977 Updating CHANGELOG/RELEASES in devel for 1.5.3 and older releases 2014-03-13 16:31:19 -05:00
James Cammarata
8df29e7c8b Cleaning up some exception blocks in TestModuleUtilsBasic 2014-03-13 16:24:29 -05:00
James Cammarata
a0cb974575 Be sure to return to the old directory if cwd is set in run_command 2014-03-13 16:24:29 -05:00
Paul Durivage
32996bf121 Documentation updates 2014-03-13 16:18:50 -05:00
James Tanner
a348f67238 Reset the current directory after running subprocess.Popen 2014-03-13 17:15:23 -04:00
James Cammarata
69ff355726 Adding new unit tests for module_utils/basic (run_command only now) 2014-03-13 14:56:44 -05:00
James Cammarata
677008bef7 Rejoin args list into a string for run_command when using an unsafe shell 
This allows the use of an args list with leading environment variables,
which otherwise would fail due to the way Popen works.
 2014-03-13 14:31:32 -05:00
James Cammarata
5233d4bc31 Fix typo in run_command when sending data that is not binary 2014-03-13 14:28:51 -05:00
James Cammarata
b1a37dcc08 Revert "Rejoin args list into a string for run_command when using an unsafe shell" 
This reverts commit 4273cb2d8e.
 2014-03-13 14:04:51 -05:00
James Cammarata
4273cb2d8e Rejoin args list into a string for run_command when using an unsafe shell 
This allows the use of an args list with leading environment variables,
which otherwise would fail due to the way Popen works.
 2014-03-13 13:51:59 -05:00
James Cammarata
b93b99871b Fix small typo resulting in a traceback for the apt_key module 2014-03-13 13:51:59 -05:00
James Tanner
b0d22b76bd Add an ast.parse unit test for modules to simulate ansible-doc 2014-03-13 12:01:55 -04:00
James Laska
07dd02c25a [test_ec2*] cloud integration test updates 
To support parallel cloud test execution, create and provide a random string to
cloud integration tests.  The variable 'resource_prefix' can be used in cloud
roles and during resource cleanup to safely create/destroy cloud-based
resources.

Additional changes include:

 * The roles test_ec2_key and test_ec2_group were updated to use to
 {{resource_prefix}}.

 * Additionally, the Makefile was updated to set resource_prefix to a random
 string.  The Makefile will also use 'resource_prefix' during cloud_cleanup.

 * All test_ec2* roles were updated to add 'setup_ec2' as a role dependency.
 2014-03-13 11:28:02 -04:00
patrickheeney
fae36165a2 Fix documentation for accept_hostkey 2014-03-13 07:58:12 -07:00
Philippe Pepiot
92e8e59cad apt_key: Fix traceback when key_id format is invalid 
Signed-off-by: Philippe Pepiot <phil@philpep.org>
 2014-03-13 15:28:37 +01:00
Michael DeHaan
d1753046e0 Revert "Correctly catch template errors without returning invalid data" 
This reverts commit 3cd7d47b7e.
 2014-03-13 07:46:19 -04:00
Richard Isaacson
e6f6a73328 Merge pull request #6461 from risaacson/modules_make_run_command_safer 
Modules make run command safer
 2014-03-12 23:28:06 -05:00
Richard C Isaacson
2b53ece3ab mysql_db module: typo fix 
Tests clean.
 2014-03-12 23:25:22 -05:00
Richard C Isaacson
427221786c Shell updates. 2014-03-12 22:15:56 -05:00
James Cammarata
bd16cce3e9 Merge pull request #6460 from jsmartin/riak-bugfix 
Fixes various typos, fetch_url now working, changed command composure for wait_for_service
 2014-03-12 21:56:39 -05:00
James Cammarata
ccc0a8cbb0 Fix regression in dnsmadeeasy module caused by fetch_url change 
Also:
* changed this module to use https for requests to the API
* fixed a bug in which a traceback was caused when the domain wasn't found

Fixes #6457
 2014-03-12 20:48:22 -05:00
James Martin
3d032b9db9 Fixes various typos introduced in a9017af2bb. 
Fixes odd encoding problem with wait_for_service.
 2014-03-12 21:26:16 -04:00
Daniel Jaouen
81f2e43b76 Fix Homebrew._current_package_is_installed 2014-03-12 19:52:16 -04:00
James Laska
9cc4be2683 Correct test integration ec2 cleanup script 2014-03-12 19:29:46 -04:00
Michael DeHaan
e753b39eae Merge pull request #6453 from jlaska/test_git 
Additional test scenarios in roles/test_git
 2014-03-12 17:21:53 -05:00
Michael DeHaan
78ebf5d266 Still more shell fixes. 2014-03-12 17:44:53 -04:00
Michael DeHaan
98500b335b Fixup shell handling in monit module. 2014-03-12 17:43:31 -04:00
Michael DeHaan
dac90278db More shell fixes 2014-03-12 17:43:31 -04:00
James Tanner
6067d826e4 Close parens in portinstall 2014-03-12 17:36:48 -04:00
Michael DeHaan
4e8b97ddeb More shell updates 2014-03-12 17:31:00 -04:00
James Tanner
e7f74251c8 Fix missing colons in cpanm 2014-03-12 17:25:32 -04:00
James Tanner
89024f5d9f Fix typo in portinstall 2014-03-12 17:12:38 -04:00
Michael DeHaan
c193604f60 Some more run_command updates. 2014-03-12 17:04:34 -04:00
James Cammarata
303e085f8b Only use cwd in run_command kwargs if the directory exists 2014-03-12 15:59:55 -05:00
Michael DeHaan
81b4ebbe1d Fixes for run_command shell usage in remainder of packaging modules, save portinstall. 2014-03-12 16:57:18 -04:00
Michael DeHaan
6010e74839 Various commits to enable no-shell or safe-shell usage, more to come. 2014-03-12 16:44:35 -04:00
James Laska
bc678e7d7b Add credentials.template and support custom INVENTORY 
Testers may override the inventory and vars-file using the environment
variables 'INVENTORY' and 'VARS_FILE'.
 2014-03-12 15:45:10 -04:00
James Laska
5c9dc33e41 Additional test_git scenarios 
Includes coverage for accept_hostkey and additional scm URL formats.
 2014-03-12 15:45:10 -04:00
James Cammarata
60a7f57300 Make sure the cwd exists in run_command before trying to use it 2014-03-12 14:33:31 -05:00
James Cammarata
751510141f Merge branch 'patch-1' of https://github.com/dmkoch/ansible into dmkoch-patch-1 2014-03-12 14:28:07 -05:00
James Cammarata
21d629f012 Merge pull request #6446 from patricksmith/fix-git 
git: Execute git commands in `dest` directory
 2014-03-12 14:25:46 -05:00
Michael DeHaan
29c32890d5 Add notes about module.run_command to coding guidelines. 2014-03-12 15:19:16 -04:00
Dan Koch
bbf320fd22 Work around for cwd stat problems with run_command and sudo 
This fixes issue #6443
 2014-03-12 14:59:50 -04:00