Commit graph

39758 commits

Author SHA1 Message Date
Dag Wieers
3034709df0 Improve GitHub templates (#44455)
* Improve GitHub templates

The existing templates are basically a copy for each type of issue (bug,
feature, doc) whereas we can make the template more specific to the task
at hand.

This PR includes:
- More specific sections depending on the type of issue
- More concise and direct instructions (NO NEED FOR FRUSTRATION CAPS!)
- Single-line comments (no need to guide people to avoid wrong edits)
- Improved paste area
- Better headings/titles
- No 'Summary' title for PRs (so commit information is placed correctly)

This PR would require some improvements to Ansibot.

* Remove controversial Ansibot stuff

Make it easier to get the first batch merged.

* Restore ISSUE_TEMPLATE.md

* Incorporate reviewer suggestions

* Make OS / ENVIRONMENT doc-related

* Rephrase Ansibot-related message
2018-09-04 16:31:45 +01:00
Dougal Seeley
a6c97f2243 ec2_vpc_route_table - allow routes to be created if the CIDR already exists but its 'Origin' is 'EnableVgwRoutePropagation' (which cannot be replaced). (#43417)
Fixes #43415
2018-09-04 11:18:33 -04:00
Protista
80bea8adaf Add definitive to valid_simple_controls in pamd module (#44601)
* Add definitive to valid_simple_controls in pamd module

* Add changelog fragment for issue 44278

* Adjusted module name to not include path or extension
2018-09-04 11:14:22 -04:00
Sandra McCann
fe119c18ef fixed formatting (#45164)
(cherry picked from commit 58ca82fa1c)
2018-09-04 09:33:01 -05:00
Allen Fair
8fb589d55e Returns reason on pkg update error (#44982)
Previously, it returned no additional information:

     "msg": "Could not update catalogue"

Now it passes that reason with the error message:

    {"changed": false, "msg": "Could not update catalogue [77]:  pkg: Insufficient privileges to update the repository catalogue.\n"}
2018-09-04 10:27:57 -04:00
joren485
cd5d484f7a Fix dead code in files module (#43479)
* Use pwd.getpwnam instead of non-existent pwd.getpwname

* Add specific exceptions to pwd and grp calls
2018-09-04 09:06:57 -05:00
Max Cameron
cf1006179d Fixes ec2.py assume_role. (#37357)
* Fixes ec2.py assume_role

Previously when connect_to_aws was called it updated the credentials in place.  "connect_to_aws" is called multiple times: on the second run it tries to assume the same role it is already using, and potentially failing depending on your iam policies.
2018-09-04 09:43:58 -04:00
characteristic
324b57d6ae Correct Jinja2 plugin math filter symmetric_difference() to not repeatedly (#45093)
build its intersection set and unnecessarily unique the final result.

The prior use of the intersect() function within the list comprehension
conditional leads to the function being called for every value in the input
list being processed, not efficient.  When the input lists a,b are large,
the Ansible run time and resource utilization wildly increases generally
never completing the operation.

Unique of the intersection result is unnecessary as the source list union()
is already unique.
2018-09-04 09:12:02 -04:00
Abhijeet Kasurde
4e9b8136c2 Add support for Devuan (#45148)
Devuan is part of Debian family. This fix adds support for Devuan OS.

Fixes: #45047

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-09-04 08:38:57 -04:00
Ryan S. Brown
617b8df5e6 Add rds_instance to module_defaults groups 2018-09-04 08:17:58 -04:00
Abhijeet Kasurde
b3b65d16b8
Handle special service where package is not available (#45155)
There are several services e.g. vmware-fdm, which does not have package name and
package description which will raise a error if queried for.

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-09-04 17:03:44 +05:30
Abhijeet Kasurde
885ee25375
Documentation for several VMware modules (#45153)
* Added return for vmware_host_config_facts
* Added return for vmware_host_service_facts
* Correct typo in vmware_portgroup_facts

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-09-04 16:37:14 +05:30
Trishna Guha
ab3cd10dfe
fix Python 2.6 regex bug terminal plugin nxos, iosxr (#45135)
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-09-04 13:44:43 +05:30
Zim Kalinowski
b1b90faf96 added missing resource_group description in return value (#45143) 2018-09-04 04:04:51 -04:00
Zim Kalinowski
e7ec1ef59c adding tags to container instance (#45142) 2018-09-04 03:56:10 -04:00
Ganesh Nalawade
455dfbe732
Fix netconf module and plugin issues (#45140)
* Fix netconf netconf issues

*  Identifier is optional for get_schema api
*  Fix dispatch api mandatory argument check
*  Add save option handling to copy config from target datastore
   to startup datastore if supported
*  Validate config in check-mode or if validate option set to true

* Copy config if check-mode is not enabled
2018-09-04 13:23:18 +05:30
linnil1
177fbea351 Fix sshkeyfilename is None not str (#44893) 2018-09-04 11:59:08 +05:30
Toshio Kuratomi
fdb51b34da Add a table of contents to the generated changelog (#45046) 2018-09-04 07:25:23 +01:00
Senthil Kumar Ganesan
3beeeffef9 Docs updated and review comments addressed (#45133) 2018-09-04 07:13:59 +01:00
Zim Kalinowski
d4aa7db323 consolidate sql tests into one (#45064) 2018-09-04 12:30:09 +08:00
Zim Kalinowski
1f8635fbd9 Virtual machine facts - retrieving instance view (#45128) 2018-09-04 11:25:01 +08:00
Zim Kalinowski
9bd702ef37 vm size idempotence (#45108) 2018-09-04 09:41:41 +08:00
Zim Kalinowski
55c549a832 added mysql management client to remove api version warning (#45103) 2018-09-04 09:23:11 +08:00
Madhura-CSI
a4663d8e73 New module for azure custom image facts (#42102)
* new module for azure custom image facts

* added facts in aliases, corrected assertion

* simplified managed disk id struct

* updated ansible version
2018-09-04 02:28:01 +08:00
Matt Clay
b3a3e8ba7b
Update test constraints. (#44975)
- Limit virtualenv version on Python 2.6.
- Limit pyopenssl version on Python 2.6.
- Pin pyfmg version to keep unit tests passing.
2018-09-03 09:34:22 -07:00
Dag Wieers
e99db084f4
aci_interface_policy_leaf_policy_group: Fix filtering by lagT (#45088) 2018-09-03 16:40:57 +02:00
Dag Wieers
6faf400621
aci_switch_policy_vpc_protection_group: Fix idempotency (#45091) 2018-09-03 16:39:39 +02:00
Rémy Léone
aeac8fe141 Add licence and boilerplate to Online module_utils 2018-09-03 07:24:25 -07:00
Zim Kalinowski
5c9241fa7c merge mysql server and database tests (#45060) 2018-09-03 16:52:09 +08:00
Zim Kalinowski
9b28319020 adding container instance facts (#43326) 2018-09-03 15:51:42 +08:00
Rémy Léone
f465a251e1 Add a dynamic inventory plugin for Online (#44720) 2018-09-03 02:33:15 -04:00
Yunge Zhu
b58141555d fix blob in non-public azure cloud (#44802)
* fix blob in non-public azure cloud

* fix  lint

* fix typo
2018-09-03 11:16:23 +08:00
vpopescu
b4c148b6ea fixed boolean value for zone (#41974) 2018-09-03 10:20:16 +08:00
Yunge Zhu
107ae1a4f3 improve vmss test (#44892)
* improve vmss test

* fix lint

* fix lint

* fix lint

* fix  test bug
2018-09-03 09:52:22 +08:00
Zim Kalinowski
d8cf645a8c merging postgresql server and database facts (#45061) 2018-09-03 09:49:18 +08:00
Zim Kalinowski
5fee46a8ec added postgresql management client version (#45079) 2018-09-03 09:47:31 +08:00
Sebastian Gumprich
961836093e remove myself from bot-notifications (#45087) 2018-09-03 02:21:59 +02:00
Felix Fontein
fec302b162 Fixing typo in acme_certificate docs. (#45082) 2018-09-02 13:01:45 -04:00
Matt Clay
bbca98ae8e Fix PEP8 issue. 2018-09-01 22:54:13 -07:00
Dan Farrell
667f62c5a8 Update lineinfile.py (#44976)
* Update lineinfile.py

The document should call out in the regexp section what regexp does in non-match scenario, not just leave it for the reader to find it under `insertbefore` and `insertafter`.  
+label: docsite_pr

* Update lineinfile.py

fixing for lint

* Use multiple entries
2018-09-02 05:18:33 +02:00
Jonathan
93cd050250 Added default value for when CloudFrontOriginAccessIdentityList is (#44984)
missing.
2018-09-02 12:17:25 +10:00
zikalino
0ee598a710 added missing public ip address alias 2018-09-01 17:05:23 -07:00
Matt Martz
f89d873698
Stub out modules scheduled for 2.8 removal (#44985)
* Remove modules scheduled for 2.8

* Add changelog and porting guide

* Skip docs test on removed modules

* Don't link to removed modules
2018-08-31 16:27:32 -05:00
Dag Wieers
b64e666643
Add elapsed return value to select modules (#37969)
* Add elapsed return value to select modules

It can be quite useful to know exactly how much time has elapsed
downloading/waiting. This improves existing modules or updates
documentation.

* Ensure elapsed is always returned

* Added changelog fragment
2018-08-31 22:20:56 +02:00
Toshio Kuratomi
af3bac1320 Also remove the .changes.yaml file 2018-08-31 11:41:13 -07:00
Toshio Kuratomi
3994300762 Update ansible version number to 2.8.0.dev0 2018-08-31 11:11:13 -07:00
Toshio Kuratomi
2d6594b34f Reset changelogs for the 2.8.0 development cycle 2018-08-31 11:11:13 -07:00
Rémy Léone
5cf9644003 Add an user facts module for Online (#44709) 2018-08-31 14:02:40 -04:00
Sam Doran
d257095976 Change Mac OSX to macOS in installation docs (#44971)
* Change Mac OSX to macOS in docs

* Lowercase via
2018-08-31 11:12:12 -05:00
S. Veyrié
60af5ab962 maven_artifact: enforce required params (fixes #44823) (#44967) 2018-08-31 11:38:09 -04:00