cmueller/ansible
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity
8592 commits 47 branches 390 tags 440 MiB
Commit graph

8592 commits

This branch
This branch
All branches
Author SHA1 Message Date
Jan-Piet Mens
d0912b84ef documentation typos 2014-01-21 09:03:14 +01:00
Rob Smith
761fe8cc04 Fix an issue where git-pull fails with AttributeError 
As part of 94f3b9bfab the code was changed to support dynamically adding localhost to the inventory. This change introduced an crash when run via ansible-pull

```
Starting ansible-pull at 2014-01-20 23:09:57
Traceback (most recent call last):
  File "/tmp/ansible/bin/ansible", line 157, in <module>
    (runner, results) = cli.run(options, args)
  File "/tmp/ansible/bin/ansible", line 82, in run
    hosts = inventory_manager.list_hosts(pattern)
  File "/tmp/ansible/lib/ansible/inventory/__init__.py", line 372, in list_hosts
    result = [ h.name for h in self.get_hosts(pattern) ]
  File "/tmp/ansible/lib/ansible/inventory/__init__.py", line 136, in get_hosts
    subset = self._get_hosts(self._subset)
  File "/tmp/ansible/lib/ansible/inventory/__init__.py", line 177, in _get_hosts
    that = self.__get_hosts(p)
  File "/tmp/ansible/lib/ansible/inventory/__init__.py", line 198, in __get_hosts
    hpat = self._hosts_in_unenumerated_pattern(name)
  File "/tmp/ansible/lib/ansible/inventory/__init__.py", line 275, in _hosts_in_unenumerated_pattern
    ungrouped.add_host(new_host)
AttributeError: 'NoneType' object has no attribute 'add_host'
```

The root cause is there is no group for the host to be added to. I fixed this case by creating the ungrouped group when it doesn't exist and then adding the host to the newly added group. This fixes the regression for me.
 2014-01-20 20:10:47 -08:00
jctanner
4b9127f0af Merge pull request #5695 from kormoc/fix_git_check_hostkey_2 
Fix case where there is a ~/.ssh/known_hosts file and the host key is only in /etc/ssh/ssh_known_hosts
 2014-01-20 19:03:27 -08:00
Rob Smith
953dc6b345 When not finding a host in ~/.ssh/known_hosts, the return value is 0 if the host just is not found. We then never check the system host file in /etc. This fixes the code to check /etc on any failure, not just a bad return code. 2014-01-20 18:56:39 -08:00
Paul Durivage
f72f5a20df Revert "Revert "Merge pull request #5325 from angstwad/add-su-support"" 
This reverts commit c17d0e0357.

Conflicts:
	lib/ansible/runner/connection_plugins/paramiko_ssh.py
 2014-01-20 19:19:03 -06:00
Paul Durivage
4c84ba74b0 Resolve su bug in paramiko libs 2014-01-20 19:16:37 -06:00
Jesse Keating
6013f0738e Store the list of hosts to run on in runner object 
This reduces the number of times inventory.list_hosts is called, which
can be costly. When coming from a playbook that data is already known.
 2014-01-20 16:22:28 -08:00
Jesse Keating
e8ad36c8d4 Store hosts for a play as a play attribute 
Operate on that play attribute to make things faster for larger
inventories. Instead of making a round trip through inventory.list_hosts
and working through some lengthy list comprehensions over and over
again, calculate the potenital hosts for a play once, then reduce from
it the unavailable hosts when necessary.

Also moves how the %fail is done. The host count is a play level count
of available hosts, which then is compared after each task to the
current number of available hosts for the play. This used to get a new
count every task which was also time expensive.
 2014-01-20 16:22:28 -08:00
Michael DeHaan
24f11168d9 Update CHANGELOG.md 2014-01-20 19:11:40 -05:00
Michael DeHaan
f420af0676 Update CHANGELOG.md 2014-01-20 19:11:15 -05:00
James Tanner
94f3b9bfab Fixes #3129 Do not require localhost to be in inventory 2014-01-20 18:26:14 -05:00
Matt Martz
89fbc64b60 Fix regex match, the printf match should work with 0 or more numeric padding characters, not 1 or more 2014-01-20 16:43:42 -06:00
James Tanner
c17d0e0357 Revert "Merge pull request #5325 from angstwad/add-su-support" 
This reverts commit 6f4bfa2cff, reversing
changes made to c91ba3a7c7.
 2014-01-20 16:10:11 -05:00
jctanner
6f4bfa2cff Merge pull request #5325 from angstwad/add-su-support 
Proposing fix for Issue #4324; adding support for su
 2014-01-20 11:55:40 -08:00
Michael DeHaan
c91ba3a7c7 Merge pull request #5680 from biolds/devel 
Mark stat module as supporting check_mode
 2014-01-20 10:48:52 -08:00
Paul Durivage
8cf071f697 Hostvars support for su 2014-01-20 12:01:28 -06:00
Paul Durivage
dec9131735 Ensure playbook support for su params 2014-01-20 11:46:56 -06:00
Paul Durivage
d21281ff43 Resolve rebase conflicts 2014-01-20 11:46:05 -06:00
Paul Durivage
ab6ee1a282 Enable su support in paramkio; disable su support in fireball, local, accelerate, chroot, jail, funcd connection plugins 2014-01-20 11:25:10 -06:00
Paul Durivage
c95be4ceaa Make sudo and su command line arguments mutually exclusive 2014-01-20 11:25:10 -06:00
Paul Durivage
4088243deb Proposing fix for Issue #4324; adding support for su in connection plugins ssh, ssh_alt 
Fixes for ssh_alt support, adding in references to in_data where appropriate
 2014-01-20 11:25:10 -06:00
jctanner
297a28aa79 Merge pull request #5333 from mvermaes/yum_fix 
yum module: Attempt #2 to cause yum to fail on invalid url
 2014-01-20 06:45:01 -08:00
jctanner
7b76ad9e62 Merge pull request #5676 from simonz05/bugfix-sysctl-multivalue2 
Correctly compare values returned by 'sysctl -e -n'
 2014-01-20 06:11:29 -08:00
Michael DeHaan
2060ae550a Update changelog 2014-01-19 13:22:28 -05:00
Michael DeHaan
26676ce2e2 update default EC2 exclude regions -- this should be the best configuration for most users, but some may still want to tweak. 2014-01-19 13:13:43 -05:00
Laurent Defert
f93b951bdd Mark stat module as supporting check_mode 2014-01-18 22:32:58 +01:00
Simon Zimmermann
3db808c840 correctly compare the values, better func name 2014-01-18 11:04:15 +01:00
Simon Zimmermann
055b404f13 Correctly compare values as returned from 'sysctl -e -n' 2014-01-18 10:50:24 +01:00
Michael DeHaan
e3e6f02835 Merge pull request #5669 from mscherer/fix_synchronize_local 
Make synchronize module work better with local transport, fix #5668
 2014-01-17 14:20:22 -08:00
Michael DeHaan
0afa0b4aed Merge pull request #5672 from simonz05/patch-1 
fix str format error due to missing '%' in sysctl module
 2014-01-17 14:19:48 -08:00
Simon Zimmermann
7495095496 fix str format error due to missing '%' in sysctl module 2014-01-17 22:31:12 +01:00
Michael DeHaan
b8676203b9 Merge pull request #5586 from tbielawa/spiff_up_plugins 
Spiff up the 'Developing Plugins' page
 2014-01-17 12:34:06 -08:00
Michael Scherer
5c5c8fd7ce Make synchronize module work better with local transport, fix #5668 2014-01-17 17:32:36 +01:00
James Tanner
3bd99903a4 Fixes #5661 Handle null values for sysctl parameters 2014-01-17 11:30:07 -05:00
Michael DeHaan
3064ca94e9 Merge pull request #5665 from Taytay/devel 
Colon in example failure message causes a YAML compile error
 2014-01-17 06:02:00 -08:00
Taylor Brown
5fce765601 Removing colon from example failure message 
The example failure message was given as - fail: msg="Bailing out: this play requires 'bar'"

The colon in the example causes a YAML compile error, so I am replacing it with a '.'
 2014-01-17 14:09:52 +01:00
Rutger Spiertz
dec6345fe6 PlayBook: better error message 
When a PlayBook has missing arguments the error message now shows which ones are missing.
 2014-01-17 10:30:57 +01:00
Michael DeHaan
2a46022bc7 Merge pull request #5658 from rishid/devel 
Add support for Scientific Linux for hostname module
 2014-01-16 17:55:24 -08:00
jctanner
450bb37c8c Merge pull request #5655 from scottgilbert/devel 
Allow keystring passed to authorized_key to contain blank lines and comments
 2014-01-16 14:22:57 -08:00
James Tanner
19cb22b6df Fixes #5656 quote values with multiple columns before calling 
the sysctl command. Calling sysctl should also not be true by default
 2014-01-16 16:30:13 -05:00
rishid
34f9349b5e Add support for Scientific Linux for hostname module 
hostname module was lacking support for Scientific Linux, this commit adds it.
 2014-01-16 16:08:51 -05:00
James Tanner
559e89036b Fixes #5631 Return a unique list of hosts when joining groups 2014-01-16 14:24:11 -05:00
James Cammarata
02ce5af6df Added ANSIBLE_SSH_PIPELINING option to enable/disable pipelining support 
Pipelining will be disabled by default, since it requires users remove
the 'requiretty' option from the servers sudoers configuration.
 2014-01-16 12:41:33 -06:00
Scott Gilbert
0aedd0c0b2 Allow keystring passed to authorized_key to contain blank lines and comments 2014-01-16 12:14:37 -06:00
James Tanner
2c39576e80 Remove unused variable from authorized_key 2014-01-16 11:46:06 -05:00
jctanner
1f1fa6c09a Merge pull request #5322 from bcrochet/neutron-fip-select 
quantum_* modules: Neutron name change, keeping backward compatibility
 2014-01-16 08:37:38 -08:00
James Cammarata
233aae5861 Reverting paramiko_ssh/alt changes from yesterday 2014-01-16 09:45:28 -06:00
Michael DeHaan
87e7b9e5cc Merge pull request #5640 from willthames/ec2_elb_docs 
ec2_elb module: Minor improvements to documentation
 2014-01-15 19:18:49 -08:00
willthames
238da3cb02 ec2_elb module: Minor improvements to documentation 
ELB(s) cause a weird formatting behaviour - it appears as EL**s**
Added choices documentation to the state option
 2014-01-16 13:14:44 +10:00
Michael DeHaan
20d39c9cab Merge pull request #5636 from sivel/rax-no-log 
Do not log the rax api_key argument in module invocation
 2014-01-15 19:14:38 -08:00