Brian Coca
df6d58614e
now actually adds usable name for systemd when service only has init
...
script
2014-12-05 12:45:01 -05:00
Toshio Kuratomi
5af4463823
Gixes to doc formatting
2014-12-03 08:17:15 -08:00
Toshio Kuratomi
799a75580a
Update cron example for setting to run twice a day
...
Fixes #415
2014-12-02 14:38:32 -08:00
Brian Coca
943f8fe7c9
Merge pull request #346 from bcoca/service_cleanup
...
service cleanup
2014-12-02 11:03:03 -05:00
Jonathan Mainguy
a75bef5bc6
Fixes bind mounts
...
Fixed tab's and spaces, or so I think I did
Fixed tabs and spaces for real this time
2014-12-01 21:31:44 -05:00
Achilleas Pipinellis
a375ce33d3
Clarify supported init systems.
2014-12-01 16:15:24 +02:00
Pascal Borreli
32a00ec3a3
Fixed typo
2014-11-28 16:36:21 +01:00
Fabrice Bernhard
1ef8c26c0e
Typo in comments
...
Credit goes to @kbsali
@pborreli : you did not see that one? :-)
2014-11-27 12:36:34 +01:00
Brian Coca
29d211e7ab
service cleanup
2014-11-17 22:32:16 -05:00
Brian Coca
f49120598f
service now detects systemd is actually running, not just installed
2014-11-17 15:03:49 -05:00
Jonathan Mainguy
8b8008569f
fixes user module for rhel5 by using -n instead of -N, all other distros will still use -N
2014-11-17 13:26:08 -05:00
Robert Estelle
4dd099fe7a
Remove incorrect executable permissions.
2014-11-13 18:08:48 -05:00
Brian Coca
04680ce228
Merge pull request #286 from bcoca/hostname_24_compatible
...
made hostname work with python 2.4
2014-11-13 12:39:01 -05:00
Patrik Lundin
eea4d06848
Fix typo: Replace "N0" with "NO".
2014-11-13 12:39:29 +01:00
Brian Coca
83669d7eda
switched to iterator as per comments
2014-11-11 09:39:03 -05:00
Martijn P. Rijkeboer
5257222f33
Fix whitespace around '=' in sysctl.conf.
2014-11-10 20:00:28 +01:00
Brian Coca
e4b6968901
made hostname work with python 2.4
2014-11-08 12:08:47 -05:00
David Fritzsche
c96a85fb70
Add working status detection for pf on FreeBSD
...
The return code of "service pf onestatus" is usually zero on FreeBSD (tested with FreeBSD 10.0), even if pf is not running. So the service module always thinks that pf is running, even when it needs to be started.
2014-10-31 11:41:51 +01:00
Toshio Kuratomi
7f611468a8
Fix for systemd service scripts with newlines
...
Fixes #127
2014-10-22 16:43:35 -04:00
Patrik Lundin
f9d9c1b6d7
Multiple fixes for OpenBSD rcctl handling.
...
* Use the newly added 'default' argument to know if the default flags are set
or not.
* Handle that 'status' may either return flags or YES/NO.
* Centralize flag handling logic.
* Set action variable after check if we need to keep going.
Big thanks to @ajacoutot for implementing the rcctl 'default' argument.
2014-10-12 18:41:23 +02:00
Patrik Lundin
e463400412
Simplify self.arguments logic.
...
Strange logic pointed out by @jarmani, thanks!
2014-10-06 21:20:20 +02:00
Patrik Lundin
924cf20cf8
Depend more on rcctl if it is present.
...
* Make the module support enable/disable of special services like pf via rcctl.
Idea and method from @jarmani.
* Make the module handle when the user supplied 'arguments' variable does not
match the current flags in rc.conf.local.
* Update description now that the code tries to use rcctl for everything if it
is available.
2014-10-06 21:20:20 +02:00
Patrik Lundin
5f37624eb4
Tweak error checking for "enabled" code.
...
Based on input from @jarmani:
* A return value of 2 now means a service does not exist. Instead of
trying to handle the different meanings of rc after running "status",
just look at stderr to know if something failed.
* Skip looking at stdout to make the code cleaner. Any errors should
turn up on stderr.
2014-10-06 21:20:20 +02:00
Patrik Lundin
c6dd88c1d1
Fail if "rcctl status" writes to stderr.
2014-10-06 21:20:20 +02:00
Patrik Lundin
1a8cdb5e3e
Check rc and print error message if any.
...
It is probably good to use stdout before printing a generic error
message as well.
2014-10-06 21:20:20 +02:00
Patrik Lundin
c46e030100
Make "enabled" code aware of --check mode.
2014-10-06 21:20:20 +02:00
Jonathan Armani
1b97390765
Add enable / disable of services for OpenBSD if rcctl is present
2014-10-06 21:20:20 +02:00
louis
45f41f4b05
added skeleton support in user module
2014-09-30 08:16:19 +02:00
billwanjohi
ff36edbb11
user: add expired state
...
ported from
https://github.com/ansible/ansible/pull/6303
It's very useful and routine to disable a *nix user.
I implemented expired instead of locked because this prevents any use of
the account, safer than just preventing password-based authentication.
I have tests [1], but since none of the suite came along with the core
modules, I'm unsure how to submit them.
[1] https://github.com/billwanjohi/ansible/blob/add_locked_state/test/integration/roles/test_user/tasks/main.yml
2014-09-29 22:42:28 +00:00
kustodian
82af074382
Set selinux state to 'permissive' for state=disabled
2014-09-30 00:33:55 +02:00
Michael Scherer
37d9903169
Add hostname to generated user SSH key comment
...
The default is not very useful to sort between different
keys and user. Adding the hostname in the comment permit to later
sort them if you start to reuse the key and set them in different
servers. See https://github.com/ansible/ansible/pull/7420
for the rational.
2014-09-29 18:07:41 -04:00
Michael DeHaan
385a037cd6
package files
2014-09-26 11:05:47 -04:00
Michael DeHaan
c8e1a2077e
file extensions!
2014-09-26 10:37:56 -04:00
Michael DeHaan
417309a626
Restructuring.
2014-09-26 10:13:26 -04:00
Michael DeHaan
73123b69fa
Move modules into subdirectory.
2014-09-26 09:23:50 -04:00
Toshio Kuratomi
8b81062be0
The fix for gh-7284 causes problems for initscripts which have the
...
standards compliant return codes but return a verbose error message via
stdout. Limit the times when we invoke the heuristic to attempt to work
around this.
2014-09-22 14:53:07 -04:00
Michael Scherer
c9a0a7ae4b
Fix #9704 , correctly set changed as false when nothing is done
2014-09-21 14:55:31 +02:00
Toshio Kuratomi
7b100dd389
Be more specific in checking if a job restarted successfully.
...
Fixes : #9056
2014-09-19 12:03:27 -07:00
Toshio Kuratomi
36083c3b90
Failure to enable a service now fails the task
...
Fixes: 8855
2014-09-18 12:39:54 -07:00
Toshio Kuratomi
a50258d26a
remove debugging that was causing failure
2014-09-17 10:25:54 -07:00
Toshio Kuratomi
2e16bd3a44
Refactor the Linux service_enable() method
...
* Fix check_mode for initctl systems
Fixes #9009
2014-09-17 09:34:33 -07:00
Toshio Kuratomi
104401805b
Revert "Refactor the Linux service_enable() method" needs some debugging
...
This reverts commit e294e31fd3
.
2014-09-17 09:17:33 -07:00
Toshio Kuratomi
c362902f50
Refactor the Linux service_enable() method
...
* Fix check_mode for initctl systems
Fixes #9009
2014-09-17 08:44:32 -07:00
Toshio Kuratomi
a9928492f7
Make systemd vs rht detection more robust for centos
...
Centos 6.x and below use an old RHT style of configuring hostname.
CentOS 7.x and better use systemd. Instead of depending on the
distribution string which seems to have changed over the course of 6.x
we need to explicitly check the version.
Fixes #8997
2014-09-16 09:53:13 -07:00
James Cammarata
7edcf21bdc
Move initscript rc check to later in service status check
...
Fixes #7284
2014-09-11 12:11:06 -05:00
Michael DeHaan
5aa6ddef7f
Tracebacks are now catchable with ignore_errors and have streamlined output. Also removes 'baby-JSON' for bash modules.
2014-09-11 12:27:21 -04:00
Patrik Lundin
0abf14ff19
service: use self.changed in service_enable_rcconf().
...
This sets the "changed" result of the module when a rc file is modified.
Previously only --check mode would show that it was going to change.
2014-08-28 00:52:23 +02:00
James Cammarata
30d6713bf0
Add additional checks to detect upstart services
...
Also adds checks for the upstart version, in order to test check
support for manual vs. start on manual
2014-08-25 13:41:39 -05:00
Eri Bastos
6f8a29dc3d
Proposed fix for issue #7757
2014-08-25 12:10:14 -05:00
James Cammarata
c8376e296f
Tweaking change to documentation language for cron name param
2014-08-25 09:54:21 -05:00