Commit graph

23124 commits

Author SHA1 Message Date
Brian Coca
9a6530be77 clarify free strategy (#44645)
* clarify free strategy
* wordsmithing
* shorten line per Shippable
2018-09-05 20:24:37 -05:00
Yunge Zhu
2955d7cd1b add publish url in webapp facts output (#45131)
* add publish url in webapp facts output

* update name

* fix test
2018-09-06 08:04:09 +08:00
Tim Rupp
4154cab278
Updates documentation formatting and dependencies (#45252)
The documentation formatting was a bit incorrect and the dependencies
mentioned were out of date. This fixes that.
2018-09-05 17:57:42 -04:00
Raphael Londner
6a026cd2f0 Pure Storage doc fix (#45197)
* Pure Storage doc fix

Fixed typos + aligned formatting between FlashArray and FlashBlade sections

* double, not triple, backticks to quote code
2018-09-05 15:44:35 -05:00
chalupaa
1f3e7ea061 [aws] lambda_policy fix update when principal is an account number (#44871)
Fix KeyError on update when principal is an account number
2018-09-05 14:59:14 -04:00
Bob Lee
9a1191cbe5 Update documentation for gcp_compute (#43791)
Added examples on how to use "keyed_groups", "hostnames", and "compose"

The compose example shows how to set the ansible_host var for a host to either the public or private ip. This is necessary when you set your hostname by name instead of ip
2018-09-05 13:45:56 -05:00
Ted Timmons
86341f7520 docfix, python-netaddr should be netaddr (#43372)
"python-netaddr" is an OS package, but "netaddr" is the pypi package needed in python. Suggesting OS packages for python libs seems in bad form. I like the syntax "python's netaddr" to explain what package manager would have it.
2018-09-05 13:42:51 -05:00
Ryan Brown
20f21779d3
Fix ec2_group for numbered protocols (GRE) (#42765)
* Fix spurious `changed=True` when int is passed as tag

* Fix for all AWS module using compare_aws_tags

* Handle improperly stringified protocols and allow inconsistency between None/-1 on non-tcp protocols

* Add integration test that reproduces the same bug

* Return false if the comparsison is not equal
2018-09-05 13:34:26 -04:00
Sloane Hertel
038fd0d0f2 elb_target_group - prevent a KeyError exception (#45169)
Ensure ports to integers after allowing the key 'Targets' to be available in params
2018-09-05 12:50:03 -04:00
Ryan Brown
9d1bf32825
[aws] Add suboptions to aws_application_scaling_policy (#43042)
* [aws] Add suboptions to aws_application_scaling_policy

Fixes #42917

* Remove any suboptions that are None
2018-09-05 12:35:26 -04:00
abirami-n
3601c74971 enable_netconf_support_on_dellos10 (#44816) 2018-09-05 19:16:01 +05:30
amb1s1
25563dc7cf Fixed an issue when expecting may be, but getting maybe (#44908)
Tested an install on a Nexus 5596 and was failing due that this model will send an output of "Another install procedure maybe in progress" when running the show install all while the install is running. This is how the module knows that an install is being processed. In my case, it will not match that conditional statement.
2018-09-05 19:15:06 +05:30
Zim Kalinowski
a5e2b60870 adding tags to keyvault (#45145) 2018-09-05 16:21:15 +08:00
Abhijeet Kasurde
9c1ba18607
VMware: Return Disk UUID information (#45157)
This fix adds feature of disk uuid for given virtual machine disk.

Fixes: #45149

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-09-05 10:35:13 +05:30
Rob Emery
41db45ac33 Subversion: Only fire changed when content has changed (#41036)
* Previously when checking out a subdirectory, if changes are made in the
repository that aren't present in the subdirectory (i.e. in a different
branch or similiar) then the changes handler still kicks in even though
the content of this working copy hasn't necessarily changed. Now we parse
the output of svn update and fire if anything changes at all.

* Previously when checking out a subdirectory, if changes are made in the
repository that aren't present in the subdirectory (i.e. in a different
branch or similiar) then the changes handler still kicks in even though
the content of this working copy hasn't necessarily changed. Now we parse
the output of svn update and svn switch, firing if anything changes at all.

* Should not be executable

* ==None doesn't do what I want, is None does
2018-09-04 19:59:16 -04:00
Rémy Léone
f6303ba5df Add user_data/cloud-init support for scaleway_compute module (#42697) 2018-09-04 19:56:05 -04:00
Felix Fontein
26edeb7cce Refactoring GET request handling. (#45051) 2018-09-04 21:28:04 +02:00
Ryan S. Brown
c04f5a1d65 Codename: How Many More Times 2018-09-04 12:38:29 -04:00
Dougal Seeley
a6c97f2243 ec2_vpc_route_table - allow routes to be created if the CIDR already exists but its 'Origin' is 'EnableVgwRoutePropagation' (which cannot be replaced). (#43417)
Fixes #43415
2018-09-04 11:18:33 -04:00
Protista
80bea8adaf Add definitive to valid_simple_controls in pamd module (#44601)
* Add definitive to valid_simple_controls in pamd module

* Add changelog fragment for issue 44278

* Adjusted module name to not include path or extension
2018-09-04 11:14:22 -04:00
Allen Fair
8fb589d55e Returns reason on pkg update error (#44982)
Previously, it returned no additional information:

     "msg": "Could not update catalogue"

Now it passes that reason with the error message:

    {"changed": false, "msg": "Could not update catalogue [77]:  pkg: Insufficient privileges to update the repository catalogue.\n"}
2018-09-04 10:27:57 -04:00
joren485
cd5d484f7a Fix dead code in files module (#43479)
* Use pwd.getpwnam instead of non-existent pwd.getpwname

* Add specific exceptions to pwd and grp calls
2018-09-04 09:06:57 -05:00
characteristic
324b57d6ae Correct Jinja2 plugin math filter symmetric_difference() to not repeatedly (#45093)
build its intersection set and unnecessarily unique the final result.

The prior use of the intersect() function within the list comprehension
conditional leads to the function being called for every value in the input
list being processed, not efficient.  When the input lists a,b are large,
the Ansible run time and resource utilization wildly increases generally
never completing the operation.

Unique of the intersection result is unnecessary as the source list union()
is already unique.
2018-09-04 09:12:02 -04:00
Abhijeet Kasurde
4e9b8136c2 Add support for Devuan (#45148)
Devuan is part of Debian family. This fix adds support for Devuan OS.

Fixes: #45047

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-09-04 08:38:57 -04:00
Ryan S. Brown
617b8df5e6 Add rds_instance to module_defaults groups 2018-09-04 08:17:58 -04:00
Abhijeet Kasurde
b3b65d16b8
Handle special service where package is not available (#45155)
There are several services e.g. vmware-fdm, which does not have package name and
package description which will raise a error if queried for.

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-09-04 17:03:44 +05:30
Abhijeet Kasurde
885ee25375
Documentation for several VMware modules (#45153)
* Added return for vmware_host_config_facts
* Added return for vmware_host_service_facts
* Correct typo in vmware_portgroup_facts

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2018-09-04 16:37:14 +05:30
Trishna Guha
ab3cd10dfe
fix Python 2.6 regex bug terminal plugin nxos, iosxr (#45135)
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2018-09-04 13:44:43 +05:30
Zim Kalinowski
b1b90faf96 added missing resource_group description in return value (#45143) 2018-09-04 04:04:51 -04:00
Zim Kalinowski
e7ec1ef59c adding tags to container instance (#45142) 2018-09-04 03:56:10 -04:00
Ganesh Nalawade
455dfbe732
Fix netconf module and plugin issues (#45140)
* Fix netconf netconf issues

*  Identifier is optional for get_schema api
*  Fix dispatch api mandatory argument check
*  Add save option handling to copy config from target datastore
   to startup datastore if supported
*  Validate config in check-mode or if validate option set to true

* Copy config if check-mode is not enabled
2018-09-04 13:23:18 +05:30
linnil1
177fbea351 Fix sshkeyfilename is None not str (#44893) 2018-09-04 11:59:08 +05:30
Senthil Kumar Ganesan
3beeeffef9 Docs updated and review comments addressed (#45133) 2018-09-04 07:13:59 +01:00
Zim Kalinowski
1f8635fbd9 Virtual machine facts - retrieving instance view (#45128) 2018-09-04 11:25:01 +08:00
Zim Kalinowski
9bd702ef37 vm size idempotence (#45108) 2018-09-04 09:41:41 +08:00
Zim Kalinowski
55c549a832 added mysql management client to remove api version warning (#45103) 2018-09-04 09:23:11 +08:00
Madhura-CSI
a4663d8e73 New module for azure custom image facts (#42102)
* new module for azure custom image facts

* added facts in aliases, corrected assertion

* simplified managed disk id struct

* updated ansible version
2018-09-04 02:28:01 +08:00
Dag Wieers
e99db084f4
aci_interface_policy_leaf_policy_group: Fix filtering by lagT (#45088) 2018-09-03 16:40:57 +02:00
Dag Wieers
6faf400621
aci_switch_policy_vpc_protection_group: Fix idempotency (#45091) 2018-09-03 16:39:39 +02:00
Rémy Léone
aeac8fe141 Add licence and boilerplate to Online module_utils 2018-09-03 07:24:25 -07:00
Zim Kalinowski
9b28319020 adding container instance facts (#43326) 2018-09-03 15:51:42 +08:00
Rémy Léone
f465a251e1 Add a dynamic inventory plugin for Online (#44720) 2018-09-03 02:33:15 -04:00
Yunge Zhu
b58141555d fix blob in non-public azure cloud (#44802)
* fix blob in non-public azure cloud

* fix  lint

* fix typo
2018-09-03 11:16:23 +08:00
vpopescu
b4c148b6ea fixed boolean value for zone (#41974) 2018-09-03 10:20:16 +08:00
Zim Kalinowski
5fee46a8ec added postgresql management client version (#45079) 2018-09-03 09:47:31 +08:00
Felix Fontein
fec302b162 Fixing typo in acme_certificate docs. (#45082) 2018-09-02 13:01:45 -04:00
Matt Clay
bbca98ae8e Fix PEP8 issue. 2018-09-01 22:54:13 -07:00
Dan Farrell
667f62c5a8 Update lineinfile.py (#44976)
* Update lineinfile.py

The document should call out in the regexp section what regexp does in non-match scenario, not just leave it for the reader to find it under `insertbefore` and `insertafter`.  
+label: docsite_pr

* Update lineinfile.py

fixing for lint

* Use multiple entries
2018-09-02 05:18:33 +02:00
Jonathan
93cd050250 Added default value for when CloudFrontOriginAccessIdentityList is (#44984)
missing.
2018-09-02 12:17:25 +10:00
Matt Martz
f89d873698
Stub out modules scheduled for 2.8 removal (#44985)
* Remove modules scheduled for 2.8

* Add changelog and porting guide

* Skip docs test on removed modules

* Don't link to removed modules
2018-08-31 16:27:32 -05:00
Dag Wieers
b64e666643
Add elapsed return value to select modules (#37969)
* Add elapsed return value to select modules

It can be quite useful to know exactly how much time has elapsed
downloading/waiting. This improves existing modules or updates
documentation.

* Ensure elapsed is always returned

* Added changelog fragment
2018-08-31 22:20:56 +02:00
Toshio Kuratomi
3994300762 Update ansible version number to 2.8.0.dev0 2018-08-31 11:11:13 -07:00
Rémy Léone
5cf9644003 Add an user facts module for Online (#44709) 2018-08-31 14:02:40 -04:00
S. Veyrié
60af5ab962 maven_artifact: enforce required params (fixes #44823) (#44967) 2018-08-31 11:38:09 -04:00
Anil Kumar Muraleedharan
fbf55a09cc Lenovo image refactor (#44953)
* Refactoring code to adhere to persistence connection.

* Update cnos_rollback.py

* Updating license for the refactored method

* Update cnos_rollback.py

* Removing the BSD License as suggested by Legal

* Adding cnos_image after testing on sftp. Test code is also added

* Removing debug comments

* adding space
2018-08-31 20:04:57 +05:30
Ganesh Nalawade
c0326aea2f
Fix cli_command multiple prompt issue (#44922)
* Add check in network_cli to handle all prompts

* Add check_all flag to mandatory handle all the command prompt
  in prompts list. By default if any one prompt is handled
  remaining prompts are ignored.

* Fix cli_command multiple prompt issue

* If multiple prompt and answers are given as input network_cli
  handles only the first prompt that matched by default
* If a command execution results in muliple prompt the fix
  add support to set a boolean option C(check_all) to indicate
  network_cli to wait till all the prompts and answers are processed.

* Update cli_command

* Update api doc

* Fix unit test failure

* Fix CI failure

* Update network_cli

* Fix review comment
2018-08-31 20:04:12 +05:30
Ganesh Nalawade
005233f814
Fix iosxr_config integration test failure (#44969)
*  Check for commands presence in case running config
   is used as base config for diff
*  Correct the fixtures
2018-08-31 19:57:38 +05:30
Deepak Agrawal
50c7702e46
cisco firepower : Make API endpoints configurable via hostvars (#44952)
* httpapi host vars

* Make configurable end-points for firepower

* pep8 fix
2018-08-31 18:38:16 +05:30
Alex Stephen
276ad32a45 removing libcloud secrets support for legacy gcp modules (#44932)
* removing libcloud secrets support for legacy gcp modules

* test fixes
2018-08-31 08:28:32 -04:00
S. Veyrié
5b358db83f maven_artifact: download with shutil.copyfileobj to a temp file (#44956)
* maven_artifact: replace homemade chunked download with shutil.copyfileobj

* maven_artifact: copy to temp file first
2018-08-31 07:35:26 -04:00
Ganesh Nalawade
b0d6867fbb
Fix netconf_config module default_operation issue (#44958)
* Pass parameters as dict to edit_config api
  as either dict or args can be passed over
  jsonrpc 2.0 and not combination of args and
  kwargs
2018-08-31 16:33:34 +05:30
bonzi316
eee406dfd2 Fix maven_artifact md5 checksum check with archiva repository (#43250) 2018-08-31 05:32:37 -04:00
Matt Davis
2822fd8d9b
initial commit of azure_rm inventory plugin (#44944)
* crusty refactor of azure_rm to support auth from non-modules
2018-08-31 01:33:23 -07:00
Martin Nečas
c2fa0d2c4b recator uploading disk and downloading (#43635) 2018-08-31 03:23:52 -04:00
Martin Nečas
d5ebc3e0ec add quota_name to ovirt permition module (#44713) 2018-08-31 03:00:13 -04:00
Martin Nečas
c65c841ef3 add ovirt attach host devic (#44714) 2018-08-31 03:00:04 -04:00
Nilashish Chakraborty
0f268e70a1
Fix ios_user issues (#44904)
* Fix ios_user issues

* Modify regex and fix unittests
2018-08-31 11:08:46 +05:30
Ubuntu
7d81de2516 updates to azure_rm_sqlfirewallrule
updates to azure_rm_sqlfirewallrule

small fixes

move sql client to common

adding state

fixed sample

fixed sanity

fixed aliases

removed unnecessary object

removed unused resource_group

changed group to less crowdy

tags

no tags on firewall rule
2018-08-30 21:54:58 -07:00
Yuwei Zhou
b7d614df78 add auto scale module (#41533)
* add autoscale modules

* add test alias
2018-08-30 21:18:56 -07:00
Roman Belyakovsky
4f70eb3e26 ec2_vol_facts: moved to boto3 (#43348)
* ec2_vol_facts: moved to boto3

* vol_facts: formatting fixes

* vol_facts: formatting fixes

* vol_facts: added integration tests

* vol_facts: improved integration tests

* vol_facts: integration tests, fixed ami

* vol_facts: integration tests, fixed ami

* vol_facts: refactor, post-review update

* vol_facts: implemented pagination

* vol_facts: pep8 style fix

* CI IAM policy requirements fix

* Tests fixed, added to unsupported, removed empty files

* removed shippable alias
2018-08-31 13:50:17 +10:00
Dag Wieers
d71670655b
Fix small typo 2018-08-31 05:10:35 +02:00
Richard Levenberg
c759381b0b win_xml module for manipulating XML files on Windows (#26404)
documentation fixups

handling backup in a more ansible canonical way

remove quotes from $dest

Handle elements with only text child nodes
2018-08-31 12:20:09 +10:00
Sloane Hertel
113336d6f1 rds_instance module and tests (#43789)
* Add functions to retrieve the allowed and required parameters for boto3 client methods

* Add custom waiter for stopping an RDS DB instance

* Add rds_instance module

* Add rds_instance integration tests

* address requested changes from ryansb

* address requested changes from willthames

* address requested changes from dmsimard

* Fix final snapshots

Fix idempotence with already-deleting DB instances

Remove unused import from module_utils/aws/core.py

Consolidate function to get all boto3 client method parameters and the subset of required parameters

* Add some additional rds_instance integration tests

* Add some common functions to module_utils/aws/rds

* Move common code out of rds_instance

* Remove hardcoded engine choices and require the minimum boto3

* Document wait behavior

* Provide a list of valid engines in the error message if it is invalid

Add supported methods to whitelist

Remove AWSRetry around waiter

Wait for a less crazy amount of time

Remove unused variables

* Add a test for an invalid engine option

* pep8

* Missed adding a method to the whitelist

* Use retries

* Fix some little things

* Fix more things

* Improve error message

* Support creating cross-region read replicas

* Remove unused imports

* Add retry when getting RDS instance

* Soft-check required options so module fails properly when options are missing

* Fix mariadb parameter version

* Fix cross-region read_replica creation and tests

* fix modify tests

* Fix a modification test

* Fix typo

* Remove test for option_group_name that exists for this account but may not for others and added as a TODO to do properly
2018-08-31 12:17:02 +10:00
Yunge Zhu
ef8ce6b2f3 remove wrong alias on secret_value (#44877) 2018-08-31 09:36:52 +08:00
Dag Wieers
dbe30cc050
win_wait_for_process: Fixes and integration tests (#44801)
* win_wait_for_process: Add integration tests

* Disable reporting changes

* Added more tests checking PID

* Various improvements

This PR includes:
- Use Get-Process instead of CIM Win32_Process
- Rewrite of process filter logic (speedup)
- Fix error messages
- Fixes to documentation, examples and return output

* win_wait_for_process: Limit to PowerShell 4 and higher

* Improve RESULT documentation

* Last minute fixes for CI

* Catch Powershell exceptions

* Increase timeout to make tests more stable
2018-08-31 03:13:51 +02:00
Will Thames
ce110ff081 K8s retry merge (#44821)
* Make merge_type a list and apply merge_type in order

Allow use case of preferring strategic-merge and failing
back to merge, or just preferring a different merge type

* Improve k8s module test coverage
2018-08-30 20:42:47 -04:00
Matt Martz
2a4e92aab7
ensure if we get a non-Task object in _get_delegated_vars, we return early (#44934) 2018-08-30 17:11:32 -05:00
Alex Stephen
3550f342e0 Gcp auth deprecation (#44866) 2018-08-30 17:14:39 -04:00
Matt Martz
a0d7d4b82f Change insertion order of apply block to not affect the include_X task itself (#44912) 2018-08-30 16:56:28 -04:00
Stéphane Wirtel
711944aa97 Fix a comparison with a string and a byte in flatpak_remote (#44835)
* flatpak_remote: Fix the comparison between string and bytes for the remote_exists function

* Use to_text instead a new compare function

* Compare bytes to bytes
2018-08-30 22:36:34 +02:00
Ryan Conway
074aeeadff Add onepassword_facts module, based on the "onepassword" lookup plugin (#43953)
* Adding 1password facts module, based on the existing lookup plugin.

* Fix typo in error message.

* Fix tiny typo.

* Fixing documentation formatting errors.

* Clarify examples.

* Fix invalid return sample.

* Add required Ansible boilerplate.

* Swap AnsibleModuleError for plain Exception to fix "ImportError: No module named errors" error.

* Renaming from "1password_facts" to "onepassword_facts" to avoid potential compatibility issues.

* Renaming the module file also.

* Remove unnecessary comment.

* Fix use of incorrect code formatting wrappers.
2018-08-30 16:26:47 -04:00
Sam Doran
8cd8d17980
Add ability to unlock 1Password vault to lookup plugins (#44923)
* Add ability to use login to 1Password vault to 1Password lookups

* Adjust unit tests

* Add changelog
2018-08-30 16:24:06 -04:00
Ken Partridge
0b7a37c67b Add lookup cpm_metering to read WTI CPM and VMR PDU device power and current data (#44491)
* Add WTI OOB and PDU Device status, control and configuration module

* removed accidental file inclusions

* removed accidental file

* re-add cpm_metering

* was gettign a ERROR: Command "docker exec from GitHub, so this is a retry

* removed un-needed files

* removed old cpm_metering

* removed cpm_metering.py

* re-add cpm_metering

* removed pyc file

* re-added cpm_metering.py

* cleaned up EXAMPLES indentation

* EXMAPLES startdate, enddate had : instead of = to indicate a value

* Fixed missing whitespace around arithmetic operator
2018-08-30 15:53:38 -04:00
Ken Partridge
77b4b2cdc9 Add module cpm_user to read, create, edit and delete users on WTI devices (#44512)
* Add WTI OOB and PDU Device status, control and configuration module

* removed accidental file inclusions

* removed accidental file

* Add module cpm_user to read, create, edit and delete users on WTI devices

* changed user_name required to true

* fixed whitespace and argument spec problems

* fixed dict issues

* fixed use_proxy inconsistency
fixed whitespace warnings

* struggling with AnsibleError removal

* remove reference to ansible.errors

* changed EXAMPLES to reflect live unit
2018-08-30 15:51:44 -04:00
Ryan Breaker
c9adfdf68b Reword documentation for IOS L2/L3 interface modules (#44870)
* Update documentation to be cohesive with ios_l2_interface

* Fix small typo in documentation
2018-08-30 14:48:43 -05:00
Jose Delarosa
fdb1d1146f Add module redfish_command (#43469)
* Add module redfish_command

Communicates with Out-Of-Band Controller through Redfish APIs
Sends a command to execute an action

* Wrapped all instances of result['msg'] inside to_native()

* Added more entries to Description section

* Minor fixes for PEP8 compliance

* Update the root URI to match the DMTF specification

* Display valid Categories or Commands in case invalid value given

* Updated returned values and description
2018-08-30 15:40:45 -04:00
Jose Delarosa
7f43f49b42 Add module redfish_config (#43470)
* Add module redfish_config

Communicates with Out-Of-Band Controller through Redfish APIs
Sends a configuration update to the Controller

* Wrapped all instances of result['msg'] inside to_native()

* Added more entries to Description section

* Minor fixes for PEP8 compliance

* Update the root URI to match the DMTF specification

* Display valid Categories or Commands in case invalid value given

* Updated returned values and description

* Add default values to bios and mgr variables
2018-08-30 15:38:57 -04:00
Adam
00368a432f Update lightsail.py (#44902) 2018-08-30 13:24:04 -05:00
Matt Martz
9d89e15ff0
Ensure we only cache the loop when the task had a loop (#44901)
* Further restrict caching of loop when the task actually had a loop. Fixes #44874

* Extend tests for loop caching
2018-08-30 12:02:43 -05:00
Senthil Kumar Ganesan
a64b97da42 Support for Openswitch (OPX) Control Plane Services (CPS) Module (#44745)
* Generic module to support Openswitch (OPX) Contorl Plane Services (CPS)

* Address ansible-test sanity issues
2018-08-30 17:39:47 +01:00
Ganesh Nalawade
1fdd0e10bb
Update netconf_config module doc (#44910)
* Fix review comments from wisotzky
2018-08-30 21:39:37 +05:30
Ganesh Nalawade
1a684df109
Fix iosxr cli_config module diff issue (#44898)
* Fix iosxr cli_config module diff issue

* Modify iosxr plugin to support configuration
  diff capability (get_diff()) within Ansible
  to be in sync with iosxr_config module.

* Fix unit test case failure
2018-08-30 21:39:11 +05:30
Jeff Geerling
c3e526bf2c helm: Improve documentation style and readability. (#44876) 2018-08-30 11:06:35 -05:00
yaakov kuperman
6b7ea5078f [aws] New module: elb_target_facts (#43565)
* initial source of the elb_target_facts module, which gathers all
registered ELBv2 target groups for a given instance id

* updating

* initial dump of tests

* updating docs, adding AWSRetry decorators

* updating tests

* More brush up, some refactoring

* updating for sanity tests

* removing extra space

* updating elb_target_facts to use a new name for the return value, not return a fact, and use instance variables for the AWS connections.  updating tests to go along with that

* updating classes to be 'new-style' classes
2018-08-30 10:47:28 -04:00
Alex Stephen
3c6c7bae9d Allow home path expansion on GCP service account files (#44863)
* Allowing home path expansion on GCP service account files #42974

* wrong name for changelog
2018-08-30 10:27:29 -04:00
Dag Wieers
bf9ed0263a Ensure action plugins accept only valid args (#44779)
* Ensure action plugins accept only valid args

This fixes #25424
This also fixes #44773

* Add missing parameters, use private _VALID_ARGS
2018-08-30 09:40:36 -04:00
Matt Martz
0221d1ad20
Introduce and use locale-naive rfc2822 date format function (#44868)
* Introduce and use locale-naive rfc2822 date format function. Fixes #44857

* Adjust test expected response
2018-08-30 08:34:37 -05:00
Ghilli3
7bc2660017 fortimanager/fmgr_provisioning.py (#35743)
* Initial commit for new provisioning module
2018-08-30 14:25:17 +01:00
Justin Yaple
a767929456 Fix 'macro name' timeout (#44001)
* Fix 'macro name' timeout

Added function to send macro to device using 'sendonly'.

* Filter 'macro' from normal commands

* Removed white space

* Undefined variable 'cmd'
2018-08-30 18:11:51 +05:30
linnil1
d89a1be011 Fix bug of interface-mode in Junos (#44380)
* Fix bug of interface-mode in Junos

* Fix typo. Thanks webknjaz.
2018-08-30 18:10:58 +05:30
pierremahot
d11e078366 adding an option for the filter ipsubnet and testing (#40670)
* adding an option for the filter ipsubnet
2018-08-30 13:21:22 +01:00
Zim Kalinowski
bd866ed69a adding container registry facts (#43325) 2018-08-30 17:56:12 +08:00
Yunge Zhu
b731732616 add azure_rm_webapp_facts module (#43631)
* add webapp facts module

* remove certified

* remove useless argument

* add tests

* return curated output

* add description of return value, move test to webapp folder

* fix lint

* fix lint

* fix lint

* fix test

* fix bug

* fix test, will get all webapp with same tag created by previous test

* fix test

* fix test

* fix test

* add properties description, refine return name

* refine properties, add request_id when exception

* fix bug

* update doc, add publish profile

* fix error

* flatten properties, add option for return publish profile
2018-08-30 17:49:06 +08:00
gyurco
4ad7642ba0 mongodb_user: don't call buildInfo with Pymongo > 3.5 (#42350)
Bug: #35155
2018-08-30 03:01:28 -04:00
Jordan Borean
533656694e
win_disk_image: return all mount paths in return value (#44799) 2018-08-30 16:25:45 +10:00
Zim Kalinowski
78eb4724a0 Adding sql client to common (#44825) 2018-08-30 12:44:36 +08:00
ndswartz
b0cee34ca1 Fixed netapp_e_lun_mapping options for backwards compatibilitiy (#44769)
* Fixed netapp_e_lun_mapping options for backwards compatibility.

Readd lun and target_type as deprecated options.

Note: lun and target_type were removed in patch #44666 since they were
no longer needed for the logic in the module.  However, this cause will
cause existing playbooks utilizing these options to break.

* Add lun specification and target_type verification for netapp_e_lun_mapping
2018-08-30 05:35:57 +01:00
Lachlan Cooper
1e7ab24e40 Fix minor issues with docker_login docs (#35081)
* Fix typos in docker_login reauthorize parameter

* Remove note about docker_login email address

Docker Hub no longer requires an email address.

* Remove check for email parameter with Docker Hub

This is no longer required, so login should not fail if it's not provided.
2018-08-30 05:33:39 +01:00
Hai Cao
ccb7909cc5 [new module] Azure Traffic Manager profile module (#43812)
* add traffic manager client and models in azure_rm_common
- add traffic manager management client
- import traffic manager models to 'traffic_manager_models' proprety
- azure.mgmt.trafficmanager doesn't have models(), so use direct import
for now

* add traffic manager facts module

* add traffic manager module

* add integration test for two modules

* fix package info in requirements

* fix sanity check

* fix monitor config default value

* fix facts module doc

* move model import into module

* resolve comments except seprating endpoint

* remove endpoint operation

* fix test after removing endpoint operation

* change module name to azure_rm_trafficmanagerprofile/facts

* fix sanity test

* seperate endpoint into delegate module

* fix typo

* fix lint

* fix lint

* fix test

* fix test

* resolve comments

* fix test

* fix test

* fix test

* fix bug in return

* resolve comments

* fix lint

* fix lint

* add sample in endpoint module
2018-08-30 14:18:53 +10:00
lwm
fbcdf8ba5b Linode: Mark 'name' as required. Fixes #29785 (#44699)
* Mark 'name' parameter as required.

Closes https://github.com/ansible/ansible/issues/29785.

* Add the `linode-python` dependency for unit tests.

* Add unit test for linode name parameter.

* Add note about where to find required arguments.

Closes https://github.com/ansible/ansible/issues/44696.
2018-08-30 05:09:21 +02:00
newtonne
30fd326953 Various updates to macports module (#44605)
- Add support for installing specific variants of a port.
- Add support for using yaml lists with 'name' parameter, rather than comma-separated lists.
- Add to and clarify documentation and examples.
- Use Macports nomenclature:
  - s/package/port/g
  - Rename update_cache to sync_ports but keep update_cache as an alias. Remove undocumented update-cache alias.
  - Remove undocumented 'pkg' alias for 'name'. Replace with 'port' alias and document it.
- Print stdout and stderr output if `port sync` fails.
- Print stderr output, rather than stdout, if `port install/uninstall/activate/deactivate` fail.
2018-08-30 05:03:29 +02:00
Martin Adler
3c26616909 DNS made easy module: add sandbox parameter to utilize sandbox API (#44639)
* added sandbox param to switch between APIs

Signed-off-by: Martin Adler <1208749+EagleIJoe@users.noreply.github.com>

* Added warning as suggested
2018-08-30 04:35:57 +02:00
Felix Fontein
1dcf52c8fe docker_container: improving idempotency (#44808)
* Only handle cpu_shares, volume_driver, auto_remove as in _host_config().

* Don't compare log_options (resp restart_retries) if log_driver (resp restart_policy) is not specified.

* Warn that log_options (resp restart_retries) is ignored if log_driver (resp restart_policy) is not specified.
2018-08-29 21:07:32 -04:00
Felix Fontein
63fde92b60 Improve description of default network removal. (#44861) 2018-08-29 20:53:26 -04:00
Jasper Aorangi
2541a8c494 azure_rm_virtualmachine: Add 'accept_terms' for accepting terms when deploying paid marketplace images (#44701)
azure_rm_storageaccount: Add 'StandardSSD_LRS', and choices to correct unrelated sanity error
2018-08-29 17:14:44 -07:00
Tim Rupp
5bdcaff921
Various f5 fixes (#44858)
* Remove sdk from modules
* Correct IP address bugs in data_group
* Correct compare_dictionary bug in several modules
2018-08-29 16:08:37 -07:00
Constantin Bugneac
23adc3ecf1 added RETURN structure to _ec2_remote_facts.py (#26041) 2018-08-29 18:22:09 -04:00
Alex Stephen
56fa7eeb41 [gcp] gcp_compute_backend_service changes (#44796) 2018-08-29 16:41:37 -04:00
Alex Willmer
490c7e7b35 Clarify docs/examples of attribute removal (#35872)
If values="somestring" is specified then this module normalizes it to
["somestring"]. This means that passing name="foo", values="",
state=exact results in the ldap entry having a single attribute called
foo="".

To delete all attributes "foo", regardless of their values, it is
necessary to pass name="foo", values=[], state="exact".
2018-08-29 15:39:37 -05:00
Nathaniel Case
149aa767ff
Setting options is fine if plugins already exist (#44859) 2018-08-29 16:33:51 -04:00
Rémi REY
cd7c946ea5 modules/terraform: add support of backend configuration (#44860)
This patch adds a new `backend_config` parameter that allows to provide the
-backend-config parameter during the terraform init command.

The option allows to dynamically set the backend information, like the s3 bucket name
and statefile name.
2018-08-29 16:26:19 -04:00
Todd Walton
1247f4a464 Clarify docs re mode's octal representation (#44410)
* Clarify docs re mode's octal representation

I changed the language about how to use mode to make it more obvious
that using "01777" is not a typo, because the leading zero is not meant
to reflect the way that number might have been given on a command line.
See also: issues #5409 #9196 #11385 #13115 #18952 #23491 #23521
2018-08-29 15:12:32 -05:00
Matt Martz
d5ed818e7c
Make sure we skip handlers from includes in compile_roles_handlers. Fixes #44848 (#44852) 2018-08-29 15:05:55 -05:00
rgustomi
305ae5442a change docs for mime-type (#36693)
* change stat.py docs for mime-type

* corrects stat.py RETURN documentation for mimetype
2018-08-29 14:49:39 -05:00
Anil Kumar Muraleedharan
822dbe3016 Refactoring code to adhere to persistence connection. (#44398)
* Refactoring code to adhere to persistence connection.

* Update cnos_rollback.py

* Review comment of Qalthos incorporated

* Updating license for the refactored method

* Update cnos_rollback.py

* Removing the BSD License as suggested by Legal
2018-08-29 15:25:19 -04:00
Adrien Fleury
4249c5ca7f New module : tower_credential_type (#37243)
* Add new module *tower_credential_type*

* Add support for credential type creation and/or deletion
* Add test coverage for tower_credential_type
2018-08-29 11:01:19 -07:00
Adrien Fleury
aaa157f140 New module tower_workflow_template. (#37520)
* Add new module *tower_workflow_template*

Manage Tower workflows and their schemas.
2018-08-29 10:58:35 -07:00
Chris Archibald
7cded31ec9 Depreciate elementsw modules (#44792)
* rename deprecated files
2018-08-29 17:51:52 +01:00
Matt Martz
cd2f66f731
Don't allow import_tasks to transition to dynamic when file is missing. See #44822 (#44836) 2018-08-29 11:43:26 -05:00
Pilou
c07ba82d3e Scaleway inventory: allows to connect via private IP (#44342)
* scaleway inventory: remove useless duplicate

* scaleway inventory: allows to connect using private ip

ansible_host was hardcoded and it was not possible to connect using
private addresses.
This allows to define multiple host variables, values are templates
which can use hosts details send by API. For example this config file
use private address and defines two variables:

    plugin: scaleway
    hostnames:
      - hostname
    variables:
      ansible_host: private_ip
      state: state
      image: image.name
    regions:
      - ams1

inventory will looks like:

    {
        "_meta": {
            "hostvars": {
                "testhost": {
                    "ansible_host": "10.1.1.1",
                    "arch": "x86_64",
                    "commercial_type": "START1-M",
                    "hostname": "testhost",
                    "id": "af669464-0c74-4c89-8573-9fe763028448",
                    "image": "CentOS 7.4",
                    "organization": "2cc9a115-380d-4ac0-ba4b-8947eee71325",
                    "public_ipv4": "163.172.1.1",
                    "public_ipv6": "2001:bc8::1",
                    "state": "running",
                    "tags": [
                        "testtag"
                    ]
                }
            }
        },
        [...]
    }
2018-08-29 12:14:12 -04:00
Tim Rupp
de0acc9cfd
Deprecates bigip_gtm_facts (#44841)
The code to support these facts has been added to bigip_device_facts.
So it is no longer necessary to include this module.
2018-08-29 08:45:39 -07:00
Tim Rupp
817b74654f
Adds gtm facts to bigip_device_facts (#44842)
Merging in the gtm facts code to device facts
2018-08-29 08:45:29 -07:00
Ganesh Nalawade
eb9c75caad
Fix rollback option in cli_config module (#44834)
* Fix rollback option in cli_config module

* Update rollback flag in cliconf plugins
* Add rollback api for junos cliconf plugin

* Update doc

* Update doc
2018-08-29 21:00:11 +05:30
Jordan Borean
559599842a windows async: return pipeline output in case of a failure (#44807) 2018-08-29 16:13:31 +02:00
Anton Nikulin
40a97d43d1 New modules and updated HTTP API plugin for FTD devices (#44578)
* Add common and Swagger client utils for FTD modules

* Update FTD HTTP API plugin and add unit tests for it

* Add configuration layer handling object idempotency

* Add ftd_configuration module with unit tests

* Add ftd_file_download and ftd_file_upload modules with unit tests

* Validate operation data and parameters

* Fix ansible-doc, boilerplate and import errors

* Fix pip8 sanity errors

* Update object comparison to work recursively

* Add copyright
2018-08-29 15:48:10 +02:00
Tzur Eliyahu
c174b4b128 IBM_Storage: Added a module for managing IBM Spectrum Accelerate (#44166)
storage system pools
2018-08-29 13:42:10 +01:00
Tzur Eliyahu
0189db2aa5 IBM_Storage: Added a module to define hosts on IBM Spectrum Accelerate (#44365)
* IBM_Storage: Added a module to define hosts on IBM Spectrum Accelerate
storage systems.
2018-08-29 13:26:24 +01:00
Will Thames
b35ac8080f Change the return key of k8s_facts (#44446)
`items` is a *terrible* return key for ansible as Jinja
will often think it refers to the `items()` function.

Even though you can typically work around this with
`results['items']`, sometimes even that doesn't work:

```
- name: Resources should exist
  assert:
    that: item.status.phase == 'Active'
  loop: "{{ k8s_namespaces['items'] }}"
```

```
fatal: [testhost]: FAILED! => {"msg": "Invalid data passed to 'loop', it
requires a list, got this instead: <built-in method items of dict object
at 0x109dc9c58>. Hint: If you passed a list/dict of just one element,
try adding wantlist=True to your lookup invocation or use q/query
instead of lookup."}
```

Change it now while we still can.
2018-08-29 12:04:04 +01:00
Felix Fontein
1ef225601a Properly documenting environment variables in documentation fragment. (#44812) 2018-08-29 11:30:20 +01:00
denraf
bbb57f5a95 Set Default values correctly for docker variables (#42641)
* Set Default values correctly
2018-08-29 10:49:27 +01:00
Zim Kalinowski
ed2cd40a5b
adding new clients to common (#44804)
* adding new clients to common

* container registry and instance clients to the common

* fix problem
2018-08-29 13:52:18 +08:00
Tim Rupp
34b7b77bce
Deprecates bigip_facts (#44790)
This module has been superceded by the bigip_device_facts module
2018-08-28 18:29:23 -07:00
Jordan Borean
9d91607754
win_psexec: fix arg handling when command contains multiple args (#44797) 2018-08-29 10:12:29 +10:00
Charles
d5d2c80779 add win_wait_for_process (#40404)
* add win_wait_for_process

* try working on additional filter options and fix derps

* improve process name matching: support arrays. support pre and post wait

* use CIM instead of WIM.  requre exact contain process binary extension

* updates to metadata

* fix errors in waiting for process to start

* validate process min count for absent state.  fix typo

* fix bug if only one processes is detected

* address GitHub comments
2018-08-28 19:44:30 -04:00
Xyon
03261b3053 Add new session parameter to win_psexec (#44263)
* Add new session parameter to win_psexec

* Indicate which version the session option was added in

* Added changelog fragment and minor edit on doc entry
2018-08-29 09:42:59 +10:00
Yunge Zhu
2bd0a66c08 start/stop/restart azure webapp (#44498)
* add webapp start/stop/restart

* disable test with facts

* fix lint

* fix lint

* fix check mode

* rename power_action to app_state

* refine names of choices

* fix renaming bug
2018-08-29 07:41:11 +08:00
Chris Archibald
408868ed49 fix bug and documentation issue (#44793) 2018-08-28 18:32:44 -04:00
Dag Wieers
5e814d8d17 Fix support for JSON output when charset is set (#44762)
* Fix support for JSON output when charset is set

This fixes #41797

* Add specific exception to catch

* Add Changelog fragment
2018-08-29 08:10:46 +10:00
Adam Miller
1e3b927a73 Improve error condition handling for dnf module (#44770)
- Fix comma separated list handling for package names
- Fix error message for unavailable/unknown package install attempt
- Fix pkg install result output generation

Signed-off-by: Adam Miller <admiller@redhat.com>
2018-08-28 17:44:46 -04:00
Chris Archibald
15886b1d56 Adding na_ontap_autosupport.py Module (#44178)
* Adding na_ontap_autosupport.py Module
2018-08-28 22:41:05 +01:00