Commit graph

27225 commits

Author SHA1 Message Date
Gonéri Le Bouder
b8c170a322 vmware_datastore_facts: handle external datastore
Without this commit, `vmware_datastore_facts` ignores the datastores are
not associated with a cluster of a datastore. This case can happen if a NFS
share is mounted directly on a ESXi instance.
2019-05-17 16:40:00 -04:00
anasbadaha
5a7bce1f8d Adding New Model onyx_qos for Configuring QoS on Onyx Switches (#55127)
* Adding New Model onyx_qos for Configuring QoS on Onyx Switches

Signed-off-by: Anas Badaha <anasb@mellanox.com>

* Fix Pep8 Failures in onyx_qos

Signed-off-by: Anas Badaha <anasb@mellanox.com>

* Fix Pep8 Failures phase 2

Signed-off-by: Anas Badaha <anasb@mellanox.com>

* Fix Samer's Comments on onyx_qos Module

Signed-off-by: Anas Badaha <anasb@mellanox.com>

* Fix Shippable Comments Phase 3

Signed-off-by: Anas Badaha <anasb@mellanox.com>

* Fix Current Version 2.9

Signed-off-by: Anas Badaha <anasb@mellanox.com>
2019-05-17 14:20:56 -04:00
Matt Martz
576593e175
Whitelist listen as a valid keyword on TaskInclude (#56586)
* Whitelist listen as a valid keyword on TaskInclude. Fixes #56580

* Move 'listen' to HandlerTaskInclude

* Remove trailing newline
2019-05-17 12:52:39 -05:00
Chaitanya Deshpande
b5935486da Updated utils to remove Avi SDK dependency and Avi 18.2.2 version update (#54894)
* Updated utils to remove Avi SDK dependency and Avi 18.2.2 version update

* Fixed the python 3.x errors failing for avi_disable_session_cache_as_fact not properly documented

* Updated version added fields for new parameters

* fixed pep8 errors

* made requests import optional

* removed setting requests to None

* Added try catch for the avi helper methods such that any import fails then module fail gracefully. This was needed to pass the requests library not found error

* removed deprecated modules. Also, trying another fix to deal with requests import error

* Fixed python3 errors

* fixed pep8, no-dict-iteritems and import test failures

* added version 2.8 for new field

* some more code cleanup and formatting

* updated the fail message and fixed plint errors

* added workaround for unicode pylint

* fixed the version added for new parameter app_learning_memory_percent and removed unicode_literals import

* Removed check of HAS_AVI for common argument spec

* Updated version added value from 2.8 to 2.9

* Version added value fixes of CI error
2019-05-17 13:12:06 -04:00
Nathaniel Case
63e33f7e71
Fix eos_l2_interface idempotency (#56531)
* Attempt to handle just mode trunk properly

* Add test for trunk-only config and clean up tests

* Add missing eapi tests and remove references to provider as we do not test local
2019-05-17 13:06:27 -04:00
Bharat Kunwar
18f22de67e Fix typo that breaks invocation of os_stack (#56575)
* Fix typo that breaks invocation of os_stack

* Apply tags conditionally so that the module does not throw up an error when using an older distro of openstacksdk
2019-05-17 10:34:57 -04:00
Kevin Breit
27aca731b3 meraki_ssid - Add examples to documentation (#56425)
* Add standalone copy/paste-able examples
2019-05-17 08:21:34 -05:00
Aleksei Kioller
2897cf43ce Fix typo in mount doc (#56566) 2019-05-17 11:44:32 +02:00
Martin Krizek
c6b40f4d40
register: fail when invalid var name is specified (#56456) 2019-05-17 11:02:03 +02:00
Fred-sun
11c63d6c1e Update azure_rm_cdnendpoint related module document (#56440) 2019-05-17 16:02:40 +08:00
Fred-sun
dfab364a19 Update azure_rm_containerinstance related module document (#56556) 2019-05-17 14:59:38 +08:00
Patrick Marques
1eb5fb9541 Add os_profile to VM facts, allow to filter by OS (#48040) 2019-05-17 14:44:44 +08:00
Fred-sun
ba8846ab74 update azure_rm_containerregisty document (#56560) 2019-05-17 14:34:28 +08:00
Rohit
06c050e9bd
asa_config fix (#56559)
Signed-off-by: Rohit Thakur <rohitthakur2590@outlook.com>
2019-05-17 11:49:00 +05:30
Kevin Breit
2a187f362a meraki - Unchanged requests now return the original data (#53576)
* Unchanged requests now return the original data

* Add changelog fragment

* Add integration tests for returned data for meraki_network

* Add integration tests for returned data

* Improve idempoetent output
- Make MX l3 rules always show default rule
- Add integration tests

* Add integration tests for returned data on meraki_network

* Improved idempotency in a few modules and improved tests
2019-05-17 08:34:16 +05:30
mjmayer
c8e179fbf1 Aws waf region (#48953)
* Add waiter for AWSRegional

* Add support for WAF Regional

* Add support for regional waf web acl

* Remove set_trace, pep formatting

* Add paginator for regional_waf

* Change name of param for waf_regional

This is more in line with how AWS refers to the service. Additional
 changes made to how client is called. Used ternary to reduce if
 statements

* Change parameter name to waf_regional

* Add support for removal waf regional condition

* Change parameter from cloudfront to waf_regional

* Added state: absent waf rule

* Remove set_trace

* Add integration tests for waf regional

* WIP: adding region parameter to tests

* Add support for waf facts module

* Add region to waf regional integration tests

* Update security policy for waf regional testing

* Add type to documentation for waf_regional param
2019-05-17 10:36:14 +10:00
Gonéri Le Bouder
32620b7e00 vsphere_copy: fix the E309 error (#56537)
Resolve the two following errors:

ERROR: lib/ansible/modules/cloud/vmware/vsphere_copy.py:0:0: E309 version_added for new option (host) should be '2.9'. Currently None
ERROR: lib/ansible/modules/cloud/vmware/vsphere_copy.py:0:0: E309 version_added for new option (login) should be '2.9'. Currently None
2019-05-16 14:42:36 -07:00
Matt Martz
867e357eb1
When not using file_per_task, make sure we don't prematurely close the perf files (#56477)
* When not using file_per_task, make sure we don't prematurely close the perf files

* add changelog fragment
2019-05-16 15:38:36 -05:00
Pilou
98246f6032 consul modules: update documentation (#56408)
* consul modules: Python 2.6 is always required on managed node, document all types, improve parameter descriptions, fix typos
* consul_kv: add doc for retrieve parameter
2019-05-16 13:54:05 -05:00
chashtag
7e997fdca2 Update ovirt_vnic_profile.py (#56518)
##### SUMMARY
qos is not defined when port_mirroring is enabled, a NoneType is returned for entity.qos in this case
getattr is safer to use than using a direct call to entity.qos.name


##### ISSUE TYPE
- Bugfix Pull Request

+label: docsite_pr
2019-05-16 13:52:45 -04:00
s-hamann
730456b402 Add seed parameter to random_mac filter (#51841) 2019-05-16 13:41:08 -04:00
Kevin Breit
d59eb9edab meraki_switchport - Improve reliability (#54275)
* Rewrite much of the execution of meraki_switchport
- Previous versions had problems with idempotency and allowed_vlans

* Modified payload creation
- Parameter map is used
- propsed is created using .copy()
- Much cleaner this way

* Add whitespace for lint

* Add bugfix snippet for changelog
2019-05-16 12:10:32 -04:00
Nathaniel Case
d5a272ce89
Fix eos_support_session logic (#56524) 2019-05-16 11:28:19 -04:00
Nathaniel Case
409c46b2fa
Properly handle check for session support on eos (#56407)
* Properly handle eos session check.

* Why is eos_use_sessions an int?

* Add changelog
2019-05-16 10:44:22 -04:00
Gonéri Le Bouder
a4f08617d4 VMware: vmware_datastore_maintenancemode: check params (#56515)
Check the `datastore` parameter and raise an error if nothing has been
found.
2019-05-16 19:52:17 +05:30
Fred-sun
4b39748d21 Update azure_rm_cdnprofile related module document (#56503)
* modify azure_rm_cdnprofile module documentation
2019-05-16 09:11:47 -05:00
Alicia Cozine
118cf3ece6
Cloud dev docs to rst (#56485)
* Moves developer docs for AWS, ovirt, and openstack modules out of lib/ansible/, integrates them with dev_guide, with abadger's fix to make python snippets pass rstcheck
2019-05-16 09:05:12 -05:00
Andrey Klychkov
75046f8410 postgresql_db: added tablespace support (#56390) 2019-05-16 12:13:40 +02:00
David Hewitt
50e9955a23 VMware: Add new module vmware_folder_info (#54344)
* Adds a new vmware module to support getting the folders and their paths within a datacenter
* Add integration tests
* Bump version added
* Refactor integration test
* Improve grammar in docs
2019-05-16 14:18:07 +05:30
Aravind Balaji
0e0735f10e VMware: Return facts about rule_affinity vmware_drs_rule_facts (#55813)
Added the rule_affinity while returning about the rule facts
2019-05-16 11:51:36 +05:30
Gonéri Le Bouder
216260cbb4 VMware: vsphere_copy: ability to target an esxi instance (#55930)
*`vsphere_copy` was only able to interact with a vCenter instance. This
patch change that.
* In addition, it also makes use of the `vmware_argument_spec`.

Co-Authored-By: Abhijeet Kasurde <akasurde@redhat.com>
2019-05-16 10:40:07 +05:30
spidermila
ca7ff2ad05 VMware: return info about SCSI controller in vmware_guest_disk_facts (#56442)
vmware_guest_disk_facts module added bus number of the SCSI controller to the output
2019-05-16 10:27:17 +05:30
Alicia Cozine
7636f36a8a
gcp_compute_target_proxy does not exist, update deprecated redirect (#56496) 2019-05-15 21:08:58 -05:00
Brian Coca
183ba93ba3
removed previouslly deprecated settings (#55662)
* removed previouslly deprecated settings

  fixes #55304

* also removed from play context
2019-05-15 16:36:30 -04:00
chashtag
db42cf5873 Update ovirt_vnic_profile.py (#56466)
##### SUMMARY
Update documentation to reflect module name


##### ISSUE TYPE
- Docs Pull Request

+label: docsite_pr
2019-05-15 14:10:05 -04:00
Till Wiese
6182f368e7 Small typo fix in documentation (#56480)
The documentation was probably C&P'd from user, leaving a "useradd" mention where a "groupadd" should be.
2019-05-15 14:08:01 -04:00
Kevin Breit
322cfa49d0 Meraki - Add check for auth_key parameter (#56199)
* auth_key parameter is required
- This will have to change when httpapi is implemented

* Add integration test

* Add assertion

* Enable VLANs on network

* Add required for auth_key
2019-05-15 11:45:07 -04:00
Sean M. Collins
63155983fe [eos] Allow ports to be configured with just trunk mode (#55887)
Fixes #55886
2019-05-15 19:57:46 +05:30
Joseph Kennedy
4928373a8b Allow config commands in aireos_command to support prompts (#56130)
* Switch failure on config command to just a warning.

* Change wording in documentation

* Missing whitespace
2019-05-15 10:25:14 -04:00
Abhijeet Kasurde
8ce09a0057 VMware: fix inventory plugin (#56431)
* Fixed regression introduced in #56071
* Added test to check if hostvars are populated
* Fix toml installation logic

Fixes: #56413

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-05-15 10:15:49 -04:00
ciliusmp
3b08e75eb2 hetzner changed image tag for server, so its working with ids and names (#56406)
* hetzner changed image tag for server, so its working with ids and names

* changed trailing whitespace

* added higher retries count since server creation from own image takes a lot longer
2019-05-15 03:43:21 -04:00
Adam Miller
666dfdc551 YUM - handle enable of non-existent repo (#53286) 2019-05-15 08:45:54 +02:00
Abhijeet Kasurde
5ef2c5314e Fixed error handling in github_issue module (#39652)
* Fixed error handling in github_issue module

Due to recent changes in github3.py library module stopped working.
This fix adds extra error handling for new changes in library.

Fixes: #39627

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>

* Check version

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>

* Refactor github_issue

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-05-15 02:35:11 -04:00
pratikgadiya12
107d9efef3 VMware: Check to retrieve list of all used disks (#56380)
Fixes: #56290
2019-05-15 11:02:25 +05:30
James E. King III
3170e8b881 azure_rm_securitygroup - fix delete error handling (#56422) 2019-05-14 21:30:22 -04:00
Jordan Borean
fd65f037f8
winrm - fix failure parsing for send input errors (#56245) 2019-05-14 19:55:41 -04:00
Martin Krizek
826b99d4bd dnf: fix wildcard matching for state: absent (#56013)
* dnf: fix wildcard matching for state: absent

Fixes #55938

* Add changelog...

* Fix sanity check failure...
2019-05-14 17:34:10 -04:00
Nabeel AlSaber
e98e98757d Initial commit for Oracle Cloud Infrastructure modules 2019-05-14 13:51:45 -07:00
Nabeel AlSaber
ec2db1aed7 Initial commit - Oracle modules
Revert "Revert oracle (#56364)"

This reverts commit eefc90b66f.
2019-05-14 13:51:45 -07:00
James E. King III
75788ecff4 azure_rm_virtualmachine (and _facts): add boot_diagnostics control and facts (#49661) 2019-05-14 12:06:06 -07:00
Diane Wang
0d2a120454 Merge pull request #56383 from Tomorrow9/fix_pr56296
VMware: add timezone and hwclockUTC customize parameters for Linux guest in vmware_guest
2019-05-14 14:11:52 -04:00
William L Thomson Jr
2d4cbe0d5b Modify/fix handling of noreplace option issue #55365 (#55967)
Presently setting noreplace: no/false has no effect. Negating the default
to true from false and modifying conditionals seems to correct this.
Making it such that you can re-install and existing package. That did not
seem possible without such modifications.

Potential fix for issue #55365 pending issue reporter testing and feedback.
2019-05-14 12:17:15 -04:00
Fred-sun
22d7e7ea0b update azure_rm_appserviceplan related module documents (#56348)
* update azure_rm_appserviceplan module documentation
2019-05-14 09:32:19 -05:00
Fred-sun
84f5666aab update azure_rm_appgateway document (#56339)
* update azure_rm_appgateway documentation
2019-05-14 09:28:33 -05:00
Pilou
7f41cc40e6 [doc] expect module: mention all parameter types (#56394) 2019-05-14 09:06:00 -05:00
Brian Coca
674a57c3fa
fix module defaults (#56020)
* fix module defaults

 - corrected precedence (specific module > group)
 - made into reusable function
 - use from gather_facts/service/package to match 'actual module used'
2019-05-14 09:59:18 -04:00
Pilou
8968d41599 [doc] command module: mention all parameter types (#56396) 2019-05-14 08:50:49 -05:00
Nilashish Chakraborty
30ccc8e1bd
Fix VyOS cli prompt issues (#56389)
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
2019-05-14 19:17:00 +05:30
Albert Siersema
0ee673a558 Issue55222 (#55223)
* Python 3.7 compatibility for re.Pattern (Fixes #55222)

* Python 3.7 compatibility for re.Pattern (Fixes #55222)
2019-05-14 18:58:43 +05:30
Fred-sun
49ecfdbc10 update azure_rm_autoscale document (#56388) 2019-05-14 17:10:59 +08:00
Abhijeet Kasurde
7a32bd8080
VMware: Improve vmware_portgroup (#56382)
* Rewrite vmware_portgroup module
* support check mode
* VLAN ID isn't required anymore
* VLAN ID 0 (no tagging) is the default
* Options match values in vSphere Client and vmware_vswitch module
* Policy override is configured properly
* VMware: vmware_portgroup updates
2019-05-14 14:34:43 +05:30
René Moser
5b4cd227d7
Revert "inventory: virtualbox: fix typo in examples (#56328)" (#56374)
This reverts commit 099917ddc8.
2019-05-14 07:08:17 +02:00
Rahul Paigavan
f88dedb39d Fixed snapshot module, Resource not found issue for persistent-disk-0 (#35341) 2019-05-13 17:38:20 -04:00
Gonéri Le Bouder
cf78759f5b vmware_vm_facts: fix the support with regular ESXi
Ensure the module still work with the ESXi where CustomFieldsManager
does not exist.

From: https://www.vmware.com/support/developer/converter-sdk/conv60_apireference/vim.CustomFieldsManager.html

    The CustomFieldsManager object is used to add and remove custom fields to
    managed entities.
    The custom fields values set on managed entities are available through the
    customValue property and through the summary objects for VirtualMachine
    and HostSystem. They are not available directly through this managed object.
    This functionality is only available through VirtualCenter.

Fixes: #56071
2019-05-13 17:25:16 -04:00
Matt Clay
eefc90b66f
Revert oracle (#56364)
* Revert "Update vcn module documentation (#55888)"

This reverts commit 94ef24974a.

* Revert "Initial commit for Oracle Cloud Infrastructure modules (#53156)"

This reverts commit 07b9f52fd5.

* Revert "Add Oracle module maintainers (#55889)"

This reverts commit b0f3df360a.
2019-05-13 10:24:12 -07:00
Tzur Eliyahu
ef0851dcd4 IBM_Storage: fixed a bug - Unwanted arguments cause failure (#56357)
* IBM_Storage: fixed a bug which caused several of our modules to pass unwanted arguments and fail

* IBM_Storage: Added a changelog for 56357 bug
2019-05-13 12:41:06 -04:00
Steve Bonds
110b8ba660 ansible-config doesn't edit configs (#56355)
Avoid suggesting that it does in the description since that capability doesn't yet exist.
2019-05-13 11:35:13 -05:00
Fred-sun
f49a677622 update azure_rm_applicationsecuritygroup document (#56344) 2019-05-13 07:48:06 -05:00
Sumit Jaiswal
661f7be0fe
To fix the issue where nios_zone module was running second time for same object (#55595)
* fix for 55128 issue

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* review comment fix

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
2019-05-13 14:30:39 +05:30
krisvasudevan
d998791b4a Bug fixes for the nios member object (#56045)
* Bug fixes in api.py

* Examples updated in nios_member.py

* Update lib/ansible/module_utils/net_tools/nios/api.py

Co-Authored-By: Sumit Jaiswal <sjaiswal@redhat.com>
2019-05-13 12:53:25 +05:30
Ashley Connor
27fcd0fd9e Fix typo in aws log group return documentation (#56335)
Change from objetcs to objects
2019-05-13 08:37:41 +05:30
Fred-sun
35c655c8f5 modify azure_rm_aks* document (#56293) 2019-05-13 10:29:10 +08:00
Miguel Duarte Barroso
c6a8e99d34 Added the mtu property to the os_network module (#55881) (#54730)
The networking API v2 specification, which is implemented
by openstack neutron, features an optional MTU parameter that
allows operators to specify the value for the maximum
transmission unit value.
2019-05-12 10:26:27 +02:00
Bill Dodd
1a6b95a8f1 redfish: Add If-Match ETag header to PATCH requests (#56150)
* add If-Match ETag header to PATCH requests

* add changelog fragment

* ensure header keys are lowercase

* fix dict comprehension for python 2.6 and earlier
2019-05-12 10:24:07 +02:00
Yurii Fisakov
099917ddc8 inventory: virtualbox: fix typo in examples (#56328)
Typo fix in 'windows' word
2019-05-11 21:47:51 +02:00
Felix Fontein
05cee754b4 Hetzner failover IP info module (#56186)
* Add hetzner_failover_ip_info module.

* Extend return value.

* Adjust to changes from refactoring.

* Forgot to adjust example.
2019-05-11 21:45:38 +02:00
anasbadaha
0f852f01c0 Adding Support For EVPN in BGP Module (#55503)
* Adding Support For EVPN in BGP Module

Signed-off-by: Anas Badaha <anasb@mellanox.com>

* Fix Pep8 Failures in onyx_bgp.py

Signed-off-by: Anas Badaha <anasb@mellanox.com>

* Fix Pep8 Failures in onyx_bgp.py Phase 2

Signed-off-by: Anas Badaha <anasb@mellanox.com>

* Fix Samer's Comments

Signed-off-by: Anas Badaha <anasb@mellanox.com>

* Remove file Variable

Signed-off-by: Anas Badaha <anasb@mellanox.com>
2019-05-11 08:21:10 -04:00
anasbadaha
0cb0fa918f Adding Support for NVE Protocol in onyx_protocol (#55513)
* Adding Support for NVE Protocol in onyx_protocol

Signed-off-by: Anas Badaha <anasb@mellanox.com>

* Fix Pep8 Failures in onyx_protocol.py

Signed-off-by: Anas Badaha <anasb@mellanox.com>
2019-05-11 08:09:48 -04:00
anasbadaha
031655def0 Adding Support for Traffic Class in Onyx Switches (#55577)
* Adding Support for Traffic Class in Onyx Switches

Signed-off-by: Anas Badaha <anasb@mellanox.com>

* Enhancing the code and elemenating code duplicate

Signed-off-by: Anas Badaha <anasb@mellanox.com>
2019-05-11 08:08:52 -04:00
Abhijeet Kasurde
7e6be4e634
VMware: vmware_guest_disk support for use_instance_uuid (#56107)
All vmware_guest_* module support for use_instance_uuid from Ansible 2.8,
somehow vmware_guest_disk missed from this change.
This fix adds support for use_instance_uuid in vmware_guest_disk.

Fixes: #56021

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-05-11 11:58:13 +05:30
Abhijeet Kasurde
9f86257a65
VMware: support folder param in vmware_vm_facts (#56298)
folder can be used as a filter while gathering facts about VMs.

Fixes: #56125

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-05-11 11:56:57 +05:30
akshay1610
f5326aa6cd Update os_image documentation (#49705)
* Update os_image.py docs to show auth details
2019-05-10 11:21:13 -05:00
vicmunoz
ecdb616954 NetApp ONTAP module for manage ipspaces (#49821)
* NetApp ONTAP module for manage ipspaces

* fixes for ci_cd and code layout

* indentation fixes

* code style fixes

* fixing yamllint issue

* unit test for module na_ontap_ipspace

* fixing sanity tests

* change pytest.skip to pytest.mark.skip

* adding ansible version to 2.9
2019-05-10 11:24:02 -04:00
Sumit Jaiswal
3fdc4ba6b4
To fix IOS static route CI failure (#56292)
* ios static failure

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* fix CI failure

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
2019-05-10 14:19:00 +05:30
Chris Van Heuveln
1554befd95 nxos_vpc:Fix multiple idempotency issues, add missing commands (#55735)
* nxos_vpc:Fix idempotency issues with multiple attributes

Several attributes were causing idempotency problems on various platforms:

- `auto_recovery`
 - This command can be disabled on certain platforms and will nvgen as `no auto-recovery`
 - When enabled it has an additional optional-keyword for changing the `reload-delay` timer value
  - This was addressed by adding a new attribute `auto_recovery_reload_delay` to handle setting the timer value
  - This new attribute is mutually exclusive with `auto_recovery`

- `/show run vpc/show run vpc all/`
 - Changed the command that gets state to `all` so that it could differentiate between `auto-recovery` and `auto-recovery reload-delay`
 - This change resulted in also changing some attribute handling withing `get_vpc`, since some attributes like `peer_gw` relied on presence of the config to determine state true or false. With `all` the config is always there so these attrs must specifically check for `'no '` in the string.

- `delay_restore`
 - This command has two additional, optional keywords that exist on some platforms and not others.
 - New attrs:
  - `delay_restore_interface_vlan`
  - `delay_restore_orphan_port`

- Modified the `sanity` test to include the new attributes and to fix the platform issues.

- Bugfix Pull Request

`modules/network/nxos/nxos_vpc.py`

- Validated `nxos_vpc` `sanity` test on these platforms, all are now 100% Pass: N35, N3K, N3K-F, N6K, N7K, N9K, N9K-F

- TBD: Future work is needed to add support for `peer_gw_exclude_gw` timers. This could be addressed in the same way as the `auto_recovery_reload_delay` changes included here.

* lint fix

* Add 'version_added' tags for new options
2019-05-10 13:17:02 +05:30
Nathaniel Case
1097632039 eos_l2_interface: Handle Interface does not exist (#56140)
* Fail on switchport error

* Handle `Interface does not exist` when gathering switchport.
2019-05-10 13:14:29 +05:30
Nathaniel Case
776ec08ad5 Ensure 'authorize' is always bool, regardless of source (#56271) 2019-05-10 13:13:36 +05:30
Chris Van Heuveln
8c56c116e5 nxos_snmp_user: platform fixes for get_snmp_user (#55832)
* nxos_snmp_user: platform fixes for get_snmp_user

snmp user output behavior varies quite a bit for the different nxos platforms and required several workarounds:

- N5K/N6k
 - These platforms do not support structured output for `show snmp user`.
 - The current code lands in an `except` clause when the output is not structured; so I added a new `get_non_structured_snmp_user` method to scrape the state from the regular cli output if it's present.

- N9K-F
 - The `group` data in the JSON output is different for this platform; it has a different key (just `group` instead of `TABLE_groups` or `group_names`) and it is not indexed
 - For a single group the value is a string, for multiple groups it's a list

- sanity
 - N5K/N6K/N9K-F platforms will reject `no snmp user <name> <role>` when it's the last role defined for the user.
 - workaround is to use `nxos_user` to remove the user

- Changes validated on:
 - `N3K, N3K-F, N35, N6K, N7K, N9K, N9K-F`
 - `6.0(2)A8`
 - `7.0(3)I2, 7.0(3)I4, 7.0(3)I5, 7.0(3)I6, 7.0(3)I7`
 - `7.3(2)D1`
 - `7.3(3)N1, 7.3(4)N1`
 - `8.3(2)`
 - `9.2(2), 9.2(3)`

* fix lint warning
2019-05-10 13:10:49 +05:30
Felix Fontein
bd47e64bc7 Hetzner failover IP: refactoring (#56203)
* Rename helper function.

* Extract hetzner.py module_utils.

* Rewrite docs.

* Add module docs fragment.

* Split up get_failover function.

* Add tests for new function.

* hetzner_pass -> hetzner_password

* Move common argspec to module_utils.
2019-05-10 08:33:51 +02:00
Gonéri Le Bouder
7a02c40bbc vmware: find_vmdk_file with trailing / (#55957)
With the example, the `file_result.folderPath` of the file
does not have any trailing '/'. `target_folder_path` is correctly
generated and equal: `[nfs_1] images`.
2019-05-10 11:49:03 +05:30
Mike Wiebe
d55c0cf8dc nxos_vtp_*: Fixes n6k issues (#55737)
* Add n6k support for nxos_vtp_domain

* Add n6k support for nxos_vtp_version

* Add n6k support for nxos_vtp_password

* Fix shippable error
2019-05-10 10:54:51 +05:30
Takashi Sugimura
5346a5cdac updated to describe required parameter (#56197)
* update ec2.py to describe required parameters for each option for `state`
2019-05-09 17:44:53 -05:00
Abhijeet Kasurde
748cfd89ab VMware: Add examples of folder in vmware_deploy_ovf (#56216)
Fixes: #51825

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-05-09 17:33:20 -05:00
Diane Wang
bfc3687f70 remove guest_id check when use template (#55281) 2019-05-09 15:58:19 -04:00
Abhijeet Kasurde
499355fc13 VMware: Cleanup vCloud references (#56268)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-05-09 12:55:02 -07:00
Lars Kellogg-Stedman
61e476b908 connection/docker: add privilege escalation support (#55816)
As described in #53385 (and #31759), the docker connection driver did
not support privilege escalation. This commit is a shameless
cut-and-paste of the privilege escalation support from the `local`
connection plugin into the `docker` plugin.

Closes: #53385
2019-05-09 15:02:53 -04:00
Maxim Babushkin
45ee165fcd os_nova_host_aggregate - Fix aggregate delete with hosts (#53166)
Aggregate delete task will fail in case it has hosts within the aggregate.
As by the OpenStack, the hosts should be removed from the aggregate
prior aggregate delete.

Add remove host in case provided.
2019-05-09 12:38:28 -04:00
XuLei Ren
46c44a4359 Add new command GetVolumeInventory / GetSessions / GetVirtualMedia (#55433) 2019-05-09 09:45:08 -04:00
zengchen
d8314e1a45 refactor moudule utils of hwc_utils.py (#55858)
* use navigate_value instead navigate_hash

* add async wait method

* update dict compare

* remove unuse methods

* not all modules have timeouts parameter

* navigate_value, the input data may be None
2019-05-09 09:04:51 -04:00
Pavan Bidkar
34a8594c91 VMware: Modifying Rest Client to use vSphere-Api-Client instead of individual service(#55804)
* Same api client can be used for other service as well 
* Incorporated Review comments. Modified Category and Guest Fact modules which are also dependent on vmware_rest_client module util
* Adding Integration Tests for vmware_rest_client changes
* Changes to incroporate changes in vcsim testware
* Change to get vm name to attach the tag
2019-05-09 18:19:42 +05:30
Nathaniel Case
0bead3672f eos_config: Fix test issues (#56180)
* Alter tests to pass

* Change diff_against to make changed work again

* Add another diff_against

* Expose supports_sessions across all EOS connection types

* Change session warning to failure

* supports_sessions needs to be a method to survive the rpc boundary

* Alter tests to match
2019-05-09 18:02:24 +05:30
Rémi REY
a7bf728555 gitlab_group: doc: fix sample code that used 'parent_path' which does not exists (#56256) 2019-05-09 14:14:26 +02:00
Nathaniel Case
ea41bbcd4e Don't detect update if vrf not set. (#56235) 2019-05-09 17:33:47 +05:30
Fred-sun
fbee506284 update azure_rm_acs document (#56158) 2019-05-09 14:54:53 +08:00
rajaspachipulusu17
458b473d06 Pluribus network prefix list module (#55686)
* Pluribus network prefix list module

* Doc fix and unit test fix

* Added default value with args spec change

* Sanity fix
2019-05-09 10:31:06 +05:30
chalupaa
05e81b28e9 Fix to allow multiple origins with origin access identity enabled (#55189) 2019-05-08 13:33:19 -07:00
stoned
59d7ce6c3b Add missing roles to tower_role module (#56182)
* Add missing roles to tower_role module

* Placate 'ansible-test sanity --test pep8'
2019-05-08 13:11:50 -04:00
Sloane Hertel
463a7ff5ca [rds_instance] don't hardcode license_model choices (#53409)
* Don't hardcode license_model choices
2019-05-08 22:01:57 +05:30
Nathaniel Case
c5f3b778c4
Fix addition of newline for eos & nxos (#56227) 2019-05-08 12:28:04 -04:00
Mike Wiebe
bceca72eb7 nxos_interface: Fix admin_state check for n6k (#55673)
* Fix admin_state check for n6k

* Fix rx and tx_rate intent check test
2019-05-08 21:20:22 +05:30
Strahinja Kustudic
a5b6a161b5 sysctl will now return an error if the value is invalid (#55695)
* sysctl will now return an error if the value is invalid

sysctl can fail to set a value even if it returns an exit status 0. More
details: https://bugzilla.redhat.com/show_bug.cgi?id=1264080. Because of
this in case of an invalid value or a read-only file system, sysctl
module would return OK, even though it didn't set anything. To be sure
that sysctl correctly applied the changes we also need to check the
output of stderr.

* Run sysctl with LANG=C

Because we are parsing sysctl stderr we need to make sure that errors
are persistent across different system language settings.

* Add changelog fragment for sysctl
2019-05-08 11:34:55 -04:00
Trishna Guha
2e8a3efccb
Revert nxos, ios, iosxr return_timestamps (#56206)
* Revert "nxos_command:run_commands results failure when commands array size >1 (#52670)"
This reverts commit 0df5b92af3.
* Revert "added timestamps to nxos_command module (#50261)"
This reverts commit e150943314.
* Revert "added timestamps to ios_command module (#50323)"
This reverts commit 2a432a093b.
* Revert "added response_timestamps to iosxr_command module (#50095)"
This reverts commit 2a0c356da9.
2019-05-08 20:49:29 +05:30
Brian Coca
deae5b1bce
remove deprecated get_md5 from stat (#55659)
* remove deprecated get_md5 from stat

  fixes #55309

* removed get_md5 from tests involving stat

* keep get_md5 but hide it

* rst it

* ammended comment

* ws

* added ignore for hidden md5
2019-05-08 10:45:45 -04:00
Will Thames
cd95843ea5 Make ansible adhoc work with include_role (#56163)
* Make ansible adhoc work with include_role

Fix logic condition so that include_role works
without

```
ERROR! 'async_val' is not a valid attribute for a IncludeRole

The error appears to be in 'None': line 0, column 0, but may
be elsewhere in the file depending on the exact syntax problem.

(could not open file to display line)
```

* Add include_role test for adhoc
2019-05-08 09:53:24 -04:00
Bojan Vitnik
2a39dc84b7 XenServer: Minor changes and fixes in xenserver_guest (#55678)
* XenServer: Minor changes and fixes in xenserver_guest

 - xenserver_guest module: ignore wait_for_ip_address when
   state=absent (fixes #55348). Module docs are updated to reflect this.
 - xenserver_guest module: show proper error message when maximum number
   of network interfaces is reached and multiple network interfaces are
   added at once (fix for changes introduced in #54697).
 - xenserver_guest module: fixed a bug in reconfigure() where VM would
   be powered off even though check mode is used when reconfiguration
   needs VM to be powered off.

* Added changelog fragment
2019-05-08 09:03:44 -04:00
Andrea Tartaglia
5a6f888036 ec2_instance: Force int when ebs.volume_size or ebs.iops is specified (#55716)
* Force int when volume_size is specified

* changelog

* both volume_size and iops must be int

* updated changelog fragment
2019-05-08 22:10:58 +10:00
James E. King III
1462fd740b ec2_instance fix name idempotency (#55224) 2019-05-08 10:07:18 +01:00
Trishna Guha
57e0567310
fix nxos_vlan mode idempotence bug (#55144)
* fix nxos_vlan mode idempotence bug

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* Fix CI failure

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
2019-05-08 11:19:15 +05:30
Felix Fontein
7a957ba64a openssl_certificate: fix passphrase handling for cryptography backend (#56155)
* Make sure passphrase is bytes string.

* Fix typo.

* Add more passphrase tests.

* Fix test names.

* Add changelog.
2019-05-07 23:58:15 -04:00
Abhijeet Kasurde
193f69064f
VMware: remove duplicate implementation of memory reservation (#56161)
mem_reservation and memory_reservation has redundant implementation.
Combining them together.

Fixes: #54335

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-05-08 08:44:30 +05:30
Kylix
e00f086c96 Update k8s_facts.py (#56193)
https://github.com/ansible/ansible/issues/55448
2019-05-08 11:36:10 +10:00
Issei.M
c99e79cc58 Fix wrong date_size skip logic in s3_sync module (#53935) 2019-05-07 16:44:08 -07:00
Nathaniel Case
38890ddcaf
Expose newline option to cli_command module (#55451)
* Add newline to all cliconf plugins

* Expose newline in cli_command

* Also hook up to anything using transform_commands directly
2019-05-07 17:25:57 -04:00
vicmunoz
6f0ac90ec3 na_ontap_qtree / na_ontap_gather_facts: qtree new params and modify operation / new subsets (#55825)
* qtree new parameters and modify action

* fixing pylint offenses

* fixing shippable fails

* added igroup_info gather_subset

* added qos_policy_info / qos_adaptive_policy_info gather_subsets

* pylint fixes

* fixing shippable test failure

* requiring option flexvol_name for na_ontap_qtree module
2019-05-07 14:32:27 -04:00
Felix Fontein
ba9fee6c37 Hetzner failover IP module (#56103)
* First version of Hetzner failover IP module.

* Extend module.

* Add comments.

* Add basic unit tests.

* Add more tests.

* Tests for set_failover.
2019-05-07 19:11:15 +02:00
Anatoly Pugachev
6e73150244 refactor iscsi network facts module, remove external grep call, add unit test (#55643)
* remove external grep call and parse with python
* use function for repeated code
* use module.get_bin_path() for iscsiutil on HPUX
* some code opt for HPUX
* clean up non-module code, module being defined is a requirement for this code
* import get_bin_path() directly and use without module prefix
* Add integration tests for AIX and HP-UX
* add changelog fragment
* Apply suggestions from code review
Co-Authored-By: mator <matorola@gmail.com>
* Apply suggestions from code review #2
Co-Authored-By: Sam Doran <sdoran@redhat.com>
* Remove strict requirement on executable to exist for get_bin_path() as
it will allow facts gathering to continue without an error. Almost all
other files under facts do not have "required=True" (except 2 files,
which should be probably fixed). And check return value for
get_bin_path() , before run attempt.

* add check for AIX lsattr run_command return code
2019-05-07 12:26:20 -04:00
Ganesh Nalawade
9c5745ad21
Fix netconf_config backup string issue (#56175)
*  Convert the ElementTree object to string
   before dumping the configuration in file.
2019-05-07 11:31:58 -04:00
Nilashish Chakraborty
7608bc821e
Fix vyos cli prompt issues (#55589)
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
2019-05-07 20:51:35 +05:30
Dag Wieers
beca3661a4
Fix some index-references and warn about remaining (#55727)
The ACI MultiSite PATCH API has a deficiency requiring some objects to be referenced by index.
This can cause silent corruption on concurrent access when changing/removing on object as
the wrong object may be referenced.

This PR removes some references by index, and documents this issue for
others.
2019-05-07 15:00:04 +02:00
Abhijeet Kasurde
2007a79952
VMware: Add managed object id in VM facts (#53523)
Fixes: #53372

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-05-07 17:05:38 +05:30
Andrey Klychkov
f79b6b06f1 postgresql_table: added cascade option (#56068) 2019-05-07 16:08:03 +05:30
Ganesh Nalawade
9271b4e368
Fix net_get and net_put task run failure (#56145)
* net_get and net_put action plugin class need
  to inherit from ActionBase class as the action
  class implements the entire get and put logic
2019-05-07 06:34:36 -04:00
Chris Van Heuveln
0e0c2a7db7 nxos_snmp_traps: fix 'group: all' for N35 platforms (#55995)
* nxos_snmp_traps: fix 'group: all' for N35 platforms

- `group: all` attempts to enable traps for all features defined in the module's `feature_list`

- `N35` platforms do not support `snmp-server enable traps bfd`; so removing `bfd` from the `feature_list` for that platform

- Minor cleanup in `sanity.yaml` test file

* whitespace lint fix
2019-05-07 13:57:55 +05:30
MyronFanQiu
14c218bb2f Check existence before calling get method (#56105) 2019-05-07 09:26:02 +08:00
iinuwa
6b474a1ecd Sync required flags from argument_spec to docs (#56121)
<!--- Your description here -->
The arguments for certificate, private_key and password are marked as required in the ArgumentSpec, but not in the documentation. 
+label: docsite_pr
2019-05-06 16:49:07 -05:00
wjohnston888
647ed207af Fixes Netconf_config single parameter bug (#56138)
* Fixes Netconf_config single parameter bug
Fixes 56022

fixed get_config to not require multiple parameters to just run a backup

* Add Integration test for netconf_config
Associated with #56022

tests backup through netconf only using one parameter.

* Added debug to the begin and end of file

* Fix formatting of save config.  #56022

* removed blank line at end: #56022
2019-05-06 17:30:49 -04:00
René Moser
f42a32ad36
cs_network_acl_rule: implement cidr/cidrs as list (#56083) 2019-05-06 22:36:26 +02:00
Alicia Cozine
8cb76408d3 Update include_role description (#56001)
* Update include_role description to discuss tasks: use

The previous description in this statement's description really threw me off, and is IMO ambiguous at best. 'Loads and executes a role as a task dynamically. This frees roles from the roles: directive and allows them to be treated more as tasks.'

For reference, I spent a long time trying to make include_role, with a loop, work under a roles: section. It doesn't work, but this documentation and its use of the roles: keyword in the opening, and the phrase '"more" as a task' muddies the waters.

+label: docsite_pr
2019-05-06 16:17:50 -04:00
Michael Tipton
dc711c3018 VMware: vCenter Cluster EVC Mode : new module (#56089)
* add vmware_evc_mode module

* alter result message for absent/absent

* Apply suggestions from code review

Co-Authored-By: CastawayEGR <36353334+CastawayEGR@users.noreply.github.com>

* add idempotency test

* change result dict to evc_mode_msg

* refactor to use pyvmomi class

* fix update to only process task on update

* minimize update code

* add single quotes around vars to match other code

* pass datacenter to cluster find

* add check_mode to disable test
2019-05-06 13:12:19 -07:00
Nathaniel Case
3d9da0c468
Don't fail trying to read boot image without enable (#56126)
Also add a message when network_os_image can't be acquired.
2019-05-06 15:15:26 -04:00
Major Hayden
93d24efe37 package_facts: Trivial docs cleanup (#56015)
Make a small documentation cleanup for the package_facts module to use
the current YAML style and remove unnecessary quotes around `auto`.

Signed-off-by: Major Hayden <major@redhat.com>
2019-05-06 09:59:14 -05:00
Benjamin MALYNOVYTCH
f90398a31d mysql_user: fix regression (#55292) 2019-05-06 16:25:43 +02:00
kobihk
ba9f0d53b2 add missing exported state do doc string (#56109) 2019-05-06 09:08:32 -05:00
Gonéri Le Bouder
23e63c9237 vmware: check the SSL certification
If `validate_certs` is enable, we now validate the server SSL
certificate.
2019-05-06 09:15:16 -04:00
Scott McIntyre
14ab205ea2 Fixed whitespace on server key 2019-05-05 12:49:56 -04:00
mttocs
7ab67fb2fe Add PTR Examples to nsupdate module
<!---  Add PTR Examples since Nsupdate usage may not be straight forward  -->

+label: docsite_pr
2019-05-05 12:49:56 -04:00
Lars Kellogg-Stedman
5e74ecb4fd fix documentation for docker_container publish_ports option (#56093)
The documentation for the docker_container publish_ports options
erroneously stated that container ports must be "exposed" in order to
be "published".
2019-05-05 06:24:32 -04:00
Felix Fontein
f692261ea0 oom_killer and oom_score_adj are available since docker-py 1.8.0. (#56012)
* oom_killer and oom_score_adj are available since docker-py 1.8.0.

* Add changelog.
2019-05-05 06:13:55 -04:00
Ganesh Nalawade
1a66121f03
Fix invalid src option return response for network config modules (#56076)
*  Add changed key in faliure case to maintain backward compatibility
2019-05-04 07:23:12 -04:00
solidblu
fa5a94aa71 doc: fix typos in azure_rm_webappslot.py (#56004) 2019-05-04 08:57:38 +02:00
Gonéri Le Bouder
223321e7e2 vmware_datastore_facts: empty list if none found
When `vmware_datastore_facts` does not fine any datastore, it raises an error.
This is not consistent with the other _facts modules. It should just return
an empty list instead.
2019-05-03 18:29:00 -04:00
Nagoor Shaik
2925f6960e Update openssl_privatekey.py (#55438)
* Update openssl_privatekey.py

<!--- Your description here -->

+label: docsite_pr

* Update lib/ansible/modules/crypto/openssl_privatekey.py

Co-Authored-By: snagoor <nagoor.s@gmail.com>

* Update lib/ansible/modules/crypto/openssl_privatekey.py

Co-Authored-By: snagoor <nagoor.s@gmail.com>
2019-05-03 18:52:26 +01:00
Felix Fontein
95d1564f70 docker_container: use restart() API function instead of stop/start sequence (#55894)
* Improve container restart.

* Adjust tests.

* Add changelog.

* Quote options.

* Move tests for restart/recreate options to start/stop tests.

* Fix changelog name.
2019-05-03 11:30:39 -04:00
Gonéri Le Bouder
93f0112953 vmware_host_config_manager: do not apply an empty list of change
In a multi-host context, `changed_list` will record all the changes
done on any host. So as soon as ONE host is changed, it will be `True`.

A host can potentially already have a parameter set, in this case
`change_option_list` will be empty.

This commit uses `change_option_list` instead of `changed_list` to
decided if a given host should be updated.
2019-05-03 11:04:30 -04:00
flowerysong
2ef8b297ff Fix loading namespaced doc_fragments from collections (#55249)
* Fix loading namespaced doc_fragments

The syntax for specifying a different fragment name was already
using '.' as a separator, so the code needed to be tweaked to
avoid choking on names like `testns.testcoll.fragname` and
`testns.testcoll.fragname.altvar`.

`get_plugin_class()` returns 'docfragment' for the fragment loader;
mangling `subdir` provides consistent alignment with the normal plugin
directory names and avoids needing special handling of plugin types
with 'module' in the name.

* Add changelog entry
2019-05-02 21:15:57 -04:00
Dag Wieers
fcca1a124d
Fix non-signature authentication (#56038)
Apparently everyone is using signature authentication these days.
2019-05-03 01:47:29 +02:00
Sloane Hertel
47b2cb748b Allow config boolean options to default to None (#55951)
* Allow plugin boolean options to default to None

* fix mistake

* changelog

* be more specific
2019-05-02 12:09:14 -07:00
Abhijeet Kasurde
cabbb0a0e5
VMware: Assign vSAN License for cluster (#55916)
* Modified vcenter_license to accept vSAN license and assign to
the given cluster.
* review comments

Fixes: #55711

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-05-02 21:39:25 +05:30
Xander Madsen
3cebb79328 Feat/add GetChassisInventory to Chassis category of redfish_facts (#54269)
* Implement get_chassis_inventory() in redfish_utils

* Add GetChassisInventory command to redfish_facts
2019-05-02 16:00:43 +01:00
Xander Madsen
b108d01b0f Feat/add GetBootOverride to Systems category of redfish_facts (#54273)
* Add GetBootOverride as possible Systems command

* Add conditional to call get_boot_override if command == GetBootOverride

* Implement get_boot_override() in redfish_utils

* Implement get_multi_boot_override() and modify get_boot_override() to support the multi wrapper

* Update GetBootOverride to use get_multi_boot_override

* Add example for new command in docstring

* fix indent

* Update lib/ansible/module_utils/redfish_utils.py

Co-Authored-By: xmadsen <xander.madsen@gmail.com>
2019-05-02 14:08:16 +01:00
rajaspachipulusu17
5309d6c131 Pluribus networks fabric local module with UT (#55872)
* Pluribus networks fabric local module with UT

* Sanity fix

* Ansible doc standards

* Unit test fix
2019-05-02 18:34:29 +05:30
Bill Dodd
2614e823df Fix SetOneTimeBoot to use standard ComputerSystem 'Boot' property (#54201)
* fix SetOneTimeBoot to use standard ComputerSystem 'Boot' property

* add support for UefiTarget and UefiBootNext boot sources
2019-05-02 13:50:41 +01:00
Xander Madsen
eb7190264e Add GetChassisPower command to Chassis category of redfish_facts (#54314)
* Add GetChassisPower as viable Chassis command in redfish_facts

* Add conditional to catch command == 'GetChassisPower'

* Implement get_chassis_power() retrieving Watts-related and other useful power data from each Chassis

* Add RelatedItem property and remove MemberId property

* Check for length of data['PowerControl'] to be > 0 before checking index 0 of the list.

* Fix return statement being inside loop and result key not being 'entries' as is expected

* Update lib/ansible/module_utils/redfish_utils.py

Co-Authored-By: xmadsen <xander.madsen@gmail.com>

* Update lib/ansible/module_utils/redfish_utils.py

Co-Authored-By: xmadsen <xander.madsen@gmail.com>

* Update redfish_facts.py
2019-05-02 13:48:57 +01:00
Mike Wiebe
9f830b77fc Fix passwordless workflow (#55441) 2019-05-02 18:06:25 +05:30
Chris Van Heuveln
de8ce08fd8 nxos_vlan: vlan names containing regex ctl chars should be escaped (#55463)
The `nxos_vlan` module may raise with regex error `sre_constants.error: multiple repeat` in the non_structured codepath if the device has existing vlan names with certain regex control characters; e.g.

```
VLAN Name                             Status    Ports
---- -------------------------------- --------- -------------------------------
1    default                          active    Eth1/3
14   my-vlan-name-is-***              active
```
2019-05-02 18:04:00 +05:30
Chris Van Heuveln
869fdcd7d4 nxos_acl: some platforms/versions raise when no ACLs are present (#55609)
* `nxos_acl` may fail with `IndexError: list index out of range` while attempting to delete a non-existent ACL.

The failure occurs when the `acl` var is an empty list.

* nxos_acl: catch 501 'Structured output unsupported' when no ACLs present

With some older image versions, `show ip access-list | json` will raise a 501 error indicating `'Structured output unsupported'` when there are no access-lists configured. This change turns off the `check_rc` and then looks for the failure condition.

* Fix kwarg

* Fix lint issues
2019-05-02 18:03:27 +05:30
Brian Coca
24a46deef5
Package facts apt fix (#55963)
* fixes for apt on package_facts

* reverse order, apt is newer

* moved warnings prop to base
2019-05-01 22:11:12 -04:00
Hideki Saito
c455635500 Fix firewalld source option handling to be exclusive (#55715)
- Fix issue #55683
- Add integration test for source option of firewalld module

Signed-off-by: Hideki Saito <saito@fgrep.org>
2019-05-01 17:47:47 -04:00
Alexander
c707dd7b62 Added implicit initialization of APT package manager '_cache' field (#55851) 2019-05-01 17:08:18 -04:00
Brian Coca
5d4c73e197 unite poll defaults (#55470)
* unite poll defaults and update docs
2019-05-01 13:47:50 -05:00
angystardust
ac657f67c0 Support "force_subnet_association" parameter on na_ontap_interface (#52691)
* Support "force_subnet_association" parameter on na_ontap_interface

* fix validate-modules issue

* - Fix spurious commit
2019-05-01 14:41:48 -04:00
Kevin Breit
91237fa414 Meraki util - Add method to encode parameters in the URL (#49015)
* Add new method to encode parameters in the URL
- I'm not really encoding, I'm sure this is broke
- There maybe an Ansible native way to do this

* Fix whitepace

* Added urlencode support
- Relies on urllib module
- Fixed string delimiter

* Enable URL params
- construct_params_list() creates a list of parameters to encode
- encode_url_params() does encoding in a simple manner

* Added proper methods for urlencoding

* Remove duplicate functions

* Remove blank line for PEP8
2019-05-01 13:15:36 -04:00
Kevin Breit
a89a2cf33f meraki/meraki_network - Enable/disable VLANs on network (#48820)
* Redo branch to fix merge commit

* Add changelog fragment

* Make VLAN settings idempotent

* Fix conflict

* Change `version_added` to 2.9 instead of 2.8.
2019-05-01 12:24:39 -04:00
cbuquet
23ddc7738b Update sample (#55654)
Correct logConfiguration example on the ecs_taskdefinition module.
2019-05-01 11:15:28 -05:00
Abhijeet Kasurde
7505550500 VMware: Handle VMs with no configurations
Sometime VMs does not return any configurations which leads
to failing the inventory plugin.

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-05-01 11:47:28 -04:00
Anil Kumar Muraleedharan
d9a1c8954f Coverity Bug Fix for cnos_vrf.py (#55954)
* Coverity Bug Fix for cnos_vrf.py

* Update cnos_vrf.py
2019-05-01 10:57:04 -04:00
Todd Bowman
6610d678f8 Add vrf option to static routes (#55298)
* added vrf to static route

* fix pylint errors

* version added 2.9 for vrf

* removed undocmented return values

* Update README.rst
2019-05-01 10:55:09 -04:00
Brian Coca
ea57377ddf correct method docs (#55961) 2019-05-01 09:13:57 -05:00
Matthew Davis
0b002203b4 clarify docs for rel src state hard (#55972) 2019-05-01 07:17:30 -05:00
Jordan Borean
cc3b8b9f72
win_acl - fix network path qualifier parsing (#55970) 2019-05-01 17:21:26 +10:00
Jordan Borean
5228133d74
Ansible.Basic - fix when deserialising a json string of an array (#55691)
* Ansible.Basic - fix when deserialising a json string of an array

* Added changelog fragment
2019-05-01 11:08:23 +10:00
jhawkesworth
0e8a77520c Refactor of win_xml (2nd attempt) to add support for processing multiple nodes and counting nodes matched by xpath (#53362)
* add multi-node manipulation, delete on xpath match only and count capability to win_xml

* fix pep8 and yamllint errors identified by ci tests

* fixed bugs when handling multiple elements, multiple attribute nodes and handling for attribute nodes when using xpaths that only select attributes like //@lang.  Added more tests and tweaked documentation.

* fixed line-too-long error

* fixed trailing space errors

* trailing whitespace expunged

* bump version_added to 2.9 for new changes

* fix PSAvoidUsingPositionalParameters sanity check failure

* refix sanity check as it broke the msg return value
2019-04-30 13:19:56 -07:00
Ondra Machacek
7e3b1da33f kubevirt_vm: Add example how to use davatavolumes (#55906) 2019-04-30 14:41:49 -05:00
Stefan Horning
7cf0626d7b Fixe cloudfront_distribution module issue #45043 (#49434) 2019-04-30 12:28:55 -07:00
Martin Krizek
f37476e247 template lookup: restore variables between calls (#55126)
* template lookup: restore variables between calls

Fixes #55113

* Address issues from the review
2019-04-30 15:22:37 -04:00
Sam Doran
0e8a6e08ce Clarify documentation an reboot delay paramaters (#55934) 2019-04-30 11:28:33 -05:00
Sumit Jaiswal
7e7eced425
Commenting Cliconf support call for IOS-XR modules for Ansible 2.9 version (#55751)
* iosxr cliconf support call

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* iosxr cliconf support call

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* iosxr cliconf support call

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* iosxr cliconf support call

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>

* iosxr cliconf support call

Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
2019-04-30 21:20:28 +05:30
Brian Coca
45d21b6474 Fix and refix help text for CLI (#55831)
fixes #23395 giving clearer information on installed role path
  re-fixes 'home display issue' for module-path
2019-04-30 11:16:26 -04:00
Sloane Hertel
11279a909d fix combine filter using undefined vars (#55840)
* Check variables are defined before using combine filter

* Add tests for the combine filter

* Remove dependencies that should already be installed

* relocate the function to recursively check for undefined vars

add another test

* changelog
2019-04-30 11:10:19 -04:00
Xander Madsen
8cfc9e6d22 Add GetSupportedFirmwareUpdateMethods to redfish_facts/Update commands (#54268)
* Add GetSupportedFirmwareUpdateMethods to update category commands list

* Add condition when command == GetSupportedFirmwareUpdateMethods to call the forthcoming rf_utils function get_supported_firmware_update_methods

* Implement get_supporte_firmware_update_methods() in redfish_utils

* rename command to GetFirmwareUpdateCapabilities

* rename comand get_firmware_update_capabilities()

* Rename command get_firmware_update_capabilities()

* Group update protocols by the type of Action they are associated with.

* remove trailing whitespace

* Use safer method to get 'title' for each action type and its allowablevalues

* Add example to docstring for using GetFirmwareUpdateCapabilities

* fix line too long

* fix line too long and trailing whitespace

* Update redfish_utils.py

* remove trailing whitespace

* fix overindent

* Use self.update_uri instead of hard-coding '/redfish/v1' in get_firmware_update_capabilities()
2019-04-30 13:53:54 +01:00
Xander Madsen
1aec39a2d7 Add GetChassisThermals command to Chassis category of redfish_facts (#54399)
* Add GetChassisThermals command to Chassis list

* Add GetChassisThermals conditional and point to rf_utils.get_chassis_thermals() function

* Implement get_chassis_thermals() in redfish_utils

* Remove trailing whitespace

* Add more properties, including RelatedItem tto distinguish entries' contexts from each other.

* Remove trailing whitespace
2019-04-30 13:46:24 +01:00
Abhijeet Kasurde
216d8b5254
VMware: support check mode in all facts modules (#55689)
* vmware_cluster_facts
* vmware_guest_facts
* vmware_guest_snapshot_facts
* vmware_host_capability_facts
* vmware_host_package_facts
* vmware_target_canonical_facts

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-04-30 16:39:21 +05:30
Ondra Machacek
8328eaee91 ovirt_disk: Fix vm creation (#55910) 2019-04-30 06:32:54 -04:00
Brian Coca
815a375177
allow empty plays again, for now (#55878) 2019-04-29 17:59:10 -04:00
Nabeel Al-Saber
94ef24974a Update vcn module documentation (#55888) 2019-04-29 15:38:50 -05:00
Sam Doran
b3ce3fc5eb
Restore ansible --version output (#55728)
* Add custom action class for version info
* Use args from CLI as prog for ArgumentParser object
* Make prog a required parameter of create_base_parser() and update all uses to pass in the newly required parameter.
* Add unit test for checking ansible --version
* Update other related unit tests
2019-04-29 16:38:31 -04:00
zingyb
c195645575 Remove illegal basic provisioning example (#55892)
The bare minimum example in the docs (i.e. only supplying name, state, and cluster) results in the error `state is present but all of the following are missing: task_definition, desired_count`.
2019-04-29 15:36:50 -05:00
The Magician
164ceb599b Bug fixes for GCP modules (#55358) 2019-04-29 15:51:09 -04:00
The Magician
50b72ec2b5 Bug fixes for GCP modules (#55359) 2019-04-29 15:50:53 -04:00
The Magician
6193658608 Bug fixes for GCP modules (#55360) 2019-04-29 15:50:41 -04:00