Commit graph

48842 commits

Author SHA1 Message Date
Kiyo Nagamine
f89ea5677b Fix typo in a changelog fragment of #64902 (#65533) 2019-12-10 09:51:47 -05:00
Evgeni Golov
3af1732bd8 fix rendering of GOOD/BAD code for regex_replace examples (#65654)
adds double colon (::) so the examples render as code
2019-12-10 08:49:38 -06:00
Joseph Jacobs
d9f0703b45 Update generator.py documentation (#65573) 2019-12-10 09:29:00 -05:00
Andrew Klychkov
e818ab1dd0 mysql_info: add seealso section (#65688) 2019-12-10 09:26:00 -05:00
Alex
4239dc1bb5 ANSIBLE_CACHE_PLUGIN_TIMEOUT - docs (#65311) 2019-12-10 09:19:54 -05:00
Gonéri Le Bouder
030b20b024
prepare_vmware_tests: ensure 'VM Network' exists (#65616)
Depending on the ESXi configuration, the 'VM Network' may missing.
2019-12-10 09:08:42 -05:00
Jasper Lievisse Adriaanse
53cd0bdd29 docs: Prefer python3 on OpenBSD (#65447) 2019-12-10 09:05:18 -05:00
Paul Belanger
d39870a693 Remove unused code in nxos_user (#65529)
There is no longer the need to warn on password, it is not supported any
more.

Update nxos_user tests not to purge current SSH user for nxos, otherwise
we loose access for testing.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>
2019-12-10 19:01:59 +05:30
Abhijeet Kasurde
7d2ae7e322 solaris_zone: Allow only valid characters in zone name (#65686)
CVE-2019-14904 - solaris_zone module accepts zone name and performs actions related to that.
However, there is no user input validation done while performing actions.
A malicious user could provide a crafted zone name which allows executing commands
into the server manipulating the module behaviour.

Adding user input validation as per Solaris Zone documentation fixes this issue.

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-12-10 07:18:55 -05:00
Andrew Klychkov
c791f916d3 postgresql_schema: use query_params with cursor object (#65679) 2019-12-10 14:11:23 +05:30
Abhijeet Kasurde
2e82989b3b
Add support for podman in virtualization facts (#64981)
Check additional file check virtualization facts for podman

Fixes: #64954

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-12-10 11:26:34 +05:30
JP Mens
f8216db21f Update iocage.py: remove 'docker' (#65656)
It seems to me as though the term 'docker' was copy/pasted in; I don't understand what it would mean in the context of iocage. As such, I think removal is best.
2019-12-10 11:09:54 +05:30
Toshio Kuratomi
ddd786eedf Fix tests which have unparsable yaml 2019-12-09 16:54:29 -08:00
Sam Doran
7767f0bb23
Mark yum tests as unstable (#65671)
Fedora 31 tests are failing due to a missing packages error. I am unable to duplicate this issue when running locally, so it is possibly an issue with a mirror that is being used when run from Shippable
2019-12-09 16:24:11 -05:00
Dusan Matejka
880bbb9946 fixed inconsistent required set to True in zabbix modules 2019-12-09 10:20:17 -08:00
Sam Doran
d35c1a435b
Handle InternalError raised by cryptography when running in FIPS mode (#65477)
Since older versions of paramiko do not require cryptography,
we cannot catch the exact exception from cryptography.

Remove other exceptions since we're catching everything now
2019-12-09 13:18:32 -05:00
Abhijeet Kasurde
0b2558051c
VMware: Minor fixes in vmware_httpapi modules (#65663)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
2019-12-09 22:14:00 +05:30
Jarno Huuskonen
0647c52368 Detect virtualization facts when VM on Nutanix AHV hypervisor (#58327)
- /sys/devices/virtual/dmi/id/product_name == 'AHV'
- /sys/devices/virtual/dmi/id/sys_vendor == 'Nutanix'
2019-12-09 21:50:20 +05:30
Jiri Tyr
28019233db Don't search for VMDK if filename is defined (#63741) 2019-12-09 11:06:31 -05:00
Mark Chappell
d8943d495e AWS NLB: Deprecate current default behaviour of 'absent' (#65468)
* Deprecate elb_network_lb default of *delete*.

* Add changelog fragment

* Porting guide entry
2019-12-09 15:55:32 +01:00
Felix Fontein
ecb6f2e76c Fix bug in format handling. (#65642) 2019-12-09 18:56:15 +05:30
Felix Fontein
57c042243f
crypto modules: fix various errors in argument specs (#65633)
* Fix various errors in crypto module argument specs.

* Adjust PR #.

* Fix provider requirement.

* Make sure openssl binary is installed.
2019-12-09 13:40:11 +01:00
Felix Fontein
e9cec0262d
docker_* modules: fix various errors in argument specs (#65632)
* Fix various errors in docker module argument specs.

* Adjust PR #.

* Fix option name.

* Fix username/password requirements for docker_login.
2019-12-09 13:39:02 +01:00
Mark Chappell
9f87978eb3 aws_acm: Fixup typo in argument_spec (alias should be aliases) (#65653) 2019-12-09 18:00:22 +05:30
Benjamin
30132861af Introduce force_basic_auth for maven_artifact (#64808)
as it's known from uri or get_url. Causes basic auth header to be sent on first request to avoid trouble with some receiving ends.

Fixes #64595
2019-12-09 05:26:12 -05:00
Martin Nečas
9c79de2e1e ovirt_vm: dont try to update template when already created from clone (#65317) 2019-12-09 05:09:33 -05:00
Mark Chappell
5c9539903e iam_policy: Make 'iam_name' a required option to match the documentation (#65559)
Without it we'd always throw a boto error
2019-12-09 15:08:43 +05:30
Mark Chappell
4919d5658a iam_cert: Make 'name' a required option to match the documentation (#65558)
Without it we'd always throw a boto error
2019-12-09 14:53:53 +05:30
Mark Chappell
cf3f1b9d3f iam: Make 'name' required to match the documentation (#65557)
With the exception of deleting Users and Roles (where we'd do nothing and exit) not passing a name would trigger a boto exception.
2019-12-09 14:46:02 +05:30
Mark Chappell
eac7d2a958 ec2_placement_group: Make name 'required' to match the documentation (#65555)
Previously you'd get one of the following behaviours:
- A boto3 error
- Nothing would change
- An error that you're not allowed to change the strategy

So of the bahaviour would depend on the random order that AWS returns the list of all Placement Groups
2019-12-09 14:35:36 +05:30
Richlv
a56139e792 Link to LTS version of Zabbix docs (#65604)
Documentation now points to version 4.0
2019-12-09 10:16:40 +05:30
Xu Yuandong
7089fa1cd4 update to remove redundant code. (#65630)
* update

* update

* update
2019-12-08 20:37:35 -05:00
Felix Fontein
717c0da32b
2.10 -> 2.9.2 (#65517) 2019-12-08 15:14:24 +01:00
Mads Jensen
965474841f Use a context manager in docker.ImageManager. (#65609)
Co-Authored-By: Felix Fontein <felix@fontein.de>
2019-12-08 08:36:33 -05:00
Matt Martz
03a4edb477 Add method to automatically clean up after an action plugin (#65509)
* Use correct var, move cleanup for async
* Add changelog and tests. Fixes #65393. Fixes #65277.
* Kill off all long running async tasks from listen_ports_facts
* Update task to work with older jinja2
2019-12-06 17:29:26 -05:00
Abhijeet Kasurde
c97360d21f vmware: vmware_vm_inventory use port value when with_tags:True (#65568)
If user specifies a port number in vmware_vm_inventory plugin configuration,
then use that port to connect to vCenter rather than connecting to 443 which
is default port.

Fixes: #64096
2019-12-06 15:23:12 -05:00
Jordan Borean
b782227642
display - Fix up tracebacks on 3rd party loggers when log path is set (#65582) 2019-12-07 06:06:52 +10:00
Dan Ramaley
09fca101b7 Nagios module: minor change, added "start" parameter (#61562)
* Finished implementing the "start" parameter to the nagios module. The backend functions already had it; this change just exposes it. This allows setting the time a Nagios outage begins rather than always starting at the time the module was run. If not provided, "start" defaults to the current time (preserving compability with existing playbooks).
* Changed default start time to None, as per comment by @goneri. This avoids initializing the variable twice.
2019-12-06 12:23:03 -05:00
Gonéri Le Bouder
b8cd4c5409 remove some tests from zuul/vmware/vcenter_only
Depends-On: ansible/ansible-zuul-jobs#253

We cannot run the following tests without any ESXi host:

- vmware_drs_rule_info
- vmware_drs_rule_facts
- vmware_host_acceptance
- vmware_host_active_directory
- vmware_host_powerstate
2019-12-06 12:20:21 -05:00
Lukas Kämmerling
5ad61ed7c1 Fix and reenable hcloud tests 2019-12-06 08:30:01 -08:00
Sergey
e444e68bf0 Add podman_container_info module (#64361)
Co-Authored-By: Felix Fontein <felix@fontein.de>
2019-12-06 09:50:30 -05:00
Nilashish Chakraborty
63bb08fea8
Object searching method should not traceback for non-existant keys (#65553)
Signed-off-by: NilashishC <nilashishchakraborty8@gmail.com>
2019-12-06 17:56:39 +05:30
Andrew Klychkov
531eebffa8 mysql: remove unused import (#65606) 2019-12-06 12:19:45 +00:00
Andrew Klychkov
10898cbcbf postgresql_idx: fix maintainer's name (#65605) 2019-12-06 06:06:29 -05:00
Andrew Klychkov
0474f0b4dd mysql_info: add note to the module's documentation (#65603) 2019-12-06 05:53:04 -05:00
Andrey Klychkov
a79c9e23ee mysql_db: add seeaslo section (#65593) 2019-12-06 02:30:28 -05:00
Andrey Klychkov
85486b1ce4 mysql: add changelog fragment for PR 64585 (#65594)
* mysql: add changelog fragment for PR 64585

* change fragment name and bug description
2019-12-06 12:05:47 +05:30
Jürgen Hötzel
47aea84924 Don't return module error when mysql_connect fails (#64560) (#64585)
* Don't return module error when mysql_connect fails (#64560)

mysql_user expects an Exception when using check_implicit_admin.

* Adds integration tests for mysql_user check_implicit_admin (#64560)
2019-12-06 11:22:34 +05:30
Jordan Borean
f21e72d55a
win_package - Use newer module wrapper as refactor baseline (#65586)
* win_package - Use newer module wrapper as refactor baseline

* Fix aliases in new arg spec
2019-12-06 13:37:52 +10:00
Ganesh Nalawade
3919a891c2
Fix iosxr netconf plugin get device info (#65489)
* Fix iosxr netconf plugin get device info

Fixes https://github.com/ansible/ansible/issues/64634

*  Catch execption if the xml payload to get
   device info is not valid for iosxr version
   running on remote host.

* Fix CI issue
2019-12-06 08:58:03 +05:30