Commit graph

23128 commits

Author SHA1 Message Date
Tim Rupp
e619052424
Fixes multiple lgtm issues (#45629)
Most of the issues were just inclusions of code that were not used.
This cleans those up. Other alerts were semi-false-positives for now
2018-09-13 15:26:17 -04:00
Matt Martz
e68f895e61
Support empty files with piped transfer_method. Fixes #45426 (#45618) 2018-09-13 13:53:36 -05:00
Vibhav Sinha
e26d758d6f fix gce_backend_service examples for healthchecks (#31134)
gce_backend_service module expects healthchecks to be an array of string. The previous example incorrectly mentioned healthchecks as an array of objects each containing a `name` key.
2018-09-13 13:47:43 -05:00
Tim Rupp
34d08adea0
Fixes lgtm alert (#45619)
Alert was for an include that was not used.
https://lgtm.com/projects/g/ansible/ansible/latest/files/lib/ansible/modules/network/f5/_bigip_facts.py?sort=name&dir=ASC&mode=heatmap&showExcluded=false#L98
2018-09-13 13:45:55 -04:00
Michael Scherer
de84a05bf4 Remove unused import iControlUnexpectedHTTPError (#45611)
Since that's unused in the code, no need to import it.
This got flagged by linter
2018-09-13 13:16:23 -04:00
Anton Nikulin
b7263eab1d Store Authorization header inside HttpApi connection plugin (#45598) 2018-09-13 19:34:30 +05:30
Nathaniel Case
285b927889
network command modules cleanup (#45242)
* Standardize _command modules

* Centralize command transformation process

* Fix check mode error test
2018-09-13 08:55:35 -04:00
Zim Kalinowski
df768914a1 adding sql firewall rule facts (#45059) 2018-09-13 17:54:58 +08:00
Strahinja Kustudic
8d8df46fe6 Add an error message if a pkg cannot be removed, fixes #35672 (#40723) 2018-09-13 02:54:38 -04:00
tterranigma
cc477ec920 Update fileglob.py (#45558)
* Update fileglob.py

Closes #45557

* Update fileglob.py
2018-09-13 12:10:00 +10:00
Nathaniel Case
3d0f19d8cd
Exclude the whole ansible_failed_task block (#45587)
It has lots of FieldAttributes that won't serialize.
Also the connection doesn't care.
2018-09-12 21:17:24 -04:00
Jordan Borean
d81249994e
win_script: add support for become and centralise exec wrapper builder (#45582)
* win_script: add support for become and centralise exec wrapper builder

* satisfying the pep8 gods

* do not scan for module dependencies when running as a script
2018-09-13 08:50:13 +10:00
Sam Doran
03dbb1d9c4 Improve code stability is checksum checking
- use context manager for dealing with the checksum file
- use loop that can tolerate zero, one, or more items return rather than the previous expression which would break if anything other than exactly one item was returned
2018-09-12 15:29:15 -07:00
Martin Nečas
2a3f3382fd Ovirt add rename functionality (#44951)
* add renaming of ovirt
* add renaming func to ovirt cluster
* ovirt update examples in docs
2018-09-12 14:36:06 -07:00
Jon "The Nice Guy" Spriggs
ab2e6fded1 Show multi-line messages in debug documentation (#23000)
* Show multi-line messages in debug documentation

* Add two-line entry
* Indicate that jinja2 filters are not applied here

* Fix to incorrect documentation change
2018-09-12 16:55:48 -04:00
Ferdinand Holzer
3c083837c0 Clarify how java_cert checks keystore certificates (#26567) 2018-09-12 15:51:37 -05:00
Dag Wieers
310b0a2521 Docs: Make docsite rebuilds smarter/faster (#45062)
* Make the following scripts  idempotent so that we only have to rebuild changed docs, not all docs:

  * plugin_formatter
  * generate_man
  * dump_keywords.py
  * dump_config.py
  * testing_formatter.sh
2018-09-12 13:50:36 -07:00
Tim Rupp
e266a24263
Fixes bugs in the bigip_software modules (#45577)
This patch makes hotfix code work, where before, only base images
were working
2018-09-12 15:56:43 -04:00
Brian Coca
1ed57f1f64 moving from with_ff to just ff (#44847) 2018-09-12 15:35:04 -04:00
Evert
f7ef06e849 Added a note regarding the delegate_facts option. (#25257)
* Added a note regarding the delegate_facts option with a link to documentation
2018-09-12 14:30:05 -05:00
Richard Schwab
ea8924f744 Make it clear that recurse only applies to state=directory (#40222)
This would otherwise cause confusion as it could be interpreted as only changing attributes for directories (and not files inside).

+label: docsite_pr
2018-09-12 13:00:49 -04:00
Anil Kumar Muraleedharan
ac58c36ad0 Lenovo cli bugfixes (#45278)
* To change all CLIs present in the code to latest CNOS CLI. One bug of executing with Lenovo Jakku switch is also getting fixed.

* To change the file names as the commands have changed from display to show

* To change to new CLI in test_cnos_comand.py as well
2018-09-12 10:31:45 -04:00
thetuxkeeper
11cfa96797 fixing bytes <-> str regexp issue in cloudengine (#45285) 2018-09-12 09:59:42 -04:00
abirami-n
06fd9820a3 Fixes handling of terminal_initial_prompt on dellos6 and dellos9 devices (#45273)
* Fix terminal initial prompt on dellos6 and dellos9

* Fix_pylint
2018-09-12 19:28:32 +05:30
Nathaniel Case
eaf01d321f
eos: Don't error on VLAN missing warning (#45433) 2018-09-12 09:55:23 -04:00
Ghilli3
6040175186 Initial commit of fmgr_sys_proxy.py (#45518) 2018-09-12 19:18:27 +05:30
Zim Kalinowski
73c8041ec0 Azure load balancer crash fix (#45546) 2018-09-12 16:25:35 +08:00
Zim Kalinowski
111febe62e extended vmss facts (#45535) 2018-09-12 13:22:47 +08:00
Brian Brooks
0198d93f68 Update keycloak_client.py (#45505)
Slightly improve wording about lack of input sanity checking on API calls.

+label: docsite_pr
2018-09-12 06:22:54 +02:00
Zim Kalinowski
821c27cefb fixed tag support in autoscale facts (#45533)
* fixed tag support in autoscale facts

* forgot to add tags to arg spec
2018-09-11 23:00:58 -04:00
Deepak Agrawal
81214409cf
asa_config/ios_config: diff strict does not work with multiple parents (#45150)
* multiple parents issues in diff

* Integration tests for missing functionality

* add testcase for other platforms. vnxos does not support qos so need to find a command chain on v-nxos for multiple parets. junos uses on-device diff so should not need this.

* Fix for issue when any candidate parent did not meet the exact line in running-config

* DCI runs eos_config without become flag
2018-09-12 07:50:24 +05:30
Michael Scherer
004621ef8e Fix useless comparaison between 2 constants (#45524)
Found with https://lgtm.com
2018-09-11 19:37:50 -04:00
Jose Delarosa
197059b4a2 Update the root URI to match the DMTF specification (#45295) 2018-09-11 19:15:59 -04:00
Kerry
bf90a44468 Clarify the creates and removes options (#45485)
* Clarify the creates and removes options

The description for the creates and removes options were worded poorly. This change improves readability and is easier to understand.

 Double negatives are BAD

+label: docsite_pr

* Fix trailing whitespace
2018-09-11 15:45:19 -05:00
William
2ea9cfcd52 Fix python 3 compatibility for network id lookup (#45467)
Due to a change in python 3 filters return filter instead of list. This breaks the network name to id lookup for the docker_swarm_module. By wrapping it in list it ensures it is a list when returned and the id is extracted.
2018-09-11 15:45:42 -04:00
Sloane Hertel
e5269c047c [AWS] cloudfront_distribution - fix method name from 'validate_distribution_id_from_caller_reference' to 'validate_distribution_from_caller_reference' and set distribution_id to the distribution's key 'Id' (#45498) 2018-09-11 15:08:30 -04:00
Matt Martz
5785de582f
Fix logic to not re-download existing files when force=no (#45495)
* Fix logic to not re-download existing files when force=no. Fixes #45491

* Reduce logic complexity
2018-09-11 13:56:13 -05:00
Nathaniel Case
b22b07e300 Fixup network connection documentation (#45487)
* Fixup network connection documentation similar to suggestions in #45224

* Another tpyo
2018-09-11 14:23:38 -04:00
Matt Clay
ae4d5e3257 Avoid duplicate Azure storage account types. 2018-09-11 10:37:48 -07:00
David Rodríguez
600c7ac108 Fix remote checksums when paths have leading dots (#45287)
* Fix remote checksums with paths have leading dots

* Fix result recorded from the wrong file

* Add changelog fragment
2018-09-11 12:47:29 -04:00
Michael Scherer
804d574d1f Add documentation for the modify command, by giving a example (#19699) 2018-09-11 11:38:39 -04:00
Sam Doran
03414727ba Add documentation about patterns with commas to find module (#45360)
Thanks @samdoran  for the example and clarification!
2018-09-11 11:04:17 -04:00
Yuwei Zhou
fa04387550 fix the autoscale resource id (#45477)
* fix the autoscale resource id

* Update main.yml
2018-09-11 18:52:43 +08:00
James Cassell
211aeebd0d remove unused templar._clean_data() (#42739) 2018-09-11 09:11:03 +02:00
Zim Kalinowski
8a221d81dd fixing facts for mysql server (#45374) 2018-09-11 14:27:50 +08:00
Harald Albers
796d8b5dc8 VMware: Fix wait_for_task backoff behavior (#45429)
Signed-off-by: Harald Albers <github@albersweb.de>
2018-09-11 09:58:53 +05:30
Jordan Borean
01398f61d5
Win deprecate 2.8 (#45473)
* Remove deprecated/expired functionality

* win:_msi: Remove the win_msi module

* removed some missed deprecated return options and added porting guide reference

Co-authored-by: dagwieers <dagwieers@users.noreply.github.com>
2018-09-11 14:23:48 +10:00
Jordan Borean
ec6d82435f
win_scheduled_task: add deprecation warning for repetition format (#45468)
* win_scheduled_task: add deprecation warning for repetition format

* fixed up sanity issues
2018-09-11 14:22:57 +10:00
Mike Klebolt
ee8a10b87d Fixes authentication error when ansible_user is a local account and computer is already joined to domain (#44270)
* Fixes authentication error when ansible_user is a local account and computer is already joined to domain

* recommended fixes
2018-09-11 13:20:45 +10:00
Jordan Borean
3371a779b6
win_group_membership - fix random issue with CI on 2012 R2 (#45462) 2018-09-11 13:07:43 +10:00