cmueller/ansible
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity
39601 commits 47 branches 390 tags 440 MiB
Commit graph

102 commits

Author SHA1 Message Date
Trishna Guha
96346938ee
nxos_vlan refactor to support non structured output (#43805) 
* nxos_vlan refactor to support non structured output

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* unittest fix

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* minor fixes

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* use check_rc

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* address review comment

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* remove additional return statement

* address Nate's review

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
 2018-08-10 21:03:56 +05:30
Trishna Guha
09ae1ec308
cliconf refactor eos, nxos fix (#43596) 
* cliconf refactor eos and nxos fix

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* move nxos replace check to plugins

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* address review comment

* fix shippable
 2018-08-02 16:34:48 +05:30
Joren Vrancken
b954917761 Surround top-level function and class definitions with two blank lines. 2018-07-31 12:06:56 -07:00
tstoner
2c3d418e53 Nxapi ssl (#42905) 
* NXAPI ssl ciphers & protocols default values

* TLSv1, TLSv1.1, TLSv1.2 and weak cipher support

* NXOS NXAPI weak/strong cipher & TLSv 1.2, 1.1 & 1.0 support

* Version checking for strong/weak ciphers & TLS 1.2, 1.1 & 1.0 support

* Cleaned up erroneously committed changes.

* Specific NXOS platform checking for nxapi ssl ciphers & protocols

* Fixed ansibot reported errors.

* Resolved ansibot reported error.

* Added network_os_version to mocked up N7K unit test device_info

* Calling get_capabilities() once in main and passing results into methods.

* Removed raising exceptions when platform capabilities return None
per reviewers request. Skipping nxapi ssl options when capabilities
are None and generating a warning when these options are skipped

* Cleaned up explicit checks for None/not None
 2018-07-27 22:10:39 +05:30
Ganesh Nalawade
af3f510316
nxos cliconf plugin refactor (#43203) 
* nxos cliconf plugin refactor

Fixes #39056

*  Refactor nxos cliconf plugin as per new api definition
*  Minor changes in ios, eos, vyos cliconf plugin
*  Change nxos httpapi plugin edit_config method to be in sync with
   nxos cliconf edit_config

* Fix CI failure

* Fix unit test failure and review comment
 2018-07-27 11:05:40 +05:30
Nathaniel Case
82dfa542c2
Replace bogus (but routeable) ip addresses with RFC 5737 example addresses (#40554) 
* Remove 1.1.1.1 from *_config tests

* remove from *_smoke and *_system

* Miscellaneous other tests

* Remove from module documentation as well

* Remove from unit tests as well

* Remove accidental duplication from rebase
 2018-05-30 13:03:20 -04:00
James Mighion
d9533c3cbf Adding changed option to save_when (#40640) 
* Adding changed option to save_when

* Fixing version when changed was added.
 2018-05-24 22:18:59 +05:30
Matt Clay
8deced3e04
Fix shebangs and file modes and update tests. (#40563) 
* Add execute bit sanity test and apply fixes.
* Add shebang test for `lib` dirs and apply fixes.
* Shebang and execute bit cleanup.
 2018-05-22 14:25:36 -07:00
saichint
dabe5e6d07 fix nxos_hsrp issues (#38410) 
* fix nxos_hsrp issues

* shippable fix

* add examples for md5 auth
 2018-04-09 23:54:05 -04:00
Trishna Guha
2fbfce06e7
Fix nxos_interface multiple issues (#36827) 
* fix interface_type

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* fix setting mtu, doc for state check param, doc for params applicable for ethernet intf

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* speed idempotence and add unittest

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* fabric_forwarding_anycast_gateway applicable for svi type intf only

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* fix speed

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
 2018-03-01 10:56:16 +05:30
rahushen
e24c547a3a Fixes for the N3500 platform that uses the A8 image (#36261) 
* fix nxos_l3_interface tests as n35 doesn't support ipv6

* add terminal dont-ask to nxos_feature and nxos_lldp

* put interfaces in L2 mode for N35

* fix nxos_feature unit-tests
 2018-02-17 10:16:03 +05:30
saichint
75a34f6668 fix nxos_bgp_af issues (#36147) 
* fix nxos_bgp_af issues

* shippable fix

* review comments

* shippable error fix
 2018-02-16 09:34:24 +05:30
saichint
c7305393a3 fix nxos_evpn_vni issues (#35930) 2018-02-09 13:02:41 +05:30
saichint
80fcfdc0d1 fix nxos_vpc issues (#35868) 2018-02-08 18:50:37 +05:30
saichint
dc35baa8db fix nxos_pim_interface issues (#35405) 
* fix nxos_pim_interface issues

* add absent test for pim_interface
 2018-01-31 10:51:11 +05:30
Trishna Guha
a65f702155
add config option to replace argument (#34342) 
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
 2018-01-15 21:17:02 +05:30
Trishna Guha
df8b01aaf7
Handle platform os version for sandbox nxos_nxapi (#34490) 
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
 2018-01-11 21:12:00 +05:30
Trishna Guha
5e6b2495c0
Convert nxos_vrf to DI module (#34274) 
* Convert nxos_vrf to DI module

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* Add purge example and improve logic

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* revert version_added for rd param

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* update test to use network_cli

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
 2018-01-08 10:10:34 +05:30
Trishna Guha
9d2182bcf8 Deprecate nxos_switchport and Add nxos_l2_interface DI module (#33813) 
* Deprecate nxos_switchport

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* Add nxos_l2_interface DI module

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* pep8 fixes

* aggregate test for nxos_l2_interface

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* revert nxos_switchport test change

* gundalow's comment

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
 2018-01-05 07:44:02 +00:00
bdowling
552d1df901 Adds parents to mutually_exclusive with src for *_config modules (#33957) 
* mutually_exclusive add - ios_config parents works with lines by not src

* mutually_execlusive parents,src added to all other net modules

* tests for mutually_exclusive parents,src and whitespce removal
 2018-01-03 09:47:12 -05:00
Trishna Guha
80ba767204
Convert nxos_interface to DI (#34240) 
* Convert nxos_interface to DI

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* Add integration test

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* commit for ganeshrn's comment

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
 2017-12-28 16:41:09 +05:30
Trishna Guha
60f3649ebd
Convert nxos_vlan to DI module (#31866) 
* Convert nxos_vlan to DI

* fix conflict

* push fix for qalthos's comment

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
 2017-12-21 14:08:33 +05:30
Trishna Guha
be89822bb5
Deprecate nxos_portchannel and add nxos_linkagg DI module (#33376) 
* deprecate nxos_portchannel

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* Add nxos_linkagg DI module

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* remove nxos_portchannel unit test

* fix syntax issues

* fix ansible-doc failure

* update nxos_portchannel unittest

* minor fixes and integration test

* update nxos_linkagg
 2017-12-20 11:26:07 +05:30
Trishna Guha
3cce8dfafd
Deprecate nxos_ip_interface and Add nxos_l3_interface DI module (#33866) 
* Deprecate nxos_ip_interface module

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* Add nxos_l3_interface DI module

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* Add integration test

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* pep8 fixes

* Add nxapi cli test

* Improve complexity

* manage layer3 interface

* fix unit test
 2017-12-20 11:07:23 +05:30
Trishna Guha
27be2a0f5a
Handle nxos platform diffs with cli conf implementation (#34020) 
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
 2017-12-20 10:41:10 +05:30
Trishna Guha
9f86b923e9
[CLI_CONF] Refactor nxos module common library to use cliconf plugin (#31524) 
* refactor nxos modules

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* get_config update

* fix get_config

* update nxos module

* device_info

* fix conflict

* add failure message check

* pep8 fixes

* use get_capabilities to check cliconf

* Add logic to detect platform in get_capabilities and cache in module_utils

* return msg in edit_config

* fix conflicts

* make modules compatible

* fix nxos cliconf api

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* cache capabilities

* Update transport queries to get_capabilities in module level

* fix unit tests

* load_config error code

* remove unnecessary change

* Refactor nxos_install_os module
 2017-12-19 12:22:33 +05:30
Trishna Guha
25a465ffcb
loopback doesn't support passive_interface (#33252) 
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
 2017-11-27 22:56:16 +05:30
Mike Wiebe
95a2140f4b Use show command to support wider platform set for nxos_interface module (#33037) 
* Use show command to support wider platform set

* Fix unit tests
 2017-11-20 18:59:09 +00:00
Arnaud
84117e57ba nxos: 32 bits AS in as-dot format not recognized by regexp asn_regex (#30569) 
* added test for 32 bits AS

* Lint not happy.
 2017-11-20 10:09:16 +00:00
Pilou
a5c9726502 Unit tests: share common code (#31456) 
* move set_module_args to units.modules.utils
* unit tests: reuse set_module_args
* unit tests: mock exit/fail_json in module.utils.ModuleTestCase
* unit tests: use module.utils.ModuleTestCase
* unit tests: fix 'import shadowed by loop variable'
 2017-11-17 09:17:07 -08:00
Trishna Guha
3ee2501c83
multiple fixes nxos (#32903) 
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
 2017-11-14 15:23:11 +00:00
Trishna Guha
c40de24e9c
fix mtu check nxos_interface (#32880) 
Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
 2017-11-14 10:40:37 +00:00
Trishna Guha
f49555d494
nxos_bgp_neighbor_af feature idea disable-peer-as-check (#32665) 
* nxos_bgp_neighbor_af feature idea disable-peer-as-check

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* Add unit test

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
 2017-11-13 14:48:31 +00:00
Trishna Guha
e4052c1261
Add mtu option nxos_interface feature idea (#32680) 
* Add mtu option nxos_interface feature idea

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* Add unit test for mtu feature

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
 2017-11-13 14:48:04 +00:00
Kedar K
916e6be888 - Fix to return error message back to the module. (#31035) 2017-09-29 17:06:30 +05:30
Kedar K
4c21563ac6 - Adds sub-interface support for nxos_interface and nxos_ip_interface (#30830) 
- Support dot1 encapsulation on routed sub-interface
 2017-09-26 21:34:51 +05:30
Ganesh Nalawade
d72eb08902 Fix nxos provider transport warning issue (#30610) 
* Fix nxos provider transport warning issue

*  Add default value of transport arg in provider spec
*  Remove default value if transport arg in top level spec
   This ensure deprecation warning is seen only in case transport
   is given as a top level arg in task
*  Refactor nxos modules to reference transport value from provider
   spec

* Fix unit test

* Remove transport arg assignment in nxos action plugin

* As assigning transport value is handled in provider spec
  top level task arg assignment is no longer required
 2017-09-22 10:32:25 +05:30
Mike Wiebe
173c41aefe Rel240/fix nxos pim interface (#29885) 
* fix nxos_pim_interface

* Add integration test coverage and fix unit test

* Add clarifying comments

* Make ansibot happy
 2017-09-14 13:36:32 -07:00
Nathaniel Case
f84ff216b6 Generalize nxos_bgp event-history detection (#28890) 
* More general handling of event-history

* Update unit tests
 2017-09-06 17:37:44 -04:00
Nathaniel Case
8bfdbd0f73 nxos_bgp_neighbor: Fix regex &report warnings (#28888) 
* Fix over-detection of log-neighbor-as

* Report nxos warnings

* Update nxos_bgp_neighbor unit tests to test remove-private-as
 2017-09-01 15:17:42 -04:00
Mike Wiebe
d9fc3def94 Fixes #28779 eth_mode key error (#28782) 
* Fixes #28779 eth_mode key error

* Remove unused get_config references

* Addressed PR comment
 2017-08-29 17:07:46 -04:00
Nathaniel Case
64dac346c9 Fix nxos_pim_interface dr-priority handling (#28472) 
* Fix nxos_pim_interface dr-priority handling

* Prefer execute_show over `| json`

* Mock get_config

* Fix sparse-mode detection
 2017-08-29 14:42:09 -04:00
Mike Wiebe
3d46258cff Refactor/fix nxos_nxapi to use show run (#28675) 
* Refactor/fix nxos_nxapi to use show run

* Fix unit tests

* Python 3 compatibility
 2017-08-28 15:00:56 -04:00
Mike Wiebe
ec11cd2696 nxos_bgp_neighbor_af fix problem with advertise-map properties (#28413) 
* Fix problem with advertise-map properties

* Change limit_to back to run all tests

* Fix unit tests

* Move advertise_map out of get_custom_value
 2017-08-21 15:28:02 -04:00
Peter Sprygada
6886153b54 refactors nxos_vrf_af module (#28208) 
* refactors nxos_vrf_af module

fixes #27595

* fix up unit test cases

* add commands to result dict

* add route-target on afi create

* adds deprecation note to safi argument
 2017-08-16 10:11:12 -04:00
saichint
d69440c4ef Fix nxos_vpc issues (#28188) 
* fix for nxos_vpc issues

* fix unit tests

* clean documentation
 2017-08-15 12:08:55 -04:00
saichint
9d84a4e530 fix for nxos_ospf_vrf invalid cmd and ntp errors (#27977) 
* fix for nxos_ospf_vrf invalid cmd

* fix for nxos_ntp issues
 2017-08-14 16:09:16 -04:00
Trishna Guha
60ce6438e3 fix nxos_overlay_global idempotence (#28150) 
* fix nxos_overlay_global idempotence

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>

* modify nxos_overlay_global unittest

Signed-off-by: Trishna Guha <trishnaguha17@gmail.com>
 2017-08-14 16:09:53 +05:30
David Newswanger
a01aa6e9df Fix structured output not supported in nxos_pim_interface (#28125) 
* fixed unstructured error

* fix unit tests so they accept commands in dictionary form
 2017-08-14 12:34:05 +05:30
Nathaniel Case
a78f3faa6c nxos_bgp_neighbor_af does not want required_together (#26370) 
* nxos_bgp_neighbor_af does not want required_together

* fixup tests

* Fix max_prefix_* issues

* Require address-family

* Fix idempotency for next_hop_third_party

* Fix idempotency for allowas_in*

* Fix idempotency for *_in and *_out

* Reorder command generation again

`default` is first, then `max-prefix`, then booleans
 2017-08-09 15:54:34 -04:00