cmueller/ansible
1
0
Fork 0
Code Issues Pull requests Projects Releases Wiki Activity
7811 commits 47 branches 390 tags 440 MiB
Commit graph

530 commits

Author SHA1 Message Date
James Cammarata
627bd47fd3 Merge pull request #2055 from skylerbunny/patch-1 
Explanation of privilege escalation in notes
 2015-09-17 11:18:30 -04:00
Brian Coca
f12a2135ca Merge pull request #1525 from mjuenema/devel 
Removed check whether destination directory is writable from files/un…
 2015-09-14 09:01:36 -04:00
skylerbunny
489f3e67f1 Explanation of privilege escalation in notes 
An attempt to make clear how privilege escalation works with respect to the src/source host and dest/destination host. One existing note was incorporated into three new ones, iterating each.
 2015-09-12 13:13:48 -07:00
James Cammarata
310cf77edc Merge pull request #1947 from astorije/astorije/fix-acl 
Fix the acl module
 2015-09-11 13:06:19 -04:00
Brian Coca
68ab025dac minor doc fixes 2015-09-01 10:58:15 -04:00
Jérémie Astori
72fb7a0a17 Fix physical walk on acl module for Linux 
`-h` is for BSD [1] while `-P`/`--physical` is for Linux [2].
This commit fixes that option now that acl module is (temporarily)
only supported for Linux.
I will re-add `-h` when fixing BSD support.

[1]: http://www.freebsd.org/cgi/man.cgi?format=html&query=setfacl(1)
[2]: http://linuxcommand.org/man_pages/setfacl1.html
 2015-08-20 23:35:53 +00:00
Jérémie Astori
8eefd44aef Make sure entry is not sent when acl state=query 2015-08-20 22:59:00 +00:00
Jérémie Astori
0e659ad872 Make sure permission-less entries are accepted when state=absent 
Also, remove that try condition as, at that stage, no permissions with
other than 2 or 3 fields are sent to the function.
 2015-08-20 22:58:49 +00:00
Jérémie Astori
e95bcaeb8a Remove support for d[efault]: in entry permissions 
It is not documented in [the Ansible doc page][1] nor
[the BSD setfacl man entry][2] (which means it might not be compatible
with BSD) so removing it does not break the API.

On the other hand, it does not conform with POSIX 1003.1e DRAFT
STANDARD 17 according to the [Linux setfacl man entry][3] so safer to
remove.

Finally, the most important reason: in non POSIX 1003.e mode, only ACL
entries without the permissions field are accepted, so having an
optional field here is very much error-prone.

[1]: http://docs.ansible.com/ansible/acl_module.html
[2]: http://www.freebsd.org/cgi/man.cgi?format=html&query=setfacl(1)
[3]: http://linuxcommand.org/man_pages/setfacl1.html
 2015-08-20 22:22:28 +00:00
Brian Coca
f925f7e01f Merge pull request #1734 from freym/assemble-file-validation 
assemble: add file validation support.
 2015-08-19 11:15:21 -04:00
Jérémie Astori
3ac990556d Fix wrong expectation regarding entry format in acl module 2015-08-19 00:26:04 +00:00
Jérémie Astori
421d3f12cf Fix wrong processing of lines returned by setfacl in test mode 2015-08-19 00:25:18 +00:00
Jérémie Astori
50c6425673 Fix minor whitespace issues 2015-08-19 00:24:08 +00:00
Brian Coca
d61fde42ef updated encoding comment and expanded authors field 2015-08-14 22:01:05 -04:00
Brian Coca
d4a39d23df Merge pull request #150 from astorije/recursive_acl 
Add recursive support for ACL module
 2015-08-14 20:21:01 -04:00
Jérémie Astori
acfc2166b0 Set version number in recursive option description 2015-08-14 23:40:47 +00:00
Jérémie Astori
f8027a7f0a Ensure Python 2.4 compatibility and Linux-restricted support 
- Make build_entry compatible with Python 2.4
- Re-add missing warning/comment that was forgotten while refactoring
- Replace `all()` with a good ol' for-loop Python 2.4 compatibility
- Make a condition check more explicit (when `state` is `query`)
- Make sure this module can only be run with on a Linux distribution
- Add a note about Linux-only support in the documentation
- Set the version in which recursive support was added, 2.0
 2015-08-14 22:06:51 +00:00
Marius Gedminas
9bcf69a155 Fix obvious copy-paste error in module docs 2015-08-13 19:47:49 +03:00
Toshio Kuratomi
f39e5ffa1d Modify the default for synchronize's dest_port again 2015-08-05 13:05:59 -07:00
Toshio Kuratomi
ed2d8121b3 Update docs to reflect precedence for synchronize's dest_port param 2015-08-05 12:46:01 -07:00
Toshio Kuratomi
0071fd0bf7 Allow mode as a synchronize parameter (handled in action plugin) 2015-08-05 11:54:36 -07:00
Brian Coca
697307f88c Merge pull request #1670 from mikeputnam/issue-1643-gpl-header 
Add missing GPLv3 License header
 2015-07-30 14:39:44 -04:00
Toshio Kuratomi
19741d75eb Fi the local_rsync_path parameter used by the action plugin 2015-07-27 11:35:48 -07:00
James Cammarata
2bfddb015d In copy, set the mode before running th validation 
Because some programs that do validation (like visudo) may require
the permissions to be more restricted.

Fixes ansible/ansible#11385
 2015-07-26 14:40:22 -04:00
Brian Coca
9b8470ae95 minor doc fixes 2015-07-24 17:57:13 -04:00
Brian Coca
c688408385 fixed fragment docs 2015-07-24 17:54:02 -04:00
Jeff Widman
fd6518179b Move validate command into doc fragment and fix a few typos 2015-07-21 17:58:43 -07:00
Brian Coca
46fa43d9e0 Merge pull request #988 from isaacsimmons/ini-file-catch-interpolation-error 
Handle ini file properties that contain interpolation errors
 2015-07-20 20:49:23 -04:00
Patrik Lundin
3849a6d87b synchronize: add flag for verifying target host. 
Add the possibility to verify the target host using a "verify_host"
flag. It is disabled by default to not change the module behaviour.
 2015-07-19 13:22:07 +02:00
Brian Coca
2e77041dae Merge pull request #1654 from bcoca/file_dir_exceptions 
now captures any exceptions when trying to create directories
 2015-07-18 23:12:34 -04:00
Matthias Frey
68a3c6ece4 assemble: add file validation support. 2015-07-15 16:35:45 +02:00
Brian Coca
e916b04e91 Also document in example that unarchive download was added in 2.0 2015-07-14 10:19:17 -04:00
Mitchell Ludwig
9e11f5fd15 Improved stat documentation 2015-07-13 17:51:32 -06:00
Brian Coca
e33f093075 added ignore hidden to assemble 2015-07-09 00:28:10 -04:00
Jérémie Astori
ae1126c217 Add recursive support for ACL module (fix #5053, fix #5550, fix #7276) 2015-07-04 22:44:10 +02:00
Mike Putnam
6c0e264806 Add missing GPLv3 License header 
Fixes #1643
 2015-07-03 22:57:53 -05:00
Brian Coca
37506141a3 Merge pull request #1613 from verm666/issue-1575 
unarchive: fix work with 0 bytes archives
 2015-07-03 22:08:52 -04:00
Brian Coca
ed179fe379 now captures any exceptions when trying to create directories 2015-07-01 10:39:50 -04:00
Matthew Gilliard
910728f6c3 Handle race condition in directory creation. 
If we try to make a directory, but someone else creates the directory
at the same time as us, we don't need to raise that error to the user.
They asked for the directory to exist, and now it does. This fixes
the race condition which was causing that error to be raised, and
closes #1648.
 2015-07-01 15:22:45 +01:00
verm666
8deee99fcc unarchive: fix @bcoca's remarks, issue #1575 2015-06-30 08:14:30 -07:00
Brian Coca
433ca93c42 Merge pull request #1605 from vladimirmartsul/patch-1 
Add "force" description
 2015-06-30 07:54:48 -04:00
Brian Coca
13116d8ac0 Merge pull request #839 from gimoh/patch-1 
Do not insert extra newline if line already contains it
 2015-06-30 00:09:42 -04:00
verm666
725a7b2f59 unarchive: fix work with 0 bytes archives 
This change is in response to issue #1575
 2015-06-26 05:49:59 -07:00
Toshio Kuratomi
a5bba2488f Update version_added to 2.0 for the partial option 2015-06-25 12:44:20 -07:00
Vladimir Martsul
2206477b73 Add "force" description 
Add "force" option description
 2015-06-26 01:40:58 +06:00
Juan Picca
892212b9c4 synchronize module: add partial option 2015-06-25 14:18:49 -03:00
Toshio Kuratomi
c5324f54e6 Bump amount of file to download in a chunk to 64k. 2015-06-24 06:48:57 -07:00
Toshio Kuratomi
daa1472ccf Merge pull request #1448 from Jmainguy/unarchive_http 
add download ability to unarchive module
 2015-06-24 06:44:58 -07:00
Jonathan Mainguy
58ef71fc84 add download ability to unarchive module 2015-06-23 22:14:25 -04:00
Ritesh Khadgaray
81528e6834 Add the ability to grep for content 2015-06-18 20:38:19 +05:30
Markus Juenemann
0db3206cae Removed check whether destination directory is writable from files/unarchive.py. 
This check will prevent extraction of an archive if the archive does not
actually write to the destination directory but only writes to any writable
sub-directories of it. The underlying tar command will report errors
should it try to write to read-only directories.
 2015-06-16 10:37:38 +10:00
Greg DeKoenigsberg
2a5f0bde87 Proper author info for all remaining modules 2015-06-15 15:53:30 -04:00
Tristan Fisher
fa9d2f56df removes bool type from validate. 2015-06-01 15:59:25 -07:00
Tristan Fisher
98061a8f33 standardizes bools in argument_spec 2015-06-01 15:57:59 -07:00
jaypei
823adbbe36 use the right way to unescape line string 
Reference https://github.com/ansible/ansible/issues/10864
 2015-06-01 15:53:45 -07:00
Brian Coca
898f47e557 stat doc fix 
fixes #1371
 2015-05-26 15:22:56 -04:00
Greg Taylor
f38bf24c8a Adding directory creation example to file module. 2015-05-19 11:45:00 -07:00
Brian Coca
37532628c0 minor docfix 2015-05-19 10:44:17 -04:00
Brian Coca
e08eb7d7bc Merge pull request #1341 from tfishersp/devel 
standardizes bools in argument_spec
 2015-05-19 08:43:29 -04:00
Tristan Fisher
90b34e2b67 removes bool type from validate. 2015-05-18 18:44:31 -04:00
Toshio Kuratomi
81b476cd02 Update module "imports" to new style 
Fixes #1351
 2015-05-18 11:59:20 -07:00
Toshio Kuratomi
4b44aa4799 Fix use of codecs.escape_decode() 2015-05-17 09:28:14 -07:00
Toshio Kuratomi
142760658f Slightly more future-proof version of the lineinfile fix 2015-05-17 09:15:57 -07:00
Toshio Kuratomi
2eafbdd63a Merge branch 'fix-lineinfile' of https://github.com/jaypei/ansible-modules-core into jaypei-fix-lineinfile 2015-05-17 09:14:00 -07:00
Toshio Kuratomi
493144e06c Correct lineinfile documentation about double quoting... Hasn't been the case for years. 2015-05-15 14:13:27 -07:00
Tristan Fisher
db292e08b9 standardizes bools in argument_spec 2015-05-15 17:09:54 -04:00
Jason Paige
72e5e3a17a update flat description 
default behavior is to append the `hostname/path/to/file`, not prepend as currently stated by the flat arg docs
 2015-05-12 12:56:37 +01:00
Brian Coca
9a2e64b76d generic fix for Exceptions that heppen when trying to set permissions on extracted files 
fixes ansible/ansible#10934 which is really a corner case
 2015-05-11 13:18:05 -04:00
Ryan Hartkopf
06e2dcc108 synchronize: don't add ssh_args to ssh_opts when false or null 2015-05-04 08:58:05 -06:00
jaypei
fb34842a05 use the right way to unescape line string 
Reference https://github.com/ansible/ansible/issues/10864
 2015-04-29 19:59:55 +08:00
Brian Coca
c323ef9233 Merge pull request #1073 from sivel/sync-ssh-args 
Add ability to specify using ssh_args in synchronize
 2015-04-24 17:02:34 -04:00
Brian Coca
724b848c61 Merge pull request #1025 from bcoca/find 
1st draft find module
 2015-04-20 10:49:17 -04:00
Toshio Kuratomi
a19fa6ba48 Implement feature to return list of files in the archive 2015-04-15 09:25:23 -07:00
Brian Coca
a597992592 updated content description to discourage using as a tempalte module 2015-04-15 10:02:30 -04:00
Toshio Kuratomi
761fc8d277 Tar --diff only sends output to stderr if a file is missing. Handle that case 
Fixes #1064
 2015-04-15 05:05:41 -07:00
Brian Coca
1e026cb8ac find module 
updated to be able to get checksums and stat data, also now it only stats a file once so it should be quite faster on large file sets
 2015-04-13 21:54:20 -04:00
Matt Martz
ba7ad8e7f5 Add version_added for the use_ssh_args option 2015-04-03 10:27:33 -05:00
Matt Martz
f431b4817b Add ability to specify using ssh_args in synchronize 2015-04-03 09:42:23 -05:00
Brian Coca
de4c7f8ba6 switched to use python's built in os.separator vs using / 2015-04-03 09:06:58 -04:00
Toshio Kuratomi
515cd6666d Fix stat code to return name of group owning the file rather than name of group that the file's owner belongs to. 
Followup to #17
 2015-03-25 08:33:19 -07:00
Isaac Simmons
1f358721ff Handle ini file properties that contain interpolation errors in the initial values 2015-03-23 11:46:59 -04:00
Brian Coca
7683f36613 fix to return vals docs 2015-03-20 17:00:55 -04:00
James Bowes
1e36b6b7f6 Fix C() formatting typo in file module 2015-03-10 21:43:45 -03:00
Brian Coca
3da0aa9f08 Merge pull request #7 from Ernest0x/patch-1 
synchronize: use a single -F instead of -FF
 2015-03-06 15:13:37 -05:00
Toshio Kuratomi
559af8d88d Clarify the documented behaviour of insertbefore slightly. 2015-03-03 11:38:08 -08:00
Toshio Kuratomi
8ec43e5bbc Merge pull request #411 from p-tr0/devel 
Fix behavior when insert* doesn't match anything
 2015-03-03 11:32:18 -08:00
Brian Coca
0cc15866c2 Merge pull request #855 from bcoca/file_rellink_fixes 
fixed file module to use realpath when following links,
 2015-02-26 21:07:35 -05:00
James Cammarata
4646fdccd9 Merge branch 'feature/ini_file_change_mode_support' of https://github.com/blxd/ansible-modules-core into blxd-feature/ini_file_change_mode_support 2015-02-26 10:03:35 -06:00
Brian Coca
62fa77fbf9 fixed file module to use realpath when following links, 
readlink could be relative and fail in corner cases as per #852
 2015-02-26 08:43:24 -05:00
gimoh
d9f8fa56d8 Do not insert extra newline if line already contains it 
When using YAML multi-line strings, e.g.:

- lineinfile:
    dest: /tmp/foo
    line: >
      foo
      bar

the line already ends with a newline.  If an extra newline is appended unconditionally it will lead to inserting an extra newline on each run.
 2015-02-23 14:14:00 +00:00
blxd
2c520f31b3 Added check mode support to the ini_file module 2015-02-23 11:14:38 +00:00
Brian Coca
dbd8ea1e7d fixed typo on isgid 2015-02-20 09:57:39 -05:00
Brian Coca
6e654f2442 fixed issues with stats return docs as per feedback 2015-02-20 09:57:39 -05:00
Brian Coca
13cdadcc4d removed always for success, as data wont show on fail 2015-02-20 09:57:39 -05:00
Brian Coca
cbf42c95b2 draft for documenting module returns 2015-02-20 09:57:39 -05:00
mrsheepuk
410862d631 Doc change - make clearer usage for existing remote file 
Having read the doc for this module several times and completely missing that it can be used for existing remote archives, I propose this update to the wording to make clear from the top the two ways in which this module can be used.
 2015-02-17 13:48:59 +00:00
Gauvain Pocentek
6c1f40fea7 fetch: fix the flat parameter description 
ansible-doc expects the value of the description field to be a list,
otherwise the output is not correct. This patch updates the flat
description to be a list.
 2015-02-17 09:06:26 +01:00
Toshio Kuratomi
9e0959d600 Fix for recursion traceback in copy with relative paths 
This is a further fix for: https://github.com/ansible/ansible/issues/9092

when the relative path contains a subdirectory.  Like:

ansible localhost -m copy -a 'src=/etc/group dest=foo/bar/'
 2015-02-16 15:36:54 -08:00
Toshio Kuratomi
32e8595abf Merge pull request #790 from rhlmhrtr/file_documentation 
Fixed Documentation issue concerning file mode
 2015-02-16 13:21:13 -08:00
Rahul Mehrotra
98f869f345 Fixed Documentation issue concerning file mode when specified using numberical value 2015-02-16 10:04:32 -08:00