Commit graph

9210 commits

Author SHA1 Message Date
Brian Coca
ec6e75f1cc attempt to fix check mode when state='absent' 2016-12-08 11:23:21 -05:00
Mischa ter Smitten
10cae0acb3 The tilde expansion doesn't work with user.home 2016-12-08 11:23:21 -05:00
HAMSIK Adam
e04a4a4114 Use mutually_exclusive in AnsibleModule 2016-12-08 11:23:21 -05:00
otdw
8740b44205 removed required together for resource pools, clusters, and template deployments. fixes inability to deploy from template on vsphere clusters without resource pools. Also, resource pools and cluster should not be required together as they are independant in vsphere 2016-12-08 11:23:21 -05:00
Iiro Uusitalo
d6fc0ac5be uri.py is not using module_utils/urls.py from ansible core 2016-12-08 11:23:21 -05:00
HAMSIK Adam
3d3be5e91f Fix missing , 2016-12-08 11:23:21 -05:00
whiter
a5a9c92fcd Fixed dicts comparison for tags 2016-12-08 11:23:21 -05:00
Brian Coca
e4dd0d98d4 now captures any exceptions when trying to create directories 2016-12-08 11:23:21 -05:00
whiter
54b02ee0da ec2_vpc_net refactor 2016-12-08 11:23:21 -05:00
HAMSIK Adam
b7a13e263f Add version 2016-12-08 11:23:21 -05:00
HAMSIK Adam
05df069176 Add module parameter for security group name. This make ec2_elb_lb module consitent with others 2016-12-08 11:23:21 -05:00
Maksim Losev
482d8da2dc Use HostConfig object when creating container with Docker Remote API > 1.15
This is mlosev's patch (from #1208), rebased against devel as of
2790af2.  It resolves #1707, which was caused by an API incompatibility
between the docker module and server API version 1.19.
2016-12-08 11:23:21 -05:00
Lars Kellogg-Stedman
e031efd82c Do not erroneously mask exceptions
There was a catch-all `except` statement in `create_containers`:

        try:
            containers = do_create(count, params)
        except:
            self.pull_image()
            containers = do_create(count, params)

This would mask a variety of errors that should be exposed, including
API compatability errors (as in #1707) and common Python exceptions (KeyError, ValueError, etc) that could result from errors in the code.

This change makes the `except` statement more specific, and only attempts to pull the image and start a container if the original create attempt failed due to a 404 error from the docker API.
2016-12-08 11:23:21 -05:00
Lars Kellogg-Stedman
6116e4cdab docker: permit empty or false pid
The `docker` Python module only accepts `None` or `'host'` as arguments.
This makes it difficult to conditionally set the `pid` attribute using
standard Ansible syntax.

This change converts any value that evaluates as boolean `False` to
`None`, which includes empty strings:

    pid:

As well as an explicit `false`:

    pid: false

This permits the following to work as intended:

    - hosts: localhost
      tasks:
      - name: starting container
        docker:
          docker_api_version: 1.18
          image: larsks/mini-httpd
          name: web
          pid: "{{ container_pid|default('') }}"

If `container_pid` is set to `host` somewhere, this will create a
Docker container with `pid=host`; otherwise, this will create a
container with normal isolated pid namespace.
2016-12-08 11:23:21 -05:00
Brian Coca
9e54efd3fd fixed version added, reworded description a bit 2016-12-08 11:23:21 -05:00
Brian Coca
16a4ff3462 fixed minor doc issues 2016-12-08 11:23:21 -05:00
Brian Coca
0cab021168 Revert "Revert "ec2_lc - include all launch config properties in the return"" 2016-12-08 11:23:20 -05:00
Brian Coca
af8ded66cc Revert "ec2_lc - include all launch config properties in the return" 2016-12-08 11:23:20 -05:00
Toshio Kuratomi
a655241488 Minor touch ups of vsphere_guest code. 2016-12-08 11:23:20 -05:00
Brian Coca
60d160a2e9 Also document in example that unarchive download was added in 2.0 2016-12-08 11:23:20 -05:00
Mitchell Ludwig
b664603a4d Improved stat documentation 2016-12-08 11:23:20 -05:00
Frank van Tol
39e24e89f4 Remove default port value, it does not work in _requires_destroy_and_create logic
When creating a Redis cluster, every run it gets destroyed and recreated because the port number of memcached is used as the default.
2016-12-08 11:23:20 -05:00
Frank van Tol
6655cd89c4 Update elasticache.py 2016-12-08 11:23:20 -05:00
Frank van Tol
426f93a291 Remove default for engine_version
Redis and memcached have different engine version numbering, there can not be a shared default value.
2016-12-08 11:23:20 -05:00
Nicholas O'Connor
b95cb3f4e9 Created option snapshot_to_clone. When specified, snapshot_to_clone will create a linked clone copy of the VM. 2016-12-08 11:23:20 -05:00
Apoorva Kulkarni
1f35e578b4 s3 module: Add missing version tag to "encrypt" parameter 2016-12-08 11:23:20 -05:00
Chris Church
31a01305ba Set force=yes as the default, add force parameter to module docs. 2016-12-08 11:23:20 -05:00
James Cammarata
5efeeb156b Correctly default crypt_scheme in htpasswd 2016-12-08 11:23:20 -05:00
Chris Faulkner
18b157fbac Report change status on django_manage collectstatic. 2016-12-08 11:23:20 -05:00
Evan Carter
d3ef622627 Adding default cooldown to AWS ASG 2016-12-08 11:23:20 -05:00
vanga
ddd399fe7a Throw error if encryption is set while passing a snapshot id 2016-12-08 11:23:20 -05:00
Chris Meyers
0dbf41e740 ensure password or ssh cert specified 2016-12-08 11:23:20 -05:00
Tom Paine
e97124d609 Update vsphere_guest.py 2016-12-08 11:23:20 -05:00
acaveroc
dda41fd95a Add version_added and type of parameter 2016-12-08 11:23:19 -05:00
acaveroc
2c6f69c95e Assorted minor bug fixes
- Modified data type for port definition from string to integer
- Modified login_host default value for compatibilize with port definition according with MySQL Documentation (https://dev.mysql.com/doc/refman/5.0/en/connecting.html)
2016-12-08 11:23:19 -05:00
acaveroc
1283fdd118 Add port definition support for mysql_vars module 2016-12-08 11:23:19 -05:00
Joel Thompson
f1ab33ad7b Adding ability to filter AWS Route 53 private hosted zones by attached VPC 2016-12-08 11:23:19 -05:00
Hennadiy (Gena) Verkh
098126807d Update uri.py
Added methods 'TRACE', 'CONNECT' from https://www.rfc-editor.org/rfc/rfc2616.txt, section 5.1.1
Added method 'REFRESH'
2016-12-08 11:23:19 -05:00
Tal Auslander
8766641871 use ConvertTo-Bool for the force parameter 2016-12-08 11:23:19 -05:00
Tal Auslander
64f19fc4c6 stop reading from url on error 2016-12-08 11:23:19 -05:00
Tal Auslander
9c6d829991 add force parameter to win_get_url 2016-12-08 11:23:19 -05:00
Tal Auslander
26a54897a2 win_get_url re-download file only if modified 2016-12-08 11:23:19 -05:00
Hennadiy (Gena) Verkh
852c232b2d Removed method restriction in uri module 2016-12-08 11:23:19 -05:00
Ian Babrou
9219aeaaeb Pulling missing docker image before doing anything 2016-12-08 11:23:19 -05:00
Nic O'Connor
c68d1ffa60 Added the ability to Linked_clone from snapshot 2016-12-08 11:23:19 -05:00
Simon Olofsson
a3cb6d2f16 Add option docker_user for docker module.
docker_user can be used to specify the user or UID to use within the
container.
2016-12-08 11:23:19 -05:00
Iiro Uusitalo
b92dabb9fb Refactor force basic auth, now all modules which use fetch_url() can use force_basic_auth 2016-12-08 11:23:19 -05:00
Toshio Kuratomi
05be82183f Add notes about loop squashing and 1.9.2 change to install packages in one yum transaction 2016-12-08 11:23:19 -05:00
Monty Taylor
8e26a7ae17 Fix a small typo in parameter processing 2016-12-08 11:23:19 -05:00
Brian Coca
f8f4a7dcdf added ignore hidden to assemble 2016-12-08 11:23:18 -05:00
Jesse Keating
16381fb5c0 Plumb ipv6 modes into os_subnet
Shade already supports these, we just need to plumb them into the module
code.
2016-12-08 11:23:18 -05:00
Jesse Keating
72809ac329 Fix up docs 2016-12-08 11:23:18 -05:00
Sean Chittenden
4c8b573e2c Fix group mod and group add for FreeBSD 2016-12-08 11:23:18 -05:00
Juho-Mikko Pellinen
29620b78fa Change the default flag value to None to prevent AWS complaining: "Instance creation failed => InvalidBlockDeviceMapping: the encrypted flag cannot be specified since device /dev/sda1 has a snapshot specified." 2016-12-08 11:23:18 -05:00
Monty Taylor
530f12035b Update docstring to show port ranges as optional 2016-12-08 11:23:18 -05:00
David Shrewsbury
789c1fcbe7 Correct port matching logic
Port matching logic did not take into account recent shade change
to equate (None, None) to (1, 65535) when Nova is the backend.

Also, this encapsulates the port matching logic into a single function
and heavily documents the logic.
2016-12-08 11:23:18 -05:00
Flyte
2f46364921 Provide correct kwargs to rds2 connection when making a final snapshot 2016-12-08 11:23:18 -05:00
David Shrewsbury
387fe5b0e7 Change required parameters for rules module
The ports and protocol are no longer required (and now depends on
a new version of shade).
2016-12-08 11:23:18 -05:00
Davide Guerri
531b93490b Fix reuse argument documentation 2016-12-08 11:23:18 -05:00
Davide Guerri
95cfe3da96 Update os_floating_ip with new shade methods 2016-12-08 11:23:18 -05:00
Monty Taylor
4f2028439f Use int in the parameter list instead of casting 2016-12-08 11:23:18 -05:00
dagnello
2c3fc61357 Resolving issues in rule comparison algorithm
Port range min/max values are at times represented as string and
compared to int equivalents.  This fix explicitly ensures all
port range values are ints for proper comparisons.
2016-12-08 11:23:18 -05:00
David Shrewsbury
e7dd93c5c1 Compare ports as strings
Ports as returned from shade are ints. They are strings as they come
in to the module.
2016-12-08 11:23:18 -05:00
David Shrewsbury
14212c37e2 Fix syntax error 2016-12-08 11:23:18 -05:00
Monty Taylor
60102e36e2 Return rule object 2016-12-08 11:23:18 -05:00
David Shrewsbury
174254a423 Update secgroup rules module for latest shade
This allows the rules module to work against either nova or neutron
for handling security groups. New parameters for 'direction' and
'ethertype' are added.

Check mode is supported with this version.
2016-12-08 11:23:18 -05:00
David Shrewsbury
fcc1d643f6 Recongnize None and -1 port equivalency
shade 0.7.0 represents disabled min/max ports as None (in the
neutron style) rather than -1. Recognize this as the same as -1.
2016-12-08 11:23:17 -05:00
David Shrewsbury
b42a9d56e6 Fix id value reference 2016-12-08 11:23:17 -05:00
David Shrewsbury
f02ec15c17 Update rules mode for latest shade
Shade 0.7.0 normalized the security group data that is returned,
when using nova, to look more like neutron security group data.
This adjusts for that change.
2016-12-08 11:23:17 -05:00
dagnello
ecef2aadba Minor fixes for os_security_group_rule module
Was not able to use this module as it was.  The changes submitted
resolved the issues I ran into in order to get it working.
2016-12-08 11:23:17 -05:00
Davide Guerri
2d7dbc5d0c Fix invalid syntax in openstack_module_kwargs call 2016-12-08 11:23:17 -05:00
Monty Taylor
9acc891477 Fix example code syntax 2016-12-08 11:23:17 -05:00
0tmc
6e4c5e0a12 Use of proper fstab file on FreeBSD 2016-12-08 11:23:17 -05:00
Monty Taylor
a657e80bc8 Add OpenStack Floating IP Module
Also deprecate the two old quantum floating ip modules.
2016-12-08 11:23:17 -05:00
Monty Taylor
8d5e43c14f Add OpenStack Security Group Rule module 2016-12-08 11:23:17 -05:00
Juho-Mikko Pellinen
321244d881 Remove empty aliases 2016-12-08 11:23:17 -05:00
Juho-Mikko Pellinen
54af79692a Add version number 2016-12-08 11:23:17 -05:00
Juho-Mikko Pellinen
f016cb556b Fix hosted_zone_id after rebase. 2016-12-08 11:23:17 -05:00
Juho-Mikko Pellinen
3f2d1e6bfa Add support for specifying unique hosted zone identifier 2016-12-08 11:23:17 -05:00
Scott Miller
62b6cf85d3 Update cloudformation.py
Fix for inaccurate phrasing
2016-12-08 11:23:17 -05:00
Brian Coca
e7dc05df11 updated upgrade to a more sensible default as the previous was prone to confusion fixes #1667 2016-12-08 11:23:17 -05:00
Robb Wagoner
848e9de950 remove double dict & fix increment bug 2016-12-08 11:23:16 -05:00
Mike Putnam
0e6e3e097e Upstream docs show launch_config_name as required.
http://docs.aws.amazon.com/AutoScaling/latest/APIReference/API_AutoScalingGroup.html

Fixes #11209

Ansible behavior is correct, this commit just updates the docs to
reflect that correctness.
2016-12-08 11:23:16 -05:00
verm666
ac40d9f41a fix authorized_keys in check_mode
This change is in response to issue #1515.
Original pull request #1580.

The original problem is: in authorized_key module you have no idea about users
which will be created by Ansible at first run. I can propose next two ways to
solve this problem:

  1. Combine modules system/user.py and system/authorized_key.py in one module
     (so you will know everything about users in that module)
  2. Use small workaround: add my commit and always provide 'path' parameter
     for authorized_key module during runs with --check option.
2016-12-08 11:23:16 -05:00
Matthew Gilliard
17a40aa259 Handle race condition in directory creation.
If we try to make a directory, but someone else creates the directory
at the same time as us, we don't need to raise that error to the user.
They asked for the directory to exist, and now it does. This fixes
the race condition which was causing that error to be raised, and
closes #1648.
2016-12-08 11:23:16 -05:00
Matt Martz
f33a8b09a9 Remove unnecessary imports in a docs only file for win_copy 2016-12-08 11:23:16 -05:00
Matt Martz
d47de74ade Replaced tabbed indentation with spaces for group module 2016-12-08 11:23:16 -05:00
Matt Martz
30d5c1166c Replaced tabbed indentation with spaces for subversion module 2016-12-08 11:23:16 -05:00
Matt Martz
a0f5ae8726 Replaced tabbed indentation with spaces for apt module 2016-12-08 11:23:16 -05:00
Matt Martz
3d28efaf7e Replace tabbed indentation with spaces for mysql_db module 2016-12-08 11:23:16 -05:00
Toshio Kuratomi
cf595b3c52 Fix indentation levels in os_keypair 2016-12-08 11:23:16 -05:00
Toshio Kuratomi
4c863187ad Few minor things from review of the pull request 2016-12-08 11:23:16 -05:00
verm666
6acfa5fcee unarchive: fix @bcoca's remarks, issue #1575 2016-12-08 11:23:16 -05:00
Toshio Kuratomi
432764b703 Add version that the profilename param was added 2016-12-08 11:23:16 -05:00
Jesse Keating
2b5af82706 Document auto_floating_ip argument 2016-12-08 11:23:16 -05:00
David Shrewsbury
3cd81d2dd3 Use newest documentation style for return value. 2016-12-08 11:23:16 -05:00
Jonathan Davila
f1027ae6bc no_log to iam password 2016-12-08 11:23:16 -05:00
David Shrewsbury
c4bc6dea13 Add a note about the return value. 2016-12-08 11:23:15 -05:00
Scott Miller
b43db1d2ff update docs for cloudformation 2016-12-08 11:23:15 -05:00
James Meickle
8197d7e640 Change uri debug example 2016-12-08 11:23:15 -05:00
Monty Taylor
c0190b0443 Fix dict syntax typo 2016-12-08 11:23:15 -05:00
Andreas Reischuck
3cc14a0a65 fixed win_file state=touch 2016-12-08 11:23:15 -05:00
ToBeReplaced
5e259a8dd9 Make ALL_IN_SCHEMA for tables affect views
ALL TABLES is considered to include views, so we must check for reltypes
'r' and 'v', not just 'r'. This bug was introduced due to using a
custom, backwards-compatible version of "ALL TABLES IN SCHEMA".
2016-12-08 11:23:15 -05:00
Robb Wagoner
372a2286db return health of instances and counts 2016-12-08 11:23:15 -05:00
verm666
b898cb656b unarchive: fix work with 0 bytes archives
This change is in response to issue #1575
2016-12-08 11:23:15 -05:00
Vladimir Martsul
db646757c1 Add "force" description
Add "force" option description
2016-12-08 11:23:15 -05:00
Patrick Roby
e638913c97 iterate through all keys in a more pythonic manner 2016-12-08 11:23:15 -05:00
Patrick Roby
bc5d79fc30 update documentation, adding new params 2016-12-08 11:23:15 -05:00
David Shrewsbury
341efbf7ae Update os_keypair for latest shade
Uses the latest version of shade for cleaner code. Also, always
return the key dict whether we create the key, or it already exists.
The example using public_key_file is corrected to use a full path
since ~ is not converted for us.
2016-12-08 11:23:15 -05:00
Evan Carter
98756144cf Add ClassicLink settings to EC2_launchconfig 2016-12-08 11:23:15 -05:00
Andrea Mandolo
ae1080d922 Added some block_device_mapping (disks) informations to EC2 instance module ouput 2016-12-08 11:23:15 -05:00
Andrea Mandolo
a8da674cf4 Added "EC2 instance" termination_protection and source_dest_check changeability at run-time 2016-12-08 11:23:15 -05:00
Tom Paine
df8013182e Parse out space characters in route53 value list
Fixes: https://github.com/ansible/ansible-modules-core/issues/992
2016-12-08 11:23:15 -05:00
Michael Weinrich
543cb13f42 Fix connection creation to allow usage of profiles with boto 2016-12-08 11:23:15 -05:00
Toshio Kuratomi
f422782180 Use module.fail_json() instead of sys.exit() 2016-12-08 11:23:14 -05:00
Toshio Kuratomi
53c840e275 Add testing of docs to the core repo 2016-12-08 11:23:14 -05:00
Brian Coca
b261fd8d3e added doc to note that git the command line tool is required for this moduel to function fixes http://github.com/ansible/ansible/issues/11358 2016-12-08 11:23:14 -05:00
Brian Coca
e91818ef77 updated docs to clarify use of exclusive 2016-12-08 11:23:14 -05:00
Roetman, Victor
fa612a14b1 apache2_module documetation update
requires a2enmod and a2dismod
2016-12-08 11:23:14 -05:00
Ash Wilson
9f12fd0a26 Default net to 'bridge' in container diff
This prevents an unnecessary reload when the `net` parameter is unspecified
(i.e. almost always).
2016-12-08 11:23:14 -05:00
verm666
9b3aa0a9d4 This change is in response to issue #133.
The original problem is: apt_repository.py connect to launchpad on
every playbook run. In this patch apt_repository.py checks if required
repository already exists or not. If no - paa will be added, if yes -
just skip actions.
2016-12-08 11:23:14 -05:00
Michael Weinrich
a0466f1f8d Add the option to pass a string as policy 2016-12-08 11:23:14 -05:00
Monty Taylor
869da89b35 Move the order of argument processing 2016-12-08 11:23:14 -05:00
Monty Taylor
377311db56 Add filter ability 2016-12-08 11:23:14 -05:00
Ed Hein
f11c451bfa Fix computation of port bindings. Port bindings configuration can be a list if several host ports are bound to the same guest port. 2016-12-08 11:23:14 -05:00
Davide Guerri
c1d7678cc2 Avoind using lookup() in documentation
lookup() is currently broken (current Ansible devel branch), so better to avoid
it in our examples.
2016-12-08 11:23:14 -05:00
Konstantin Gribov
8d91c3a61a Escape spaces, backslashes and ampersands in fstab
Fixes #530.

It's more generic than #578 which only fixes spaces escaping in name (target dir to mount).
Escaping is used in both `set_mount` (important for `src`, `name` and `opts`) and
`unset_mount` (for `name`).

It's shouldn't be used in `mount` and `umount` since `name` parameter is passed as array element
to `module.run_command`.

Signed-off-by: Konstantin Gribov <grossws@gmail.com>
2016-12-08 11:23:14 -05:00
Arata Notsu
cc76a479e1 Not use "is" to compare strings
As "is" tests whether if operands are the same object rather than
they have the same value, potentially causes a wrong result.
2016-12-08 11:23:14 -05:00
Bryan Fleming
6f8d60a5ed fixes #1120 - privileges using columns 2016-12-08 11:23:13 -05:00
Lucas David Traverso
20aa4c0cea django_manage: Use shebang in manage.py instead of hardcode python 2016-12-08 11:23:13 -05:00
Andrew Davis
4d4d911d6e ansible_facts reflects 1.8 output 2016-12-08 11:23:13 -05:00
Monty Taylor
0c0359798b Add OpenStack Keypair module
Also deprecate old nova_keypair module.
2016-12-08 11:23:13 -05:00
Ash Wilson
ea83727fcf Wait for process exit on detached=no. 2016-12-08 11:23:13 -05:00
Ian Clegg
f9c294f1ad Added support for comma seperated feature names in the name parameter of the win_feature module 2016-12-08 11:23:13 -05:00
Tagir Bakirov
8bd367eac7 added 'absent' option to supervisorctl 2016-12-08 11:23:13 -05:00
Stefan Junker
4ee972190b docker: Use a list instead of a dict for volumes according to the docker-py docs. Do not add host-binds to volumes list. 2016-12-08 11:23:13 -05:00
gimoh
fd69c5687b Do not insert extra newline if line already contains it
When using YAML multi-line strings, e.g.:

- lineinfile:
    dest: /tmp/foo
    line: >
      foo
      bar

the line already ends with a newline.  If an extra newline is appended unconditionally it will lead to inserting an extra newline on each run.
2016-12-08 11:23:13 -05:00
Jens Carl
9ad15cdae9 - List the name servers of a zone. 2016-12-08 11:23:13 -05:00
Alexis Seigneurin
53e9caa1d0 - 'name' should not be required so as to allow uninstalling a cron_file 2016-12-08 11:23:13 -05:00
Annika Backstrom
6b2c89a422 Force redownload if sha256sum does not match 2016-12-08 11:23:13 -05:00
Igor Khomyakov
03483d2ea5 Check if a service exists 2016-12-08 11:23:13 -05:00
Federico G. Schwindt
b6258a1e4c Document globbing support 2016-12-08 11:23:13 -05:00
sysadmin75
f096359608 ansible-modules-core #530 fix - Mount module does not accept spaces in mount point path 2016-12-08 11:23:13 -05:00
Chris Church
3048626d6e Update docs, add example of using django_manage to run other commands. 2016-12-08 11:23:13 -05:00
Stefan Junker
50fe57fff3 Fix bind-volumes on docker >= 1.4.0
If bind-volumes are submitted to docker >= 1.4.0 with the volumes set in addition to the binds, docker will create a regular volume and not bind-mount the specified path.
2016-12-08 11:23:13 -05:00
Federico G. Schwindt
fa463fb1b7 Allow globbing in creates= and removes= directives
Fixes 1904
2016-12-08 11:23:12 -05:00
Robb Wagoner
e025effc99 include all launch config properties in the return
make all properties available when registering the result
which is useful when wanting to launch a stand-alone instance based upon
an existing Launch Config.
2016-12-08 11:23:12 -05:00
Toshio Kuratomi
870446dd6b Update version_added to 2.0 for the partial option 2016-12-08 11:23:12 -05:00
Jonathan Davila
82b809f0e2 new vpc module. does not contain subnet or route table functionality.
changed name to ec2_vpc_net

refactored out IGW functionality
2016-12-08 11:23:12 -05:00
Juan Picca
81ea358b09 synchronize module: add partial option 2016-12-08 11:23:12 -05:00